MoinMoin: MoinMoinChat/Logs/moin-dev/2008-04-13

2008-04-13T00:23:37  <kikka> gn
2008-04-13T10:07:22  <zenhase> moin
2008-04-13T10:09:16  <dreimark> moin
2008-04-13T10:09:45  <kikka> moin
2008-04-13T10:48:41  <dreimark> zenhase: there are some people talking about wsgi on #moin
2008-04-13T10:53:59  <dreimark> moin johill
2008-04-13T10:54:06  <johill> moin
2008-04-13T10:54:43  <dreimark> do you have seen the after_auth session patch?
2008-04-13T10:55:01  <johill> yeah, afaict it has one small problem: you should be using the session storage adapter to remove it
2008-04-13T10:55:40  <johill> i.e. instead of caching.CacheEntry(request, 'session', session_name, 'farm').remove()
2008-04-13T10:56:39  <dreimark> ah, ok.
2008-04-13T10:57:02  <johill> self.dataclass(request, session_name).remove()
2008-04-13T10:57:20  <johill> eh, .delete
2008-04-13T10:57:20  <xorAxAx> TheSheep: ping
2008-04-13T10:57:48  <johill> dreimark: then it should be fine, and much thanks for digging into it
2008-04-13T10:58:15  <dreimark> :)
2008-04-13T10:58:44  <johill> actually
2008-04-13T10:58:45  <johill> hah
2008-04-13T10:58:48  <johill> it's much simpler
2008-04-13T10:59:48  <dreimark> johill: ? feel free to change it ;)
2008-04-13T11:00:38  <johill> http://moinmo.in/JohannesBerg/SessionFix
2008-04-13T11:00:51  <johill> can you try that? I don't have http-auth set up right now
2008-04-13T11:01:15  <dreimark> yes
2008-04-13T11:02:27  <johill> the session id doesn't need to change, after all
2008-04-13T11:02:37  <johill> we just need to remove the data from it
2008-04-13T11:03:21  <dreimark> that's true
2008-04-13T11:04:15  <johill> and the anon handling etc isn't necessary either since at that point we're logged in for sure
2008-04-13T11:04:21  <johill> although just under the new user
2008-04-13T11:15:43  <TheSheep> xorAxAx: I'll rate them today evening, I'm on a conference now, sorry
2008-04-13T11:16:01  <xorAxAx> TheSheep: i know :)
2008-04-13T11:16:07  <xorAxAx> TheSheep: i guess you didnt even visit the pypy talk
2008-04-13T11:16:25  <xorAxAx> because you are organizing the whole time, a pity :)
2008-04-13T11:19:22  <dreimark> johill: great!
2008-04-13T11:26:17  <dreimark> johill: do we really want session files starting with a  -
2008-04-13T11:29:00  <TheSheep> xorAxAx: no, I was on the pypy talk
2008-04-13T11:29:13  <TheSheep> xorAxAx:  was great
2008-04-13T11:29:20  <xorAxAx> TheSheep: good to know!
2008-04-13T11:29:48  <TheSheep> xorAxAx: there will be probably a more technical extra pypy session today
2008-04-13T11:29:57  <xorAxAx> cool
2008-04-13T11:30:37  <dreimark> TheSheep: where are you (which conf) ?
2008-04-13T11:30:57  <TheSheep> dreimark: RuPy in Poznań, Poland
2008-04-13T11:34:49  <dreimark> silverlight is restricted for ie ?
2008-04-13T11:36:42  <dreimark> TheSheep: greetings to christopher
2008-04-13T11:37:18  <TheSheep> dreimark: thanks, I'll pass them to him
2008-04-13T11:37:41  <TheSheep> dreimark: no, on the presentation the guy was showing it woring on Safari...
2008-04-13T11:37:51  <TheSheep> working
2008-04-13T11:42:22  <johill> dreimark: can you commit it? I have to run. do we care about session files starting with a -? we can just use a-zA-Z0-9 too, doesn't matter
2008-04-13T11:43:28  <dreimark> johill: yes can do after lunch
2008-04-13T11:44:10  <dreimark> (I don't have hg on the modem box)
2008-04-13T11:44:33  <johill> ok, I'll be out for a while longer, my granddad is celebrating his 88th birthday
2008-04-13T11:45:09  <dreimark> have fun ;)
2008-04-13T11:54:46  <dreimark> bbl
2008-04-13T11:59:51  <ThomasWaldmann> moin
2008-04-13T13:20:43  <zenhase> re
2008-04-13T13:21:04  <zenhase> dreimark: oh :o
2008-04-13T14:55:59  <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3498:1c113184a79b 1.7/MoinMoin/session.py:
2008-04-13T14:55:59  <CIA-47> MoinMoin.session: bug fix for http_auth for two user using one browser (invalida
2008-04-13T14:55:59  <CIA-47> ting session) (Johannes & Reimar)
2008-04-13T15:03:57  <dreimark> moin
2008-04-13T15:07:14  <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3499:b18ca3046da7 1.7/MoinMoin/session.py: MoinMoin.session: removed char "-" from possible session name chars
2008-04-13T15:09:51  <dreimark> ThomasWaldmann: converter/_tests/test_text_html_text_moin_wiki.py fails for me
2008-04-13T15:10:00  <dreimark> assert u' * {{{\n   test\n   }}}\n\n' == u' * {{{\n   test\n\n}}}\n\n'
2008-04-13T15:10:57  <ThomasWaldmann> nothing new
2008-04-13T15:11:16  <ThomasWaldmann> but you could rather fix the hits test you wrote recently
2008-04-13T15:12:16  <ThomasWaldmann> (or the code it tests for the case that it is not the test what's broken)
2008-04-13T15:15:48  <dreimark> how does it fail for you?
2008-04-13T15:17:53  <dreimark> ThomasWaldmann:
2008-04-13T15:20:14  * ThomasWaldmann runs py.test
2008-04-13T15:25:46  <ThomasWaldmann> dreimark:
2008-04-13T15:25:48  <ThomasWaldmann> E       assert result == expected
2008-04-13T15:25:48  <ThomasWaldmann> >       assert u'1' == '2'
2008-04-13T15:25:48  <ThomasWaldmann> [/home/tw/eclipse-ws/moin-1.7/src/MoinMoin/macro/_tests/test_Hits.py:106]
2008-04-13T15:26:15  <ThomasWaldmann> this is how it fails. i nuked tests/wiki/* before running the tests
2008-04-13T15:33:05  * dreimark looks
2008-04-13T15:42:22  <dreimark> ThomasWaldmann: doesn't fail on my nuked test wiki
2008-04-13T15:42:37  * dreimark fetches a new clone and tries again
2008-04-13T15:45:19  <dreimark> it doesn't fail on a new clone too
2008-04-13T15:49:24  <dreimark> ah
2008-04-13T15:54:04  * gizmach back from weekend and moin to all
2008-04-13T15:55:19  <dreimark> hi gizmach
2008-04-13T15:57:08  <zenhase> moin gizmach
2008-04-13T16:03:55  <dreimark> ThomasWaldmann: the docstring of test3 was wrong but it is doing right
2008-04-13T16:04:33  <dreimark> the page u'AutoCreatedMoinMoinTemporaryTestPageForHits' is two times saved
2008-04-13T16:05:21  <dreimark> does the last test work for you ?
2008-04-13T16:15:39  <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3500:b5b3f1a72b4e 1.7/MoinMoin/macro/_tests/test_Hits.py: macro._tests.test_Hits: fixed/added docstrings, removed from teardown_class purging event_log and related cache files.
2008-04-13T16:16:10  <ThomasWaldmann> the one i posted above is the only one failing there
2008-04-13T16:16:42  <gizmach> dreimark: /msg dreimark  I'm a bit confused about the translating part
2008-04-13T16:16:50  <gizmach> well
2008-04-13T16:17:04  <gizmach> I loged in at
2008-04-13T16:17:41  <gizmach> moinmaster
2008-04-13T16:18:01  <gizmach> and add myself to http://master.moinmo.in/MoinPagesEditorGroup
2008-04-13T16:18:41  <gizmach> but this one says to be immputable page http://master17.moinmo.in/MoinI18n/hr
2008-04-13T16:20:07  <dreimark> ThomasWaldmann: this means it fails filtering currentpage for SAVE
2008-04-13T16:21:04  <dreimark> or it knows only one page saved at this time while the next test does it for allpages right
2008-04-13T16:21:42  <dreimark> gizmach: this are two wikis
2008-04-13T16:22:13  <dreimark> ThomasWaldmann: has joined all previous users at the time he created both wikis
2008-04-13T16:22:29  <gizmach> dreimark: ;)
2008-04-13T16:22:36  <dreimark> we can use singelsign login (openid) with 1.7 (later)
2008-04-13T16:23:07  <gizmach> dreimark: I also loged in to the other one
2008-04-13T16:28:05  * ThomasWaldmann thought about running master16 and 17 from the same user_dir, but there are some changes in the user profiles and I didn't want to risk problems, so I just copied the user_dir.
2008-04-13T18:04:52  <CIA-47> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3501:159b08b1d9ff 1.7/MoinMoin/macro/_tests/test_Hits.py: macro._tests.test_Hits: removed dependencies of tests
2008-04-13T18:05:26  <dreimark> ThomasWaldmann: please test and please 0 failures
2008-04-13T18:39:30  <dreimark> gizmach: does it work now ?
2008-04-13T18:43:06  * ThomasWaldmann runs tests
2008-04-13T18:43:23  <gizmach> dreimark: yes now it's working :) I was mixing 1.6 and 1.7 so I was a bit confused :) Now it's everything ok
2008-04-13T18:52:06  <ThomasWaldmann> dreimark: no hits failures any more! :)
2008-04-13T18:53:42  <dreimark> hooray
2008-04-13T19:06:48  <dreimark> Do we have somewhere some docs about the last wikidicts changes
2008-04-13T19:06:58  <dreimark> e.g. DICTS_PICKLE_VERSION
2008-04-13T19:15:04  <ThomasWaldmann> for what do you need that?
2008-04-13T19:16:53  <dreimark> just readed the file and found the hint # Please increment if you have changed the structure.
2008-04-13T19:17:51  <ThomasWaldmann> it is just for invalidating
2008-04-13T19:36:20  <dreimark> bbl
2008-04-13T20:03:12  <TheSheep> dreimark: hehe, I aid hi to Christoph, but I couldn't pronounce your name :/
2008-04-13T20:03:19  <TheSheep> dreimark: so he had to guess
2008-04-13T20:05:11  <ThomasWaldmann> wb TheSheep :)
2008-04-13T20:05:21  <ThomasWaldmann> rupy is over?
2008-04-13T20:05:25  <TheSheep> ThomasWaldmann: thanks, yes
2008-04-13T20:05:36  <TheSheep> ThomasWaldmann: I just saw Chuck Smith to the station
2008-04-13T20:06:00  <TheSheep> Christoph's talk was great, a learned some new tricks
2008-04-13T20:06:07  <TheSheep> s/a/I
2008-04-13T20:07:16  <ThomasWaldmann> once you have recovered, please do some SOC scoring and request some mentorship.
2008-04-13T20:08:20  <TheSheep> ThomasWaldmann: yes, I'm sorry for the delay
2008-04-13T20:08:30  <ThomasWaldmann> (and please, score ALL projects. it can mean giving 0 points, of course. :)
2008-04-13T20:09:24  <ThomasWaldmann> (begin with those you care for :)
2008-04-13T20:09:24  <TheSheep> ThomasWaldmann: yes, I know, thanks
2008-04-13T20:10:52  <ThomasWaldmann> xorAxAx told google will give slots wednesday
2008-04-13T20:12:46  <xorAxAx> yep
2008-04-13T20:13:13  <TheSheep> ThomasWaldmann: I hope to finish by tomorrow
2008-04-13T20:13:59  <ThomasWaldmann> great :)
2008-04-13T20:31:22  * ThomasWaldmann tries to refactor the tests
2008-04-13T21:04:09  <dreimark> TheSheep:  did he guessed right?
2008-04-13T21:04:23  <TheSheep> dreimark: yes
2008-04-13T21:04:47  <TheSheep> dreimark: he's got very cool style of talking
2008-04-13T21:05:44  <dreimark> yeah
2008-04-13T21:06:35  <dreimark> he is the founder of pycologne too
2008-04-13T21:07:26  <TheSheep> wow
2008-04-13T21:23:04  * ThomasWaldmann renames gain_superuser_rights
2008-04-13T21:41:03  <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3502:02b73ceab324 1.7/MoinMoin/ (9 files in 3 dirs): tests: move code from MoinMoin._tests.common to MoinMoin._tests, rename gain_superuser_rights to become_superuser, add become_known and become_trusted
2008-04-13T21:42:41  <ThomasWaldmann> please everybody use the appropriate become_* for your tests. especially do not just call become_superuser if what you do in your tests does not require being a superuser
2008-04-13T21:44:39  <ThomasWaldmann> and if you change your tests, run them afterwards to check if they work as expected
2008-04-13T21:50:00  * dreimark is tired
2008-04-13T21:50:04  <dreimark> good night
2008-04-13T21:57:11  <ThomasWaldmann> gn dreimark
2008-04-13T21:59:25  <ThomasWaldmann> hmm, MoinMoin.security.AccessControlList _special_Known vs _special_Trusted looks suspicious
2008-04-13T22:00:34  <ThomasWaldmann> for Known we check if there is a userid for that name (why not just request.user.valid and request.user.name == name?)
2008-04-13T22:01:07  <ThomasWaldmann> for Trusted, I guess the code works, but request.user.valid could also be added to the if-clause
2008-04-13T22:05:19  <ThomasWaldmann> ah, the notification stuff is the point. when sending notifies it checks if <username> may "read", but that user is != request.user
2008-04-13T22:23:19  <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3503:383fda7ebfd1 1.7/MoinMoin/ (7 files in 3 dirs): tests: add some clarifications to become_trusted/become_valid, use become_trusted instead of become_superuser when it does not need superuser permissions
2008-04-13T23:08:09  <gizmo> moin
2008-04-13T23:08:30  <TheSheep> gizmo: moin
2008-04-13T23:08:37  <zenhase> gizmach is gizmo again :o
2008-04-13T23:08:47  <zenhase> (good evening btw.)
2008-04-13T23:10:56  <gizmo> zenhase: it wil be changed
2008-04-13T23:11:24  <zenhase> why?
2008-04-13T23:12:04  <gizmach> zenhase: cause I registered my nik -gizmach
2008-04-13T23:12:11  <gizmach> nickk
2008-04-13T23:12:59  <zenhase> hmm ok .. and i guess that gizmo is also already taken by someone else
2008-04-13T23:13:00  <gizmach> TheSheep: hi
2008-04-13T23:56:21  * ThomasWaldmann .oO(crappy tests!)