MoinMoin: MoinMoinChat/Logs/moin-dev/2008-06-05

2008-06-05T00:00:29  <mmihaljevic> good night
2008-06-05T00:31:04  <ThomasWaldmann> dreimark: a noaa.gov moin user on the mailing list
2008-06-05T08:19:38  <dreimark> moin
2008-06-05T08:19:46  * dreimark reads teh mailing list
2008-06-05T08:33:15  <ThomasWaldmann> moin
2008-06-05T10:41:43  <CIA-50> MelitaMihaljevic <melita.mihaljevic@gmail.com> default * 3665:bb58eec045b1 1.8/MoinMoin/auth/ldap_login.py: merged main
2008-06-05T10:41:53  <CIA-50> MelitaMihaljevic <melita.mihaljevic@gmail.com> default * 3666:479067b42c67 1.8/ (MoinMoin/auth/ldap_login.py docs/CHANGES): No new code commited
2008-06-05T10:42:01  <CIA-50> MelitaMihaljevic <melita.mihaljevic@gmail.com> default * 3667:4e59423375ce 1.8/docs/CHANGES: update CHANGES
2008-06-05T10:45:31  <ThomasWaldmann> gizmach: i suggest you do a hg diff before doing a commit
2008-06-05T10:45:51  <gizmach> ThomasWaldmann: :) I good suggestion
2008-06-05T10:46:05  <ThomasWaldmann> and please use your soc projects repo for your work, not the main branch
2008-06-05T10:46:22  <gizmach> ThomasWaldmann: dammit
2008-06-05T10:50:31  <ThomasWaldmann> (look into .hg/hgrc)
2008-06-05T10:50:57  <gizmach> ThomasWaldmann: I changed it now, but I wasn't thinking
2008-06-05T10:52:19  <dreimark> hi gizmach
2008-06-05T10:52:27  <gizmach> hi dreimark
2008-06-05T10:54:12  <dreimark> gizmach: you've seen that you have commited to the 1.8 branch and not to yours ?
2008-06-05T10:54:34  <gizmach> dreimark: yes really stupid thing :(((
2008-06-05T10:55:41  * dreimark has not seen ThomasWaldmann comment
2008-06-05T10:55:51  <dreimark> ok, who will do the revert?
2008-06-05T10:57:27  <ThomasWaldmann> dreimark: feel free (but don't make it worse :)
2008-06-05T10:59:58  * dreimark fetches a clone
2008-06-05T11:08:57  <dreimark> hg revert --rev 3664 docs/CHANGES MoinMoin/auth/ldap_login.py ?
2008-06-05T11:15:46  <ThomasWaldmann> could work (but should do the same as if just reverting all to that revision)
2008-06-05T11:16:02  <ThomasWaldmann> and use hg diff :)
2008-06-05T11:16:18  <dreimark> doing currently looks ok to me
2008-06-05T11:20:39  <CIA-50> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3668:1a5fe473e649 1.8/ (MoinMoin/auth/ldap_login.py docs/CHANGES): docs/CHANGES MoinMoin/auth/ldap_login.py reverted to changeset 3664:d027dd4948d7
2008-06-05T11:22:05  * dreimark lunch
2008-06-05T11:28:53  <ThomasWaldmann> gizmach: dreimark: and if hg tells you that your action would create new branches (but you did not want to create a new branch), then you are likely doing sth wrong
2008-06-05T11:33:32  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3669:86f8f213d044 1.8/ (61 files in 14 dirs): merge 2 heads
2008-06-05T12:26:03  <dreimark> ThomasWaldmann: it hasn't told me that
2008-06-05T12:26:34  <ThomasWaldmann> i guess melita got the msg :)
2008-06-05T12:35:17  <ThomasWaldmann> bbl
2008-06-05T13:25:20  <CIA-50> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com default * 4023:3dda3bedeeab 1.8-storage-cdenter/MoinMoin/storage/abstract.py: Corrected some issues I had due to non-matching method names. I really need tests. :)
2008-06-05T13:35:12  <johill> dennda: create_item should be abstract
2008-06-05T14:00:47  <zenhase> uhhh ... 2 hours until the presentation :o
2008-06-05T14:00:56  * zenhase is nervous
2008-06-05T14:04:31  <dennda> johill: Sorry, my connection is a bit sucky atm
2008-06-05T14:04:42  <dennda> johill: Why not provide some default behaviour?
2008-06-05T14:06:14  <johill> because then backend authors will try to use it at the expense of not having IDs ;)
2008-06-05T14:06:53  <dennda> Ok, luckily it's not hard to change that :)
2008-06-05T14:08:02  <dennda> johill: I am just writing my first tests with py.test. Shall I create a test-method for every method? (That includes all the raise NotImplementedError-methods)
2008-06-05T14:08:08  <dennda> with py.test.raises
2008-06-05T14:08:22  <johill> you can also use test generators
2008-06-05T14:08:48  <dennda> Ah yes, I read about them but can't remember exactly, let me read that again
2008-06-05T14:08:57  <johill> look at MoinMoin/_tests/test_wikiutil.py
2008-06-05T14:09:00  <dennda> But the general rule is to test all methods?
2008-06-05T14:09:09  <johill> e.g. testExtendedParserMultikey
2008-06-05T14:09:17  <johill> well, you probably want to test functional units
2008-06-05T14:09:29  <dennda> Sure
2008-06-05T14:09:48  <dennda> That's not the question
2008-06-05T14:10:06  <johill> then I misunderstood?
2008-06-05T14:11:33  <dennda> Sure I need to test the functional methods, that is methods that actually do something, but I wonder if there is some common rule to test all methods, even those that don't have actual behaviour (i.e. just raising NotImplementedError)
2008-06-05T14:13:47  <johill> not really, I don't think that's too useful
2008-06-05T14:13:52  <dennda> sweet
2008-06-05T14:14:11  <zenhase> hiho johill, hiho dennda
2008-06-05T14:15:41  <dennda> Hi
2008-06-05T14:15:58  <dennda> lecture starts
2008-06-05T15:48:52  <dreimark> mmihaljevic: hi
2008-06-05T16:41:55  <dreimark> ThomasWaldmann: I do wonder a bit about page creation and acls.
2008-06-05T16:42:19  <dreimark> if we have acl_rights_default = 'UserGroup:read,write,revert,delete All:read,write'
2008-06-05T16:44:22  <dreimark> one tried to save a page with the line acl Known: read,write
2008-06-05T16:44:47  <dreimark> in that case Known is a subset of All
2008-06-05T16:46:21  <dreimark> the PageEditor forbides saving.#
2008-06-05T16:47:08  <dreimark> hmm probably I have to enter the whole line of acl_rights_default to a page
2008-06-05T17:27:29  <ThomasWaldmann> if you have no admin rights, youcan't change or setup acls.
2008-06-05T17:39:57  <zenhase> re!
2008-06-05T17:40:14  <zenhase> *phew* finally done with my talk :D
2008-06-05T17:45:46  <ThomasWaldmann> dennda: +        self._metadata      = None          # XXX Will be loaded lazily upon first real access.
2008-06-05T17:45:53  <ThomasWaldmann> that's not pep8 compliant
2008-06-05T17:46:23  <ThomasWaldmann> (maybe not your fault, but please fix it while you work on it - in a separate changeset)
2008-06-05T18:17:33  <dennda> ThomasWaldmann: The whitespace?
2008-06-05T18:19:40  * dreimark founds a bug with attachments and blanks
2008-06-05T18:25:55  <dreimark> bbl
2008-06-05T18:28:49  <zenhase> don't found any new bugs ;)
2008-06-05T19:46:14  <ThomasWaldmann> dennda: yes
2008-06-05T20:02:49  <dennda> ThomasWaldmann: ok
2008-06-05T20:04:44  <ThomasWaldmann> it is also bad for diffs btw, if you want to keep that "tabular formatting" you might have to edit other lines if you add or remove some statement with some longer/shorter name to keep the layout. I guess that's the main reason why it is discouraged.
2008-06-05T20:06:23  <dennda> true
2008-06-05T20:06:28  <dennda> never thought about that
2008-06-05T20:06:31  <dennda> just found it more readable
2008-06-05T23:40:30  <dreimark> mmihaljevic: ping