2008-07-16T00:11:20 <zenhase> hmm, not much progress in the evening hours
2008-07-16T00:11:48 <zenhase> i will go to sleep now and then be up at 8:30 tomorrow
2008-07-16T00:20:00 <dreimark> xorAxAx: None
2008-07-16T00:35:53 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 175:377e5f674c66 1.7-extensions/data/plugin/parser/text_x_arnica.py: text_x_arnica: fixed wrong quoting of pagename
2008-07-16T00:40:27 <dreimark> johill: ThomasWaldmann is that idea for more tags ok ? http://moinmo.in/ReimarBauer/HelpOnArnica#tagsforimages
2008-07-16T07:08:55 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 176:27039f0d187c 1.7-extensions/data/plugin/action/arnica_slides.py: arnica_slides: preload of all images changed to load image on demand
2008-07-16T07:08:56 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 177:a399665b4cb9 1.7-extensions/data/plugin/ (action/refresh.py parser/text_x_arnica.py): text_x_arnica, refresh: added image extension to key
2008-07-16T07:15:59 <dreimark> hmm, does it mean if i get 2008-07-16 07:15:45,778 INFO MoinMoin.server.server_standalone:290 127.0.0.1 "GET /?action=cache&do=get&key=W96a02a0424c01aec74644....
2008-07-16T07:16:20 <dreimark> that the image key is all the time loaded
2008-07-16T07:16:44 <dreimark> that wasn't before with arnicas cache
2008-07-16T07:20:26 <dreimark> ThomasWaldmann: in do_get request.if_modified_since is always None
2008-07-16T07:40:29 <dreimark> bbl
2008-07-16T07:49:57 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 178:d29abc5e4b4f 1.7-extensions/data/plugin/ (3 files in 2 dirs): PEP8 fixes
2008-07-16T08:53:44 <mmihaljevic> moin
2008-07-16T08:59:56 <mmihaljevic> dreimark: need comments and figure how to deal with calling create_backend because of different parms http://paste.pocoo.org/show/79551/
2008-07-16T09:08:27 <gizmach> re
2008-07-16T09:34:49 <dreimark> moin
2008-07-16T09:35:00 <gizmach> dreimark: hi
2008-07-16T09:36:46 <dreimark> gizmach: I can't see any params in your pastebin, where is the problem
2008-07-16T09:38:32 <gizmach> dreimark: create_backend , sometimes it takes request and sometimes it doesn't and in the wikiconfg it is called:
2008-07-16T09:40:42 <gizmach> http://paste.pocoo.org/show/79553/
2008-07-16T09:40:56 <gizmach> and I need somehow create_backend
2008-07-16T09:44:51 <johill> dennda: have to check
2008-07-16T09:46:11 <johill> dreimark: can't exif info store tags? I think f-spot does that, no?
2008-07-16T09:47:51 <dreimark> johill: exif does and pil ignores it currently and not all image formats do have exif data (e.g. png)
2008-07-16T09:48:52 <dennda> johill: Would be good. I am not that sure how to handle it
2008-07-16T09:49:53 <dreimark> gizmach: if it is not needed can't it be ignored then ?
2008-07-16T09:50:25 <gizmach> dreimark: you mean to give request always and than if it is not needed just to ignore it?
2008-07-16T09:50:29 <johill> dreimark: ok, I'd hate to have to tag my photos in different places
2008-07-16T09:50:37 <johill> dreimark: maybe you can import f-spot sqlite db ;)
2008-07-16T09:50:48 <dreimark> gizmach: that is one possibility
2008-07-16T09:51:05 <gizmach> dreimark: well I think this way could work
2008-07-16T09:51:16 <dreimark> johill: good idea I dislike this spreading too
2008-07-16T09:51:17 <johill> dreimark: the one thing I find odd is that you're using such a wiki syntax, that means you have to parse the wiki stuff
2008-07-16T09:51:35 <johill> dennda: ok let me see
2008-07-16T09:52:38 <dreimark> johill: that wiki syntax can be used to be rendered and added somewhere on the page
2008-07-16T09:53:25 * dennda needs to get in again
2008-07-16T09:53:55 <dreimark> gizmach: http://paste.pocoo.org/show/79553/ do you ask which parameter you should add ?
2008-07-16T09:54:58 <gizmach> hm.. this is for wiki and I don't need parms, but for config I'll give them before
2008-07-16T09:55:26 <dreimark> gizmach: why don't you need params ?
2008-07-16T09:55:48 <gizmach> dreimark: but they are given by request
2008-07-16T09:55:48 <gizmach> all of them for wikigroups
2008-07-16T09:55:51 <gizmach> I think
2008-07-16T09:56:57 <dreimark> I am not sure if it is good to have config vars used for one backend and parameters for all others, do you?
2008-07-16T09:57:41 <gizmach> but I have different backend factories
2008-07-16T09:57:58 <gizmach> for config, ldap
2008-07-16T09:57:58 <johill> dennda: yes, that is doing the edit-locking
2008-07-16T09:58:18 <dreimark> gizmach: ok, we can discuss this later
2008-07-16T09:58:19 <johill> dennda: unfortunately, lanius hid the actual metadata operations in the item collection layer, which imho is the wrong place to put it
2008-07-16T09:58:28 <gizmach> ok
2008-07-16T09:59:29 <dennda> let me get up. just awake
2008-07-16T10:06:04 <dreimark> johill: I have removed that preload function, it is fast enough without
2008-07-16T10:08:23 <zenhase> moin
2008-07-16T10:11:31 <dreimark> hi zenhase, will you give some status report on the meeting today?
2008-07-16T10:14:17 <zenhase> yeah
2008-07-16T10:16:32 <johill> dreimark: cool :)
2008-07-16T10:19:04 <dreimark> johill: currently the cache action can't verify already send, and sends always
2008-07-16T10:19:14 <johill> ?
2008-07-16T10:20:34 <dreimark> request.if_modified_since in action.action._do_get is always None, ["Status: 304 Not modified"] can't be used
2008-07-16T10:20:48 * dreimark waits for ThomasWaldmann
2008-07-16T10:21:01 <johill> oh
2008-07-16T10:22:44 <dreimark> s/.action./.cache./
2008-07-16T10:27:25 <johill> yeah understood
2008-07-16T11:14:26 <lanius> hi
2008-07-16T11:24:46 <ThomasWaldmann> moin
2008-07-16T11:29:06 <ThomasWaldmann> dreimark: maybe there is something missing for put_cache, the if-modified-since is only done by the browser if it received some last-modified header (iirc) when it cached the object
2008-07-16T11:30:09 <zenhase> hmm ... http://paste.pocoo.org/show/79558/
2008-07-16T11:31:09 <zenhase> this is quite awful for testing, when you have to have proper login rights etc. for creating/deleting test-pages :o
2008-07-16T11:32:41 <johill> zenhase: I wouldn't worry about it too much, ideally all the tests would soon be written against some non-persistent storage backend :)
2008-07-16T11:33:53 <xorAxAx> congrats to zenhase for appearing on a wednesday :)
2008-07-16T11:33:54 <zenhase> yeah, but right now i'll have to go for some lenghts to create my own tests :/
2008-07-16T11:34:07 <zenhase> :P
2008-07-16T11:34:08 <ThomasWaldmann> dreimark: hmm, no, last-modified header is created in put(), so it should work
2008-07-16T11:34:28 <xorAxAx> zenhase: i was not amused
2008-07-16T11:35:12 <dreimark> ThomasWaldmann: last-modified is defined but request.if_modified_since is None
2008-07-16T11:35:30 <ThomasWaldmann> dreimark: show me the code using the cache and where you observe no if-modified-since
2008-07-16T11:35:45 <zenhase> xorAxAx: i apologize again :o
2008-07-16T11:36:09 <ThomasWaldmann> last-modified is in the server response, if-modified-since is in the (next) browser request
2008-07-16T11:36:27 <xorAxAx> zenhase: hmm, when did you do the first time?
2008-07-16T11:36:50 <ThomasWaldmann> xorAxAx: we talked already
2008-07-16T11:38:15 <zenhase> meeting starts at 13:00 right?
2008-07-16T11:38:17 * dreimark lunch
2008-07-16T11:38:25 <zenhase> (german time)
2008-07-16T11:38:55 <xorAxAx> ThomasWaldmann: well, it might be useful to present the status to the others or at least the other org admin :-p
2008-07-16T11:39:22 <xorAxAx> also he should talk about it in the meeting
2008-07-16T11:39:59 <zenhase> can do that
2008-07-16T11:52:21 <ThomasWaldmann> byegonweon: don't miss the meeting
2008-07-16T11:53:03 <zenhase> i'll go to see a professor now, i'll be back in time for the meeting
2008-07-16T12:12:34 <dennda> johill: So how do I handle that? Just remove it and replace it by create_revision() and commit()? (Since we didn't want to use edit-locks on Page items but rather do that implicitly)
2008-07-16T12:12:42 * dennda needs a new keyboard asap
2008-07-16T12:18:10 <johill> dennda: umm, no, we do explicit edit-locks
2008-07-16T12:18:32 <johill> that's a high-level lock
2008-07-16T12:19:00 <johill> dennda: look at the code in storage/external
2008-07-16T12:21:33 <dennda> johill: doing that
2008-07-16T12:22:22 <johill> I think we want to move that code into some helper function or so
2008-07-16T12:22:39 <johill> but it shouldn't be in storage
2008-07-16T12:22:41 <dennda> The locking methods in Item?
2008-07-16T12:23:05 <johill> the edit_lock stuff
2008-07-16T12:23:34 <dennda> (didn't I say that?)
2008-07-16T12:24:12 <PawelPacana> moin
2008-07-16T12:24:16 <johill> aren't there other locking methods too?
2008-07-16T12:24:29 <dennda> that may be true
2008-07-16T12:24:55 <johill> hi PawelPacana
2008-07-16T12:24:56 <dennda> I meant everything between get_edit_lock and _check_lock
2008-07-16T12:25:09 <johill> dennda: there are, and those we don't want/need, but the edit-lock stuff is a high-level operation ("
2008-07-16T12:25:24 <dennda> So cut&paste?
2008-07-16T12:25:46 <johill> no, get_lock is not needed
2008-07-16T12:26:03 <dennda> Why is that?
2008-07-16T12:26:15 <johill> well I would make maybe wikiutil.edit_lock(item) wikiutil.edit_unlock(item)
2008-07-16T12:26:38 <johill> well look at set_lock, it sents a backend lock
2008-07-16T12:26:41 <johill> that's something we don't need
2008-07-16T12:26:53 <dennda> ok, are those locks meant to be held in metadata?
2008-07-16T12:27:08 <dennda> Because he does that there
2008-07-16T12:27:16 <johill> the edit locks, yes
2008-07-16T12:27:56 <dennda> Ok, just for better understanding: You think that locking an Item is a high level operation because...?
2008-07-16T12:29:36 <johill> you don't understand edit-locks
2008-07-16T12:30:00 <johill> that's what you get as a user
2008-07-16T12:30:01 <johill> "XY is editing this page, please don't right now"
2008-07-16T12:33:25 <dennda> ...because it has nothing to do with storage directly?
2008-07-16T12:34:17 <johill> yeah basically
2008-07-16T12:37:34 <dreimark> re
2008-07-16T12:37:56 <dreimark> ThomasWaldmann: it happens in arnica slide on requesting the url from the javascript code
2008-07-16T12:38:51 <dennda> wikiutil looks like it contains a bunch of helper functions
2008-07-16T12:43:52 <dreimark> ThomasWaldmann: as an example just use the url e.g.
2008-07-16T12:43:57 <dreimark> http://localhost:8080/?action=cache&do=get&key=We701bca26bcba269cbf78cd92df93d83258319fc.JPG
2008-07-16T12:46:29 <dreimark> ThomasWaldmann: hmm, that is different request.if_modified_since is defined and it reloads
2008-07-16T12:47:11 <ThomasWaldmann> dreimark: why does the key have a .JPG extension?
2008-07-16T12:47:13 <dreimark> ThomasWaldmann: looks like I'm wrong,
2008-07-16T12:47:25 <dreimark> ThomasWaldmann: stupid idea yesterday
2008-07-16T12:47:46 <dreimark> will remove it later
2008-07-16T12:47:59 <johill> dennda: yeah, you can do MoinMoin.util.edit_lock too if you wish
2008-07-16T12:48:51 * gizmach here
2008-07-16T12:49:57 <dreimark> ThomasWaldmann: can't reproduce the problem here, will look later again on it at home
2008-07-16T12:51:14 <dreimark> may be I have overlooked the 304 at the end of the log msg.
2008-07-16T12:54:06 <dreimark> strange it works here on this machine perfectly
2008-07-16T12:57:54 <xorAxAx> byegonweon: moin, are you there?
2008-07-16T12:59:02 <johill> I most likely won't be on next week
2008-07-16T12:59:23 <johill> that'd be 7am for me :)
2008-07-16T12:59:47 <johill> i.e. I have to be at breakfast or so to get to OLS
2008-07-16T13:00:15 <xorAxAx> hehe
2008-07-16T13:00:36 <zenhase> re
2008-07-16T13:02:02 <dreimark> mitsuhiko: ping
2008-07-16T13:03:22 <dreimark> every student here ?
2008-07-16T13:03:35 <gizmach> :)
2008-07-16T13:03:37 <PawelPacana> :>
2008-07-16T13:04:08 <dennda> yep
2008-07-16T13:04:50 <zenhase> hmm
2008-07-16T13:04:52 <dreimark> zenhase: was first at 13:00 and we should start with you, because lacking twice meetings
2008-07-16T13:05:36 <xorAxAx> yeah
2008-07-16T13:05:37 <zenhase> ok, so how shall i do this? :)
2008-07-16T13:05:52 <xorAxAx> like the other times we had it and where you hopefully read the logs :)
2008-07-16T13:05:58 <dreimark> did you read http://moinmo.in/GoogleSoc2008
2008-07-16T13:06:18 <dreimark> zenhase: tudent reporting about progress of that week (what's new, what works, what does not work, ...)
2008-07-16T13:06:25 <dreimark> +s
2008-07-16T13:06:42 <zenhase> ok
2008-07-16T13:07:26 <ThomasWaldmann> re
2008-07-16T13:07:41 <zenhase> well, since i didn't report officially because of the missed meetings, i guess everything is kind of new
2008-07-16T13:07:56 <zenhase> i will talk about what has been done so far
2008-07-16T13:08:28 <ThomasWaldmann> ok, lets begin :)
2008-07-16T13:08:33 <ThomasWaldmann> waldi: please begin
2008-07-16T13:08:41 <xorAxAx> ThomasWaldmann: zenhase is beginning
2008-07-16T13:08:50 <waldi> ThomasWaldmann: well
2008-07-16T13:09:00 <xorAxAx> but probably waldi is a better choice
2008-07-16T13:09:01 <zenhase> i have put together the werkzeug Request/Response objects for moin and wrapped them up in 'context'-objects
2008-07-16T13:09:01 <zenhase> :)
2008-07-16T13:09:06 <waldi> it works now, mostly
2008-07-16T13:09:11 * ThomasWaldmann ususally follows the list on http://moinmo.in/GoogleSoc2008
2008-07-16T13:09:53 <waldi> the creole parser is completed. a compatibility formatter is available for old parser and macros
2008-07-16T13:10:00 <ThomasWaldmann> ok, zenhase, remember your words and waldi has the stage now
2008-07-16T13:10:12 <zenhase> ThomasWaldmann: yep
2008-07-16T13:10:15 <waldi> next steps: new/improved macro interface, converter priorities
2008-07-16T13:10:45 <ThomasWaldmann> waldi: completed mean EVERYTHING works?
2008-07-16T13:11:01 <waldi> okay, mostly completed
2008-07-16T13:11:18 <waldi> hmm, no, creole is complete, the further steps are not
2008-07-16T13:11:37 <ThomasWaldmann> hr works now?
2008-07-16T13:11:50 <waldi> this is undefined in the html converter
2008-07-16T13:12:05 <waldi> and a nop
2008-07-16T13:12:20 <ThomasWaldmann> why?
2008-07-16T13:14:06 * ThomasWaldmann sees half a dozen TODO tags in creole_in
2008-07-16T13:14:08 <waldi> it is one of the not really output-indenpendant definition of html, aka no semantic item
2008-07-16T13:14:18 <byegonweon> xorAxAx: I'm coming.
2008-07-16T13:14:39 <waldi> ThomasWaldmann: oh, yeah, need to clean them up
2008-07-16T13:14:55 <ThomasWaldmann> ok, any blockers?
2008-07-16T13:16:01 <waldi> no
2008-07-16T13:16:09 <ThomasWaldmann> (and btw, we need hr for about every markup)
2008-07-16T13:17:04 <ThomasWaldmann> ok, thanks waldi (we can talk about plans for macro interface later)
2008-07-16T13:17:32 <ThomasWaldmann> zenhase: mitsuhiko: please continue, your stage now :)
2008-07-16T13:17:39 <zenhase> ok
2008-07-16T13:18:18 <xorAxAx> mitsuhiko: ping
2008-07-16T13:18:49 <zenhase> as said, request/response from werkzeug have been put into a single request-object for moin (like it has been before)
2008-07-16T13:18:56 <dennda> xorAxAx: afair he left for a short trip to the city. maybe he is back in time
2008-07-16T13:19:07 <xorAxAx> dennda: hopefully
2008-07-16T13:20:03 <zenhase> the contexts wrap this one up then with the methods (be it convenience or really needed) for the moin-code expecting the old request api
2008-07-16T13:20:29 <ThomasWaldmann> zenhase: are you practically testing and how much of moin does currently work after your heavy changes?
2008-07-16T13:20:35 <zenhase> i already did change a lot of the old code to use for example the nicer multidicts for form/queryargs
2008-07-16T13:20:43 <zenhase> and the same goes for incoming/outgoing headers
2008-07-16T13:21:39 <mitsuhiko> xorAxAx: pong
2008-07-16T13:21:48 <xorAxAx> mitsuhiko: you are 21 minutes late :)
2008-07-16T13:21:54 <mitsuhiko> i know sorry, the car broke down
2008-07-16T13:21:55 <dreimark> mitsuhiko: read backlog zenhase is already reporting
2008-07-16T13:21:55 <zenhase> i am constantly testing with a running standalone-server (which is currently based on mitsuhikos run_simple-wsgiserver from werkzeug and SharedDataMiddleware for the static files)
2008-07-16T13:22:01 <xorAxAx> mitsuhiko: oh :-(
2008-07-16T13:22:31 <zenhase> and the last 2 weeks i was unto working my way into the unittests, making them pass again and look for opportunities to write new ones
2008-07-16T13:22:46 <zenhase> i think from the original tests there is only one failing right now
2008-07-16T13:23:27 <zenhase> also i tried to seperate session and auth-handling a little bit, this was heavily intermingled in the old code
2008-07-16T13:23:29 <ThomasWaldmann> so if you already have some sort of "new wsgi based standalone server", can you integrate it with the script plugins
2008-07-16T13:23:45 <zenhase> right now sessions get setup independent from user/auth
2008-07-16T13:23:59 <zenhase> hmm, does script use the standalone server?
2008-07-16T13:24:07 <zenhase> i saw a lot of request_cli-use there
2008-07-16T13:24:16 <ThomasWaldmann> moin server standalone ... is the command
2008-07-16T13:24:18 <dreimark> zenhase: please merge with 1.8
2008-07-16T13:24:37 <zenhase> ah, you mean that
2008-07-16T13:25:08 <zenhase> dreimark: i did merge 1 week ago, i will merge again soon
2008-07-16T13:25:16 <ThomasWaldmann> if you don't want to kill that right now (assuming it still works), you could do moin server wsgi ... command.
2008-07-16T13:25:51 <mitsuhiko> isn't the plan for unittests to go away from the all mygthy request object to stipped down context objects anyways?
2008-07-16T13:26:06 <zenhase> regarding unittests: werkzeug.test.Client is/would be a nice way to blackbox-test the application
2008-07-16T13:26:31 <zenhase> ThomasWaldmann: oh, i think i would kill it and replace it with the werkzeug-standalone server then
2008-07-16T13:26:36 <zenhase> mitsuhiko: yeah, i was coming to that
2008-07-16T13:26:51 <xorAxAx> mitsuhiko: depends on what you want to test, blackbox tests are missing completly for example
2008-07-16T13:26:56 <xorAxAx> in the current testing scheme
2008-07-16T13:27:06 <zenhase> i realized, that a lot of the testing is done not on apis, but on complete request-runs
2008-07-16T13:27:15 <mitsuhiko> xorAxAx: especially unittests on parsers and that
2008-07-16T13:27:18 <ThomasWaldmann> zenhase: be careful, the current standalone is rather powerful, offering different server types, threading, ...
2008-07-16T13:27:30 <mitsuhiko> there we can pass a FormatterContext or how it's called currently that doesn't need http information
2008-07-16T13:28:00 <zenhase> same goes for script with request_cli, which really feels wrong, but ok ... can be dealt with in a similar fashion until something better comes up
2008-07-16T13:28:11 <zenhase> ThomasWaldmann: does it have to be?
2008-07-16T13:28:14 <xorAxAx> mitsuhiko: yes, thats more along the lines of decouplance refactoring and a good point to see whether the old tests still run without a request-alike
2008-07-16T13:28:28 <xorAxAx> zenhase: what do you mean by similar fashion here?
2008-07-16T13:28:29 <zenhase> i mean, how many server-types do you really need to support
2008-07-16T13:28:34 <zenhase> ?
2008-07-16T13:28:39 <zenhase> in standalone
2008-07-16T13:28:46 <ThomasWaldmann> some people use standalone behind apache proxy for intranet
2008-07-16T13:29:05 <mitsuhiko> ThomasWaldmann: that's what people should use paste/cherrypy for in the future
2008-07-16T13:29:12 <mitsuhiko> no need to shop those servers with moint
2008-07-16T13:29:15 * johill gets bored
2008-07-16T13:29:32 <mitsuhiko> you can still offer all-in-one packages for the windows admins too lazy to use easy_install
2008-07-16T13:29:42 <ThomasWaldmann> ok, zenhase, blockers? plan for next week?
2008-07-16T13:30:33 <zenhase> xorAxAx: that it's quite similar if you unittest against a request.run() and test for certain attributes afterwards on the request object as it is to do CLI interfacing of moin via a special request object (request_cli)
2008-07-16T13:30:51 <zenhase> so a sum-up of what i would like to do next:
2008-07-16T13:31:36 <ThomasWaldmann> gizmach: dreimark: you are next after zenhase has finished
2008-07-16T13:31:42 <dreimark> ok
2008-07-16T13:31:45 <gizmach> ok
2008-07-16T13:31:45 <zenhase> * write some tests for stuff i encountered on the way and also the new code i wrote
2008-07-16T13:32:16 <xorAxAx> zenhase: generally, a lot of scripts dont need any request-alike in their code - they only need some kind of context
2008-07-16T13:32:22 <zenhase> see http://moinmo.in/FlorianKrupicka/SOC2008/ToDo for an overview (Unsorted heading)
2008-07-16T13:32:25 <xorAxAx> zenhase: so thats to be fixed
2008-07-16T13:32:43 <mitsuhiko> oh. and i would love to see moin shipping a venv bootstrapping script :D
2008-07-16T13:33:01 <xorAxAx> mitsuhiko: feel free :)
2008-07-16T13:33:01 <zenhase> xorAxAx: yeah, that's what 'replacement for request_cli' would be
2008-07-16T13:33:09 <xorAxAx> zenhase: ok
2008-07-16T13:33:09 <zenhase> mitsuhiko: venv?
2008-07-16T13:33:15 <dreimark> 10mins extended already, those parts can be talked later
2008-07-16T13:33:16 <mitsuhiko> zenhase: virtualenv
2008-07-16T13:33:24 <mitsuhiko> bootstrapps a virtual python with all dependencies and moin
2008-07-16T13:33:37 <xorAxAx> zenhase: so now you may want to give a public apology for your non-appearance in the last meetings
2008-07-16T13:33:43 <zenhase> regarding packaging/bootstrapping: have a item on the todo-page too for that
2008-07-16T13:33:50 <zenhase> ok
2008-07-16T13:34:30 <xorAxAx> mitsuhiko: hmm, is that related to his soc task?
2008-07-16T13:35:15 <zenhase> i deeply apologize for not appearing to the last meetings. i made a more strict timetable and it won't happen again
2008-07-16T13:35:17 <mitsuhiko> xorAxAx: sort of because moin has dependencies now
2008-07-16T13:35:17 <zenhase> ah, 2min battery left
2008-07-16T13:35:29 <mitsuhiko> a virtualenv bootstrapping script could solve that by automatically installing everything
2008-07-16T13:35:29 <zenhase> need to see a wallplug soon :o
2008-07-16T13:35:29 <zenhase> yeah
2008-07-16T13:35:36 <mitsuhiko> besides, that script is 10 lines custom code or so
2008-07-16T13:35:47 <zenhase> it's the first real dependency
2008-07-16T13:35:50 <xorAxAx> mitsuhiko: well, in fact it adds another dependency :)
2008-07-16T13:35:51 <zenhase> it will be mandatory to run moin :o
2008-07-16T13:35:55 <mitsuhiko> xorAxAx: no
2008-07-16T13:35:55 <ThomasWaldmann> zenhase: mitsuhiko: 1 minute
2008-07-16T13:36:20 <mitsuhiko> xorAxAx: virtualenv can create a bootstrapping script that just bootstraps a virtualenv without virtualenv
2008-07-16T13:36:26 <zenhase> if you would like to continue with the next student i will hunt down a wallplug
2008-07-16T13:36:31 <zenhase> and be back in a few minutes
2008-07-16T13:37:01 <johill> we don't want to discuss any deployment issues right now anyway
2008-07-16T13:37:06 <johill> at least I don't
2008-07-16T13:37:09 <ThomasWaldmann> ok, thanks zenhase / mitsuhiko (please continue afterwards), gizmach, your stage
2008-07-16T13:37:17 <gizmach> ok here I am
2008-07-16T13:37:19 <ThomasWaldmann> (and dreimark, of course)
2008-07-16T13:37:37 <dreimark> gizmach: please report about the progress of the last two weeks
2008-07-16T13:37:44 <gizmach> the progress I done in the past two weeks is wiki group backend
2008-07-16T13:38:19 <dreimark> the acl part is working ?
2008-07-16T13:38:39 <gizmach> also I added backend factory so wikiconfiguration can have defined wikigroup backend and ldap backend which needed to be instance with request
2008-07-16T13:39:01 <johill> why do you need a new instance for each request as opposed to one in the config?
2008-07-16T13:39:04 <gizmach> dreimark: I'm still fixing because of the backend factory I added
2008-07-16T13:39:26 <gizmach> and before this it was working dreimark
2008-07-16T13:39:47 <gizmach> johill: I can't define Something(reqest) in config
2008-07-16T13:40:11 <johill> what thing needs request?
2008-07-16T13:40:22 <gizmach> wiki group manager backend
2008-07-16T13:40:26 <gizmach> and ldap too
2008-07-16T13:40:29 <johill> what for?
2008-07-16T13:41:02 <gizmach> for instancing the objects
2008-07-16T13:41:08 <johill> which objects?
2008-07-16T13:41:27 <johill> and what do they need the request for?
2008-07-16T13:41:29 <gizmach> the objects of WikiGroup backend
2008-07-16T13:42:03 <gizmach> they need the requests for checking the acl rights of the requested page for example
2008-07-16T13:42:06 <johill> I don't see anything that is request dependent in a "is X in group Y" type of thing
2008-07-16T13:42:07 <gizmach> if you mean on this
2008-07-16T13:42:26 <johill> then why does the group code check ACLs as opposed to the ACL code using the group?
2008-07-16T13:42:43 <gizmach> johill: the acls check the group
2008-07-16T13:42:56 <gizmach> maybe I said it worongly
2008-07-16T13:43:07 <johill> ok so then where does the group code need the request?
2008-07-16T13:43:28 <zenhase> re
2008-07-16T13:43:33 <gizmach> but when I have the page group and the page is defined it parses the page and reads the members of the group
2008-07-16T13:43:44 <gizmach> so there I need to request of the current page
2008-07-16T13:44:25 <xorAxAx> johill: Page needs a request
2008-07-16T13:44:49 <gizmach> xorAxAx: true and also I need to check if the page exists and parse the page
2008-07-16T13:44:58 <johill> ok true
2008-07-16T13:45:15 <johill> seems that fundamentally even that shouldn't need the request
2008-07-16T13:46:18 <gizmach> ok so I done the backendFactory for every backend to handle this (was in one of my last pastebins)
2008-07-16T13:46:19 * dreimark Page/PageEditor refactoring may give some further possibilities
2008-07-16T13:46:21 <xorAxAx> its needing it quite often - that pattern is called redudant object passing and leads to better safety
2008-07-16T13:46:26 <dreimark> *thinks
2008-07-16T13:47:09 <ThomasWaldmann> gizmach: when can we expect something practically working?
2008-07-16T13:47:26 <ThomasWaldmann> (for wiki and config backend)
2008-07-16T13:47:28 <gizmach> ThomasWaldmann: these days, with the cache it was working everything
2008-07-16T13:47:39 <gizmach> before this backend factory
2008-07-16T13:47:51 <gizmach> so I suppose to get everyithying working these days
2008-07-16T13:48:19 <dreimark> gizmach: it is wednesday do you think on thursday or friday?
2008-07-16T13:48:33 <gizmach> only have a bit problem with create_backend
2008-07-16T13:48:44 <gizmach> dreimark: I hope thursday
2008-07-16T13:49:01 <gizmach> I only need to solve that problem
2008-07-16T13:49:57 <gizmach> dreimark: and than I plan to finish later all the group backend
2008-07-16T13:50:05 <dreimark> gizmach: what are then the steps until next wednesday ?
2008-07-16T13:51:12 <gizmach> dreimark: to finish all the group backend, I started on the ldap groups already, at least get it work
2008-07-16T13:51:46 <dreimark> writing more tests? add detailed comments too
2008-07-16T13:51:50 <gizmach> dreimark: also on wednesday or on thursday I'll be traveling but I'll have a network tere
2008-07-16T13:51:57 <gizmach> dreimark: yes that too
2008-07-16T13:52:23 <dreimark> look on other document pages and try to write yours similiar
2008-07-16T13:52:31 <gizmach> ok
2008-07-16T13:52:43 <dreimark> gizmach: any blockers ?
2008-07-16T13:53:16 <gizmach> dreimark: except that create_backend , currently nothing but about that we can discuss aftermeeting
2008-07-16T13:53:36 <dreimark> ok, so we are ready?
2008-07-16T13:53:51 <gizmach> huh?
2008-07-16T13:53:54 <ThomasWaldmann> ok, we have to proceed. thanks gizmach and dreimark. next is byegonweon and xorAxAx - your stage!
2008-07-16T13:53:59 <gizmach> :)
2008-07-16T13:54:04 <xorAxAx> byegonweon: please report
2008-07-16T13:54:06 <byegonweon> for the first. from previous friday to this monday. I was trip to my hometown and have a time with my family.
2008-07-16T13:54:12 <ThomasWaldmann> s/ready/finished/ :)
2008-07-16T13:54:19 <byegonweon> during this week. I was looking around fckeditor automated test.
2008-07-16T13:54:25 <byegonweon> there's three type of testing methods in fckeditor. what I interested was selenium test.
2008-07-16T13:54:36 <byegonweon> maybe I can make automated test for moinmoin fckeditor using selenium. fckeditor dev team already try that kind of thing.
2008-07-16T13:54:45 <byegonweon> I will make moinmoin fckeditor automated test prototype using selenium next week.
2008-07-16T13:54:54 <byegonweon> and I try to find another solution of fckeditor problem on safari using server side html tidy.
2008-07-16T13:55:04 <byegonweon> copy and past :)
2008-07-16T13:55:28 <byegonweon> and
2008-07-16T13:55:33 <byegonweon> I don't have any blockers yet.
2008-07-16T13:55:47 <xorAxAx> any progress on the fckeditor bug report?
2008-07-16T13:56:06 <byegonweon> xorAxAx: no.. they seems like very busy.
2008-07-16T13:56:07 <xorAxAx> (by them)
2008-07-16T13:56:26 <ThomasWaldmann> byegonweon: you didn't commit anything since nine days
2008-07-16T13:56:33 <byegonweon> xorAxAx: so I try alternative solution.
2008-07-16T13:56:54 <xorAxAx> indeed. also it would be nice if you can brainstorm a bit about the deliverables for the next week
2008-07-16T13:57:01 <byegonweon> Thoms: I know. during that period I can work about 4days
2008-07-16T13:57:31 <byegonweon> ThomasWaldmann: and other days I read codes , manuals, make prototype.
2008-07-16T13:57:46 <ThomasWaldmann> but even for 4 days, nothing is not much :)
2008-07-16T13:58:52 <byegonweon> ThomasWaldmann: yes. I know. next week I can make something commit. please wait little more :)
2008-07-16T13:59:32 <ThomasWaldmann> ok. as you are focussing on tests now, does this mean IE and Firefox do work completely now with GUI editor?
2008-07-16T13:59:57 <xorAxAx> at least we dont have any known issue
2008-07-16T14:00:03 <xorAxAx> and people are invited to test
2008-07-16T14:00:09 <byegonweon> as I tested. yes.
2008-07-16T14:00:17 <xorAxAx> byegonweon: can you think about the deliverables?
2008-07-16T14:00:36 <ThomasWaldmann> iirc there are lots of gui editor bugs open on the wiki
2008-07-16T14:00:47 <ThomasWaldmann> byegonweon: do you close bugs after fixing stuff?
2008-07-16T14:01:18 <byegonweon> xorAxAx: what is the deliverables?
2008-07-16T14:01:38 <xorAxAx> byegonweon: well, we need new ideas for the next weeks, you dont want to write tests for all those weeks, do you?
2008-07-16T14:02:11 <xorAxAx> yes, it would be nice if you could classify all gui editor bugs if they are related to the converter or the js side
2008-07-16T14:02:17 <xorAxAx> and in the latter case try to fix them
2008-07-16T14:02:18 <byegonweon> ThomasWaldmann: I missed bugs reported on moinmoin wiki. I'll check that and determine that progress.
2008-07-16T14:02:23 <xorAxAx> (or even reproduce)
2008-07-16T14:02:27 * ThomasWaldmann .oO(deliverables are like vegetables. mentors eat them.)
2008-07-16T14:03:46 <byegonweon> xorAxAx: oh. I understand what you say. give me more time think about that.
2008-07-16T14:04:17 <ThomasWaldmann> byegonweon: title search for: Bugs Gui Editor
2008-07-16T14:04:19 <byegonweon> xorAxAx: I will send you that soon.
2008-07-16T14:04:29 <xorAxAx> byegonweon: i added the classification task to http://moinmo.in/MoonByeongweon/SOC2008
2008-07-16T14:04:36 <xorAxAx> byegonweon: you can also put it onto that wiki page
2008-07-16T14:05:00 <byegonweon> xorAxAx: ok.
2008-07-16T14:05:09 <byegonweon> ThomasWaldmann: thanks.
2008-07-16T14:05:15 <ThomasWaldmann> dennda: johill: you are next after byegonweon / xorAxAx is finished
2008-07-16T14:05:24 <dennda> I know :)
2008-07-16T14:05:33 <dennda> But are they yet?
2008-07-16T14:05:41 <xorAxAx> byegonweon: any blockers?
2008-07-16T14:05:49 <byegonweon> not yet.
2008-07-16T14:06:45 <xorAxAx> ok, dennda
2008-07-16T14:07:13 <dennda> Ah I thought that "not yet." was the answer to my question :)
2008-07-16T14:07:14 <dennda> Ok
2008-07-16T14:07:35 <byegonweon> hehe.
2008-07-16T14:07:39 <byegonweon> I'm finished.
2008-07-16T14:07:41 <dennda> I almost forgot we had no meeting last week, so let me roughly sum up what I did in the week before this one
2008-07-16T14:08:02 <dennda> Fixing PEP8 violations, Fixing tests, johill added his new-style FS-backend (Which makes debugging easier as you can imagine ;)), started the hook-up-process, general bugfixing and merging.
2008-07-16T14:08:40 <dennda> Unfortunately, due to the three exams I tackled last week and monday (as announced), I wasn't able to commit something worth mentioning.
2008-07-16T14:08:57 <dennda> (i.e. from 9th to today)
2008-07-16T14:09:09 <dennda> I only committed two pending changesets containing changes to user.py and a bunch of tests we already had but which were not committed yet.
2008-07-16T14:09:55 <dennda> WIth those changes, you can log in now, but you cannot change your preferences due to some metadata-locking-error I am figuring out at the moment. (You can create an account though)
2008-07-16T14:10:34 <PawelPacana> dennda: can you browse page history?
2008-07-16T14:11:37 <dennda> PawelPacana: Didn't test that. I didn't adjust PageEditor up to now, so there are no pages (+history) I can browse
2008-07-16T14:11:50 <dennda> PawelPacana: If you need that functionality, I can change my priorities and get that done though
2008-07-16T14:12:34 <PawelPacana> dennda: im not sure until todays evening
2008-07-16T14:12:44 <dennda> PawelPacana: Why do you ask?
2008-07-16T14:12:48 <PawelPacana> you'll read later why :)
2008-07-16T14:13:11 <xorAxAx> any blockers, dennda?
2008-07-16T14:13:12 <ThomasWaldmann> btw, don't forget we need some mig script (copying all stuff from one (old) backend to another (new) backend)
2008-07-16T14:13:52 <dennda> Blockers? Hm... My exams blocked me, but that's sorted out now. :)
2008-07-16T14:13:57 <dennda> xorAxAx: Are you hungry? :)
2008-07-16T14:14:11 <dennda> ThomasWaldmann: sure, that's hard to forget
2008-07-16T14:14:20 <dennda> Thus, the plan for the next week is to get the integration finished. I just started editing PageEditor.py, since I really want to see
2008-07-16T14:14:24 <dennda> some common functionality using the new storage layer.
2008-07-16T14:14:26 <xorAxAx> dennda: hehe
2008-07-16T14:15:28 <ThomasWaldmann> PawelPacana: TheSheep: you are next after dennda / johill has finished
2008-07-16T14:15:30 * dennda wonders if johill has any thoughts/questions/concerns or if he already fell asleep or died from starvation
2008-07-16T14:16:05 <dennda> (the latter may happen to me soon, too) :)
2008-07-16T14:16:09 <johill> not really
2008-07-16T14:16:25 <dennda> ok
2008-07-16T14:16:31 <PawelPacana> shall we start?
2008-07-16T14:16:45 <johill> sure
2008-07-16T14:16:51 <PawelPacana> during EuroPython i managed to get all 60 backend tests passing
2008-07-16T14:16:56 <PawelPacana> long name trimming, revision metadata, item meta and locking stuff are working
2008-07-16T14:17:02 <johill> cool. I didn't know there were 60 now
2008-07-16T14:17:05 <PawelPacana> because of the mercurial limitations of commiting empty changesets some things were done differently than planned:
2008-07-16T14:17:15 <PawelPacana> - revision meta couldnt be stored in commit messages because empty commits have no files associated in changeset
2008-07-16T14:17:15 <PawelPacana> (on empty commit global rev number is increased, but filerevs not)
2008-07-16T14:17:28 <dennda> johill: Me neither
2008-07-16T14:17:33 <PawelPacana> - revision meta implementation is ported from fs backend - revision meta & data are stored in the same file, so that any change of data or meta allows us to commit
2008-07-16T14:17:41 <dennda> PawelPacana: Did you write new tests? I don't have 60
2008-07-16T14:18:18 <PawelPacana> dennda: the number comes from generative tests
2008-07-16T14:18:25 <dennda> ic
2008-07-16T14:18:51 <PawelPacana> yielding create rename get countrs for 3 in one run
2008-07-16T14:19:08 <PawelPacana> johill pointed out that committing empty page revision in row (with no meta and data changes) should be allowed (as it is now)
2008-07-16T14:19:19 <PawelPacana> i have no idea how to achieve this yet, except for messing with dirstate or changing file attributes and thus faking changes
2008-07-16T14:19:33 <PawelPacana> i asked on #mercurial, however they didnt feel like answering rather pointing my usecase is pointless
2008-07-16T14:19:49 <PawelPacana> all work so far was done on stable mercurial release, 1.0.1
2008-07-16T14:20:01 <PawelPacana> i pulled devel version recently, and there are few changes, in commit() whats important too
2008-07-16T14:20:01 <PawelPacana> i'll be pointing my todays work on testing this code
2008-07-16T14:20:01 <PawelPacana> i hope to find a solution for empty commits and try out commiting with no working copy
2008-07-16T14:20:18 <PawelPacana> if none of this will work > i have to write my own extensions for achieving this functionality
2008-07-16T14:20:18 <PawelPacana> and this would be this weeks task
2008-07-16T14:20:31 <PawelPacana> if this will work mostly out-of-the-box in this dev snapshot, i'll focus on new page history plugin then (this depends on state of new backend integration)
2008-07-16T14:20:46 <PawelPacana> thats why i asked you dennda
2008-07-16T14:20:50 <dennda> (Why do you need empty commits?)
2008-07-16T14:21:27 <PawelPacana> im not pushing on empty commits, but they are allowed now
2008-07-16T14:21:59 <PawelPacana> and johill stated this should be doable
2008-07-16T14:22:04 <ThomasWaldmann> (maybe we can talk about plan for until next meeting, and dennda / PawelPacana talk more after official end of meeting)
2008-07-16T14:22:06 <TheSheep> dennda: for when you only change the metadata
2008-07-16T14:22:30 <dennda> TheSheep: Yeah, but then you did change something and thus it's not an empty commit, is it?
2008-07-16T14:22:54 <TheSheep> dennda: we wanted to store metadata in the commit message, so for mercurial it's empty
2008-07-16T14:23:13 <PawelPacana> dennda: such case with meta OR data change is handled right now
2008-07-16T14:23:22 <johill> dennda: mostly I said that we allow you to commit no data and no metadata once, so why add an arbitrary restriction disallowing doing it twice?
2008-07-16T14:23:50 <johill> but if that's going to be a big problem we can talk about it again
2008-07-16T14:24:14 <PawelPacana> johill: i'll let you know today
2008-07-16T14:24:35 <PawelPacana> wanted to dig this code anyway
2008-07-16T14:24:42 <PawelPacana> (hg devel)
2008-07-16T14:25:20 <PawelPacana> last task fallback (when blocked)
2008-07-16T14:25:31 <PawelPacana> is writing migration script
2008-07-16T14:25:57 <dennda> I wonder
2008-07-16T14:25:57 <PawelPacana> thats all :)
2008-07-16T14:26:15 <dennda> (Hm no, let's discuss that another time)
2008-07-16T14:26:29 <ThomasWaldmann> PawelPacana: you mean the generic backend-backend mig script?
2008-07-16T14:26:48 <dennda> I think he means $something -> mercurial
2008-07-16T14:27:00 <xorAxAx> why would such a specific script be necessary?
2008-07-16T14:27:08 <ThomasWaldmann> if all backends conform to storage api, that's not needed
2008-07-16T14:27:20 <ThomasWaldmann> we just need a any-any script
2008-07-16T14:27:47 <dennda> (That's why I wondered)
2008-07-16T14:27:54 <PawelPacana> i thought about specific one, but you're right, generic is just enough
2008-07-16T14:28:24 <johill> we only need a read-only old-style backend still
2008-07-16T14:28:28 <ThomasWaldmann> (and if that does not work out for some reason, maybe the api is incomplete)
2008-07-16T14:29:31 <ThomasWaldmann> ok, guess we are finished with the official part. thanks for everybody being here today. :)
2008-07-16T14:30:00 <TheSheep> thank you
2008-07-16T14:31:04 <gizmach> brb ~10 min
2008-07-16T14:33:23 <zenhase> :)
2008-07-16T14:33:46 * zenhase is updating his wiki-pages
2008-07-16T14:35:15 * dreimark has a meeting with some colleagues
2008-07-16T14:37:55 <ThomasWaldmann> zenhase: btw, you remember that non-configurable proxy-handling code? is your restructuring making it configurable somehow?
2008-07-16T14:38:52 <TheSheep> mitsuhiko: a complete offtopic, but is there a support channel for werkzeug?
2008-07-16T14:39:21 <ThomasWaldmann> zenhase: of course we need to ship SOME standalone server (at least for the people running it as "Desktop Edition" - for that application it does not need to be high-performance, medium is enough)
2008-07-16T14:39:26 <mmihaljevic> re
2008-07-16T14:42:27 <xorAxAx> TheSheep: when in doubt, ask #pocoo
2008-07-16T14:42:43 <xorAxAx> mitsuhiko, TheSheep: even though i would prefer a separate channel :)
2008-07-16T14:43:04 <zenhase> ThomasWaldmann: which proxy-handling code do you refer to?
2008-07-16T14:43:09 <mmihaljevic> dreimark: please ping me when you are back
2008-07-16T14:44:07 <ThomasWaldmann> zenhase: in old request/__init__.py at the top
2008-07-16T14:44:22 <zenhase> xorAxAx: #pocoo is still small enough that it can handle the request for werkzeug too
2008-07-16T14:44:24 <zenhase> ah that one
2008-07-16T14:44:31 <zenhase> trusted proxies :)
2008-07-16T14:45:27 <zenhase> hmm
2008-07-16T14:45:44 <ThomasWaldmann> zenhase: btw, about "Confusing link behaviour" - it just is like that and you are not expected to change that in your branch.
2008-07-16T14:46:13 <ThomasWaldmann> (and it is ../OtherPage not ./OtherPage)
2008-07-16T14:46:49 <zenhase> ThomasWaldmann: i didn't want to change that myself, it's just something that i now got wrong several times, so i wondered why it is that way :)
2008-07-16T14:47:12 <ThomasWaldmann> it has been like that from the beginning
2008-07-16T14:47:20 <ThomasWaldmann> FooPage is always top level
2008-07-16T14:47:28 <ThomasWaldmann> no matter from where you link to it
2008-07-16T14:47:30 <xorAxAx> zenhase: IMHO its huge serving many different projects
2008-07-16T14:47:30 <zenhase> i expected ./OtherPage to refer to a subpage (like subdirectory on unix) and /OtherPage to a page at the root
2008-07-16T14:48:49 <zenhase> xorAxAx: ok, if there was something more official like #werkzeug, perhaps there would also be more people there that ask questions
2008-07-16T14:49:07 <xorAxAx> zenhase: for example
2008-07-16T14:49:36 <zenhase> ThomasWaldmann: hmm ok, since FooPage always goes toplevel, wiki-linking doesn't follow filesystem-semantics anyway :)
2008-07-16T14:50:43 <zenhase> i will leave that on the page though as a reminder to myself, if i ever need to design link-semantics in some application
2008-07-16T14:51:45 <zenhase> regarding the configurability of the 'trusted_proxies'
2008-07-16T14:53:34 <zenhase> problem is that this has to be configured on the cfg ... which in turn doesn't show up on the actual request/response object, which has the remote_addr property
2008-07-16T14:54:39 <zenhase> it also has the .access_route, which contains the full route through all the proxies
2008-07-16T14:56:00 <zenhase> since .cfg resides a layer higher, on the contexts wrapped around this low-level request object, it's kind of not that nice/clean to push down configuration to the lower layer
2008-07-16T14:56:11 <zenhase> i actually wonder, how often this trusted_proxies feature is needed anyway
2008-07-16T14:57:20 <zenhase> i mean until now it meant editing moins code, is this documented anywhere?
2008-07-16T14:57:37 <zenhase> (except the code itself, i mean)
2008-07-16T14:58:16 <ThomasWaldmann> you need it as soon you run moin behind a proxy
2008-07-16T14:58:40 <ThomasWaldmann> or your edit-log entries will just show proxy ip
2008-07-16T15:05:20 <zenhase> hmm yeah
2008-07-16T15:05:50 <zenhase> and just trusting all proxies gives also bad results
2008-07-16T15:06:50 <zenhase> because you will end up with having things like 192.168.0.x addresses from somewhere on this planet in your logs ... which would not make any sense
2008-07-16T15:16:57 <dennda> johill: Do we want an edit_lock property on the item objects as it is now?
2008-07-16T15:19:22 <johill> no, I don't think so
2008-07-16T15:24:33 <dennda> just a sec, phonecall
2008-07-16T15:25:35 <johill> heh just called the hotel in Ottawa
2008-07-16T15:25:41 <johill> to confirm my reservation
2008-07-16T15:26:04 <johill> just my luck, their reservation system crashed this morning and isn't back up yet ;)
2008-07-16T15:27:23 <mmihaljevic> ThomasWaldmann: or someone , now I have http://paste.pocoo.org/show/79575/ and http://paste.pocoo.org/show/79576/ but somehow I need to call create_backend I was thinking to do that in GroupManager in __init__ but I'm not sure
2008-07-16T15:28:32 <xorAxAx> johill: the hostel in SF that i was in on sunday still had paper cards on the wall :)
2008-07-16T15:29:12 <johill> haha
2008-07-16T15:29:20 <johill> at least those can only burn, not crash
2008-07-16T15:30:22 <dennda> Meh, raining cats and dogs now
2008-07-16T15:31:42 <dennda> johill: Ok, so the current code checks a predefined set of EDIT_LOCK settings and looks whether they are in the items metadata. If not, it sets an edit_lock attribute (Which becomes a property later on). Shall I just rewrite that and use change_metadata and publish_metadata on a given item-object?
2008-07-16T15:32:11 <johill> I think so
2008-07-16T15:32:18 <dennda> ok
2008-07-16T15:34:22 <ThomasWaldmann> mmihaljevic: i guess you should investigate how to give the request object to your code and you will find what's still missing / not possible
2008-07-16T15:34:49 <ThomasWaldmann> i.e. how do you call create_backend(request) ?
2008-07-16T15:35:32 <mmihaljevic> ThomasWaldmann: yes I still need the request to be passed somehow and I can't define it in GroupManager
2008-07-16T15:35:50 <ThomasWaldmann> yes, so? :)
2008-07-16T15:36:08 <ThomasWaldmann> don't you have a deja-vue? :D
2008-07-16T15:36:30 <mmihaljevic> ThomasWaldmann: well yes and it looks like oh no, not agian
2008-07-16T15:36:50 <mmihaljevic> you think I sould do the process once again
2008-07-16T15:37:18 <ThomasWaldmann> well, if you don't have a better idea, you maybe just do it and not waste time
2008-07-16T15:38:25 <mmihaljevic> because I was thinking to do in a GroupManager something lik this but it wont work :self.backends = [manager.create_backend(request) for manager in manager_backends], so I need to create_factroy_backend and than instance a real one?
2008-07-16T15:47:03 <ThomasWaldmann> your problem is that you need request in GroupManager and you don't have it
2008-07-16T15:47:22 <mmihaljevic> yes
2008-07-16T15:47:44 <ThomasWaldmann> so apply some known pattern to solve that :)
2008-07-16T15:48:06 <mmihaljevic> :)
2008-07-16T15:48:07 <ThomasWaldmann> it is about 5 LOC
2008-07-16T15:48:16 <mmihaljevic> huh?
2008-07-16T15:48:28 <ThomasWaldmann> "Lines Of Code"
2008-07-16T15:48:31 <mmihaljevic> :) ok
2008-07-16T16:11:44 <mmihaljevic> ThomasWaldmann: but also datastruct/__init__ *BackendFactory doesn't have request, true?
2008-07-16T16:14:35 <mmihaljevic> pardon backend/__init__
2008-07-16T16:22:27 <ThomasWaldmann> raise NoSenseError
2008-07-16T16:23:09 <mmihaljevic> huh?
2008-07-16T16:23:34 <ThomasWaldmann> there is no code in backend/__init__
2008-07-16T16:24:36 <mmihaljevic> ThomasWaldmann: urgh not now, but the BackendFactory I put in the backend/__init__ the pastebin I sent
2008-07-16T16:25:11 <ThomasWaldmann> it is a bit of a pain to follow all your pastebins
2008-07-16T16:26:07 <mmihaljevic> http://paste.pocoo.org/show/79575/
2008-07-16T16:26:21 <mmihaljevic> sorry
2008-07-16T16:30:03 <ThomasWaldmann> and btw, you maybe want to put all group related code into the group_* files?
2008-07-16T16:30:44 <mmihaljevic> ThomasWaldmann: ah that could work than and I will have request I needed
2008-07-16T16:31:26 <ThomasWaldmann> the GMXBF get their request when someone is calling create_backend(request) method of them.
2008-07-16T16:31:47 <ThomasWaldmann> so now go to the place where this call comes from and make sure it has a request there
2008-07-16T16:32:11 <mmihaljevic> :) ok
2008-07-16T17:01:07 <LotekThirteen> hi there
2008-07-16T17:02:00 <dreimark> re
2008-07-16T17:02:18 <mmihaljevic> dreimark: ThomasWaldmann gave me some advices do I'm fixing it
2008-07-16T17:02:19 * dreimark wonders if we will get a backend name grmpf
2008-07-16T17:02:31 <LotekThirteen> did you know that the textchas not working if the user chose a language witch has no textchas integrated (I switches my default language from en to de and do not receive any more any textcha questions)
2008-07-16T17:02:33 <mmihaljevic> :))
2008-07-16T17:02:59 <dreimark> ThomasWaldmann: ^^
2008-07-16T17:03:06 <LotekThirteen> it's happen on moinmo.in
2008-07-16T17:04:00 <dreimark> LotekThirteen: probably a not wanted feature ;)
2008-07-16T17:04:27 <LotekThirteen> yep! because moinmoin is supporting a lot of different languages...
2008-07-16T17:04:52 <LotekThirteen> for me it's okey; I do not have fill out "stupid" questions *hehe*
2008-07-16T17:06:16 <LotekThirteen> dreimark: maybe also a security flaw; because if the wiki use the language from the browser; you could easy bypass the textchas...
2008-07-16T17:08:31 <dreimark> LotekThirteen: I don't think it can be named a security flaw because it is not related to any protection of pages
2008-07-16T17:09:45 <dreimark> LotekThirteen: we will fix it till sunday and the other one too
2008-07-16T17:10:47 <ThomasWaldmann> LotekThirteen: that is intended :) it's not a bug, but a feature or my configuration.
2008-07-16T17:10:59 <dreimark> mmihaljevic: following the pastebins is difficult
2008-07-16T17:10:59 <LotekThirteen> dreimark: sure; it's more a trick for spammer; well I was just wondering why I never got any textcha questions...
2008-07-16T17:11:34 <ThomasWaldmann> s/or my/of my/
2008-07-16T17:12:29 <mmihaljevic> dreimark: I will change them and send you the working one or none working if I won't suceed to fix it
2008-07-16T17:13:44 <LotekThirteen> ThomasWaldmann: But I do not want to add to any possible language a textcha? Maybe should work like 1. if textcha is true and 2. language has no textcha 3. then editing is not possible?
2008-07-16T17:14:22 <LotekThirteen> eeh.. bullshit what I said!
2008-07-16T17:14:33 <ThomasWaldmann> if you do not define a language in the textchas dict, it will fall back to your default_lang or 'en'
2008-07-16T17:14:52 <LotekThirteen> ThomasWaldmann: yeah you right! So need to go, thx and bye
2008-07-16T17:15:01 <ThomasWaldmann> what I did is to define an empty list of q/a for 'de' - in that case you don't get questions
2008-07-16T17:15:22 <LotekThirteen> I understand :-)
2008-07-16T17:15:23 <LotekThirteen> bye
2008-07-16T17:15:32 <dreimark> LotekThirteen: I add you to the trusted group
2008-07-16T17:28:26 <CIA-53> Florian Krupicka <florian.krupicka@googlemail.com> default * 3913:31fb12b2deb5 1.8-wsgi-fkrupicka/MoinMoin/web/contexts.py: Fixed: small errors in send_file
2008-07-16T17:28:27 <CIA-53> Florian Krupicka <florian.krupicka@googlemail.com> default * 3914:54b6f63ae411 1.8-wsgi-fkrupicka/MoinMoin/wsgiapp.py: Removed old send_file code which was ported from request_wsgi
2008-07-16T17:28:28 <CIA-53> Florian Krupicka <florian.krupicka@googlemail.com> default * 3915:b2df0c84140f 1.8-wsgi-fkrupicka/MoinMoin/action/AttachFile.py: Fixed handling of if_modified headers (threw exception on attachment-get)
2008-07-16T17:32:54 * dreimark plays with 1.8-guieditor-mbyeongweon
2008-07-16T17:34:25 <zenhase> your playing with his repo? :)
2008-07-16T17:34:30 <dreimark> yeah
2008-07-16T17:35:50 <dreimark> xorAxAx: byegonweon how should I report problems ?
2008-07-16T17:36:20 <xorAxAx> dreimark: check the bug tracker if there is already a bug report, if not, create one and link it on http://moinmo.in/MoonByeongweon/SOC2008
2008-07-16T17:36:35 <dreimark> ok
2008-07-16T17:45:01 <dreimark> xorAxAx: hmm, I do see MoinMoin: Release 1.7.0rc1 in SystemInfo of his repo. incomplete merge ?
2008-07-16T17:45:36 <dreimark> byegonweon: why isn't that not based on 1.8
2008-07-16T17:46:32 <xorAxAx> dreimark: no idea
2008-07-16T17:46:56 <xorAxAx> put that onto the wiki page
2008-07-16T17:51:22 <xorAxAx> probably its just younger than the last time he pulled main
2008-07-16T18:00:09 <dreimark> byegonweon: please can you subscribe to MoonByeongweon/SOC2008
2008-07-16T18:12:41 <dreimark> zenhase: if I want to play with your repo would it make sense on the current state and is there some docu already what I need to do?
2008-07-16T18:13:15 <CIA-53> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 4307:fac1da5c4617 1.8-storage-cdenter/MoinMoin/ (PageEditor.py wikiutil.py):
2008-07-16T18:13:15 <CIA-53> storage: hook-up-process:
2008-07-16T18:13:15 <CIA-53> * First set of changes to PageEditor.py
2008-07-16T18:13:15 <CIA-53> * Rewriting edit-lock-methods
2008-07-16T18:13:15 <CIA-53> * Moved edit-lock-methods to wikiutil.py
2008-07-16T18:13:38 <dennda> johill: Can you look at those changes?
2008-07-16T18:18:04 <zenhase> dreimark: uhm, not directly .. the script i use to run the standalone server is a quick hack right now directly in my test-installation
2008-07-16T18:18:19 <zenhase> dreimark: but i guess i could make this into something more sophisticated this week, so others can start playing
2008-07-16T18:18:45 <xorAxAx> zenhase: that was one of thomas ideas today - to make it startable through the moin script
2008-07-16T18:18:50 <zenhase> i will start documentation soon too
2008-07-16T18:18:55 <zenhase> yes
2008-07-16T18:19:11 <zenhase> i already took a look at that
2008-07-16T18:19:23 <zenhase> should not be hard to do :)
2008-07-16T18:19:28 <dreimark> good :)
2008-07-16T18:36:19 <dreimark> ThomasWaldmann: xorAxAx may be we should have a public testwiki of the byegonweon fck editor changes
2008-07-16T18:38:09 <dreimark> bbl
2008-07-16T18:39:24 <xorAxAx> dreimark: why only for his?
2008-07-16T18:48:39 <johill> dennda: sure
2008-07-16T18:49:15 <johill> dennda: import EDIT_LOCK_TIMESTAMP, EDIT_LOCK_ADDR, EDIT_LOCK_HOSTNAME, EDIT_LOCK_USERID
2008-07-16T18:49:18 <johill> ?
2008-07-16T18:50:47 <dennda> oops
2008-07-16T18:50:56 <dennda> nevermind
2008-07-16T19:31:48 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3859:8cb2f4ebd45f 1.8/MoinMoin/ (_tests/test_caching.py caching.py): caching: implemented file-like api (thanks to Thomas Pfaff for the patch)
2008-07-16T19:31:50 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3860:c18d557b5aec 1.8/MoinMoin/caching.py: caching: remember lock in self._lock, handle it in a similar way as self._fileobj
2008-07-16T19:31:50 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3861:be61d38685f5 1.8/MoinMoin/caching.py: caching: more doc-strings, added (c) of Thomas Pfaff, cosmetic changes
2008-07-16T19:31:52 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3862:2526b5b8411f 1.8/MoinMoin/caching.py: caching: always use binary file mode for file-like api
2008-07-16T19:31:54 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3863:6d2f6f954c08 1.8/MoinMoin/caching.py: caching: improve comments/docstrings, better exception handling, use file-like api for contents() and update(), calculate cache file name only once, cleanup
2008-07-16T19:32:40 <PawelPacana> nah, this new cool mercurial features work: memchangeset and memfilechangeset, and finally commitchangeset :)
2008-07-16T19:32:50 <johill> :)
2008-07-16T19:37:26 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3864:6dbeb3669091 1.8/MoinMoin/ (caching.py wikiutil.py): some PEP8 fixes
2008-07-16T19:39:21 <ThomasWaldmann> if someone has time, look at the new caching file-like api (and also at the old functions internally using this api now, too). some tests on windows would be great.
2008-07-16T19:40:36 <ThomasWaldmann> gtg / bbl
2008-07-16T20:40:48 * mmihaljevic is in the midle of the breakeout
2008-07-16T21:57:30 <xorAxAx> byegonweon: please look at http://moinmo.in/MoonByeongweon/SOC2008
2008-07-16T22:09:29 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3865:4ffd618f2826 1.8/MoinMoin/ (action/cache.py caching.py): caching: support file-like content for update(), new size() function. cache action: use file-like api of caching
2008-07-16T22:11:38 <dennda> johill: Is the changeset ok (ignoring that line)?
2008-07-16T22:24:41 <CIA-53> Pawel Pacana <pawel.pacana@gmail.com> default * 4321:8fb13feeec2b 1.8-mercurialbackend-ppacana/MoinMoin/storage/backends/research/test_memory_commit.py: (research) Test showing new possibilities of hg - commits from memory.
2008-07-16T22:33:45 <johill> dennda: sorry was on phone
2008-07-16T22:35:08 <johill> dennda: eh, yeah, it looks ok, I looked at it earlier, I don't much like your way of doing the ### old code stuff but I guess you plan on removing it
2008-07-16T22:41:32 <xorAxAx> any ### sequence in the code at pencil down time will automatically let the student fail :-)
2008-07-16T22:42:57 <johill> heh
2008-07-16T22:48:46 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3866:44275a3436eb 1.8/MoinMoin/caching.py: caching: minor changes
2008-07-16T22:53:15 <dennda> Well, sure that's going to be removed. But it helps me rewrite the snippets (and compare my code to the code we had before, if any problems arise)
2008-07-16T22:53:29 <xorAxAx> yeah i know that
2008-07-16T22:53:29 <dennda> Why do you think I prefix it with three ugly #?
2008-07-16T22:53:35 <dennda> Certainly not for beauty :)
2008-07-16T22:53:48 <johill> :)
2008-07-16T23:43:20 <mmihaljevic> TheSheep: is that yours http://www.thesheepmarket.com/
2008-07-16T23:43:23 <mmihaljevic> :D
2008-07-16T23:46:57 <TheSheep> moonlight and madness
2008-07-16T23:48:21 * johill found a wolf MoinMoin: MoinMoinChat/Logs/moin-dev/2008-07-16 (last edited 2008-07-15 22:15:02 by IrcLogImporter)
