2009-02-27T00:07:40 <dreimark> xorAxAx: if you have time can you change the url on http://gmane.org/info.php?group=gmane.comp.web.wiki.moin.general (seems I am not allowed to do it)
2009-02-27T00:13:05 *** grzywacz has quit IRC
2009-02-27T01:11:51 *** dimazest_ has joined #moin-dev
2009-02-27T01:29:36 *** dimazest has quit IRC
2009-02-27T02:47:06 *** dimazest has joined #moin-dev
2009-02-27T03:03:28 *** dimazest_ has quit IRC
2009-02-27T05:01:15 *** dimazest_ has joined #moin-dev
2009-02-27T05:18:42 *** dimazest has quit IRC
2009-02-27T05:29:17 *** ChanServ has quit IRC
2009-02-27T05:29:17 *** starshine_away has quit IRC
2009-02-27T05:29:17 *** dennda has quit IRC
2009-02-27T05:29:24 *** dimazest has joined #moin-dev
2009-02-27T05:30:45 *** ChanServ has joined #moin-dev
2009-02-27T05:30:45 *** starshine_away has joined #moin-dev
2009-02-27T05:30:45 *** dennda has joined #moin-dev
2009-02-27T05:30:45 *** irc.freenode.net sets mode: +o ChanServ
2009-02-27T05:44:13 *** dimazest_ has quit IRC
2009-02-27T07:07:37 *** starGaming has quit IRC
2009-02-27T08:00:47 *** dimazest has quit IRC
2009-02-27T08:31:18 *** dimazest has joined #moin-dev
2009-02-27T08:35:45 *** dimazest has quit IRC
2009-02-27T09:46:56 *** dimazest has joined #moin-dev
2009-02-27T09:55:00 *** dimazest has quit IRC
2009-02-27T10:06:40 *** TheSheep has joined #moin-dev
2009-02-27T10:44:38 *** dimazest has joined #moin-dev
2009-02-27T10:47:53 *** dimazest has quit IRC
2009-02-27T10:51:03 *** dimazest has joined #moin-dev
2009-02-27T11:28:02 *** TheSheep has quit IRC
2009-02-27T11:42:45 *** dimazest has joined #moin-dev
2009-02-27T13:11:47 *** TheSheep has joined #moin-dev
2009-02-27T13:58:29 *** dimazest has joined #moin-dev
2009-02-27T14:20:36 *** dimazest_ has joined #moin-dev
2009-02-27T14:37:06 *** dimazest has quit IRC
2009-02-27T14:50:29 <dreimark> moin
2009-02-27T15:21:14 *** starGaming has joined #moin-dev
2009-02-27T16:31:04 *** coreyleong has joined #moin-dev
2009-02-27T17:07:29 *** dimazest_ has quit IRC
2009-02-27T19:42:22 *** starGaming- has joined #moin-dev
2009-02-27T19:43:10 *** starGaming has quit IRC
2009-02-27T19:58:41 *** coreyleong has quit IRC
2009-02-27T21:33:22 *** mitsuhiko has joined #moin-dev
2009-02-27T21:33:27 <mitsuhiko> let's move that over here
2009-02-27T21:33:43 <mitsuhiko> you wouldn't even have to use virtualenv
2009-02-27T21:34:00 <mitsuhiko> just provide a setup.exe for windows users that installs moin moin + dependencies into progra~1
2009-02-27T21:39:45 <ThomasWaldmann> how does that help?
2009-02-27T21:41:12 <mitsuhiko> a windows user only has to click?
2009-02-27T21:41:57 <ThomasWaldmann> who creates that setup.exe and how?
2009-02-27T21:42:11 <mitsuhiko> nsis creates it
2009-02-27T21:42:17 <mitsuhiko> how? with the tool for it?
2009-02-27T21:42:32 <mitsuhiko> i don't quite see the problem
2009-02-27T21:42:58 <ThomasWaldmann> i guess you need windows for that
2009-02-27T21:43:18 <mitsuhiko> of course
2009-02-27T21:44:12 <ThomasWaldmann> then we'll stay with the current method as obviously none of our developers likes working with windows
2009-02-27T21:44:43 * ThomasWaldmann does not even have windows on his main machines
2009-02-27T21:46:50 <dennda> virtualbox + windows + 15 minutes of your time = painless handling of dependencies
2009-02-27T21:47:12 <ThomasWaldmann> btw, we import werkzeug and the other stuff quite normally, so if someone kills it from MoinMoin/support, but has it at another place in a compatible version, it's no problem
2009-02-27T21:47:39 <mitsuhiko> that doesn't solve the headaches it will cause
2009-02-27T21:47:44 <ThomasWaldmann> dennda: 1ghz, 1gb, 8gb
2009-02-27T21:47:49 <mitsuhiko> at least it causes me where i try to get werkzeug imported form somewhere else right now
2009-02-27T21:48:07 <mitsuhiko> ThomasWaldmann: rdp into someone else's box
2009-02-27T21:48:09 <vpv> Fedora recently had a package called mingw-nsis added, but I have no idea how one would use (nor the interest, really)
2009-02-27T21:48:31 <mitsuhiko> apollo13 from #pocoo lends me his virtualized box via network every once in a while
2009-02-27T21:50:20 <ThomasWaldmann> yes, rdp would work, assuming that there is a windows machine somewhere
2009-02-27T21:50:32 <ThomasWaldmann> still, it would require someone doing that windows stuff
2009-02-27T21:50:58 <ThomasWaldmann> currently we have about 0 additional effort for windows
2009-02-27T21:51:18 <ThomasWaldmann> s/effort/packaging effort/
2009-02-27T21:51:39 <mitsuhiko> well. the moin windows installation is incredible complex
2009-02-27T21:51:50 <ThomasWaldmann> it's not.
2009-02-27T21:51:51 <mitsuhiko> even pylons installs easier on windows, and that is command line driven
2009-02-27T21:51:54 <mitsuhiko> i failed -.-
2009-02-27T21:52:01 <ThomasWaldmann> unpack and run
2009-02-27T21:57:22 *** dimazest has joined #moin-dev
2009-02-27T21:58:10 <mitsuhiko> ThomasWaldmann: so how do you switch dependencies temporarily?
2009-02-27T21:58:15 <mitsuhiko> delete from support?
2009-02-27T21:59:14 <ThomasWaldmann> mv werkzeug werkzeugfoo
2009-02-27T22:00:02 <ThomasWaldmann> (and move it back at the end in case it is a hg workdir)
2009-02-27T22:00:29 <mitsuhiko> -.-
2009-02-27T22:00:38 <mitsuhiko> ThomasWaldmann: "data_underlay_dir "/Users/mitsuhiko/Development/moin-1.9/wiki/underlay" does not exist, or has incorrect ownership or
2009-02-27T22:00:39 <mitsuhiko> permissions."
2009-02-27T22:00:42 <mitsuhiko> where to get that folder?
2009-02-27T22:01:56 <mitsuhiko> found it. why is that a tarball?
2009-02-27T22:02:22 <ThomasWaldmann> tar xf underlay.tar
2009-02-27T22:02:45 <ThomasWaldmann> because we don't want all the files separately in the repo
2009-02-27T22:03:11 <mitsuhiko> ThomasWaldmann: data_underlay_dir "/Users/mitsuhiko/Development/moin-1.9/wiki/underlay" does not exist, or has incorrect ownership or
2009-02-27T22:03:11 <mitsuhiko> permissions.
2009-02-27T22:03:12 <mitsuhiko> eh
2009-02-27T22:03:15 <ThomasWaldmann> (in the releases, it is unpacked)
2009-02-27T22:03:18 <mitsuhiko> ThomasWaldmann: http://paste.pocoo.org/show/105832/
2009-02-27T22:04:08 <ThomasWaldmann> if you just run wikiserver.py as same user as you used for unpacking the stuff, it'll work
2009-02-27T22:04:23 <ThomasWaldmann> if you need to run it as another user, you have to fix permissions for that user
2009-02-27T22:04:45 <mitsuhiko> that change however requires werkzeug > 0.3
2009-02-27T22:04:57 <mitsuhiko> because in werkzeug 0.3 "stream" was still available on the base response
2009-02-27T22:05:06 <mitsuhiko> which would break the mro
2009-02-27T22:08:33 <ThomasWaldmann> why did you delete in_*
2009-02-27T22:08:41 <mitsuhiko> ThomasWaldmann: unused
2009-02-27T22:09:43 <mitsuhiko> ah bullshit. that is actually using Response, so the mro should be still broken for stream
2009-02-27T22:12:13 <mitsuhiko> looking at it i suppose a ton more is broken
2009-02-27T22:12:27 <mitsuhiko> the code is actually writing stuff into response.stream like it would write into an arbitrary stream
2009-02-27T22:12:41 <mitsuhiko> however a response stream sends a flush after writing, slowing things down
2009-02-27T22:14:21 <ThomasWaldmann> "the code" == moin code?
2009-02-27T22:14:28 <mitsuhiko> yep
2009-02-27T22:15:09 <ThomasWaldmann> you mean request.write(...)?
2009-02-27T22:15:14 <mitsuhiko> yes
2009-02-27T22:15:29 <mitsuhiko> i could swear that was a stringio during soc
2009-02-27T22:16:10 <ThomasWaldmann> hg annotate :)
2009-02-27T22:17:37 <mitsuhiko> ThomasWaldmann: does the moin core still use context.write() all over the place?
2009-02-27T22:18:40 <ThomasWaldmann> it has been improved,but still lots of places use that
2009-02-27T22:18:58 <ThomasWaldmann> esp. actions
2009-02-27T22:20:01 <mitsuhiko> oh boy. everything uses write as it seems somehow
2009-02-27T22:20:08 <mitsuhiko> tricky
2009-02-27T22:22:19 <mitsuhiko> anyhow. that should make it work: http://paste.pocoo.org/show/105843/
2009-02-27T22:25:48 <ThomasWaldmann> why did you delete that script_root if -- patch:43?
2009-02-27T22:48:13 <ThomasWaldmann> mitsuhiko:
2009-02-27T22:48:35 <mitsuhiko> ThomasWaldmann: i did not delete it, i changed it to script_root or "/"
2009-02-27T22:48:39 <mitsuhiko> which does the same but is easier to maintain
2009-02-27T22:48:43 <mitsuhiko> DRY
2009-02-27T22:50:00 <ThomasWaldmann> ah, overlooked that
2009-02-27T22:52:16 <ThomasWaldmann> mitsuhiko: ok, so that diff is the final one, shall I try that?
2009-02-27T22:53:20 <mitsuhiko> ThomasWaldmann: yep
2009-02-27T22:54:17 * ThomasWaldmann tries
2009-02-27T22:57:32 <ThomasWaldmann> patch unexpectedly ends in middle of line
2009-02-27T22:58:19 <ThomasWaldmann> caused by the final \n missing
2009-02-27T22:58:34 <ThomasWaldmann> (DLed it with wget)
2009-02-27T23:11:27 <ThomasWaldmann> mitsuhiko:
2009-02-27T23:11:29 <ThomasWaldmann> - def __init__(self, environ, populate_request=True, shallow=False,
2009-02-27T23:11:29 <ThomasWaldmann> - response=None, status=None, headers=None, mimetype=None,
2009-02-27T23:11:29 <ThomasWaldmann> - content_type=None):
2009-02-27T23:11:51 <ThomasWaldmann> your new code doesn't have all those args. did you check all callers?
2009-02-27T23:12:08 <mitsuhiko> i acked and did not find anything creating request objects as responses
2009-02-27T23:13:08 <ThomasWaldmann> acked?
2009-02-27T23:15:25 <ronny> oh my
2009-02-27T23:15:49 * ThomasWaldmann tests with old werkzeug code
2009-02-27T23:22:16 <ThomasWaldmann> mitsuhiko: changeset comment?
2009-02-27T23:22:37 <mitsuhiko> changed code to support latest werkzeug version?
2009-02-27T23:23:46 <ThomasWaldmann> i didn't test the new werkzeug code yet, it works with the old code
2009-02-27T23:24:25 <ThomasWaldmann> and do you prefer your nick or your realname in the comment?
2009-02-27T23:25:12 <mitsuhiko> nick
2009-02-27T23:25:21 <mitsuhiko> well. project policy
2009-02-27T23:26:21 <ThomasWaldmann> project policy is real names, usually
2009-02-27T23:35:33 <ThomasWaldmann> mitsuhiko: file upload broken with werkzeug 0.5
2009-02-27T23:38:08 <mitsuhiko> ThomasWaldmann: what's "broken"?
2009-02-27T23:38:09 <mitsuhiko> traceback?
2009-02-27T23:38:36 <ThomasWaldmann> it tells empty file content
2009-02-27T23:38:47 <ThomasWaldmann> no tb
2009-02-27T23:40:55 <mitsuhiko> ThomasWaldmann: how is moin handling files?
2009-02-27T23:41:06 <mitsuhiko> is it using werkzeug's file upload support or something custom?
2009-02-27T23:41:21 <mitsuhiko> if it's not using, it is now
2009-02-27T23:41:40 <mitsuhiko> well. i changed read() to point to the in_stream
2009-02-27T23:41:45 <mitsuhiko> because the older call was not wsgi compliant
2009-02-27T23:42:03 <mitsuhiko> which however means that moin has to use request.files then
2009-02-27T23:42:17 <mitsuhiko> well. in that case revert the def read() change in contexts.py
2009-02-27T23:42:45 <ThomasWaldmann> file_upload = request.files.get('file')
2009-02-27T23:42:45 <ThomasWaldmann> if not file_upload:
2009-02-27T23:42:45 <ThomasWaldmann> # This might happen when trying to upload file names
2009-02-27T23:42:45 <ThomasWaldmann> # with non-ascii characters on Safari.
2009-02-27T23:42:45 <ThomasWaldmann> return _("No file content. Delete non ASCII characters from the file name and try again.")
2009-02-27T23:42:50 <ThomasWaldmann> this triggers
2009-02-27T23:43:41 <mitsuhiko> weird
2009-02-27T23:44:37 <ThomasWaldmann> and i tried the same code (including your patch) with old werkzeug and it worked
2009-02-27T23:45:19 <mitsuhiko> the werkzeug file upload works, there are unittests
2009-02-27T23:46:52 <mitsuhiko> okay. FileStorage is falsy now
2009-02-27T23:47:25 <mitsuhiko> i'll get rid of FileStorage.__len__
2009-02-27T23:48:26 <mitsuhiko> changed in latest werkzeug
2009-02-27T23:48:32 <mitsuhiko> FileStorage is now always truthy
2009-02-27T23:50:12 <ThomasWaldmann> :)
2009-02-27T23:55:03 <ThomasWaldmann> mitsuhiko: no change
2009-02-27T23:56:05 <mitsuhiko> ThomasWaldmann: but now
2009-02-27T23:58:04 <ThomasWaldmann> yeah, works
2009-02-27T23:58:28 * ThomasWaldmann runs unit tests MoinMoin: MoinMoinChat/Logs/moin-dev/2009-02-27 (last edited 2009-02-26 23:15:02 by IrcLogImporter)
