2009-07-13T00:58:04 *** grzywacz has quit IRC
2009-07-13T02:00:41 <CIA-78> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6063:ecbafb144025 2.0-storage/MoinMoin/storage/backends/__init__.py: copy item / clone backend: reduce code duplication
2009-07-13T04:17:49 *** amartani has joined #moin-dev
2009-07-13T04:18:15 *** amartani has joined #moin-dev
2009-07-13T07:10:29 *** devilsadvocate_ has joined #moin-dev
2009-07-13T07:11:47 *** devilsadvocate has quit IRC
2009-07-13T08:02:23 <ThomasWaldmann> moin
2009-07-13T09:13:45 <dreimark> moin
2009-07-13T09:24:22 *** amartani has quit IRC
2009-07-13T09:31:01 <dreimark> ThomasWaldmann: I see Forbidden\nYou may not destroy revisions of 'UserGroup'.
2009-07-13T09:31:41 <ronny> ThomasWaldmann: isnt destroy_revision impossible in some cases?
2009-07-13T09:31:49 <ronny> (like backing wit a dvcs)
2009-07-13T09:32:34 <dreimark> yes
2009-07-13T09:32:36 <dreimark> ChristopherDenter has introduced a "destroy" permission, a "destroy item" and "destroy revision" storage api method (it was required by inter-backend item rename and it is useful also for other purposes), the hg backend needs to somehow deal with it (it can't really destroy stuff internally of course, but maybe it could be simulated somehow)
2009-07-13T09:32:46 <dreimark> from http://moinmo.in/PawelPacana
2009-07-13T09:35:55 <dreimark> ronny: ^^
2009-07-13T10:25:34 <dreimark> dimazest: 2 failing tests
2009-07-13T10:25:37 <dreimark> http://paste.pocoo.org/show/128220/
2009-07-13T10:25:54 <dreimark> tested in a fresh clone of your repo
2009-07-13T12:34:10 <dimazest> dreimark: you have 2 failing test on a whole MoinMoin ?
2009-07-13T12:34:15 <dreimark> yes
2009-07-13T12:34:36 <dimazest> i have 4...
2009-07-13T12:34:51 <dimazest> i need to do testing on linux
2009-07-13T12:34:56 <dreimark> I have done a fresh clone from hg.m...
2009-07-13T12:35:02 <dreimark> untared underlay
2009-07-13T12:35:10 <dreimark> run py.test
2009-07-13T12:35:18 <dimazest> which python and py.test versions?
2009-07-13T12:37:44 <dreimark> python 2.6.2 where does py.test show the version?
2009-07-13T12:39:33 <dimazest> i think py.test is not a big problem
2009-07-13T12:39:41 <dimazest> i use python 2.4
2009-07-13T12:41:55 <dreimark> dimazest: you have too (because that is the requirement)
2009-07-13T12:42:14 <dreimark> I have in an other setup 3 failing tests
2009-07-13T12:42:17 <dreimark> but not 4
2009-07-13T12:43:03 <dreimark> I thing it is not a dependency of the python version
2009-07-13T12:43:32 * dreimark tries to create a real live example from the failing test_groups_with_member
2009-07-13T12:47:01 <dimazest> dreimark: i have 3 failing tests
2009-07-13T12:49:15 <dimazest> MoinMoin/macro/_tests/test_EmbedObject.py:39: TestEmbedObject.testEmbedObjectMimetype FAIL
2009-07-13T12:49:31 <dimazest> MoinMoin/datastruct/backends/_tests/__init__.py:76: TestWikiGroupBackend.test_groups_with_member FAIL
2009-07-13T12:50:17 <dreimark> embed_object failes likly because of a difference in mimetype definition or missing mimetype definition
2009-07-13T12:50:28 <dreimark> on the targt system
2009-07-13T12:51:08 <dreimark> which mimetype does it not know?
2009-07-13T12:52:41 <dimazest> E assert 'image/svg+xml' in u'Current configuration does not allow embedding of the file test.svg because ...eForEmbedObject?action=AttachFile&do=get&target=test.svg">test.svg</a>'
2009-07-13T12:53:35 <dreimark> grep svg /etc/mime.types ?
2009-07-13T12:53:58 <dimazest> grep: /etc/mime.types: No such file or directory
2009-07-13T12:54:33 <dreimark> looks like not to be linux?
2009-07-13T12:54:44 <dimazest> yes, i'm on mac
2009-07-13T12:58:56 <dreimark> dimazest: import mimetypes
2009-07-13T12:59:02 <dreimark> mimetypes.knownfiles
2009-07-13T12:59:22 <dreimark> that should list the files of mimetype definitions
2009-07-13T13:01:29 <dimazest> ['/etc/mime.types', '/usr/local/etc/httpd/conf/mime.types', '/usr/local/lib/netscape/mime.types', '/usr/local/etc/httpd/conf/mime.types', '/usr/local/etc/mime.types']
2009-07-13T13:01:43 <dimazest> but i do not have these files
2009-07-13T13:02:46 <dreimark> interesting seems we need to figure how mimetypes work with mac. and it looks like there is an unresolved dependeny here
2009-07-13T13:02:56 <dreimark> +c
2009-07-13T13:03:10 <dreimark> I have a question:
2009-07-13T13:03:33 <dreimark> when test_wiki_groups becomes executed
2009-07-13T13:03:48 <dreimark> it is inherited from GroupsBackendTest
2009-07-13T13:04:10 <dimazest> yes
2009-07-13T13:04:27 <dreimark> that executes test_groups_with_member from the __init__
2009-07-13T13:05:04 <dreimark> groups = self.request.groups
2009-07-13T13:06:59 <dimazest> yes
2009-07-13T13:07:00 <dreimark> which groups denition is that on this point
2009-07-13T13:10:29 <dimazest> i do not know, do you mean from GroupsBackendTest or TestWikiGroupBackend
2009-07-13T13:16:05 <dreimark> ah figured it
2009-07-13T13:20:12 <dimazest> dreimark: request.groups['SystemPagesInSimplifiedChineseGroup'] returns an error
2009-07-13T13:42:08 <dreimark> this one is knows because of the i18n changes all these lang groups don't exists anymore
2009-07-13T13:43:18 <dimazest> dreimark: then tests/wiki/underlay/ should be updated
2009-07-13T13:43:24 <dreimark> the translation of pages was changed and there is no need for organizing them in a group apge
2009-07-13T13:43:35 <dreimark> dimazest: yes
2009-07-13T13:43:43 <dreimark> but it needs translators
2009-07-13T13:44:09 <dreimark> http://master19.moinmo.in/FrontPage?action=CheckTranslation
2009-07-13T13:44:18 <dreimark> that is the new way foing it
2009-07-13T13:44:27 <dreimark> s/f/d/
2009-07-13T13:45:53 * dreimark wants to have integrated your groups and dicts code before beta3
2009-07-13T13:46:22 <dreimark> at this time we get an update of underlay
2009-07-13T13:47:17 <dimazest> dreimark: another question is dicts, after using formatter, they are working in a different way
2009-07-13T13:47:25 <dimazest> if there is
2009-07-13T13:47:35 <dimazest> key:: [[some link]]
2009-07-13T13:47:46 <dimazest> dict will return "some link"
2009-07-13T13:48:22 <dimazest> and there is an issue when different markups are used
2009-07-13T13:49:42 <dreimark> you could currently check if the format is wiki and raise not implemented for any other
2009-07-13T13:55:21 <dimazest> dreimark: i mean http://paste.pocoo.org/show/128257/
2009-07-13T13:56:46 <dreimark> if you want to render the markup you can call wikiutil.renderText
2009-07-13T13:58:04 <dreimark> waldi is working on a domtree refactoring.
2009-07-13T13:58:24 <dreimark> this is planned to merge after 2.0
2009-07-13T13:59:30 <dimazest> dreimark: but then is a question, what dict formatter should return
2009-07-13T14:03:02 <dreimark> can it return "this format is for dicts not implemented yet" ?
2009-07-13T14:03:53 <dimazest> but when you do dicts.[myDict][myKey]
2009-07-13T14:04:01 <dimazest> we get just a string
2009-07-13T14:04:13 <dreimark> hmm
2009-07-13T15:18:14 <dreimark> dimazest: if we define a dict regex becomes this easier?
2009-07-13T15:20:24 <dreimark> no, we have that already page_dict_regex.
2009-07-13T15:22:09 *** PawelPacana has joined #moin-dev
2009-07-13T15:22:21 <PawelPacana> moin
2009-07-13T15:23:21 <dreimark> dennda: ping
2009-07-13T15:23:27 <dreimark> moin PawelPacana
2009-07-13T15:23:42 <PawelPacana> ThomasWaldmann: dreimark: i've read your comments on wiki, i think i'll find some time at evening
2009-07-13T15:23:54 <dreimark> PawelPacana: very good
2009-07-13T15:23:59 <PawelPacana> and during that week in general
2009-07-13T15:24:08 <dreimark> even better :)
2009-07-13T15:24:30 <dreimark> you missed the europython in birmingham and all that english food
2009-07-13T15:24:46 <dennda> dreimark: pong
2009-07-13T15:25:09 <PawelPacana> yeah, I had to choose EP or Open'er festival - dates were clashing
2009-07-13T15:25:09 <dennda> PawelPacana: great, nice to see you
2009-07-13T15:25:24 <PawelPacana> and I bought tickets earlier
2009-07-13T15:26:30 <dennda> PawelPacana: a) there's both hg.py and newhg.py. I guess one of them can be dropped as the patch needed made it into mercurial trunk (afaik). b) there's a few test cases failing for the hg backend. some fail due to two new methods that were added to the storage api
2009-07-13T15:26:48 <dreimark> dimazest: http://paste.pocoo.org/show/128288/ please have a look if this is the right place for doing so. with that it is only 1 test_lock failure left over
2009-07-13T15:28:16 <PawelPacana> dennda: a) true, I've seen it on recent version of mercurial, it confused me a bit at first
2009-07-13T15:30:48 <PawelPacana> ok, see you later then
2009-07-13T15:33:18 <TheSheep> btw, hg 1.3 changed the api
2009-07-13T15:33:34 <TheSheep> they removed a bucnh of parameters from constructors, like empty_ok
2009-07-13T15:33:48 <TheSheep> and the 'files' parameter to commit
2009-07-13T15:34:12 <TheSheep> you are supposed to use 'match' instead, with mercurial.match.exact
2009-07-13T16:10:21 <dimazest> dreimark: may this is better http://paste.pocoo.org/show/128297/
2009-07-13T16:10:48 <dimazest> i do not like that request.page can be overwritten
2009-07-13T16:27:34 *** waldi has quit IRC
2009-07-13T16:27:34 *** ronny has quit IRC
2009-07-13T16:27:59 *** ronny has joined #moin-dev
2009-07-13T16:27:59 *** waldi has joined #moin-dev
2009-07-13T16:35:52 <ThomasWaldmann> PawelPacana: cool :)
2009-07-13T16:36:28 <ThomasWaldmann> currently the hg backend test is skipped, just disable the py.test.skip() call in it
2009-07-13T16:48:44 <dimazest> dreimark: ThomasWaldmann is there a bug in creole http://paste.pocoo.org/show/128312/
2009-07-13T16:59:02 <ThomasWaldmann> looks like it collects target and label
2009-07-13T17:03:50 <dimazest> formatter collects text only
2009-07-13T17:03:57 <dimazest> http://hg.moinmo.in/moin/1.9-groups-dmilajevs/file/982f706482e7/MoinMoin/formatter/groups.py
2009-07-13T17:10:25 <ThomasWaldmann> ehrm
2009-07-13T17:10:52 <ThomasWaldmann> links are allowed and you should collect the link target then
2009-07-13T17:11:16 <ThomasWaldmann> (the old stuff just stripped away [[ and ]] from [[foo]])
2009-07-13T17:11:24 <ThomasWaldmann> (for wiki markup)
2009-07-13T17:12:03 <ThomasWaldmann> didn't you have already code for that?
2009-07-13T17:12:53 <ThomasWaldmann> dimazest: ^^
2009-07-13T17:13:04 <dimazest> no
2009-07-13T17:13:20 <dimazest> because now it collects label, but not the link
2009-07-13T17:15:35 <dimazest> see http://hg.moinmo.in/moin/1.9-groups-dmilajevs/file/982f706482e7/MoinMoin/formatter/_tests/test_groups.py#l51
2009-07-13T17:15:43 <ThomasWaldmann> well, it collected link targets in the past
2009-07-13T17:15:58 <dimazest> so, as i understand it must be changed
2009-07-13T17:16:16 <ThomasWaldmann> i don't think it could copy with anything except [[target]], but if you use the formatter now, you should just use the target and ignore the label
2009-07-13T17:16:38 <ThomasWaldmann> and if there is no link, just collect simple text
2009-07-13T17:16:55 <dimazest> ok
2009-07-13T17:28:31 <dreimark> dimazest: patch looks good
2009-07-13T17:59:05 <xorAxAx> devilsadvocate_: if you need review, you need to ask for it here in the channel
2009-07-13T18:43:18 <dreimark> bbl
2009-07-13T18:58:39 *** grzywacz has joined #moin-dev
2009-07-13T19:16:08 <dennda> ThomasWaldmann: I got a belated reply to my acl mail
2009-07-13T19:26:59 <dennda> ThomasWaldmann: fw'ed, see my comments
2009-07-13T19:38:09 <CIA-78> Dmitrijs Milajevs <dimazest@gmail.com> default * 4838:f0bcf3e1725d 1.9-groups-dmilajevs/wiki/config/more_samples/groups_wikiconfig_snippet: Groups2009: Configuration snippets for groups.
2009-07-13T19:38:12 <CIA-78> Dmitrijs Milajevs <dimazest@gmail.com> default * 4839:f1e75133ab7b 1.9-groups-dmilajevs/MoinMoin/datastruct/backends/wiki_groups.py: Groups2009: TestWikiGroupBackend.test_groups_with_member test was fixed.
2009-07-13T20:43:59 *** devilsadvocate_ has quit IRC
2009-07-13T20:44:35 *** devilsadvocate has joined #moin-dev
2009-07-13T20:44:58 <dreimark> Thanks to Lennie de Rijk, each mentor who has not filled out an
2009-07-13T20:44:58 <dreimark> evaluation will receive a nag email, cc'ed to her organization
2009-07-13T20:44:58 <dreimark> administrator. Students will also be receiving these nag mails, also
2009-07-13T20:44:58 <dreimark> cc'ed to their organization administrators. In order to give everyone
2009-07-13T20:44:58 <dreimark> the most opportunity to fill out the evaluations since we were only
2009-07-13T20:45:01 <dreimark> able to implement reminders this weekend, we've pushed out the
2009-07-13T20:45:14 <dreimark> deadline by four hours to 23:00 UTC today.
2009-07-13T22:13:40 <PawelPacana> re
2009-07-13T22:23:37 <PawelPacana> 2.0-storage?
2009-07-13T22:24:29 <dennda> yes
MoinMoin: MoinMoinChat/Logs/moin-dev/2009-07-13 (last edited 2009-07-12 23:00:01 by IrcLogImporter)
