MoinMoin: MoinMoinChat/Logs/moin-dev/2009-11-26

   1 2009-11-26T00:19:47  *** dainbrain has joined #moin-dev
   2 2009-11-26T00:29:58  *** grzywacz has quit IRC
   3 2009-11-26T00:30:12  *** JosefMeier has quit IRC
   4 2009-11-26T01:43:56  *** dainbrain has quit IRC
   5 2009-11-26T03:42:30  *** xorAxAx has quit IRC
   6 2009-11-26T04:15:33  *** xorAxAx has joined #moin-dev
   7 2009-11-26T04:38:22  *** ronny has quit IRC
   8 2009-11-26T04:38:22  *** waldi has quit IRC
   9 2009-11-26T04:38:22  *** dreimark has quit IRC
  10 2009-11-26T04:38:22  *** vpv has quit IRC
  11 2009-11-26T04:38:22  *** dennda has quit IRC
  12 2009-11-26T04:38:22  *** tpfennig has quit IRC
  13 2009-11-26T04:38:22  *** ser has quit IRC
  14 2009-11-26T04:40:33  *** tpfennig has joined #moin-dev
  15 2009-11-26T04:40:33  *** ser has joined #moin-dev
  16 2009-11-26T04:40:33  *** ronny has joined #moin-dev
  17 2009-11-26T04:40:33  *** dennda has joined #moin-dev
  18 2009-11-26T04:40:33  *** dreimark has joined #moin-dev
  19 2009-11-26T04:40:33  *** waldi has joined #moin-dev
  20 2009-11-26T04:40:33  *** vpv has joined #moin-dev
  21 2009-11-26T09:36:10  <ThomasWaldmann> moin
  22 2009-11-26T09:36:22  * ThomasWaldmann looks at josef's code
  23 2009-11-26T09:39:05  <ThomasWaldmann> hmm, usage of request.getScriptname() should fill the logs with deprecation warnings
  24 2009-11-26T09:41:50  <ThomasWaldmann> l68..71 can be easily done in a single line, using x = y or z
  25 2009-11-26T09:46:02  <ThomasWaldmann> l73..75 look like they are not needed (and even wrong for the somewhat strange, but existing usecase of a deleted page that has attachments)
  26 2009-11-26T09:48:42  <ThomasWaldmann> l83 has to be checked for XSS / missing escaping
  27 2009-11-26T09:53:21  <ThomasWaldmann> l149 onkeyup="OnPagenameChange();" onchange="OnPagenameChange();" is that both needed?
  28 2009-11-26T09:54:02  <ThomasWaldmann> l159 same q.
  29 2009-11-26T10:05:34  <ThomasWaldmann> l1.144 + 149 hardcoded colours
  30 2009-11-26T10:07:49  <ThomasWaldmann> l1.192 doesn't that already exist???
  31 2009-11-26T10:15:07  <ThomasWaldmann> l1.241..244 has confusing names, maybe rather use attachmentName on the left side
  32 2009-11-26T10:19:11  <ThomasWaldmann> l1.278+ wtf?
  33 2009-11-26T10:25:34  <ThomasWaldmann> line numbers refer to:
  34 2009-11-26T10:25:37  <ThomasWaldmann> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/bec06fa7f2aa
  35 2009-11-26T10:32:16  <ThomasWaldmann> that "LanguageString()" (l1.278+) stuff has to be removed completely. it is just used at 2 places and those 2 places should be done differently.
  36 2009-11-26T10:34:06  <ThomasWaldmann> if you don't want that empty pagename or empty attachname is submitted, I suggest you just do not enable OK submit button if those fields are empty.
  37 2009-11-26T10:42:02  <ThomasWaldmann> <a href="test.pdf" title="attachment:test.pdf">test.pdf</a>
  38 2009-11-26T10:43:06  <ThomasWaldmann> that href is not really useful. it looks like this works by ignoring href in the converter and just using what title contains. :)
  39 2009-11-26T10:45:31  <ThomasWaldmann> of one edits the attachment name, it doesn't even change the href
  40 2009-11-26T11:18:31  <dreimark> moin
  41 2009-11-26T11:36:11  <ThomasWaldmann> hi dreimark
  42 2009-11-26T12:56:03  *** vinci_ has joined #moin-dev
  43 2009-11-26T13:12:58  *** tpfennig has quit IRC
  44 2009-11-26T15:18:39  *** vinci_ has quit IRC
  45 2009-11-26T16:26:50  *** vinci_ has joined #moin-dev
  46 2009-11-26T19:42:53  *** vinci__ has joined #moin-dev
  47 2009-11-26T19:58:04  *** vinci_ has quit IRC
  48 2009-11-26T20:28:06  *** vinci__ is now known as tpfennig
  49 2009-11-26T20:44:12  *** grzywacz has joined #moin-dev
  50 2009-11-26T22:10:49  <dreimark> re
  51 2009-11-26T22:11:49  <ThomasWaldmann> hi dreimark
  52 2009-11-26T22:13:49  <dreimark> lots of work because of hardware defects (normally that happens in may)
  53 2009-11-26T22:15:01  <ThomasWaldmann> disks?
  54 2009-11-26T22:15:17  <dreimark> yeah and graphic cards
  55 2009-11-26T22:53:21  *** JosefMeier has joined #moin-dev
  56 2009-11-26T23:14:09  *** JosefMeier has quit IRC
  57 2009-11-26T23:52:42  *** JosefMeier has joined #moin-dev
  58