MoinMoin: MoinMoinChat/Logs/moin-dev/2010-03-09

   1 2010-03-09T00:04:39  <ThomasWaldmann> looks clean, but still looking and trying to get an overview
   2 2010-03-09T00:09:15  * dreimark never heard about storm
   3 2010-03-09T00:14:23  <dreimark> ThomasWaldmann: where do you've got the source from gh?
   4 2010-03-09T00:14:31  <dreimark> i see lots of dead links
   5 2010-03-09T00:15:17  * dreimark found the hg repo
   6 2010-03-09T00:16:01  <ThomasWaldmann> dreimark: storm is gustavo's db stuff
   7 2010-03-09T00:20:33  <dreimark> gn
   8 2010-03-09T00:21:35  <ThomasWaldmann> gn dreimark
   9 2010-03-09T00:32:18  *** grzywacz has quit IRC
  10 2010-03-09T00:57:53  *** JosefMeier has quit IRC
  11 2010-03-09T15:05:54  <ThomasWaldmann> cool, line-links patch from esyr
  12 2010-03-09T16:06:32  <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5618:b86af2e26465 1.9/MoinMoin/formatter/text_html.py: formatter/text_html: Added line number links to code blocks. Also line number show/hide script cleaned up slightly.
  13 2010-03-09T16:06:37  <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5619:92e6d4ce7049 1.9/ (342 files in 51 dirs): Merge
  14 2010-03-09T16:07:31  <ThomasWaldmann> \o/
  15 2010-03-09T17:49:50  <dreimark> moin
  16 2010-03-09T17:51:31  <dreimark> .oO another merge commit
  17 2010-03-09T18:08:34  *** eSyr has joined #moin-dev
  18 2010-03-09T18:08:50  <eSyr> ThomasWaldmann, http://moinmo.in/4ct10n/info/MoinMoinBugs/AlignTopAlignLeft?action=diff&rev2=5&rev1=4
  19 2010-03-09T18:12:07  <eSyr> (and what about http://paste.pocoo.org/show/186061/ ?)
  20 2010-03-09T18:12:49  <ThomasWaldmann> hi eSyr
  21 2010-03-09T18:12:56  <eSyr> ThomasWaldmann, moin
  22 2010-03-09T18:47:47  <dreimark> ThomasWaldmann: http://moinmo.in/FeatureRequests/SortableTables?action=AttachFile&do=view&target=widget_browser_sort.patch#CA-c2f0075bf2f18200543b920f1a05cf5d04c7ccb2_1
  23 2010-03-09T18:47:57  <dreimark> works with 2.4
  24 2010-03-09T18:58:51  <ThomasWaldmann> you want to apply it to < 1.9?
  25 2010-03-09T19:01:28  * dreimark yes
  26 2010-03-09T19:01:35  <dreimark> no 1.9
  27 2010-03-09T19:02:15  <ThomasWaldmann> we require py2.4 in 1.9, you don't need compatibility code
  28 2010-03-09T19:02:33  <dreimark> ok, the sorted stuff was also there
  29 2010-03-09T19:03:45  * dreimark reverts that change
  30 2010-03-09T19:04:40  <ThomasWaldmann> that is because I didn't feel like fixing all callers in 1.9
  31 2010-03-09T19:04:59  <ThomasWaldmann> or for the case that some 3rd party stuff also used it from there
  32 2010-03-09T19:05:17  <ThomasWaldmann> your param "index" should be rather "sort_keys"
  33 2010-03-09T19:06:04  <ThomasWaldmann> or sort_columns
  34 2010-03-09T19:06:30  <dreimark> sort_columns sounds good
  35 2010-03-09T19:07:32  <ThomasWaldmann> also fix docstring in 80
  36 2010-03-09T19:08:03  <dreimark> ok
  37 2010-03-09T19:14:27  <ThomasWaldmann> that rows2table/table2rows stuff is suspect
  38 2010-03-09T19:20:25  <dreimark> why ?
  39 2010-03-09T19:21:33  <ThomasWaldmann> well, it is transforming one table into another table, right?
  40 2010-03-09T19:22:07  <ThomasWaldmann> and we don't know whether elements are tuples or not?
  41 2010-03-09T19:22:35  <dreimark> the filter function needs tuples.
  42 2010-03-09T19:24:46  <ThomasWaldmann> then, if there is an element "42" and another "foo", you convert the first to Decimal(42) (why Decimal?) and keep the "foo" as is?
  43 2010-03-09T19:26:15  <dreimark> Decimal is to get numerical sorted
  44 2010-03-09T19:26:24  <dreimark> otherwise you get 1 10 100 9
  45 2010-03-09T19:28:24  <ThomasWaldmann> >>> decimal.Decimal("10") < "3,1415"
  46 2010-03-09T19:28:24  <ThomasWaldmann> True
  47 2010-03-09T19:28:44  <ThomasWaldmann> small typo, big effect :D
  48 2010-03-09T19:32:07  <dreimark> decimal.Decimal("10") < decimal.Decimal("3.14")
  49 2010-03-09T19:32:51  <ThomasWaldmann> yes, but your code will choose string comparison if it can't convert
  50 2010-03-09T19:33:33  <ThomasWaldmann> so, if you data is a bit mixed up, outcome might be unexpected
  51 2010-03-09T19:34:55  <dreimark> the numbers are still sorted and the sorted text is at the end
  52 2010-03-09T19:35:24  <ThomasWaldmann> except for the german numbers :P
  53 2010-03-09T19:36:41  <ThomasWaldmann> and if sort compares a Decimal to such a "string number", it'll convert the Decimal to a str also
  54 2010-03-09T19:37:24  <dreimark> http://moinmo.in/ReimarBauer/ExampleSort
  55 2010-03-09T19:37:36  <dreimark> such it loks like if you mix numbers and text
  56 2010-03-09T19:37:42  <ThomasWaldmann> but maybe, as long as you don't know your input data and you must guess, you can't do better
  57 2010-03-09T19:38:04  <dreimark> var1 is sorted
  58 2010-03-09T19:38:59  <ThomasWaldmann> that was a lucky case
  59 2010-03-09T19:39:10  <ThomasWaldmann> add 10 and 3,14
  60 2010-03-09T19:40:45  <dreimark> reload
  61 2010-03-09T19:41:29  <ThomasWaldmann> also, what's the point of having tuples if both elements are the same after rows2table?
  62 2010-03-09T19:44:08  <ThomasWaldmann> looks like it didn't compare "3,14" with "400"
  63 2010-03-09T19:44:42  <dreimark>  3,14 is a string and is compared with Aide and ide
  64 2010-03-09T19:45:16  <ThomasWaldmann> says who?
  65 2010-03-09T19:46:37  * ThomasWaldmann would guess the algorithm works on all values and compares the ones as determined by the algorithm
  66 2010-03-09T19:48:30  <ThomasWaldmann> 68..77 need to be rewritten
  67 2010-03-09T19:48:39  <ThomasWaldmann> first determine value
  68 2010-03-09T19:48:46  <ThomasWaldmann> then try conversion
  69 2010-03-09T19:48:51  <ThomasWaldmann> then do append
  70 2010-03-09T19:50:15  <dreimark> ok
  71 2010-03-09T19:52:20  <dreimark> hmm, but they are always strings and not numbers
  72 2010-03-09T19:52:34  <dreimark> how can I figure that it is a number ?
  73 2010-03-09T19:55:25  *** grzywacz has joined #moin-dev
  74 2010-03-09T19:56:12  <dreimark> eSyr: ping
  75 2010-03-09T19:56:19  <eSyr> dreimark, you can try to extract number from start of string, if any, and try to sort it.
  76 2010-03-09T19:57:15  <eSyr> (and sort tuples containing (int/float, str) with custom sort function)
  77 2010-03-09T19:57:30  <eSyr> (or do the stuff in compare function)
  78 2010-03-09T19:57:33  <dreimark> i don want as result 1 10 100 9, so that must become a numerical type
  79 2010-03-09T19:57:44  <eSyr> yes, i understand.
  80 2010-03-09T19:58:41  <ThomasWaldmann> as long as you have homogeneous data only, that'll work. if you mix, it gets mixed up.
  81 2010-03-09T19:59:13  <eSyr> ThomasWaldmann, modern file browsers like nautilus solve this problem somehow :)
  82 2010-03-09T19:59:18  <eSyr> (or even sort -n)
  83 2010-03-09T20:01:42  <dreimark> can't we just take this a limitation?
  84 2010-03-09T20:01:47  <dreimark> +as
  85 2010-03-09T20:02:39  <eSyr> ok, i'll try now to write proper comparing function when we have mixed data.
  86 2010-03-09T20:04:09  <dreimark> thx, me is looking at tuples (if we still need them)
  87 2010-03-09T20:06:22  <ThomasWaldmann> dreimark: did you get 7.0000000001 without Decimal and with float?
  88 2010-03-09T20:16:10  <dreimark> yes
  89 2010-03-09T20:16:26  <dreimark> thats why i prefer Decimal
  90 2010-03-09T20:17:35  <ThomasWaldmann> ok, so what's up with losing elem[0]?
  91 2010-03-09T20:17:59  <dreimark> sometimes you get 324.999999
  92 2010-03-09T20:18:11  <dreimark> it depends on the floating point arithmetic
  93 2010-03-09T20:18:17  <dreimark> and your value
  94 2010-03-09T20:18:26  <ThomasWaldmann> repr or str?
  95 2010-03-09T20:19:38  <dreimark> i have used str before, not looked at repr
  96 2010-03-09T20:20:06  <eSyr> ThomasWaldmann, looks like we can preserve whitespace in diffs and have some backward compatibility for old themes.
  97 2010-03-09T20:20:21  <eSyr> (e.g., it wouldn't been worse in them)
  98 2010-03-09T20:20:58  <eSyr> (just eliminating unneeded additional whitespace does the job)
  99 2010-03-09T20:21:55  <ThomasWaldmann> >>> x=1.1
 100 2010-03-09T20:21:55  <ThomasWaldmann> >>> repr(x)
 101 2010-03-09T20:21:55  <ThomasWaldmann> '1.1000000000000001'
 102 2010-03-09T20:21:55  <ThomasWaldmann> >>> str(x)
 103 2010-03-09T20:21:55  <ThomasWaldmann> '1.1'
 104 2010-03-09T20:26:51  <dreimark> strange I tried that first, and can't reproduce it now, but I have seen .9999
 105 2010-03-09T20:39:45  <eSyr> ThomasWaldmann, http://paste.pocoo.org/show/187587/
 106 2010-03-09T20:41:06  <eSyr> dreimark, where is latest patch about sorting datagrid?
 107 2010-03-09T20:42:14  <dreimark> eSyr: http://moinmo.in/FeatureRequests/SortableTables?action=AttachFile&do=view&target=widget_browser_sort.patch
 108 2010-03-09T20:44:30  <ThomasWaldmann> eSyr: if that is as good as it gets, feel free...
 109 2010-03-09T20:46:32  <eSyr> ok, i'll test it with some additional cases and push then.
 110 2010-03-09T20:47:25  <dreimark> eSyr: i'll add soon a pastebin of a newer compatible collectlist
 111 2010-03-09T20:47:43  <dreimark> because that sorting code can be easier checked by that
 112 2010-03-09T20:47:50  <eSyr> ok.
 113 2010-03-09T20:48:05  <ThomasWaldmann>         key = 'I am secret'
 114 2010-03-09T20:48:21  <ThomasWaldmann> oops :)
 115 2010-03-09T20:48:28  <eSyr> hehehe.
 116 2010-03-09T20:50:41  * ThomasWaldmann reads some glashammer code
 117 2010-03-09T20:51:03  <eSyr> yes, we've noticed :)
 118 2010-03-09T20:53:04  <dreimark> eSyr: http://paste.pocoo.org/show/187600/
 119 2010-03-09T20:56:10  <dreimark> (and we can rename it if one has a good name for it)
 120 2010-03-09T21:21:24  <dreimark> for now i think we can eliminate tuples but I will look in older cs if there is a reason mentioned
 121 2010-03-09T21:21:33  <dreimark> bbl
 122 2010-03-09T21:37:38  <eSyr> dreimark, http://paste.pocoo.org/show/187628/ --- little patch for collectlists
 123 2010-03-09T21:40:34  <eSyr> dreimark, http://paste.pocoo.org/show/187631/ --- patch for your widget browser patch
 124 2010-03-09T21:41:19  <eSyr> (i know code should be written somehow cleaner, but it's just proof of concept)
 125 2010-03-09T21:42:57  <eSyr> bbl
 126 2010-03-09T21:46:00  *** eSyr has quit IRC
 127 2010-03-09T21:50:00  <dreimark> re
 128 2010-03-09T22:03:19  <dreimark> cool regex to check for the number
 129 2010-03-09T22:03:48  * dreimark remembers an old parser where we had that problem too
 130 2010-03-09T22:04:23  <dreimark> http://moinmo.in/ParserMarket/Sstable?action=AttachFile&do=view&target=sstable-1.0.4.py#CA-6ed29384770e354f81e6d68733ce7ad761731f8d_300
 131 2010-03-09T22:04:31  * dreimark likes that feature
 132 2010-03-09T22:26:24  * dreimark is to tired
 133 2010-03-09T22:26:36  <dreimark> +o
 134 2010-03-09T23:12:51  *** eSyr has joined #moin-dev
 135 2010-03-09T23:34:42  <dreimark> eSyr: me don't hack today - too tired, but I remembered http://moinmo.in/ParserMarket/Sstable?action=AttachFile&do=view&target=sstable-1.0.4.py#CA-6ed29384770e354f81e6d68733ce7ad761731f8d_300
 136 2010-03-09T23:36:59  <eSyr> oh, thanks.
 137 2010-03-09T23:38:08  <eSyr> (anyway, i've got regex from http://www.regular-expressions.info/floatingpoint.html )
 138 2010-03-09T23:46:22  <eSyr> ThomasWaldmann, what about http://moinmo.in/MoinMoinBugs/AlignTopAlignLeft ?
 139 2010-03-09T23:50:41  <dreimark> eSyr: should number sorting with your patch?
 140 2010-03-09T23:50:49  <dreimark> +work
 141 2010-03-09T23:51:02  <eSyr> yes, it should.
 142 2010-03-09T23:51:55  <ThomasWaldmann> eSyr: i had a quick look at the code and your patch yesterday, but found it rather confusing and didn't see how it is related to the bug
 143 2010-03-09T23:52:05  <dreimark> eSyr: http://paste.pocoo.org/show/187697/
 144 2010-03-09T23:53:18  <ThomasWaldmann> eSyr: ehrm, is it because of the missing comma?
 145 2010-03-09T23:53:23  <eSyr> ThomasWaldmann, what do you mean?
 146 2010-03-09T23:53:41  <ThomasWaldmann> the argparser code and the fix to it
 147 2010-03-09T23:54:19  <eSyr> mmm, i've added some tests which current code failing.
 148 2010-03-09T23:54:58  <eSyr> dreimark, can you provide example where this traceback occured?
 149 2010-03-09T23:57:46  <ThomasWaldmann> eSyr: i didn't look again or at the tests yet
 150 2010-03-09T23:59:39  <dreimark> ok