1 2010-07-05T01:47:00 <diofeher> re
2 2010-07-05T02:03:11 *** |mmk[null]|
3 2010-07-05T02:05:40 *** |mmk[null]|
4 2010-07-05T02:08:48 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8500:72f5d0d96b16 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/header.html theme/jinja.py): [templating] added a dummy trail and changed the return of path_breadcrumbs (tuple list instead of hardcoded html list)
5 2010-07-05T02:20:20 <ThomasWaldmann> diofeher: item is not a url
6 2010-07-05T02:22:15 <ThomasWaldmann> and you left a print in the code
7 2010-07-05T02:24:57 <ThomasWaldmann> if you use urls there, you can use almost same code for location and path breadcrumbs
8 2010-07-05T02:25:36 <ThomasWaldmann> and because of interwiki links in trail, you need to generate urls
9 2010-07-05T02:41:13 <diofeher> ThomasWaldmann: what this item are you talking about?
10 2010-07-05T02:42:17 <TheSheep> the variable name you are iterating over in breadcrumbs, I think
11 2010-07-05T02:42:39 <ThomasWaldmann> the one you put into the tuple as url
12 2010-07-05T02:47:55 <diofeher> ok, gonna fix now
13 2010-07-05T02:55:41 <diofeher> maybe item_path?
14 2010-07-05T02:57:36 <diofeher> TheSheep ThomasWaldmann
15 2010-07-05T03:12:24 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8501:ea45528f5b0f 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/actions_menu.html theme/jinja.py): [templating] removing unnecessary print
16 2010-07-05T03:12:27 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8502:43d7be7769d6 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/header.html: [templating] renaming wrong variables names (url to item_path)
17 2010-07-05T03:15:00 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8503:f86003a28667 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] reimplementation of JinjaTheme.translated_item_name without use wikiutil.getLocalizedPage and using an Page object
18 2010-07-05T03:22:14 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8504:ab6fd989c85c 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] killed getLocalizedPage use in JinjaTheme and replaced by translated_item_name
19 2010-07-05T04:07:37 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8505:a7df2b782abd 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (3 files in 2 dirs): [templating] fixed bug in splitNavilink (using Page instance now). Refactored actionsMenu (now actions_menu) to use tuples instead of hardcoded html. other data passed in actions_menu is now rendered in templates
20 2010-07-05T05:07:43 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8506:26129f358a8c 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (5 files in 3 dirs): [templating] fixed order of elements in actions tuple. created hierarchical structure to diff and to show
21 2010-07-05T05:22:13 *** kursor
22 2010-07-05T05:25:32 *** DmitryAndreev
23 2010-07-05T05:32:46 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8507:3f0405b03366 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] workaround to create attribute page in JinjaTheme in cases that request does not come with page attribute
24 2010-07-05T05:35:36 <diofeher> where is gonna be the high level place that constructs response object?
25 2010-07-05T05:35:43 <diofeher> ThomasWaldmann TheSheep
26 2010-07-05T05:35:57 <diofeher> i'm gonna sleep now, tomorrow continue, gonna update diary tomorrow too
27 2010-07-05T05:36:32 <diofeher> i've made two workarounds just to pass all tests, but code have a lot to do :)
28 2010-07-05T05:36:34 <diofeher> gn
29 2010-07-05T05:36:35 *** diofeher
30 2010-07-05T05:37:42 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8508:1d416fb9f3bf 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/ (diff.py show.py): [templating] workaround to add headers in request.
31 2010-07-05T06:12:09 *** ritinardo
32 2010-07-05T06:35:58 *** kursor
33 2010-07-05T07:11:48 *** DmitryAndreev
34 2010-07-05T07:13:05 *** DmitryAndreev
35 2010-07-05T08:43:54 *** gwork
36 2010-07-05T08:43:55 *** valeuf
37 2010-07-05T08:44:48 *** valeuf
38 2010-07-05T08:45:52 <ThomasWaldmann> moin
39 2010-07-05T08:46:03 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/f86003a28667 wtf?
40 2010-07-05T10:11:46 <valeuf> moin :)
41 2010-07-05T10:58:41 *** DmitryAndreev
42 2010-07-05T11:28:32 <dreimark> moin
43 2010-07-05T11:41:05 <ei-grad> moin
44 2010-07-05T12:18:59 *** DmitryAndreev
45 2010-07-05T13:05:12 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5779:da91b319fe4c 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/_tests/__init__.py: [LDAP2010] fixed error in test_backend_acl_allow - it checked "Admin1" user several times instead of checking all users in group
46 2010-07-05T13:05:14 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5780:c4b038ef5db2 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed errors in "memberOf" part of LDAPGroup.__iter__, it is not covered by tests (see MoinMoin:LDAP2010/memberOf)
47 2010-07-05T13:05:28 <CIA-98> Andrew Grigorev <andrew@ei-grad.ru> default * 5781:0744458e1a02 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] fixed errors in "memberOf" part of LDAPGroups._retrieve_members, it is not covered by tests (see MoinMoin:LDAP2010/memberOf)
48 2010-07-05T13:09:44 <dreimark> ei-grad: see py.test -C test_ldap_groups.py for coverage
49 2010-07-05T13:10:02 <ei-grad> oh, thanks
50 2010-07-05T13:10:32 <ei-grad> py.test: error: no such option: -C
51 2010-07-05T13:10:33 <dreimark> you need probably easy_install -U coverage beforehand
52 2010-07-05T13:12:01 <dreimark> ei-grad: ^
53 2010-07-05T13:12:03 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8520:1626615dc07f 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_in.py html_in.py): Add support for quotation in HTML_IN converter
54 2010-07-05T13:12:04 <ei-grad> yep
55 2010-07-05T13:12:10 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8521:fa66facdd753 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Add comments to explain the dummy mimetype x.moin.html
56 2010-07-05T13:12:12 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8522:dfafb3888000 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (converter2/docbook_in.py items/__init__.py): Add support for DocBook mimetype in the wiki
57 2010-07-05T13:12:13 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8523:e5cde26afff7 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/ (_tests/test_html_out.py html_out.py): Add support for quote tags in HTML_OUT
58 2010-07-05T13:14:08 <valeuf> dreimark: that's cool tool !
59 2010-07-05T13:14:15 <dreimark> ei-grad: py.test -C -k test_ldap_groups.py (i missed the -k keyword)
60 2010-07-05T13:14:28 <dreimark> valeuf: :)
61 2010-07-05T13:15:38 <dreimark> DmitryAndreev: you watched too? py.test -C after installation of coverage by easy_install -U
62 2010-07-05T13:16:37 <ei-grad> dreimark: http://paste.pocoo.org/show/233682/
63 2010-07-05T13:17:19 <ei-grad> it shows 15% for test_ldap_groups.py... (if run without -k option)
64 2010-07-05T13:18:03 <dreimark> looks like -C is wrong implemented for usage together with -k
65 2010-07-05T13:20:30 <DmitryAndreev> MoinMoin/converter2/_tests/test_moinwiki_out 58 58 Cover 100% :D
66 2010-07-05T13:21:24 <DmitryAndreev> ow, i'm not right
67 2010-07-05T13:21:43 <dreimark> DmitryAndreev: test_sourcecode.py FFF
68 2010-07-05T13:23:27 <dreimark> and currently lots of other failures on many places
69 2010-07-05T13:23:43 <dreimark> when do you have merged last time?
70 2010-07-05T13:24:30 <DmitryAndreev> dreimark, 2 weeks maybe.
71 2010-07-05T13:25:46 <DmitryAndreev> now i'm fixing pep8
72 2010-07-05T13:28:36 <dreimark> DmitryAndreev: please merge after you have fixed your pep8 problems
73 2010-07-05T13:28:48 <DmitryAndreev> dreimark, ok
74 2010-07-05T13:29:06 <dreimark> valeuf: when did you merged last?
75 2010-07-05T13:30:18 <valeuf> dreimark: 8 days ago
76 2010-07-05T13:30:25 <valeuf> it is probably time to merge again :)
77 2010-07-05T13:31:02 <dreimark> yes please.
78 2010-07-05T13:35:17 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8533:a54d907ea7c2 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (7 files in 5 dirs): Merge with the main 2.0 branch
79 2010-07-05T13:35:21 <valeuf> \o/ no error in the tests :)
80 2010-07-05T13:36:29 <ThomasWaldmann> some stuff is just skipped
81 2010-07-05T13:36:59 <valeuf> yep I saw it
82 2010-07-05T13:37:10 <valeuf> but I guess that there is code reason about it :p
83 2010-07-05T13:38:46 <dreimark> i think it is a good idea to have it merged always before our weekly meeting if there is not other reason to do it
84 2010-07-05T13:38:56 <dreimark> +an
85 2010-07-05T13:39:04 <dreimark> e.g. every Thursday
86 2010-07-05T14:02:46 *** aa_
87 2010-07-05T14:10:07 *** aa_
88 2010-07-05T14:26:45 *** ritinardo
89 2010-07-05T14:32:11 <ThomasWaldmann> ok, moin seems to work with py 2.7. except if it crashes, it'll double-crash in the werkzeug debugger
90 2010-07-05T14:38:54 *** diofeher
91 2010-07-05T14:38:57 <diofeher> moin!
92 2010-07-05T14:49:00 <dreimark> bbl
93 2010-07-05T14:51:10 <ThomasWaldmann> hi diofeher
94 2010-07-05T14:54:03 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8331:808df757c4fd 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (moinwiki_out.py rst_out.py): DOM->ReST and DOM->Moinwiki: Fix indents in lists
95 2010-07-05T14:54:25 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8441:69bf415188df 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (_tests/test_rst_in.py moinwiki_out.py rst_in.py rst_out.py): PEP8 fix
96 2010-07-05T14:54:27 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8442:b29a89abb68d 2.0-dev-wiki-rest-dandreev/ (126 files in 39 dirs): Merge with the main 2.0 branch
97 2010-07-05T14:58:45 <diofeher> ThomasWaldmann: hi! i dropped the documentation of actionsMenuInit a little early :P
98 2010-07-05T14:59:21 <ThomasWaldmann> you can also keep the item on your todo for later
99 2010-07-05T14:59:30 <diofeher> it is rendered in actions_menu.html now... i'm gonna move into body_onload
100 2010-07-05T14:59:45 <ThomasWaldmann> don't change that now
101 2010-07-05T14:59:55 <ThomasWaldmann> you'll do js cleanup later anyway
102 2010-07-05T15:00:24 <diofeher> ok so
103 2010-07-05T15:00:42 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8509:ac9e1cef5d28 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] reverting actions_menu documentation
104 2010-07-05T15:00:47 <diofeher> ThomasWaldmann: today i'm gonna concentrate in this response object
105 2010-07-05T15:01:11 <diofeher> make a basic structure at least
106 2010-07-05T15:01:23 <ThomasWaldmann> maybe just look at some other werkzeug apps how they handle Response
107 2010-07-05T15:01:38 <ThomasWaldmann> and views
108 2010-07-05T15:01:44 <diofeher> okay
109 2010-07-05T15:01:46 <ThomasWaldmann> it usually is
110 2010-07-05T15:01:48 <ThomasWaldmann> ...
111 2010-07-05T15:01:56 <diofeher> a lot of tests will break, huh?
112 2010-07-05T15:02:00 <ThomasWaldmann> return Response(render(template))
113 2010-07-05T15:02:38 <ThomasWaldmann> many actions are broken anyway
114 2010-07-05T15:02:47 <diofeher> django is in this way.. but use HttpResponse instead Response
115 2010-07-05T15:02:54 <diofeher> i know, but they not covered by tests
116 2010-07-05T15:02:54 <ThomasWaldmann> maybe concentrate on show for now
117 2010-07-05T15:02:58 <diofeher> ok
118 2010-07-05T15:03:42 <ThomasWaldmann> moin2 has lots of broken stuff, but we first concentrate on getting the core functionality right
119 2010-07-05T15:05:42 *** kursor
120 2010-07-05T15:18:42 <ThomasWaldmann> diofeher: delete action looks a bit strange :)
121 2010-07-05T15:19:19 <ThomasWaldmann> same for rename
122 2010-07-05T15:21:08 <diofeher> ThomasWaldmann: the way they behavior?
123 2010-07-05T15:21:15 <diofeher> behave*
124 2010-07-05T15:24:09 <ThomasWaldmann> there is a duplicate theme header in the content area
125 2010-07-05T15:24:41 <ThomasWaldmann> -> you need to fix their templates
126 2010-07-05T15:26:11 <diofeher> i know... just show and diff are working
127 2010-07-05T15:26:52 <ThomasWaldmann> ok, maybe first finish them
128 2010-07-05T15:30:39 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8510:a57ece60a877 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/ (diff.py show.py): [templating] put header set before write response
129 2010-07-05T15:33:22 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8511:4dc8ed2baa32 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/delete.py: [templating] fix delete action rendering
130 2010-07-05T15:36:43 <diofeher> ThomasWaldmann: recent changes is broken in storage
131 2010-07-05T15:36:52 <diofeher> do=rc <-
132 2010-07-05T15:37:58 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8512:d94cae01e76d 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/rename.py: [templating] fix rename action rendering
133 2010-07-05T15:40:39 <valeuf> dreimark: yep, I will try to merge every sunday so :)
134 2010-07-05T15:41:33 <ThomasWaldmann> diofeher: i know, will fix soon
135 2010-07-05T15:41:56 <ThomasWaldmann> it is just because there is no fake-metadata any more
136 2010-07-05T15:42:13 <diofeher> hmm
137 2010-07-05T15:42:37 <diofeher> ThomasWaldmann: i've created a hierarchical structure for it, and now it's not giving internal error anymore
138 2010-07-05T15:42:40 <diofeher> but no data is showed
139 2010-07-05T15:45:58 <diofeher> can i commit this with a TODO (fix)?
140 2010-07-05T15:47:00 <ThomasWaldmann> first make it working
141 2010-07-05T15:47:16 <diofeher> but i don't know how to deal with storage
142 2010-07-05T15:47:33 <ThomasWaldmann> you don't need to deal with storage
143 2010-07-05T15:48:06 <diofeher> well, the theme is showed, only content it's not
144 2010-07-05T15:49:48 <ThomasWaldmann> was it shown before?
145 2010-07-05T15:51:01 <diofeher> not, before gave internal error
146 2010-07-05T15:51:20 <diofeher> i didn't understood why variable is fail silently in hierarchical structure...
147 2010-07-05T15:58:01 <valeuf> waldi: does link like do=get&mimetype=application%2Fdocbook+xml are supposed to get the page with the specified mimetype ?
148 2010-07-05T15:58:19 <valeuf> waldi: so we can convert an Item into any mimetype (if we have a converter to handle that)
149 2010-07-05T16:06:35 *** RogerHaase
150 2010-07-05T16:07:10 <ThomasWaldmann> diofeher: are you still talking about rc or what exactly?
151 2010-07-05T16:07:22 <diofeher> rc
152 2010-07-05T16:07:34 <diofeher> ThomasWaldmann: i asked in pocoo
153 2010-07-05T16:08:01 <diofeher> like mitsuhiko said, it's because we using a streamed output
154 2010-07-05T16:08:27 <diofeher> and stream outputs until point of exception
155 2010-07-05T16:08:38 <diofeher> exactly what's happening here
156 2010-07-05T16:12:42 <ThomasWaldmann> diofeher: what about show, does that work?
157 2010-07-05T16:13:00 <diofeher> yes
158 2010-07-05T16:13:06 <waldi> valeuf: that was my plan. but please name the parameter type or better mediatype. even if the original definition comes from the mime speci, it have nothing to do with mail
159 2010-07-05T16:13:07 <diofeher> diff too
160 2010-07-05T16:13:12 <ThomasWaldmann> ok, you don't need to care about rc failure
161 2010-07-05T16:13:19 <diofeher> and now rename and delete
162 2010-07-05T16:13:39 <valeuf> valeuf: with mail ?
163 2010-07-05T16:14:00 <diofeher> ThomasWaldmann: ok, but i'm gonna leave a TODO, because no error is failed.. just to remember :)
164 2010-07-05T16:14:22 <diofeher> s/failed/raised
165 2010-07-05T16:14:26 <valeuf> waldi: I did not name any parameter, do=get is already working, except that it return the internal storage data (and not a converted output{
166 2010-07-05T16:14:27 <valeuf> )
167 2010-07-05T16:14:37 <ThomasWaldmann> it is just because there is no fake ip or whatever there any more (in older revisions, if it did not have an IP, it had meta[EDIT_LOG_IP] == '0.0.0.0', for example
168 2010-07-05T16:14:58 <ThomasWaldmann> ), but now, if there is no known IP, the key is just missing
169 2010-07-05T16:15:24 <diofeher> oh, understood
170 2010-07-05T16:15:43 <ThomasWaldmann> the fix is to not use meta[key], but meta.get(key, 'defaultyouwanttohave')
171 2010-07-05T16:16:18 <ThomasWaldmann> diofeher: about Response
172 2010-07-05T16:16:39 <ThomasWaldmann> that stuff isn't strictly related to your task
173 2010-07-05T16:16:46 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8513:40457f98737e 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (action/rc.py templates/rc.html): [templating] put rc template in hierarchical structure and changed rc action to behave accordingly
174 2010-07-05T16:17:03 <ThomasWaldmann> so, if you like to concnetrate more on your task, you can just modify actions so that they:
175 2010-07-05T16:17:17 <ThomasWaldmann> set headers (as it is already)
176 2010-07-05T16:17:42 <ThomasWaldmann> but then, not call send_title, request.write(mystuff), send_footer,
177 2010-07-05T16:18:06 <ThomasWaldmann> but just return their full content as a unicode object
178 2010-07-05T16:18:39 <ThomasWaldmann> at the place that dispatches to the action, you can then check if the returned value is not None
179 2010-07-05T16:19:03 <ThomasWaldmann> and if you get something back, you use request.write(result) THERE
180 2010-07-05T16:19:38 <ThomasWaldmann> that way, you don't need to deal with status codes, headers, etc. now
181 2010-07-05T16:19:48 <diofeher> hmm, looks nice :D
182 2010-07-05T16:20:00 <diofeher> thx
183 2010-07-05T16:20:32 <ThomasWaldmann> so it is basically return render(sometemplate)
184 2010-07-05T16:21:54 <ThomasWaldmann> also, you don't need to care for exotic actions now. show, modify, diff for now, later info/history/rc.
185 2010-07-05T16:25:12 <ThomasWaldmann> tenso?
186 2010-07-05T16:25:50 <diofeher> ok
187 2010-07-05T16:25:57 <diofeher> ThomasWaldmann: tenso??? :P
188 2010-07-05T16:26:10 <diofeher> are you speaking portuguese? :P
189 2010-07-05T16:27:49 <ThomasWaldmann> no, i just wondered what it means
190 2010-07-05T16:28:10 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/40457f98737e#l2.13
191 2010-07-05T16:28:25 <diofeher> ooooooh
192 2010-07-05T16:28:26 <diofeher> hahaha
193 2010-07-05T16:28:44 <diofeher> just to test if variable is failing silently
194 2010-07-05T16:29:25 <diofeher> we have a lot of jokes here using this word
195 2010-07-05T16:29:58 <ThomasWaldmann> no portuguese jokes in moin src please :D
196 2010-07-05T16:30:12 <diofeher> i reviewed but didn't see this
197 2010-07-05T16:30:19 <diofeher> sry ^^
198 2010-07-05T16:30:35 <diofeher> i have to review better my commits...
199 2010-07-05T16:34:46 <diofeher> ThomasWaldmann: if you have free time, just to see what it means: http://wolocomeu.files.wordpress.com/2009/10/tenso21.jpg
200 2010-07-05T16:36:04 <ThomasWaldmann> hehe
201 2010-07-05T16:52:42 <ThomasWaldmann> diofeher: you need to move doctype html /html
202 2010-07-05T16:55:08 <ThomasWaldmann> and body, /body
203 2010-07-05T16:56:07 <ThomasWaldmann> and head, /head
204 2010-07-05T16:56:29 <ThomasWaldmann> -> base.html
205 2010-07-05T16:57:45 <diofeher> so kill head.html, header.html and footer.html?
206 2010-07-05T16:57:53 <diofeher> just put them in base?
207 2010-07-05T16:58:56 <diofeher> ThomasWaldmann: i'm looking here how to write stream... when i get returned function (action.getHandler), i don't have a request object
208 2010-07-05T16:59:22 <diofeher> have one in context, but it doesn't have write function
209 2010-07-05T17:01:20 <ThomasWaldmann> no, just do what I told
210 2010-07-05T17:02:12 <ThomasWaldmann> the action gets the request object as param when it is called, so it is likely there also a line below
211 2010-07-05T17:02:44 <ThomasWaldmann> in general, remove assymetric stuff from your templates
212 2010-07-05T17:03:09 <ThomasWaldmann> that applies also to the end of header and the beginning of footer
213 2010-07-05T17:04:05 <ThomasWaldmann> (the template shall contain some outer opening tag at the beginning, and same outer closing tag at the end usually)
214 2010-07-05T17:06:15 <ThomasWaldmann> if there is something asymmetric, it maybe rather should be in the template above the one you're looking at
215 2010-07-05T17:07:27 <ThomasWaldmann> modify_text_html.html:<link href="{{ url_prefix_ckeditor }}/contents.css" rel="stylesheet" type="text/css"/>
216 2010-07-05T17:07:54 <ThomasWaldmann> that's wrong for html4, remove the / (not your fault :)
217 2010-07-05T17:09:39 <diofeher> oh ok! ^^
218 2010-07-05T17:09:49 <diofeher> i'm gonna fix this as soon as finish response
219 2010-07-05T17:10:12 <diofeher> ThomasWaldmann: the request object passed in action is different what we really have in action
220 2010-07-05T17:10:46 <diofeher> in handler: <class 'MoinMoin.wsgiapp.AppRequest'>
221 2010-07-05T17:10:56 <diofeher> in action: <class 'MoinMoin.web.contexts.AllContext'>
222 2010-07-05T17:11:52 <ThomasWaldmann> so it mutates on the way?
223 2010-07-05T17:12:55 <diofeher> yes oO
224 2010-07-05T17:13:40 <diofeher> because of this i can't render response in wsgiapp.handle_action
225 2010-07-05T17:15:17 <ThomasWaldmann> wsgiapp:250
226 2010-07-05T17:15:34 <diofeher> yes, exactly here
227 2010-07-05T17:16:21 <ThomasWaldmann> and context.write(result) doesn't work?
228 2010-07-05T17:16:38 <ThomasWaldmann> (if result is not None)
229 2010-07-05T17:16:48 <diofeher> oooh, i was accesing context.request
230 2010-07-05T17:16:49 <diofeher> oO
231 2010-07-05T17:16:51 <diofeher> sr
232 2010-07-05T17:16:53 <diofeher> sry*
233 2010-07-05T17:17:08 <ThomasWaldmann> context and request there is a bit confusing
234 2010-07-05T17:17:39 <diofeher> yea..
235 2010-07-05T17:19:18 <ThomasWaldmann> hmm, instead of checking "result is not None" you could even better check for "isinstance(result, unicode)"
236 2010-07-05T17:20:37 <ThomasWaldmann> (binary stuff needs to be reviewed anyway)
237 2010-07-05T17:21:48 <diofeher> i'm gonna remove this line: handler(context.page.page_name, context)
238 2010-07-05T17:22:00 <diofeher> and replace by response = handler(context.page.page_name, context)
239 2010-07-05T17:22:43 <ThomasWaldmann> well, currently it is not a response like in the werkzeug Response meaning
240 2010-07-05T17:23:20 <ThomasWaldmann> it's rather "result" or "content" or so
241 2010-07-05T17:25:26 <diofeher> result so?
242 2010-07-05T17:25:26 <diofeher> :p
243 2010-07-05T17:25:36 <ThomasWaldmann> yes
244 2010-07-05T17:25:55 <diofeher> content is better... result is too absctract
245 2010-07-05T17:26:00 <ThomasWaldmann> (that'll get rewritten later again anyway :)
246 2010-07-05T17:26:08 <diofeher> right ^^
247 2010-07-05T17:28:15 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8514:ccddec940e26 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (action/show.py templates/rc.html wsgiapp.py): [templating] removed variable used for tests and changed show action to return a string. write content in stream out is done now in wsgiapp
248 2010-07-05T17:29:30 <ThomasWaldmann> and be careful: string sounds rather like str than unicode
249 2010-07-05T17:33:27 <ThomasWaldmann> btw, if you use a self-created item, /item?do=rc works
250 2010-07-05T17:33:49 <ThomasWaldmann> as well as /?do=rc
251 2010-07-05T17:36:12 <diofeher> sorry, my internet was down
252 2010-07-05T17:36:17 <diofeher> [12:29] <ThomasWaldmann> and be careful: string sounds rather like str than unicode
253 2010-07-05T17:36:17 <diofeher> [12:35] <ThomasWaldmann> btw, if you use a self-created item, /item?do=rc works
254 2010-07-05T17:37:29 <diofeher> i've missed something?
255 2010-07-05T17:37:33 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8515:3232f689fa52 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/diff.py: [templating] diff action returns string instead of None.
256 2010-07-05T17:38:37 <ThomasWaldmann> as well as /?do=rc
257 2010-07-05T17:39:40 <diofeher> ok so ^^
258 2010-07-05T17:40:09 <ThomasWaldmann> (just the system/underlay pages are making trouble currently, because they have incomplete metadata)
259 2010-07-05T17:41:35 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8516:067ce1b35091 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (base.html footer.html head.html header.html): [templating] moved some tags to base.html to get a symetric template
260 2010-07-05T17:43:33 <ThomasWaldmann> now move head /head also to base.html
261 2010-07-05T17:44:26 *** gwork
262 2010-07-05T17:50:38 <ThomasWaldmann> TheSheep: how about merging header.html + block content_base + footer.html into body.html?
263 2010-07-05T17:51:24 <ThomasWaldmann> currently, editbar is rendered and computed twice, maybe that could be easily optimized then
264 2010-07-05T17:52:12 * ThomasWaldmann gtg
265 2010-07-05T17:54:08 *** DmitryAndreev
266 2010-07-05T17:55:46 <TheSheep> ThomasWaldmann: that was the idea
267 2010-07-05T17:55:56 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8517:d4a6c8689ed7 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (base.html head.html header.html): [templating] fixed html errors and moved <head> tag to base.html
268 2010-07-05T17:57:19 <ThomasWaldmann> i was just unsure, because the place where content is inserted is a bit less visible then, in the midst of a longer template
269 2010-07-05T17:59:09 <TheSheep> ThomasWaldmann: it should be base.html with all the html in it and a block for content left empty (or with some loremipsum) and layout.html inheriting from it, with all the menus, and then item.html inheriting from it with the editbars and such
270 2010-07-05T18:01:33 <ThomasWaldmann> diofeher: ^^
271 2010-07-05T18:01:43 <ThomasWaldmann> ok, now really away :)
272 2010-07-05T18:02:42 <diofeher> hmm
273 2010-07-05T18:03:48 <diofeher> ok, i'm gonna do this later
274 2010-07-05T18:07:41 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8518:858fa8f51c8f 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/actions_menu.html theme/jinja.py): [templating] change disabled (action tuple returns) from string to boolean. html rendering is done at template
275 2010-07-05T18:17:57 <diofeher> ThomasWaldmann: "rather try to get rid of all .page usage "
276 2010-07-05T18:18:05 <diofeher> remove all page usage in jinja.py? :-O
277 2010-07-05T18:22:41 *** kursor
278 2010-07-05T18:25:40 *** ronny
279 2010-07-05T18:56:08 *** grzywacz
280 2010-07-05T19:05:41 <diofeher> re
281 2010-07-05T19:05:47 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8519:9f411ad31490 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/modify.py: [templating] changed modify to use hierarchical structure
282 2010-07-05T19:16:43 <dreimark> F
283 2010-07-05T19:16:53 <dreimark> diofeher: moin-dev is loggedat
284 2010-07-05T19:17:01 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8534:9516fd3afaa7 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_in.py: Remove debug print statement
285 2010-07-05T19:17:01 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8535:f4279ef25b0a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Rename elem as element in DocBook_OUT converter
286 2010-07-05T19:17:01 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8536:cbdbee671bc2 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_out.py: Add tests for list for DocBook_OUT ocneverter
287 2010-07-05T19:17:02 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8537:fb741f12210e 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_out.py: Add test for (un)ordered list support in DocBook_OUT converter
288 2010-07-05T19:17:04 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8538:bf351d51a80a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Add support for (un)ordered list in DocBook_OUT converter
289 2010-07-05T19:17:20 <dreimark> diofeher: moin-dev is logged at http://moinmo.in/MoinMoinChat/Logs/moin-dev/2010-07-05
290 2010-07-05T19:38:11 <ei-grad> Working on ldap_wikiconfig_snippet I noticed that using single LDAPConnection we can not specify different base_dn to find groups and users. It would be nice if the parameters passed to LDAPAuth and LDAPGroup will override the corresponding parameters of LDAPConnection, but in practice it only makes sense for base_dn. Probably worth would be to make an exception for base_dn and override it in case if
291 2010-07-05T19:38:13 <ei-grad> LDAPConnection specified, and show a warning for every of other specified parameter...
292 2010-07-05T19:38:46 <diofeher> dreimark thanks.. i know ^^ but sometimes it takes a little to update there, right?
293 2010-07-05T19:41:00 <ei-grad> hm... we already overriding bind_dn and bind_pw, so seems right to override base_dn too...
294 2010-07-05T19:41:46 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8539:f12eff1e78c0 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_out.py: Add test for the different list-style-type of the ordered list in DocBook_OUT converter
295 2010-07-05T19:41:50 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8540:6f1ae5a790a6 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_docbook_out.py: Add comments to explain the different type of test for the list in DocBook_OUT converter
296 2010-07-05T19:41:50 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8541:5f245bba0f61 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Add support for the different list-style-type with the ordered list in the DocBook_OUT converter
297 2010-07-05T19:41:52 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8542:4dec4083765e 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Fix wrong indetation
298 2010-07-05T19:45:30 <diofeher> TheSheep have you ever heard about closure http://closure-library.googlecode.com/svn/trunk/closure/goog/demos/index.html ?
299 2010-07-05T19:52:21 <TheSheep> diofeher: yes, we use something similar at work
300 2010-07-05T19:53:49 <valeuf> diofeher: really nice library !
301 2010-07-05T20:11:27 <diofeher> valeuf: yes, it is! ^^
302 2010-07-05T20:11:36 <diofeher> TheSheep: what do you use at work?
303 2010-07-05T20:14:28 <TheSheep> diofeher: we grew our own js thing based on google's widgets
304 2010-07-05T20:16:11 <TheSheep> diofeher: it's running in the browser and fed with jsons, so our web apps don't need to touch html ever again
305 2010-07-05T20:21:27 <diofeher> TheSheep: wow nice ^^
306 2010-07-05T20:21:31 <diofeher> it's open source?
307 2010-07-05T20:28:20 <TheSheep> no :(
308 2010-07-05T20:34:09 <diofeher> ah :(
309 2010-07-05T20:34:27 <diofeher> i'm going to work out now, bbl
310 2010-07-05T20:37:00 *** DmitryAndreev
311 2010-07-05T21:08:19 <ThomasWaldmann> re
312 2010-07-05T21:11:57 *** grzywacz
313 2010-07-05T22:28:55 *** grzywacz
314 2010-07-05T22:33:44 <dreimark> re
315 2010-07-05T22:35:34 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8389:8db9f0384139 2.0-dev/MoinMoin/ (items/__init__.py storage/backends/fs19.py): fs19: convert SAVE/REVERT 'extra' information to reverted_to metadata
316 2010-07-05T22:36:36 *** DmitryAndreev_
317 2010-07-05T22:39:52 *** DmitryAndreev
318 2010-07-05T22:43:31 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8390:0086a3e52df1 2.0-dev/MoinMoin/templates/rc.html: remove 'extra' info column from rc (not used any more)
319 2010-07-05T22:56:18 <dreimark> which was that rfc for extension of domain names by german umlauts and so oon?
320 2010-07-05T22:59:45 <CIA-98> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8391:97c7d82f41a3 2.0-dev/MoinMoin/templates/rc.html: rc template: add thead/tbody
321 2010-07-05T23:58:33 <valeuf> hehe we got the list of question for the mid-term evaluation
322 2010-07-05T23:58:42 <valeuf> we can also say bad things about the organization :p
323 2010-07-05T23:59:44 <xorAxAx> hehe
