1 2010-07-29T00:00:26  <valeuf> ThomasWaldmann: ok
   2 2010-07-29T00:12:48  *** RogerHaase has left #moin-dev
   3 2010-07-29T04:49:39  <diofeher> ThomasWaldmann, I think we should not worry about white spaces... we can minify files before send back to user
   4 2010-07-29T04:59:32  <xorAxAx> yeah
   5 2010-07-29T04:59:38  <xorAxAx> genshi does that automatically
   6 2010-07-29T05:02:48  <diofeher> xoraxax: it good if we have this in .css and .js files too (i don't know if jinja minify html files)
   7 2010-07-29T08:21:38  *** ebo^ has joined #moin-dev
   8 2010-07-29T10:00:18  <valeuf> moin
   9 2010-07-29T10:40:43  <ThomasWaldmann> moin
  10 2010-07-29T10:41:18  <ThomasWaldmann> diofeher: jinja2 doesn't kill whitespace, obviously
  11 2010-07-29T10:42:21  <ThomasWaldmann> and you even have wrong whitespace at places considered content that would not be touched anyway, even if there were such a functionality
  12 2010-07-29T10:52:49  <valeuf> speaking about whitespace
  13 2010-07-29T10:53:05  <valeuf> waldi: do you know if there is a pretty print function in EmeraldTree ?
  14 2010-07-29T10:53:16  <waldi> no
  15 2010-07-29T10:53:59  <valeuf> waldi: I think it would be quite useful, because currently the DocBook document are just a one-line text file, which is not so good
  16 2010-07-29T10:54:08  <valeuf> waldi: I will add this to my todo list
  17 2010-07-29T10:59:25  <valeuf> waldi: btw, did you apply this patch http://paste.pocoo.org/show/242984/ to the emeraldtree repo?
  18 2010-07-29T10:59:41  <valeuf> (hum sorry, there is still a print statement)
  19 2010-07-29T11:04:12  <valeuf> waldi: ok here is the correct version : http://paste.pocoo.org/show/242986/
  20 2010-07-29T11:28:23  <dreimark> moin
  21 2010-07-29T11:55:37  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9124:cd3868b1bf51 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Add test for standard attribute conversion for HTML_IN converter
  22 2010-07-29T11:55:39  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9125:51f318770160 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Add support for standard attribute conversion for the HTML_IN converter
  23 2010-07-29T11:55:41  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9126:18f6a9ca4821 2.0-dev-docbook-html-vjaniaut/MoinMoin/util/tree.py: Add XML in the Well-known namespaces
  24 2010-07-29T12:47:33  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9127:e207c14b2956 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in.py: Add test for the xml:id attribute conversion
  25 2010-07-29T12:47:36  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9128:d31962df3555 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/html_in.py: Add support for html:id --> xml:id conversion for the HTML_IN converter
  26 2010-07-29T13:01:14  <CIA-51> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9129:e349c92b9cad 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/_tests/test_html_in_out.py: Add test for standard attribute conversion for HTML_IN_OUT conversion
  27 2010-07-29T13:05:18  <CIA-51> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9126:8801f7058bd5 2.0-dev/MoinMoin/ (3 files in 3 dirs): implement similar_item_names (and kill LikePages action)
  28 2010-07-29T13:06:40  <valeuf> ThomasWaldmann: a lot of red in your commit ^ ^
  29 2010-07-29T13:07:15  <valeuf> ThomasWaldmann: for the similar items, I am thinking about a lot of nice stuff to implement, but this basic will be fine
  30 2010-07-29T13:07:36  <valeuf> ThomasWaldmann: I think I will do some experience next semester with that, I will have a course about natural language processing
  31 2010-07-29T13:07:47  <valeuf> ThomasWaldmann: wiki page can be a good training set ^ ^
  32 2010-07-29T13:10:43  <ThomasWaldmann> i mostly took old implementation and cleaned up names a bit
  33 2010-07-29T13:10:53  <valeuf> ah ok :)
  34 2010-07-29T13:11:05  <valeuf> by the way the flask stuff clean the code a lot
  35 2010-07-29T13:11:07  <valeuf> it is really great
  36 2010-07-29T13:11:20  <ThomasWaldmann> the CamelCase kind of word splitting might have to go at some point
  37 2010-07-29T13:11:38  <ThomasWaldmann> yeah :)
  38 2010-07-29T13:13:44  <valeuf> ok, I will be off most of time this afternoon, bank appointement and visa problem ^ ^ see you tonight
  39 2010-07-29T13:14:19  <ThomasWaldmann> about NLP: moin tries to be rather international, so I am not sure if there is any generically useful stuff
  40 2010-07-29T13:58:24  <valeuf> ThomasWaldmann: hm, yes you are right
  41 2010-07-29T14:44:13  <ThomasWaldmann> waldi: is there any reason no to just use the mimetype for doing pygments lexer lookup?
  42 2010-07-29T14:45:11  <ThomasWaldmann> currently pygments_in factory does strange stuff with Type('x-moin/format;name=%s'...
  43 2010-07-29T14:49:01  <waldi> every convert does things with x-moin/format, and i think this is documented on the mimetypes page
  44 2010-07-29T14:52:35  <ThomasWaldmann> url?
  45 2010-07-29T14:57:01  <ThomasWaldmann> page MimeType it is
  46 2010-07-29T15:08:29  <ThomasWaldmann> ok, i kept that stuff, but refactored the code a bit, so it is more clear about lexer name vs lexer mimetype
  47 2010-07-29T15:13:20  *** valeuf has quit IRC
  48 2010-07-29T15:14:00  *** valeuf has joined #moin-dev
  49 2010-07-29T15:34:22  <CIA-51> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9127:f0a2cf2b250d 2.0-dev/MoinMoin/ (3 files in 3 dirs): (log message trimmed)
  50 2010-07-29T15:34:22  <CIA-51> implement highlight view, refactor pygments_in converter, details below
  51 2010-07-29T15:34:22  <CIA-51> one can invoke highlight view from item history now, should work for all
  52 2010-07-29T15:34:22  <CIA-51> text items supported by pygments
  53 2010-07-29T15:34:22  <CIA-51> removed old do_highlight code in items
  54 2010-07-29T15:34:23  <CIA-51> converter setup in the view needs to be improved when pygments_in is in registry
  55 2010-07-29T15:34:24  <CIA-51> pygments_in: made it more clear about pygments lexer name vs. pygments
  56 2010-07-29T15:45:22  <dreimark> ThomasWaldmann: pygments.util.ClassNotFound
  57 2010-07-29T15:45:28  <dreimark> ClassNotFound: no lexer for mimetype u'text/x.moin.wiki' found
  58 2010-07-29T15:45:54  <dreimark> happens in moin-2.0-dev/MoinMoin/support/pygments/lexers/__init__.py", line 135, in get_lexer_for_mimetype
  59 2010-07-29T16:02:06  <ThomasWaldmann> dreimark: there is no lexer for that
  60 2010-07-29T16:02:26  <ThomasWaldmann> (but we need to handle the exception somehow)
  61 2010-07-29T16:15:13  <ThomasWaldmann> waldi: btw, is it better to give the input converters a list of lines or could they just do the split themselves?
  62 2010-07-29T16:36:56  *** CIA-51 has quit IRC
  63 2010-07-29T17:05:04  *** ebo^ has quit IRC
  64 2010-07-29T17:06:25  *** CIA-47 has joined #moin-dev
  65 2010-07-29T17:12:54  <dreimark> ThomasWaldmann: it is in Pygments 0.7.
  66 2010-07-29T17:13:07  <dreimark> search for http://pygments.org/docs/lexers/#lexers-for-non-source-code-file-types
  67 2010-07-29T17:13:15  <dreimark> MoinWikiLexer
  68 2010-07-29T17:13:35  <dreimark> the mimetype is there text/x-trac-wiki
  69 2010-07-29T17:14:33  <dreimark> our mimetype have a dot instead of a dash. why ?
  70 2010-07-29T17:14:47  <dreimark> +s
  71 2010-07-29T17:16:56  <diofeher> moin
  72 2010-07-29T17:17:02  <TheSheep> I think . is used for something
  73 2010-07-29T17:17:03  <dreimark> ei-grad: ping
  74 2010-07-29T17:23:04  <ThomasWaldmann> dreimark: trac is maybe compatible to moin 0.1 or so
  75 2010-07-29T17:23:34  <ThomasWaldmann> moin diofeher
  76 2010-07-29T17:27:03  <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9129:af513f215fab 2.0-dev/MoinMoin/ (3 files in 3 dirs): modify_text_html template: fix for html5/xml, use url_for, kill cfg.url_prefix_ckeditor
  77 2010-07-29T17:27:55  <ThomasWaldmann> btw, it looks like we currently have safe html processing for (unsafe) text/html and no processing for safe html
  78 2010-07-29T17:28:01  <ThomasWaldmann> valeuf: ^^ :)
  79 2010-07-29T17:38:24  *** CIA-47 has quit IRC
  80 2010-07-29T17:40:54  <dreimark> eSyr: please forward to your student http://gist.github.com/497582
  81 2010-07-29T17:42:44  <valeuf> ThomasWaldmann: yes exactly, it is a problem?
  82 2010-07-29T17:44:07  <valeuf> ThomasWaldmann: I am thinking to a solution for the CSS, but you were right it is more difficult than I expected
  83 2010-07-29T17:44:21  <valeuf> ThomasWaldmann: but maybe we could try to use a kind of white-list?
  84 2010-07-29T17:45:42  <ThomasWaldmann> no, except that it is behaving somehow reversed to what it tells :D
  85 2010-07-29T17:47:32  <valeuf> ThomasWaldmann: any other solution so? :p
  86 2010-07-29T17:50:51  <ThomasWaldmann> well, we need:
  87 2010-07-29T17:51:14  <ThomasWaldmann> a) sane mimetypes
  88 2010-07-29T17:51:18  <ThomasWaldmann> b) correct menu
  89 2010-07-29T17:51:23  <ThomasWaldmann> c) correct processing
  90 2010-07-29T17:51:56  <valeuf> ThomasWaldmann: heuh yes, but what is related to the style in your list?
  91 2010-07-29T17:52:02  <ThomasWaldmann> i am not sure whether text/html and text/x-unsafe-html are a good idea
  92 2010-07-29T17:52:33  <valeuf> ThomasWaldmann: well, it let trusted user to enjoy HTML as they want, and for not trusted user still proposed them some html
  93 2010-07-29T17:52:37  <ThomasWaldmann> and for the unsafe variant, it shall just pass-through
  94 2010-07-29T17:52:46  <valeuf> ThomasWaldmann: however, it needs an ACL to restrict the access to different mimetypes
  95 2010-07-29T17:54:19  <ThomasWaldmann> yeah, for modify at least :)
  96 2010-07-29T17:54:26  <valeuf> ThomasWaldmann: yes:)
  97 2010-07-29T17:55:53  <ThomasWaldmann> btw, i moved the docbook entry to the markup section of the type selection menu
  98 2010-07-29T17:56:04  <valeuf> ThomasWaldmann: no problem
  99 2010-07-29T17:57:44  <valeuf> ThomasWaldmann: conflict in items module ^ ^, I will have a look to fix that tonight
 100 2010-07-29T17:57:47  <valeuf> bbl
 101 2010-07-29T18:02:01  <diofeher> ThomasWaldmann, instead of block feed, we can have an "extra_head" block
 102 2010-07-29T18:02:03  <diofeher> what do u think?
 103 2010-07-29T18:03:14  <TheSheep> or just 'head' block and use inheritance to add to it
 104 2010-07-29T18:05:00  <diofeher> eh, sounds better
 105 2010-07-29T18:17:12  <diofeher> ThomasWaldmann, "announce it in the show view's html in the usual way" what do you mean?
 106 2010-07-29T18:18:48  <ThomasWaldmann> in the usual way as atom feeds are announced in the html (<link ...)
 107 2010-07-29T18:19:56  * ThomasWaldmann found that url_for() puts values not needed for the building of the path into query string
 108 2010-07-29T18:22:19  <diofeher> ah, atom is ok so
 109 2010-07-29T18:24:45  *** CIA-50 has joined #moin-dev
 110 2010-07-29T18:28:52  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9131:2b83ef1230a2 2.0-dev/MoinMoin/templates/ (show_template_selection.html show_type_selection.html): templates: replaced all href() by url_for()
 111 2010-07-29T18:29:07  <ThomasWaldmann> diofeher: ^^ merge and make sure all of them are removed
 112 2010-07-29T18:31:45  <ThomasWaldmann> and don't use any *href*() any more, use url_for(...)
 113 2010-07-29T18:33:16  <diofeher> i know =D
 114 2010-07-29T18:37:46  *** grzywacz has joined #moin-dev
 115 2010-07-29T18:38:12  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9141:59b074b32fea 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (11 files in 6 dirs): [templating] merged with main repo
 116 2010-07-29T18:41:14  <ThomasWaldmann> bbl
 117 2010-07-29T19:10:06  <diofeher> actions going to be deprecated too, right? all tests are broken because a lot of action code was removed
 118 2010-07-29T19:17:04  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9142:12ae2f75b294 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (base.html show.html): [templating] removed unnecessary spaces in base.html/show.html and identation
 119 2010-07-29T19:17:25  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9143:f487cccaf53a 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (10 files in 4 dirs): [templating] removed all ThemeBase.add_msg() code and ThemeBase.msg_list
 120 2010-07-29T19:25:44  <ThomasWaldmann> re
 121 2010-07-29T19:26:12  <valeuf> what tool do you use to do graphical merge on conflicted file?
 122 2010-07-29T19:26:24  <ThomasWaldmann> none
 123 2010-07-29T19:26:37  <diofeher> ThomasWaldmann, where is wsgiapp? Oo
 124 2010-07-29T19:27:13  <diofeher> me none too
 125 2010-07-29T19:27:20  <ThomasWaldmann> gone
 126 2010-07-29T19:27:33  <valeuf> just your text editor??
 127 2010-07-29T19:28:36  <diofeher> hm, a lot of places tries to import it...
 128 2010-07-29T19:28:53  <diofeher> can i remove actions test, so? they used handle_action of wsgiapp
 129 2010-07-29T19:31:08  <ThomasWaldmann> valeuf: yes
 130 2010-07-29T19:31:31  <ThomasWaldmann> diofeher: yes, tests are rather broken until the conftest.py is fixed
 131 2010-07-29T19:39:57  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9144:b4b386ccc30e 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (3 files in 2 dirs): [templating] removed actions and wsgiapp tests
 132 2010-07-29T19:49:10  *** ebo^ has joined #moin-dev
 133 2010-07-29T19:50:40  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9145:ee5abb0140a2 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (base.html show.html): [templating] moved universal edit button to show.html, this code doesn't make much sense in base.html because is item related.
 134 2010-07-29T19:50:43  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9146:ee2c357b50ea 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (layout.html show.html): [templating] removed extra_content block of show.html and refactored page history block that is more extensible now.
 135 2010-07-29T20:04:56  <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9130:cc69ce7c8c3a 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Add some comments to DocBook_out converter
 136 2010-07-29T20:05:01  <valeuf> ok :) the merge was fine with kdiff finally :)
 137 2010-07-29T20:05:06  <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9161:731514bf9f39 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (58 files in 16 dirs): Merge against main dev/moin2.0 repository
 138 2010-07-29T20:05:09  <CIA-50> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 9162:4548022b0980 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Fix issue with item mimetype for non-existant objects
 139 2010-07-29T20:07:25  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9147:fbbdadb447ba 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/layout.html: [templating] removed unnecessary spaces in layout.html
 140 2010-07-29T20:07:27  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9148:e01e5f27dc3d 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (26 files): [templating] fixed white spaces in end of templates
 141 2010-07-29T20:15:58  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9149:f1af10a9fa12 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/layout.html: [templating] escaping urls of layout.html
 142 2010-07-29T21:23:43  <ThomasWaldmann> valeuf: your repo is stable for merge back?
 143 2010-07-29T21:26:58  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9150:f07cbae1538f 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/ (base.html editbar.html layout.html show.html): [templating] refactored whitespace control
 144 2010-07-29T21:28:54  <diofeher> brb
 145 2010-07-29T21:45:45  <valeuf> ThomasWaldmann: I think so yes, there is no big work in progress
 146 2010-07-29T21:45:53  <valeuf> ThomasWaldmann: I am adding support of different DocBook element
 147 2010-07-29T21:46:24  <valeuf> however it is possible there is some bad code since you did not review all, but we can review it together
 148 2010-07-29T21:47:05  <ThomasWaldmann> ok
 149 2010-07-29T21:48:44  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9132:67d1f2d662b8 2.0-dev/MoinMoin/__init__.py: kill request.href, use url_for()
 150 2010-07-29T21:49:01  <valeuf> ThomasWaldmann: to get a diff between my repos and the main repos, the best would be to clone the main repos, and then pull my repo in, and then hg diff??
 151 2010-07-29T21:49:05  <valeuf> or there is better way?
 152 2010-07-29T21:51:25  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9165:c03584837211 2.0-dev/MoinMoin/ (38 files in 6 dirs): merged moin/2.0-dev-docbook-html-vjaniaut
 153 2010-07-29T21:51:32  * ThomasWaldmann merged and pushes
 154 2010-07-29T21:51:43  <valeuf> ThomasWaldmann: ok cool :)
 155 2010-07-29T21:52:20  <valeuf> now you have the convert action in the main repos normally :)
 156 2010-07-29T21:52:34  <ThomasWaldmann> and tests in korean :D
 157 2010-07-29T21:52:42  <valeuf> ThomasWaldmann: \o/
 158 2010-07-29T21:54:59  <ThomasWaldmann> CIA-50: wake up
 159 2010-07-29T21:55:17  <valeuf> actually it is quit
 160 2010-07-29T21:55:42  <ThomasWaldmann> or borken
 161 2010-07-29T21:56:34  <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev/rev/c03584837211 there are all the changes
 162 2010-07-29T21:57:27  <valeuf> ThomasWaldmann: oh what do you think about the item name problem for the conversion?
 163 2010-07-29T21:57:37  <valeuf> (1.29)
 164 2010-07-29T21:57:58  <ThomasWaldmann> yay, smileys!
 165 2010-07-29T21:58:23  <valeuf> I need a name which does not exist, I just added converted to the itemname, but it can give some bug if someone use a page with converted
 166 2010-07-29T21:58:26  <ThomasWaldmann> bbl
 167 2010-07-29T22:29:48  <ThomasWaldmann> valeuf: i get tracebacks when saving docbook items
 168 2010-07-29T22:29:55  <valeuf> ah?
 169 2010-07-29T22:31:16  <ThomasWaldmann> hmm, it uses the Text class?
 170 2010-07-29T22:31:27  <valeuf> I just tried, and it works fine, but maybe some input data gives a bug
 171 2010-07-29T22:31:37  <valeuf> ThomasWaldmann: in item yes
 172 2010-07-29T22:31:40  <valeuf> as mother class
 173 2010-07-29T22:31:43  <valeuf> it is wrong?
 174 2010-07-29T22:32:46  <ThomasWaldmann> looks like input_conv returns None
 175 2010-07-29T22:33:11  <valeuf> ThomasWaldmann: can you show me the traceback and the docbook document you are using?
 176 2010-07-29T22:33:41  <ThomasWaldmann> http://paste.pocoo.org/show/243178/
 177 2010-07-29T22:33:49  *** ebo^ has quit IRC
 178 2010-07-29T22:33:53  <ThomasWaldmann> current moin/2.0-dev code
 179 2010-07-29T22:34:07  <ThomasWaldmann> create new item, choose docbook from menu
 180 2010-07-29T22:34:31  <valeuf> ThomasWaldmann: ok I get the same TraceBack
 181 2010-07-29T22:35:26  <valeuf> I will try to figure out the problem
 182 2010-07-29T22:37:47  <ThomasWaldmann> is it missing xml header?
 183 2010-07-29T22:37:50  <valeuf> It is bizarre, the bug happens before the conversion
 184 2010-07-29T22:38:31  <valeuf> ThomasWaldmann: ah no namespace is missing
 185 2010-07-29T22:39:05  <valeuf> using <article xmlns='http://docbook.org/ns/docbook'> will work
 186 2010-07-29T22:39:26  <valeuf> should we try to add xmlns attribute by ourself? I am not sure
 187 2010-07-29T22:39:56  <valeuf> (and for some weird reason, Emilio lizardo is at the end of the document, without any reason)
 188 2010-07-29T22:41:58  * ThomasWaldmann just copy and pasted some stuff from docbook book :)
 189 2010-07-29T22:42:40  <valeuf> ThomasWaldmann: :) no actually it is because you used author, and I do not handle author yet, so I just put the information in the inf tag at the end
 190 2010-07-29T22:42:51  <valeuf> but still, it is not really clean result
 191 2010-07-29T22:42:51  <ThomasWaldmann> so the question is, is the xmlns required?
 192 2010-07-29T22:43:08  <valeuf> ThomasWaldmann: to have a valid DocBook 5 document : yes
 193 2010-07-29T22:43:45  <valeuf> however, we can suppose that if people choose DocBook item, they are writting a docbook document, and so we can check if there is the namespace, if not maybe add it?
 194 2010-07-29T22:44:06  <ThomasWaldmann> maybe there should be some error handling there, it could hint at stuff that could be wrong
 195 2010-07-29T22:44:48  <valeuf> ThomasWaldmann: yep, however I do not well how we should handle error at this time
 196 2010-07-29T22:45:28  <valeuf> ThomasWaldmann: like if I want to stop the conversion and return an error, should I just use raise in python, or do we have some way to handle error?
 197 2010-07-29T22:46:15  <ThomasWaldmann> well, if input converter returns None, you don't need to proceed
 198 2010-07-29T22:46:43  <valeuf> yep, but how the input converter can return an error message to display to the user?
 199 2010-07-29T22:47:39  <ThomasWaldmann> well, if the input converter internally detects what's wrong, it could raise some ConverterException with a good error msg
 200 2010-07-29T22:47:54  <dreimark> valeuf: yan you try run
 201 2010-07-29T22:48:04  <dreimark> s/yan/can/
 202 2010-07-29T22:48:27  <valeuf> ThomasWaldmann: ok, it looks good solution
 203 2010-07-29T22:48:34  <valeuf> dreimark: run what?
 204 2010-07-29T22:53:12  <ThomasWaldmann> can we use smileys.keys() instead of config.smileys?
 205 2010-07-29T22:53:28  <valeuf> ah yes, I did not change that,
 206 2010-07-29T22:53:33  <valeuf> normaly yes
 207 2010-07-29T22:54:06  <ThomasWaldmann> ok, i change some stuff
 208 2010-07-29T22:54:12  <valeuf> ThomasWaldmann: no problem
 209 2010-07-29T22:58:05  <dreimark> valeuf: try except raise
 210 2010-07-29T23:01:31  <valeuf> dreimark: ah yes sure, I will change my code te use that
 211 2010-07-29T23:01:33  <valeuf> *to
 212 2010-07-29T23:04:54  *** grzywacz has quit IRC
 213 2010-07-29T23:09:10  <dreimark> http://xkcd.com/ lol
 214 2010-07-29T23:09:18  <ThomasWaldmann> valeuf: render that:
 215 2010-07-29T23:09:19  <ThomasWaldmann> 1 2 :-) 3
 216 2010-07-29T23:09:21  <ThomasWaldmann> 4
 217 2010-07-29T23:10:38  <valeuf> oooOOOoo
 218 2010-07-29T23:11:03  <valeuf> that's odd
 219 2010-07-29T23:11:31  <dreimark>  :)
 220 2010-07-29T23:11:36  <dreimark> gives a bullet list
 221 2010-07-29T23:11:54  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9166:6221184bd4f4 2.0-dev/MoinMoin/converter2/smiley.py: smiley converter: use url_for(), use smiley list from converter, cosmetic changes
 222 2010-07-29T23:11:57  <valeuf> dreimark: no it inverts the 3 and the 4 for me
 223 2010-07-29T23:12:06  <valeuf> ThomasWaldmann: did you find the cause of the bug?
 224 2010-07-29T23:12:08  <ThomasWaldmann> yeah, for me too
 225 2010-07-29T23:12:15  * dreimark found an other issue
 226 2010-07-29T23:12:20  <dreimark>  :)
 227 2010-07-29T23:12:20  <ThomasWaldmann> not yet, did just some cosmetic stuff ^^
 228 2010-07-29T23:12:24  <dreimark> \n ;)
 229 2010-07-29T23:12:36  <valeuf> ThomasWaldmann: I will try to find, it is really weird
 230 2010-07-29T23:13:30  <dreimark> hmm, is it intended that when a line starts with a blank that it becomes a bullet list?
 231 2010-07-29T23:13:39  <dreimark>  This
 232 2010-07-29T23:14:00  <valeuf> with the moinmoin syntax ?
 233 2010-07-29T23:14:05  <dreimark> yes
 234 2010-07-29T23:14:10  <dreimark> blank This
 235 2010-07-29T23:16:03  <valeuf> it happens only with creol and moinmoin syntax converter
 236 2010-07-29T23:16:15  <valeuf> I suspect some problem in the DOM tree during the conversion
 237 2010-07-29T23:16:20  <ThomasWaldmann> no, shouldn't be bullet imho
 238 2010-07-29T23:16:41  <valeuf> dreimark: yes, it is a bug too :)
 239 2010-07-29T23:17:28  <dreimark> looks like we need more tests. I mean specially those which not are common
 240 2010-07-29T23:18:07  <valeuf> dreimark: actually for the smiley, I wrote really simple test, I should probably write more
 241 2010-07-29T23:18:50  <dreimark> yes but i meant it different. we need tests which are not only the common way we would write text.
 242 2010-07-29T23:19:14  <dreimark> otherwise we test only how we use the application
 243 2010-07-29T23:19:28  <dreimark> and anyone who is not on our path will fail badly
 244 2010-07-29T23:19:59  <CIA-50> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9167:cdf54083048c 2.0-dev/MoinMoin/converter2/smiley.py: smiley converter: also accept line ending after a smiley
 245 2010-07-29T23:20:17  <valeuf> it fixed the bug?
 246 2010-07-29T23:20:25  <ThomasWaldmann> no, other bug
 247 2010-07-29T23:20:30  <valeuf> T.T
 248 2010-07-29T23:21:56  <ThomasWaldmann> valeuf: did you copy/add the smileys to the new location?
 249 2010-07-29T23:22:13  <valeuf> ThomasWaldmann: yes
 250 2010-07-29T23:22:29  <valeuf> it did not work?
 251 2010-07-29T23:23:14  <ThomasWaldmann> well, if they are not used otherwise, we could've moved them?
 252 2010-07-29T23:23:36  <valeuf> hum, weird in my working directory, I have the smiley pics in 2 folder, it is not what I wanted
 253 2010-07-29T23:24:02  <valeuf> ThomasWaldmann: you want to put them in a specific directory independant from the theme?
 254 2010-07-29T23:24:39  <ThomasWaldmann> no, other theme could have different looking smiley
 255 2010-07-29T23:25:06  <valeuf> yep, by the way, the official location is now theme_directory/img/smileys
 256 2010-07-29T23:25:09  <ThomasWaldmann> but if we don't need them except as for smiley markup, why should we have them in the upper dir also?
 257 2010-07-29T23:25:43  <valeuf> ThomasWaldmann: it is an error :) I probably did it wrongly with mercurial, sorry about it :$
 258 2010-07-29T23:25:56  * valeuf will go back to read mercurial book
 259 2010-07-29T23:29:16  <ThomasWaldmann> hg mv :)
 260 2010-07-29T23:30:07  <ThomasWaldmann> btw, we have another problem with line ends
 261 2010-07-29T23:30:08  <ThomasWaldmann> 1
 262 2010-07-29T23:30:09  <ThomasWaldmann> 2
 263 2010-07-29T23:30:10  <ThomasWaldmann> 3
 264 2010-07-29T23:30:16  <ThomasWaldmann> that should render like:
 265 2010-07-29T23:30:19  <ThomasWaldmann> 1 2 3
 266 2010-07-29T23:30:22  <ThomasWaldmann> not:
 267 2010-07-29T23:30:24  <ThomasWaldmann> 123
 268 2010-07-29T23:31:11  <valeuf> hum me I get 132 :p
 269 2010-07-29T23:31:19  * dreimark gets 132 too#
 270 2010-07-29T23:31:41  <valeuf> which means smiley is maybe not the problem
 271 2010-07-29T23:31:46  <dreimark> 135264 (1-6)
 272 2010-07-29T23:32:08  <dreimark> do you have implemented the weird algo?
 273 2010-07-29T23:32:36  <valeuf> wow
 274 2010-07-29T23:32:48  <ThomasWaldmann> Data:
 275 2010-07-29T23:32:50  <ThomasWaldmann> 13542
 276 2010-07-29T23:33:05  <valeuf> (0-9) --> 0246815973
 277 2010-07-29T23:33:08  <ThomasWaldmann> something is weird there ;D
 278 2010-07-29T23:33:08  <valeuf> I do not see any logic
 279 2010-07-29T23:33:14  <valeuf> god is talking to us :p
 280 2010-07-29T23:33:48  <ThomasWaldmann> but it is always same output for same input :D
 281 2010-07-29T23:34:08  <dreimark> 15243
 282 2010-07-29T23:34:35  <valeuf> We just created a really nice cryptographic algorithm ^ ^
 283 2010-07-29T23:34:45  <diofeher> hahaha
 284 2010-07-29T23:35:31  <dreimark> the first one is always the first
 285 2010-07-29T23:35:57  <dreimark> if the last would also the last it would be the excercise you had at the beginning
 286 2010-07-29T23:36:23  <valeuf> (1-9) --> 135794862 it is completely shuffle compare to (0-9)
 287 2010-07-29T23:36:27  <valeuf> it is completely insane
 288 2010-07-29T23:37:28  <valeuf> ah ah ah VALENTIN --> VLIATENN
 289 2010-07-29T23:38:22  <ThomasWaldmann> waldi: ^^
 290 2010-07-29T23:40:15  <valeuf> ThomasWaldmann: no it is not waldi fault, it is mine
 291 2010-07-29T23:40:27  <valeuf> ThomasWaldmann: I disactivate the smiley converter and it works fine
 292 2010-07-29T23:41:07  <valeuf> But I do not understand what I am doing in the smiley converter to messed up stuff like that
 293 2010-07-29T23:41:33  <diofeher> hey guys, are you going to use session of flask?
 294 2010-07-29T23:42:45  <dreimark> diofeher: proably yes
 295 2010-07-29T23:43:31  <diofeher> dreimark: nice ^^
 296 2010-07-29T23:45:28  <valeuf> I have an idea about the place of the bug
 297 2010-07-29T23:45:39  <valeuf> but not clear way to solve it
 298 2010-07-29T23:50:01  <CIA-50> Diogenes Augusto Fernandes Herminio <diofeher@gmail.com> default * 9187:e37e01cc4b0e 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (39 files in 7 dirs): [templating] merge with main repo
 299 2010-07-29T23:52:11  <valeuf> ok the order problem is fixed
 300 2010-07-29T23:52:14  <valeuf> now the space
 301 2010-07-29T23:54:42  <TheSheep> and beyond
 302 2010-07-29T23:55:01  <valeuf> :D
 303 2010-07-29T23:55:39  <diofeher> hm, atom feed is with error in converter 2
 304 2010-07-29T23:56:09  <diofeher> http://paste.pocoo.org/show/243207/
 305 2010-07-29T23:56:11  <valeuf> diofeher: what the relation between atom feed and the converter?
 306 2010-07-29T23:56:21  <diofeher> valeuf ^^ traceback
 307 2010-07-29T23:56:55  <valeuf> diofeher: hmmm
 308 2010-07-29T23:57:03  <valeuf> it is bug squashing day ...
 309 2010-07-29T23:57:52  <diofeher> hehe

MoinMoin: MoinMoinChat/Logs/moin-dev/2010-07-29 (last edited 2010-07-28 22:45:02 by IrcLogImporter)