1 2010-09-14T00:06:26 *** RogerHaase
2 2010-09-14T08:34:27 <dreimark> moin
3 2010-09-14T08:35:31 <dreimark> how can i get all items? Or I don't need to compare with the regex if I can get only those which define groups.
4 2010-09-14T08:37:44 <dreimark> flaskg.storage.get_index() shows AttributeError: 'RouterBackend' object has no attribute 'get_index'
5 2010-09-14T08:45:43 <dreimark> all_items = flaskg.storage.iteritems() seems to be what I need
6 2010-09-14T09:38:58 *** gwork
7 2010-09-14T11:17:20 <ThomasWaldmann> moin
8 2010-09-14T14:05:21 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9915:9adbf9288355 2.0-dev/MoinMoin/conftest.py: test: make SECRET_KEY long enough for cfg.secrets also
9 2010-09-14T14:05:25 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9916:bae5896c47bd 2.0-dev/MoinMoin/ (9 files in 8 dirs): (log message trimmed)
10 2010-09-14T14:05:25 <CIA-36> User / config: cleanup attributes and defaults
11 2010-09-14T14:05:25 <CIA-36> User: unconfigured attributes should be None now, only non-None values get
12 2010-09-14T14:05:25 <CIA-36> saved into profile
13 2010-09-14T14:05:25 <CIA-36> get_locale: cosmetic changes (use locale instead of lang)
14 2010-09-14T14:05:25 <CIA-36> config:
15 2010-09-14T14:05:26 <CIA-36> * new: user_defaults - a dict holding ALL default values that are copied into
16 2010-09-14T14:23:21 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9917:5db1231a4914 2.0-dev/ (4 files in 3 dirs): remove url_prefix_* settings, we just use the default from flask (/static) now
17 2010-09-14T15:06:50 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9918:d783fa8552a8 2.0-dev/ (9 files in 8 dirs):
18 2010-09-14T15:06:50 <CIA-36> rename some page_* config attributes
19 2010-09-14T15:06:50 <CIA-36> page_front_page -> item_root
20 2010-09-14T15:06:50 <CIA-36> page_license_page -> item_license
21 2010-09-14T15:06:50 <CIA-36> page_credits -> credits
22 2010-09-14T15:16:24 <dreimark> moin
23 2010-09-14T15:32:12 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9919:93d93eeac482 2.0-dev/ (4 files in 4 dirs): rename logo_string > logo, only render logo div if we have a logo (internal default: no logo)
24 2010-09-14T15:32:15 <ThomasWaldmann> hi dreimark
25 2010-09-14T15:35:19 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9920:af7cb8ebad85 2.0-dev/MoinMoin/config/default.py: config attr str -> unicode decoding - also decode empty str
26 2010-09-14T15:55:36 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9921:0f51c185aaab 2.0-dev/MoinMoin/config/default.py: add some more names to decode_names so they get decoded if they are str
27 2010-09-14T15:57:07 <dreimark> I see more cleanup ;)
28 2010-09-14T16:07:02 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9922:70cbc9fc78b2 2.0-dev/MoinMoin/config/default.py: if we want unicode for some config attr, tell so in the docs
29 2010-09-14T16:09:24 * ThomasWaldmann looks at the strange html_head* stuff now
30 2010-09-14T16:19:04 * ThomasWaldmann feels like just killing it
31 2010-09-14T16:20:51 <ThomasWaldmann> some of it maybe made sense for moin 1.x, but not for the different url design (and possibility of robots.txt usage) of moin2, we also do not have (automatic) "index pages" any more, like TitleIndex or RecentChanges
32 2010-09-14T16:32:37 *** RogerHaase
33 2010-09-14T16:35:42 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9923:fbbc27d01aa1 2.0-dev/MoinMoin/ (config/default.py templates/base.html theme/__init__.py):
34 2010-09-14T16:35:42 <CIA-36> get rid of cfg.html_head_* - doesn't make sense any more for moin2
35 2010-09-14T16:35:42 <CIA-36> moin 1.9 tried to use these to tame some search engine bots.
36 2010-09-14T16:35:42 <CIA-36> for moin2 with its new restful url design, we can make better use of robots.txt
37 2010-09-14T16:35:42 <CIA-36> as we could with 1.9 (because action were in query string in 1.9, now they
38 2010-09-14T16:35:43 <CIA-36> are in path).
39 2010-09-14T16:44:39 <ThomasWaldmann> bah, most of those link rel are wrong
40 2010-09-14T17:02:57 *** gwork
41 2010-09-14T17:19:57 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9924:7ed35e4da8e5 2.0-dev/MoinMoin/templates/base.html: (log message trimmed)
42 2010-09-14T17:19:57 <CIA-36> removed some link rel crap, added link rel="archives"
43 2010-09-14T17:19:57 <CIA-36> Added:
44 2010-09-14T17:19:57 <CIA-36> archives: links to current item's history
45 2010-09-14T17:19:57 <CIA-36> Deleted:
46 2010-09-14T17:19:58 <CIA-36> search: no FindPage any more, should be reimplemented with OpenSearch later
47 2010-09-14T17:19:58 <CIA-36> index: should be an index (or top document?) related to the CURRENT document (not a global wiki index), drop it
48 2010-09-14T17:55:20 *** vpv
49 2010-09-14T17:55:54 *** vpv
50 2010-09-14T18:14:17 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9925:bc7e6638d8a8 2.0-dev/MoinMoin/templates/ (base.html show.html):
51 2010-09-14T18:14:17 <CIA-36> templates: restructure html head, group similar stuff together
52 2010-09-14T18:14:17 <CIA-36> remove type attr for javascript scripts (this is default in html5)
53 2010-09-14T18:14:17 <CIA-36> show template: just extend head_links block, not head block
54 2010-09-14T18:30:02 *** RogerHaase
55 2010-09-14T18:32:42 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9926:4f57287859ad 2.0-dev/MoinMoin/templates/layout.html: use div for locationline, h1 shall be used by content only
56 2010-09-14T18:34:52 <TheSheep> ThomasWaldmann: any rationale for that?
57 2010-09-14T18:35:48 <ThomasWaldmann> it's navigation, not a title or headline
58 2010-09-14T18:36:42 <TheSheep> ThomasWaldmann: doesn't it contain the title of the page?
59 2010-09-14T18:36:56 <TheSheep> s/title/name, s/page/item
60 2010-09-14T18:37:13 <xorAxAx> ESYNTAX
61 2010-09-14T18:38:38 <ThomasWaldmann> it's comparable to letter_grandma.odt :)
62 2010-09-14T18:39:12 <ThomasWaldmann> giving the item name, but not necessarily usable as a headline
63 2010-09-14T18:39:16 <TheSheep> ThomasWaldmann: the rule of thumb I usually use when styling web pages is: make it look good and logical without styles first, then apply styles
64 2010-09-14T18:39:52 <TheSheep> at least in theory
65 2010-09-14T18:40:08 <ThomasWaldmann> how's that related?
66 2010-09-14T18:40:56 <TheSheep> changing all the non-content tags to divs will make it all run together and be completely unusable without css
67 2010-09-14T18:43:04 <TheSheep> also, html5 has some tags for navigation and such...
68 2010-09-14T18:43:15 <ThomasWaldmann> i've just seen that modernized in 1.9 also uses h1 there, but not modern
69 2010-09-14T18:43:34 <TheSheep> yes, it's one of the changes I made
70 2010-09-14T18:43:49 <ThomasWaldmann> i just think Hn should be just the content, not the navigation. esp since = foo = gives h1 also
71 2010-09-14T18:44:12 <TheSheep> there is no rule saying that tag names cannot repeat on a page
72 2010-09-14T18:44:27 <ThomasWaldmann> sure they will, e.g. with = bar =
73 2010-09-14T18:44:39 <ThomasWaldmann> but the point is that usage is mixed then
74 2010-09-14T18:44:53 <ThomasWaldmann> some h1 will be navigation, all other h1 will be content
75 2010-09-14T18:45:18 <TheSheep> the h1 by itself only means 'heading', what it is heading of is determined by enclosing elements -- the header in this case
76 2010-09-14T18:45:34 <ThomasWaldmann> also, we have other breadcrumbs stuff in the nav area, which is currently not h1 either
77 2010-09-14T18:45:38 <TheSheep> you can also have a side menu with headings in it
78 2010-09-14T18:45:42 <ThomasWaldmann> like the trail
79 2010-09-14T18:45:44 <TheSheep> and it's perfectly correct
80 2010-09-14T18:46:14 <ThomasWaldmann> ok, and so what is it heading? :)
81 2010-09-14T18:46:39 <TheSheep> the header, of course, which is a navigation element by itself
82 2010-09-14T18:46:43 <ThomasWaldmann> i see the point for sidebar headlines
83 2010-09-14T18:46:58 <TheSheep> so it makes sense that the location is the header of the navigation element
84 2010-09-14T18:47:37 <TheSheep> I'm not going to insist to use h1, I just don't want it to be all divs
85 2010-09-14T18:48:25 <TheSheep> it will then be 'semantically correct' as far as 'no semantics involved whatsoever' is crrect semantics
86 2010-09-14T18:49:15 <ThomasWaldmann> well, that being the heading of header is not so obvious for me as it is rather in the midst of it
87 2010-09-14T18:49:39 <ThomasWaldmann> (middle*?)
88 2010-09-14T18:49:44 <TheSheep> that's accidental due to limitations in our css skills ;)
89 2010-09-14T18:50:02 <TheSheep> and msie 6
90 2010-09-14T18:50:42 <ThomasWaldmann> i just don't want that "i want another title there" discussion again :)
91 2010-09-14T18:51:10 <ThomasWaldmann> so it should be more obvious that this is not the title, it is just the item name
92 2010-09-14T18:51:29 <TheSheep> ThomasWaldmann: do you think using <address> would be bad?
93 2010-09-14T18:51:46 <ThomasWaldmann> and h1 felt somehow counterproductive with respect to that
94 2010-09-14T18:52:09 <ThomasWaldmann> isn't that rather for postal addresses? :)
95 2010-09-14T18:53:43 <TheSheep> lets check out options, we have <p>, <blockquote>, <ins>, <del> and <pre>
96 2010-09-14T18:53:57 <TheSheep> from the block-level tags in html4
97 2010-09-14T18:54:12 <TheSheep> and <center> :D
98 2010-09-14T18:55:40 <TheSheep> "The ADDRESS element provides contact information for a document or part of a document."
99 2010-09-14T18:58:02 <TheSheep> right, it's not good
100 2010-09-14T20:28:09 *** RogerHaase
101 2010-09-14T20:31:48 * ThomasWaldmann kills widget package
102 2010-09-14T20:32:25 <dreimark> re
103 2010-09-14T20:36:18 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9927:8705e51b2a13 2.0-dev/MoinMoin/util/ (_tests/test_web.py web.py): remove MoinMoin.util.web + tests, not used any more
104 2010-09-14T20:36:33 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9928:84b01f23a869 2.0-dev/MoinMoin/util/__init__.py: remove some unused stuff from MoinMoin.util
105 2010-09-14T20:36:46 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9929:c339abd285fb 2.0-dev/MoinMoin/ (7 files in 3 dirs): removed MoinMoin.widget, not used any more
106 2010-09-14T20:44:17 <dreimark> ThomasWaldmann: item.copy() is broken, IntegrityError: (IntegrityError) column name is not unique u'INSERT INTO item_table (uuid, name) VALUES (?, ?)' [u'SomeOtherGroup', u'SomeGroup']
107 2010-09-14T20:46:32 <ThomasWaldmann> that uuid stuff is not final yet, not even really ready
108 2010-09-14T20:48:34 <dreimark> ok, then i skip that test for now
109 2010-09-14T20:49:44 <ThomasWaldmann> DmitryAndreev_: btw, it would be cool if you could help to make some of the converter tests (or code?) less broken
110 2010-09-14T21:27:57 *** grzywacz
111 2010-09-14T21:38:31 <dreimark> missing tests have quite the same problem: AttributeError: 'AclWrapperItem' object has no attribute '_save'
112 2010-09-14T21:52:26 <ThomasWaldmann> all my missing tests don't have troubles :D
113 2010-09-14T21:59:47 <dreimark> haha - the bad ones
114 2010-09-14T22:08:23 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9930:3e335748317b 2.0-dev/MoinMoin/ (9 files in 7 dirs): move interwiki functions from wikiutil to util.interwiki
115 2010-09-14T22:45:16 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9931:d0bba2150583 2.0-dev/MoinMoin/ (_tests/test_wikiutil.py wikiutil.py): remove wikiutil.ParameterParser (unused)
116 2010-09-14T23:00:40 <dreimark> test_wiki_groups.py ..........s...s.
117 2010-09-14T23:01:18 <dreimark> after some more refactoring of that test api i'll push it
118 2010-09-14T23:02:30 <dreimark> the two skipped are because of: 'trivial change not implemented yet' or 'item.copy() is not finished'
119 2010-09-14T23:11:23 <ThomasWaldmann> how are trivial changes related to groups?
120 2010-09-14T23:16:00 <dreimark> in the past we had a bug that the event was not triggered by trivial change to update groups
121 2010-09-14T23:20:47 <ThomasWaldmann> what event?
122 2010-09-14T23:21:32 <ThomasWaldmann> (btw, i completely ripped out that event handling, so there's currently nothing)
123 2010-09-14T23:27:40 <dreimark> i know (http://hg.moinmo.in/moin/1.9/file/7a83cc907f68/MoinMoin/events/__init__.py#l58)
124 2010-09-14T23:28:31 <dreimark> thats why i skipped it and because we did once the mistake in the past
125 2010-09-14T23:33:07 <ThomasWaldmann> well, in case the test doesn't make sense any more, rather remove it
126 2010-09-14T23:34:26 <dreimark> ok
127 2010-09-14T23:38:20 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9932:3e3ae3cbe518 2.0-dev/MoinMoin/ (5 files in 5 dirs): move the other parameter parser from wikiutil to util.paramparser
128 2010-09-14T23:40:19 <dreimark> gn
129 2010-09-14T23:40:29 <ThomasWaldmann> gn dreimark
130 2010-09-14T23:41:44 *** grzywacz
131
