1 2010-12-02T00:04:09 <ThomasWaldmann> pygments is 3rd party stuff
2 2010-12-02T00:04:26 <ThomasWaldmann> what you see there is pygments code, we use pygments just for code highlighting
3 2010-12-02T00:05:07 <m4k3r> ThomasWaldmann: so, I shouldn't care about it?
4 2010-12-02T00:12:08 <ronny> m4k3r: i dont think so, syntax highlighting is completely orthogonal to auth
5 2010-12-02T00:12:39 <m4k3r> ronny: then, how is that file generated?
6 2010-12-02T00:15:36 <ThomasWaldmann> modifying anything below MoinMoin/support/ is usually not in scope of gci tasks
7 2010-12-02T00:15:57 <ThomasWaldmann> m4k3r: do you like searching memory leaks? :)
8 2010-12-02T00:16:53 <ThomasWaldmann> on old linux system? :)
9 2010-12-02T00:24:49 <m4k3r> ThomasWaldmann: why such a question? :)
10 2010-12-02T00:25:43 <ThomasWaldmann> because i have one :D
11 2010-12-02T00:25:45 <m4k3r> I've had too few experiences with memleaks to give an opinion.
12 2010-12-02T00:26:05 <m4k3r> ThomasWaldmann:
13 2010-12-02T00:26:08 <m4k3r> on moinmoin?
14 2010-12-02T00:26:16 <ThomasWaldmann> xapian-indexer eating memory for breakfast, lunch and dinner and in between
15 2010-12-02T00:26:43 <ThomasWaldmann> no, on a similar big wiki, but with very many attachments
16 2010-12-02T00:29:56 <m4k3r> :o
17 2010-12-02T00:30:16 <m4k3r> No, never used valgrid anyway.
18 2010-12-02T00:43:19 *** m4k3r
19 2010-12-02T00:47:37 *** nickr5
20 2010-12-02T01:22:07 *** jrabbit
21 2010-12-02T01:23:16 <jrabbit> Which version of test failure fixes are the GCI tasks for?
22 2010-12-02T01:42:11 <ThomasWaldmann> you mean for which moin version?
23 2010-12-02T01:42:19 <ThomasWaldmann> jrabbit:
24 2010-12-02T01:42:21 <jrabbit> Yes
25 2010-12-02T01:42:29 <jrabbit> theres two HG repos
26 2010-12-02T01:42:39 <ThomasWaldmann> most bugs on the wiki are for moin 1.x
27 2010-12-02T01:42:43 <jrabbit> I don't know why its not branches...
28 2010-12-02T01:42:52 <ThomasWaldmann> but the moin version is usually specified in the bug report
29 2010-12-02T01:43:04 <jrabbit> ThomasWaldmann: they just say "medium test" http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965999
30 2010-12-02T01:43:12 <ThomasWaldmann> we use hg for a long time
31 2010-12-02T01:43:32 <ThomasWaldmann> you first have to find something you want to solve
32 2010-12-02T01:43:40 <ThomasWaldmann> then talk to us about difficulty
33 2010-12-02T01:43:49 <ThomasWaldmann> then claim the right task
34 2010-12-02T01:43:51 <jrabbit> ThomasWaldmann: yeah but shouldn't it be an hg branch?
35 2010-12-02T01:43:52 <jrabbit> :P
36 2010-12-02T01:44:04 <ThomasWaldmann> branches did not exist back then
37 2010-12-02T01:44:10 * jrabbit hasn't used hg alot thoguh so I might not get it
38 2010-12-02T01:44:11 <jrabbit> ah
39 2010-12-02T01:44:12 <jrabbit> :)
40 2010-12-02T01:44:30 <ThomasWaldmann> also, having stuff separate might be more robust maybe
41 2010-12-02T01:45:15 <jrabbit> just curious
42 2010-12-02T01:45:47 <ThomasWaldmann> sorry that the claiming for test/bug fixes is a bit complicated, but we could not create hundreds of tasks for all the bugs including difficulty and time estimation
43 2010-12-02T01:46:22 <ThomasWaldmann> on the positive side, you have more freedom this way
44 2010-12-02T01:48:54 <jrabbit> heh
45 2010-12-02T01:49:28 <jrabbit> is there a list of failing test or do I need to run my own?
46 2010-12-02T01:50:50 <ThomasWaldmann> just run py.test
47 2010-12-02T01:51:21 <jrabbit> is that its own app?
48 2010-12-02T01:51:24 <ThomasWaldmann> for tests, you can either use moin/2.0-dev (lots of failing tests) or moin/1.9 (few)
49 2010-12-02T01:51:37 <jrabbit> ThomasWaldmann: you were syaign to use 1.9? :S
50 2010-12-02T01:51:39 <ThomasWaldmann> that's a test framework
51 2010-12-02T01:51:58 <jrabbit> how do I run them?
52 2010-12-02T01:52:11 <ThomasWaldmann> for moin2 run pytest from the toplevel dir
53 2010-12-02T01:52:47 <ThomasWaldmann> (pytest is a file included there, somehow a compressed bundled version of py.test)
54 2010-12-02T01:53:14 <ThomasWaldmann> btw, start with cloning moin/2.0-dev, takes a while
55 2010-12-02T01:53:50 <jrabbit> k
56 2010-12-02T01:53:58 <jrabbit> yeah its bigger then 1.9 :(
57 2010-12-02T01:54:13 <ThomasWaldmann> if you want something difficult to fix, i have a memory leak in 1.9 to offer :)
58 2010-12-02T01:54:21 <jrabbit> nope!
59 2010-12-02T01:54:22 <jrabbit> :)
60 2010-12-02T01:54:38 <ThomasWaldmann> hehe, shit, now i have to fix it on my own :D
61 2010-12-02T02:11:11 *** jordonwii
62 2010-12-02T02:12:13 <jordonwii> Moin
63 2010-12-02T02:17:00 <jordonwii> ThomasWaldmann: are you here?
64 2010-12-02T02:21:37 <jordonwii> Are you here dreimark?
65 2010-12-02T02:23:06 <ThomasWaldmann> just ask :)
66 2010-12-02T02:23:18 <ThomasWaldmann> (what you want to really know)
67 2010-12-02T02:23:47 <jordonwii> Ah =)
68 2010-12-02T02:23:56 <jordonwii> Did you check out my patch?
69 2010-12-02T02:26:20 <ThomasWaldmann> not yet. had to / have to do some emergency fixing.
70 2010-12-02T02:26:33 <jordonwii> Kk
71 2010-12-02T02:26:51 <ThomasWaldmann> maybe use the time to do own review/refinement
72 2010-12-02T02:27:28 <jordonwii> Ok...I really don't have a whole lot of time ATM
73 2010-12-02T02:27:43 <jordonwii> Got my mom yelling at me to come to dinner right now =p
74 2010-12-02T02:31:14 <ThomasWaldmann> :)
75 2010-12-02T02:32:37 <jordonwii> I'll bbl ;)
76 2010-12-02T03:52:25 <jrabbit> E ImportError: No module named json
77 2010-12-02T03:52:28 <jrabbit> wtf
78 2010-12-02T03:52:35 <jrabbit> it hasn't been named that for what
79 2010-12-02T03:52:37 <jrabbit> 5 years?
80 2010-12-02T03:53:05 <jrabbit> ThomasWaldmann: how about I make it try old json the inport simplejson.
81 2010-12-02T03:53:08 <jrabbit> *import
82 2010-12-02T03:54:18 <jrabbit> I'm using the oldest python I have.
83 2010-12-02T03:55:56 *** jordonwii
84 2010-12-02T03:56:28 *** jordonwii
85 2010-12-02T04:02:36 <jrabbit> ThomasWaldmann: there were so many errors stringIO failed to write I think.
86 2010-12-02T04:05:54 <jrabbit> ValueError: I/O operation on closed file
87 2010-12-02T04:06:47 <jrabbit> anyone around?
88 2010-12-02T04:07:11 <jrabbit> I made the tests run.on 2.0 which test failure does that count as? :P
89 2010-12-02T04:10:46 <jrabbit> jordonwii: ping?
90 2010-12-02T04:10:52 <jordonwii> ?
91 2010-12-02T04:10:59 <jordonwii> Eh?
92 2010-12-02T04:11:35 <jrabbit> not a GCI person?
93 2010-12-02T04:11:48 <jordonwii> Yes
94 2010-12-02T04:11:58 <jrabbit> is that a no or a yes
95 2010-12-02T04:12:10 <jrabbit> ValueError: I/O operation on closed file
96 2010-12-02T04:12:14 * jrabbit headdesk
97 2010-12-02T04:12:24 <jrabbit> did anyone ever run py.test on this
98 2010-12-02T04:12:25 <jrabbit> lol
99 2010-12-02T04:12:31 <jordonwii> Wait, what do you mean by GCI person?
100 2010-12-02T04:12:34 <jordonwii> I'm a student =)
101 2010-12-02T04:12:38 <jrabbit> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965999
102 2010-12-02T04:12:42 <jrabbit> jordonwii: oh
103 2010-12-02T04:12:44 <jrabbit> :)
104 2010-12-02T04:12:49 <jordonwii> Sorry ;)
105 2010-12-02T04:13:01 <jrabbit> looking for a monmoin dev to tell me which serverity this is
106 2010-12-02T04:13:08 <jrabbit> the testing structure fails :P
107 2010-12-02T04:13:16 <jrabbit> importing json? non!
108 2010-12-02T04:13:28 <jordonwii> Heh
109 2010-12-02T04:13:53 <jordonwii> ThomasWaldmann is busy making "some emergency fixes" he said
110 2010-12-02T04:15:22 <jrabbit> jordonwii: omg this is horrible spaggetti code of python versions
111 2010-12-02T04:15:28 <jrabbit> the wiki says they support 2.4
112 2010-12-02T04:15:32 <jrabbit> or w/e
113 2010-12-02T04:16:31 <jrabbit> AttributeError: magic
114 2010-12-02T04:16:33 <jrabbit> what.
115 2010-12-02T04:17:06 <jrabbit> jordonwii: what are you doing with moinmoin.
116 2010-12-02T04:17:16 <jordonwii> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966150
117 2010-12-02T04:17:23 <jordonwii> A couple (easy) UI changes
118 2010-12-02T04:18:13 <jrabbit> I don't even know what thats asking :D
119 2010-12-02T04:19:45 <jordonwii> If an item (like an image) is included on a page, I'm making a mouseover that gives a link to view just the image
120 2010-12-02T04:19:47 <jordonwii> By itself
121 2010-12-02T04:21:04 <jrabbit> ah
122 2010-12-02T04:21:51 <jordonwii> =)
123 2010-12-02T04:22:14 <jrabbit> MoinMoin/security/_tests/test_security.py:161:
124 2010-12-02T04:22:23 <jrabbit> ^ I think this test is bunk
125 2010-12-02T04:23:10 <jordonwii> Ok
126 2010-12-02T04:24:32 <jordonwii> If you say so =p
127 2010-12-02T04:25:14 <jrabbit> jordonwii: it failed like a million lines
128 2010-12-02T04:25:30 <jrabbit> 21338 py.test.log
129 2010-12-02T04:25:39 <jrabbit> 21338 lines of fail
130 2010-12-02T04:26:02 <jordonwii> I don't know much about the tests
131 2010-12-02T04:26:32 <jrabbit> ThomasWaldmann: the included pytest is ancient.
132 2010-12-02T04:30:34 <jrabbit> jordonwii: is it easy to main tain an hg fork or what should I do in hg to track my changes
133 2010-12-02T04:30:44 <jrabbit> I'm a git user most of the time
134 2010-12-02T04:31:30 <jordonwii> Just make the changes you want, then 'hg pull', 'hg update'
135 2010-12-02T04:31:39 <jordonwii> And then go 'hg diff > mypatch.diff'
136 2010-12-02T04:33:04 <jrabbit> jordonwii: eeeeeh :P
137 2010-12-02T04:33:43 * jrabbit will look at hg guis and hg-git
138 2010-12-02T04:34:28 <jordonwii> =)
139 2010-12-02T04:56:44 <jordonwii> Ok, I gotta go
140 2010-12-02T04:56:46 <jordonwii> 'Night
141 2010-12-02T04:56:51 *** jordonwii
142 2010-12-02T05:02:21 *** moin2
143 2010-12-02T05:02:32 <moin2> is mr.waldmann there?
144 2010-12-02T05:06:46 <moin2> is anyone there?
145 2010-12-02T05:09:21 <moin2> despite the insistence that my code had bugs, i am going to submit it anyways for evaluation
146 2010-12-02T05:09:29 <moin2> i feel confident it is right
147 2010-12-02T05:14:32 *** nickr5
148 2010-12-02T05:15:25 *** kursor
149 2010-12-02T05:15:54 *** moin2
150 2010-12-02T06:45:46 *** kursor
151 2010-12-02T08:12:48 *** faina
152 2010-12-02T08:20:32 <dreimark> moin
153 2010-12-02T09:18:10 *** faina
154 2010-12-02T09:26:03 <dreimark> bbl
155 2010-12-02T10:15:17 *** rfw
156 2010-12-02T10:58:07 *** greg_f
157 2010-12-02T11:05:41 *** greg_f
158 2010-12-02T11:08:40 *** greg_f
159 2010-12-02T11:37:52 *** achshar
160 2010-12-02T11:38:18 *** achshar
161 2010-12-02T11:39:46 *** achshar
162 2010-12-02T11:39:57 <achshar> hello!
163 2010-12-02T11:40:28 <xorAxAx> achshar: do you have a local moin installation?
164 2010-12-02T11:40:44 <xorAxAx> you dont need xampp
165 2010-12-02T11:41:04 <xorAxAx> you only need python and moinmoin
166 2010-12-02T11:41:22 <achshar> ohkz i can get moin moin
167 2010-12-02T11:41:40 <achshar> and can you give me link to python?
168 2010-12-02T11:41:46 <xorAxAx> www.python.org
169 2010-12-02T11:42:15 <achshar> thanks.. let me installit first
170 2010-12-02T11:50:20 <achshar> BTW i have added the screenshots.. please havea look and see if anything else is needed :D
171 2010-12-02T11:50:23 <achshar> http://moinmo.in/EasyToDo/make%20an%20alternate%20stylesheet/sunset
172 2010-12-02T11:59:50 * xorAxAx is gone shopping
173 2010-12-02T11:59:58 <xorAxAx> achshar: while i am away, others may help you as well
174 2010-12-02T12:04:24 <TheSheep> achshar: http://www.quirksmode.org/css/clearing.html
175 2010-12-02T12:10:33 <achshar> TheSheep: you made my day man! thanks a ton. learned something new. :P
176 2010-12-02T12:11:04 <achshar> so i guess i dont need a patch now :D and i can finaly submit the work
177 2010-12-02T12:11:21 <achshar> thanks everybody
178 2010-12-02T12:34:13 <ThomasWaldmann> re
179 2010-12-02T12:55:05 <achshar> i have submited the task for review again :)
180 2010-12-02T13:06:55 *** achshar
181 2010-12-02T15:38:52 *** kursor
182 2010-12-02T16:12:33 <jrabbit> ThomasWaldmann: ping
183 2010-12-02T16:27:49 <dreimark> re
184 2010-12-02T16:29:53 *** achshar
185 2010-12-02T16:39:08 *** jrabbit
186 2010-12-02T16:39:38 <achshar> hello. i have submited the improved header css file. can you please check it out if it is ok
187 2010-12-02T16:40:20 *** jrabbit
188 2010-12-02T16:43:22 <jrabbit> Back
189 2010-12-02T16:47:20 *** m4k3r
190 2010-12-02T17:10:58 <achshar> so can any mentor review my task.. its night over here and if there are any small improvements then i would like to finish this task before going to bed.. ;)
191 2010-12-02T17:18:49 <dreimark> achshar: soon i am still at work
192 2010-12-02T17:22:42 <dreimark> btw. we need to wait about a fix of melange
193 2010-12-02T17:35:15 <dreimark> achshar: just a question if i look at http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=sunset.png
194 2010-12-02T17:35:37 <dreimark> i have a blue line which I don't see on your images
195 2010-12-02T17:36:01 <dreimark> I am not unhappy with it, just want to know if you see this too
196 2010-12-02T17:39:31 *** maker__
197 2010-12-02T17:39:39 <dreimark> bbl
198 2010-12-02T17:39:56 *** m4k3r
199 2010-12-02T17:47:16 <achshar> sorry for late response
200 2010-12-02T17:47:22 <achshar> yes i intentionaly removed it
201 2010-12-02T17:48:13 <achshar> because i was unable to fit any good color in it
202 2010-12-02T17:48:33 <achshar> but in the image you gave the logo blue looks good with it
203 2010-12-02T17:48:42 <achshar> it could be added with it
204 2010-12-02T17:50:39 <achshar> strange that you have that line.. in my css file, it was removed..
205 2010-12-02T17:51:41 <achshar> #moin-pageline { clear: both; margin: 0px 0px -1px; padding: 0; width: 100%; border-bottom: 1px solid #333; } it dosent even have a background color
206 2010-12-02T17:52:00 <achshar> did you add it manualy to the file?
207 2010-12-02T18:41:55 <achshar> gtg
208 2010-12-02T18:41:59 *** achshar
209 2010-12-02T18:59:11 *** maker__
210 2010-12-02T19:42:57 <dreimark> re
211 2010-12-02T20:10:14 *** rfw
212 2010-12-02T20:11:43 *** greg_f
213 2010-12-02T20:49:32 *** m4k3r
214 2010-12-02T21:10:49 *** kursor
215 2010-12-02T22:08:08 <jrabbit> dreimark: stil laround?
216 2010-12-02T22:08:51 <jrabbit> i fixed an silly import error that broke tests that shoul be pulled... which GCI task level woudl that be? easy? :P
217 2010-12-02T22:13:18 <dreimark> jrabbit: yes
218 2010-12-02T22:13:29 <jrabbit> ok :)
219 2010-12-02T22:13:41 <jrabbit> should I upload a diff or make a pull request?
220 2010-12-02T22:13:54 <dreimark> make first a claim request
221 2010-12-02T22:14:07 <ThomasWaldmann> re
222 2010-12-02T22:14:07 <jrabbit> k
223 2010-12-02T22:14:15 <jrabbit> ThomasWaldmann: what?
224 2010-12-02T22:14:29 <dreimark> describe the bug you want to fix a bit
225 2010-12-02T22:14:39 <dreimark> so we avoid double claiming
226 2010-12-02T22:14:49 <jrabbit> I went ahead and fixed it to run the tests
227 2010-12-02T22:14:55 <jrabbit> you import json tools as "json"
228 2010-12-02T22:14:59 <ThomasWaldmann> jrabbit: ?
229 2010-12-02T22:15:02 <dreimark> jrabbit: this means return (re)
230 2010-12-02T22:15:17 <jrabbit> I don't know where that works but its not portable
231 2010-12-02T22:15:50 <jrabbit> simplejson is everywhere though.
232 2010-12-02T22:15:51 <dreimark> our cloaks are always online but soemtimes the body needs sleep
233 2010-12-02T22:16:23 <dreimark> so we tell when we are active on irc
234 2010-12-02T22:16:27 <jrabbit> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965405
235 2010-12-02T22:16:34 <jrabbit> dreimark: oh I see.
236 2010-12-02T22:16:51 <jrabbit> odd that you don't use /away and such but whatever
237 2010-12-02T22:17:09 <dreimark> well i am able to read backlog
238 2010-12-02T22:17:44 <ThomasWaldmann> jrabbit: we require 2.6 and 2.6 has "json" in stdlib
239 2010-12-02T22:18:02 <dreimark> everyone can read answers on the wiki
240 2010-12-02T22:18:07 <jrabbit> ThomasWaldmann: mine doesn't
241 2010-12-02T22:18:16 <jrabbit> erm
242 2010-12-02T22:18:27 <jrabbit> nvm maybe 2.7 doesnt
243 2010-12-02T22:18:28 <ThomasWaldmann> what version is it exactly?
244 2010-12-02T22:18:37 <jrabbit> 2.6 does have it lemem hceck back in 2.7
245 2010-12-02T22:18:42 <jrabbit> odd
246 2010-12-02T22:18:48 <jrabbit> i was testing with 2.5
247 2010-12-02T22:18:55 <jrabbit> but that simple switch should work fine
248 2010-12-02T22:19:03 <jrabbit> it'll introduce 2.5 compat then
249 2010-12-02T22:19:22 <ThomasWaldmann> well, just a bit of 2.5 compat is pointless
250 2010-12-02T22:19:28 <jrabbit> and or you should make it explictly clear that its failing because of python not modules
251 2010-12-02T22:19:45 <ThomasWaldmann> and when we release 2.0 in maybe a year, 2.5 will be outdated anyway
252 2010-12-02T22:19:46 <jrabbit> ThomasWaldmann: also your atexit thing fails to actually log the py.test session
253 2010-12-02T22:19:55 <jrabbit> ThomasWaldmann: wiki is wrong then :P
254 2010-12-02T22:20:04 <ThomasWaldmann> what atexit thing?
255 2010-12-02T22:20:12 <jrabbit> ThomasWaldmann: well I can substitute the improt with an actual explination.
256 2010-12-02T22:20:47 <jrabbit> https://gist.github.com/725511
257 2010-12-02T22:22:35 <ThomasWaldmann> i don't see moin code there
258 2010-12-02T22:22:55 <jrabbit> py.test doesn't contain an atexit
259 2010-12-02T22:22:59 <jrabbit> moin does.
260 2010-12-02T22:23:28 <jrabbit> MoinMoin/conftest.py: atexit.register(report_coverage)
261 2010-12-02T22:23:39 <jrabbit> I believe thats the part thats failing
262 2010-12-02T22:24:00 <jrabbit> ThomasWaldmann: how can I "undo" a local hg commit?
263 2010-12-02T22:25:20 * ThomasWaldmann runs pytest with coverage installed
264 2010-12-02T22:25:33 <jrabbit> ThomasWaldmann: oh you think thats the issue?
265 2010-12-02T22:25:51 <ThomasWaldmann> jrabbit: if it is really still local and you did not push yet, hg rollback undos last commit
266 2010-12-02T22:26:03 <ThomasWaldmann> i try to reproduce it
267 2010-12-02T22:27:08 <jrabbit> it happens at the end of the testing.
268 2010-12-02T22:27:24 <dreimark> i am tinking about if we want a new transcluded items view
269 2010-12-02T22:28:02 <dreimark> so that we know where an item is transcluded
270 2010-12-02T22:29:28 <jrabbit> ThomasWaldmann: ok wrote a patch that explains that moinmoin needs 2.6+
271 2010-12-02T22:29:32 <dreimark> it should give a list where it is used
272 2010-12-02T22:29:42 <jrabbit> could you approve the task so I can submit it?
273 2010-12-02T22:30:51 <ThomasWaldmann> wait a sec until i reproduced the atexit thing
274 2010-12-02T22:31:21 <jrabbit> oh I was thinking that'd be what I looked at next but its related in terms of bad UX :)
275 2010-12-02T22:31:49 <ThomasWaldmann> i recently also had the json vs jsonlib problem. i tested pypy with moin and pypy is still at 2.5 level.
276 2010-12-02T22:32:03 <jrabbit> Heh :)
277 2010-12-02T22:32:56 <ThomasWaldmann> just the 2.6 check is almost too trivial, but wait, maybe we can have some nice mix
278 2010-12-02T22:33:37 <jrabbit> ThomasWaldmann: its not a 2.6 check... its a major UX failure
279 2010-12-02T22:34:13 <ThomasWaldmann> what did you do to get the atexit problem?
280 2010-12-02T22:34:26 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965405 (find a bug, fix a bug (difficulty: medium) 1/3)
281 2010-12-02T22:35:13 <jrabbit> ThomasWaldmann: ran my own py.test
282 2010-12-02T22:35:27 <jrabbit> PYTHONPATH="/sw/lib/python2.6/site-packages/" python2.6 /sw/bin/py.test-2.6
283 2010-12-02T22:35:36 <ThomasWaldmann> so it doesn't happen with the pytest we have in the top dir?
284 2010-12-02T22:35:42 <jrabbit> ThomasWaldmann: I don't know
285 2010-12-02T22:35:49 <ThomasWaldmann> well, try :)
286 2010-12-02T22:35:51 <jrabbit> ThomasWaldmann: yours is quite old
287 2010-12-02T22:35:59 <ThomasWaldmann> i don't care, it works
288 2010-12-02T22:36:02 <jrabbit> :P
289 2010-12-02T22:36:17 <ThomasWaldmann> (and it is newer than what most linux dists have)
290 2010-12-02T22:37:03 <jrabbit> ThomasWaldmann: this passes mroe tests...
291 2010-12-02T22:37:05 <jrabbit> thats bizzare.
292 2010-12-02T22:37:57 <jrabbit> ThomasWaldmann: I think pytest 2.0 picks up more errors or something odd.
293 2010-12-02T22:37:59 <ThomasWaldmann> maybe yours is a bit too new :D
294 2010-12-02T22:38:04 <jrabbit> i'll see if the error is generated.
295 2010-12-02T22:38:17 <jrabbit> once the test is over
296 2010-12-02T22:38:33 <jrabbit> and I don't have coverage
297 2010-12-02T22:39:50 <ThomasWaldmann> only coverage stuff uses atexit
298 2010-12-02T22:40:00 <jrabbit> ThomasWaldmann: yes but its wrapped in a try
299 2010-12-02T22:40:08 <jrabbit> but the except doesn't actually work.
300 2010-12-02T22:40:18 <jrabbit> or didn't
301 2010-12-02T22:40:28 <jrabbit> we'll see if it works in ye olde pytest :)
302 2010-12-02T22:40:44 <ThomasWaldmann> ?
303 2010-12-02T22:42:17 <jrabbit> the tests are still running
304 2010-12-02T22:43:47 <jrabbit> odd.
305 2010-12-02T22:43:55 <jrabbit> it does fail only with the newer pytest.
306 2010-12-02T22:46:28 <jrabbit> you should still except that error.
307 2010-12-02T22:46:36 <jrabbit> donno why the errors changed.
308 2010-12-02T22:47:16 <jrabbit> I'll add it to the except?
309 2010-12-02T22:48:26 <ThomasWaldmann> don't fix what aint broken
310 2010-12-02T22:48:57 <ThomasWaldmann> maybe it is py.test 2.0 because it is incompatible to 1.x
311 2010-12-02T22:48:58 <jrabbit> it is broken except for your special env
312 2010-12-02T22:49:08 <ThomasWaldmann> but as we don't use py.test 2.0 yet...
313 2010-12-02T22:49:24 <jrabbit> which isn't documented
314 2010-12-02T22:49:26 <jrabbit> (ironic)
315 2010-12-02T22:49:48 <ThomasWaldmann> ok, so what's left of your fixes?
316 2010-12-02T22:49:56 <ThomasWaldmann> json / simplejson
317 2010-12-02T22:50:10 <ThomasWaldmann> emitting a warning that < 2.6 is not really supported?
318 2010-12-02T22:50:14 <jrabbit> Yeah.
319 2010-12-02T22:50:48 <jrabbit> ThomasWaldmann: http://moinmo.in/Python3
320 2010-12-02T22:51:09 <jrabbit> what happened to that?
321 2010-12-02T22:51:54 <ThomasWaldmann> well, as flask already has the json fix, i would say do both and claim an easy bugfix for it
322 2010-12-02T22:52:35 <jrabbit> whoops I did medium not easy
323 2010-12-02T22:53:08 <ThomasWaldmann> i estimate that's not enough for medium
324 2010-12-02T22:53:22 <jrabbit> ThomasWaldmann: so you *do* want it to import simplejson on 2.5?
325 2010-12-02T22:53:24 <jrabbit> or error
326 2010-12-02T22:53:28 <jrabbit> Which is it?
327 2010-12-02T22:53:41 <ThomasWaldmann> search in flask for json
328 2010-12-02T22:53:45 <ThomasWaldmann> helpers.py
329 2010-12-02T22:53:48 <jrabbit> s/error/messsage the user
330 2010-12-02T22:53:56 <ThomasWaldmann> maybe we can just import json from there?
331 2010-12-02T22:54:04 <jrabbit> flask?
332 2010-12-02T22:54:15 <ThomasWaldmann> the framework we use
333 2010-12-02T22:55:37 <jrabbit> ThomasWaldmann: which python do you want
334 2010-12-02T22:55:44 <jrabbit> I need a clear answer.
335 2010-12-02T22:56:07 <ThomasWaldmann> moin2 requires >= 2.6 and < 3.0
336 2010-12-02T22:56:26 <ThomasWaldmann> but if you can make it work for pypy 1.4, that would be nice :)
337 2010-12-02T22:56:34 <jrabbit> lol
338 2010-12-02T22:57:03 <ThomasWaldmann> doing a warning and fixing json is a first step for that
339 2010-12-02T22:57:10 <jrabbit> ok :P
340 2010-12-02T22:57:22 <ThomasWaldmann> if you want to completely fix, we can talk about medium or hard
341 2010-12-02T22:58:44 <jrabbit> print """MoinMoin 2.0 suggests Python 2.6 or later to run."""
342 2010-12-02T22:58:48 <jrabbit> how about that?
343 2010-12-02T22:59:11 <jrabbit> -to run
344 2010-12-02T23:00:15 <ThomasWaldmann> "moin requires python >= 2.6 and < 3.0"
345 2010-12-02T23:04:40 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965167 (find a bug, fix a bug (difficulty: easy) 3/3)
346 2010-12-02T23:04:55 <jrabbit> ThomasWaldmann: sure.
347 2010-12-02T23:05:48 <jrabbit> print """MoinMoin 2.0 suggests Python 2.6 or greater but not Python 3."""
348 2010-12-02T23:06:01 <ThomasWaldmann> can you please put a comment and specify what you want to fix (in melange)
349 2010-12-02T23:06:24 <ThomasWaldmann> no, we require it, not suggest it
350 2010-12-02T23:06:47 <ThomasWaldmann> of course one is free to try less (like 2.5), but if it blows up, you own the pieces
351 2010-12-02T23:07:24 <jrabbit> ThomasWaldmann: but this explicitly allows for 2.5 :P
352 2010-12-02T23:07:34 <jrabbit> ThomasWaldmann: hence suggests.
353 2010-12-02T23:10:03 <ThomasWaldmann> no, we don't explicitely allow 2.5
354 2010-12-02T23:10:21 <jrabbit> ThomasWaldmann: the documentatino is a CF this is all they're gonna see.
355 2010-12-02T23:10:38 <ThomasWaldmann> ?
356 2010-12-02T23:10:46 <jrabbit> """MoinMoin 2.0 requires Python 2.6 or greater but not Python 3. Running on 2.5 is unsupported."""
357 2010-12-02T23:10:49 <jrabbit> therer.
358 2010-12-02T23:11:08 <ThomasWaldmann> that's redundant
359 2010-12-02T23:11:35 <ThomasWaldmann> because everything < 2.6 is unsupported
360 2010-12-02T23:11:44 <jrabbit> how abotu supports
361 2010-12-02T23:11:48 <jrabbit> requires is a bad word
362 2010-12-02T23:11:53 <jrabbit> it implies things you don't mean
363 2010-12-02T23:11:56 <ThomasWaldmann> why?
364 2010-12-02T23:12:02 <ThomasWaldmann> wut?
365 2010-12-02T23:12:07 <jrabbit> MoinMoin 2.0 supports Python 2.6 or greater but not Python 3.
366 2010-12-02T23:12:25 <jrabbit> ThomasWaldmann: because requires implies absoluteness
367 2010-12-02T23:12:37 <jrabbit> like "required by law"
368 2010-12-02T23:12:39 <ThomasWaldmann> it is meant like that
369 2010-12-02T23:12:56 <jrabbit> Except you want me to fix a 2.5 issue!~
370 2010-12-02T23:13:01 <ThomasWaldmann> of course we can't keep someone back from breaking that law
371 2010-12-02T23:13:02 <jrabbit> You can't have it both ways.
372 2010-12-02T23:13:16 <ThomasWaldmann> if he's lucky, it works, if not, it's not our fault
373 2010-12-02T23:13:25 <jrabbit> its bad enough the documenbtatino is wrong
374 2010-12-02T23:13:38 <ThomasWaldmann> what's wrong?
375 2010-12-02T23:13:51 <jrabbit> http://moinmo.in/Python3
376 2010-12-02T23:13:54 <jrabbit> ^WRONG
377 2010-12-02T23:14:40 <ThomasWaldmann> look again :)
378 2010-12-02T23:14:54 <jrabbit> :p
379 2010-12-02T23:15:04 <ThomasWaldmann> it was just planning, the requirements are stated in docs/REQUIREMENTS
380 2010-12-02T23:15:08 <jrabbit> anywho you support [2.6,3)
381 2010-12-02T23:15:14 <ThomasWaldmann> yes
382 2010-12-02T23:15:22 <jrabbit> this states just that.
383 2010-12-02T23:16:14 <ThomasWaldmann> most linux distributions' packages have something like requires: <list of software needed to run this package>
384 2010-12-02T23:16:28 <jrabbit> not ones i use
385 2010-12-02T23:16:40 <jrabbit> ThomasWaldmann: just use supprots
386 2010-12-02T23:16:46 <jrabbit> its neutral
387 2010-12-02T23:16:54 <ThomasWaldmann> i just wanted to point out that "requirements" is not something moin specific
388 2010-12-02T23:17:10 <ThomasWaldmann> everyone except you calls it like that :)
389 2010-12-02T23:17:11 <jrabbit> it doesn't explain the same thing effectively though
390 2010-12-02T23:17:18 <jrabbit> ThomasWaldmann: Debian doesn't
391 2010-12-02T23:18:35 <ThomasWaldmann> yeah, it calls it "depends"
392 2010-12-02T23:18:43 <ThomasWaldmann> but not suggest
393 2010-12-02T23:18:58 <jrabbit> suggests in a different field.
394 2010-12-02T23:19:05 <jrabbit> written in the same document
395 2010-12-02T23:19:09 <ThomasWaldmann> yes, and is not what we mean
396 2010-12-02T23:19:16 <ThomasWaldmann> can we end this topic?
397 2010-12-02T23:19:52 <jrabbit> ok but I'm not changing it to something that confuses more then it clairifies
398 2010-12-02T23:20:41 <ThomasWaldmann> and i won't accept something that I think is wrong :P
399 2010-12-02T23:20:52 * dreimark too
400 2010-12-02T23:21:01 <jrabbit> dreimark: ok you pick a word.
401 2010-12-02T23:21:10 <ThomasWaldmann> see above
402 2010-12-02T23:23:21 <ThomasWaldmann> the REQUIREMENTS file is in the top level dir, btw
403 2010-12-02T23:25:25 * dreimark likes the x201 its cover is still cold after 3h
404 2010-12-02T23:26:20 <ThomasWaldmann> that's how it should be for small notebooks with long battery life :)
405 2010-12-02T23:26:32 <dreimark> yeah
406 2010-12-02T23:27:18 <jrabbit> dreimark: pcik a word so we can fix better problems :)
407 2010-12-02T23:27:51 <jrabbit> ThomasWaldmann: oooh it could be like madlibs, put in a different word each time or randomly from a list :)
408 2010-12-02T23:29:03 <dreimark> you are sure you are not a bot or a energy beast. for both cases i don't feed you
409 2010-12-02T23:31:43 <jrabbit> dreimark: pick us a word :>
410 2010-12-02T23:35:12 <jrabbit> relating python and moin in a sentance
411 2010-12-02T23:38:02 <ThomasWaldmann> "moin requires python >= 2.6 and < 3.0"
412 2010-12-02T23:38:06 <m4k3r> ThomasWaldmann: lol, finally get an idea about how MoinMoin handles logins. Anyway, seems like you tried to provide an abstract inferface, but failed with all those usename/password variables/attributes.
413 2010-12-02T23:38:39 <jrabbit> ThomasWaldmann: I understnad what you're tryign to say I jsut want confirmatino that its jsut me
414 2010-12-02T23:39:08 <ThomasWaldmann> m4k3r: that stuff was only partially ported to moin2 yet. i left out all the openid rp and server stuff because I didn't want to test it.
415 2010-12-02T23:39:44 <m4k3r> ThomasWaldmann: so you left this dirty job to us.
416 2010-12-02T23:39:46 <m4k3r> :D
417 2010-12-02T23:40:02 <ThomasWaldmann> yeah :D
418 2010-12-02T23:40:10 <ThomasWaldmann> or just for later
419 2010-12-02T23:40:28 <ThomasWaldmann> it's not like openid is the most pressing thing we need to have
420 2010-12-02T23:40:59 <ThomasWaldmann> but we rather a stable core with basic functionality
421 2010-12-02T23:41:11 <jrabbit> ThomasWaldmann: ok I'll jsut go with yours fine
422 2010-12-02T23:41:44 <m4k3r> ThomasWaldmann: yeah, also ldap login is still to be completely integrated.
423 2010-12-02T23:41:57 <ThomasWaldmann> jrabbit: just a WARNING + continue
424 2010-12-02T23:42:05 <jrabbit> ThomasWaldmann: yeah
425 2010-12-02T23:44:13 * ThomasWaldmann updates pypy meanwhile :)
426 2010-12-02T23:44:28 <jrabbit> ok submitted
427 2010-12-02T23:48:18 <ThomasWaldmann> a) you don't really check the python version
428 2010-12-02T23:48:29 <ThomasWaldmann> py3 might have json, but will cause other trouble
429 2010-12-02T23:48:46 <jrabbit> ThomasWaldmann: 3k isn't the issue here
430 2010-12-02T23:49:05 <jrabbit> I can have it be a bit mroe helpfu lwhere it fails...
431 2010-12-02T23:49:06 <ThomasWaldmann> b) don't mention "2.0" as the moin version number, i don't want to updated that at multiple places
432 2010-12-02T23:49:10 <ThomasWaldmann> -d
433 2010-12-02T23:50:25 <ThomasWaldmann> also, you patch doesn't work. see how flask does it and either import it from there or do it in the same way.
434 2010-12-02T23:53:28 <jrabbit> ThomasWaldmann: what do you mean it doesn't work I've used it myself testin it on 2.5?
435 2010-12-02T23:53:47 *** nickr5
436 2010-12-02T23:54:57 <ThomasWaldmann> i doubt you tested the json stuff
437 2010-12-02T23:55:04 <jrabbit> oh whoops
438 2010-12-02T23:55:09 <jrabbit> i changed it from previously
439 2010-12-02T23:55:13 <jrabbit> it should be as json
440 2010-12-02T23:55:18 <ThomasWaldmann> sure :)
441 2010-12-02T23:55:56 <ThomasWaldmann> and please move that version check to MoinMoin/__init__.py and do a real version check
442 2010-12-02T23:56:01 <jrabbit> ok you want it to explain in that file that it can't be run on 3k?
443 2010-12-02T23:56:20 <ThomasWaldmann> you don't need to explain, just check version, early
444 2010-12-02T23:56:22 <jrabbit> ThomasWaldmann: I can do a real versino check there but you specifcally want it to run on 2.5
445 2010-12-02T23:56:43 <ThomasWaldmann> hm, right. wait.
446 2010-12-02T23:57:05 <jrabbit> I can just have it fail on sys.version_info.major == 3
447 2010-12-02T23:58:04 *** moin2
448 2010-12-02T23:58:44 <moin2> hello to the mentors: this is moin2, the implements wanted item view, i have resubmitted and requested for review
449 2010-12-02T23:59:31 <ThomasWaldmann> jrabbit: it is no problem, you just emit a warning, do not exit
450 2010-12-02T23:59:44 <ThomasWaldmann> if it blows up, user has been warned and knows why
451 2010-12-02T23:59:49 <ThomasWaldmann> if not, fine :)
