1 2010-12-25T00:21:56 <ThomasWaldmann> anthony__: want another easy (and less work) ro task?
2 2010-12-25T00:40:13 *** anthony__
3 2010-12-25T00:47:55 *** anthony__
4 2010-12-25T00:48:12 <anthony__> ThomasWaldmann: hey
5 2010-12-25T00:48:23 <anthony__> ThomasWaldmann: yes I want another task
6 2010-12-25T00:50:53 <anthony__> ThomasWaldmann: ping
7 2010-12-25T00:53:32 *** m4k3r
8 2010-12-25T01:02:14 <ThomasWaldmann> anthony__: hi. read news on melange. :)
9 2010-12-25T01:03:51 <ThomasWaldmann> ah, you've already done it. great. :)
10 2010-12-25T01:04:53 <ThomasWaldmann> anthony__: you need to submit something to melange, it doesn't let me close without submission
11 2010-12-25T01:12:01 *** m4k3r
12 2010-12-25T01:27:45 <ThomasWaldmann> anthony__: btw, you stull will be in moin 1.9.4 release (next release)
13 2010-12-25T01:28:05 <ThomasWaldmann> stuff* :)
14 2010-12-25T01:42:25 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5753:09e6d2748472 1.9/MoinMoin/i18n/ (43 files): updated i18n (includes updated ro translation, thanks to NicolaeAntonio, GCI 2010)
15 2010-12-25T01:42:31 <ThomasWaldmann> anthony__: ^^
16 2010-12-25T01:48:51 *** anthony__
17 2010-12-25T01:50:30 *** anthony__
18 2010-12-25T01:50:37 <anthony__> ThomasWaldmann: sorry
19 2010-12-25T01:50:40 * ThomasWaldmann is annoyed by rapidshare
20 2010-12-25T01:52:49 <anthony__> i submitted to melange
21 2010-12-25T01:52:55 <anthony__> ThomasWaldmann:
22 2010-12-25T02:00:37 <ThomasWaldmann> closed :)
23 2010-12-25T02:02:32 <anthony__> yhx
24 2010-12-25T02:02:35 <anthony__> thx
25 2010-12-25T02:02:39 <anthony__> ThomasWaldmann:
26 2010-12-25T02:02:48 <anthony__> now i wanna do the other
27 2010-12-25T02:05:07 <anthony__> or any translation in romanian or spanish
28 2010-12-25T02:05:22 <anthony__> or english
29 2010-12-25T02:05:25 <anthony__> :D
30 2010-12-25T02:05:28 <anthony__> ThomasWaldmann:
31 2010-12-25T02:06:18 <ThomasWaldmann> see the url i have given, read the task, claim it if you like
32 2010-12-25T02:06:25 <ThomasWaldmann> (on melange)
33 2010-12-25T02:06:27 <anthony__> i saw it
34 2010-12-25T02:06:30 <anthony__> commented it
35 2010-12-25T02:06:39 <anthony__> but cannot claim it
36 2010-12-25T02:07:07 <anthony__> because i don't know my CNP, and ZIP code to register as a student
37 2010-12-25T02:07:54 <ThomasWaldmann> well, i guess you need to register first
38 2010-12-25T02:08:01 <ThomasWaldmann> what's CNP?
39 2010-12-25T02:09:55 <ThomasWaldmann> and the ZIP code should be easy to find out (you know what it means?)
40 2010-12-25T02:11:23 <anthony__> numerical personal code
41 2010-12-25T02:11:30 <anthony__> no
42 2010-12-25T02:11:32 <anthony__> ...
43 2010-12-25T02:11:40 <anthony__> i have to ask my parents
44 2010-12-25T02:11:55 <anthony__> but i would like to start working
45 2010-12-25T02:12:01 <ThomasWaldmann> (parts of) cities usually have a number assigned to them
46 2010-12-25T02:12:09 <ThomasWaldmann> for postal delivery addresses
47 2010-12-25T02:12:14 <ThomasWaldmann> that's the zip code
48 2010-12-25T02:12:39 <anthony__> i'm from romania...i don't know how to find that
49 2010-12-25T02:12:46 <anthony__> my parents know it
50 2010-12-25T02:12:55 <ThomasWaldmann> so if you know your correct postal address, you know your zip code
51 2010-12-25T02:14:00 <anthony__> can i start working now
52 2010-12-25T02:14:06 <anthony__> and claim it tomorrow
53 2010-12-25T02:14:21 <ThomasWaldmann> yes, in that case you can
54 2010-12-25T02:14:57 <ThomasWaldmann> you formally don't have it though, but in this special case this is no problem, as we might have multiple of these tasks
55 2010-12-25T02:15:33 <anthony__> ok
56 2010-12-25T02:16:02 <anthony__> do you have any more romanian or spanish translation tasks?
57 2010-12-25T02:16:14 <anthony__> ThomasWaldmann:
58 2010-12-25T02:17:19 <ThomasWaldmann> http://master19.moinmo.in/MoinI18n/es that's the state of spanish
59 2010-12-25T02:17:42 <ThomasWaldmann> but for translating your should be a native speaker or have equivalent knowledge
60 2010-12-25T02:18:25 <anthony__> i have equivalent knowledge...i lived there for 5 months
61 2010-12-25T02:18:38 <anthony__> and is almost like romanian
62 2010-12-25T02:18:48 <anthony__> comes from latin
63 2010-12-25T02:19:40 <ThomasWaldmann> so you could write an article in spanish?
64 2010-12-25T02:19:41 <anthony__> what does #~ crap mean
65 2010-12-25T02:19:42 <anthony__> ?
66 2010-12-25T02:19:44 <anthony__> ThomasWaldmann:
67 2010-12-25T02:20:05 <ThomasWaldmann> it is unused stuff, usually located at the end of the po file
68 2010-12-25T02:20:20 <ThomasWaldmann> the lines begin with #~
69 2010-12-25T02:20:40 <anthony__> aham
70 2010-12-25T02:21:11 <anthony__> ok
71 2010-12-25T02:21:20 <anthony__> and what should i do about them
72 2010-12-25T02:21:28 <ThomasWaldmann> but maybe first finish ro :)
73 2010-12-25T02:21:38 <ThomasWaldmann> (you just remove them after it is complete)
74 2010-12-25T02:26:22 <anthony__> i would like to do the spanish translation first because it's easier
75 2010-12-25T02:26:38 <anthony__> ThomasWaldmann: is that ok?
76 2010-12-25T02:28:35 <anthony__> ThomasWaldmann: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129270131341
77 2010-12-25T02:31:12 <ThomasWaldmann> is what ok?
78 2010-12-25T02:31:28 <anthony__> said i would like to do the spanish translation first because it's easier
79 2010-12-25T02:31:59 <anthony__> ThomasWaldmann:
80 2010-12-25T02:32:29 <ThomasWaldmann> your choice
81 2010-12-25T02:33:09 <anthony__> ok
82 2010-12-25T02:33:45 <anthony__> ThomasWaldmann: can you please tell me where do I download the po file for spanish?
83 2010-12-25T02:34:32 <anthony__> ThomasWaldmann: because with romanian I struggled with copy/paste in notepad
84 2010-12-25T02:34:54 <ThomasWaldmann> (02:17) < ThomasWal> http://master19.moinmo.in/MoinI18n/es that's the state of spanish
85 2010-12-25T02:35:06 <anthony__> I know that
86 2010-12-25T02:35:14 <ThomasWaldmann> you can wget the raw url
87 2010-12-25T02:35:29 <anthony__> how do i do that
88 2010-12-25T02:35:32 <anthony__> linux?
89 2010-12-25T02:35:40 <anthony__> wget url
90 2010-12-25T02:35:49 <anthony__> ThomasWaldmann: or what
91 2010-12-25T02:35:59 <ThomasWaldmann> yes
92 2010-12-25T02:36:05 <anthony__> ok...
93 2010-12-25T02:36:15 <anthony__> but i dont have linux
94 2010-12-25T02:36:21 <anthony__> i have to ask a friend
95 2010-12-25T02:36:33 <ThomasWaldmann> you can use any dl program
96 2010-12-25T02:36:39 <ThomasWaldmann> including your browser
97 2010-12-25T02:36:56 <anthony__> just save the page?
98 2010-12-25T02:38:49 <ThomasWaldmann> the raw view
99 2010-12-25T02:39:33 <ThomasWaldmann> you can also choose "save" from the menu
100 2010-12-25T02:43:01 <anthony__> ok
101 2010-12-25T03:01:33 <anthony__> ThomasWaldmann: ping
102 2010-12-25T03:03:53 <ThomasWaldmann> remember what i said
103 2010-12-25T03:25:31 *** anthony__
104 2010-12-25T09:26:05 *** NikitaUtiu
105 2010-12-25T09:36:49 *** Samm
106 2010-12-25T09:52:02 *** rfw
107 2010-12-25T09:54:51 *** rfw
108 2010-12-25T09:54:51 *** rfw
109 2010-12-25T09:57:50 *** Samm
110 2010-12-25T10:10:20 *** Samm
111 2010-12-25T10:32:49 *** rfw
112 2010-12-25T10:39:09 *** Samm
113 2010-12-25T11:00:40 *** Samm
114 2010-12-25T11:15:25 *** m4k3r
115 2010-12-25T11:32:57 <xorAxAx> ThomasWaldmann: 6 seats in the hackcenter!
116 2010-12-25T11:33:09 <xorAxAx> thanks for applying
117 2010-12-25T11:33:53 <xorAxAx> cf. http://events.ccc.de/congress/2010/wiki/Floorplans
118 2010-12-25T11:34:10 <diofeher> good morning
119 2010-12-25T11:39:45 *** skylamer`
120 2010-12-25T11:46:23 <NikitaUtiu> i've finished with the +orphans , +wanteds and +backlink views, haven't written the unit tests yet https://bitbucket.org/NikitaUtiu/moin/changeset/fea6c14872a5
121 2010-12-25T11:55:35 <ronny> ThomasWaldmann: can i kill the buildin coverage test handling, or should i move it so pytest finds the options
122 2010-12-25T12:19:30 <ThomasWaldmann> xorAxAx: yup :)
123 2010-12-25T12:19:52 <ThomasWaldmann> maybe even 8, because it looks like 4 tables x 2 seats
124 2010-12-25T12:24:26 <ThomasWaldmann> ronny: need more details about that
125 2010-12-25T12:25:11 <ronny> ThomasWaldmann: pytest doesnt consider conftests in subdirs for cmdline parsing
126 2010-12-25T12:25:16 <ronny> bbl, food ready
127 2010-12-25T12:32:10 <ThomasWaldmann> NikitaUtiu: why do you use a set for refs_here?
128 2010-12-25T12:34:37 <NikitaUtiu> ThomasWaldmann: i don't actually know. i could've used a list just as well
129 2010-12-25T12:37:12 <NikitaUtiu> ThomasWaldmann: should i change it to a list?
130 2010-12-25T12:37:34 <ThomasWaldmann> yeah - and when you start thinking about having a sorted output, a list suddenly makes more sense :)
131 2010-12-25T12:39:15 <ThomasWaldmann> also, think about your set operations. they are semantically correct, but I think you can do it more easily.
132 2010-12-25T12:40:10 <NikitaUtiu> btw, how can i correct a commit with hg ?:D
133 2010-12-25T12:40:23 <ThomasWaldmann> usually you can't
134 2010-12-25T12:40:32 <NikitaUtiu> so, new commit ?
135 2010-12-25T12:40:34 <ThomasWaldmann> except if it is only local and the last one
136 2010-12-25T12:41:01 <ThomasWaldmann> but you can just do another commit with some respective comment. but let us first discuss the sets stuff.
137 2010-12-25T12:41:38 <ThomasWaldmann> what you do is l = set(links) ; t = set(transclusions); both = l.union(t)
138 2010-12-25T12:41:55 <NikitaUtiu> yes
139 2010-12-25T12:42:14 <ThomasWaldmann> how about both = set(links + transclusions) ?
140 2010-12-25T12:42:54 <NikitaUtiu> yes, it would be more readable
141 2010-12-25T12:43:56 <ThomasWaldmann> a little, yes, and maybe slightly more efficient, because you are only building one set, not three
142 2010-12-25T12:44:50 <NikitaUtiu> also, about what you said, should they be sorted ?
143 2010-12-25T12:45:07 *** m4k3r
144 2010-12-25T12:46:13 <ThomasWaldmann> NikitaUtiu: i guess it would look more pretty and be more usable, so yes
145 2010-12-25T12:46:35 <NikitaUtiu> and i'll change refs_here to a list
146 2010-12-25T12:49:52 <NikitaUtiu> are the others ok ?
147 2010-12-25T12:52:06 <ThomasWaldmann> templates need optimization
148 2010-12-25T12:52:36 <ThomasWaldmann> you made a new one, but isn't it same as orphans template?
149 2010-12-25T12:52:57 <NikitaUtiu> it kinda is
150 2010-12-25T12:53:05 <NikitaUtiu> yes, it is
151 2010-12-25T12:53:29 <ThomasWaldmann> see item_link_list
152 2010-12-25T12:53:58 <ThomasWaldmann> maybe we should have item_link_list_enumerated or so
153 2010-12-25T12:54:26 <ThomasWaldmann> and refer that from both orphans and what refers here
154 2010-12-25T12:54:34 <ThomasWaldmann> separate changeset for that one, please
155 2010-12-25T12:54:49 <ThomasWaldmann> "avoid template duplication"
156 2010-12-25T12:55:47 <NikitaUtiu> so different commits for the one about sorting and this one ?
157 2010-12-25T12:55:47 <ThomasWaldmann> (and hg rm the one you added in that changeset)
158 2010-12-25T12:55:52 <ThomasWaldmann> yes
159 2010-12-25T12:56:33 <NikitaUtiu> should i send them to you first or push them to my repo ?
160 2010-12-25T13:00:11 <ThomasWaldmann> if you have committed them already, you can also just push
161 2010-12-25T13:00:24 <ThomasWaldmann> try to do clean changesets :)
162 2010-12-25T13:00:32 <NikitaUtiu> clean ?
163 2010-12-25T13:01:09 <ThomasWaldmann> focus on some topic, only do changes related to that topic, do ALL changes relating to that topic
164 2010-12-25T13:02:04 <NikitaUtiu> oh, so not like the one before :D
165 2010-12-25T13:03:05 <ThomasWaldmann> and don't forget hg add for the new template
166 2010-12-25T13:03:15 <ThomasWaldmann> alternatively, you could also hg mv the existing one to the new name
167 2010-12-25T13:04:37 *** kennym
168 2010-12-25T13:05:01 <ThomasWaldmann> someone killed kenny :D
169 2010-12-25T13:05:32 <NikitaUtiu> ok, also, if i just use sorted, the list isn't sorted properly (alphanum)
170 2010-12-25T13:05:53 <NikitaUtiu> should i use alphanumerical sort or regular python sort?
171 2010-12-25T13:05:59 <ThomasWaldmann> what's not proper?
172 2010-12-25T13:06:18 <NikitaUtiu> eg. 'Home' < 'creole'
173 2010-12-25T13:07:15 <ThomasWaldmann> wanteds.html just uses | sort
174 2010-12-25T13:09:16 <NikitaUtiu> i was doing it in views.py, that was the problem
175 2010-12-25T13:13:52 <ThomasWaldmann> oh, they accepted the MoinMoin workshop at 27c3 :)
176 2010-12-25T13:14:06 <xorAxAx> wow :)
177 2010-12-25T13:14:13 <ThomasWaldmann> Day Day 1 2010-12-27
178 2010-12-25T13:14:15 <ThomasWaldmann> Start time 16:00:00
179 2010-12-25T13:14:22 <ThomasWaldmann> 3h
180 2010-12-25T13:14:43 <ThomasWaldmann> i guess I'll need some help :)
181 2010-12-25T13:23:55 *** skylamer`
182 2010-12-25T13:25:18 <NikitaUtiu> ThomasWaldmann: fixed them
183 2010-12-25T13:30:00 <ThomasWaldmann> http://events.ccc.de/congress/2010/wiki/MoinMoin
184 2010-12-25T13:34:32 <NikitaUtiu> bbl
185 2010-12-25T13:38:35 *** NikitaUtiu
186 2010-12-25T13:44:29 <ThomasWaldmann> ronny: do you know, can mercurial do a repo clone without old history?
187 2010-12-25T13:49:45 <ronny> ThomasWaldmann: currently not, the soc project failed with some detail semantics
188 2010-12-25T14:07:53 <ThomasWaldmann> do you know some way how changesets can be made that can be pulled into moin/2.0-dev without having a full clone of it?
189 2010-12-25T14:09:20 <ThomasWaldmann> ronny:
190 2010-12-25T14:10:27 <ronny> ThomasWaldmann: how do you mean that?
191 2010-12-25T14:17:35 <ThomasWaldmann> well, for 27c3 some people wanting to work on moin2 might be unprepared
192 2010-12-25T14:18:40 <ThomasWaldmann> and clone the repo takes a lot of time, esp. if you have high latency, slow throughput connection
193 2010-12-25T14:19:09 <ronny> ThomasWaldmann: usb stick with repo?
194 2010-12-25T14:19:19 <ThomasWaldmann> so, is there a better way to solve that than making a .tar.bz2 of a current clone/workdir?
195 2010-12-25T14:19:40 <ronny> a bundle of the complete history is the smallest thing
196 2010-12-25T14:19:48 <ronny> but a tarball with a correct hgrc would be nice
197 2010-12-25T14:20:06 <ronny> its helpfull to do hg up null before
198 2010-12-25T14:20:15 <ronny> (removes the workdir)
199 2010-12-25T14:20:25 <ronny> i'll bring a usb stick
200 2010-12-25T14:21:14 <ThomasWaldmann> the tar.bz2 is 224MB
201 2010-12-25T14:21:58 <ThomasWaldmann> i think having a workdir is nice, because you can just run the stuff, even without hg
202 2010-12-25T14:27:21 <ronny> wasnt it around 70 some time ago?
203 2010-12-25T14:37:19 <ThomasWaldmann> i guess that depends on the definition of "some time" :)
204 2010-12-25T14:40:03 <ronny> last congress or so
205 2010-12-25T14:40:31 <ronny> but that rather large growth seems to indicate weirdness
206 2010-12-25T14:40:35 <ronny> to me
207 2010-12-25T14:40:43 <ronny> ThomasWaldmann: so what to do about coverage?
208 2010-12-25T14:40:52 <ThomasWaldmann> it's because we have lots of 3rd party stuff in the repo
209 2010-12-25T14:41:58 <ThomasWaldmann> ronny: i am still unclear about the problem and your proposed solution
210 2010-12-25T14:42:49 <ronny> ThomasWaldmann: pytest doesnt take a look at MoinMoin/conftest till after being done with commandline parsing
211 2010-12-25T14:43:07 <ronny> so the commandline stuff for coverage doesnt get added
212 2010-12-25T14:43:15 <ronny> i'd prefer using the pytest coverage plugin
213 2010-12-25T14:43:44 <ronny> but you might want t keep that logic
214 2010-12-25T14:43:51 <ThomasWaldmann> does that work with that "pytest" way?
215 2010-12-25T14:44:26 <ronny> currently not
216 2010-12-25T14:44:47 <ronny> i suppose i'll make the logic accessible for now
217 2010-12-25T14:45:47 <ronny> later i'd like to wire up a ./pytest that contains pep8, coverage, xdist+execnet as basic plugin set
218 2010-12-25T14:52:10 <ThomasWaldmann> http://moinmo.in/27c3/WorkShop < xorAxAx ronny waldi please add ideas there
219 2010-12-25T14:52:23 <ThomasWaldmann> (see bottom of page)
220 2010-12-25T14:55:27 <ronny> added something insane :)
221 2010-12-25T14:55:37 <ronny> hmm
222 2010-12-25T14:56:06 <ronny> i need to steamline moins testing a bit, so it works with ./pytest and py.test 2.0
223 2010-12-25T14:57:07 <ronny> ThomasWaldmann: i noticed that most of the data in the moinmoin repo is actually i18n and that wiki subtree
224 2010-12-25T15:02:35 *** kennym
225 2010-12-25T15:07:15 <ThomasWaldmann> ronny: yes, but we can't do much about that without rewriting the repo, right?
226 2010-12-25T15:08:59 <ronny> yes
227 2010-12-25T15:09:07 <ronny> should be a later item
228 2010-12-25T15:09:22 <ronny> bbl
229 2010-12-25T15:10:21 <xorAxAx> ThomasWaldmann: clone via network?
230 2010-12-25T15:10:30 <xorAxAx> ThomasWaldmann: we will have a switch there
231 2010-12-25T15:13:09 <ThomasWaldmann> i put that archive on moinmo.in
232 2010-12-25T15:13:37 <ThomasWaldmann> i guess that should work ok, if the network (WLAN) works.
233 2010-12-25T15:13:50 <ThomasWaldmann> outbound bw is usually not a problem there
234 2010-12-25T15:15:38 <xorAxAx> yeah
235 2010-12-25T15:15:48 <xorAxAx> well, the wifi network is a problem
236 2010-12-25T15:15:55 <xorAxAx> but as i just said, we will have wired ethernet
237 2010-12-25T15:24:57 <ThomasWaldmann> ok, so what's suitable for the ws?
238 2010-12-25T15:25:12 <ThomasWaldmann> i thought about maybe beginning with my EP lightning talk
239 2010-12-25T15:25:39 <ThomasWaldmann> that is 5..10 minutes and maybe suitable as a quick intro into moin2
240 2010-12-25T15:25:58 <xorAxAx> makes sense
241 2010-12-25T15:26:04 <xorAxAx> i will think about it tomorrow a bit
242 2010-12-25T15:26:11 *** NikitaUtiu
243 2010-12-25T15:26:37 <ThomasWaldmann> then maybe browse through the code and comment on it?
244 2010-12-25T15:26:50 <ronny> ThomasWaldmann: btw, when will you arrive?
245 2010-12-25T15:29:26 <ThomasWaldmann> I'll leave from stuttgart at 08:51 tomorrow. trip is ~6h (hopefully).
246 2010-12-25T15:36:16 <kennym> hello
247 2010-12-25T15:37:06 <xorAxAx> ThomasWaldmann: dont you have DECT?
248 2010-12-25T15:37:20 <xorAxAx> at 27c3
249 2010-12-25T15:37:55 <ThomasWaldmann> I'll try to have GSM :)
250 2010-12-25T15:38:19 <xorAxAx> then preregister the gsm extension
251 2010-12-25T15:38:37 <ronny> bbl
252 2010-12-25T15:38:42 <xorAxAx> ThomasWaldmann:
253 2010-12-25T15:40:50 *** skylamer`
254 2010-12-25T15:41:38 <kennym> ThomasWaldmann: you can review my current work? https://km0r3@bitbucket.org/km0r3/moin-2.0-dev
255 2010-12-25T15:43:33 <kennym> *please
256 2010-12-25T15:49:55 <NikitaUtiu> ThomasWaldmann: about my changes. the code in apps/views.py isn't very unit testable as it is now. should i change it or those don't need tests ?
257 2010-12-25T15:51:33 <ThomasWaldmann> xorAxAx: 9386
258 2010-12-25T15:57:33 <kennym> ThomasWaldmann: are the multiple commits OK?
259 2010-12-25T15:57:40 <kennym> s/commits/changesets
260 2010-12-25T16:01:17 <ThomasWaldmann> NikitaUtiu: you did not remove the unused templates?
261 2010-12-25T16:02:21 <ThomasWaldmann> ehrm, ignore, you did. just didn't see it as bb is showing that differently.
262 2010-12-25T16:02:23 <NikitaUtiu> i removed the orphans and refs_here templates
263 2010-12-25T16:02:26 <NikitaUtiu> a ok
264 2010-12-25T16:03:16 <kennym> why are you guys ignoring me?
265 2010-12-25T16:03:53 * ThomasWaldmann is rather busy with 27c3 preparations, so please be patient
266 2010-12-25T16:04:44 <kennym> then that's OK
267 2010-12-25T16:04:47 <kennym> sorry
268 2010-12-25T16:10:39 <ThomasWaldmann> btw, you'll need some patience between now and 2010-12-31, because some of use will by at 27c3 congress
269 2010-12-25T16:10:46 <ThomasWaldmann> us*
270 2010-12-25T16:12:32 <kennym> and what will happen to my task?
271 2010-12-25T16:12:39 <kennym> I cannot wait until next year
272 2010-12-25T16:13:50 <ThomasWaldmann> don't panic (tm)
273 2010-12-25T16:14:08 <kennym> sorry
274 2010-12-25T16:14:14 <kennym> I will finish what I can, now
275 2010-12-25T16:14:28 <kennym> and will then ask you gently to take a quick look at it
276 2010-12-25T16:14:30 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10183:fea6c14872a5 2.0-dev/MoinMoin/ (3 files in 3 dirs):
277 2010-12-25T16:14:30 <CIA-56> Added ITEMTRANSCLUSIONS to +orphaned and +wanteds views
278 2010-12-25T16:14:30 <CIA-56> Implemented what refs here view and changed its name to +backrefs
279 2010-12-25T16:14:30 <CIA-56> Added a template for the what refers here view
280 2010-12-25T16:14:32 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10184:3143bd5a7589 2.0-dev/MoinMoin/apps/frontend/views.py: improved code readability in views.py
281 2010-12-25T16:14:34 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10185:b3e6b4be889c 2.0-dev/MoinMoin/ (4 files in 2 dirs): avoiding template duplication
282 2010-12-25T16:14:41 <kennym> you must have at least 5 minutes, I hope
283 2010-12-25T16:15:59 <ThomasWaldmann> NikitaUtiu: you only modified the sets code at one place
284 2010-12-25T16:16:12 <ThomasWaldmann> didn't you do it like that at some other places also?
285 2010-12-25T16:16:26 <NikitaUtiu> no
286 2010-12-25T16:18:09 <NikitaUtiu> should i ?
287 2010-12-25T16:18:10 <ThomasWaldmann> wanted_items?
288 2010-12-25T16:18:37 <ThomasWaldmann> same thing
289 2010-12-25T16:18:56 <NikitaUtiu> whoops, sorry
290 2010-12-25T16:21:44 <ThomasWaldmann> unit tests?
291 2010-12-25T16:22:43 <NikitaUtiu> that's what i was wondering about. it's not unit testable as it is now, i have to split it into functions
292 2010-12-25T16:24:15 <ThomasWaldmann> yup
293 2010-12-25T16:25:20 <NikitaUtiu> also, none of the views has unit tests, interesting
294 2010-12-25T16:26:25 <ThomasWaldmann> just extract the core to a function and test that. you don't need to test the template.
295 2010-12-25T16:26:42 <NikitaUtiu> or the flaskg, ok
296 2010-12-25T16:28:55 <kennym> ThomasWaldmann: is there someone I can ping when I need help?
297 2010-12-25T16:29:51 <ThomasWaldmann> i look at it right now
298 2010-12-25T16:34:21 <ThomasWaldmann> kennym: https://bitbucket.org/km0r3/moin-2.0-dev/changeset/0a3e0f77d832 why did you change base.html?
299 2010-12-25T16:35:12 <ThomasWaldmann> the diff.html change needs to be 1 string
300 2010-12-25T16:35:26 <ThomasWaldmann> with named placeholders
301 2010-12-25T16:35:57 <kennym> ThomasWaldmann: yes, one line
302 2010-12-25T16:36:46 <kennym> ThomasWaldmann: ok
303 2010-12-25T16:36:50 <ThomasWaldmann> in general, you could use placeholders and newstyle gettext much more often
304 2010-12-25T16:40:34 <ThomasWaldmann> https://bitbucket.org/km0r3/moin-2.0-dev/changeset/5786caff25a2
305 2010-12-25T16:40:52 <ThomasWaldmann> flash("mail recovery token not implemented yet") no need to translate that
306 2010-12-25T16:41:36 <ThomasWaldmann> https://bitbucket.org/km0r3/moin-2.0-dev/changeset/fadf855a4359
307 2010-12-25T16:41:44 <ThomasWaldmann> why did you change N_ to _?
308 2010-12-25T16:43:33 <ThomasWaldmann> https://bitbucket.org/km0r3/moin-2.0-dev/changeset/e79885660c8a
309 2010-12-25T16:43:52 <ThomasWaldmann> you must not remove translation from that ------- line
310 2010-12-25T16:44:05 <kennym> ThomasWaldmann: yes, I fixed that in a new commit
311 2010-12-25T16:44:18 <kennym> it's the latest one
312 2010-12-25T16:44:57 <ThomasWaldmann> ok
313 2010-12-25T16:45:12 <kennym> ThomasWaldmann: do I have to leave the N_ in the previous one?
314 2010-12-25T16:45:24 <ThomasWaldmann> do you have reason to change it?
315 2010-12-25T16:45:52 <kennym> My task was to check if ngettext was used appropiately
316 2010-12-25T16:46:00 <kennym> I don't see why we should use N_ there
317 2010-12-25T16:48:49 <ThomasWaldmann> https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/__init__.py#cl-28 you see there that N_ is NOT ngettext
318 2010-12-25T16:49:36 * ThomasWaldmann was also confused by that N_ stuff
319 2010-12-25T16:50:25 <kennym> ThomasWaldmann: thank you for telling me this!
320 2010-12-25T16:50:34 <kennym> I was about modify a lot
321 2010-12-25T16:52:15 <kennym> will fix that
322 2010-12-25T16:53:39 *** anthony__
323 2010-12-25T17:21:38 *** Samm_
324 2010-12-25T17:23:21 *** Samm
325 2010-12-25T17:30:58 *** Samm_
326 2010-12-25T18:00:24 <kennym> ThomasWaldmann: you think these have to i18nised? https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/items/__init__.py#cl-651
327 2010-12-25T18:00:28 <kennym> https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/items/__init__.py#cl-653
328 2010-12-25T18:06:41 <kennym> btw, do I have to find strings that have to be i18nised in the Python source?
329 2010-12-25T18:14:10 <kennym> Also, do the command-line scripts have to i18nised, too? They are located in MoinMoin/scripts . There are a lot of strings not i18nised
330 2010-12-25T18:14:16 <ThomasWaldmann> 651 yes, the user will see that
331 2010-12-25T18:14:27 <ThomasWaldmann> 653 same
332 2010-12-25T18:15:11 <ThomasWaldmann> kennym: no don't i18n commandline. this is admin stuff, admins know english.
333 2010-12-25T18:16:13 <kennym> ThomasWaldmann: will fix that
334 2010-12-25T18:16:16 <kennym> ThomasWaldmann: thanks
335 2010-12-25T18:37:44 <kennym> ThomasWaldmann: will the user see these one's too? https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/search/queryparser/__init__.py#cl-64
336 2010-12-25T18:38:04 <kennym> I guess so
337 2010-12-25T18:43:00 <ThomasWaldmann> yes
338 2010-12-25T18:44:21 <kennym> generally, when do I know when it needs to be i18nised?
339 2010-12-25T18:44:40 <kennym> I mean, when the file is called 'views.py' then it's obvious.
340 2010-12-25T18:58:38 <NikitaUtiu> ThomasWaldmann: do i disturb you ?
341 2010-12-25T18:59:45 <ThomasWaldmann> just ask, someone who has time will answer, sooner or later :)
342 2010-12-25T19:00:01 <NikitaUtiu> i have just finished implementing the unit tests
343 2010-12-25T19:00:35 <NikitaUtiu> is it good?
344 2010-12-25T19:06:58 <kennym> ThomasWaldmann: Generally all output will be visible to the user, in MoinMoin/storage/__init__.py, right?
345 2010-12-25T19:07:03 <kennym> https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/storage/__init__.py
346 2010-12-25T19:09:20 <NikitaUtiu> forgot the link https://bitbucket.org/NikitaUtiu/moin-2.0-dev
347 2010-12-25T19:10:17 <ThomasWaldmann> NikitaUtiu: check the _wanteds docstring
348 2010-12-25T19:11:17 *** Samm
349 2010-12-25T19:12:03 <NikitaUtiu> don't see any problem with it
350 2010-12-25T19:14:22 <ThomasWaldmann> return value is not a list?
351 2010-12-25T19:14:39 <ThomasWaldmann> https://bitbucket.org/NikitaUtiu/moin-2.0-dev/changeset/5e4e436b04a2#chg-MoinMoin/apps/frontend/_tests/test_frontend.py_newline202
352 2010-12-25T19:14:51 <ThomasWaldmann> you want to add a sorted() there
353 2010-12-25T19:15:13 <ThomasWaldmann> not needed right now, but if someone makes that list longer than one, it will be needed
354 2010-12-25T19:15:49 <NikitaUtiu> ok
355 2010-12-25T19:17:59 <ThomasWaldmann> kennym: the review is your task, if you want to know something specific, you need to ask more specific
356 2010-12-25T19:18:12 <kennym> ThomasWaldmann: ok
357 2010-12-25T19:18:43 <kennym> ThomasWaldmann: will this be visible to the user: https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/storage/__init__.py#cl-628 ?
358 2010-12-25T19:19:24 <kennym> ThomasWaldmann: in general, no i18n has been used in MoinMoin/storage
359 2010-12-25T19:23:15 <NikitaUtiu> is there anything else i should change ?
360 2010-12-25T19:23:23 <ThomasWaldmann> these 3 exception texts there don't need i18n, kennym
361 2010-12-25T19:23:38 <ThomasWaldmann> (in general, don't translate exception texts)
362 2010-12-25T19:24:03 <kennym> ThomasWaldmann: OK, thank you
363 2010-12-25T19:24:23 <ThomasWaldmann> NikitaUtiu: make sure you run all tests, check if yours and test_sourcecode works
364 2010-12-25T19:25:18 <kennym> ThomasWaldmann: MoinMoin/support look like third-party libraries. Do I have to i18n those?
365 2010-12-25T19:25:32 <kennym> I don't think that's my job
366 2010-12-25T19:26:33 <ThomasWaldmann> no, don't touch anything in support/
367 2010-12-25T19:27:17 <ThomasWaldmann> NikitaUtiu: also, give it a final practical test. but i think you're done then.
368 2010-12-25T19:28:18 <NikitaUtiu> i just need to run all the tests again to see if i haven't broken anything since i split the code
369 2010-12-25T19:34:13 <NikitaUtiu> it's good still 48
370 2010-12-25T19:36:16 <NikitaUtiu> pushed the docstring and sorted fix to the repo
371 2010-12-25T19:36:34 <NikitaUtiu> and it passes the tests
372 2010-12-25T19:42:04 <ThomasWaldmann> did you push all to bb already?
373 2010-12-25T19:42:14 <NikitaUtiu> yes
374 2010-12-25T19:43:23 <ThomasWaldmann> last change i see there is 6h ago
375 2010-12-25T19:43:37 <NikitaUtiu> now?
376 2010-12-25T19:44:13 <ThomasWaldmann> same
377 2010-12-25T19:44:30 <NikitaUtiu> that's strange
378 2010-12-25T19:44:36 <ThomasWaldmann> hg out
379 2010-12-25T19:44:39 <NikitaUtiu> https://bitbucket.org/NikitaUtiu/moin-2.0-dev/changeset/3174c93b5f01
380 2010-12-25T19:45:41 <ThomasWaldmann> oops, i used /moin
381 2010-12-25T19:46:24 <NikitaUtiu> that was a test, this one is forked from yours
382 2010-12-25T19:47:46 <kennym> ThomasWaldmann: can you please tell me if nesting in gettext calls for Jinja templates is allowed, like here: https://bitbucket.org/km0r3/moin-2.0-dev/src/6a47b7bfe7ef/MoinMoin/templates/modify_show_template_selection.html#cl-5
383 2010-12-25T19:49:13 <anthony__> ThomasWaldmann: hello
384 2010-12-25T19:49:15 <ThomasWaldmann> NikitaUtiu: you need to submit something or it doesn't let me close
385 2010-12-25T19:49:34 <NikitaUtiu> a, just a sec
386 2010-12-25T19:49:45 <anthony__> ThomasWaldmann: I finished the Spanish translation and claimed the task...
387 2010-12-25T19:49:47 *** Samm
388 2010-12-25T19:49:54 <anthony__> ThomasWaldmann: can you accept it?
389 2010-12-25T19:50:41 <ThomasWaldmann> anthony__: if you give urls, it works faster :)
390 2010-12-25T19:50:50 <NikitaUtiu> i submitted a link to my repo
391 2010-12-25T19:51:41 <anthony__> ThomasWaldmann: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129202088391
392 2010-12-25T19:52:04 <anthony__> ThomasWaldmann: and http://master19.moinmo.in/MoinI18n/es
393 2010-12-25T19:53:57 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10189:3174c93b5f01 2.0-dev/MoinMoin/apps/frontend/ (_tests/test_frontend.py views.py): fixed the _wanteds docstring and added sorted in _orphans
394 2010-12-25T19:53:57 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10187:e936f850c9e9 2.0-dev/MoinMoin/apps/frontend/views.py: split the code of +backrefs, +orphans and +wanteds views into unit testable chunks
395 2010-12-25T19:53:57 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10188:5e4e436b04a2 2.0-dev/MoinMoin/apps/frontend/ (_tests/test_frontend.py views.py): added unit tests for +backrefs, +wanteds and +orphans views
396 2010-12-25T19:53:57 <CIA-56> Nichita Utiu <nikita.utiu@gmail.com> default * 10186:c23afde80aa8 2.0-dev/MoinMoin/apps/frontend/views.py: optimized wanted_items code
397 2010-12-25T19:54:28 <ThomasWaldmann> anthony__: just running the i18n update script, hold on
398 2010-12-25T19:56:22 <NikitaUtiu> i gotta go
399 2010-12-25T19:56:22 <NikitaUtiu> bye
400 2010-12-25T20:00:18 <ThomasWaldmann> cu :)
401 2010-12-25T20:00:59 *** NikitaUtiu
402 2010-12-25T20:03:11 <ThomasWaldmann> kennym: use %(modifylink)s
403 2010-12-25T20:04:56 <kennym> ThomasWaldmann: where would I use that
404 2010-12-25T20:04:57 <kennym> ?
405 2010-12-25T20:06:18 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5754:e9866081fa75 1.9/MoinMoin/i18n/es.MoinMoin.po: updated i18n (includes updated es translation, thanks to NicolaeAntonio, GCI 2010)
406 2010-12-25T20:08:40 <ThomasWaldmann> anthony__: good work ^^ :)
407 2010-12-25T20:09:18 <kennym> ThomasWaldmann: you mean like this:
408 2010-12-25T20:09:42 <kennym> {{ _("You can either <a href='%(modifylink)s'>create the item from scratch</a> or select a template.", modifylink=url_for('frontend.modify_item', item_name=item_name, mimetype=mimetype, template='')|e) }}
409 2010-12-25T20:09:44 <kennym> ?
410 2010-12-25T20:10:57 <kennym> damn it, this looks like crap
411 2010-12-25T20:11:17 <ThomasWaldmann> kennym: yes, you could also use modifyhref instead of modifylink
412 2010-12-25T20:12:52 <kennym> ThomasWaldmann: yes, that sounds better
413 2010-12-25T20:13:19 <ThomasWaldmann> anthony__: you need to submit something to melange then, so i can close it.
414 2010-12-25T20:19:14 <anthony__> ThomasWaldmann: ok
415 2010-12-25T20:21:18 *** Samm
416 2010-12-25T20:22:07 <kennym> ThomasWaldmann: I just finished my second iteration (http://moinmo.in/KennyMeyer/Notes#Iteration_.232) and pushed the changes in a single changeset (https://bitbucket.org/km0r3/moin-2.0-dev/changeset/2d1e7a0151c1)
417 2010-12-25T20:22:26 <kennym> It contains all the corrections, and a little more
418 2010-12-25T20:22:44 <kennym> also found some things I didn't see during the first iteration
419 2010-12-25T20:23:12 <anthony__> ThomasWaldmann: subitted
420 2010-12-25T20:23:52 <anthony__> submitted*
421 2010-12-25T20:31:18 *** m4k3r
422 2010-12-25T20:31:21 <ronny> ThomasWaldmann: i added another idea
423 2010-12-25T20:33:26 <ronny> (workshop that is)
424 2010-12-25T20:36:44 <ThomasWaldmann> ronny: writing a backend is for sure too hard, but we can have a look into the concepts
425 2010-12-25T20:37:47 <ronny> ThomasWaldmann: what about that automagiv fontpage thing
426 2010-12-25T20:37:55 <kennym> please, have a look at it, soon. I want to write some code
427 2010-12-25T20:37:59 <ronny> another possibly interesting thing would be autogenerating menu
428 2010-12-25T20:38:26 <ronny> (i.e. all the stuff thats necessary to replace a clusterfuck cms like joomla)
429 2010-12-25T20:39:36 <ThomasWaldmann> i guess the idea needs more details
430 2010-12-25T20:42:39 <ThomasWaldmann> kennym: don't translate stuff you give to exception classes (like raise X(msg))
431 2010-12-25T20:42:58 <ThomasWaldmann> e.g. config/default.py line 83
432 2010-12-25T20:43:22 <ThomasWaldmann> (I already noted that before btw)
433 2010-12-25T20:43:34 <kennym> ThomasWaldmann: Oh, I am sorry
434 2010-12-25T20:43:37 <ThomasWaldmann> also items/__init__
435 2010-12-25T20:43:39 <kennym> any other issues?
436 2010-12-25T20:43:42 <kennym> ok
437 2010-12-25T20:45:28 <ThomasWaldmann> security/__init__ also
438 2010-12-25T20:47:46 <ThomasWaldmann> typo in modify_applet:
439 2010-12-25T20:47:46 <ThomasWaldmann> 3
440 2010-12-25T20:47:47 <ThomasWaldmann> <h1>{{ _("Modifying %(item_name)s", item_name= tem_name) }}</h1>
441 2010-12-25T20:48:18 *** Samm
442 2010-12-25T20:50:00 <kennym> good catch
443 2010-12-25T20:50:57 * ThomasWaldmann just reads the diff, you can do that, too :)
444 2010-12-25T20:51:43 *** Samm
445 2010-12-25T20:52:13 <kennym> believe me, I read the diff. I didn't see that one
446 2010-12-25T20:53:56 <ThomasWaldmann> ok :)
447 2010-12-25T20:56:27 *** skylamer`
448 2010-12-25T21:00:55 <ronny> ThomasWaldmann: fun fail, my sleeping place just went unsecure
449 2010-12-25T21:01:17 <ThomasWaldmann> uhoh, bad timing
450 2010-12-25T21:02:04 <ronny> yup, timing couldnt be much worse
451 2010-12-25T21:02:29 <ronny> managed to get a short term alternative, will have to ask around a bit
452 2010-12-25T21:06:41 <ronny> ThomasWaldmann: in which a&o are you guys staying again?
453 2010-12-25T21:09:11 <ThomasWaldmann> koepenicker
454 2010-12-25T21:11:10 <kennym> ThomasWaldmann: I can leave that? https://bitbucket.org/km0r3/moin-2.0-dev/changeset/2d1e7a0151c1#chg-MoinMoin/items/__init__.py_oldline651
455 2010-12-25T21:13:26 <ThomasWaldmann> yes, why are you asking?
456 2010-12-25T21:15:42 <kennym> Sorry, I just wanted to be sure
457 2010-12-25T21:27:51 <kennym> ThomasWaldmann: OK, all fixed. https://bitbucket.org/km0r3/moin-2.0-dev/changeset/c6389596cce9
458 2010-12-25T21:27:54 <kennym> thanks for your feedback
459 2010-12-25T21:45:21 *** Guest35100
460 2010-12-25T21:58:31 *** Guest35100
461 2010-12-25T21:58:31 *** Guest35100
462 2010-12-25T21:59:26 *** Guest35100
463 2010-12-25T22:00:50 <dreimark> re
464 2010-12-25T22:01:36 <dreimark> ThomasWaldmann: that is a bad short cut N_ if it is for lazy - to lazy readers
465 2010-12-25T22:01:42 * dreimark did the mistake too
466 2010-12-25T22:33:44 <kennym> hi dreimark
467 2010-12-25T22:38:16 * dreimark reads currently your changesets
468 2010-12-25T22:39:19 <kennym> dreimark: thanks
469 2010-12-25T22:39:24 <kennym> dreimark: can you approve the task?
470 2010-12-25T22:39:57 <kennym> *do you have the permission
471 2010-12-25T22:39:58 <kennym> s
472 2010-12-25T22:40:57 <dreimark> i have the permission, i am currently checking
473 2010-12-25T22:43:57 <dreimark> https://bitbucket.org/km0r3/moin-2.0-dev/changeset/2d1e7a0151c1#chg-MoinMoin/apps/admin/views.py_newline59
474 2010-12-25T22:44:07 <dreimark> isn't it user profile
475 2010-12-25T22:44:42 <dreimark> and the other question is why not User profile
476 2010-12-25T22:45:12 <dreimark> because we also write User Browser
477 2010-12-25T22:46:44 <dreimark> ThomasWaldmann: https://bitbucket.org/km0r3/moin-2.0-dev/changeset/2d1e7a0151c1#chg-MoinMoin/apps/feed/views.py_oldline66
478 2010-12-25T22:47:14 <dreimark> why was it u'....'
479 2010-12-25T22:47:32 <dreimark> or is that important
480 2010-12-25T22:51:14 <kennym> dreimark: is it possible to setup a local MoinMoin instance without Apache?
481 2010-12-25T22:51:36 <kennym> dreimark: so, I could discover the context
482 2010-12-25T22:52:29 <dreimark> kennym: just start ./moin
483 2010-12-25T22:52:42 <dreimark> we have a builtin webserver
484 2010-12-25T22:53:26 <dreimark> kennym: some of the sentences don't start with an upper case letter.
485 2010-12-25T22:54:02 <kennym> dreimark: thanks, very cool!
486 2010-12-25T22:54:27 <kennym> dreimark: for example?
487 2010-12-25T22:55:00 <dreimark> kennym: 22:43 < dreimark> https:
488 2010-12-25T23:02:35 <kennym> dreimark: fixed, and pushed https://bitbucket.org/km0r3/moin-2.0-dev/changeset/c5afc3032063
489 2010-12-25T23:05:58 <dreimark> kennym: where ever a username or item name is used it must be type unicode
490 2010-12-25T23:08:09 <kennym> dreimark: item name?
491 2010-12-25T23:08:36 <dreimark> kennym: in the past this was attachment or page, now we have only mimetypes
492 2010-12-25T23:09:04 <dreimark> different mimetype for items
493 2010-12-25T23:09:30 *** Samm
494 2010-12-25T23:09:40 <kennym> so,
495 2010-12-25T23:10:01 <kennym> + return _(u"User profile of %(username)s: %(email)r", username=user_name,
496 2010-12-25T23:12:30 <dreimark> yes
497 2010-12-25T23:12:56 <dreimark> please search for username or user_name
498 2010-12-25T23:13:19 <dreimark> kennym: https://bitbucket.org/km0r3/moin-2.0-dev/src/c5afc3032063/MoinMoin/apps/admin/templates/index.html
499 2010-12-25T23:13:25 <dreimark> <h1>Admin Menu</h1>
500 2010-12-25T23:14:22 <kennym> dreimark: argh, good catch
501 2010-12-25T23:18:05 <ThomasWaldmann> kennym: maybe checkk all h1
502 2010-12-25T23:20:22 <kennym> OK
503 2010-12-25T23:20:45 <kennym> dreimark: I could only that user_name/username
504 2010-12-25T23:20:50 <kennym> *find
505 2010-12-25T23:21:43 <dreimark> item / item_name is may be the other one.
506 2010-12-25T23:22:06 <dreimark> if we can catch some easily now they should be fixed
507 2010-12-25T23:27:21 <dreimark> kennym: search for <strong>
508 2010-12-25T23:27:27 <dreimark> e.g.
509 2010-12-25T23:27:37 <dreimark> <strong>NOTE:</strong> You need a Java enabled browser to edit the drawing.
510 2010-12-25T23:28:20 <kennym> templates/modify_anywikidraw.html
511 2010-12-25T23:28:29 <kennym> thanks
512 2010-12-25T23:28:34 <dreimark> and in twikidraw
513 2010-12-25T23:28:51 <dreimark> but there it is
514 2010-12-25T23:33:09 <kennym> ah, found another one
515 2010-12-25T23:36:39 <kennym> dreimark: has this to be passed as unicode: https://bitbucket.org/km0r3/moin-2.0-dev/src/2d1e7a0151c1/MoinMoin/items/__init__.py#cl-661
516 2010-12-25T23:36:40 <kennym> ?
517 2010-12-25T23:37:55 <dreimark> kennym: no, there is no mimetype which needs a unicode
518 2010-12-25T23:38:09 <kennym> ok
519 2010-12-25T23:38:31 <dreimark> it is only if there can be some user input data
520 2010-12-25T23:38:35 <dreimark> which needs it
521 2010-12-25T23:38:50 <dreimark> e.g. an item can be Änderungen
522 2010-12-25T23:39:05 <dreimark> or a username can have a ß
523 2010-12-25T23:39:30 <dreimark> or some signs i can't type on that keyboard
524 2010-12-25T23:39:38 <dreimark> s/signs/chars/
525 2010-12-25T23:39:52 <kennym> yeah, but if I don't detect some of them now, can't they be easily fixed later on?
526 2010-12-25T23:40:16 <dreimark> easily not, the strings must be reviewed
527 2010-12-25T23:40:31 <dreimark> at the time the po files are created one can do
528 2010-12-25T23:43:59 <kennym> ok
529 2010-12-25T23:44:07 <kennym> so what exactly is left to complete this task?
530 2010-12-25T23:44:24 <dreimark> do you have done the <h1> review ?
531 2010-12-25T23:44:26 <kennym> btw, I documented most of what I did here: http://moinmo.in/KennyMeyer/Notes
532 2010-12-25T23:45:06 <kennym> dreimark: yes, everywhere where there are html files
533 2010-12-25T23:45:13 <kennym> except of _tests/ folder
534 2010-12-25T23:45:20 <kennym> s/folder/folders
535 2010-12-25T23:45:31 <kennym> they had some templates too
536 2010-12-25T23:49:32 <dreimark> i am not finished with checking of some tags
537 2010-12-25T23:49:41 <dreimark> so far it looks good
538 2010-12-25T23:53:38 <kennym> review is far much eye-friendlier than a diff in the terminal, at least with Mercurial. I miss the syntax highlighting
539 2010-12-25T23:55:24 <dreimark> kennym: hg serve
540 2010-12-25T23:55:38 <dreimark> and pygments installed
