MoinMoin: MoinMoinChat/Logs/moin-dev/2011-01-16

   1 2011-01-16T00:03:19  * ThomasWaldmann works in index-rebuild, load-xml, save-xml as flask-script commands
   2 2011-01-16T00:34:07  <ThomasWaldmann> waldi: https://bitbucket.org/RogerHaase/moin-2.0-dev please review incoming changesets, esp. the dom related changes
   3 2011-01-16T00:38:58  *** maker has quit IRC
   4 2011-01-16T01:05:12  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10279:0a69a18648b1 2.0-dev/MoinMoin/conftest.py: fix before_wiki() call in conftest
   5 2011-01-16T01:09:08  *** Guiiks_ has quit IRC
   6 2011-01-16T02:06:26  *** grzywa has quit IRC
   7 2011-01-16T02:06:45  *** grzywa has joined #moin-dev
   8 2011-01-16T02:08:16  *** grzywa is now known as grzywacz
   9 2011-01-16T02:08:25  *** grzywacz has quit IRC
  10 2011-01-16T02:08:25  *** grzywacz has joined #moin-dev
  11 2011-01-16T02:09:02  *** TripleEntendre has quit IRC
  12 2011-01-16T02:29:32  *** izibi has joined #moin-dev
  13 2011-01-16T02:31:49  *** izibi_ has quit IRC
  14 2011-01-16T03:11:29  *** izibi has quit IRC
  15 2011-01-16T03:24:10  *** Matt has joined #moin-dev
  16 2011-01-16T03:24:36  *** Matt is now known as Guest71214
  17 2011-01-16T04:41:12  *** Guest71214 has quit IRC
  18 2011-01-16T04:47:30  *** Matt has joined #moin-dev
  19 2011-01-16T04:47:57  *** Matt is now known as Guest65474
  20 2011-01-16T05:08:07  *** Guest65474 has quit IRC
  21 2011-01-16T06:15:52  *** pvinogradov1 has quit IRC
  22 2011-01-16T07:38:12  *** kursor has joined #moin-dev
  23 2011-01-16T08:33:46  *** izibi has joined #moin-dev
  24 2011-01-16T08:46:49  *** izibi_ has joined #moin-dev
  25 2011-01-16T08:50:17  *** izibi has quit IRC
  26 2011-01-16T09:12:54  *** izibi_ is now known as izibi
  27 2011-01-16T09:20:33  *** NikitaUtiu has joined #moin-dev
  28 2011-01-16T11:38:47  <ThomasWaldmann> moin
  29 2011-01-16T12:11:53  <ThomasWaldmann> ronny: the changesets incoming from your repo, shall that stuff be merged? is it finished and non-disrupting?
  30 2011-01-16T12:13:28  *** greg_f has joined #moin-dev
  31 2011-01-16T12:16:00  <ThomasWaldmann> izibi: btw, there is an issue with the timers and the tests
  32 2011-01-16T12:17:10  <ThomasWaldmann> if one runs the tests, it crashes in after_wiki() because it has no flaskg.clock somehow!?
  33 2011-01-16T12:20:33  <ThomasWaldmann> NikitaUtiu: hi, we should talk about openid / your changesets today
  34 2011-01-16T12:21:05  <NikitaUtiu> ok, but a little later, i'm doing some homework now
  35 2011-01-16T12:21:14  <ThomasWaldmann> ok
  36 2011-01-16T12:26:25  *** kursor has quit IRC
  37 2011-01-16T13:09:31  <ronny> ThomasWaldmann: not finished, there is still much breakage on pytest2 due to the weird setupstate
  38 2011-01-16T13:09:44  <ronny> ThomasWaldmann: i'll tell you when its ready
  39 2011-01-16T13:31:56  *** maker has joined #moin-dev
  40 2011-01-16T14:38:13  *** maker is now known as m4k3r
  41 2011-01-16T14:38:24  *** m4k3r is now known as maker
  42 2011-01-16T14:39:47  *** maker has quit IRC
  43 2011-01-16T14:40:14  *** m4k3r has joined #moin-dev
  44 2011-01-16T14:43:00  <NikitaUtiu> moin
  45 2011-01-16T14:43:05  <NikitaUtiu> ThomasWaldmann: we can discuss now
  46 2011-01-16T15:04:21  *** m4k3r has quit IRC
  47 2011-01-16T15:48:09  *** m4k3r has joined #moin-dev
  48 2011-01-16T15:48:59  *** m4k3r has joined #moin-dev
  49 2011-01-16T15:53:11  <ThomasWaldmann> re
  50 2011-01-16T15:53:17  <ThomasWaldmann> NikitaUtiu: still there?
  51 2011-01-16T15:53:23  <NikitaUtiu> yep
  52 2011-01-16T15:54:07  <ThomasWaldmann> ok, one thing i was wondering about: does openid work with the main repo code right now? i does not have the HTTPException patch.
  53 2011-01-16T15:55:12  <ThomasWaldmann> it*
  54 2011-01-16T15:55:58  <NikitaUtiu> well my working dir is synchronised with the main repo and it works quite well
  55 2011-01-16T15:56:46  <ThomasWaldmann> didn't you need a working redirect from the auth stuff?
  56 2011-01-16T16:01:46  <NikitaUtiu> well not if it was a html response not redirect
  57 2011-01-16T16:02:15  <ThomasWaldmann> ok, so we don't need the patch any more?
  58 2011-01-16T16:02:49  <NikitaUtiu> oh, we need in case the oid server is set to return redirects
  59 2011-01-16T16:04:42  <ThomasWaldmann> do you have any oid server needing that to test it?
  60 2011-01-16T16:06:52  <NikitaUtiu> i can test it anyway, the server returns both html and redirect but tells you which to use afterwards
  61 2011-01-16T16:08:50  <ThomasWaldmann> ok, please do so, so i can add the patch (if needed) or not :)
  62 2011-01-16T16:12:32  <NikitaUtiu> ThomasWaldmann:  does not work
  63 2011-01-16T16:12:49  <NikitaUtiu> that's what it's supposed to do
  64 2011-01-16T16:13:11  <ThomasWaldmann> ok, so wait a sec, i add the patch, then you can do same test again after merging
  65 2011-01-16T16:14:58  <NikitaUtiu> ok
  66 2011-01-16T16:18:05  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10280:b2e3d265ecf1 2.0-dev/MoinMoin/__init__.py: add HTTPException handler around setup_user(), add try/finally to stop clock
  67 2011-01-16T16:18:37  <ThomasWaldmann> NikitaUtiu: ^^
  68 2011-01-16T16:23:00  <NikitaUtiu> ThomasWaldmann: works
  69 2011-01-16T16:23:59  <ThomasWaldmann> great :)
  70 2011-01-16T16:24:29  <ThomasWaldmann> ok, so now about your other changes: do you think they are in a good state for merging?
  71 2011-01-16T16:28:14  <NikitaUtiu> the trusted providers stuff?
  72 2011-01-16T16:30:41  <ThomasWaldmann> all outgoing stuff from your repo to main repo
  73 2011-01-16T16:31:35  <NikitaUtiu> oh, not yet
  74 2011-01-16T16:31:52  <NikitaUtiu> i still have to make the account creation stuff
  75 2011-01-16T16:34:28  <ThomasWaldmann> hmm, it's not so much the question whether openid stuff is "feature complete"
  76 2011-01-16T16:35:07  <ThomasWaldmann> rather whether the existing stuff in your repo is finished
  77 2011-01-16T16:35:46  <NikitaUtiu> well it's not finished yet
  78 2011-01-16T16:37:32  <ThomasWaldmann> ok
  79 2011-01-16T16:37:42  <ThomasWaldmann> some changesets look a bit confusing btw
  80 2011-01-16T16:37:57  <ThomasWaldmann> https://bitbucket.org/NikitaUtiu/moin-2.0-dev/changeset/90a44f210f37
  81 2011-01-16T16:38:03  <ThomasWaldmann> https://bitbucket.org/NikitaUtiu/moin-2.0-dev/changeset/45855b6002e3
  82 2011-01-16T16:38:11  <ThomasWaldmann> https://bitbucket.org/NikitaUtiu/moin-2.0-dev/changeset/8692d35b9031
  83 2011-01-16T16:38:24  <NikitaUtiu> ?
  84 2011-01-16T16:39:10  <ThomasWaldmann> you did x, reverted x, applied x again?
  85 2011-01-16T16:39:29  <NikitaUtiu> well i saw that code and thought it would fail if used in wsgi unless i wrapped it in a response and added the mimetype
  86 2011-01-16T16:40:22  <NikitaUtiu> well screwed stuff up a little, i reverted it by mistake
  87 2011-01-16T16:41:58  <ThomasWaldmann> ok
  88 2011-01-16T16:43:13  <ThomasWaldmann> btw, you need to still push the merge you just did to your bb repo, right?
  89 2011-01-16T16:43:58  <NikitaUtiu> yes
  90 2011-01-16T16:47:15  <ThomasWaldmann> btw, that auto_oid_trusted, could that just be a kw args to OpenIDAuth()?
  91 2011-01-16T16:47:25  <ThomasWaldmann> auth*
  92 2011-01-16T16:47:42  * ThomasWaldmann refers to snippet
  93 2011-01-16T16:54:16  <NikitaUtiu> ThomasWaldmann:  yes, and that's how fserv was used in 1.9
  94 2011-01-16T16:54:37  <NikitaUtiu> but dreimark referred to it as config entry in the task description
  95 2011-01-16T16:58:06  <ThomasWaldmann> all ldap stuff also used to be separate config entries in the past
  96 2011-01-16T16:58:34  <ThomasWaldmann> the problem is that this is not very modular and default config grows more and more by doing that
  97 2011-01-16T16:59:32  <ThomasWaldmann> but if stuff is more OO, this modularizes it in a nice way (and we have those auth classes anyway, so why not give them their params as usual for class instantiation?)
  98 2011-01-16T16:59:51  <ThomasWaldmann> see how ldap auth looks like currently
  99 2011-01-16T17:00:31  <NikitaUtiu> yep, that's true, it'll look nicer if i did so
 100 2011-01-16T17:29:56  *** Matt has joined #moin-dev
 101 2011-01-16T17:30:22  *** Matt is now known as Guest21818
 102 2011-01-16T17:55:24  *** greg_f has quit IRC
 103 2011-01-16T18:13:47  <NikitaUtiu> ThomasWaldmann: modified and pushed it to bb :)
 104 2011-01-16T18:36:49  *** m4k3r has quit IRC
 105 2011-01-16T18:37:51  *** Guest21818 has quit IRC
 106 2011-01-16T18:58:34  * ThomasWaldmann looks
 107 2011-01-16T19:01:01  <ThomasWaldmann> NikitaUtiu: you should use wikiconfig_local.py for debugging
 108 2011-01-16T19:01:28  <NikitaUtiu> where is that ?
 109 2011-01-16T19:01:29  <ThomasWaldmann> (see the comment at the end of wikiconfig.py)
 110 2011-01-16T19:01:40  <ThomasWaldmann> toplevel dir
 111 2011-01-16T19:02:33  <ThomasWaldmann> and be careful with lists as default params
 112 2011-01-16T19:02:51  <ThomasWaldmann> (no problem as long as noone modifies them, though)
 113 2011-01-16T19:03:15  <ThomasWaldmann> (same for any other mutable type)
 114 2011-01-16T19:09:10  <NikitaUtiu> so is it good like this or some other thing?
 115 2011-01-16T19:09:39  <NikitaUtiu> tuple?
 116 2011-01-16T19:11:55  <ThomasWaldmann> as long as noone modifies it, it is ok.
 117 2011-01-16T19:19:09  <NikitaUtiu> what if self._trusted_providers=list(trusted_providers)
 118 2011-01-16T19:19:32  <NikitaUtiu> ThomasWaldmann:  ^?
 119 2011-01-16T19:20:20  <ThomasWaldmann> yes, that's a bit safer as it creates a copy
 120 2011-01-16T19:32:31  <ThomasWaldmann> NikitaUtiu: if server in trusted or len(trusted) == 0:
 121 2011-01-16T19:33:00  <NikitaUtiu> the list is empty trust all
 122 2011-01-16T19:33:06  <ThomasWaldmann> if not trusted or server in trusted:
 123 2011-01-16T19:33:46  <ThomasWaldmann> also, is it really a "server" or rather a url?
 124 2011-01-16T19:34:05  * ThomasWaldmann was asking himself how to get those urls for that list
 125 2011-01-16T19:34:29  <NikitaUtiu> well
 126 2011-01-16T19:34:46  <NikitaUtiu> i got it from some forum page on google
 127 2011-01-16T20:03:52  <NikitaUtiu> i htg
 128 2011-01-16T20:03:54  <NikitaUtiu> bye
 129 2011-01-16T20:04:01  *** NikitaUtiu has quit IRC
 130 2011-01-16T21:05:10  <dreimark> moin
 131 2011-01-16T21:08:30  <ThomasWaldmann> wb dreimark
 132 2011-01-16T21:12:52  <dreimark> I think we should have a bot on #moin which can be used to tell lines of wikiconfig
 133 2011-01-16T21:15:36  <dreimark> ThomasWaldmann: i think the openid stuff should also work if we don't enable moin auth
 134 2011-01-16T21:15:49  <dreimark> (only open id)
 135 2011-01-16T21:24:50  <ThomasWaldmann> yes
 136 2011-01-16T21:49:18  *** Matt has joined #moin-dev
 137 2011-01-16T21:49:44  *** Matt is now known as Guest53310
 138 2011-01-16T22:07:06  *** franklin has joined #moin-dev
 139 2011-01-16T22:11:11  *** m4k3r has joined #moin-dev
 140 2011-01-16T22:17:04  * ThomasWaldmann tries to fix the timers with tests
 141 2011-01-16T22:25:58  *** m4k3r has quit IRC
 142 2011-01-16T22:41:59  *** Guest53310 is now known as TripleEntendre
 143 2011-01-16T22:53:42  *** TripleEntendre has quit IRC
 144 2011-01-16T23:38:58  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10281:e97cad8ad39e 2.0-dev/MoinMoin/ (__init__.py conftest.py): tests: make sure after_wiki() is called, add debug logging to before/after_wiki()
 145 2011-01-16T23:39:00  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10282:31a61675fe63 2.0-dev/MoinMoin/__init__.py: tests: avoid exceptions if after_wiki() is called twice