1 2011-05-18T00:31:50 <RogerHaase> ThomasWaldmann: I updated my BB repo and sent you an email from BB . I had another hg "learning experience" with my first merge on Ubuntu.
2 2011-05-18T00:37:19 <RogerHaase> ThomasWaldmann: I found one place where +modify is used: http://test.moinmo.in/mylogo. If you mouseover the "log.." part of the create it message, the overlay link appears.
3 2011-05-18T00:39:27 <ThomasWaldmann> but the overlay link does not link to +modify
4 2011-05-18T00:41:49 <ThomasWaldmann> RogerHaase: hg on ubuntu should be quite similar to hg on windows, no?
5 2011-05-18T00:41:54 <RogerHaase> right, but if you click on the overlay, it links to a page with the same message...that links to +modify.
6 2011-05-18T00:42:40 <ThomasWaldmann> the msg links to +modify there, yes, but no overlay there
7 2011-05-18T00:43:06 <ThomasWaldmann> (and that's good like that)
8 2011-05-18T00:45:08 <RogerHaase> But not so good with my change to make the overlay appear when you mouseover any part of the object.
9 2011-05-18T00:45:47 <RogerHaase> Before I never saw the overlay, now with my change I see it always (on mouseover)
10 2011-05-18T00:48:06 <RogerHaase> I claim the overlay on http://test.moinmo.in/mylogo does not make any sense, it only allows you to end up on the same page, but it takes one more click to get there.
11 2011-05-18T00:48:47 <RogerHaase> Why create a long route?
12 2011-05-18T00:53:29 *** sinha
13 2011-05-18T00:54:42 <RogerHaase> hg line commands on Ubuntu are similar to windows. TortoiseHG seems really flaky on Ubuntu. I have problems with the right-click menu being inconsistent - commands are sometimes different.
14 2011-05-18T00:54:57 <ThomasWaldmann> the initial idea about overlay was to offer a link (because otherwise you would not have one, like for transcluded images)
15 2011-05-18T00:55:16 <ThomasWaldmann> it doesn't make much sense if you are already on the item's page
16 2011-05-18T00:55:35 <ThomasWaldmann> but due to the way the item view is generated, the overlay comes there also
17 2011-05-18T00:56:02 <ThomasWaldmann> because viewing an item is just looking at the moin theme that shows a transclusion of that item as only content.
18 2011-05-18T00:57:34 <RogerHaase> Right, we need the link for transcluded items, but not if you are on the itempage already, and (now) not if you have already have a link.
19 2011-05-18T00:59:09 <RogerHaase> I must break for dinner, will discuss more tomorrow.
20 2011-05-18T01:00:36 <ThomasWaldmann> ok, have a nice dinner :)
21 2011-05-18T01:03:20 *** RogerHaase
22 2011-05-18T01:33:43 *** grzywacz
23 2011-05-18T03:40:33 *** MattMaker
24 2011-05-18T04:40:17 *** Marchael
25 2011-05-18T05:11:00 *** RogerHaase
26 2011-05-18T05:19:13 *** Marchael
27 2011-05-18T05:23:40 *** RogerHaase
28 2011-05-18T06:05:39 *** Marchael
29 2011-05-18T06:10:42 *** franklin_
30 2011-05-18T06:13:33 *** franklin_
31 2011-05-18T06:34:21 *** Marchael
32 2011-05-18T06:57:23 *** Marchael
33 2011-05-18T07:43:25 <Marchael> moin
34 2011-05-18T08:47:27 <dreimark> moin
35 2011-05-18T08:57:43 *** Marchael
36 2011-05-18T09:23:49 *** ronny
37 2011-05-18T09:42:24 <ThomasWaldmann> moin
38 2011-05-18T09:43:02 *** ronny
39 2011-05-18T10:08:57 *** ronny
40 2011-05-18T10:17:29 *** ronny
41 2011-05-18T11:00:10 *** Marchael
42 2011-05-18T11:58:20 <dreimark> moin
43 2011-05-18T11:58:32 * dreimark has to drive to Wuppertal to a meeting today
44 2011-05-18T12:27:14 *** greg_f
45 2011-05-18T12:44:10 *** pkumar
46 2011-05-18T14:26:19 *** andialbrecht_
47 2011-05-18T14:44:52 *** hardy_89
48 2011-05-18T14:47:15 <pkumar> hardy_89: http://etherpad.osuosl.org/moin2-unittest
49 2011-05-18T15:04:32 <pkumar> Is it the time?
50 2011-05-18T15:04:55 <pkumar> ThomasWaldmann: ^
51 2011-05-18T15:05:09 <xorAxAx> moin
52 2011-05-18T15:05:17 <xorAxAx> yeah, meeting time
53 2011-05-18T15:05:22 <xorAxAx> waldi: are you with us?
54 2011-05-18T15:05:24 <waldi> moin :/
55 2011-05-18T15:07:36 <xorAxAx> why ":/"?
56 2011-05-18T15:08:51 <xorAxAx> pkumar: how did you choose the packages that you want to extend tests in?
57 2011-05-18T15:10:07 <pkumar> Actually those were the modules mentioned in my application
58 2011-05-18T15:10:37 <pkumar> so, ThomasWaldmann suggested me to write my name before them
59 2011-05-18T15:10:41 <pkumar> for the time being
60 2011-05-18T15:10:49 <pkumar> in EP
61 2011-05-18T15:11:44 <xorAxAx> yeah
62 2011-05-18T15:11:51 <pkumar> need to be changed for hardy_89
63 2011-05-18T15:11:59 <xorAxAx> still no hardy_89 with us?
64 2011-05-18T15:12:07 <pkumar> he is
65 2011-05-18T15:12:19 <hardy_89> xorAxAx: here
66 2011-05-18T15:12:22 <hardy_89> :)
67 2011-05-18T15:12:29 <waldi> ah, there he is
68 2011-05-18T15:12:36 <xorAxAx> hardy_89: so can you extend the EP?
69 2011-05-18T15:13:02 <pkumar> I have specified the file sizes for the ease of work division
70 2011-05-18T15:13:19 <pkumar> may be a rough idea
71 2011-05-18T15:13:32 <hardy_89> xorAxAx: i can ammend it cos we are supposed to divide the work as instructed by Thomas
72 2011-05-18T15:13:40 <hardy_89> waldi: hi
73 2011-05-18T15:14:16 <hardy_89> xorAxAx: we already have a rough idea of the road map as already discussed by me and pkumar
74 2011-05-18T15:14:25 <hardy_89> xorAxAx: the division part is left
75 2011-05-18T15:14:33 <hardy_89> and the coding ofc
76 2011-05-18T15:14:47 <xorAxAx> ofc?
77 2011-05-18T15:15:07 <hardy_89> xorAxAx: of course :)
78 2011-05-18T15:15:35 <hardy_89> xorAxAx: yeah one thing.
79 2011-05-18T15:15:36 <pkumar> there are four bigger modules and rest all are smaller ones
80 2011-05-18T15:15:52 <pkumar> also we have 3 issues
81 2011-05-18T15:16:06 <hardy_89> xorAxAx: i'd like to add the bug listing thing in the first porting phase also
82 2011-05-18T15:16:16 <hardy_89> pkumar: ^
83 2011-05-18T15:16:19 <xorAxAx> hardy_89: what do you mean by that?
84 2011-05-18T15:16:56 <hardy_89> pkumar, xorAxAx : cos we're likely to come across issues even while porting which needed to be taken care off
85 2011-05-18T15:17:05 <hardy_89> *needs
86 2011-05-18T15:17:17 <xorAxAx> what is the "the bug listing thing"?
87 2011-05-18T15:18:07 <pkumar> Actually, it can be ported with issues, too
88 2011-05-18T15:18:09 <hardy_89> xorAxAx: that will be like a list of issues that we face while porting tests, which will later be corrected during Bug Week
89 2011-05-18T15:18:33 <xorAxAx> cant that list simply go in the main bugtracker for moin 2.0?
90 2011-05-18T15:18:48 <pkumar> one idea is may be new pytest can help us in fixing issues till an extent
91 2011-05-18T15:19:07 <hardy_89> pkumar: but having a list of what all unnecessary we have to be fixed will be helpful
92 2011-05-18T15:19:44 <pkumar> it may change with the change in the code i.e. after porting
93 2011-05-18T15:20:10 <pkumar> or some may be fixed too since pytest is an improved version
94 2011-05-18T15:20:47 <pkumar> well, I'm just saying an idea
95 2011-05-18T15:20:54 <pkumar> hardy_89: ^
96 2011-05-18T15:21:02 <hardy_89> pkumar: since the tests are being written for the second time, lets try to make it kinda full proof, is my point :)
97 2011-05-18T15:21:32 <hardy_89> so that it is not carried on to GSoC 2012
98 2011-05-18T15:22:28 <pkumar> there may be different plans but in course of action we should not be working on same task again
99 2011-05-18T15:23:26 <hardy_89> pkumar: so the only thing is, whatsoever problem we face while porting
100 2011-05-18T15:23:33 <pkumar> like bug fixing after porting
101 2011-05-18T15:23:42 <hardy_89> pkumar: having a simple txt file of them would be handy
102 2011-05-18T15:23:59 <xorAxAx> a txt file of what? bug reports?
103 2011-05-18T15:24:03 <hardy_89> pkumar: yeah right.
104 2011-05-18T15:24:30 <hardy_89> xorAxAx: a txt file of any trivial to major issues while porting
105 2011-05-18T15:25:17 <xorAxAx> why not use the bugtracker of moin!??!?
106 2011-05-18T15:25:24 <hardy_89> cos we have dedicated week for bug fixing after porting.
107 2011-05-18T15:25:44 <xorAxAx> i dont understand
108 2011-05-18T15:25:49 <hardy_89> pkumar: -->xorAxAx: why not use the bugtracker of moin!??!?
109 2011-05-18T15:26:03 <xorAxAx> you can use it nevertheless
110 2011-05-18T15:26:09 <pkumar> hardy_89: So, do you want port first and fix all the issues and bugs or fix bugs then port
111 2011-05-18T15:26:11 <hardy_89> xorAxAx: yes we can
112 2011-05-18T15:26:27 <hardy_89> pkumar: the former
113 2011-05-18T15:26:54 <hardy_89> pkumar: the way it is right now in EP
114 2011-05-18T15:26:55 <pkumar> okay
115 2011-05-18T15:28:21 <pkumar> xorAxAx: what do you say of the plan in EP
116 2011-05-18T15:28:42 <pkumar> does it need some modifications?
117 2011-05-18T15:29:10 <pkumar> waldi: ^
118 2011-05-18T15:29:31 <xorAxAx> why does it end on june 15?
119 2011-05-18T15:29:36 <hardy_89> yes, before dividing work, kindly making changes, if any.
120 2011-05-18T15:30:08 <hardy_89> xorAxAx: not anymore
121 2011-05-18T15:30:25 <xorAxAx> why does it end on june 13?
122 2011-05-18T15:30:38 <xorAxAx> and not later
123 2011-05-18T15:30:40 <waldi> i miss one central point: the overhaul of the test setup
124 2011-05-18T15:31:04 <pkumar> can we shorten the porting period so that we get more time for fixing bugs?
125 2011-05-18T15:31:14 <pkumar> hardy_89: ^
126 2011-05-18T15:31:23 <hardy_89> pkumar: have made few changes
127 2011-05-18T15:31:26 <hardy_89> pkumar: pls2check
128 2011-05-18T15:31:39 <pkumar> yeah
129 2011-05-18T15:32:07 <xorAxAx> why does nobody answer my question?
130 2011-05-18T15:32:23 <pkumar> we need to add more tasks for further dates
131 2011-05-18T15:32:26 <hardy_89> xorAxAx: thats the quarter term eval date.
132 2011-05-18T15:32:47 <hardy_89> xand this is doable in this much time.
133 2011-05-18T15:32:49 <xorAxAx> ok, so you think you succeed in such a short timespan with the tasks
134 2011-05-18T15:33:13 <xorAxAx> so now about waldis comment
135 2011-05-18T15:33:28 <xorAxAx> where is the test setup overhauled, memory issues fixed, etc.?
136 2011-05-18T15:34:05 <pkumar> June 1- June 9
137 2011-05-18T15:34:12 <pkumar> fixing issues
138 2011-05-18T15:34:34 <waldi> this is no issue. this is a task
139 2011-05-18T15:34:53 <waldi> it needs a concept and the implementation
140 2011-05-18T15:34:59 <xorAxAx> furthermore, you want to add a new task about writing new tests
141 2011-05-18T15:35:37 <waldi> pkumar: and I doubt that this is not solveable within one week
142 2011-05-18T15:36:21 <pkumar> Thats why we have two weeks for bugs and issues
143 2011-05-18T15:36:32 <hardy_89> xorAxAx: tests which are to be written are given in the Module list.
144 2011-05-18T15:37:07 <xorAxAx> hardy_89: indeed
145 2011-05-18T15:37:21 <pkumar> As I was planning to go with my plan in application in http://moinmo.in/pkumar_pytest-2
146 2011-05-18T15:37:28 <hardy_89> pkumar: does this porting time also includes the time for writing new tests?
147 2011-05-18T15:37:35 <xorAxAx> so you want to improve the test coverage and port tests in one single week?
148 2011-05-18T15:37:49 <pkumar> no
149 2011-05-18T15:38:07 <pkumar> Porting means just porting the current tests
150 2011-05-18T15:38:14 <hardy_89> xorAxAx: test coverage will take time. Porting,Yes.
151 2011-05-18T15:38:27 <pkumar> more tests need to be added
152 2011-05-18T15:38:29 <pkumar> http://moinmo.in/pkumar_pytest-2
153 2011-05-18T15:38:41 <xorAxAx> then add a new task for writing new tests
154 2011-05-18T15:39:59 <pkumar> not only for that, other new tasks like framework improvements also need to be added
155 2011-05-18T15:40:11 <xorAxAx> yes, please do so
156 2011-05-18T15:40:57 <hardy_89> xorAxAx: but adding new test is not included in the time span of 13 june.
157 2011-05-18T15:42:00 <pkumar> we need to add those in further dates
158 2011-05-18T15:42:53 <hardy_89> pkumar: we can add it in the task to be done on EP though
159 2011-05-18T15:43:04 <pkumar> yeah
160 2011-05-18T15:45:26 <xorAxAx> ok, should happen today
161 2011-05-18T15:45:36 <xorAxAx> waldi and i will respond on the EP then
162 2011-05-18T15:46:40 <pkumar> okay
163 2011-05-18T15:47:31 *** Marchael
164 2011-05-18T16:00:43 <ThomasWaldmann> re
165 2011-05-18T16:01:15 <ThomasWaldmann> welcome to our 2nd weekly meeting
166 2011-05-18T16:01:27 <ThomasWaldmann> please give a short lifesign if you are there
167 2011-05-18T16:01:44 <xorAxAx> moo
168 2011-05-18T16:02:47 * dreimark is currently here
169 2011-05-18T16:02:59 <dreimark> but sinha is missing
170 2011-05-18T16:03:31 <hardy_89> ThomasWaldmann: here.
171 2011-05-18T16:03:47 <hardy_89> ThomasWaldmann: and so is pkumar who is busy editing on EP
172 2011-05-18T16:03:48 <hardy_89> :)
173 2011-05-18T16:04:27 <pkumar> hey
174 2011-05-18T16:04:53 <ThomasWaldmann> ok, i didn't follow as i was away - did you finish talking about testing stuff?
175 2011-05-18T16:04:59 <hardy_89> ThomasWaldmann: http://etherpad.osuosl.org/moin2-unittest
176 2011-05-18T16:05:51 <pkumar> yeah, we have made few improvements
177 2011-05-18T16:06:00 <ThomasWaldmann> ok, looks like work has started there, finally
178 2011-05-18T16:06:10 <ThomasWaldmann> now just do the "need to" :)
179 2011-05-18T16:06:11 <pkumar> yeah :)
180 2011-05-18T16:06:47 <ThomasWaldmann> hardy_89: you were missed in the last weeks
181 2011-05-18T16:07:15 <hardy_89> ThomasWaldmann: i have my exams going in parallel
182 2011-05-18T16:07:21 <ThomasWaldmann> sinha not here
183 2011-05-18T16:07:31 <ThomasWaldmann> Marchael not here
184 2011-05-18T16:07:45 <ThomasWaldmann> we need to train meetings more
185 2011-05-18T16:08:12 <ThomasWaldmann> any questions especially for me about testing=
186 2011-05-18T16:08:14 <ThomasWaldmann> ?
187 2011-05-18T16:08:52 <pkumar> ThomasWaldmann: Your suggestion about http://etherpad.osuosl.org/moin2-unittest
188 2011-05-18T16:09:12 <ThomasWaldmann> you need to ask more precisely
189 2011-05-18T16:10:05 <hardy_89> ThomasWaldmann: anything that you would like to add/change in timeline till June 13.
190 2011-05-18T16:10:33 <ThomasWaldmann> (in general I can only recommend to have a deeper look at the current testing framework (conftest.py) and the tests, then it should get more clear why they need improvement)
191 2011-05-18T16:11:16 <ThomasWaldmann> yes, the "need to"
192 2011-05-18T16:11:30 <ThomasWaldmann> also, i only see PK, no hardy_89
193 2011-05-18T16:11:40 <ThomasWaldmann> (== HA)
194 2011-05-18T16:11:46 <pkumar> I ran coverage(-C) on tests and many areas need to be improved
195 2011-05-18T16:11:52 <pkumar> and tested as well
196 2011-05-18T16:12:02 <hardy_89> ThomasWaldmann: well, thats just a list of modules
197 2011-05-18T16:12:13 <hardy_89> ThomasWaldmann: division of work is yet to be don
198 2011-05-18T16:12:15 <hardy_89> +e
199 2011-05-18T16:12:28 <ThomasWaldmann> yeah, do it :)
200 2011-05-18T16:13:35 <dreimark> only 5 days left
201 2011-05-18T16:14:11 <dreimark> hardy_89: until next 2h done?
202 2011-05-18T16:14:31 <hardy_89> dreimark: yes
203 2011-05-18T16:14:45 <dreimark> pkumar: hardy_89 if you discuss the project please do it in this channel or in the pad
204 2011-05-18T16:14:53 <pkumar> okay
205 2011-05-18T16:14:58 <hardy_89> all right
206 2011-05-18T16:15:46 * dreimark prefers it here because we can follow too while we not always stay in the ep
207 2011-05-18T16:16:34 <ThomasWaldmann> (or just announce working on the pad, so we know when you're active there)
208 2011-05-18T16:19:48 * dreimark has to go
209 2011-05-18T16:20:11 <dreimark> ThomasWaldmann: can you please talk with sinha, if he joins in
210 2011-05-18T16:20:25 <dreimark> bbl
211 2011-05-18T16:34:52 <ThomasWaldmann> well, if he misses the time, it's not your fault
212 2011-05-18T16:39:48 <hardy_89> ThomasWaldmann: like i did the prev time. #shameful
213 2011-05-18T16:40:29 <pkumar> on EP
214 2011-05-18T16:42:37 <pkumar> xorAxAx: ^
215 2011-05-18T16:42:43 <pkumar> waldi: ^
216 2011-05-18T16:47:27 <ThomasWaldmann> xorAxAx: waldi: can you please care a bit more if your students have questions?
217 2011-05-18T16:47:44 <xorAxAx> sure
218 2011-05-18T16:48:18 <ThomasWaldmann> hardy_89: pkumar: can you involve your mentors more and ask specific questions?
219 2011-05-18T16:48:43 *** m4k3r
220 2011-05-18T16:49:28 <xorAxAx> "Work on deciding and finalizing new testing framework and Test Coverage."
221 2011-05-18T16:49:42 <xorAxAx> i dont understand the latter part - how is test coverage related to that, hardy_89?
222 2011-05-18T16:50:33 * ThomasWaldmann needs to do other stuff now.
223 2011-05-18T16:52:03 <hardy_89> xorAxAx: we have just mentioned it
224 2011-05-18T16:52:14 <hardy_89> xorAxAx: we won't work on it
225 2011-05-18T16:52:39 <hardy_89> xorAxAx: work plan of job in hand till June 13 is ready
226 2011-05-18T16:52:51 <hardy_89> ThomasWaldmann: yeah. we did today.
227 2011-05-18T16:55:51 *** Marchael
228 2011-05-18T16:56:58 *** hardy_89
229 2011-05-18T17:09:06 *** pkumar
230 2011-05-18T17:10:33 *** gwork
231 2011-05-18T17:27:25 *** andialbrecht
232 2011-05-18T17:54:13 *** grzywacz
233 2011-05-18T17:57:38 *** ronny
234 2011-05-18T18:03:16 <ThomasWaldmann> waldi: xorAxAx: see ep chat
235 2011-05-18T18:41:33 *** Marchael
236 2011-05-18T18:49:57 *** ronny
237 2011-05-18T19:13:07 *** Marchael
238 2011-05-18T19:18:45 <dreimark> re
239 2011-05-18T19:29:51 *** Marchael
240 2011-05-18T19:52:27 *** sinha
241 2011-05-18T20:00:21 <ThomasWaldmann> hi sinha
242 2011-05-18T20:00:42 <sinha> ThomasWaldmann: hi
243 2011-05-18T20:00:46 <ThomasWaldmann> you missed todays meeting
244 2011-05-18T20:01:15 <sinha> yeah sorry i completely forgot
245 2011-05-18T20:01:22 <ThomasWaldmann> do you have some device that can alert you each week about it?
246 2011-05-18T20:01:41 <sinha> i will remeber it from next time
247 2011-05-18T20:01:50 <sinha> s/remeber/remember
248 2011-05-18T20:02:06 <ThomasWaldmann> dreimark: ^^
249 2011-05-18T20:03:28 *** Marchael
250 2011-05-18T20:12:03 <ThomasWaldmann> sinha: your etherpad has 0 changes since a week?
251 2011-05-18T20:12:16 *** greg_f
252 2011-05-18T20:15:13 <sinha> yes working on it, had a very busy week, i will definitely do changes there soon
253 2011-05-18T20:16:11 <ThomasWaldmann> 3weeks gone, 1 left
254 2011-05-18T20:16:24 *** Marchael
255 2011-05-18T20:24:22 *** ronny
256 2011-05-18T20:24:49 *** ronny
257 2011-05-18T20:32:23 <sinha> ThomasWaldmann: http://hg.moinmo.in/moin/2.0/file/bac248bcf98c/MoinMoin/storage/backends/indexing.py#l411 what does this query.offset do ? does it limit the number of query results, as similar in mysql for limit x,y
258 2011-05-18T20:32:56 <sinha> and when this start variable is going to have something ? because from the interface there is no option to set it
259 2011-05-18T20:39:15 <ThomasWaldmann> it is the start offset, one can also give the end - to get a part of history
260 2011-05-18T20:40:59 <sinha> start offset for the fetched results, i.e. if number of results is 20 and start is 5 and end is 15 so we will see 10 results from 5-15 ? right ?
261 2011-05-18T20:44:58 *** RogerHaase
262 2011-05-18T20:46:00 <sinha> ThomasWaldmann: ^^
263 2011-05-18T20:49:34 <ThomasWaldmann> 10 or 11, yes
264 2011-05-18T20:52:20 <sinha> ThomansWaldmann: so if i pass the value for start and end variable at this line http://hg.moinmo.in/moin/2.0/file/bac248bcf98c/MoinMoin/apps/frontend/views.py#l592 then the history results must get filtered out ?
265 2011-05-18T20:54:33 <ThomasWaldmann> try it :)
266 2011-05-18T20:57:26 <dreimark> hi sinha
267 2011-05-18T20:57:49 <sinha> dreimark: hi
268 2011-05-18T20:58:52 <sinha> In global history view, i wanted to reconsider the idea of grouping by month, lets show them grouped by date and add filter option for results like show only save/delete/new
269 2011-05-18T20:58:58 <sinha> dreimark: what say
270 2011-05-18T20:59:47 <dreimark> why not rename and destroyed?
271 2011-05-18T20:59:50 <dreimark> sinha: ^
272 2011-05-18T20:59:57 <sinha> dreimark: yes all of them
273 2011-05-18T21:00:08 <sinha> i was just giving the idea
274 2011-05-18T21:00:14 <dreimark> know now
275 2011-05-18T21:00:32 <dreimark> sounds ok to me
276 2011-05-18T21:00:50 <sinha> dreimark: and i will handle these grouping by day in the template file itself
277 2011-05-18T21:00:52 <dreimark> but also somethimes the old 1 | 2 | 3 | 7 | 14 | 30 | 60 | 90
278 2011-05-18T21:01:14 <dreimark> was good, because it depends on the amount of entries per item
279 2011-05-18T21:01:30 <sinha> yes filter option like, from this month and this year
280 2011-05-18T21:01:37 <dreimark> ok
281 2011-05-18T21:01:42 <sinha> and will keep pagination for each kind of query
282 2011-05-18T21:01:57 <dreimark> good
283 2011-05-18T21:02:12 <dreimark> it should be possible as option to set the amount of lines
284 2011-05-18T21:02:55 <dreimark> so one can e.g. use it to get no pagination or just 10 lines more if there are not so much content
285 2011-05-18T21:02:56 <sinha> yes somewhere on page itself like show 10,20 results per page
286 2011-05-18T21:03:17 <dreimark> yet it needs mostly done in the template
287 2011-05-18T21:03:21 <dreimark> +be
288 2011-05-18T21:04:11 <dreimark> may be some code is better placed in the RecentChanges code
289 2011-05-18T21:04:23 <sinha> this limiting in results could be done in backend file not in template, there is option for start and end for each query results
290 2011-05-18T21:04:43 <dreimark> because we have to take care also that templates can be used to style moin now
291 2011-05-18T21:05:16 <dreimark> sure, don't fetch all data and filter then is to expensive
292 2011-05-18T21:05:27 <sinha> we can use the template for grouping by day on moin1.9
293 2011-05-18T21:05:33 <dreimark> try to filter using the database functions
294 2011-05-18T21:05:39 <sinha> yes ofcourse
295 2011-05-18T21:08:15 <dreimark> sinha: please add details to the pad, I am switching meanwhile my computers
296 2011-05-18T21:08:17 <dreimark> brb
297 2011-05-18T21:09:58 <ThomasWaldmann> sinha: you need also the moin 1.9 algorithm
298 2011-05-18T21:10:27 <ThomasWaldmann> optionally a simple algo, for people who think the other one is not correct
299 2011-05-18T21:11:19 <sinha> ThomasWaldmann: algo for the view part ?
300 2011-05-18T21:12:10 <ThomasWaldmann> look how this wiki shows recentchanges and compare with moin 2
301 2011-05-18T21:12:32 <ThomasWaldmann> esp if you are logged in and have a bookmark set
302 2011-05-18T21:12:37 <sinha> ThomasWaldmann: ah yes
303 2011-05-18T21:12:54 <sinha> yes i was going to ask reg bookmark functionality in moin2
304 2011-05-18T21:13:33 <sinha> i see the bookmark function in implemented there in the file
305 2011-05-18T21:13:36 <sinha> s/in/is
306 2011-05-18T21:13:49 <sinha> but i guess it is not been used from the frontend
307 2011-05-18T21:13:56 <ThomasWaldmann> yes
308 2011-05-18T21:14:05 <ThomasWaldmann> you see, lots to do :)
309 2011-05-18T21:16:27 <sinha> okay in the history function, i can retrieve the bookmark time from flaskg.user.getBookmark() function, and insert the bookmark time as condition for the query ?
310 2011-05-18T21:17:16 <sinha> and where is the function implemented for flaskg ?
311 2011-05-18T21:17:25 <sinha> i am not seeing it in any file
312 2011-05-18T21:26:01 <ThomasWaldmann> flaskg == flask.g
313 2011-05-18T21:29:59 <dreimark> re
314 2011-05-18T21:31:52 <dreimark> we have on various places from flask import g as flaskg
315 2011-05-18T21:32:20 <sinha> yes i know that, but where are those functions implemented of flask.g
316 2011-05-18T21:33:03 <dreimark> it is a library in your env
317 2011-05-18T21:33:52 <dreimark> e.g. env/lib/python2.6/site-packages/flask/
318 2011-05-18T21:36:11 <sinha> okay, then the functions setBookmark() and delBookmark() is implemented there ? or they are defined somehwere else
319 2011-05-18T21:37:26 <dreimark> user.setBookmark()
320 2011-05-18T21:38:05 <dreimark> http://hg.moinmo.in/moin/2.0/file/f6e023768f35/MoinMoin/user.py#l450
321 2011-05-18T21:38:33 <dreimark> http://hg.moinmo.in/moin/2.0/file/f6e023768f35/MoinMoin/user.py#l475
322 2011-05-18T21:39:52 <sinha> okay so why cant they be simply called as MoinMoin.user.setBookmark rather than flaskg.user.setBookmark
323 2011-05-18T21:42:09 <dreimark> this is done by the app setup http://hg.moinmo.in/moin/2.0/file/f6e023768f35/MoinMoin/app.py
324 2011-05-18T21:43:05 <dreimark> if you call it as flaskg.user.setBookmark you have the users user object already who did the request
325 2011-05-18T21:44:21 <dreimark> if you need operations which need e.g. a different user you can call MoinMoin.user and initialize a new user object
326 2011-05-18T21:44:32 <dreimark> but you don't need that for the current user
327 2011-05-18T21:45:22 <sinha> okay.
328 2011-05-18T21:45:58 <sinha> so reg bookmark funcionality the bookmark value has a timestamp, which is used in outputting the history
329 2011-05-18T21:46:16 <sinha> but in current moin2 can i set is as the date
330 2011-05-18T21:46:29 <sinha> and then use that date as the condition for the query
331 2011-05-18T21:46:45 <dreimark> or you convert the date to a number if that is needed
332 2011-05-18T21:47:08 <dreimark> in moin-1.9 it works also with fractions
333 2011-05-18T21:47:41 <dreimark> if you e.g. bookmark at midday
334 2011-05-18T21:47:50 <dreimark> then stuff an our later is shown
335 2011-05-18T21:47:57 <dreimark> *new
336 2011-05-18T21:48:57 <sinha> bookmark will be set for a day ? because our result will be grouped as the day for each kind of filter
337 2011-05-18T21:50:22 <dreimark> sinha: http://moinmo.in/RecentChanges
338 2011-05-18T21:50:39 <dreimark> the bookmark call is there at each date
339 2011-05-18T21:51:05 <dreimark> you see the integer representation on mouse over
340 2011-05-18T21:51:45 <sinha> yes it is something like a timestamp
341 2011-05-18T21:53:32 <dreimark> the one on top is the timestamp of the last entry on the list
342 2011-05-18T21:55:08 <dreimark> there it matters. all others can have a dayly stepping below
343 2011-05-18T21:57:35 <sinha> okay i guess i have got some insight reg this history implementation, i am putting all this on etherpad now
344 2011-05-18T22:06:56 <dreimark> sinha: ok, als fill in .. (add details about implementation plans) ...
345 2011-05-18T22:07:06 <dreimark> where what
346 2011-05-18T22:07:22 <sinha> yes sure
347 2011-05-18T22:10:54 *** RogerHaase
348 2011-05-18T22:25:49 *** RogerHaase
349 2011-05-18T23:02:43 <ThomasWaldmann> re
350 2011-05-18T23:35:41 <sinha> dreimark: is there any attribute present in rev_table to get what kind of revision is that, whether it is new/edit/delete or something else ?
351 2011-05-18T23:36:23 <sinha> such that i could add a condition in the query in case of filtering the results based on the actions taken on page
352 2011-05-18T23:49:57 <ThomasWaldmann> maybe first get clear what we have
353 2011-05-18T23:54:02 <sinha> where can i see what all the attributes present in rev_table and item_table
354 2011-05-18T23:54:19 <ThomasWaldmann> in the schema
355 2011-05-18T23:58:35 <sinha> where is the schema
