1 2011-06-08T00:03:05 * dreimark recognized that we can write in 2.0 comments without doing a data change.
2 2011-06-08T00:03:08 <dreimark> I like that
3 2011-06-08T00:05:14 <ThomasWaldmann> yes, you can change meta without changing data
4 2011-06-08T00:05:24 <ThomasWaldmann> that even works for binaries now
5 2011-06-08T00:27:01 <ThomasWaldmann> http://ep2011.europython.eu/p3/sprints/ < click button there if you want to attend the sprint
6 2011-06-08T00:41:22 <ThomasWaldmann> ronny: TheSheep: xorAxAx (?): ^^
7 2011-06-08T00:43:26 <ronny> re
8 2011-06-08T00:48:14 <ThomasWaldmann> (and whoever else wants to join us in the europython 2011 moin2 sprint)
9 2011-06-08T00:52:29 *** m4k3r
10 2011-06-08T00:53:39 <dreimark> m4k3r: do you want to join us at ep?
11 2011-06-08T00:54:37 <ThomasWaldmann> florence!!11
12 2011-06-08T00:55:48 <dreimark> at least he has an it provider
13 2011-06-08T00:56:17 <m4k3r> dreimark: unfortunately I have my high school exam :(
14 2011-06-08T00:56:28 <dreimark> oh how bad
15 2011-06-08T00:57:05 <dreimark> good luck :)
16 2011-06-08T00:57:06 <m4k3r> Yep, last year pycon Italy was pretty good.
17 2011-06-08T00:57:23 <m4k3r> I was a speaker there gh :D
18 2011-06-08T00:57:45 <m4k3r> s/gh/lol/
19 2011-06-08T00:58:06 <ThomasWaldmann> bad timing
20 2011-06-08T00:58:25 <dreimark> gn
21 2011-06-08T01:01:20 <ThomasWaldmann> gn dreimark
22 2011-06-08T01:13:08 *** raignarok
23 2011-06-08T01:37:40 *** m4k3r
24 2011-06-08T01:39:11 *** m4k3r
25 2011-06-08T01:44:22 *** m4k3r
26 2011-06-08T01:49:50 *** ronny
27 2011-06-08T01:52:06 *** ronny
28 2011-06-08T04:12:35 *** xjjk
29 2011-06-08T04:12:40 *** xjjk
30 2011-06-08T07:40:36 *** andialbrecht_
31 2011-06-08T08:52:44 *** raignarok
32 2011-06-08T09:23:22 *** hardy89
33 2011-06-08T09:37:10 *** Marchael
34 2011-06-08T09:39:01 <Marchael> moin
35 2011-06-08T10:16:59 <ThomasWaldmann> moin
36 2011-06-08T10:45:41 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4539114/
37 2011-06-08T11:06:14 <ThomasWaldmann> review done
38 2011-06-08T11:09:25 *** hardy89
39 2011-06-08T11:10:28 * Marchael looks
40 2011-06-08T11:13:01 <dreimark> moin
41 2011-06-08T11:16:01 <ThomasWaldmann> Marchael: btw, sorry for being so strict about good names, but that's just a result from long past experience
42 2011-06-08T11:16:22 <Marchael> I understand
43 2011-06-08T11:16:52 * dreimark commetns too
44 2011-06-08T11:17:03 <ThomasWaldmann> if it is not obvious yet for your regarding code, just imagine someone tells you a story, but doesn't choose the correct names for things (or even verbs) in that story.
45 2011-06-08T11:18:09 <ThomasWaldmann> like instead of saying "the chicken crossed the street" he is telling "the wingedthing xed the ground". you likely would end up "?????".
46 2011-06-08T11:18:41 <Marchael> :D
47 2011-06-08T11:24:56 <Marchael> dreimark: thx for commenting
48 2011-06-08T11:26:12 <Marchael> dreimark: > I would prefer a given file system location
49 2011-06-08T11:26:12 <Marchael> You mean absolute path?
50 2011-06-08T11:26:27 <dreimark> Marchael: read http://docs.python.org/library/tempfile.html
51 2011-06-08T11:26:48 <dreimark> give it a location in the test environment
52 2011-06-08T11:27:51 <ThomasWaldmann> dreimark: the tests should just work, without configuration
53 2011-06-08T11:28:04 <dreimark> yes
54 2011-06-08T11:28:10 <ThomasWaldmann> and if you insist on influencing it, you can still set TEMP=....
55 2011-06-08T11:28:13 <dreimark> ThomasWaldmann: i don't want test dirs in /tmp
56 2011-06-08T11:29:01 <ThomasWaldmann> they are just temporary and cleaned up some ms later
57 2011-06-08T11:29:11 <dreimark> or by an other process
58 2011-06-08T11:30:17 <dreimark> I suggest to use a /tmp in the env
59 2011-06-08T11:30:32 <dreimark> env/tmp
60 2011-06-08T11:35:56 <ThomasWaldmann> dreimark: btw, usually it is only the owner/creator of the temp dir who is allowed to delete it
61 2011-06-08T11:37:00 <ThomasWaldmann> and /tmp is just exactly for that purpose, so why not use it?
62 2011-06-08T11:49:11 <Marchael> ThomasWaldmann: also, I don't understand why we should compicate this code using setup_method() and teardown() ?
63 2011-06-08T11:51:11 <ThomasWaldmann> Marchael: because that is the usual way offered by the test framework.
64 2011-06-08T11:51:29 <Marchael> ah
65 2011-06-08T11:51:40 <ThomasWaldmann> and you can add more tests as methods without repeating that setup/teardown code in every method
66 2011-06-08T11:51:44 <Marchael> ok, but I didn't find this in py.test docs
67 2011-06-08T11:51:54 <Marchael> I'll look proper
68 2011-06-08T11:52:04 <ThomasWaldmann> i even pointed you to a file where we use that
69 2011-06-08T11:52:20 <ThomasWaldmann> even exactly for the same as you need
70 2011-06-08T11:54:58 <Marchael> I can't find name of that file in logs, please can you repeat?
71 2011-06-08T11:56:00 <ThomasWaldmann> search for tempfile. in the tests
72 2011-06-08T11:56:12 <ThomasWaldmann> or better without .
73 2011-06-08T12:01:24 <Marchael> find moin-2.0/ -name '*tempfile*' says nothing
74 2011-06-08T12:02:03 <Marchael> may that happends because I don't run tests
75 2011-06-08T12:12:34 *** m4k3r
76 2011-06-08T12:14:52 *** sinha
77 2011-06-08T12:15:11 *** ronny
78 2011-06-08T12:16:01 <ThomasWaldmann> Marchael: wrong command
79 2011-06-08T12:16:27 <ThomasWaldmann> i of course meant in the contents of the test source, not in the filenames
80 2011-06-08T12:18:15 <ThomasWaldmann> so you either use grep -r tempfile . or something even better
81 2011-06-08T12:29:48 *** ronny
82 2011-06-08T12:52:03 *** dreimark
83 2011-06-08T13:15:16 *** m4k3r
84 2011-06-08T13:37:25 *** dreimark
85 2011-06-08T13:37:36 <dreimark> re
86 2011-06-08T14:13:55 *** raignarok
87 2011-06-08T14:31:20 <CIA-69> pkumar <contactprashantat@gmail.com> * 964a9744310c r266 pytest2/MoinMoin/conftest.py: docstring moved to inside of function
88 2011-06-08T14:31:20 <CIA-69> pkumar <contactprashantat@gmail.com> * 957d41c088db r267 pytest2/MoinMoin/conftest.py: added 'try', 'finally' in MoinTestFunction
89 2011-06-08T14:31:21 <CIA-69> pkumar <contactprashantat@gmail.com> * 81f27ab8c620 r268 pytest2/MoinMoin/ (conftest.py test_logging.conf): test_logging.conf added for logging configurations of tests and pytest.set_trace removed from conftest.py.
90 2011-06-08T14:31:21 <CIA-69> pkumar <contactprashantat@gmail.com> * 7a29b52c8452 r269 pytest2/MoinMoin/conftest.py: MoinMoin.log.load_config(config_file) called from conftest.py to configure logging for tests.
91 2011-06-08T14:31:21 <CIA-69> pkumar <contactprashantat@gmail.com> * b7105cee9db7 r270 pytest2/MoinMoin/conftest.py: docstring added about the hack made.
92 2011-06-08T14:31:21 <CIA-69> pkumar <contactprashantat@gmail.com> * 92f9d136044f r271 pytest2/MoinMoin/ (conftest.py test_logging.conf): MoinMoin.log.load_config() called before import of MoinMoin.app in conftest.py and level changed to ERROR in test_logging.conf
93 2011-06-08T14:51:26 *** ronny
94 2011-06-08T14:55:02 <xorAxAx> waldi: ping
95 2011-06-08T14:55:08 <waldi> pong
96 2011-06-08T14:57:05 <xorAxAx> waldi: i will be busy till 16:00 CEST, can you manage the first meeting?
97 2011-06-08T15:00:23 *** pkumar
98 2011-06-08T15:00:30 <waldi> xorAxAx: not really
99 2011-06-08T15:01:04 <xorAxAx> so you are busy as well?
100 2011-06-08T15:01:08 <xorAxAx> why didnt you say that?
101 2011-06-08T15:05:29 *** gwork
102 2011-06-08T15:13:22 <pkumar> ThomasWaldmann: hi
103 2011-06-08T15:14:14 <pkumar> ThomasWaldmann: I had a little query about issue 'logging for test'
104 2011-06-08T15:15:08 <pkumar> ThomasWaldmann: Can you please tell me how should the log output be like after a test fails
105 2011-06-08T15:15:48 <pkumar> ThomasWaldmann: or should it show any output at all?
106 2011-06-08T15:16:04 <pkumar> I mean log output
107 2011-06-08T15:30:10 * dreimark is still in a meeting
108 2011-06-08T15:30:16 <xorAxAx> so waldi fail
109 2011-06-08T15:30:30 <xorAxAx> we will talk about coordination issues in the main meeting today
110 2011-06-08T15:30:43 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4539114/
111 2011-06-08T15:31:26 <Marchael> sorry, I can't answer you fast because ready to tomorrow offset
112 2011-06-08T15:31:54 <Marchael> s/ready/I'm getting ready/
113 2011-06-08T15:39:48 <Marchael> also it still has acl issue http://paste.pocoo.org/show/402773/
114 2011-06-08T15:40:20 <Marchael> but I test AclTokenizer() in test_analyzers, it's work correct
115 2011-06-08T15:40:55 <ThomasWaldmann> pkumar: timing log output is completely uninteresting in test log output. so we need a separate logging config for tests.
116 2011-06-08T15:41:42 *** hardy89
117 2011-06-08T15:42:25 <pkumar> ThomasWaldmann: yeah, but can please give a rough idea how the new log should look like, may be its contents.
118 2011-06-08T15:42:48 <pkumar> ThomasWaldmann: or should there be any log?
119 2011-06-08T15:43:08 <ThomasWaldmann> well, just look yourself what's practical
120 2011-06-08T15:43:27 <ThomasWaldmann> i just have seen that the timing output spams it too much
121 2011-06-08T15:44:13 <ThomasWaldmann> in any case, you need to change the framework so it does not use the default logging configuration, but a separate test logging configuration
122 2011-06-08T15:45:16 <pkumar> ThomasWaldmann: for the time being I've added a new test_logging.conf file which can be modified directly to change logging for tests.
123 2011-06-08T15:45:46 <pkumar> ThomasWaldmann: few changes in conftest.py served the purpose
124 2011-06-08T15:48:22 <ThomasWaldmann> sounds good
125 2011-06-08T15:48:43 <pkumar> :)
126 2011-06-08T15:53:19 <ThomasWaldmann> dreimark: hardy89: Marchael: pkumar: sinha: waldi: xorAxAx: main meeting in 9 minutes
127 2011-06-08T15:53:32 <pkumar> ok,
128 2011-06-08T15:53:34 <hardy89> ThomasWaldmann: ok
129 2011-06-08T15:53:38 <Marchael> ok
130 2011-06-08T16:02:28 *** andialbrecht
131 2011-06-08T16:04:56 <sinha> re
132 2011-06-08T16:09:01 *** ronny
133 2011-06-08T16:09:34 <ThomasWaldmann> sorry, was away, can't somebody else just start
134 2011-06-08T16:10:01 <ThomasWaldmann> Marchael: please paste your prepared stuff about progress last week, blockers, plans for next 7 days
135 2011-06-08T16:10:47 <Marchael> This week I working on fixing analyzers, whoosh schema and writing tests for indexing.
136 2011-06-08T16:10:47 <Marchael> I failed to do rebuilding indexes, but I think what I can do it my prioritet task for next week
137 2011-06-08T16:10:47 <Marchael> In this changeset http://codereview.appspot.com/4539114/ I change some value names, add setup_ and teardown_ methods for base class
138 2011-06-08T16:10:47 <Marchael> But I think what indexing schema is done, and it won't be change in the nearest future.
139 2011-06-08T16:10:59 <Marchael> Blocker: test for searching in acl field fails, and I can't understard the reason of it. AclTokenizer() has been tested in test_analyzer.py and it's work correct
140 2011-06-08T16:11:11 * ThomasWaldmann notes that this meeting time is a bit unpractical on the mentor side as it is normal work time
141 2011-06-08T16:11:53 * Marchael done
142 2011-06-08T16:12:30 <ThomasWaldmann> well, that acl thing might be an unsolved problem, but not really a blocker
143 2011-06-08T16:12:55 <ThomasWaldmann> to clarify that again, a blocker means that something stands in your way so you can't continue doing further work
144 2011-06-08T16:12:59 <Marchael> hm, may be. But we can't search in acl for now
145 2011-06-08T16:13:26 <ThomasWaldmann> I'll have a look at that specific thing after the session.
146 2011-06-08T16:13:33 <Marchael> ok, thx
147 2011-06-08T16:13:47 <Marchael> I pasted traceback ^
148 2011-06-08T16:13:49 <ThomasWaldmann> a general question: can we do anything to speedup progress and improve communications?
149 2011-06-08T16:13:52 <xorAxAx> ThomasWaldmann: well, re time, force the indians to accustom to european sleeping patterns
150 2011-06-08T16:14:50 <ThomasWaldmann> aren't we all night owls anyway? :)
151 2011-06-08T16:15:32 <Marchael> ThomasWaldmann: I know what youe timezone utc +2 and you working. But it's a bit problem for me to work whole night :)
152 2011-06-08T16:16:15 <ThomasWaldmann> Marchael: above question is also for you ^^
153 2011-06-08T16:17:04 <Marchael> I thought what it was rhetorical question
154 2011-06-08T16:17:05 <Marchael> :)
155 2011-06-08T16:17:28 <ThomasWaldmann> no, that will be a growing problem if we don't
156 2011-06-08T16:18:28 <Marchael> I can work at night but I it's a bit difficult to write good code.
157 2011-06-08T16:18:36 <ThomasWaldmann> sinha: hardy89: pkumar: same question will go to you later, think about it
158 2011-06-08T16:19:04 <ThomasWaldmann> Marchael: that was not the question
159 2011-06-08T16:19:20 <sinha> 5-6 hours later than now will be fine
160 2011-06-08T16:19:39 <hardy89> sinha: you actually mean it :O
161 2011-06-08T16:19:53 <hardy89> sinha: you too fom India. Right?
162 2011-06-08T16:20:11 <sinha> hardy89 : ofcourse, when do you sleep
163 2011-06-08T16:20:23 <hardy89> sinha: so 5-6 hrs from now would mean 1 a.m
164 2011-06-08T16:20:32 <hardy89> sinha: thats when i sleep^
165 2011-06-08T16:20:33 <hardy89> :)
166 2011-06-08T16:20:37 <ThomasWaldmann> Marchael: the communication problem i am seeing is that i have to repeat over and over again and you seem to be struggling with stuff for which I was already pointing you to a solution
167 2011-06-08T16:20:42 <Marchael> heh, 5-6 hours later and there will be 2.00
168 2011-06-08T16:21:06 <sinha> hardy89: maybe around 11 PM
169 2011-06-08T16:21:25 <ThomasWaldmann> and the speed problem you maybe know the cause better, weekly output is too low for 40 work hours
170 2011-06-08T16:22:31 <ThomasWaldmann> Marchael: so, suggestions about how to improve that?
171 2011-06-08T16:24:34 <ThomasWaldmann> -\|/-.....
172 2011-06-08T16:25:00 <Marchael> ThomasWaldmann: may be multitasking? For example if I make change to one task and you have no time to view it, may be I can do something else?
173 2011-06-08T16:25:20 <Marchael> related with this task
174 2011-06-08T16:25:32 <ThomasWaldmann> yeah, that is a good suggestion. you didn't do that yet? :)
175 2011-06-08T16:26:27 <Marchael> no, I try, but sometimes I have only one task to solve
176 2011-06-08T16:27:05 <ThomasWaldmann> some principles of OS design can be transferred to human work and communications also, we can talk a bit about that after session
177 2011-06-08T16:27:07 <Marchael> s/no/yes/
178 2011-06-08T16:27:15 <pkumar> 2 emails a week reporting project status would help, i guess.
179 2011-06-08T16:27:24 <ThomasWaldmann> ok, any questions for Marchael from other mentors
180 2011-06-08T16:27:27 <ThomasWaldmann> ?
181 2011-06-08T16:27:44 <ThomasWaldmann> pkumar: you have the diary for that, email is discouraged
182 2011-06-08T16:27:52 <pkumar> ok
183 2011-06-08T16:28:00 <ThomasWaldmann> and you have to update it DAILY for that day
184 2011-06-08T16:28:27 <ThomasWaldmann> dreimark: you are there?
185 2011-06-08T16:28:53 <ThomasWaldmann> ok, sinha, you're next
186 2011-06-08T16:29:08 <sinha> LAST: Completed the grouping of history results on the item name basis and date basis.
187 2011-06-08T16:29:09 <sinha> Changesets :-
188 2011-06-08T16:29:09 <sinha> i) https://bitbucket.org/sinha/moin2/changeset/58a29a7fd016
189 2011-06-08T16:29:09 <sinha> ii) https://bitbucket.org/sinha/moin2/changeset/08e3faf4c020
190 2011-06-08T16:29:09 <sinha> Screen Shot for the same : http://www.moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-07?action=AttachFile&do=get&target=historygrouping.png
191 2011-06-08T16:29:09 <sinha> CURRENT: Adding the bookmark functionality, reading the moin1.9 codes to get some idea.
192 2011-06-08T16:29:09 <sinha> NEXT: Will start pagination of the results after completing this bookmark functionality.
193 2011-06-08T16:29:10 <sinha> BLOCKER: Nothing now
194 2011-06-08T16:29:14 <ThomasWaldmann> (if dreimark is busy at work, I'll try to do it)
195 2011-06-08T16:29:25 <ThomasWaldmann> that was well prepared :)
196 2011-06-08T16:30:24 <ThomasWaldmann> (although we can't look at changesets right now)
197 2011-06-08T16:30:45 <sinha> ThomasWaldmann: i got it reviewed from dreimark yesterday
198 2011-06-08T16:31:15 <ThomasWaldmann> looks nice, except the contenttype column which wraps a bit ugly
199 2011-06-08T16:31:57 <ThomasWaldmann> about the paging: please discuss that further here before starting to implement. after the session.
200 2011-06-08T16:32:30 <ThomasWaldmann> sinha: did you try for non-english locale?
201 2011-06-08T16:32:31 <sinha> Reg contenttype column : will customize it later with icons, clean texts
202 2011-06-08T16:33:09 <sinha> i tried for Dutch
203 2011-06-08T16:33:20 <sinha> you mean for the names, etc ?
204 2011-06-08T16:33:37 <ThomasWaldmann> for display of date/time
205 2011-06-08T16:33:45 <sinha> yes working fine for that
206 2011-06-08T16:34:29 <ThomasWaldmann> why is the screenshot showing a different left column icon for Jun 6 and Jun 4 change?
207 2011-06-08T16:34:49 <ThomasWaldmann> http://www.moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-07?action=AttachFile&do=get&target=historygrouping.png
208 2011-06-08T16:34:55 <sinha> June 6 is Rename one
209 2011-06-08T16:35:04 <sinha> June 4 is SAVE one
210 2011-06-08T16:35:24 <sinha> icon on the basis of action, will give text on mouse hover on them
211 2011-06-08T16:35:35 <ThomasWaldmann> ah, ok.
212 2011-06-08T16:35:47 <ThomasWaldmann> any other questions for sinha?
213 2011-06-08T16:35:56 <xorAxAx> no
214 2011-06-08T16:36:40 <ThomasWaldmann> btw, one more request from me: we maybe need 2 modes for rc display. the one simple stupid mode (like it was) and the 1.9 like mode (like you showed)
215 2011-06-08T16:37:17 <ThomasWaldmann> ok, xorAxAx pkumar please continue
216 2011-06-08T16:37:48 <xorAxAx> pkumar: please paste
217 2011-06-08T16:38:11 <pkumar> -> Worked on the issues raised due to changes in conftest.py.
218 2011-06-08T16:38:21 <pkumar> -> started to work on the issue:- memory leakage when py.test is run. But need to look into the issue more carefully.
219 2011-06-08T16:38:32 <pkumar> -> worked on issue "logging for tests" https://bitbucket.org/pkumar/pytest_moin/changesets ; Now logs for tests dont give messy output anymore.
220 2011-06-08T16:39:09 <xorAxAx> pkumar: how many % of the tests did you port yet?
221 2011-06-08T16:39:14 <pkumar> planning to work on the listed issues for the next couple of days
222 2011-06-08T16:40:56 <xorAxAx> pkumar: umm, your paste buffer is pretty slow
223 2011-06-08T16:41:01 * ThomasWaldmann now and then had the impression that main porting work was s/py.test/pytest/g :)
224 2011-06-08T16:41:04 <xorAxAx> why didnt you prepare your messages?
225 2011-06-08T16:41:09 <pkumar> actually, the difference between pytest2 and pytest 1 is the way they behave in handling test items
226 2011-06-08T16:42:31 <pkumar> I've made changes in conftest.py like the way pytest2 handle generator functions
227 2011-06-08T16:44:06 <pkumar> Also, the tests work fine with pytest2 and currently there is noting much to change except some syntax like in skip methods
228 2011-06-08T16:45:09 <pkumar> though it is more important to change the test behavior so that they get in more sync with pytest2 as they were actually designed for pytest 1
229 2011-06-08T16:45:45 <xorAxAx> pkumar: so, is porting work still needed?
230 2011-06-08T16:46:02 *** raignarok
231 2011-06-08T16:47:59 <pkumar> currently it would be good to work according to given schedule in EP and the tests could be modified in course of time as we get more porting ideas
232 2011-06-08T16:48:18 <xorAxAx> EP?
233 2011-06-08T16:48:37 <pkumar> http://etherpad.osuosl.org/moin2-unittest
234 2011-06-08T16:48:44 <ThomasWaldmann> as a note for your memory leak debugging: currently it sets up a complete wsgi app with everything from scratch for every test method. maybe this is the cause. also it is rather slow, think about better ways.
235 2011-06-08T16:49:13 <pkumar> ThomasWaldmann: ok
236 2011-06-08T16:50:50 <xorAxAx> pkumar: NEXT , BLOCKERS please
237 2011-06-08T16:51:01 <xorAxAx> ok, you did next partly
238 2011-06-08T16:51:03 <pkumar> xorAxAx: this is again a bug fix week so this may lead to certain changes in MoinMoin tests in course of fixing these
239 2011-06-08T16:51:32 <xorAxAx> pkumar: note that you are behind schedule
240 2011-06-08T16:51:49 <pkumar> xorAxAx: currently no blockers.
241 2011-06-08T16:51:52 <xorAxAx> and its not because the problems were heard
242 2011-06-08T16:51:54 <xorAxAx> hard
243 2011-06-08T16:52:44 <pkumar> xorAxAx: I'll make it up in the coming weeks
244 2011-06-08T16:52:51 <xorAxAx> ok
245 2011-06-08T16:53:51 <pkumar> well, that's it about this week's work from my side.
246 2011-06-08T16:53:59 <xorAxAx> ok
247 2011-06-08T16:54:08 <xorAxAx> please prepare your messages next time
248 2011-06-08T16:54:17 <pkumar> sure, will do
249 2011-06-08T16:54:24 <pkumar> sorry about the delay caused this time, everyone
250 2011-06-08T16:57:45 <hardy89> ThomasWaldmann: its my turn now?
251 2011-06-08T16:58:05 <hardy89> waldi: ^
252 2011-06-08T16:59:20 *** hardy89
253 2011-06-08T16:59:21 *** pkumar
254 2011-06-08T16:59:43 *** hardy89
255 2011-06-08T17:00:06 <hardy89> .
256 2011-06-08T17:01:05 <hardy89> t123?
257 2011-06-08T17:01:51 <hardy89> xorAxAx: are waldi and ThomasWaldmann not here anymore?
258 2011-06-08T17:02:42 <Marchael> I think what they can see your paste anyway
259 2011-06-08T17:03:41 <hardy89> Marchael: i thought meeting was for reporting the issue and asking :)
260 2011-06-08T17:04:10 * hardy89 feels he is the only one left on channel.
261 2011-06-08T17:04:25 <hardy89> waldi, ThomasWaldmann : LAST + BLOCKERS
262 2011-06-08T17:04:25 <hardy89> 1. For Memory leak problem, i read the docs regarding memory leaks and made few changes in conftest.py, but that did not do any difference so reverted them back. Even used a plug-in called 'Dozer' but can't see any change in the activity monitor. RAM usage still climb up to around 2.8GB.
263 2011-06-08T17:04:25 <hardy89> 2. Did not work on the fs2 issue.
264 2011-06-08T17:04:26 <hardy89> 3. For logging, pytest and stackoverflow docs were read and few changes were done. Tests were run individually and all of them together. Used 'capturelog 0.7' which although works but still does not routes logs in default config.
265 2011-06-08T17:04:55 <hardy89> waldi, ThomasWaldmann : NEXT
266 2011-06-08T17:04:55 <hardy89> 1. Work on these issue continues. Probably just on memory leak issue cos pkumar is already working on logging.
267 2011-06-08T17:04:55 <hardy89> 2. Would like to work more with 'Dozer' cos it still seem to be useful.
268 2011-06-08T17:04:55 <hardy89> 3. Along with this, tests which skip, show error, or fail will be fixed. Specially tests in modules Storage and Datastruct.
269 2011-06-08T17:05:23 <hardy89> waldi, ThomasWaldmann : even had some branch issues with my repo so could not commit much.
270 2011-06-08T17:05:34 <hardy89> have to commit all the changes all over again.
271 2011-06-08T17:05:37 <hardy89> will do it soon
272 2011-06-08T17:06:16 <hardy89> won't be able to work on 9th and 10th of June. Have my last college exam on 11th.
273 2011-06-08T17:06:32 <hardy89> after that i'll b done with my college, once and for all :)
274 2011-06-08T17:09:07 <sinha> hardy86: which college are you from, exams so late ??
275 2011-06-08T17:09:53 <hardy89> sinha: MD University, Haryana. heard of it?
276 2011-06-08T17:10:16 <hardy89> sinha: for 4 subjects, they gave us 28 days :|
277 2011-06-08T17:10:24 <sinha> cool man
278 2011-06-08T17:10:33 <sinha> you can visit homes in between the paper :P
279 2011-06-08T17:11:04 <dreimark> re
280 2011-06-08T17:11:26 <hardy89> sinha: i'm at home. but yeah students, do that. :)
281 2011-06-08T17:16:03 <hardy89> dreimark: kindly go through my this week progress
282 2011-06-08T17:17:09 <hardy89> dreimark: are you still here?
283 2011-06-08T17:18:34 <dreimark> hardy89: yes
284 2011-06-08T17:18:50 <hardy89> dreimark: ah. finally
285 2011-06-08T17:19:03 <hardy89> dreimark: why everyone left till my turn :|
286 2011-06-08T17:19:26 <hardy89> dreimark: LAST & BLOCKERS
287 2011-06-08T17:19:27 <hardy89> 1. For Memory leak problem, i read the docs regarding memory leaks and made few changes in conftest.py, but that did not do much/any difference. Even used a plug-in called 'Dozer' but can't see any change in the activity monitor. RAM usage still climb up to around 2.8GB.
288 2011-06-08T17:19:27 <hardy89> 2. Did not work on the fs2 issue.
289 2011-06-08T17:19:27 <hardy89> 3. For logging, pytest and stackoverflow docs were read and few changes were done. Tests were run individually and all of them together. Used a plug-in called 'capturelog 0.7' which although works but still does not routes log.
290 2011-06-08T17:19:37 <dreimark> hardy89: noone left
291 2011-06-08T17:19:52 <hardy89> dreimark: i did PING everybody.
292 2011-06-08T17:20:03 <dreimark> be patient
293 2011-06-08T17:20:09 <hardy89> dreimark: :)
294 2011-06-08T17:20:13 <hardy89> NEXT
295 2011-06-08T17:20:14 <hardy89> 1. Work on these issue continues. Probably just on memory leak issue cos pkumar is already working on logging.
296 2011-06-08T17:20:14 <hardy89> 2. Would like to work more with 'Dozer' cos it still seem to be useful.
297 2011-06-08T17:20:14 <hardy89> 3. Along with this, tests which skip, show error, or fail will be fixed. Specially tests in modules Storage and Datastruct.
298 2011-06-08T17:21:35 <Marchael> seems like mentors are disscuss somthing
299 2011-06-08T17:29:36 <dreimark> hardy89: url to your repo please
300 2011-06-08T17:32:02 <hardy89> even had some branch issues with my repo so could not commit much.
301 2011-06-08T17:32:02 <hardy89> have to commit all the changes all over again.
302 2011-06-08T17:32:02 <hardy89> will do it soon
303 2011-06-08T17:32:42 <hardy89> dreimark: https://bitbucket.org/89hardy
304 2011-06-08T17:32:50 <hardy89> but therez much there right now
305 2011-06-08T17:32:55 <dreimark> noone said it is easy to find the mem leakage
306 2011-06-08T17:33:07 <dreimark> because then we had fixed that already
307 2011-06-08T17:34:03 <hardy89> dreimark: yeah thats not easy. i agree. but yeah, doable.
308 2011-06-08T17:34:20 <dreimark> do you work with logging too?
309 2011-06-08T17:34:39 <dreimark> or profiling ?
310 2011-06-08T17:35:19 <hardy89> dreimark: i started of with logging, but pkumar has also taken that up. so we decided that he continues with it, and i look over to mem leakage
311 2011-06-08T17:35:27 <hardy89> dreimark: no profiling
312 2011-06-08T17:37:37 <dreimark> from the speed I would guess there is something recursive running
313 2011-06-08T17:38:04 <dreimark> so I would search first for stuff which recurses
314 2011-06-08T17:38:13 <dreimark> or stuff which is very often called
315 2011-06-08T17:38:39 <hardy89> dreimark: ok.
316 2011-06-08T17:39:05 <hardy89> dreimark: i read few docs which said this might be due to some objects being called over and over again
317 2011-06-08T17:39:11 <hardy89> cycles being created
318 2011-06-08T17:39:19 <hardy89> garbage etc.
319 2011-06-08T17:40:18 <dreimark> you can also compare with a long cli task e.g. creating reading many items
320 2011-06-08T17:40:31 <dreimark> if that shows the same problem
321 2011-06-08T17:40:39 <dreimark> if so you have a smaller test setuo+
322 2011-06-08T17:41:36 <dreimark> if not you know which methods likly not involved
323 2011-06-08T17:42:01 <hardy89> right. will do it.
324 2011-06-08T17:42:21 <dreimark> ok, we can talk later I have a python user group meeting soon
325 2011-06-08T17:42:26 <dreimark> bbl
326 2011-06-08T17:42:33 <hardy89> dreimark: sure. thanks :)
327 2011-06-08T17:43:23 <hardy89> waldi, ThomasWaldmann : i even read chat logs in which you mentioned the issue with __init__.py and diary page.
328 2011-06-08T17:43:46 <hardy89> __init__.py has bee fixed. Diarsy Page, that i'll keep in mind.
329 2011-06-08T17:43:50 <hardy89> *diary
330 2011-06-08T17:47:26 <sinha> dreimark: reg that bookmark thing, i am trying to write condition on the query as condition = and_(item_table.c.id == rev_table.c.item_id,
331 2011-06-08T17:47:27 <sinha> rev_table.c.datetime > bookmark_time)
332 2011-06-08T17:48:13 <sinha> dreimark: but the query which is getting generated is not including this variable and comes out as SELECT rev_table.datetime, item_table.name, rev_table.revno, rev_table.id FROM rev_table, item_table WHERE item_table.id = rev_table.item_id AND rev_table.datetime > ? ORDER BY rev_table.datetime DESC
333 2011-06-08T17:48:39 <sinha> i am prinitng bookmark_time separately on console, it is coming right there
334 2011-06-08T17:48:49 <sinha> what could be the problem ?
335 2011-06-08T17:51:09 *** hardy89
336 2011-06-08T18:03:08 * Marchael brb soon
337 2011-06-08T18:16:55 <Marchael> ThomasWaldmann: highlight me when you go back
338 2011-06-08T18:26:59 *** raignarok
339 2011-06-08T18:38:00 <dreimark> re
340 2011-06-08T19:10:02 *** ronny
341 2011-06-08T19:18:37 <ThomasWaldmann> xorAxAx: it would've been nice if you had continue the formal meeting with hardy89 when no other mentor is there.
342 2011-06-08T19:19:05 <xorAxAx> ThomasWaldmann: i was interrupted
343 2011-06-08T19:19:15 <ThomasWaldmann> Marchael: i am here for a few minutes, then away, then back again
344 2011-06-08T19:20:01 * ThomasWaldmann was also interrupted.
345 2011-06-08T19:20:23 <ThomasWaldmann> waldi: please try to be available in the meeting time.
346 2011-06-08T19:23:24 <Marchael> ThomasWaldmann: I want to discuss about building indexes and integrating indexing to moin
347 2011-06-08T19:24:16 <Marchael> I think what indexes should be build using moin backend
348 2011-06-08T19:24:30 <Marchael> so I need to use sqla fot this
349 2011-06-08T19:27:40 <Marchael> if you haven't time right now, so we can discuss this later
350 2011-06-08T19:28:28 <ThomasWaldmann> it is unclear what you mean, please be more precise
351 2011-06-08T19:31:14 <Marchael> For building index files we need some documents, all documetns stored into backend, so I plan to use sqla for getting documents from backend and putting them to whoosh indexes
352 2011-06-08T19:38:24 <ThomasWaldmann> it is still totally unclear to me what you mean or why you would want to do that
353 2011-06-08T19:42:05 <ThomasWaldmann> in case that is unclear: the storage api is used to get items/revisions from the backend storage (no matter what that storage is)
354 2011-06-08T19:42:12 <ThomasWaldmann> see MoinMoin.storage
355 2011-06-08T19:42:26 <Marchael> thx
356 2011-06-08T19:42:39 * ThomasWaldmann brb
357 2011-06-08T19:56:11 *** ronny
358 2011-06-08T20:16:40 *** grzywacz
359 2011-06-08T20:16:41 *** grzywacz
360 2011-06-08T20:28:52 <ThomasWaldmann> re
361 2011-06-08T20:30:59 <Marchael> ThomasWaldmann: can you help me to find a reasons why search query in acl field fails?
362 2011-06-08T20:38:04 <ThomasWaldmann> need more input
363 2011-06-08T20:38:56 <Marchael> you mean what I should add more acl rules?
364 2011-06-08T20:42:45 <ThomasWaldmann> I need more input
365 2011-06-08T20:45:50 <ThomasWaldmann> http://codereview.appspot.com/4539114/ that is still uptodate and to review?
366 2011-06-08T20:46:31 <Marchael> no
367 2011-06-08T20:47:14 <Marchael> I made some changes to this, and now update this
368 2011-06-08T20:49:19 <Marchael> updated
369 2011-06-08T20:50:33 <Marchael> ThomasWaldmann: now it is reviewable
370 2011-06-08T20:56:10 <Marchael> testUpdateDel() will be test update_document() and delete_document(). But there is a problem, whoosh update_document works only with schemas containing unique fields
371 2011-06-08T21:03:34 <ThomasWaldmann> ok, i look
372 2011-06-08T21:06:33 <ThomasWaldmann> setup/teardown is better now
373 2011-06-08T21:08:32 <sinha> ThomasWaldmann: i am editing the revision query by putting a condition on date time as `condition = and_(item_table.c.id == rev_table.c.item_id,rev_table.c.datetime > bookmark_time)`
374 2011-06-08T21:09:03 <sinha> but the query i am getting comes like this `SELECT rev_table.datetime, item_table.name, rev_table.revno, rev_table.id FROM rev_table, item_table WHERE item_table.id = rev_table.item_id AND rev_table.datetime > ? ORDER BY rev_table.datetime DESC'
375 2011-06-08T21:09:26 <sinha> why isnt it putting the value of variable bookmark_time ?
376 2011-06-08T21:10:05 <sinha> i am printing the value of that variable separately on console, it is showing the correct value there ? what could be wrong ?
377 2011-06-08T21:24:47 *** raignarok
378 2011-06-08T21:36:23 <ThomasWaldmann> Marchael: review done
379 2011-06-08T21:36:34 * Marchael looks
380 2011-06-08T21:45:04 <sinha> gn
381 2011-06-08T21:45:05 *** sinha
382 2011-06-08T21:45:16 <ThomasWaldmann> maybe next time try to react to ALL the review comments somehow. either fix or ask.
383 2011-06-08T21:45:18 *** m4k3r
384 2011-06-08T22:13:16 <Marchael> ThomasWaldmann: I understand what perfomance slow down when commit to index happens after each add_document() in tests. but if we working in real wiki, not test enviroment. Shouldn't we commited changes immediately?
385 2011-06-08T22:14:02 <ThomasWaldmann> my comment is more on api principles
386 2011-06-08T22:14:25 <ThomasWaldmann> you can just call the whoosh api directly, instead making a worse copy of it
387 2011-06-08T22:14:48 <ThomasWaldmann> for single add_document, you of course call commit afterwards
388 2011-06-08T22:16:11 <Marchael> So you think WhooshIndex class shouldn't contain add,delete,modify methods?
389 2011-06-08T22:16:37 <Marchael> s/modify/update/
390 2011-06-08T22:19:34 <ThomasWaldmann> no replication of whoosh api
391 2011-06-08T22:19:50 <ThomasWaldmann> esp. if you use same name, that gets confusing
392 2011-06-08T22:20:58 <Marchael> ok
393 2011-06-08T22:33:31 <ThomasWaldmann> brb
394 2011-06-08T22:34:51 <Marchael> strange
395 2011-06-08T22:35:05 <Marchael> test no fails anymore
396 2011-06-08T22:35:11 <Marchael> *have no
397 2011-06-08T22:35:15 <Marchael> *has
398 2011-06-08T22:37:22 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4539114
399 2011-06-08T23:08:30 <Marchael> gn/bbl
400 2011-06-08T23:08:57 <ThomasWaldmann> Marchael: did you fix all the stuff?
401 2011-06-08T23:09:31 <Marchael> I tryed :)
402 2011-06-08T23:09:38 <ThomasWaldmann> ok
403 2011-06-08T23:09:47 <ThomasWaldmann> gn Marchael
404 2011-06-08T23:10:30 <Marchael> hm, may be you review that code first and I can sleep well :)
405 2011-06-08T23:12:08 <Marchael> ThomasWaldmann: ^
406 2011-06-08T23:15:44 <ThomasWaldmann> review done, looks good, sleep well :)
407 2011-06-08T23:15:56 <ThomasWaldmann> (one minor comment, see there)
408 2011-06-08T23:16:12 <Marchael> thx, I commit this to repo and make record to diary
409 2011-06-08T23:22:00 <Marchael> gn/bbl
410 2011-06-08T23:27:06 <dreimark> re
411 2011-06-08T23:27:29 * dreimark laptop was out of battery power
412 2011-06-08T23:29:33 <dreimark> sinha: show me the code how I can verify that
