1 2011-06-14T00:00:05 *** m4k3r
2 2011-06-14T00:32:36 *** RogerHaase
3 2011-06-14T02:21:05 <dreimark> gn
4 2011-06-14T05:23:29 *** Marchael
5 2011-06-14T05:23:40 <Marchael> moin
6 2011-06-14T07:35:56 *** andialbrecht_
7 2011-06-14T08:03:43 <dreimark> moin
8 2011-06-14T08:26:34 *** gwork
9 2011-06-14T08:28:44 *** gwork
10 2011-06-14T08:28:58 *** gwork
11 2011-06-14T08:30:22 *** gwork
12 2011-06-14T08:31:21 *** gwork
13 2011-06-14T08:31:27 *** gwork
14 2011-06-14T08:33:27 *** gwork
15 2011-06-14T09:28:33 *** gwork
16 2011-06-14T09:40:53 <ThomasWaldmann> moin
17 2011-06-14T09:44:38 <ThomasWaldmann> Marchael: https://bitbucket.org/mchaput/whoosh/changeset/7ccca491016f
18 2011-06-14T09:47:15 *** hardy89
19 2011-06-14T09:53:58 *** hardy89
20 2011-06-14T10:21:38 *** gwork
21 2011-06-14T10:49:30 *** hardy89
22 2011-06-14T10:49:35 *** hardy89
23 2011-06-14T11:03:37 *** greg_f
24 2011-06-14T12:23:25 *** ronny
25 2011-06-14T12:25:49 *** ronny
26 2011-06-14T12:31:26 *** sinha
27 2011-06-14T13:59:20 <CIA-69> Akash Sinha <akash2607@gmail.com> * 71988ea0f53e r267 default/MoinMoin/apps/frontend/views.py: minor edition in grouping of results, now changes done on the same day for a item is only shown in that item group
28 2011-06-14T14:07:45 *** ronny
29 2011-06-14T14:34:15 *** raignarok
30 2011-06-14T14:52:23 <ThomasWaldmann> Marchael: any progress?
31 2011-06-14T14:56:28 *** ronny
32 2011-06-14T15:05:04 *** Marchael
33 2011-06-14T16:28:38 *** andialbrecht
34 2011-06-14T16:34:58 *** m4k3r
35 2011-06-14T17:00:44 <ThomasWaldmann> dreimark: i suggested that "just use revno" for rc. of course these numbers can get longer, but that's maybe still simpler / more direct than inventing new numbers just for that purpose
36 2011-06-14T17:15:41 <dreimark> ThomasWaldmann: I agree totally because it is the correct mapping. Somehow I missed that discussion
37 2011-06-14T17:49:49 *** RogerHaase
38 2011-06-14T17:52:13 *** grzywacz
39 2011-06-14T18:14:46 *** Marchael
40 2011-06-14T18:15:08 <Marchael> moin
41 2011-06-14T18:40:35 <RogerHaase> ThomasWaldmann: dreimark: I updated http://codereview.appspot.com/4535086 with a workaround for Firefox and Opera middle mouse button issue. Not a perfect solution, see comments near line 839 in common.js.
42 2011-06-14T19:03:07 <Marchael> I couldn't set app.cfg.index_dir in my wikiconfig_my.py, moin failed to run with this traceback http://paste.pocoo.org/show/407620/
43 2011-06-14T19:04:16 <dreimark> RogerHaase: thx, me looks soon
44 2011-06-14T19:04:30 <Marchael> there is wikiconfig_my.py http://paste.pocoo.org/show/407632/
45 2011-06-14T19:06:16 <dreimark> Marchael: why can you name it wikiconfig_my.py? because isn't it wikiconfig_editme.py ?
46 2011-06-14T19:07:22 <Marchael> I think what I can name it like wikiconfig_{something}.py
47 2011-06-14T19:07:48 <Marchael> only not local of course
48 2011-06-14T19:08:05 <Marchael> local == wikiconfig_local.py
49 2011-06-14T19:08:28 <dreimark> hmm, may be then you don't have autoreload for this file
50 2011-06-14T19:09:08 <dreimark> cat wikiconfig_local.py
51 2011-06-14T19:09:13 <dreimark> from wikiconfig_editme import *
52 2011-06-14T19:09:41 <dreimark> thats the workaround for autoreload i use, have not seen that this was only on my box
53 2011-06-14T19:09:53 <Marchael> I I put "from wikiconfig_editme import *" in wikiconfig_local.py but it doesn't make sense
54 2011-06-14T19:10:20 * Marchael named this wikiconfig_editme.py
55 2011-06-14T19:10:25 <dreimark> if you have a wikiconfig_editme.py
56 2011-06-14T19:10:37 <dreimark> you can do changes in that file and don't need to restart moin
57 2011-06-14T19:11:11 <dreimark> however not the current problem
58 2011-06-14T19:12:55 <dreimark> Marchael: isn't it Config.index_dir ?
59 2011-06-14T19:13:44 <Marchael> mmm, Thomas recomends me to use app.cfg.index_dir
60 2011-06-14T19:14:04 <dreimark> i have not followed the discussion
61 2011-06-14T19:14:21 <dreimark> but usually config vars are defined in MM.config
62 2011-06-14T19:15:11 <Marchael> but app.cfg.index_dir contains absolute path
63 2011-06-14T19:15:23 <Marchael> it should be setted by wiki admin
64 2011-06-14T19:15:52 <dreimark> at least later it should be moved to the usual Config definitions
65 2011-06-14T19:18:40 <ThomasWaldmann> File "/home/marchael/Downloads/moin/moin2/moin-2.0/wikiconfig_editme.py", line 5, in LocalConfig app.cfg.index_dir = "/home/marchael/Downloads/moin/moin2/moin-2.0/MoinMoin/search/"
66 2011-06-14T19:18:57 <ThomasWaldmann> that's wrong, in 2 ways
67 2011-06-14T19:19:50 <ThomasWaldmann> first, app.cfg IS that class, so, if you are inside the class, you just use index_dir = '...'
68 2011-06-14T19:21:08 <ThomasWaldmann> second, don't put the index into the code, use some directory elsewhere for it (e.g. wiki/index/ or whatever)
69 2011-06-14T19:21:24 <ThomasWaldmann> Marchael: ^^
70 2011-06-14T19:22:36 <ThomasWaldmann> if you want to refer to that classes' index_dir in the code, you use app.cfg.index_dir.
71 2011-06-14T19:23:04 <ThomasWaldmann> app.cfg to get the Config object, .index_dir to get that attribute's value
72 2011-06-14T19:23:11 <Marchael> hm, but I'm try to use app.cfg.index_dir
73 2011-06-14T19:23:30 <ThomasWaldmann> line 5 of your config is wrong
74 2011-06-14T19:23:38 <ThomasWaldmann> remove the app.cfg. there
75 2011-06-14T19:23:40 <Marchael> but I not sure about place where it should located
76 2011-06-14T19:23:46 <Marchael> *locate
77 2011-06-14T19:24:05 <ThomasWaldmann> it must be inside the class definition
78 2011-06-14T19:24:18 <ThomasWaldmann> like the other config attributes also
79 2011-06-14T19:24:34 <ThomasWaldmann> btw, that stuff is documented :)
80 2011-06-14T19:24:44 <ThomasWaldmann> (not index_dir, of course, but in general)
81 2011-06-14T19:24:55 <Marchael> ok
82 2011-06-14T19:25:49 <ThomasWaldmann> the error you are seeing in that traceback always happens if there is no app, btw
83 2011-06-14T19:26:11 <Marchael> then I should use LocalConfig.index_dir?
84 2011-06-14T19:26:16 <ThomasWaldmann> (and similar error happen if there is no request or no flask.g or whatever)
85 2011-06-14T19:26:32 <ThomasWaldmann> that stuff is only there while the app / request is running
86 2011-06-14T19:26:48 <ThomasWaldmann> you use app.cfg.index_dir in the code
87 2011-06-14T19:26:56 <ThomasWaldmann> and in the config:
88 2011-06-14T19:27:07 <ThomasWaldmann> class LocalConfig(Config):
89 2011-06-14T19:27:19 <ThomasWaldmann> index_dir = '/...'
90 2011-06-14T19:29:26 <ThomasWaldmann> (a running app / request does not necessarily mean that the wiki server is running or that some user used his browser and clicked somewhere)
91 2011-06-14T19:30:22 <ThomasWaldmann> it can also be due to some test_request running for testing purposes, or because you used flask-script to create such a "running environment"
92 2011-06-14T19:31:19 <ThomasWaldmann> so, just remember - if you see something similar to this:
93 2011-06-14T19:31:22 <ThomasWaldmann> current_app = LocalProxy(lambda: _request_ctx_stack.top.app)
94 2011-06-14T19:31:22 <ThomasWaldmann> AttributeError: 'NoneType' object has no attribute 'app'
95 2011-06-14T19:31:50 <ThomasWaldmann> it means that there is no app currently
96 2011-06-14T19:32:41 <ThomasWaldmann> which, for the time of config-loading is natural, because the config is used to start the app
97 2011-06-14T19:33:21 <Marchael> but how can i access to LocalConfig.index_dir?
98 2011-06-14T19:33:28 <ThomasWaldmann> see MoinMoin/__init__.py create_app if you are interested in the details
99 2011-06-14T19:33:41 <ThomasWaldmann> (19:26) < ThomasWal> you use app.cfg.index_dir in the code
100 2011-06-14T19:33:45 <Marchael> I try import LocalConfigm but failed
101 2011-06-14T19:34:02 <Marchael> no
102 2011-06-14T19:34:06 <ThomasWaldmann> from flask import current_app as app
103 2011-06-14T19:34:08 <Marchael> I removed app.cfg
104 2011-06-14T19:34:24 <ThomasWaldmann> try it. if you do what I said, it'll work :)
105 2011-06-14T19:34:41 <Marchael> http://paste.pocoo.org/show/407655/
106 2011-06-14T19:34:55 <ThomasWaldmann> you can also grep for app.cfg, there are many places it is used like this
107 2011-06-14T19:35:01 <Marchael> ok
108 2011-06-14T19:36:06 <ThomasWaldmann> http://paste.pocoo.org/show/407655/ except for that it is still putting index files into the code, that is ok. if you are not careful, it might kill your code. :P
109 2011-06-14T19:36:39 <Marchael> oops
110 2011-06-14T19:37:40 <ThomasWaldmann> wiki/index is a nice place
111 2011-06-14T19:38:42 <Marchael> ok
112 2011-06-14T19:39:03 <ThomasWaldmann> later, if that stuff starts working, you can even compute that directory based on some other configured directory
113 2011-06-14T19:39:05 <Marchael> but error sill appears, import LocalConfig doesn't make sense
114 2011-06-14T19:39:20 <ThomasWaldmann> traceback
115 2011-06-14T19:39:34 <Marchael> not it is NameError: global name 'index_dir' is not defined
116 2011-06-14T19:39:36 <Marchael> sec
117 2011-06-14T19:39:56 <ThomasWaldmann> and btw, directories usually have no / at the end
118 2011-06-14T19:40:00 <Marchael> http://paste.pocoo.org/show/407657/
119 2011-06-14T19:40:32 <ThomasWaldmann> print app.cfg.index_dir
120 2011-06-14T19:41:08 <Marchael> AttributeError: 'Config' object has no attribute 'index_dir'
121 2011-06-14T19:41:28 <dreimark> http://hg.moinmo.in/moin/2.0/file/37c117ad8f7e/MoinMoin/config/__init__.py
122 2011-06-14T19:41:36 <ThomasWaldmann> ehrm. that sounds like it is not using your config
123 2011-06-14T19:42:04 <dreimark> hmm, i should look into Marchael repo
124 2011-06-14T19:42:21 <ThomasWaldmann> dreimark: that's not for user configurable stuff, rather for builtin constants
125 2011-06-14T19:43:30 <Marchael> but i put from wikiconfig_editme import * to wikiconfig_local.py
126 2011-06-14T19:44:40 *** greg_f
127 2011-06-14T19:44:52 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0/file/37c117ad8f7e/wikiconfig.py#l99 do you also have the stuff from line 99 and 100?
128 2011-06-14T19:45:52 <ThomasWaldmann> because MOINCFG is how this stuff gets into the flask app called moin :)
129 2011-06-14T19:46:44 <ThomasWaldmann> (it's a bit weird, but flask wants uppercase variables only and so we need that trick)
130 2011-06-14T19:48:45 <Marchael> yes, I have that line but it sets to MOINCFG = Config
131 2011-06-14T19:49:09 <Marchael> and my config calling LocalConfig
132 2011-06-14T19:50:04 <dreimark> I wonder a bit how about that works, the only line where I find index_dir is https://bitbucket.org/marchael/moin-2.0/src/21860894d4dd/MoinMoin/search/indexing.py#cl-61
133 2011-06-14T19:50:13 <Marchael> btw, I tried rename it to LocalConfig but get NameError: name 'LocalConfig' is not defined
134 2011-06-14T19:51:13 <Marchael> dreimark: it's directory which stores whoosh's index files
135 2011-06-14T19:51:23 <Marchael> but user can set it to whatever
136 2011-06-14T19:51:41 <dreimark> Marchael: that is what i understand
137 2011-06-14T19:51:44 <Marchael> for example for test i specify altenative directory
138 2011-06-14T19:53:03 <dreimark> there you do index_object = WhooshIndex(index_dir=self.index_dir)
139 2011-06-14T19:55:57 <Marchael> index_object a referer to class with 2 opening index writers
140 2011-06-14T19:56:14 <Marchael> one for all revs schema and another for latest rev schema
141 2011-06-14T19:56:30 <Marchael> s/schema/indxes/
142 2011-06-14T19:59:07 <dreimark> Marchael: http://paste.pocoo.org/show/407667/
143 2011-06-14T19:59:24 <dreimark> that's what I have in wiiconfig_editme.py
144 2011-06-14T19:59:48 <Marchael> yes, I'm using same format
145 2011-06-14T20:00:12 <dreimark> and what can I do to reproduce the problem now?
146 2011-06-14T20:00:40 <Marchael> cool, that stuff working now
147 2011-06-14T20:00:53 <dreimark> Marchael: make a diff to yours and tell
148 2011-06-14T20:01:08 <Marchael> I'm used wrong value when tried to create WhooshIndex objexct
149 2011-06-14T20:01:44 <dreimark> in the wikiconfig ?
150 2011-06-14T20:02:15 <Marchael> no, in MoinMoin/script/maint/build_indexes.py
151 2011-06-14T20:02:48 <Marchael> (build_indexes is script for rebuilding indexes from backend)
152 2011-06-14T20:03:44 <dreimark> ah ok
153 2011-06-14T20:06:24 <ThomasWaldmann> the directions in the wikiconfig are rather clear. don't do it differently without good reason.
154 2011-06-14T20:07:12 * Marchael brb in 20 minutes
155 2011-06-14T20:18:01 *** sinha
156 2011-06-14T20:18:09 *** sinha
157 2011-06-14T21:21:20 *** brunomartin
158 2011-06-14T21:23:28 <brunomartin> Hi!
159 2011-06-14T21:24:49 <dreimark> http://ep2011.europython.eu/conference/talks/debugging-and-profiling-techniques
160 2011-06-14T21:28:47 <ThomasWaldmann> moin brunomartin
161 2011-06-14T21:29:10 <ThomasWaldmann> dreimark: already bookmarked :)
162 2011-06-14T21:29:44 <brunomartin> I'm getting starting with moin 2! I'm trying to make template for specific content type, as begging...
163 2011-06-14T21:30:03 <ThomasWaldmann> cool :)
164 2011-06-14T21:30:27 <ThomasWaldmann> if you have questions, just ask
165 2011-06-14T21:33:07 <Marchael> this flask-script build indexes http://paste.pocoo.org/show/407727/ but it has strange traceback http://paste.pocoo.org/show/407728/
166 2011-06-14T21:33:16 <Marchael> but uuid field is unique!
167 2011-06-14T21:34:42 <Marchael> oops, /me make a big mistake :)
168 2011-06-14T21:35:12 <brunomartin> I did not figure out how to do it... I start to explore the code today, I found item.Binary.get_templates function that take then, but, how can a create these templates?
169 2011-06-14T21:35:30 <Marchael> ThomasWaldmann: any ideas how to improve 23,24
170 2011-06-14T21:35:32 <Marchael> ?
171 2011-06-14T21:37:04 <ThomasWaldmann> Marchael: does that code work on 2.6?
172 2011-06-14T21:37:22 <Marchael> I don't try
173 2011-06-14T21:37:36 <ThomasWaldmann> you are required to write code that runs on 2.6
174 2011-06-14T21:37:47 <ThomasWaldmann> the easiest way to do that is to use 2.6
175 2011-06-14T21:38:32 <ThomasWaldmann> brunomartin: the global templates are located in MoinMoin/templates
176 2011-06-14T21:39:20 <ThomasWaldmann> ehrm, sorry, that's not what you meant
177 2011-06-14T21:39:36 <ThomasWaldmann> the wiki item templates are created like normal items
178 2011-06-14T21:40:08 <ThomasWaldmann> the only thing special about them is that they are tagged 'template'
179 2011-06-14T21:40:34 <Marchael> there is a code which seems work correct http://paste.pocoo.org/show/407735/
180 2011-06-14T21:40:47 <ThomasWaldmann> there is no UI currently to set tags, but you can just add 'tags': ['template'] to the metadata json
181 2011-06-14T21:40:53 <Marchael> now try to test it on 2.6
182 2011-06-14T21:40:56 <ThomasWaldmann> brunomartin: ^^
183 2011-06-14T21:41:01 <Marchael> *trying
184 2011-06-14T21:44:54 <ThomasWaldmann> Marchael: that code is pretty inefficient
185 2011-06-14T21:45:49 <Marchael> let me put it to codereview
186 2011-06-14T21:46:54 <Marchael> http://codereview.appspot.com/4539114/patch/27001/13002
187 2011-06-14T21:49:24 <brunomartin> ThomasWaldmann: thanks! :-) I'm gonna put that on configure.rst, may I?
188 2011-06-14T21:52:16 <dreimark> we plan to have an ui for that
189 2011-06-14T21:53:47 *** dreimark
190 2011-06-14T21:58:34 *** dreimark
191 2011-06-14T21:59:13 <brunomartin> I got it...
192 2011-06-14T21:59:44 *** dreimark
193 2011-06-14T21:59:44 *** dreimark
194 2011-06-14T21:59:59 <Marchael> ThomasWaldmann: thx!
195 2011-06-14T22:00:48 <ThomasWaldmann> brunomartin: that rather using, not configuring. but yes, we'll need more docs. but this stuff is still a bit in flux.
196 2011-06-14T22:02:25 <ThomasWaldmann> brunomartin: if you like, you could write some docs about metadata. I'ld proofread it.
197 2011-06-14T22:03:26 <ThomasWaldmann> Marchael: which revno do you get as last list item?
198 2011-06-14T22:03:43 <Marchael> 2 iirc
199 2011-06-14T22:03:53 <Marchael> {0,1,2}
200 2011-06-14T22:04:25 <ThomasWaldmann> so it is the latest rev's rev_no? :)
201 2011-06-14T22:05:21 <Marchael> Should I enlarge number of revisions?
202 2011-06-14T22:06:01 <dreimark> is that loading all data for indexing?
203 2011-06-14T22:06:22 <ThomasWaldmann> Marchael: why?
204 2011-06-14T22:06:43 * Marchael just guessed
205 2011-06-14T22:07:20 <ThomasWaldmann> dreimark: full index build
206 2011-06-14T22:08:35 <brunomartin> ThomasWaldmann: yeah, I can do that. I wanna try to make some relations between items using metadata, for listing pages and so on... while I study it, I can doc it too!
207 2011-06-14T22:08:37 <Marchael> getattr(index_object, index_object.indexes[0][0])
208 2011-06-14T22:08:37 <Marchael> It is ugly, I know. But I think what if we need to change index name of all or latest revisions we should change it here also
209 2011-06-14T22:09:58 <dreimark> may be it should do that in an append mode and start with the simple content type
210 2011-06-14T22:10:42 <dreimark> or make the smallest first
211 2011-06-14T22:11:09 <dreimark> how much memory is needed for that?
212 2011-06-14T22:12:37 <Marchael> depended from backend size I guess
213 2011-06-14T22:13:53 <dreimark> I asked that because you can have lots of items in a serialized process
214 2011-06-14T22:14:19 <dreimark> which don't need much memory at creation process
215 2011-06-14T22:22:26 <ThomasWaldmann> dreimark: what exactly is the problem?
216 2011-06-14T22:23:14 <Marchael> > You know what the latest revision is, so you just need to add_document() with its data - ONCE - instead of thousands of calls to update_document().
217 2011-06-14T22:23:14 <Marchael> But if I do so, latest_revs_index will be store all revisions of all documents
218 2011-06-14T22:23:42 <ThomasWaldmann> huh?
219 2011-06-14T22:24:03 <ThomasWaldmann> au contraire :)
220 2011-06-14T22:26:33 <Marchael> all items add to index after commit, and if I'll just add_document. They all will be store in latest indexes
221 2011-06-14T22:26:56 <Marchael> They == documents
222 2011-06-14T22:27:38 <ThomasWaldmann> for latest_revs_index, you only call add_document() once - for the last rev, of course
223 2011-06-14T22:27:58 <ThomasWaldmann> then you have exactly that in the index, no more, no less, no overhead
224 2011-06-14T22:28:25 <Marchael> ok
225 2011-06-14T22:39:39 <dreimark> ThomasWaldmann: the problem comes only or not after answering the initial question
226 2011-06-14T22:40:14 <dreimark> how much memory does it need - is it accumulating?
227 2011-06-14T22:41:18 <ThomasWaldmann> no, at least not by design of the indexing code :)
228 2011-06-14T22:42:44 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4539114/patch/13003/13004
229 2011-06-14T22:42:44 <Marchael> I already noticed about bad identation in last line :)
230 2011-06-14T22:51:17 <dreimark> gn
231 2011-06-14T22:52:06 <ThomasWaldmann> Marchael: mostly ok now, some minor improvements + the stuff you already know
232 2011-06-14T22:52:12 <Marchael> dreimark: gn
233 2011-06-14T22:52:34 <Marchael> ThomasWaldmann: thank you!
234 2011-06-14T22:53:47 <ThomasWaldmann> Marchael: btw, you don't need to tell it is using the backend, that's clear anyway
235 2011-06-14T22:54:46 <Marchael> ok
236 2011-06-14T22:58:45 <ThomasWaldmann> does it work now? :)
237 2011-06-14T23:01:49 <Marchael> yes
238 2011-06-14T23:02:01 <Marchael> btw, how about ugly code?
239 2011-06-14T23:02:15 <Marchael> I mean latest_revs_index = getattr(index_object, index_object.indexes[0][0])
240 2011-06-14T23:04:06 <Marchael> I know what [0][0] is confusing, but if someone changes WhooshIndex class he mays broke other stuff like that
241 2011-06-14T23:05:58 *** grzywacz
242 2011-06-14T23:14:17 <ThomasWaldmann> foo.bar
243 2011-06-14T23:17:53 <Marchael> and?
244 2011-06-14T23:19:35 <ThomasWaldmann> you know what you want, so you can access it directly
245 2011-06-14T23:20:48 <Marchael> yes, but what happends if in future someone wants to change it?
246 2011-06-14T23:21:44 <Marchael> I mean in WhooshIndex class
247 2011-06-14T23:22:04 <ThomasWaldmann> then he has to use search & replace
248 2011-06-14T23:22:15 <Marchael> hm
249 2011-06-14T23:22:36 <Marchael> ok
250 2011-06-14T23:23:16 <ThomasWaldmann> and I am not sure about the mid term fate of this WhooshIndex class anyway
251 2011-06-14T23:23:40 <ThomasWaldmann> is seems a bit to mostly get in the way and lead to confusing naming
252 2011-06-14T23:24:27 <Marchael> but we can use this class to access to opening indexes from any place in moin
253 2011-06-14T23:25:54 <ThomasWaldmann> yes, and the alternative would be about ... 2 lines of code?
254 2011-06-14T23:26:22 <ThomasWaldmann> like
255 2011-06-14T23:26:49 <ThomasWaldmann> latest_ix = open_dir(app.cfg.index_dir, 'latest')
256 2011-06-14T23:27:02 <ThomasWaldmann> all_ix = ... 'all')
257 2011-06-14T23:28:08 *** raignarok
258 2011-06-14T23:28:56 <Marchael> sounds good, may be update info on ep
259 2011-06-14T23:31:39 <Marchael> ThomasWaldmann: can I commit this http://codereview.appspot.com/4539114/patch/16004/16005 ?
260 2011-06-14T23:36:21 <ThomasWaldmann> i'ld put that comment about current rev one line higher, on an own line
261 2011-06-14T23:36:46 <ThomasWaldmann> so directly after the for loop
262 2011-06-14T23:37:09 <ThomasWaldmann> because you are using that revision is still set from the last looping
263 2011-06-14T23:38:26 <Marchael> you mean 34?
264 2011-06-14T23:39:56 <ThomasWaldmann> yes
265 2011-06-14T23:40:21 <Marchael> ok
266 2011-06-14T23:41:13 <ThomasWaldmann> and after commit please read the whoosh docs about how to do fast bulk indexing
267 2011-06-14T23:41:33 <Marchael> ok
268 2011-06-14T23:43:19 <CIA-69> Michael Mayorov <marchael@kb.csu.ru> * d5c124222533 r267 moin-2.0/MoinMoin/ (5 files in 4 dirs): Building indexes, minor fixing in schemas, add forgotten imports
269 2011-06-14T23:43:50 <ThomasWaldmann> btw, what happens to index size if you run that script twice?
270 2011-06-14T23:46:33 <Marchael> http://paste.pocoo.org/show/407822/
271 2011-06-14T23:47:23 <Marchael> hm
272 2011-06-14T23:47:37 <Marchael> after third round it 193K :)
273 2011-06-14T23:48:12 <ThomasWaldmann> i guessed it would always grow
274 2011-06-14T23:49:05 *** brunomartin
275 2011-06-14T23:49:20 <ThomasWaldmann> because you always add
276 2011-06-14T23:49:51 <Marchael> yes, need check for existing
277 2011-06-14T23:50:22 <Marchael> but now I going sleep for some time, gn
278 2011-06-14T23:50:38 <ThomasWaldmann> gn :)
279 2011-06-14T23:50:59 <ThomasWaldmann> before doing random changes tomorrow, think about what we need :)
280 2011-06-14T23:52:37 <RogerHaase> ThomasWaldmann: I updated http://codereview.appspot.com/4535086 with a workaround for Firefox and Opera middle mouse button issue. Not a perfect solution, see comments near line 839 in common.js.
281 2011-06-14T23:57:24 <ThomasWaldmann> ah, right, almost forgot. thanks for reminder :)
