1 2011-06-18T00:36:30 *** m4k3r
2 2011-06-18T02:17:22 *** sinha1
3 2011-06-18T05:23:43 *** Marchael
4 2011-06-18T09:25:19 <ThomasWaldmann> moin
5 2011-06-18T10:11:11 *** m4k3r
6 2011-06-18T10:46:10 *** greg_f
7 2011-06-18T12:23:53 *** ronny
8 2011-06-18T12:24:14 *** ronny
9 2011-06-18T12:43:45 *** grzywacz
10 2011-06-18T12:43:45 *** grzywacz
11 2011-06-18T12:54:49 *** m4k3r
12 2011-06-18T13:02:00 *** m4k3r
13 2011-06-18T13:07:04 *** m4k3r
14 2011-06-18T13:09:11 *** m4k3r
15 2011-06-18T13:20:26 *** dreimark
16 2011-06-18T13:20:26 *** dreimark
17 2011-06-18T13:49:09 *** ronny
18 2011-06-18T14:31:21 <ThomasWaldmann> xorAxAx: pkumar has no diary entries since 3d
19 2011-06-18T14:36:48 *** pkumar
20 2011-06-18T14:42:11 <ThomasWaldmann> same for Marchael, btw
21 2011-06-18T14:42:37 <ThomasWaldmann> 2d for hardy
22 2011-06-18T14:46:28 <ThomasWaldmann> http://www.doodle.com/srhzaz7h56fmb5nh if we want a new weekday/daytime, there should be more participation
23 2011-06-18T14:46:57 <ThomasWaldmann> dreimark: pkumar: waldi: xorAxAx: ^^
24 2011-06-18T14:48:20 <pkumar> ok
25 2011-06-18T14:51:56 <ThomasWaldmann> pkumar: can you check if the timezone selection works for you? what is your tz?
26 2011-06-18T14:52:38 <pkumar> IST I guess
27 2011-06-18T14:52:52 <pkumar> lemme check
28 2011-06-18T14:52:59 <pkumar> the doodle
29 2011-06-18T14:54:22 <pkumar> yeah, that is it. Asia/Kolkata
30 2011-06-18T14:55:39 <ThomasWaldmann> ok
31 2011-06-18T14:59:21 *** Marchael
32 2011-06-18T14:59:55 <Marchael> moin
33 2011-06-18T15:01:59 <pkumar> ok, done
34 2011-06-18T15:04:35 <ThomasWaldmann> moin Marchael
35 2011-06-18T15:05:15 <ThomasWaldmann> Marchael: is your diary correct?
36 2011-06-18T15:05:31 <ThomasWaldmann> Marchael: (14:46) < ThomasWal> http://www.doodle.com/srhzaz7h56fmb5nh if we want a new weekday/daytime, there should be more participation
37 2011-06-18T15:05:41 <Marchael> mm, I forgot to update it yerstaday...
38 2011-06-18T15:07:00 <Marchael> timeline in utc+2?
39 2011-06-18T15:07:27 <ThomasWaldmann> Marchael: see the timezone selection menue at the top
40 2011-06-18T15:07:50 <Marchael> o
41 2011-06-18T15:07:52 <Marchael> *ok
42 2011-06-18T15:07:52 <ThomasWaldmann> and choose YOUR tz, then it shows your localtime
43 2011-06-18T15:10:22 <Marchael> done
44 2011-06-18T15:11:32 <ThomasWaldmann> btw, ~3 weeks until midterm evals begin, I added that date to the calendars
45 2011-06-18T15:15:28 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4539114/
46 2011-06-18T15:16:28 * ThomasWaldmann added the date of final evals also
47 2011-06-18T15:16:41 <Marchael> btw, output is rather strange http://paste.pocoo.org/show/414244/
48 2011-06-18T15:16:44 <Marchael> ok
49 2011-06-18T15:22:04 <Marchael> I should write unittest for that
50 2011-06-18T15:32:18 * Marchael found an error
51 2011-06-18T15:35:41 <ThomasWaldmann> maybe first get the code into better shape
52 2011-06-18T15:38:01 <Marchael> ok
53 2011-06-18T16:14:32 <pkumar> bbl
54 2011-06-18T16:14:41 *** pkumar
55 2011-06-18T16:23:09 *** sinha
56 2011-06-18T16:25:37 <Marchael> seems now working
57 2011-06-18T16:25:46 <Marchael> there will be large changeset :)
58 2011-06-18T16:29:13 * ThomasWaldmann has nothing against larger and better changesets :)
59 2011-06-18T16:29:44 <Marchael> http://codereview.appspot.com/4539114/
60 2011-06-18T16:29:49 <Marchael> please, review
61 2011-06-18T16:35:06 *** sinha
62 2011-06-18T16:35:23 *** sinha
63 2011-06-18T16:55:33 <ThomasWaldmann> Marchael: done, quite ok, but needs more work
64 2011-06-18T16:56:00 * Marchael looks
65 2011-06-18T16:56:10 <ThomasWaldmann> you always need to consider behaviour for all cases that can happen
66 2011-06-18T16:56:20 <ThomasWaldmann> including exceptions
67 2011-06-18T17:04:09 <Marchael> ThomasWaldmann: for building-test I should commit some documents to indexes?
68 2011-06-18T17:04:31 <Marchael> or just build_index() will be enough?
69 2011-06-18T17:07:45 <ThomasWaldmann> that depends on what you want to test
70 2011-06-18T17:08:29 <ThomasWaldmann> if you just want to test create_index() [new name], it is enough to check whether there is a working index afterwards that has no content
71 2011-06-18T17:09:17 <Marchael> ok, I add some dox
72 2011-06-18T17:09:44 <ThomasWaldmann> also, if the final code is rather trivial, you maybe don't even need that test
73 2011-06-18T17:10:09 <ThomasWaldmann> keep in mind that you are testing YOUR code, not writing tests for whoosh
74 2011-06-18T17:33:19 <Marchael> ThomasWaldmann: please, review
75 2011-06-18T17:50:21 <ThomasWaldmann> Marchael: yes, me too :D
76 2011-06-18T17:50:33 <ThomasWaldmann> oops. ignore. review done.
77 2011-06-18T17:50:43 * ThomasWaldmann is away now for a while
78 2011-06-18T18:00:47 <Marchael> ThomasWaldmann: here/
79 2011-06-18T18:00:48 <Marchael> ?
80 2011-06-18T18:03:54 <Marchael> I need to go to hostel, please make review.
81 2011-06-18T18:03:57 * Marchael bbl
82 2011-06-18T18:04:07 *** pkumar
83 2011-06-18T18:04:07 *** Marchael
84 2011-06-18T19:28:39 <sinha> ThomasWaldmann: `please note that .get() has a second parameter', what changes i should do here, i mean i have used `count` as second param and was retrieving it correctly as get('count') ?
85 2011-06-18T19:38:05 *** hardy89
86 2011-06-18T19:43:27 *** greg_f
87 2011-06-18T19:53:56 *** Marchael
88 2011-06-18T19:54:22 *** ronny
89 2011-06-18T19:56:49 <Marchael> ThomasWaldmann: ping
90 2011-06-18T19:59:01 <hardy89> pkumar: what does logging do?
91 2011-06-18T20:03:18 *** ronny
92 2011-06-18T20:05:54 <pkumar> hardy89 : this might help => http://lmgtfy.com/?q=python%20logging
93 2011-06-18T20:08:10 <hardy89> pkumar: thanks. but i was asking specifically about pytest
94 2011-06-18T20:08:21 <hardy89> of MoinMoin
95 2011-06-18T20:12:44 <pkumar> weren't you planning to work on fixing the memory leak issue?
96 2011-06-18T20:13:12 <hardy89> pkumar: no. i'm not planning. I am working on that issue
97 2011-06-18T20:13:23 <hardy89> pkumar: and this is regarding that
98 2011-06-18T20:13:36 <pkumar> how so?
99 2011-06-18T20:14:06 <hardy89> pkumar: whatsoever changes i make through gc module in the main code. It does not show any changes in terminal
100 2011-06-18T20:14:15 <hardy89> Success/Failure nothing
101 2011-06-18T20:14:43 <hardy89> pkumar: i was wondering whether logging diverts it somewhere else cos that is what it is supposed to do
102 2011-06-18T20:16:17 <pkumar> try using PDB
103 2011-06-18T20:18:21 <hardy89> pkumar: ok. but at least tell me, 1. what is the coverage of logging in our code.
104 2011-06-18T20:19:02 <hardy89> 2. where it diverts all the info which is not required to?
105 2011-06-18T20:28:53 <pkumar> I'm no sure if logging has much to do with memory leakage.
106 2011-06-18T20:29:48 <pkumar> I think your main problem is that you are not able to view any changes like print statements when made in tests
107 2011-06-18T20:32:01 <hardy89> pkumar: no. there are few things which a gc module is supposed to show after a test is run.
108 2011-06-18T20:32:19 <hardy89> so that is why i need the info which i asked you
109 2011-06-18T20:33:05 <hardy89> which is actually important to me
110 2011-06-18T20:35:02 <pkumar> which gc module are you using?
111 2011-06-18T20:36:43 <hardy89> pkumar: i'm using the garbage collector interface for python
112 2011-06-18T20:43:44 <pkumar> currently it produces a stdout(standard output) like some print statements only on a test failure or some error.
113 2011-06-18T20:44:27 <hardy89> pkumar: and where is rest of the stuff gone?
114 2011-06-18T20:48:01 <pkumar> I'm not sure of it where those things go may be this is how pytest works.
115 2011-06-18T20:48:36 <pkumar> If you want to have your outputs in the test best way is to use PDB
116 2011-06-18T20:49:05 <pkumar> it is also a part of pytest. use pytest.set_trace()
117 2011-06-18T20:49:21 <hardy89> pkumar: hm. maybe my stuff goes along with it.
118 2011-06-18T20:49:30 <pkumar> after that you get an interactive interface
119 2011-06-18T20:49:47 <pkumar> so you can print or call your stuff there.
120 2011-06-18T20:49:56 <hardy89> pkumar: PDB? Google does not show some good results for it
121 2011-06-18T20:50:14 <pkumar> it is there in pytest documentation
122 2011-06-18T20:51:14 <pkumar> as I said just use pytest.set_trace() . you'll get the interface
123 2011-06-18T20:52:27 <hardy89> pkumar: will check and ask you later if i have any doubts. Thanks.
124 2011-06-18T20:52:37 <pkumar> np
125 2011-06-18T20:52:40 <pkumar> :)
126 2011-06-18T20:55:33 *** hardy89
127 2011-06-18T20:58:40 *** ronny
128 2011-06-18T21:04:00 *** ronny
129 2011-06-18T21:11:26 *** ronny
130 2011-06-18T21:16:07 *** ronny
131 2011-06-18T22:04:38 *** Marchael
132 2011-06-18T22:30:42 *** sinha
133 2011-06-18T22:30:55 *** sinha
134 2011-06-18T23:13:48 <dreimark> re
135 2011-06-18T23:14:32 * dreimark is stressed
136 2011-06-18T23:23:53 <dreimark> sinha: you can work on the navigation given from the icons first
137 2011-06-18T23:24:24 <dreimark> look at http://moinmo.in/RecentChanges
138 2011-06-18T23:24:48 <dreimark> they have to link to the different views
139 2011-06-18T23:24:57 <dreimark> also a legend of them would be nice
140 2011-06-18T23:25:04 <dreimark> small work bt
141 2011-06-18T23:25:21 <dreimark> but then Historie is similiar to the old RC
142 2011-06-18T23:25:34 <sinha> you mean use icons for the comment and contenttype
143 2011-06-18T23:25:39 <sinha> on history page
144 2011-06-18T23:27:44 <sinha> dreimark: ^^
145 2011-06-18T23:29:00 <dreimark> sinha: look at bottom of RC
146 2011-06-18T23:29:25 <dreimark> there are more icons which are also functions
147 2011-06-18T23:29:48 <dreimark> and I think in your solution they are just icons, not clickable
148 2011-06-18T23:30:41 <sinha> yes, just has to replace the texts from icons
149 2011-06-18T23:31:02 <dreimark> if you don't have a bookmark you have only 2 different kinds but with bookmark all
150 2011-06-18T23:32:13 <sinha> how ? in bookmark also item is getting grouped
151 2011-06-18T23:32:33 <sinha> only the change of that day
152 2011-06-18T23:33:01 <sinha> only the icon for latest revision action is shown
153 2011-06-18T23:33:20 <sinha> and that could be any SAVE,TRASH,RENAME,COPY
154 2011-06-18T23:33:29 <dreimark> sinha: left hand icons in RC
155 2011-06-18T23:34:08 <dreimark> yes but it should links to the view for diff
156 2011-06-18T23:35:11 <sinha> okay thats fine, but we have that diff links also in the column after contenttype
157 2011-06-18T23:35:29 <dreimark> yes, there we have all
158 2011-06-18T23:36:02 <dreimark> we can go to 5 different on the day if there where 5 the left one can do a diff over 5 revisions
159 2011-06-18T23:36:52 <dreimark> also look, if you can get the mouseover of the users name showing the same info
160 2011-06-18T23:38:45 <sinha> i mean how come the left one can do a diff over five revision ? i mean what will be it link, as simply doing +diff/item, shows the diff between last 2 revisions
161 2011-06-18T23:40:15 <dreimark> it can show only more if you have more changes on a day
162 2011-06-18T23:40:29 <dreimark> if it is only one change it shows the same as the other
163 2011-06-18T23:40:55 <dreimark> but it saves you to click on each if you want to see from first to last
164 2011-06-18T23:41:04 <dreimark> e.g.
165 2011-06-18T23:41:09 <dreimark> someone changes something
166 2011-06-18T23:41:22 <dreimark> someone continues changing
167 2011-06-18T23:41:30 <dreimark> someone maual reverts
168 2011-06-18T23:42:17 <dreimark> you can save some time seeing that the cummulative diff is empty
169 2011-06-18T23:42:35 <sinha> i am getting your point, on why to do this, but i am asking how to do this
170 2011-06-18T23:42:50 <sinha> as i said i have 5 changes for a item on a day
171 2011-06-18T23:43:00 <sinha> but when i do +diff/item
172 2011-06-18T23:43:13 <sinha> it shows the diff between rev5 and rev4
173 2011-06-18T23:43:50 <dreimark> look here http://test.moinmo.in/+history/Home
174 2011-06-18T23:44:15 <dreimark> click in diff at fist selector first line
175 2011-06-18T23:44:24 <dreimark> and at second selector last line
176 2011-06-18T23:44:29 <dreimark> then diff
177 2011-06-18T23:45:37 <sinha> okay here the rev1 is 8 and rev2 is 0
178 2011-06-18T23:45:57 <sinha> okay you want to put this rev number in that left hand diff link
179 2011-06-18T23:46:07 <dreimark> yes
180 2011-06-18T23:46:09 <sinha> okay i got it how to do
181 2011-06-18T23:46:46 <sinha> and reg icons for contenttype ?
182 2011-06-18T23:47:33 <dreimark> for now only for major type
183 2011-06-18T23:47:55 <dreimark> that needs compatible license
184 2011-06-18T23:48:09 <sinha> i mean how will i parse them, the have pretty big names
185 2011-06-18T23:48:22 <sinha> i mean if a substitute the class name for content type
186 2011-06-18T23:48:38 <dreimark> and minor type I am not sure maybe by color or on mouseover
187 2011-06-18T23:49:52 <dreimark> there is a lib which can split major from minor type
188 2011-06-18T23:50:14 <ThomasWaldmann> MoinMoin.util.mime or so, Type class
189 2011-06-18T23:51:15 <sinha> okay, you mean for the type `text/x.moin.wiki` what i will get as output after splitting ?
190 2011-06-18T23:52:09 <dreimark> look at that lib
191 2011-06-18T23:52:57 <dreimark> I have to organize my luggage
192 2011-06-18T23:53:11 <ThomasWaldmann> you will get "text" and "x.moin.wiki"
193 2011-06-18T23:53:26 <ThomasWaldmann> (and charset and other params)
194 2011-06-18T23:53:49 <ThomasWaldmann> btw, iirc i already coded some mapping from mimetypes to css class
195 2011-06-18T23:56:45 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0/file/37c117ad8f7e/MoinMoin/util/mime.py#l10
196 2011-06-18T23:58:41 <sinha> i am seeing it in global index
197 2011-06-18T23:58:49 <dreimark> sinha: i answer later to the mail
198 2011-06-18T23:58:53 <sinha> okay
