1 2011-07-21T00:56:24 *** ronny
2 2011-07-21T01:01:40 *** ronny
3 2011-07-21T02:40:29 *** MattMaker
4 2011-07-21T03:32:57 *** MattMaker
5 2011-07-21T06:06:08 <Marchael> moin
6 2011-07-21T06:07:19 <Marchael> I'm trying to create to hidden fields "pagenum" and "pagelen" but get this traceback http://paste.pocoo.org/show/443293/
7 2011-07-21T06:07:19 <Marchael> my code http://codereview.appspot.com/4802048
8 2011-07-21T06:07:32 <Marchael> *two hidden
9 2011-07-21T06:08:52 <Marchael> I'm need a way to pass this 2 arguments to SearchForm
10 2011-07-21T06:14:16 <Marchael> I have added this 2 fields to views.py http://codereview.appspot.com/4802048 Patchset 2, but not sure what it's correct
11 2011-07-21T06:44:23 <Marchael> ThomasWaldmann: I made result stats http://i.imgur.com/p5z0X.png
12 2011-07-21T06:47:59 <Marchael> http://codereview.appspot.com/4802048 Patchset 3
13 2011-07-21T06:49:22 <Marchael> ah, I forgot add runtime
14 2011-07-21T06:49:33 *** Marchael
15 2011-07-21T06:49:37 *** Marchael
16 2011-07-21T06:55:53 <Marchael> http://i.imgur.com/07F22.png
17 2011-07-21T06:57:07 <Marchael> http://codereview.appspot.com/4802048/ patchset 4
18 2011-07-21T07:08:47 <Marchael> bbl
19 2011-07-21T07:16:51 *** Marchael
20 2011-07-21T08:43:11 *** pkumar
21 2011-07-21T09:06:24 <dreimark> moin
22 2011-07-21T09:11:35 <pkumar> dreimark : hi, can you please check the results of test_backends_fs2 with py.test 1. I just wanna sure that those errors are not due to pytest2 and also not due to some env problems in my system
23 2011-07-21T09:13:06 <pkumar> in storage module
24 2011-07-21T09:20:36 <dreimark> moin
25 2011-07-21T09:22:22 * dreimark looks
26 2011-07-21T09:22:50 <dreimark> but anyway you can have also a second checkout of the common moin-2 for testing this too
27 2011-07-21T09:26:43 <pkumar> dreimark : do you mean checking the default repo with pytest1?
28 2011-07-21T09:27:07 <dreimark> pkumar: yes, you can have a second clone of that and a second env
29 2011-07-21T09:28:11 <pkumar> dreimark : yeah, I did that and found the errors in that too. So, seems like those errors are not due to pytest2.
30 2011-07-21T09:30:39 <pkumar> dreimark : what should _rollback_item do exactly? does it remove the 'item' form backend #backends.fs2
31 2011-07-21T09:30:52 <pkumar> from*
32 2011-07-21T09:31:46 <dreimark> from the scope of hg backend it should do rollback the last action
33 2011-07-21T09:32:18 <dreimark> we have to look into the source of backends.fs2
34 2011-07-21T09:32:20 <ThomasWaldmann> it is the opposite of commit
35 2011-07-21T09:34:16 <pkumar> but I'm not sure if it really removes a item from the backend, in case a new item is created before rollback.
36 2011-07-21T09:34:33 <pkumar> test_new_item_create_revision() in test_backends
37 2011-07-21T09:36:56 <pkumar> for fs2
38 2011-07-21T09:39:32 <ThomasWaldmann> well, obviously the test wants to test that it does not exist
39 2011-07-21T09:45:29 <ThomasWaldmann> and the fs2 code also looks like that
40 2011-07-21T09:47:53 <pkumar> ThomasWaldmann : yeah, but I trace the test, it shows that the item still exist. Though on the use of item.destroy, removes it
41 2011-07-21T09:48:47 <pkumar> thats the reason that test also fails for me
42 2011-07-21T10:10:16 <ThomasWaldmann> well, find out what happens exactly
43 2011-07-21T10:12:28 <pkumar> ok, thanks
44 2011-07-21T10:14:34 <pkumar> xorAxAx : hi, as you had suggested, working on fixing errors in storage.
45 2011-07-21T10:15:26 <pkumar> xorAxAx : I've added tests to util, I mean as the work of the last week
46 2011-07-21T10:15:47 <xorAxAx> ok
47 2011-07-21T10:18:31 <pkumar> xorAxAx : ep updated
48 2011-07-21T11:15:06 *** pkumar
49 2011-07-21T11:22:21 <ThomasWaldmann> dreimark: btw, marchael might contact sinha because of the (search results) paging stuff
50 2011-07-21T11:22:42 <ThomasWaldmann> i didn't follow it closely, is there some reusable paging widget now?
51 2011-07-21T11:53:26 *** greg_f
52 2011-07-21T13:42:27 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 294:5158f027bb3f 2.0/MoinMoin/ (apps/frontend/views.py converter/__init__.py): (log message trimmed)
53 2011-07-21T13:42:27 <CIA-114> use converters to convert a rev to indexable content
54 2011-07-21T13:42:27 <CIA-114> revision data may contain all sorts of content-types, e.g.:
55 2011-07-21T13:42:27 <CIA-114> - markup text (moin, creole, docbook, rst, html, ...)
56 2011-07-21T13:42:27 <CIA-114> - plain text (code, docs, ...)
57 2011-07-21T13:42:27 <CIA-114> - images, audio
58 2011-07-21T13:42:28 <CIA-114> - archives and other binary stuff
59 2011-07-21T13:47:43 <ThomasWaldmann> ...
60 2011-07-21T13:48:04 <ThomasWaldmann> if someone is bored: we need a dom -> simple indexable text converter
61 2011-07-21T14:02:40 * dreimark is currently busy at work
62 2011-07-21T14:02:47 <dreimark> I send a mail to him
63 2011-07-21T15:24:31 *** Marchael
64 2011-07-21T16:21:55 <ThomasWaldmann> hi Marchael
65 2011-07-21T16:22:09 <ThomasWaldmann> see review and my recent commit to main repo
66 2011-07-21T16:25:30 <Marchael> moin
67 2011-07-21T16:25:32 <Marchael> ok
68 2011-07-21T16:28:47 <Marchael> I guess that better leave "pagenum" and "pagelen" as is. User may try to choose other page or extends selection
69 2011-07-21T16:29:17 <Marchael> that's why I made their hidden
70 2011-07-21T16:29:37 <Marchael> Althought, for "value" better use constants
71 2011-07-21T16:40:34 <ThomasWaldmann> Marchael: such stuff has to be done by a control on the search results page, note via the single-entry search field at top right
72 2011-07-21T16:40:49 <Marchael> yes, I get it.
73 2011-07-21T16:40:50 <ThomasWaldmann> but as i said, ask sinha, he worked on paging
74 2011-07-21T16:41:18 * ThomasWaldmann would be happy not to get n different paging control widgets with n*N different bugs
75 2011-07-21T16:41:43 <Marchael> but how I can integrate sinha's widget to my code?
76 2011-07-21T16:42:05 <ThomasWaldmann> i have no idea how far he got with that, ask sinha and dreimark
77 2011-07-21T16:42:32 <ThomasWaldmann> if it is not ready yet, just don't do paging and set length to a rather high value
78 2011-07-21T16:42:35 <Marchael> dreimark: ^
79 2011-07-21T16:42:50 <ThomasWaldmann> (like 100 or so)
80 2011-07-21T16:43:33 <ThomasWaldmann> if one gets more than 100 results one usually rather wants to refine the search and not look through more than 100 results
81 2011-07-21T16:44:57 * ThomasWaldmann continues review on CR
82 2011-07-21T16:45:00 <Marchael> hm, may be I will use moin navigation widget for now?
83 2011-07-21T16:48:44 <ThomasWaldmann> ok, review done
84 2011-07-21T16:49:09 <ThomasWaldmann> you will talk with sinha so you both use the same widget.
85 2011-07-21T16:49:24 <ThomasWaldmann> i just said that I do not want multiple implementations for the same thing.
86 2011-07-21T16:50:08 <ThomasWaldmann> and until that is cleared you just don't do paging.
87 2011-07-21T16:57:39 *** sinha
88 2011-07-21T16:59:00 <Marchael> sinha: hi, may I use your page navigation widget for showing search results?
89 2011-07-21T17:02:24 <sinha> Marchael: I have used one in item history
90 2011-07-21T17:02:28 <sinha> let me give the link
91 2011-07-21T17:09:22 <Marchael> ThomasWaldmann: where I can define constant for resultlen? in MoinMoin.config?
92 2011-07-21T17:17:41 <sinha> Marchael: see this https://bitbucket.org/sinha/moin2/src/fa1b9282a3ac/MoinMoin/apps/frontend/views.py#cl-596 and https://bitbucket.org/sinha/moin2/src/fa1b9282a3ac/MoinMoin/templates/history.html#cl-5
93 2011-07-21T17:20:56 <Marchael> sinha: mm, your widget integrated with history?
94 2011-07-21T17:21:14 <Marchael> can I use it from other place?
95 2011-07-21T17:21:48 <dreimark> that should be become a widget so it is not tied to one view
96 2011-07-21T17:23:10 <sinha> Marchael: i just had to use in history, if i would have to use it in other places, i would have made a different function
97 2011-07-21T17:23:10 <dreimark> brb
98 2011-07-21T17:23:11 <sinha> so now its only there
99 2011-07-21T17:23:33 <dreimark> sinha: we asked for doing it as a widget
100 2011-07-21T17:23:44 <dreimark> so that it can be used on many places
101 2011-07-21T17:25:19 <Marchael> sinha: could you make separate function so I can use it?
102 2011-07-21T17:27:18 <sinha> dreimark: yes, but you told me to do when i need it at somewhere else
103 2011-07-21T17:27:30 <sinha> dreimark: okay, i have some uncommitted changes in my repo, i will do it after that
104 2011-07-21T17:27:48 <sinha> Marchael: yes i will, when do you need it ? i mean , i am working on something else, and thus have some uncommitted changes
105 2011-07-21T17:28:53 <sinha> so i wanted to complete it first
106 2011-07-21T17:29:10 <Marchael> sinha: I'll be happy if you do it this week
107 2011-07-21T17:29:24 <Marchael> until friday at least
108 2011-07-21T17:29:49 <Marchael> s/friday/sunday/
109 2011-07-21T17:30:25 <sinha> Marchael: okay i will try
110 2011-07-21T17:31:10 <sinha> :)
111 2011-07-21T17:31:25 <sinha> definitely
112 2011-07-21T17:32:33 *** sinha
113 2011-07-21T17:39:42 <Marchael> ThomasWaldmann: for first time I try to copy-paste sihna`s widet code from history and insert it to search-result
114 2011-07-21T17:47:51 <ThomasWaldmann> Marchael: it doesn't make sense to configure a constant for result len in the config. for now, just hardcode it, later there should be a ui element.
115 2011-07-21T17:48:15 <dreimark> sinha it run out of focus because for the index page because of the index letters
116 2011-07-21T17:49:22 <Marchael> ThomasWaldmann: ok, but what about navigating?
117 2011-07-21T17:50:05 <ThomasWaldmann> do you read and understand what I say?
118 2011-07-21T17:51:29 <ThomasWaldmann> (16:47) < ThomasWal> i just said that I do not want multiple implementations for the same thing.
119 2011-07-21T17:51:32 <ThomasWaldmann> (16:48) < ThomasWal> and until that is cleared you just don't do paging.
120 2011-07-21T17:53:40 <Marchael> where is it'll be cleared?
121 2011-07-21T17:55:47 <ThomasWaldmann> when you and sinha have a common widget
122 2011-07-21T17:56:18 <Marchael> ok, I wait for sihna's widget
123 2011-07-21T17:56:43 <Marchael> *sinha's
124 2011-07-21T18:10:03 <dreimark> hmm, i am asking myself currently if the mimetype matters for just downloading
125 2011-07-21T18:10:41 <dreimark> if I force the mimtype to content_type = "text/x.moin.wiki.download"
126 2011-07-21T18:11:34 <dreimark> for the multi download I just have to assign only one mimetype for downloading all kinds of items
127 2011-07-21T18:11:45 <dreimark> for storing locally
128 2011-07-21T18:17:34 <ThomasWaldmann> try application/octet-stream
129 2011-07-21T18:21:34 <dreimark> this makes no change for chromium-browser but firefox wants for each then the ok button
130 2011-07-21T18:38:07 <ThomasWaldmann> dreimark: can't one say "always do this action for this filetype"?
131 2011-07-21T18:38:39 <ThomasWaldmann> because for that mimetype, viewing usually makes no sense (except if it uses extension to make up the mimetype then)
132 2011-07-21T18:40:34 *** raignarok
133 2011-07-21T18:51:22 <dreimark> ThomasWaldmann: exactly this is missing for application/octet-stream
134 2011-07-21T18:51:58 <dreimark> it should offer to not ask again and just download
135 2011-07-21T18:52:21 <dreimark> chromium browser behaves completly different
136 2011-07-21T18:53:56 <dreimark> bbö
137 2011-07-21T18:53:59 <dreimark> l
138 2011-07-21T20:00:42 <Marchael> ThomasWaldmann: I have some playing with css and now http://i.imgur.com/PPMb8.png
139 2011-07-21T20:01:15 <Marchael> Now I'm working on highlighting headings
140 2011-07-21T20:01:50 <Marchael> Content doesn't showing so far but I will add this later
141 2011-07-21T20:17:36 *** greg_f
142 2011-07-21T20:41:45 <Marchael> ThomasWaldmann: I having troubles with highlighting http://paste.pocoo.org/show/443711/
143 2011-07-21T20:41:45 <Marchael> code: http://codereview.appspot.com/4802048/diff2/10001:16001/MoinMoin/apps/frontend/views.py
144 2011-07-21T20:42:11 <Marchael> I think what this problem related with item_name_analazyer
145 2011-07-21T21:37:51 <Marchael> gn/bbl
146 2011-07-21T23:02:34 <ThomasWaldmann> re
