1 2011-08-03T00:09:30  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5788:89882824b375 1.9/MoinMoin/action/PackagePages.py: avoid strange exception in zipfile.py for pre-1980 timestamps
   2 2011-08-03T00:17:45  *** raignarok has quit IRC
   3 2011-08-03T01:08:29  *** m4k3r has quit IRC
   4 2011-08-03T01:25:26  <dreimark> gn
   5 2011-08-03T04:20:48  <Marchael> moin
   6 2011-08-03T05:03:23  *** MattMaker has quit IRC
   7 2011-08-03T05:42:44  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 293e27b399b7 r378 moin-2.0/MoinMoin/ (3 files in 3 dirs): Showing highlighted results on search results page
   8 2011-08-03T05:42:45  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 42f7af473347 r379 moin-2.0/MoinMoin/script/maint/index.py: Fix issue with indexing users in backend
   9 2011-08-03T06:32:06  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0337d76bd420 r380 moin-2.0/MoinMoin/converter/ (xml_in.py opendocument_in.py): add generic text/xml input converter (for indexing only), reuse code from there in ODF converter
  10 2011-08-03T06:32:07  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1fb3bf63594b r381 moin-2.0/MoinMoin/converter/opendocument_in.py: add support for old openoffice *.sx? formats (same code as we use for ODF)
  11 2011-08-03T06:32:07  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 41a22e9dae75 r382 moin-2.0/ (setup.py MoinMoin/converter/pdf_in.py): pdf indexable text content extraction using pdfminer
  12 2011-08-03T06:32:08  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 1ed44f76458c r383 moin-2.0/ (4 files in 2 dirs): merged
  13 2011-08-03T06:32:08  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0ab852761ff2 r384 moin-2.0/MoinMoin/apps/frontend/views.py: Using Multifield parser for searching in revisions name and content
  14 2011-08-03T06:48:05  *** MattMaker has joined #moin-dev
  15 2011-08-03T07:32:41  *** pkumar has joined #moin-dev
  16 2011-08-03T08:41:09  <ThomasWaldmann> moin
  17 2011-08-03T08:41:24  <ThomasWaldmann> hi Marchael, we've to talk about https://bitbucket.org/marchael/moin-2.0/changeset/42f7af473347
  18 2011-08-03T08:43:21  <ThomasWaldmann> 85 list_revisions() can be a bit too expensive and you don't really need it for what you want to achieve
  19 2011-08-03T08:45:56  <ThomasWaldmann> so, what you really want to do is to catch the NoSuchRevision exception you get from item.get_revision(-1) and "continue" in that case
  20 2011-08-03T08:46:50  <ThomasWaldmann> 187 unclean changeset, you still don't review hg diff carefully
  21 2011-08-03T08:47:51  <ThomasWaldmann> 205 unclean changeset, --""-- (that change is unrelated to what you said in the commit comment)
  22 2011-08-03T08:53:38  <ThomasWaldmann> 70 checking locals() for that is a bit strange. what you really want is to check the list of revision before line 64 and continue if it is empty.
  23 2011-08-03T08:57:00  <ThomasWaldmann> commit comment "Fix issue with indexing users in backend" - this comment can be improved. you did not really say what the issue was (but you should).
  24 2011-08-03T08:59:40  <ThomasWaldmann> https://bitbucket.org/marchael/moin-2.0/changeset/14a9f545934d why is removing 411 correct?
  25 2011-08-03T09:11:48  <Marchael> re
  26 2011-08-03T09:19:28  <Marchael> 411 is correct, but we waste our time, because we already have converted_rev earlier
  27 2011-08-03T09:19:59  <Marchael> and that line generate strange traceback
  28 2011-08-03T09:20:06  <Marchael> *tracebacks
  29 2011-08-03T09:20:08  <ThomasWaldmann> but you have different metadata fields for latest rev than for all revs
  30 2011-08-03T09:20:44  <ThomasWaldmann> so conversion result could be different, right?
  31 2011-08-03T09:20:50  <Marchael> yes
  32 2011-08-03T09:21:05  <Marchael> but content unavailable
  33 2011-08-03T09:21:29  <ThomasWaldmann> hm?
  34 2011-08-03T09:21:50  <Marchael> so first time when I call backend_to_index() for all revs it's return converted revision with content
  35 2011-08-03T09:22:08  <Marchael> but in that case I haven't content
  36 2011-08-03T09:22:35  * Marchael not quite understand what may cause that
  37 2011-08-03T09:22:59  <ThomasWaldmann> the initial question was whether removing 411 was correct
  38 2011-08-03T09:23:23  <ThomasWaldmann> it think it was not because fields might be different
  39 2011-08-03T09:24:57  <ThomasWaldmann> i* ...
  40 2011-08-03T09:28:27  <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/451757/ I return 411 back
  41 2011-08-03T09:29:34  <Marchael> Althought, for all revisions content was indexed correct
  42 2011-08-03T09:29:58  <ThomasWaldmann> 18 and 21?
  43 2011-08-03T09:30:25  <ThomasWaldmann> doesn't look like "latest" only
  44 2011-08-03T09:30:34  <Marchael> default xml item
  45 2011-08-03T09:31:13  <ThomasWaldmann> hm?
  46 2011-08-03T09:31:16  <Marchael> 18
  47 2011-08-03T09:31:30  <Marchael> We already talk about uuid problem
  48 2011-08-03T09:31:45  <ThomasWaldmann> 8 no content indexed
  49 2011-08-03T09:32:10  <ThomasWaldmann> ah, right
  50 2011-08-03T09:32:21  <ThomasWaldmann> ok, so for now, add 411 back
  51 2011-08-03T09:32:44  <Marchael> but then we can't index content
  52 2011-08-03T09:32:52  <Marchael> because without that it's working
  53 2011-08-03T09:33:13  <ThomasWaldmann> how is that related?
  54 2011-08-03T09:33:29  <ThomasWaldmann> and no, content search is not working
  55 2011-08-03T09:33:46  <Marchael> why?
  56 2011-08-03T09:34:38  <Marchael> I can search for some contenttypes now
  57 2011-08-03T09:34:45  <Marchael> *in some
  58 2011-08-03T09:35:47  <ThomasWaldmann> i said content, not contenttype
  59 2011-08-03T09:36:23  <ThomasWaldmann> i can see with +indexable view what it could put into index
  60 2011-08-03T09:36:37  <ThomasWaldmann> but i don't get results when searching for some word i see there
  61 2011-08-03T09:37:09  <ThomasWaldmann> but first commit that 411 fix then we'll see again
  62 2011-08-03T09:37:39  <Marchael> if you search in default items, may I see your query?
  63 2011-08-03T09:38:07  <Marchael> it'll helpful for bug testing
  64 2011-08-03T09:38:08  <ThomasWaldmann> No results for 'markup'
  65 2011-08-03T09:39:52  <Marchael> mm
  66 2011-08-03T09:39:58  <Marchael> but I see results
  67 2011-08-03T09:41:20  <Marchael> http://i.imgur.com/57wLO.png
  68 2011-08-03T09:42:43  <ThomasWaldmann> $ moin index --action build --for both
  69 2011-08-03T09:42:56  <ThomasWaldmann>   File "/home/tw/w/moin-2.0-whoosh/MoinMoin/storage/backends/indexing.py", line 411, in add_rev_whoosh
  70 2011-08-03T09:42:59  <ThomasWaldmann>     logging.debug("LATEST: Updating %s %s from last", converted_rev[UUID], converted_rev["rev_no"])
  71 2011-08-03T09:43:03  <ThomasWaldmann> UnboundLocalError: local variable 'converted_rev' referenced before assignment
  72 2011-08-03T09:43:15  <ThomasWaldmann> so, just add that line back and commit
  73 2011-08-03T09:55:40  <ThomasWaldmann> Marchael: ^^
  74 2011-08-03T09:58:42  <Marchael> ok ok
  75 2011-08-03T09:59:02  <Marchael> I just leave for some time and will do it.
  76 2011-08-03T09:59:27  <ThomasWaldmann> hmpf, latency
  77 2011-08-03T10:01:41  * ThomasWaldmann fixes it locally for himself in 5 secs instead of waiting
  78 2011-08-03T10:03:32  <ThomasWaldmann> and suddenly search starts to work again
  79 2011-08-03T10:38:22  *** greg_f has joined #moin-dev
  80 2011-08-03T10:50:33  <Marchael> re
  81 2011-08-03T10:51:50  <Marchael> ThomasWaldmann: and content indexing for latest revs?
  82 2011-08-03T10:51:52  *** pkumar has quit IRC
  83 2011-08-03T10:53:42  <dreimark> moin
  84 2011-08-03T10:54:36  <dreimark> ThomasWaldmann: should i add this http://moinmo.in/4ct10n/info/MoinMoinFragen?action=diff&rev1=279&rev2=278 to a regular mig script?
  85 2011-08-03T11:00:50  <ThomasWaldmann> Marchael: i don't understand your question.
  86 2011-08-03T11:02:03  <Marchael> did you see content when do moin index --for latest-revs --action show?
  87 2011-08-03T11:04:36  <ThomasWaldmann> dreimark: no, user error.
  88 2011-08-03T11:05:41  <ThomasWaldmann> Marchael: yes
  89 2011-08-03T11:07:08  <ThomasWaldmann> but not for stuff entered via wiki UI
  90 2011-08-03T11:10:09  <ThomasWaldmann> {'rev_no': 2, 'contenttype': u'text/x.moin.wiki;charset=utf-8', 'name': u'Home', 'language': u'en', 'itemlinks': [u'rst', u'moin', u'creole', u'docbook'], 'hostname': u'localhost.localdomain', 'uuid': u'922fc98f503e4bb9bb0de9d9b7226d30', 'content': u'moin2 test content
  91 2011-08-03T11:10:23  <ThomasWaldmann> {'rev_no': 2, 'contenttype': u'text/x.moin.wiki;charset=utf-8', 'name': u'Home', 'language': u'en', 'itemlinks': [u'rst', u'moin', u'creole', u'docbook'], 'hostname': u'localhost.localdomain', 'uuid': u'922fc98f503e4bb9bb0de9d9b7226d30', 'content': u'',
  92 2011-08-03T11:10:41  <ThomasWaldmann> that's from same moin index command output
  93 2011-08-03T11:11:02  <ThomasWaldmann> looks like you're messing up the index
  94 2011-08-03T11:12:19  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * e57259c40f74 r385 moin-2.0/MoinMoin/themes/modernized/static/css/common.css: Using white backgroung for long search form
  95 2011-08-03T11:12:19  <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 3c1d17e77d1c r386 moin-2.0/MoinMoin/storage/backends/indexing.py: Return removed line for converting backend revision to whoosh index
  96 2011-08-03T11:15:04  * Marchael looks
  97 2011-08-03T11:19:19  <Marchael> I try to fix issue with uuid
  98 2011-08-03T11:19:53  <ronny> moin
  99 2011-08-03T11:20:02  <Marchael> s/uuid/duplicating/
 100 2011-08-03T11:23:50  <ThomasWaldmann> btw, if you fix some bug from the issue tracker, close the issue
 101 2011-08-03T11:25:00  <ThomasWaldmann> on bitbucket, you can do it with some specific wording in the commit comment, e.g. "... Fixes #1." should close bug #1 automatically.
 102 2011-08-03T11:25:20  <Marchael> hm, I just set status to resolved
 103 2011-08-03T11:26:24  <ThomasWaldmann> you just need to enable it for your repo, iirc. it is better than just closing the bug as it also references the changeset that closes the bug in the bug report.
 104 2011-08-03T11:31:08  <Marchael> seems like for removing documents whoosh using UUID field instead name_exact
 105 2011-08-03T11:31:52  <Marchael> ThomasWaldmann: so I guess we should change name_exact field to unique
 106 2011-08-03T11:32:22  <Marchael> and remove unique from uuid, because it may confuse update_document()
 107 2011-08-03T11:33:13  <Marchael> It doesn't chnage anything, we just will use name_exact for deleting documents
 108 2011-08-03T11:45:50  <ThomasWaldmann> so, can you point at exactly what's going wrong?
 109 2011-08-03T11:46:20  <Marchael> yes, but first I try and then paste y code to CR
 110 2011-08-03T11:47:03  <Marchael> *my code
 111 2011-08-03T11:47:56  <Marchael> yep
 112 2011-08-03T11:51:49  <Marchael> ThomasWaldmann: http://codereview.appspot.com/4832049
 113 2011-08-03T11:54:51  <ThomasWaldmann> i don't see why this should fix anything.
 114 2011-08-03T11:57:08  <Marchael> That should fix bug when preloaded documents appeared in latest revs
 115 2011-08-03T11:57:29  <ThomasWaldmann> maybe stop guessing and rather try to identify/explain a bug precisely before doing random tries to "fix" it
 116 2011-08-03T11:57:32  <Marchael> I meant like Home with revisions N and Home with revision 0
 117 2011-08-03T11:57:50  <Marchael> I explained i above
 118 2011-08-03T11:57:57  <Marchael> *it
 119 2011-08-03T11:58:17  <ThomasWaldmann> well, you just broke it in another way right now
 120 2011-08-03T11:58:53  <ThomasWaldmann> and i was pointing you at 2 index entries that had same uuid, so it is not THAT problem
 121 2011-08-03T11:59:15  <ThomasWaldmann> they even have the same rev_no
 122 2011-08-03T12:00:20  <ThomasWaldmann> so, for now, stay with UUID, ignore the rev 0 uuid problem, but fix the problem that you add the same rev twice
 123 2011-08-03T12:01:05  <ThomasWaldmann> because if you use name_exact, you'll run into troubles with renames sooner or later.
 124 2011-08-03T12:01:19  <Marchael> ok
 125 2011-08-03T12:01:21  <ThomasWaldmann> (and the uuid issue needs to get fixed anyway)
 126 2011-08-03T12:01:38  <ThomasWaldmann> (by me)
 127 2011-08-03T12:02:09  *** sinha has joined #moin-dev
 128 2011-08-03T12:41:34  * dreimark bbl - meeting
 129 2011-08-03T13:17:22  <Marchael> ThomasWaldmann: could you help to reproduce your issue please?
 130 2011-08-03T13:17:42  <Marchael> I mean duplication
 131 2011-08-03T13:34:06  <ThomasWaldmann> can't reproduce it currently
 132 2011-08-03T13:34:50  <ThomasWaldmann> but i wasn't doing anything unusual. just using moin to modify item, moin index command to build/move/show index.
 133 2011-08-03T13:36:11  <ThomasWaldmann> maybe fix #9 first
 134 2011-08-03T13:37:35  <Marchael> ok
 135 2011-08-03T13:54:53  <Marchael> rather strange
 136 2011-08-03T13:56:13  <Marchael> ThomasWaldmann: I think what issue in convert_to_indexable()
 137 2011-08-03T13:56:51  <Marchael> if I call convert_to_indexable() first time, it gave me converted content
 138 2011-08-03T13:57:10  <Marchael> for second I recieved traceback or ''
 139 2011-08-03T13:58:10  <ThomasWaldmann> you are calling it twice?
 140 2011-08-03T13:58:13  <Marchael> I mean calling for one backend revision
 141 2011-08-03T13:59:24  <ThomasWaldmann> that might be because of its file-like api. if you have once read its content, you are at EOF. if you read again, you get nothing.
 142 2011-08-03T13:59:38  <Marchael> mm
 143 2011-08-03T13:59:49  <ThomasWaldmann> but you only need to convert it once, so trying to do that twice is stupid anyway :)
 144 2011-08-03T13:59:50  <Marchael> that could describe most of things
 145 2011-08-03T14:00:26  <ThomasWaldmann> (and slow)
 146 2011-08-03T14:00:32  <Marchael> hm
 147 2011-08-03T14:11:04  *** MattMaker has quit IRC
 148 2011-08-03T14:21:16  <Marchael> ThomasWaldmann: may be use cache for content?
 149 2011-08-03T14:21:35  <Marchael> or I can just pass content to backend_to_index()
 150 2011-08-03T14:44:37  <ThomasWaldmann> yes
 151 2011-08-03T14:44:54  <ThomasWaldmann> you need to modify add_rev_whoosh to only compute indexable content once
 152 2011-08-03T14:49:56  <ThomasWaldmann> and also check other places. content conversion can be rather expensive, so it should be done only once.
 153 2011-08-03T14:50:55  <ThomasWaldmann> e.g. i tried a rather big pdf yesterday. that took ages (== a minute?) for pdfminder to process. if you have a lot of documents, that sums up.
 154 2011-08-03T15:26:30  <Marchael> ThomasWaldmann: http://codereview.appspot.com/4837052
 155 2011-08-03T15:32:55  <ThomasWaldmann> Marchael: review done
 156 2011-08-03T15:33:11  <ThomasWaldmann> gtg/bbl
 157 2011-08-03T16:16:45  *** eSyr has quit IRC
 158 2011-08-03T16:16:50  *** eSyr has joined #moin-dev
 159 2011-08-03T16:20:56  *** sinha has quit IRC
 160 2011-08-03T16:39:19  <Marchael> ThomasWaldmann: http://codereview.appspot.com/4837052/ patchset 2
 161 2011-08-03T16:59:18  <Marchael> bbl
 162 2011-08-03T17:00:36  *** Marchael has quit IRC
 163 2011-08-03T17:09:13  *** pkumar has joined #moin-dev
 164 2011-08-03T17:21:08  *** brunomartin has joined #moin-dev
 165 2011-08-03T17:31:13  *** Marchael has joined #moin-dev
 166 2011-08-03T17:32:17  <Marchael> ThomasWaldmann: ping
 167 2011-08-03T17:34:37  *** m4k3r has joined #moin-dev
 168 2011-08-03T17:38:35  <ThomasWaldmann> Marchael: review done
 169 2011-08-03T17:39:18  *** m4k3r has quit IRC
 170 2011-08-03T17:39:39  *** m4k3r has joined #moin-dev
 171 2011-08-03T18:04:27  *** sinha has joined #moin-dev
 172 2011-08-03T18:04:35  <Marchael> ThomasWaldmann: http://codereview.appspot.com/4837052/ patchset 3
 173 2011-08-03T18:06:33  <pkumar> ThomasWaldmann : moin, I had been looking into that import_export_xml stuff and had a few doubts regarding it. in the test test_wikiutil, it checks for the contents in the revision of items like HelpOnLinking. first thing, do we want those xml pages?
 174 2011-08-03T18:15:16  *** ThomasWaldmann has quit IRC
 175 2011-08-03T18:15:40  *** xorAxAx has quit IRC
 176 2011-08-03T18:17:58  <pkumar> bbl
 177 2011-08-03T18:18:01  *** pkumar has quit IRC
 178 2011-08-03T18:19:56  *** TheSheep has quit IRC
 179 2011-08-03T18:20:34  *** TheSheep has joined #moin-dev
 180 2011-08-03T18:20:40  *** xorAxAx has joined #moin-dev
 181 2011-08-03T18:26:36  *** ThomasWaldmann has joined #moin-dev
 182 2011-08-03T18:26:42  *** ThomasWaldmann has joined #moin-dev
 183 2011-08-03T18:39:44  *** m4k3r has quit IRC
 184 2011-08-03T18:44:10  <Marchael> ThomasWaldmann: why I need use autofocus if it automatically focused on long search form?
 185 2011-08-03T18:45:42  *** m4k3r has joined #moin-dev
 186 2011-08-03T18:46:19  <Marchael> ThomasWaldmann: http://codereview.appspot.com/4837052/ patchset 3, it's unclean changeset
 187 2011-08-03T18:46:34  <Marchael> I'll divide them later
 188 2011-08-03T18:51:12  <Marchael> brb
 189 2011-08-03T19:04:59  <Marchael> re
 190 2011-08-03T19:17:32  <ThomasWaldmann> review done
 191 2011-08-03T19:20:56  *** greg_f has quit IRC
 192 2011-08-03T19:23:47  *** pkumar has joined #moin-dev
 193 2011-08-03T19:26:17  <Marchael> ThomasWaldmann: how I can override searchform in layout.html?
 194 2011-08-03T19:27:20  *** m4k3r has quit IRC
 195 2011-08-03T19:29:01  *** m4k3r has joined #moin-dev
 196 2011-08-03T19:34:28  *** m4k3r_ has joined #moin-dev
 197 2011-08-03T19:37:00  *** m4k3r has quit IRC
 198 2011-08-03T19:42:40  *** raignarok has joined #moin-dev
 199 2011-08-03T19:50:50  <ronny> sup
 200 2011-08-03T19:56:54  *** m4k3r has joined #moin-dev
 201 2011-08-03T19:57:19  <ronny> pkumar: how is it going?
 202 2011-08-03T19:59:10  *** m4k3r_ has quit IRC
 203 2011-08-03T20:01:40  <pkumar> ronny : hey, goin fine yet. thanx. can you please suggest me about test clean up i.e. all the instances/stuffs tests create should be removed after test ends.
 204 2011-08-03T20:02:06  <ronny> you mean teardown i suppose
 205 2011-08-03T20:02:32  <ronny> pkumar: there could be a teardown hook that shuts down the backend
 206 2011-08-03T20:02:44  <ronny> pkumar: im not sure where the leaks are, didnt investigate myself
 207 2011-08-03T20:04:49  <pkumar> ronny : I'm not sure because teardown doesn't cleans up every thing, thats why I guess we need to initialize new app every time for the fresh backend. I'll try the hook though, thanx
 208 2011-08-03T20:23:22  *** MattMaker has joined #moin-dev
 209 2011-08-03T20:24:05  <ronny> pkumar: got any stats i can make/take a look at
 210 2011-08-03T20:27:24  <pkumar> ronny : not currently, this clean up problem is a TODO task for me, will surely get to you once I start working on it. Thomas was suggesting to improve the test framework and over all design. It would be great if you could give some suggestions
 211 2011-08-03T20:28:39  <pkumar> like some new features/enhancements
 212 2011-08-03T20:29:20  <pkumar> requirement
 213 2011-08-03T20:29:20  <pkumar> ?
 214 2011-08-03T20:32:27  *** m4k3r has quit IRC
 215 2011-08-03T20:38:34  <dreimark> re
 216 2011-08-03T20:39:37  <dreimark> sinha: everything ok?
 217 2011-08-03T20:39:58  <sinha> dreimark: yes,
 218 2011-08-03T20:40:05  <sinha> thanks for asking
 219 2011-08-03T20:40:41  <sinha> dreimark: currently i am done with select all thing, should i commit this now, OR commit selectall+downloadalll together ?
 220 2011-08-03T20:41:16  <dreimark> you can commit it one after the other, do you want a review?
 221 2011-08-03T20:42:10  <dreimark> sinha: ^
 222 2011-08-03T20:42:14  <sinha> yes, just posting in 5 mins,
 223 2011-08-03T20:42:19  <dreimark> ok
 224 2011-08-03T20:42:20  <sinha> i wanted you to test this also
 225 2011-08-03T20:42:31  <dreimark> yeah - i have time
 226 2011-08-03T20:52:30  <ThomasWaldmann> Marchael: doesn't the form automatically go away if you do not give search_form=... to the render call?
 227 2011-08-03T21:12:59  <sinha> dreimark: Codereview: http://codereview.appspot.com/4810068 and it looks something like this  http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-03?action=AttachFile&do=get&target=index.png
 228 2011-08-03T21:20:18  *** pkumar has quit IRC
 229 2011-08-03T21:31:58  *** m4k3r has joined #moin-dev
 230 2011-08-03T21:47:57  *** m4k3r has quit IRC
 231 2011-08-03T21:48:30  *** m4k3r has joined #moin-dev
 232 2011-08-03T21:48:46  <dreimark> sinha: I look soon, need to write a long email currently
 233 2011-08-03T21:53:48  <sinha> okay
 234 2011-08-03T21:56:31  *** MattMaker has quit IRC
 235 2011-08-03T22:21:17  <dreimark> sinha: the checkbox png is from tango? license ?
 236 2011-08-03T22:38:11  *** m4k3r has quit IRC
 237 2011-08-03T22:39:57  *** m4k3r has joined #moin-dev
 238 2011-08-03T22:54:57  *** raignarok has quit IRC
 239 2011-08-03T22:57:51  <sinha> dreimark: yes its from tango
 240 2011-08-03T22:58:10  <dreimark> ok
 241 2011-08-03T23:00:48  <sinha> dreimark: and "it would be good this becomes combined with Filter by Content Type and Index Letter subset", how exactly you want it to get done ?
 242 2011-08-03T23:05:42  <dreimark> sinha: e.g. selecting all images and only starting with indexletter L
 243 2011-08-03T23:06:12  <dreimark> or All indexletters but only markup text
 244 2011-08-03T23:06:52  <dreimark> I assume that when I select a index letter it can only download that items
 245 2011-08-03T23:07:15  <dreimark> so we need to get the subset by contenttype filter
 246 2011-08-03T23:08:30  *** m4k3r has quit IRC
 247 2011-08-03T23:08:58  <sinha> dreimark: okay, these things are happening by the already forms in place, i mean first i will do filter and then select a index letter, so i need to do these things in javascript itself ? in that select all what option i should give ?
 248 2011-08-03T23:09:31  <sinha> Or their will be "Advanced option" kind of thing for Select All ?
 249 2011-08-03T23:09:46  <sinha> s/their/there
 250 2011-08-03T23:10:10  <dreimark> hmm, select all is in "filter by content type" everything checked
 251 2011-08-03T23:10:19  <dreimark> so this is the same workflow
 252 2011-08-03T23:11:12  <dreimark> lets say it this way "Download" should download everything visible on index page
 253 2011-08-03T23:11:44  <dreimark> and the selection is done by now from Index letter and the filter tool
 254 2011-08-03T23:13:16  <dreimark> in "filter by content type" can have a check all button or toggle
 255 2011-08-03T23:14:11  <dreimark> "by now" what we currently have, may be we want another method, e.g. exact name
 256 2011-08-03T23:14:37  <ThomasWaldmann> re
 257 2011-08-03T23:14:46  <dreimark> but that is not important now, because one item can be downloaded always
 258 2011-08-03T23:22:37  <sinha> dreimark: okay, when page gets load everything will be checked, when i uncheck "image" in contenttype filter, then image items will be unchecked, something like this ?
 259 2011-08-03T23:22:58  <dreimark> sinha: yes
 260 2011-08-03T23:23:38  <sinha> dreimark: but suppose here i check audio items (which was unchecked by default), we cant select audio items anymore because they are not on page
 261 2011-08-03T23:23:42  <dreimark> and they can't be downloaded unless "image" is  checked again
 262 2011-08-03T23:24:11  <sinha> dreimark: but what if i just have to download a single item ?
 263 2011-08-03T23:25:01  <dreimark> that's a further improvement. in general this can be currently only done on an item view itselfs
 264 2011-08-03T23:25:46  <dreimark> one feature i have yet no idea if that works is to move an item to the desktop
 265 2011-08-03T23:26:08  <dreimark> thats the opposite from nautilus dropping
 266 2011-08-03T23:28:21  <dreimark> another future improvement is to only show available contenttypes or disable those not existing
 267 2011-08-03T23:28:39  <sinha> dreimark: yes i was also thinking about that file dropping to desktop thing
 268 2011-08-03T23:29:20  <sinha> this dragging of files work for images, i mean just drag a image to desktop it gets downloaded
 269 2011-08-03T23:30:07  <dreimark> for me this currently creates a link
 270 2011-08-03T23:30:33  <sinha> yes for me also, but i guess it works on windows
 271 2011-08-03T23:30:52  <sinha> (i have seen this working sometimes ago)
 272 2011-08-03T23:30:57  <dreimark> dragging the item itselfs does it
 273 2011-08-03T23:34:05  <sinha> dreimark: i am pushing the current changes, please try it once
 274 2011-08-03T23:34:14  <sinha> and tell me where i need to change
 275 2011-08-03T23:34:55  <dreimark> I'll do
 276 2011-08-03T23:35:47  <CIA-114> Akash Sinha <akash2607@gmail.com> * e65f9a5ee6df r348 default/MoinMoin/ (5 files in 4 dirs): selet item feature added on index page
 277 2011-08-03T23:36:26  <dreimark> typo in commit message
 278 2011-08-03T23:36:35  <sinha> ah, yes
 279 2011-08-03T23:44:03  <dreimark> sinha: we work later on where to show on the page this mew elements
 280 2011-08-03T23:45:00  <sinha> okay
 281 2011-08-03T23:47:31  <dreimark> good idea with the select all checkbox
 282 2011-08-03T23:47:45  <dreimark> at least one can remove those the don't want
 283 2011-08-03T23:48:38  <dreimark> /the/he/
 284 2011-08-03T23:49:34  <sinha> dreimark: so tell me whether should i carry on this
 285 2011-08-03T23:49:48  <sinha> i mean here first by filtering we get all images
 286 2011-08-03T23:50:03  <sinha> then select all of them (or deselect which is not wanted)
 287 2011-08-03T23:50:10  <sinha> and click on action Download
 288 2011-08-03T23:51:38  <dreimark> i think that workflow is easy to describe and works
 289 2011-08-03T23:52:04  <dreimark> that's all we can do in one request
 290 2011-08-03T23:52:43  * dreimark is tired
 291 2011-08-03T23:53:01  <dreimark> gn
 292 2011-08-03T23:53:03  <sinha> dreimark: will discuss in morning
 293 2011-08-03T23:53:03  <sinha> gn
 294 2011-08-03T23:56:10  *** sinha has quit IRC
 295 

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-08-03 (last edited 2011-08-02 22:45:03 by IrcLogImporter)