1 2011-08-16T00:56:50 *** TheSheep
2 2011-08-16T00:57:30 *** TheSheep
3 2011-08-16T01:20:46 *** raignarok
4 2011-08-16T02:55:30 *** TheSheep
5 2011-08-16T02:55:44 *** TheSheep
6 2011-08-16T07:13:34 *** pkumar
7 2011-08-16T07:22:56 *** Marchael
8 2011-08-16T07:24:26 <Marchael> moin
9 2011-08-16T07:24:27 <pkumar> dreimark : hi, well.. logically there should be no item in unprotected_storage once removed from flaskg.storage but what I meant was in the functions test_user_unicode_password_change and test_user_password_change_to_unicode_pw in test_frontend, the satement self.createUser(name, password) creates an item in unprotected_storage but not in storage. may be a fault in the part of creating user there.
10 2011-08-16T07:27:28 <pkumar> ThomasWaldmann : moin, the function seems helpful in removing all the items after each test, as a result we don't need to init app in storage and datastruct modules any more. thus making the tests singnificantly even faster
11 2011-08-16T08:09:48 *** Marchael
12 2011-08-16T09:28:24 <ThomasWaldmann> pkumar: you are aware that p/up storage are usually 2 views of same storage?
13 2011-08-16T09:29:43 <pkumar> ThomasWaldmann : yes, just with acl protection in p I guess.
14 2011-08-16T09:30:32 <ThomasWaldmann> yes. so it is a bit strange to first try to kill all items from p with lots of acl trickery and then trying to remove all from up
15 2011-08-16T09:31:56 <ThomasWaldmann> so, maybe try if just killing all from up works (which is assumed)
16 2011-08-16T09:33:00 <pkumar> ThomasWaldmann : if I just try to delete items from up, I get lots of AccessDeniedError, so had to get rights to delete the items in there
17 2011-08-16T09:37:22 <pkumar> and regarding the statement, it's just test_frontend has the issue of having an item in up(and nothing in p) after creating a user there. seems like some problem with user creation there.
18 2011-08-16T09:37:42 <ThomasWaldmann> as there is no acl protection in up, you should not get ADE
19 2011-08-16T09:39:44 <pkumar> ThomasWaldmann : if I delete only items from up, I get IntegrityError
20 2011-08-16T09:40:48 <ThomasWaldmann> please add comments there telling all that what you told here right now
21 2011-08-16T09:41:13 <pkumar> sure :)
22 2011-08-16T09:41:15 *** Marchael
23 2011-08-16T09:42:40 *** mkerrin
24 2011-08-16T09:45:20 <pkumar> ThomasWaldmann : can you please tell me about _get_key_id in kvstore. how this - select([key_table.c.id, key_table.c.value_type],
25 2011-08-16T09:45:21 <pkumar> key_table.c.name == name
26 2011-08-16T09:45:21 <pkumar> ).execute().fetchone() works?because I get assertion error(str and unicode) in there.
27 2011-08-16T09:45:44 <pkumar> while running some tests in items
28 2011-08-16T09:46:11 <pkumar> specially due to contenttypes
29 2011-08-16T09:46:40 <pkumar> normally above one returns value - str
30 2011-08-16T09:47:17 <pkumar> but in some cases we have unicode values of contenttype
31 2011-08-16T09:47:29 <pkumar> so how should this exactly be?
32 2011-08-16T09:48:25 <ThomasWaldmann> pkumar: kvstore is something not existing any more in moin-whoosh repo
33 2011-08-16T09:49:07 <ThomasWaldmann> and str vs unicode is just because it is very picky about types
34 2011-08-16T09:49:54 <pkumar> ThomasWaldmann : ok, so I don't need to worry about those assertions right?
35 2011-08-16T09:49:54 <ThomasWaldmann> so, for example for item names, always use unicode, never str
36 2011-08-16T09:50:25 <pkumar> ok, and what about contenttypes? unicode?
37 2011-08-16T09:50:37 <ThomasWaldmann> yes
38 2011-08-16T09:51:47 <ThomasWaldmann> i think we'll merge Marchael's stuff soon into main repo, so you can get it from there
39 2011-08-16T09:52:54 <ThomasWaldmann> (indexing will be with whoosh then, so no sqla errors there any more)
40 2011-08-16T09:54:31 <pkumar> ThomasWaldmann : that would be great. I would also get some time to fix/modify tests if any due to Marchael's changes
41 2011-08-16T09:56:11 <pkumar> ThomasWaldmann : also, regarding docs for the testing work, MoinMoin wiki page should be fine right?
42 2011-08-16T09:57:19 <pkumar> any suggestions regarding docs?
43 2011-08-16T09:57:41 <ThomasWaldmann> well, depends what you mean exactly
44 2011-08-16T09:57:52 <ThomasWaldmann> there are 3 places: wiki, sphinx docs, source
45 2011-08-16T09:58:33 <pkumar> so, what exactly should be the basis of selection?
46 2011-08-16T10:01:01 <pkumar> the documentation would contain the info about the changes/ working of the tests using pytest2. also may be some info for the ppl who want to contribute to it. any thing else you would suggest to add?
47 2011-08-16T10:01:06 <pkumar> ThomasWaldmann : ^
48 2011-08-16T10:02:35 <pkumar> also please enlighten me about above three places?
49 2011-08-16T10:03:28 <ThomasWaldmann> well, the developer (sphinx-based) docs are a good place to tell what a test-writing moin-developer should know
50 2011-08-16T10:04:19 <ThomasWaldmann> the source is a good place to tell details WHY you are doing some stuff in the way you did (see discussion above)
51 2011-08-16T10:05:08 <ThomasWaldmann> the wiki might be a good place to advertise your project on your home page or a project page and point to some stuff
52 2011-08-16T10:09:43 <pkumar> ThomasWaldmann : wow, sounds great. I think I can use all of them. How do I create spinx docs. with source do you mean source code or some other place to document?
53 2011-08-16T10:11:36 <ThomasWaldmann> with source i mean source code :)
54 2011-08-16T10:12:15 <ThomasWaldmann> sphinx-based docs are below docs/ - just look there, there are some docs already and do it in same style
55 2011-08-16T10:12:45 <ThomasWaldmann> you need to write in rst markup and run "make html" in the docs/ dir to build the html files
56 2011-08-16T10:15:57 <ThomasWaldmann> dreimark: Marchael: pkumar: waldi: xorAxAx: (and sinha): today meeting as usual
57 2011-08-16T10:17:01 <ThomasWaldmann> please prepare by looking at the project and thinking about what to do in the last week before final evals start
58 2011-08-16T10:18:28 <pkumar> all right :)
59 2011-08-16T10:18:35 <Marchael> ok
60 2011-08-16T10:22:04 *** greg_f
61 2011-08-16T10:27:20 * dreimark ack
62 2011-08-16T10:27:25 <dreimark> moin
63 2011-08-16T10:29:25 <dreimark> pkumar: you could write a test which shows this failure. it is not a good idea to work around a bug/problem by slently fixing it in that way
64 2011-08-16T10:31:05 <pkumar> dreimark : are you referring to problem in apps.frontend?
65 2011-08-16T10:32:25 <pkumar> * the tests in apps.frontend?
66 2011-08-16T10:41:40 <pkumar> dreimark : I'll try to fix those tests
67 2011-08-16T10:43:17 <pkumar> bbl,
68 2011-08-16T10:43:35 *** pkumar
69 2011-08-16T11:03:31 <Marchael> ThomasWaldmann: what difference between delete and destroy item?
70 2011-08-16T11:05:53 <Marchael> ThomasWaldmann: there is something wrong...delete shoul delete revision and destroy whole item. But if I remove last revision, moin offers me to create item again.
71 2011-08-16T11:06:44 <Marchael> so, latest revision will be deleted but previous will stays in indexes
72 2011-08-16T11:08:33 <ThomasWaldmann> delete item = move whole item to trash/*
73 2011-08-16T11:09:01 <ThomasWaldmann> destroy item = nuke item (stops to exist)
74 2011-08-16T11:09:02 <Marchael> hm, so user can search in trashed revisions
75 2011-08-16T11:09:21 <ThomasWaldmann> destroy revision = nuke a single revision, rest stays as is
76 2011-08-16T11:09:23 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4887043
77 2011-08-16T11:09:45 <Marchael> that should fix https://bitbucket.org/marchael/moin-2.0/issue/33/incomplete-code-in-indexing-middleware
78 2011-08-16T11:12:24 <ThomasWaldmann> review done
79 2011-08-16T11:14:24 <Marchael> replied
80 2011-08-16T11:14:37 <Marchael> brb
81 2011-08-16T11:16:26 * Marchael here
82 2011-08-16T11:17:09 *** raignarok
83 2011-08-16T11:17:21 <Marchael> ThomasWaldmann: ?
84 2011-08-16T11:18:15 <Marchael> or you mean what I should remove uuid=metas[UUID] from parameters/
85 2011-08-16T11:18:17 <Marchael> ?
86 2011-08-16T11:19:58 <ThomasWaldmann> the main point of the question was why are you doing it differently than a few lines above
87 2011-08-16T11:20:45 <Marchael> hm, uuid doesn't need there
88 2011-08-16T11:21:12 <ThomasWaldmann> why is it different?
89 2011-08-16T11:21:24 <Marchael> also, iirc sometime ago dreimark told what after renaming revision may change uuid
90 2011-08-16T11:21:51 <ThomasWaldmann> if working correctly, a uuid of an item never changes
91 2011-08-16T11:26:54 * Marchael trying with same params
92 2011-08-16T11:28:22 <Marchael> ThomasWaldmann: seems working after adding uuid, may I commit or you want to review my code first?
93 2011-08-16T11:29:10 <ThomasWaldmann> so you have name, uuid and interwiki now?
94 2011-08-16T11:29:14 <Marchael> yes
95 2011-08-16T11:29:51 <ThomasWaldmann> how do you select at other places?
96 2011-08-16T11:30:25 <Marchael> you mean other class methods?
97 2011-08-16T11:30:51 <ThomasWaldmann> whereever
98 2011-08-16T11:31:48 <Marchael> in most cases i use name, uuid, interwiki and sometimes rev_no
99 2011-08-16T11:31:59 <Marchael> *name_exact
100 2011-08-16T11:33:19 <ThomasWaldmann> ok, commit as is
101 2011-08-16T11:33:39 <ThomasWaldmann> we'll do some global fixing to all this as soon as the uuid stuff works better
102 2011-08-16T11:37:19 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6b4f5e5850a3 r444 moin-2.0/MoinMoin/storage/backends/indexing.py: fixed issue with destroying items. Revisions don't deleted from all revisions index Fixes #33.
103 2011-08-16T11:46:35 <Marchael> ThomasWaldmann: I add scoring for name field in both schemas http://codereview.appspot.com/4894049
104 2011-08-16T11:47:57 <ThomasWaldmann> almost, see review
105 2011-08-16T11:48:47 <Marchael> ah, ok
106 2011-08-16T11:51:04 <Marchael> ThomasWaldmann: ps 2
107 2011-08-16T11:51:50 <ThomasWaldmann> ok
108 2011-08-16T11:52:09 <Marchael> is it fix #30?
109 2011-08-16T11:53:21 <ThomasWaldmann> hope so. did you test it?
110 2011-08-16T11:53:39 <Marchael> yes, I test it for "docbook"
111 2011-08-16T11:54:05 <ThomasWaldmann> so the item with the hit in item name_exact is now always first?
112 2011-08-16T11:54:13 <Marchael> earlier, "Home" was highter because it had greater revisions
113 2011-08-16T11:54:25 <Marchael> of course
114 2011-08-16T11:54:34 <ThomasWaldmann> ok, close it
115 2011-08-16T11:55:04 <ThomasWaldmann> #29 is somewhat related, #34 important
116 2011-08-16T11:55:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0f29cbb71223 r445 moin-2.0/MoinMoin/search/indexing.py: Using scoring name and name_exact fields to improve search results Fixes #30.
117 2011-08-16T12:03:24 <Marchael> ThomasWaldmann: about #29. I tried to search in all revisions and there is my results http://awesomescreenshot.com/044iowof5 Seems adequate
118 2011-08-16T12:04:33 <Marchael> I tried same query like this http://awesomescreenshot.com/0b8ijdpe9
119 2011-08-16T12:05:00 <ThomasWaldmann> sheer luck
120 2011-08-16T12:05:19 <ThomasWaldmann> Marchael: you know how it sorts by default?
121 2011-08-16T12:05:45 <Marchael> I guess whoosh sorst results by count of hits
122 2011-08-16T12:05:52 <Marchael> *sorts
123 2011-08-16T12:06:45 <ThomasWaldmann> yes, almost. it sorts by score.
124 2011-08-16T12:07:10 <ThomasWaldmann> that's hits, weighted, boosted.
125 2011-08-16T12:07:24 <ThomasWaldmann> so, what do we want for sorting?
126 2011-08-16T12:09:55 <ThomasWaldmann> or, asked differently: do we want something else?
127 2011-08-16T12:11:26 <Marchael> I guess that's enough
128 2011-08-16T12:13:58 <Marchael> I meant > hits, weighted, boosted.
129 2011-08-16T12:15:34 <ThomasWaldmann> yes. i initially thought it shoud be otherwise somehow (like sorting for name, revno, grouping somehow, but maybe just score is best)
130 2011-08-16T12:17:25 <Marchael> so, we are using scoring now
131 2011-08-16T12:17:46 <ThomasWaldmann> yes, that's what we already have
132 2011-08-16T12:18:42 <ThomasWaldmann> so, what do you do with the bug report now? :)
133 2011-08-16T12:20:17 <Marchael> close? :)
134 2011-08-16T12:20:47 <ThomasWaldmann> you didn't do anything
135 2011-08-16T12:26:02 <Marchael> ThomasWaldmann: may be use sorting?
136 2011-08-16T12:26:44 <ThomasWaldmann> what can be improved with it and how?
137 2011-08-16T12:47:58 <ThomasWaldmann> Marchael: so, what do you plan to do?
138 2011-08-16T12:48:12 <Marchael> read docs about scoring
139 2011-08-16T12:48:21 <ThomasWaldmann> url?
140 2011-08-16T12:48:57 <Marchael> http://packages.python.org/Whoosh/api/scoring.html
141 2011-08-16T12:52:56 <ThomasWaldmann> hmm, i don't think that is related
142 2011-08-16T12:53:55 <ThomasWaldmann> because hits determine score. and you already boosted some fields where hits should score higher. so i think you are done with scoring.
143 2011-08-16T12:54:35 <ThomasWaldmann> http://packages.python.org/Whoosh/facets.html i was first rather thinking of that
144 2011-08-16T12:55:00 <ThomasWaldmann> but, after thinking about it, I don't even think that could improve this case
145 2011-08-16T12:55:46 * ThomasWaldmann needs to leave soon, so if you have questions, ask now
146 2011-08-16T12:56:31 <Marchael> It could be using for sorting and likely realted with #20
147 2011-08-16T12:59:53 <Marchael> ThomasWaldmann: could you try again to use same query for searching, but first, merging with my repo. Whoosh using BM25F for scoring, so if you see incorrect results may that's bug in alghorithm implementation?
148 2011-08-16T13:00:15 *** sinha
149 2011-08-16T13:00:38 <ThomasWaldmann> i didn't say results are incorrect
150 2011-08-16T13:00:48 <Marchael> because documents with best matches locate in wrong order
151 2011-08-16T13:01:18 <ThomasWaldmann> i was just thinking about whether we can improve rendering somehow
152 2011-08-16T13:01:43 <Marchael> hm, what you mean?
153 2011-08-16T13:01:50 <ThomasWaldmann> but meanwhile i think we can't easily do that, at least not with sorting or scoring or standard grouping
154 2011-08-16T13:02:45 <ThomasWaldmann> because we for sure want to sort by score for search results
155 2011-08-16T13:03:22 <ThomasWaldmann> so, even if we add a 2nd sort criteria, that would only influence order of stuff with same score
156 2011-08-16T13:04:29 * Marchael confused
157 2011-08-16T13:05:28 * Marchael don't quite understand the root of issue
158 2011-08-16T13:06:14 <ThomasWaldmann> the order you see in my screenshot is correct order based on score (likely, we do not directly see the score)
159 2011-08-16T13:06:52 <ThomasWaldmann> what looked a bit unpretty is that same item name was not somehow grouped together, but this was just due to different score.
160 2011-08-16T13:07:38 <ThomasWaldmann> but as we want to sort by score (default), there is no easy way to improve this
161 2011-08-16T13:08:33 <Marchael> may just try list named "Another results for that item" or somelike
162 2011-08-16T13:08:52 <Marchael> but there is need js and jquery
163 2011-08-16T13:08:54 <ThomasWaldmann> so, you could just close that issue stating that it is invalid, because we just want it as it is. :D
164 2011-08-16T13:09:10 <ThomasWaldmann> ehrm, set it to invalid not close
165 2011-08-16T13:10:13 <Marchael> but what you think about idea with dropdown animated list?
166 2011-08-16T13:10:19 <ThomasWaldmann> the problem with grouping by name is also that low-score hits would be drawn into high-score hits of same name
167 2011-08-16T13:10:46 <Marchael> So we just show "item name" and "see more..."
168 2011-08-16T13:10:55 <ThomasWaldmann> so, maybe we better just forget about it.
169 2011-08-16T13:11:30 <ThomasWaldmann> (this was just to train you that not every bug report is valid :D )
170 2011-08-16T13:11:56 <Marchael> heh
171 2011-08-16T13:12:25 <Marchael> anyway, how about my idea?
172 2011-08-16T13:12:51 <ThomasWaldmann> it wouldn't improve things
173 2011-08-16T13:13:38 <ThomasWaldmann> #34 next
174 2011-08-16T13:14:01 <Marchael> ok
175 2011-08-16T13:14:05 * ThomasWaldmann needs to go, hope to be back until meeting time
176 2011-08-16T13:32:16 *** sinha
177 2011-08-16T13:32:28 *** sinha
178 2011-08-16T13:32:57 * grad wonders on how much student workflow was improved at this summer :-)
179 2011-08-16T13:33:29 <dreimark> ThomasWaldmann: Marchael not it did not change the uuid but you can have for the same name of an item different uuids
180 2011-08-16T13:47:00 <dreimark> grad: hmm?
181 2011-08-16T13:48:57 <dreimark> sinha: https://bugzilla.mozilla.org/show_bug.cgi?id=68421
182 2011-08-16T13:52:21 <sinha> dreimark: the previous comment was posted almost 10 years ago :O
183 2011-08-16T14:01:07 *** sinha
184 2011-08-16T14:01:55 <grad> dreimark: we not used any bugtracking/code-review systems, although it does not help in the absence of Internet... I'm just glad that Marchael's interaction with a mentor is so active
185 2011-08-16T14:05:05 <Marchael> grad: student and mentor itercation is always active...before deadline :)
186 2011-08-16T14:07:03 <dreimark> grad: me learned about that cr on a python barcamp this year, just in time for gsoc
187 2011-08-16T14:07:08 <Marchael> *iteraction
188 2011-08-16T14:07:24 <dreimark> and if you once used that you don't like pastebins for the same purpose
189 2011-08-16T14:09:15 <dreimark> at all the work must be done and one can't do to summer jobs
190 2011-08-16T14:09:24 <dreimark> s/to/two/
191 2011-08-16T14:12:11 <dreimark> bbl
192 2011-08-16T14:48:50 <grad> I think that I shouldn't quit my job at GSoC time last year... that was one of my mistakes - having to work in the university would guarantee me regular Internet access, delay my coursework to after-gsoc time, and I would save some time on journeys back and forth from Miass to Chelyabinsk... yeah)
193 2011-08-16T14:50:42 <Marchael> grad: but you're alive dude
194 2011-08-16T15:09:34 <grad> why I shouldn't be? 0_o
195 2011-08-16T15:24:22 <Marchael> who can gatanty that you should...
196 2011-08-16T15:24:29 <Marchael> *garanty
197 2011-08-16T15:32:56 *** Marchael
198 2011-08-16T15:33:24 *** raignarok
199 2011-08-16T15:37:57 *** raignarok
200 2011-08-16T15:45:23 *** raignarok
201 2011-08-16T16:16:01 *** pkumar
202 2011-08-16T16:18:05 *** raignarok
203 2011-08-16T16:34:31 *** Marchael
204 2011-08-16T17:00:14 <ThomasWaldmann> dreimark: i am not sure i understand your comment
205 2011-08-16T17:00:26 <ThomasWaldmann> (or how it is important / related)
206 2011-08-16T17:01:13 <ThomasWaldmann> but it is known that the uuid stuff still has issues, so there can be no perfect code/behaviour for that
207 2011-08-16T17:01:20 *** sinha
208 2011-08-16T17:07:51 <Marchael> ThomasWaldmann: ItemIndex doesn't accept index_dir parameter, so how can I build test index for that?
209 2011-08-16T17:17:52 <ThomasWaldmann> Marchael: MoinMoin/_tests/wikiconfig.py maybe?
210 2011-08-16T17:18:43 <Marchael> ah, exactly :)
211 2011-08-16T17:27:39 *** Marchael
212 2011-08-16T17:28:58 *** Marchael
213 2011-08-16T17:36:06 <dreimark> ThomasWaldmann: it is no issue it is just normal. if you rename something it keeps the uuid, if you create then the name again it has a different uuid.
214 2011-08-16T17:36:54 <dreimark> if you revert a renaming you can do this only by reverting the new creation beforehand
215 2011-08-16T17:47:50 <pkumar> brb
216 2011-08-16T17:56:23 <ThomasWaldmann> meeting in 5 mins
217 2011-08-16T18:02:19 <ThomasWaldmann> dreimark: Marchael: pkumar: sinha: waldi: xorAxAx: meeting time :)
218 2011-08-16T18:02:29 * Marchael here
219 2011-08-16T18:02:34 <ThomasWaldmann> please give life signs :)
220 2011-08-16T18:02:35 <sinha> here
221 2011-08-16T18:02:43 <ThomasWaldmann> ok, marchael, please begin :)
222 2011-08-16T18:02:50 <Marchael> ok
223 2011-08-16T18:02:51 <Marchael> Last week I worked on fixing bugs and adding some features
224 2011-08-16T18:02:52 <Marchael> Using scoring for name and name_exact fields https://bitbucket.org/marchael/moin-2.0/changeset/0f29cbb71223
225 2011-08-16T18:02:52 <Marchael> Fixed issue with destroying items https://bitbucket.org/marchael/moin-2.0/changeset/6b4f5e5850a3
226 2011-08-16T18:02:52 <Marchael> Updated admin docs https://bitbucket.org/marchael/moin-2.0/changeset/b8ebdf2c816e
227 2011-08-16T18:02:52 <Marchael> Refactoring some code in builing script https://bitbucket.org/marchael/moin-2.0/changeset/33249607fd48
228 2011-08-16T18:02:52 <Marchael> Added dynamic fields for searching https://bitbucket.org/marchael/moin-2.0/changeset/dccbd79260ce
229 2011-08-16T18:02:52 <Marchael> Added search in non-current revisions using checkbox https://bitbucket.org/marchael/moin-2.0/changeset/66981eb25822
230 2011-08-16T18:02:53 <Marchael> Improve displaying results from other wikis https://bitbucket.org/marchael/moin-2.0/changeset/78a2962bf192
231 2011-08-16T18:02:53 <Marchael> Fixed displaying results for users which have no rights to view content of this revisions https://bitbucket.org/marchael/moin-2.0/changeset/6800ab9dd159
232 2011-08-16T18:02:54 <Marchael> Next week, I'll be working on writing missed tests and documentation. Also, will try to implements some features from my issue tracker
233 2011-08-16T18:02:54 <Marchael> blockers: none
234 2011-08-16T18:02:59 <ThomasWaldmann> hehe
235 2011-08-16T18:03:09 <ThomasWaldmann> someone was prepared
236 2011-08-16T18:03:58 <dreimark> builing script?
237 2011-08-16T18:03:59 <ThomasWaldmann> ok, sounds good :)
238 2011-08-16T18:04:02 <ThomasWaldmann> +d
239 2011-08-16T18:04:07 <Marchael> yep :)
240 2011-08-16T18:04:11 <ThomasWaldmann> index build script
241 2011-08-16T18:04:46 <ThomasWaldmann> ok, me has no questions, just a remark:
242 2011-08-16T18:05:29 <ThomasWaldmann> I'll do a first merge of Marchael's whoosh search code into main repo soon, so be prepared for some bigger change there.
243 2011-08-16T18:05:41 <dreimark> good
244 2011-08-16T18:05:48 <ThomasWaldmann> as there was no search code at all before, I hope it won't break anything.
245 2011-08-16T18:05:59 <Marchael> nice :)
246 2011-08-16T18:06:40 <ThomasWaldmann> and as far as i can see, the basic search functionality works quite ok (modulo some uuid stuff that can't work yet)
247 2011-08-16T18:07:14 <ThomasWaldmann> there is lots to do though to make more use of whoosh index within the moin code, there is not much yet, just history and tags
248 2011-08-16T18:08:02 <ThomasWaldmann> so, everybody be prepared to upgrade your envs after merging that stuff from main repo:
249 2011-08-16T18:08:22 <ThomasWaldmann> pip install --upgrade -e . # that should fix stuff
250 2011-08-16T18:08:45 <dreimark> ThomasWaldmann: soon is today or until which day?
251 2011-08-16T18:09:10 <dreimark> I think we should merge sinha repo also before end of gsoc
252 2011-08-16T18:09:13 <ThomasWaldmann> maybe the sooner the better?
253 2011-08-16T18:09:36 <waldi> here
254 2011-08-16T18:09:55 <ThomasWaldmann> yes, maybe i can do it today
255 2011-08-16T18:10:09 <Marchael> hm, may be do it after SOC? I also want to work on some features.
256 2011-08-16T18:10:12 <ThomasWaldmann> ok, other questions / remarks for Marchael?
257 2011-08-16T18:10:42 * dreimark not now
258 2011-08-16T18:11:08 <ThomasWaldmann> Marchael: yes, we can do some stuff after SOC also. for final evals only the stuff done within SOC counts, though.
259 2011-08-16T18:11:28 <Marchael> ok
260 2011-08-16T18:11:53 <ThomasWaldmann> ok, so thanks Marchael. sinha, your stage. :)
261 2011-08-16T18:11:58 <sinha> okay
262 2011-08-16T18:12:15 <sinha> LAST: Worked on further improvements on index page
263 2011-08-16T18:12:15 <sinha> i) Implemented the ajax delete feature, CS: https://bitbucket.org/sinha/moin2/changeset/5c86980e7d06
264 2011-08-16T18:12:15 <sinha> ii) Similary ajax destroy feature, CS: https://bitbucket.org/sinha/moin2/changeset/92314b3890a8
265 2011-08-16T18:12:15 <sinha> iii) And also option to add new item also implemented, along with the already done upload file thing, CS: https://bitbucket.org/sinha/moin2/changeset/050c5d125762 (needs some improvement)
266 2011-08-16T18:12:15 <sinha> CURRENT: Has to do some cleaning (modifictation) of earlier written codes in global_history and index.
267 2011-08-16T18:12:16 <sinha> NEXT: If there will be time then, i will do that on demand loading of meta (using ajax).
268 2011-08-16T18:12:36 <sinha> this is current screen shot http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-16?action=AttachFile&do=get&target=index.png
269 2011-08-16T18:13:50 <ThomasWaldmann> about the screenshot:
270 2011-08-16T18:14:26 <ThomasWaldmann> i can guess the meaning of the topmost field that has XMen/, but for normal users I think there should be some label
271 2011-08-16T18:14:44 <ThomasWaldmann> (or even some more words?)
272 2011-08-16T18:14:54 <sinha> there is a placeholder defined
273 2011-08-16T18:15:16 <sinha> but by default i am putting the item prefix in the box, such that one can create subitem of that item
274 2011-08-16T18:15:27 <ThomasWaldmann> ah, so it always shows that until you start typing?
275 2011-08-16T18:15:42 <ThomasWaldmann> well, as soon as you put something in there, noone sees placeholder
276 2011-08-16T18:15:48 <sinha> yes
277 2011-08-16T18:15:54 <sinha> i guess i have to put a labe
278 2011-08-16T18:15:56 <sinha> *
279 2011-08-16T18:15:57 <sinha> l
280 2011-08-16T18:16:04 <ThomasWaldmann> (that's one of the biggest issues with placeholders and also with autofocus)
281 2011-08-16T18:16:13 <sinha> hmm
282 2011-08-16T18:16:31 <pkumar> re
283 2011-08-16T18:16:31 <ThomasWaldmann> "close" there just means close that little window?
284 2011-08-16T18:16:50 <dreimark> sinha: make some generic item index pages, so these can be used for documentation purposes too
285 2011-08-16T18:17:07 <dreimark> generic in the meaning, something moin related
286 2011-08-16T18:17:28 <dreimark> e.g. different Help names
287 2011-08-16T18:17:32 <dreimark> as on 1.9
288 2011-08-16T18:17:46 <dreimark> ThomasWaldmann: yes
289 2011-08-16T18:18:02 <ThomasWaldmann> why not the usual X in the title?
290 2011-08-16T18:18:23 <dreimark> sinha: ^
291 2011-08-16T18:18:34 <sinha> it could be done, but actually that popup box will also be serving as comment box for delete/destroy
292 2011-08-16T18:18:55 <sinha> and i already had Cancel in them, so putting X will do the same thing, hence i skipped that
293 2011-08-16T18:19:21 <dreimark> we should show the usual window ways to close stuff
294 2011-08-16T18:20:02 <sinha> okay i will add that too
295 2011-08-16T18:20:04 <dreimark> it is duplicated for the functionality but this is known to the user
296 2011-08-16T18:21:10 <dreimark> sinha: "Using MoinMoin"
297 2011-08-16T18:21:21 <dreimark> should get a section for History and Index
298 2011-08-16T18:21:38 <dreimark> with some brief examples describing the functionality
299 2011-08-16T18:21:54 <ThomasWaldmann> on normal web pages I somehow reduced usage of "Cancel", because it is somehow superfluous - you can just click anywhere else than "Save"
300 2011-08-16T18:22:00 <dreimark> for History you can look at Recent Changes in 1.9
301 2011-08-16T18:22:32 <sinha> dreimark: you mean i add them here http://moinmo.in/HelpForUsers
302 2011-08-16T18:22:33 <dreimark> ThomasWaldmann: that won't work with that window, it stays in foreground and did not vanish
303 2011-08-16T18:22:36 <ThomasWaldmann> btw, i prefer to not have "Help wiki pages" for now.
304 2011-08-16T18:22:45 <ThomasWaldmann> and maybe never ever again.
305 2011-08-16T18:23:00 <ThomasWaldmann> rather do sphinx docs additions
306 2011-08-16T18:23:07 <dreimark> sinha: no to the sphinx doc
307 2011-08-16T18:23:14 <dreimark> it is in your repo
308 2011-08-16T18:23:39 <dreimark> moin-2.0-sinha/docs
309 2011-08-16T18:23:57 <dreimark> a older compiled version is http://static.moinmo.in/m2/html/
310 2011-08-16T18:24:19 <ThomasWaldmann> or just do make html and point browser to filesystem there
311 2011-08-16T18:24:39 <sinha> yes it could be easier
312 2011-08-16T18:25:17 <sinha> dreimark: if i have to do it in sphinx how do i add them ?
313 2011-08-16T18:25:33 <ThomasWaldmann> that thing that looks like [] ^ is also a bit strange
314 2011-08-16T18:25:34 <sinha> i mean can i open that docs directory in browser
315 2011-08-16T18:25:54 <dreimark> sinha: you need to write in reST and you can create files in that dir
316 2011-08-16T18:26:00 <ThomasWaldmann> (on the screenshot, left of "Filter by content type ^"
317 2011-08-16T18:26:30 <sinha> its just a arrow, which points upward/downward based on the visibility of the form
318 2011-08-16T18:26:39 <sinha> which appears after clicking on that
319 2011-08-16T18:26:57 <ThomasWaldmann> so should it be labelled "Create item"?
320 2011-08-16T18:27:29 <dreimark> ThomasWaldmann: rather actions, because you see all ajax actions
321 2011-08-16T18:27:43 <ThomasWaldmann> ok, so "Actions"?
322 2011-08-16T18:28:14 <dreimark> sinha: yeah a label is neede there
323 2011-08-16T18:28:44 <ThomasWaldmann> sinha: btw, you could grab any friend or family member to do usability tests :D
324 2011-08-16T18:29:11 <sinha> yes i could do that :)
325 2011-08-16T18:30:44 <dreimark> docs/user is a good place for this kind of documentation
326 2011-08-16T18:31:31 <sinha> dreimark: i simply open the file in vim and write the things
327 2011-08-16T18:32:17 <dreimark> create new files, yes, and there is lots of docs about sphinx on the net
328 2011-08-16T18:32:34 <dreimark> also whole python doc is done with it, click "show Source"
329 2011-08-16T18:32:46 <dreimark> if you need further examples
330 2011-08-16T18:32:53 <sinha> ok
331 2011-08-16T18:33:19 <dreimark> e.g. http://sphinx.pocoo.org/
332 2011-08-16T18:34:52 * dreimark more questions to sinha ?
333 2011-08-16T18:35:42 <ThomasWaldmann> not from me now
334 2011-08-16T18:36:06 <ThomasWaldmann> ok, pkumar / xorAxAx - your stage
335 2011-08-16T18:36:21 <pkumar> This week:
336 2011-08-16T18:36:22 <pkumar> Worked on improvement of test coverage in auth module.
337 2011-08-16T18:36:22 <pkumar> worked on the test cleanup. As MoinMoin tests do not init app for all the tests anymore, still there were some tests which needed app initialization due to creation of items and lack of clean up after each test like in storage, datastruct, items and apps. added method so that these items can be removed after each test. as a result app initializations removed from those tests. now the tests have become significantly faster. Also, worked on unicode/str ass
338 2011-08-16T18:36:22 <pkumar> ertion errors in items, though that was kinda useless but have fixed it for items for now. tried with fresh clone, seem to work fine.
339 2011-08-16T18:36:24 <pkumar> Next week will work on documentation on the MoinMoin tests/testing work. check for the errors/failures in tests after merging the repos of students. Final look at test coverage improvement, will add if required. Also go through testing architecture to ensure if I can improve some stuffs there.
340 2011-08-16T18:37:09 <ThomasWaldmann> yay for faster tests :)
341 2011-08-16T18:37:27 <xorAxAx> hi from torun
342 2011-08-16T18:37:29 <pkumar> hehe
343 2011-08-16T18:37:45 <pkumar> hi xorAxAx , welcome
344 2011-08-16T18:38:11 <pkumar> :)
345 2011-08-16T18:38:30 <xorAxAx> thanks :)
346 2011-08-16T18:38:56 <ThomasWaldmann> plan sounds good for me.
347 2011-08-16T18:39:44 <pkumar> ThomasWaldmann : the only requirement here is to have a merged repo
348 2011-08-16T18:40:12 <ThomasWaldmann> pkumar: so, all tests that need app, cfg or storage somehow, need to init the app in setup_*?
349 2011-08-16T18:40:17 <dreimark> pkumar: have you measured speed up?
350 2011-08-16T18:41:07 <pkumar> ThomasWaldmann : yes, they needed earlier due to lack of cleanup, not any more
351 2011-08-16T18:41:45 <pkumar> dreimark : yes, not exactly but it is approx half of what it used to be on the first day of project
352 2011-08-16T18:41:53 <ThomasWaldmann> hm, so what do they need now?
353 2011-08-16T18:42:10 <pkumar> dreimark : I'll have more accurate details
354 2011-08-16T18:42:53 <pkumar> ThomasWaldmann : they work with the previous app initializations as when apps are empty they are as good as new in this context
355 2011-08-16T18:42:57 <ThomasWaldmann> xorAxAx: what are you doing there, btw? :)
356 2011-08-16T18:43:15 <xorAxAx> holidays
357 2011-08-16T18:43:33 <xorAxAx> pythonpolandcitytrip
358 2011-08-16T18:43:36 <ThomasWaldmann> hanging around with sheep? :)
359 2011-08-16T18:44:05 <xorAxAx> did so yesterday
360 2011-08-16T18:44:54 <ThomasWaldmann> pkumar: ok, sounds good
361 2011-08-16T18:45:15 <ThomasWaldmann> pkumar: what's the current failure count?
362 2011-08-16T18:46:13 <pkumar> ThomasWaldmann : 29 it seems
363 2011-08-16T18:46:33 <pkumar> all are in converter and in storage
364 2011-08-16T18:46:43 <ThomasWaldmann> and should every test that does not fail really succeed? :)
365 2011-08-16T18:47:37 <ThomasWaldmann> any other questions for pkumar?
366 2011-08-16T18:47:56 <pkumar> ThomasWaldmann : I tried failing th tests as suggested by xorAxAx , they functions the same as earlier tests
367 2011-08-16T18:48:18 * dreimark not now
368 2011-08-16T18:48:39 * ThomasWaldmann neither.
369 2011-08-16T18:49:08 <ThomasWaldmann> ok, looks like we are through for today. happy hacking! :)
370 2011-08-16T18:50:33 <pkumar> xorAxAx : happy holidays :)
371 2011-08-16T18:51:11 <xorAxAx> Thanks
372 2011-08-16T18:51:25 * dreimark greets from noderney
373 2011-08-16T18:54:03 *** mkerrin
374 2011-08-16T18:57:41 <pkumar> brb
375 2011-08-16T19:09:15 <dreimark> bbl
376 2011-08-16T19:24:31 *** greg_f
377 2011-08-16T19:51:35 *** Marchael
378 2011-08-16T20:27:06 *** pkumar
379 2011-08-16T21:36:06 *** raignarok
380 2011-08-16T21:53:52 * ThomasWaldmann merges
381 2011-08-16T22:17:56 *** raignarok
382 2011-08-16T22:18:49 <dreimark> re
383 2011-08-16T22:42:50 <ThomasWaldmann> duck!
384 2011-08-16T22:43:13 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 321:28093a47a961 2.0/MoinMoin/search/ (4 files in 2 dirs): Whoosh schemas for items and revisions, analyzer for "item name" field and tokenizers for "acl" and "mimetype" fields of whoosh's schema. Write simple tests for acl and mimetype tokenizers.
385 2011-08-16T22:43:14 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 322:3872b8328dd5 2.0/MoinMoin/ (16 files in 8 dirs): Sync with Thomas Waldmann repo
386 2011-08-16T22:43:14 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 323:bc7b8834eff5 2.0/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py): Fixed item_name_tokenizer() and test for it.
387 2011-08-16T22:43:15 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 324:999e33243b26 2.0/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py): Add Whoosh MultiFilter() to item_name_analyzer, fix test.
388 2011-08-16T22:43:16 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 325:a1273e8734a3 2.0/MoinMoin/search/indexing.py: Add opening\creating index files for Whoosh schema
389 2011-08-16T22:43:16 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 326:53420a55b1bc 2.0/MoinMoin/search/ (analyzers.py indexing.py):
390 2011-08-16T22:43:17 <CIA-114> Fix some places in open_index(), add draft for indexing schema test
391 2011-08-16T22:43:17 <CIA-114> (great thanks to Thomas Waldmann!)
392 2011-08-16T22:43:17 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 327:1de89cc3a6bd 2.0/MoinMoin/ (9 files in 8 dirs): Merged with Thomas Waldmann's repo
393 2011-08-16T22:43:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 328:07271d66ea5b 2.0/MoinMoin/search/ (4 files in 2 dirs): Fixing wrong value names, add finally done with tests for indexing schemas
394 2011-08-16T22:43:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 329:7d32ff657987 2.0/ (MoinMoin/search/analyzers.py setup.py): Add whoosh to dependencies, remove useless comment
395 2011-08-16T22:43:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 330:a3c707668331 2.0/MoinMoin/search/ (3 files in 2 dirs): Fix some name issues
396 2011-08-16T22:43:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 331:a46852031865 2.0/MoinMoin/search/_tests/test_indexing.py: Changes in test algorithm in test_indexing.py
397 2011-08-16T22:43:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 332:779eee3e39d8 2.0/MoinMoin/search/ (_tests/test_indexing.py indexing.py): Removed "metadata" field from whoosh schema
398 2011-08-16T22:43:21 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 333:e6fb11f35a84 2.0/MoinMoin/search/indexing.py: Added wikiname/userid/address/hostname/ to whoosh schema
399 2011-08-16T22:43:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 334:21860894d4dd 2.0/MoinMoin/search/_tests/test_indexing.py: Rewrited some parts of test_indexing.py using new schemas
400 2011-08-16T22:43:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 335:d5c124222533 2.0/MoinMoin/ (5 files in 4 dirs): Building indexes, minor fixing in schemas, add forgotten imports
401 2011-08-16T22:43:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 336:98cbec45cffb 2.0/MoinMoin/ (3 files in 3 dirs): Fiexes in flask-script for rebuilding indexes. Python2.6 compatibility. Make changes in schema for better integration with Moin.
402 2011-08-16T22:43:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 337:3f7914a961e0 2.0/MoinMoin/ (3 files in 3 dirs): Remove useless code, change whoosh schema fieldname for better MoinMoin backend compatibility.
403 2011-08-16T22:43:26 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 338:fd2248ba64c8 2.0/MoinMoin/script/maint/build_indexes.py: Fix some typos in build_indexes.py
404 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 339:f69fa81b34b6 2.0/MoinMoin/script/maint/build_indexes.py: Saving revision number into indexes
405 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 340:078c2ee0c19a 2.0/MoinMoin/script/maint/build_indexes.py: Convert date from os.path.mtime() format to datetime
406 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 341:4b052f23b24a 2.0/MoinMoin/script/maint/build_indexes.py: Change date format
407 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 342:beb99cd78481 2.0/MoinMoin/script/ (__init__.py maint/update_indexes.py): Add draft for updating index
408 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 343:28858876a5f1 2.0/MoinMoin/script/maint/update_indexes.py: Some fixes in update script with debug output
409 2011-08-16T22:43:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 344:4dba3eece489 2.0/MoinMoin/script/maint/update_indexes.py: Bugfixes in update_script.py
410 2011-08-16T22:43:37 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 345:b646d3764eb6 2.0/MoinMoin/script/maint/build_indexes.py: Add building path option to rebuild indexes script
411 2011-08-16T22:43:37 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 346:750781283141 2.0/MoinMoin/script/maint/build_indexes.py:
412 2011-08-16T22:43:37 <CIA-114> Replace multisegment writer by normal writer because
413 2011-08-16T22:43:37 <CIA-114> it has bug with writing to indexes. I'll add it again
414 2011-08-16T22:43:38 <CIA-114> when new whoosh version will released.
415 2011-08-16T22:43:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 347:c14527438f0d 2.0/MoinMoin/script/maint/build_indexes.py:
416 2011-08-16T22:43:39 <CIA-114> Refactoring in build index script:
417 2011-08-16T22:43:39 <CIA-114> CHANGES:
418 2011-08-16T22:43:40 <CIA-114> Indexes build in index_dir_tmp(defined in local config)
419 2011-08-16T22:43:40 <CIA-114> Cleaning base indexes with --action clean
420 2011-08-16T22:43:41 <CIA-114> Moving indexes from index_dir_tmp location to index_dir_tmp(now working for all-revs and latest-revs)
421 2011-08-16T22:43:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 348:46cda7e03229 2.0/ (3 files in 3 dirs): Minor fixes at build indexes script, add documentation for admin
422 2011-08-16T22:43:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 349:fdfa75114e83 2.0/ (MoinMoin/script/__init__.py docs/admin/buildindexes.rst): Update documentation, fixes in build script
423 2011-08-16T22:43:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 350:b0855eb191e1 2.0/MoinMoin/script/maint/ (build_indexes.py update_indexes.py): Fix giant bug in update index script, add "--for" option for partly updating
424 2011-08-16T22:43:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 351:3ec32fa2fe01 2.0/ (3 files in 2 dirs): Merge update index and build index script to one, improvements in cli syntax
425 2011-08-16T22:43:47 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 352:7ad7f9472ae0 2.0/ (3 files in 3 dirs):
426 2011-08-16T22:43:47 <CIA-114> Fixing some names for better usability,
427 2011-08-16T22:43:51 <CIA-114> changes in move functions(not it remove old indexes before add new),
428 2011-08-16T22:43:51 <CIA-114> fix bug with copy empty indexes.
429 2011-08-16T22:43:51 <CIA-114> TODO: whoosh searcher can't find items moving to trash, so it continuely try to add trashed revisions to index.
430 2011-08-16T22:43:51 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 353:cbf97d9067f3 2.0/ (33 files in 15 dirs): Merging with main repo
431 2011-08-16T22:43:52 <CIA-114> (12 lines omitted)
432 2011-08-16T22:44:05 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 385:c5cc63fd82f6 2.0/ (4 files in 4 dirs):
433 2011-08-16T22:44:05 <CIA-114> Content indexing support
434 2011-08-16T22:44:05 <CIA-114> - backend_to_index() moved to MoinMoin.search.revision_converter and can be used from other places
435 2011-08-16T22:44:05 <CIA-114> - Using plain text converters(thanks Thomas Waldmann) for creating indexable output
436 2011-08-16T22:44:06 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 390:14a9f545934d 2.0/MoinMoin/ (search/revision_converter.py storage/backends/indexing.py): Fix issue with content indexing, improve indexing perfomance for runtime and start up
437 2011-08-16T22:44:08 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 391:293e27b399b7 2.0/MoinMoin/ (3 files in 3 dirs): Showing highlighted results on search results page
438 2011-08-16T22:44:08 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 392:42f7af473347 2.0/MoinMoin/script/maint/index.py: Fix issue with indexing users in backend
439 2011-08-16T22:44:09 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 389:1691f2cb863d 2.0/MoinMoin/ (4 files in 2 dirs): merged
440 2011-08-16T22:44:10 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 397:65c2c01aa266 2.0/MoinMoin/ (search/revision_converter.py storage/backends/indexing.py): Fixing issue with double content indexing, cosmetic changes in debug output
441 2011-08-16T22:44:12 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 399:fdd1b2dec689 2.0/MoinMoin/ (3 files in 3 dirs): Improved index --for ... --action show output, syntax change in css class name
442 2011-08-16T22:44:13 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 398:a9b78e0231c6 2.0/MoinMoin/ (apps/frontend/views.py templates/search_results.html): Remove small search field at top right on search result template
443 2011-08-16T22:44:14 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 403:79d80bcd1d32 2.0/MoinMoin/script/maint/index.py:
444 2011-08-16T22:44:14 <CIA-114> Fixes issue https://bitbucket.org/marchael/moin-2.0/issue/11/moin-index-script-wrong-unhelpful-texts
445 2011-08-16T22:44:14 <CIA-114> Fixes #11.
446 2011-08-16T22:44:15 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 404:951c8edf9776 2.0/MoinMoin/storage/backends/indexing.py:
447 2011-08-16T22:44:15 <CIA-114> remove ItemIndex.history (was replaced by history_whoosh)
448 2011-08-16T22:44:15 <CIA-114> remove all kvstore usage (was intended to store user-defined metadata,
449 2011-08-16T22:44:16 <CIA-114> but we'll use whoosh dynamic fields for that soon)
450 2011-08-16T22:44:16 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 406:256c6e0ae8bf 2.0/MoinMoin/storage/backends/indexing.py: removed all_tags / tagged_items, replaced by *_whoosh
451 2011-08-16T22:44:18 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 408:8cc72401fc25 2.0/ (9 files in 6 dirs): (log message trimmed)
452 2011-08-16T22:44:20 <CIA-114> indexing: remove sqlalchemy based indexing code (is done by whoosh now)
453 2011-08-16T22:44:20 <CIA-114> rename some methods from *_whoosh to * (as there are no others any more,
454 2011-08-16T22:44:20 <CIA-114> all indexing is based on whoosh now).
455 2011-08-16T22:44:20 <CIA-114> added some "XXX wrong" comments to indexing, where item and revision level
456 2011-08-16T22:44:21 <CIA-114> was confused.
457 2011-08-16T22:44:21 <CIA-114> cfg.index_uri was removed as well as index_uri Backend kwarg (both were only
458 2011-08-16T22:44:22 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 409:598b1731069b 2.0/MoinMoin/ (app.py config/default.py storage/backends/indexing.py): remove cfg.index_rebuild and related code (not needed any more)
459 2011-08-16T22:44:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 402:ab4ac448d5d8 2.0/ (15 files in 12 dirs): merged
460 2011-08-16T22:44:34 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 430:78a2962bf192 2.0/ (3 files in 3 dirs): Fixed displaying results for multiple wikis(wiki farm) Fixes #15.
461 2011-08-16T22:44:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 432:66981eb25822 2.0/MoinMoin/ (3 files in 2 dirs): Added searching in non-current revisions Fixes #18.
462 2011-08-16T22:44:38 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 418:e362e7abfda6 2.0/MoinMoin/search/ (_tests/test_indexing.py analyzers.py): merged whoosh repo
463 2011-08-16T22:44:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 436:6d1f88659ab1 2.0/MoinMoin/ (4 files in 3 dirs): Add dynamic fields support(may be don't work for last revs after rebuilding)
464 2011-08-16T22:44:39 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 435:a2aee9baecd3 2.0/whoosh200-highlight-mode-fix.patch: removed whoosh-highlighting patch due issue was fixed in 2.1.0
465 2011-08-16T22:44:40 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 372:f7c91c4b601a 2.0/ (3 files in 3 dirs): Fixed issue with interwikiname
466 2011-08-16T22:44:42 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 441:7a5557f9355f 2.0/MoinMoin/ (4 files in 3 dirs): merge
467 2011-08-16T22:44:44 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 433:406966afa113 2.0/MoinMoin/apps/frontend/views.py: Using name_exact schema field for wildcard searching Fixes #26.
468 2011-08-16T22:44:44 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 444:6b4f5e5850a3 2.0/MoinMoin/storage/backends/indexing.py: fixed issue with destroying items. Revisions don't deleted from all revisions index Fixes #33.
469 2011-08-16T22:44:45 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 364:daedbbcaa1cb 2.0/MoinMoin/script/maint/index.py: Removed break import line
470 2011-08-16T22:44:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 377:369af927b0a8 2.0/MoinMoin/ (3 files in 2 dirs): Merged
471 2011-08-16T22:44:48 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 405:2dc35ebbc43a 2.0/MoinMoin/util/kvstore.py: removed MoinMoin.util.kvstore - not used any more
472 2011-08-16T22:44:49 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 393:1ed44f76458c 2.0/ (4 files in 2 dirs): merged
473 2011-08-16T22:44:50 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 442:d71800ea7e4c 2.0/ (4 files in 3 dirs): merged
474 2011-08-16T22:44:51 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 438:33249607fd48 2.0/MoinMoin/script/maint/index.py: Refactoing crap in building script Fixes #32.
475 2011-08-16T22:44:52 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 443:b8ebdf2c816e 2.0/docs/ (index.rst admin/index.rst): Updated admin docs
476 2011-08-16T22:44:56 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 417:d49d08bb5f50 2.0/MoinMoin/ (3 files in 3 dirs): merged whoosh repo
477 2011-08-16T22:45:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 395:e57259c40f74 2.0/MoinMoin/themes/modernized/static/css/common.css: Using white backgroung for long search form
478 2011-08-16T22:45:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 437:dccbd79260ce 2.0/MoinMoin/search/indexing.py: Added several dynamic fields Fixes #17.
479 2011-08-16T22:45:03 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 400:ea001bcb5f90 2.0/MoinMoin/ (script/maint/index.py storage/backends/indexing.py):
480 2011-08-16T22:45:03 <CIA-114> Fixed issue with runtime indexation https://bitbucket.org/marchael/moin-2.0/issue/9/content-entered-via-wiki-ui-is-not-indexed
481 2011-08-16T22:45:03 <CIA-114> Fixes issue with content indexing in building\updating script
482 2011-08-16T22:45:04 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 428:643dd888e74a 2.0/MoinMoin/templates/search_results.html: Fixed showing results for wikis sharing one index
483 2011-08-16T22:45:05 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 387:05657b355ce4 2.0/MoinMoin/search/ (_tests/test_analyzers.py analyzers.py indexing.py): Fix ACL indexing issue for preloaded items with acl field (thanks brunomartin and Thomas Waldmann)
484 2011-08-16T22:45:06 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 410:0f9a97f74a8d 2.0/MoinMoin/storage/backends/indexing.py: Fixed https://bitbucket.org/marchael/moin-2.0/issue/3/dicts-are-bad-for-sorting Fixes #3.
485 2011-08-16T22:45:09 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 407:72278e056ec4 2.0/MoinMoin/storage/backends/indexing.py: indexing: removed/commented unused code
486 2011-08-16T22:45:09 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 368:430223bb9701 2.0/whoosh184-fix.patch: Add missing ^M in whoosh patch
487 2011-08-16T22:45:10 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 366:79a8c0c5a820 2.0/setup.py: Strict checking for whoosh version
488 2011-08-16T22:45:11 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 363:c552332cb53e 2.0/MoinMoin/ (3 files in 3 dirs): Content indexing for runtime working and scripts, fix bug in move_index()
489 2011-08-16T22:45:12 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 396:3c1d17e77d1c 2.0/MoinMoin/storage/backends/indexing.py: Return removed line for converting backend revision to whoosh index
490 2011-08-16T22:45:13 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 431:6800ab9dd159 2.0/MoinMoin/templates/search_results.html: fixed acl search issue Fixes #14
491 2011-08-16T22:45:15 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 420:e2d16dadf565 2.0/MoinMoin/search/analyzers.py: merged whoosh repo
492 2011-08-16T22:45:16 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 384:8b39c8a2140e 2.0/setup.py: return whoosh back
493 2011-08-16T22:45:18 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 411:6f6a29825a1e 2.0/MoinMoin/ (3 files in 3 dirs): Fixed test_sourcecode failures
494 2011-08-16T22:45:19 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 427:0248b030a814 2.0/MoinMoin/templates/search_results.html: Fixes translation issue Fixes #25.
495 2011-08-16T22:45:21 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 382:0fd6527bd6aa 2.0/ (3 files in 3 dirs): merged
496 2011-08-16T22:45:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 434:5d805b9f5e91 2.0/setup.py: Require whoosh version not lesser than 2.1.0 Fixes #18.
497 2011-08-16T22:45:29 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 383:ea543ad2fb6c 2.0/MoinMoin/ (3 files in 2 dirs): temporarily remove acl fields from the schema due to pickle issues
498 2011-08-16T22:45:30 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 439:81744c1ebd2e 2.0/docs/admin/buildindexes.rst: remove outdated docs
499 2011-08-16T22:45:31 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 358:0adb935309cb 2.0/: fixing multiple heads
500 2011-08-16T22:45:32 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 375:c9653e23e167 2.0/ (3 files in 3 dirs): Fixed runtime and offline indexation, if interwiki was None, moin crashed
501 2011-08-16T22:45:33 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 374:748523da8db6 2.0/MoinMoin/ (26 files in 3 dirs): Merged
502 2011-08-16T22:45:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 401:215d7a8f5b3e 2.0/MoinMoin/ (3 files in 3 dirs):
503 2011-08-16T22:45:35 <CIA-114> Fixes #6.
504 2011-08-16T22:45:35 <CIA-114> Fixing https://bitbucket.org/marchael/moin-2.0/issue/6/unpretty-search-results-rendering
505 2011-08-16T22:45:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 359:c41fdeb81880 2.0/setup.py: fixing before merge
506 2011-08-16T22:45:39 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 440:2340dd0ee580 2.0/MoinMoin/ (4 files in 3 dirs):
507 2011-08-16T22:45:39 <CIA-114> move backend_to_index function to MoinMoin.search.indexing module
508 2011-08-16T22:45:39 <CIA-114> as the schema is defined there, it makes sense that the conversion function
509 2011-08-16T22:45:39 <CIA-114> is also there.
510 2011-08-16T22:45:40 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 424:0b400626bc93 2.0/MoinMoin/search/revision_converter.py: rev converter: misc src cosmetics
511 2011-08-16T22:45:41 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 361:6111e4d47e04 2.0/ (12 files in 6 dirs): merged
512 2011-08-16T22:45:46 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 369:5c6ef2031235 2.0/MoinMoin/ (5 files in 3 dirs): Update dosctrings for MoinMoin.search, add (c) in MoinMoin.storage.backends.indexing
513 2011-08-16T22:45:49 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 394:0ab852761ff2 2.0/MoinMoin/apps/frontend/views.py: Using Multifield parser for searching in revisions name and content
514 2011-08-16T22:45:50 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 422:91b72ea6039e 2.0/MoinMoin/search/indexing.py: indexing: misc src cosmetics
515 2011-08-16T22:45:51 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 362:29cc4f25eec8 2.0/ (MoinMoin/converter/moinwiki_out.py setup.py): Ignoring href splitting for IRI in moinwiki_out
516 2011-08-16T22:45:53 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 415:d755f798fe66 2.0/MoinMoin/ (8 files in 6 dirs):
517 2011-08-16T22:45:53 <CIA-114> fix some tests
518 2011-08-16T22:45:53 <CIA-114> make item name and contenttype constants unicode
519 2011-08-16T22:45:53 <CIA-114> give cfg kwarg to RouterBackend
520 2011-08-16T22:45:53 <CIA-114> delay tokenizer creation to test method call time, so that we're within a test
521 2011-08-16T22:45:54 <CIA-114> request environment and app is available.
522 2011-08-16T22:45:54 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> default * 445:0f29cbb71223 2.0/MoinMoin/search/indexing.py: Using scoring name and name_exact fields to improve search results Fixes #30.
523 2011-08-16T22:47:31 <brunomartin> yeah! :-D
524 2011-08-16T22:49:20 <ThomasWaldmann> ;)
525 2011-08-16T23:14:38 * dreimark pulls
526 2011-08-16T23:28:07 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/459608/
527 2011-08-16T23:28:20 <dreimark> after upgrade of my env
528 2011-08-16T23:31:47 <ThomasWaldmann> but it starts nevertheless, right?
529 2011-08-16T23:36:19 <dreimark> yes, it starts did not crash and seems to work
530 2011-08-16T23:37:46 <ThomasWaldmann> some converters need a running request to work, this is known and todo
531 2011-08-16T23:43:06 *** sinha
532 2011-08-16T23:57:06 <dreimark> gn
533 2011-08-16T23:58:15 <ThomasWaldmann> gn dreimark
