MoinMoin: MoinMoinChat/Logs/moin-dev/2011-10-08

   1 2011-10-08T01:26:48  *** raignarok has quit IRC
   2 2011-10-08T04:05:20  *** MattMaker has quit IRC
   3 2011-10-08T04:36:49  *** MattMaker has joined #moin-dev
   4 2011-10-08T07:44:21  *** MattMaker has quit IRC
   5 2011-10-08T08:40:59  *** raignarok has joined #moin-dev
   6 2011-10-08T09:36:01  *** raignarok has quit IRC
   7 2011-10-08T10:13:55  <dreimark> moin
   8 2011-10-08T10:15:57  *** raignarok has joined #moin-dev
   9 2011-10-08T10:16:16  <ThomasWaldmann> moin
  10 2011-10-08T10:17:49  <dreimark> moin
  11 2011-10-08T10:29:05  *** raignarok has quit IRC
  12 2011-10-08T10:34:28  *** raignarok has joined #moin-dev
  13 2011-10-08T11:11:52  <ThomasWaldmann> is something keeping us back from merging storage-ng back into default branch?
  14 2011-10-08T11:23:18  <dreimark> ThomasWaldmann: is this : part solved?
  15 2011-10-08T11:24:32  <dreimark> that generates more requests by new people if it isn't
  16 2011-10-08T11:27:15  <ThomasWaldmann> no, it is not solved, but worked around by not using the router
  17 2011-10-08T11:29:03  <ThomasWaldmann> rsync: mkstemp "/home/tw/w/moin-2.0/dlc/.http%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2FX%2FXStatic-jQuery-File-Upload%2FXStatic-jQuery-File-Upload-4.4.2.tar.gz.content-type.O9OLTq" failed: File name too long (36)
  18 2011-10-08T11:29:08  <ThomasWaldmann> wtf?
  19 2011-10-08T11:30:17  * ThomasWaldmann is just rsyncing back some file to the freshly installed notebook that were also present at same place before
  20 2011-10-08T11:31:50  <ThomasWaldmann> old: ext3, new: ext4
  21 2011-10-08T11:38:30  <dreimark> arg
  22 2011-10-08T11:39:22  <dreimark> ext4 gazillion of files but a length limit less than ext3?
  23 2011-10-08T11:39:56  * dreimark has to prepare leaving the hotel
  24 2011-10-08T11:41:43  <dreimark> bbl
  25 2011-10-08T11:47:02  <ThomasWaldmann> it is a ecryptfs issue: https://bugs.launchpad.net/ecryptfs/+bug/344878
  26 2011-10-08T11:47:23  <ThomasWaldmann> that is the stuff ubuntu offers in the desktop install for home directory encryption
  27 2011-10-08T11:48:24  <ThomasWaldmann> i used luks/dmcrypt before, so i didn't have that kind of issue. fsck, i guess i have to reinstall. :(
  28 2011-10-08T12:34:30  * ThomasWaldmann reinstalls notebook, bbl.
  29 2011-10-08T12:42:23  <dreimark> re
  30 2011-10-08T12:52:10  *** raignarok_ has joined #moin-dev
  31 2011-10-08T12:54:46  *** raignarok has quit IRC
  32 2011-10-08T13:03:56  <ThomasWaldmann> ok, system up again :)
  33 2011-10-08T13:08:54  * dreimark fast
  34 2011-10-08T13:11:47  <ThomasWaldmann> usb stick -> ssd :)
  35 2011-10-08T13:15:49  <ThomasWaldmann> and with pure ext4 on dmcrypt, suddenly long filenames start to work again :)
  36 2011-10-08T13:16:08  * ThomasWaldmann puts ecryptfs onto "avoid this" list
  37 2011-10-08T13:29:41  *** raignarok_ is now known as raignarok
  38 2011-10-08T14:16:40  *** greg_f has joined #moin-dev
  39 2011-10-08T15:41:26  *** kursor has joined #moin-dev
  40 2011-10-08T15:41:33  *** kursor has left #moin-dev
  41 2011-10-08T15:58:27  *** kursor has joined #moin-dev
  42 2011-10-08T16:04:05  *** kursor has quit IRC
  43 2011-10-08T16:11:03  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> storage-ng * 928:84f6b501129e 2.0/docs/admin/upgrade.rst: fix docs about 1.9 data import
  44 2011-10-08T16:40:16  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 929:0bf6b0dcb747 2.0/ (143 files in 43 dirs): (log message trimmed)
  45 2011-10-08T16:40:16  <CIA-65> merged storage-ng branch into default branch
  46 2011-10-08T16:40:16  <CIA-65> Please note:
  47 2011-10-08T16:40:16  <CIA-65> you need to reconfigure and recreate storage, start from scratch.
  48 2011-10-08T16:40:16  <CIA-65> if you have important content in moin2 and you can't just copy&paste it,
  49 2011-10-08T16:40:16  <CIA-65> you may want to wait for a storage converter and keep your repo at
  50 2011-10-08T16:40:17  <CIA-65> pre-storage-ng state (changeset 7f0a56769cbe ) until then.
  51 2011-10-08T16:42:25  <ThomasWaldmann> \o/
  52 2011-10-08T16:51:02  *** raignarok has quit IRC
  53 2011-10-08T17:02:54  * dreimark pulls, lets see if it works with gprs
  54 2011-10-08T17:03:36  <dreimark> fast
  55 2011-10-08T17:14:11  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 931:69b4656c4b45 2.0/setup.py: require sphinx 1.0.7 for now. 1.0.8 crashes.
  56 2011-10-08T17:14:12  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 930:187a8229ea15 2.0/docs/devel/api/ (30 files): update api docs
  57 2011-10-08T17:18:58  <dreimark> 1.1 is not far away
  58 2011-10-08T17:42:12  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 932:68a31ec0a64d 2.0/docs/admin/install.rst: install docs fixes
  59 2011-10-08T17:44:38  *** vedranm has joined #moin-dev
  60 2011-10-08T17:45:45  <vedranm> ThomasWaldmann: perhaps you could adjust sample config in docs for 1.9 import
  61 2011-10-08T17:46:12  <vedranm> it's using import os now
  62 2011-10-08T17:46:24  <vedranm> and interwiki name is after sitename
  63 2011-10-08T17:49:17  <ThomasWaldmann> there is some stuff missing also (storage config)
  64 2011-10-08T17:49:45  <vedranm> yes
  65 2011-10-08T17:51:56  <vedranm> ok, how long should import19 take for 50-page or so wiki?
  66 2011-10-08T17:52:35  <vedranm> wait, it's done :)
  67 2011-10-08T17:53:02  <vedranm> what does "Fix userids..." do?
  68 2011-10-08T17:53:13  <vedranm> and what does lost u'...' mean?
  69 2011-10-08T17:53:20  <vedranm> can I fix that stuff in my 1.9 installation?
  70 2011-10-08T17:56:01  <vedranm> well, it actually does look nice :)))
  71 2011-10-08T17:56:11  <vedranm> congrats :)
  72 2011-10-08T17:58:20  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 933:fb45cc507f6a 2.0/ (4 files in 4 dirs):
  73 2011-10-08T17:58:20  <CIA-65> make sqlalchemy optional, remove unused OrderedDict monkeypatch
  74 2011-10-08T17:58:20  <CIA-65> sqlalchemy is now optional for users of sqla store
  75 2011-10-08T17:58:20  <CIA-65> python 2.6 does not have OrderedDict, but no problem, we currently do
  76 2011-10-08T17:58:20  <CIA-65> not use it any more.
  77 2011-10-08T17:59:22  <ThomasWaldmann> vedranm: lost userids means that a userid is referred from history that does not exist as a user profile
  78 2011-10-08T18:00:07  <vedranm> ok
  79 2011-10-08T18:00:19  <vedranm> is it expected to have <<DateTime: execution failed [Bad timestamp u'2011-09-28T14': invalid literal for float(): 2011-09-28T14] (see also the log)>>)
  80 2011-10-08T18:00:33  <dreimark> yes that is wrong
  81 2011-10-08T18:00:38  <vedranm> and that Pygments don't work?
  82 2011-10-08T18:01:12  <dreimark> timestamp usually has hours and mins too
  83 2011-10-08T18:01:39  <vedranm> dreimark: well, it's what -- <unknown> <<DateTime(2011-10-08T22:00:03Z)>> generates in 1.9
  84 2011-10-08T18:01:52  <vedranm> ThomasWaldmann: it seems that user pages aren't imported
  85 2011-10-08T18:02:00  <vedranm> I get blank pages
  86 2011-10-08T18:02:14  <ThomasWaldmann> no, what sig generates has minutes and secs
  87 2011-10-08T18:02:45  * vedranm bows
  88 2011-10-08T18:02:47  <dreimark> no, that creates ReimarBauer <<DateTime(2011-10-08T17:02:25+0100)>>
  89 2011-10-08T18:02:47  <ThomasWaldmann> vedranm: user homepages are currently in conflict with user profiles, both have same name
  90 2011-10-08T18:03:05  <vedranm> so, it's intentional?
  91 2011-10-08T18:03:18  <ThomasWaldmann> it is a todo
  92 2011-10-08T18:03:26  <vedranm> ok, great then
  93 2011-10-08T18:03:38  <ThomasWaldmann> you see it when you look at history of that item
  94 2011-10-08T18:03:52  <ThomasWaldmann> it will have both userprofile and user homepage revs
  95 2011-10-08T18:04:25  <vedranm> I see
  96 2011-10-08T18:04:45  <vedranm> http:// and mailto: links aren't handled automatically?
  97 2011-10-08T18:05:45  <dreimark> [[ ]]
  98 2011-10-08T18:05:53  <vedranm> of course
  99 2011-10-08T18:06:08  <vedranm> that's better than what 1.9 does
 100 2011-10-08T18:06:10  <vedranm> great
 101 2011-10-08T18:06:15  <dreimark> we have also no CamelCase anymore
 102 2011-10-08T18:06:25  <vedranm> new "Contents" design is awesome
 103 2011-10-08T18:06:44  <dreimark> btw. if you want to help we really want help
 104 2011-10-08T18:07:00  <dreimark> brb
 105 2011-10-08T18:09:03  <vedranm> ok, there is some history weirdness
 106 2011-10-08T18:09:05  <vedranm> http://inf2.ffri.hr:8080/OS2
 107 2011-10-08T18:09:15  <vedranm> non-latest revision is shown
 108 2011-10-08T18:09:48  <vedranm> http://inf2.ffri.hr:8080/+history/OS2
 109 2011-10-08T18:09:54  <vedranm> author is "anonymous"
 110 2011-10-08T18:10:08  <vedranm> in 1.9 it's VedranMiletic http://inf2.ffri.hr/redwiki/OS2?action=info
 111 2011-10-08T18:13:36  *** MattMaker has joined #moin-dev
 112 2011-10-08T18:15:26  <vedranm> thanks for help guys
 113 2011-10-08T18:15:30  <vedranm> got to run
 114 2011-10-08T18:15:32  <vedranm> bbl
 115 2011-10-08T18:15:38  <vedranm> I would love to hep, dreimark
 116 2011-10-08T18:15:45  <vedranm> help^
 117 2011-10-08T18:28:53  <ThomasWaldmann> cu vedranm
 118 2011-10-08T18:29:19  * ThomasWaldmann ups requirement to werkzeug 0.8.1
 119 2011-10-08T18:33:46  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 934:ff6822d700e2 2.0/ (4 files in 4 dirs):
 120 2011-10-08T18:33:46  <CIA-65> require werkzeug 0.8.1, fix tests, remove old werkzeug related workarounds and monkeypatch
 121 2011-10-08T18:33:46  <CIA-65> removed the workaround for werkzeug.wsgi.LimitedStream (it now checks
 122 2011-10-08T18:33:46  <CIA-65> for size == -1 also)
 123 2011-10-08T18:49:09  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 935:56720a762aac 2.0/setup.py: raise Flask* requirements to latest releases
 124 2011-10-08T19:02:03  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 936:7ad58da75dbd 2.0/setup.py: raise other requirements - later stuff, less bugs
 125 2011-10-08T19:46:09  *** greg_f has quit IRC
 126 2011-10-08T19:57:00  *** raignarok has joined #moin-dev
 127 2011-10-08T21:15:48  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 937:c5b05cf0b196 2.0/MoinMoin/ (3 files in 3 dirs): use a constant for user profile content-type
 128 2011-10-08T21:15:49  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 938:046320bc0f82 2.0/MoinMoin/apps/frontend/views.py: implement +mychanges view - list all items the current user has contributed to
 129 2011-10-08T21:21:09  <vedranm> hi
 130 2011-10-08T21:21:17  <vedranm> so, how can I help with Moin 2.0?
 131 2011-10-08T21:25:18  <vedranm> ThomasWaldmann, how do I incorporate upgrade into Moin 2.0 installation after doing hg pull -u?
 132 2011-10-08T21:32:09  <ThomasWaldmann> if you used quickinstall, it uses moin from the workdir
 133 2011-10-08T21:32:32  <vedranm> so it's updated automatically?
 134 2011-10-08T21:32:36  <ThomasWaldmann> yes
 135 2011-10-08T21:33:15  <ThomasWaldmann> well, there is lots todo. not sure what matches your interests and capabilities best, though.
 136 2011-10-08T21:33:31  <vedranm> do you have a list online?
 137 2011-10-08T21:34:29  <ThomasWaldmann> there is an issue tracker on bitbucket
 138 2011-10-08T21:34:38  <ThomasWaldmann> it is all linked from MoinMoin2.0 page
 139 2011-10-08T21:34:48  <vedranm> ok
 140 2011-10-08T21:36:55  <ThomasWaldmann> if you discover new issues or have ideas, you can also add it there
 141 2011-10-08T21:37:37  <ThomasWaldmann> (but keep in mind that 2.0 should be a basic features release)
 142 2011-10-08T21:43:53  <vedranm> ok
 143 2011-10-08T21:44:03  <vedranm> can you give an example of some simple-to-fix bug?
 144 2011-10-08T21:47:07  <ThomasWaldmann>    mail_login is a bit ugly mixing username and password into one string
 145 2011-10-08T21:47:12  <ThomasWaldmann> todo from the docs :)
 146 2011-10-08T21:47:40  <vedranm> ok
 147 2011-10-08T21:47:42  <vedranm> sounds good
 148 2011-10-08T21:47:47  <vedranm> where do I look?
 149 2011-10-08T21:47:56  <ThomasWaldmann> that should be either a tuple, or (easier for non-pythonistas) 2 settings
 150 2011-10-08T21:48:14  <ThomasWaldmann> just grep for it
 151 2011-10-08T21:48:20  <vedranm> sure
 152 2011-10-08T21:51:27  <vedranm> so, it's username_space_password?
 153 2011-10-08T21:51:36  <ThomasWaldmann> currently, yes
 154 2011-10-08T21:51:40  <vedranm> ok
 155 2011-10-08T21:51:57  <ThomasWaldmann> you see it in the code, where it is used
 156 2011-10-08T21:52:04  <vedranm> sendmail.py
 157 2011-10-08T21:52:04  <ThomasWaldmann> btw, you use hg?
 158 2011-10-08T21:52:07  <vedranm> yes
 159 2011-10-08T21:52:09  <vedranm> love it :)
 160 2011-10-08T21:52:14  <ThomasWaldmann> great :)
 161 2011-10-08T21:52:22  <vedranm> and python too
 162 2011-10-08T21:52:37  <vedranm> so, great on both fronts
 163 2011-10-08T21:53:04  <vedranm> so, on sendmail.py:136 I have cfg.mail_login
 164 2011-10-08T21:53:12  <vedranm> and that's all
 165 2011-10-08T21:53:46  <ThomasWaldmann> if you fix it, also remove todo from docs
 166 2011-10-08T21:54:00  <vedranm> wait
 167 2011-10-08T21:54:03  <vedranm> let me understand
 168 2011-10-08T21:54:18  <vedranm> cfg is app.cfg which is flask.current_app
 169 2011-10-08T21:54:25  <vedranm> so I need to modify flask code?
 170 2011-10-08T21:56:47  <ThomasWaldmann> no, it is in MoinMoin.config.default
 171 2011-10-08T21:57:05  <ThomasWaldmann> search for login
 172 2011-10-08T21:57:24  <ThomasWaldmann> (some stuff is grouped, so the mail_ prefix is split off)
 173 2011-10-08T21:58:19  <vedranm> I see
 174 2011-10-08T22:02:13  <vedranm> can SMTP work without password?
 175 2011-10-08T22:02:26  <vedranm> i.e. what should be "default" value for password?
 176 2011-10-08T22:02:29  <vedranm> None or ''?
 177 2011-10-08T22:05:11  <ThomasWaldmann> well, as it is for authentication, username but no password doesn't make sense
 178 2011-10-08T22:05:31  <ThomasWaldmann> maybe None as default for both is best
 179 2011-10-08T22:05:52  <ThomasWaldmann> and both need to be not None for auth to be used
 180 2011-10-08T22:05:59  <vedranm> :)
 181 2011-10-08T22:06:00  <vedranm> sure
 182 2011-10-08T22:08:13  <vedranm> http://pastebin.com/nHwM8zsx
 183 2011-10-08T22:08:45  <vedranm> so I have to configure sendmail and test it now?
 184 2011-10-08T22:09:44  <ThomasWaldmann> line 23 - use "is not None", 2 times
 185 2011-10-08T22:10:34  <vedranm> ok
 186 2011-10-08T22:11:10  <ThomasWaldmann> and maybe use cfg.* directly a few lines below
 187 2011-10-08T22:12:49  <vedranm> http://pastebin.com/BzRYEyyL
 188 2011-10-08T22:16:53  <vedranm> why is "is not None" required? Only case where it would work is '' for username or password
 189 2011-10-08T22:17:32  <vedranm> and with is not None we allow it to be ''
 190 2011-10-08T22:17:35  <ThomasWaldmann> well, one exotic case might be username = "foo", password = ""
 191 2011-10-08T22:17:49  <vedranm> does sendmail allow that?
 192 2011-10-08T22:17:53  <ThomasWaldmann> that doesn't make sense, but is not invalid
 193 2011-10-08T22:17:57  <ThomasWaldmann> (AFAIK)
 194 2011-10-08T22:18:00  <vedranm> oh
 195 2011-10-08T22:18:01  <vedranm> ok
 196 2011-10-08T22:18:16  <vedranm> sure then
 197 2011-10-08T22:18:41  <ThomasWaldmann> so None means not configured / not used, any other string is ok (and the admin's problem in case if it is not ok)
 198 2011-10-08T22:18:58  <vedranm> makes sense
 199 2011-10-08T22:19:19  <vedranm> so, this is the bugfix?
 200 2011-10-08T22:19:27  <vedranm> i just need to test it and remove todo item?
 201 2011-10-08T22:22:55  <vedranm> and I don't see this todo item in docs/todo/todo.rst
 202 2011-10-08T22:23:31  <ThomasWaldmann> grep for mail_login in docs
 203 2011-10-08T22:23:54  <vedranm> got it :)
 204 2011-10-08T22:24:59  <ThomasWaldmann> do you have a mail server to test it with?
 205 2011-10-08T22:25:10  <vedranm> no, but I can install and configure fone
 206 2011-10-08T22:25:13  <vedranm> one^
 207 2011-10-08T22:25:26  <ThomasWaldmann> well, maybe too much work then
 208 2011-10-08T22:25:33  <vedranm> do you have one?
 209 2011-10-08T22:25:41  <ThomasWaldmann> we can test it at another time
 210 2011-10-08T22:25:44  <ThomasWaldmann> yes
 211 2011-10-08T22:25:47  <vedranm> great
 212 2011-10-08T22:26:23  <ThomasWaldmann> (testing not because of your change, but in general, that stuff has not seen tests for long likely)
 213 2011-10-08T22:26:54  <vedranm> http://pastebin.com/M3iVbc10
 214 2011-10-08T22:26:57  <vedranm> absolutely
 215 2011-10-08T22:27:12  <vedranm> I have never configured sendmail
 216 2011-10-08T22:27:20  <vedranm> but hopefully default config isn't too bad
 217 2011-10-08T22:27:46  <vedranm> perhaps I we could test it some time this week
 218 2011-10-08T22:28:18  <vedranm> so, will you commit this?
 219 2011-10-08T22:30:13  <ThomasWaldmann> well, if you want to contribute more often, you could fork moin-2.0 on bb
 220 2011-10-08T22:30:20  <ThomasWaldmann> but before you commit, fix bug in 30
 221 2011-10-08T22:31:01  <vedranm> logging.debug("trying to log in to smtp server using account '%s'" % user) ?
 222 2011-10-08T22:31:30  <vedranm> of course
 223 2011-10-08T22:31:33  <vedranm> you are right
 224 2011-10-08T22:32:30  <vedranm> can I use str.format?
 225 2011-10-08T22:32:36  <vedranm> is it prefered or not?
 226 2011-10-08T22:33:05  <ThomasWaldmann> we don't use it yet, but we should consider it and change it globally
 227 2011-10-08T22:33:24  <vedranm> well, you require 2.6
 228 2011-10-08T22:33:36  <vedranm> so it's not a problem to use it
 229 2011-10-08T22:34:01  <vedranm> it seems like something that is simple enough and I would like to take on at it
 230 2011-10-08T22:34:36  <ThomasWaldmann> sounds good :)
 231 2011-10-08T22:35:15  <vedranm> :)
 232 2011-10-08T22:35:16  <vedranm> ok
 233 2011-10-08T22:35:22  <vedranm> great
 234 2011-10-08T22:37:04  <ThomasWaldmann> can you do that systematically somehow?
 235 2011-10-08T22:37:37  <vedranm> regexp stuff?
 236 2011-10-08T22:40:54  <ThomasWaldmann> not sure if it can be fully automatized. i rather meant somehow making sure that you got all places that are better with that.
 237 2011-10-08T22:43:47  <vedranm> ThomasWaldmann: hopefully http://pastebin.com/5iPPGbsz
 238 2011-10-08T22:47:20  <ThomasWaldmann> ok.
 239 2011-10-08T22:47:32  <ThomasWaldmann> maybe as a general comment: try to keep changesets clean
 240 2011-10-08T22:47:42  <ThomasWaldmann> so, exactly work on one topic
 241 2011-10-08T22:49:01  <vedranm> so, I shouldn't use new str.format here?
 242 2011-10-08T22:50:13  <vedranm> sure
 243 2011-10-08T22:51:33  <vedranm> http://pastebin.com/0rmneEWx
 244 2011-10-08T22:54:14  <ThomasWaldmann> ok, fine :) commit :)
 245 2011-10-08T22:54:29  <vedranm> to my bitbucket fork?
 246 2011-10-08T22:57:19  <ThomasWaldmann> yes
 247 2011-10-08T22:57:36  <ThomasWaldmann> i'll pull and merge it then
 248 2011-10-08T22:57:38  <vedranm> ok
 249 2011-10-08T23:01:50  <vedranm> ok, done
 250 2011-10-08T23:01:52  <vedranm> great :)
 251 2011-10-08T23:02:06  <vedranm> let me try str.format stuff now
 252 2011-10-08T23:03:41  <CIA-65> Vedran Mileti? <rivanvx@gmail.com> default * 939:f3a0d1c65051 2.0/ (3 files in 3 dirs): Split mail_login into mail_username and mail_password, remove todo item from docs
 253 2011-10-08T23:03:43  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 940:d22dc7f0a19e 2.0/docs/ (4 files in 3 dirs): some doc updates
 254 2011-10-08T23:04:02  <vedranm> nice
 255 2011-10-08T23:04:19  <ThomasWaldmann> cia doesn't like non-ascii stuff
 256 2011-10-08T23:04:49  <vedranm> neither does hgweb
 257 2011-10-08T23:04:56  <vedranm> i believe it doesn't use utf-8 by default
 258 2011-10-08T23:05:09  <vedranm> but I hope it's not a problem with you
 259 2011-10-08T23:05:50  <ThomasWaldmann> no, as long as it doesn't crash :)
 260 2011-10-08T23:06:25  <ThomasWaldmann> ah, one thing maybe: most moin files are currently pure ascii
 261 2011-10-08T23:06:38  <ThomasWaldmann> except where required differently by the code
 262 2011-10-08T23:07:08  <vedranm> ok
 263 2011-10-08T23:07:12  <ThomasWaldmann> so, if you add yourself to the the (c) lines, could you maybe transcribe your name, so the code can stay ascii?
 264 2011-10-08T23:07:24  <vedranm> yes, it can be "VedranMiletic"
 265 2011-10-08T23:07:52  <vedranm> but let's see about that when I do something valuable
 266 2011-10-08T23:08:06  <ThomasWaldmann> if you want to follow the present style, you can use MoinMoin:VedranMiletic and create a page on mm wiki with that name
 267 2011-10-08T23:08:18  <ThomasWaldmann> kind of interwiki link :)
 268 2011-10-08T23:08:25  <vedranm> haha, nice :)
 269 2011-10-08T23:08:26  <vedranm> sure
 270 2011-10-08T23:08:50  <vedranm> did moin 1.9 use iso-8859-1?
 271 2011-10-08T23:09:06  <vedranm> so, this is now replaced by either ascii or utf-8?
 272 2011-10-08T23:09:23  <ThomasWaldmann> yes
 273 2011-10-08T23:09:31  <vedranm> ok, great
 274 2011-10-08T23:09:40  <ThomasWaldmann> but ascii is currently very much preferred
 275 2011-10-08T23:10:11  <ThomasWaldmann> iirc, some python version will default to utf-8 in the future, we'll switch then
 276 2011-10-08T23:10:53  <vedranm> iirc python 3.0 already does
 277 2011-10-08T23:11:48  <ThomasWaldmann> yeah, after we get bored with moin 2.x, well make moin 3.0 for py3 :)
 278 2011-10-08T23:15:55  <ThomasWaldmann> vedranm: btw, you know codereview.appspot.com?
 279 2011-10-08T23:16:50  <vedranm> Rietveld, yes
 280 2011-10-08T23:17:08  <ThomasWaldmann> we used it quite a lot last summer :)
 281 2011-10-08T23:17:32  <ThomasWaldmann> as easy, but more powerful than pastebin
 282 2011-10-08T23:18:01  <vedranm> nsnam.org people use it for serious code review
 283 2011-10-08T23:18:27  <vedranm> when code is almost ready to be included, but hasn't been seen by all devs
 284 2011-10-08T23:18:39  <vedranm> but I could post stuff there, no problem
 285 2011-10-08T23:23:39  * ThomasWaldmann goes trough tracker, checking whether stuff is still uptodate
 286 2011-10-08T23:30:11  <vedranm> ThomasWaldmann: find MoinMoin/ | xargs grep %s | grep -v "Binary file .* matches" | wc gives 370
 287 2011-10-08T23:30:54  <ThomasWaldmann> yeah, that's a simple, but big task
 288 2011-10-08T23:31:11  <ThomasWaldmann> and we also use %(foo)s, so it is even more than that
 289 2011-10-08T23:31:19  <vedranm> sure, no problem
 290 2011-10-08T23:31:27  <vedranm> I will avoid touching html stuff
 291 2011-10-08T23:31:29  <vedranm> only .py
 292 2011-10-08T23:31:36  <vedranm> there are 4 occurences in html
 293 2011-10-08T23:31:50  <ThomasWaldmann> btw, for translated stuff, the placeholder must make sense for translator
 294 2011-10-08T23:32:08  <vedranm> what do you mean?
 295 2011-10-08T23:32:32  <ThomasWaldmann> at quite some places this is currently %(foobar)s, but maybe not at all places, some places maybe still use just %s
 296 2011-10-08T23:32:58  <ThomasWaldmann> also, named placeholders are required because word sequence might be different in different languages
 297 2011-10-08T23:33:03  <vedranm> what does %(foobar) do?
 298 2011-10-08T23:33:39  <ThomasWaldmann> "%(foobar)s bla bla %(barbaz)s" % dict(foobar="a", barbaz="b")
 299 2011-10-08T23:33:56  <ThomasWaldmann> named placeholders
 300 2011-10-08T23:34:03  <vedranm> ok
 301 2011-10-08T23:37:14  <vedranm> I would convert that one like
 302 2011-10-08T23:37:16  <vedranm> "{foobar} bla bla {barbaz}".format(foobar="a", barbaz="b")
 303 2011-10-08T23:37:19  <vedranm> is that ok?
 304 2011-10-08T23:38:17  <ThomasWaldmann> if that works, yes
 305 2011-10-08T23:38:21  <vedranm> ok
 306 2011-10-08T23:38:48  <ThomasWaldmann> of course we use more meaningful placeholders :)
 307 2011-10-08T23:38:55  <vedranm> :D
 308 2011-10-08T23:38:57  <vedranm> of course
 309 2011-10-08T23:39:19  <vedranm> how many translation strings got changed from 1.9 to 2.0?
 310 2011-10-08T23:40:56  <ThomasWaldmann> no idea. 90%?
 311 2011-10-08T23:41:00  <vedranm> good
 312 2011-10-08T23:41:14  <ThomasWaldmann> we don't do translations now anyway
 313 2011-10-08T23:41:15  <vedranm> because croatian translation wasn't good and I told people not to update it :D
 314 2011-10-08T23:41:24  <vedranm> no?
 315 2011-10-08T23:41:30  <ThomasWaldmann> there is just one german translation, as a proof of concept
 316 2011-10-08T23:41:51  <ThomasWaldmann> but it would be rather annoying for translators if we change stuff all the time
 317 2011-10-08T23:42:55  <vedranm> yes, definitely
 318 2011-10-08T23:43:01  <vedranm> but 2.0 will have translations?
 319 2011-10-08T23:44:54  <ThomasWaldmann> yes, later
 320 2011-10-08T23:55:55  * ThomasWaldmann closed some outdated bugs
 321 2011-10-08T23:56:08  <vedranm> :)
 322 2011-10-08T23:56:13  <vedranm> %d is used for integers?
 323 2011-10-08T23:56:31  <ThomasWaldmann> yes
 324 2011-10-08T23:56:46  <ThomasWaldmann> looks like you never used the old method :)
 325 2011-10-08T23:58:24  <vedranm> nope
 326 2011-10-08T23:58:30  <vedranm> I only saw it in code
 327 2011-10-08T23:58:46  <vedranm> my method was mostly "blah" + var1 + "bleh"
 328 2011-10-08T23:58:55  <vedranm> coming from php
 329 2011-10-08T23:59:32  <ThomasWaldmann> it's getting better :)
 330 2011-10-08T23:59:47  <vedranm> my method or python or both? :D