1 2011-11-29T00:00:33 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5798:d0599106e17a 1.9/MoinMoin/config/multiconfig.py: remove curl UA from ua_spiders as python-openid uses libcurl (if installed)
2 2011-11-29T00:06:48 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5799:fe33650291f3 1.9/MoinMoin/web/static/htdocs/common/js/common.js: added workaround for IE8 script loop, thanks to Roger Haase
3 2011-11-29T00:15:11 <cdbs> ThomasWaldmann: Could you review the newest patch I uploaded to melange? It uses a template filter and the code is clean, and works
4 2011-11-29T00:17:08 <CIA-56> Paul Boddie <paul@boddie.org.uk> default * 5800:4ab3c578e44b 1.9/MoinMoin/action/serveopenid.py: (log message trimmed)
5 2011-11-29T00:17:08 <CIA-56> Introduced the invalidation of associations where the endpoint to be returned in
6 2011-11-29T00:17:08 <CIA-56> a response is different from the endpoint for the page being used to handle
7 2011-11-29T00:17:08 <CIA-56> OpenID requests. This changing endpoint behaviour occurs when an "identifier
8 2011-11-29T00:17:08 <CIA-56> select" request is handled by the front page of a Wiki, where an
9 2011-11-29T00:17:08 <CIA-56> identity-specific endpoint is then returned, confusing relying parties which
10 2011-11-29T00:17:09 <CIA-56> store their associations in endpoint-specific mappings (as is done by the
11 2011-11-29T00:27:48 <ThomasWaldmann> cdbs: if you give url, it'll be done faster :)
12 2011-11-29T00:28:05 <cdbs> ThomasWaldmann: http://www.google-melange.com/gci/work/download/google/gci2011/7123370?id=12001 :)
13 2011-11-29T00:32:09 <ThomasWaldmann> cdbs: almost :)
14 2011-11-29T00:32:22 <cdbs> almost means?
15 2011-11-29T00:32:45 <ThomasWaldmann> as i already mentioned, there are other IDs that look the same way. so it should be shorten_id, not shorten_revid
16 2011-11-29T00:33:04 <cdbs> ThomasWaldmann: So, that change, and what else?
17 2011-11-29T00:33:16 <cdbs> ThomasWaldmann: Length should always be 7, right?
18 2011-11-29T00:33:27 <cdbs> (in all cases I mean)
19 2011-11-29T00:33:27 <ThomasWaldmann> s/first 7 char/first <length> char/
20 2011-11-29T00:33:51 <cdbs> ThomasWaldmann: Is it even possible to specify length inside the template?
21 2011-11-29T00:34:03 <ThomasWaldmann> (and also change revid to id there, in the code)
22 2011-11-29T00:34:04 <cdbs> ThomasWaldmann: something like {{ revid | shorted_id(6) }}
23 2011-11-29T00:34:13 <ThomasWaldmann> using some sane default is nice, keep it that way
24 2011-11-29T00:34:21 <cdbs> okay
25 2011-11-29T00:34:37 <cdbs> ThomasWaldmann: Where should I change revid to id, other than in the filter names?
26 2011-11-29T00:35:27 <ThomasWaldmann> also, in history.html, add a blank left/right of |
27 2011-11-29T00:39:42 <ThomasWaldmann> well, "id" would be the right name, but well, that is a python builtin name
28 2011-11-29T00:40:07 <ThomasWaldmann> hex_id?
29 2011-11-29T00:40:15 <ThomasWaldmann> uuid
30 2011-11-29T00:41:09 * ThomasWaldmann watches Ion Tichy: Raumpilot on TV
31 2011-11-29T00:41:23 <ThomasWaldmann> TheSheep: ^^
32 2011-11-29T00:42:01 <ThomasWaldmann> Ijon even
33 2011-11-29T00:44:07 <ThomasWaldmann> cdbs: yes, use same term everywhere. the stuff you add is rather general use. for revids, itemids, whateverids.
34 2011-11-29T00:44:19 <cdbs> ThomasWaldmann: well, I've fixed everything you've mentioend
35 2011-11-29T00:44:23 <cdbs> *mentioned
36 2011-11-29T00:44:54 <cdbs> but yeah, hg export now creates a weird patch that includes the changes of the first commit with the ones in the second commit amended in the end
37 2011-11-29T00:44:58 <cdbs> *appended
38 2011-11-29T00:45:27 <ThomasWaldmann> yeah, that is expected
39 2011-11-29T00:45:37 <ThomasWaldmann> did you fork the repo on bitbucket?
40 2011-11-29T00:45:48 <cdbs> no, I forked the one on hg.moinmo.in
41 2011-11-29T00:46:51 <ThomasWaldmann> i was asking because if you had a public repo, i'ld just pull the changes from there
42 2011-11-29T00:46:59 <ThomasWaldmann> put exported changesets also work
43 2011-11-29T00:47:31 <cdbs> ThomasWaldmann: uploaded a new patch
44 2011-11-29T00:47:58 <cdbs> yeah, I know that it helps a lot, but I don't have a bitbucket account, I'm too addicted to github and launchpad
45 2011-11-29T00:48:16 <cdbs> ThomasWaldmann: URL of new patch http://www.google-melange.com/gci/work/download/google/gci2011/7123370?id=13001
46 2011-11-29T00:50:07 <CIA-56> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1110:5479a3b62b9f 2.0/MoinMoin/ (4 files in 2 dirs):
47 2011-11-29T00:50:07 <CIA-56> Change shorten_revid to shorten_id everywhere.
48 2011-11-29T00:50:07 <CIA-56> Also, fix the usage of length function arg in filter shorten_id
49 2011-11-29T00:50:08 <CIA-56> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1109:b703c5e590a3 2.0/MoinMoin/ (4 files in 2 dirs):
50 2011-11-29T00:50:08 <CIA-56> Create new template filter "shorten_revid" which shortens the specified text to 7 chars
51 2011-11-29T00:50:08 <CIA-56> Make use of templates in history, show and diff_text HTML templates.
52 2011-11-29T00:50:09 <CIA-56> Also, in history.html, render revids in monospace fonts.
53 2011-11-29T00:50:42 <cdbs> :) Thanks a lot ThomasWaldmann !
54 2011-11-29T00:51:31 <ThomasWaldmann> ok, looks better now :)
55 2011-11-29T00:52:06 <cdbs> ThomasWaldmann: You might want to close the GCI task: http://www.google-melange.com/gci/task/view/google/gci2011/7123370
56 2011-11-29T00:53:23 <ThomasWaldmann> did you do a review whether there are other places showing (rev)ids?
57 2011-11-29T00:53:38 <cdbs> I did a grep
58 2011-11-29T00:53:54 <cdbs> ThomasWaldmann: The only other place is meta.html
59 2011-11-29T00:54:12 <cdbs> ThomasWaldmann: but I think it would make sense to show the whole ID there
60 2011-11-29T00:54:16 <ThomasWaldmann> sure
61 2011-11-29T00:54:36 <ThomasWaldmann> can you close the bb issue?
62 2011-11-29T00:55:11 <ThomasWaldmann> just link to the changesets in the bb repo
63 2011-11-29T00:55:18 * cdbs will have to create a new account, but he'll do it
64 2011-11-29T00:56:58 <ThomasWaldmann> might be useful for future also
65 2011-11-29T00:58:15 <cdbs> yup, closed
66 2011-11-29T00:59:03 <ThomasWaldmann> thanks. closed the task also. :)
67 2011-11-29T01:00:04 <cdbs> thanks a lot
68 2011-11-29T01:01:15 <ThomasWaldmann> thanks for helping :)
69 2011-11-29T04:54:29 *** qxcv
70 2011-11-29T09:58:26 *** greg_f
71 2011-11-29T10:58:44 *** sungji
72 2011-11-29T11:02:31 *** sungji
73 2011-11-29T11:34:06 <sungji> "(for a sufferable machine translation visit MoinAPI/Examples)" hahaha
74 2011-11-29T11:34:59 <ThomasWaldmann> wut?
75 2011-11-29T11:35:50 <sungji> I had to laugh because of the wording ("sufferable machine translation" )
76 2011-11-29T11:35:52 <sungji> :)
77 2011-11-29T11:46:24 <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7116303 can someone please review?
78 2011-11-29T11:46:48 <ThomasWaldmann> (link to us icons)
79 2011-11-29T12:58:36 <Donald95> ThomasWaldmann: so what do you think about them? :)
80 2011-11-29T13:37:33 <sungji> does moinmo.in provide a sandbox site e.g. for demo reasons?
81 2011-11-29T13:43:16 <qxcv> sungji: test.moinmo.in (moin 2) and moinmo.in/WikiSandBox (moin 1.9)
82 2011-11-29T13:43:32 <sungji> qxcv: awesome, thanks!
83 2011-11-29T13:46:37 *** qxcv
84 2011-11-29T14:00:38 *** dave_largo
85 2011-11-29T14:01:04 <sungji> hm how does moin2 resolve "conflicts"? I created a document on test.moinmo.in and opened it in two new browser windows. Then I modified the text in both of the browser tabs with a different text. Then I saved the changes made in window 1 and then the changes made in window 2.
86 2011-11-29T14:02:28 <sungji> Apparently, moin2 makes it to look like as if the base revision for the second browser window was the modification made in window 1 instead of the original rev0 base. (i.e. it does some linearization apparently, but I don't know the specs behind it)
87 2011-11-29T14:08:31 <sungji> ah, looks like it treats the writes in window 1 as deletions in window 2 and thus it's possible to have a 'pseudo-linearity' (i.e. 'we started with the revision window 1 and then deleted every uncommon change in browser window 2')
88 2011-11-29T14:09:59 <sungji> why does it not merge the texts like in e.g. svn?
89 2011-11-29T14:18:28 *** pkumar
90 2011-11-29T14:24:46 *** NikitaUtiu
91 2011-11-29T14:24:54 <NikitaUtiu> moin, all ! :D
92 2011-11-29T14:25:36 <NikitaUtiu> i think i found a solution for invalidating all sessions
93 2011-11-29T14:26:32 <NikitaUtiu> i thought of adding another attribute, a session id, to the users, and if the session id in the server storage differs from the one stored locally, it will invalidate it
94 2011-11-29T14:27:19 <NikitaUtiu> this way not only does it invalidate it in case of password change but it can be invalidated by just incrementing the value
95 2011-11-29T14:30:12 *** raignarok
96 2011-11-29T14:50:13 <ThomasWaldmann> sungji: iirc, we do not have any conflict-handling or merging code in moin2 yet
97 2011-11-29T14:50:58 <ThomasWaldmann> but, on the backend, we have better foundations now to do that (revids are not simple numbers any more, we can store parentid)
98 2011-11-29T14:58:55 <sungji> ThomasWaldmann: oh ok
99 2011-11-29T15:00:01 <ThomasWaldmann> sungji: are you searching for gci tasks?
100 2011-11-29T15:00:50 <sungji> ThomasWaldmann: you mean google code-in?
101 2011-11-29T15:01:48 <ThomasWaldmann> yes
102 2011-11-29T15:02:12 <sungji> ThomasWaldmann: I think I'm above the age limit :/ (I'm a university student)
103 2011-11-29T15:02:27 <ThomasWaldmann> oh, ok :D
104 2011-11-29T15:03:33 <sungji> ThomasWaldmann: in Zurich mhm :)
105 2011-11-29T15:05:21 <dreimark> moin
106 2011-11-29T15:06:40 <sungji> dreimark: moinmoin :)
107 2011-11-29T15:10:00 <dreimark> ThomasWaldmann: i look later on 7116303, currently at work
108 2011-11-29T15:12:54 <Donald95> ThomasWaldmann: Hey did you liked the small sized ones here http://imageshack.us/f/440/googlecopyl.jpg/ ? Maybe start making all sizes based on their look ?
109 2011-11-29T15:30:32 *** NikitaUtiu
110 2011-11-29T15:36:11 <ThomasWaldmann> Donald95: they have the same issue as I already pointed out.
111 2011-11-29T15:36:41 <ThomasWaldmann> maybe you should start with a small icon and then do the bigger ones.
112 2011-11-29T15:37:50 *** Wim
113 2011-11-29T15:38:35 <ThomasWaldmann> maybe you also want to look at such images of other projects first, to get an impression
114 2011-11-29T15:39:36 <Wim> Hi, just to let you know that if you use the latest 'werkzeug' in moinmoin, ipv6 works for the standalone webserver
115 2011-11-29T15:44:06 <Donald95> ThomasWaldmann: http://www.dynamicdrive.com/link.htm Should I make the same sizes as here?
116 2011-11-29T15:44:54 <Donald95> ThomasWaldmann: like Micro buttons,Small buttons,Medium buttons,Large banners ?
117 2011-11-29T15:53:58 <ThomasWaldmann> Donald95: not as ugly and blinking, but sizes like micro/small/medium/large, yes
118 2011-11-29T15:55:26 <Donald95> ThomasWaldmann:ok got it :) Thanks
119 2011-11-29T15:57:40 <ThomasWaldmann> and also you are not required to exactly say "we use MoinMoin", it just needs to somehow tell that or look like telling that
120 2011-11-29T15:57:55 <ThomasWaldmann> Wim: ah, interesting
121 2011-11-29T15:58:39 <ThomasWaldmann> Wim: you tested with moin2 or 1.9.x?
122 2011-11-29T16:02:26 <ThomasWaldmann> Donald95: you could even look at what we have right now: http://test.moinmo.in/Home , see bottom right, left icon
123 2011-11-29T16:03:07 <ThomasWaldmann> e.g. the font could be improved there, maybe use same font as for the python powered one?
124 2011-11-29T16:03:34 <ThomasWaldmann> also same font colour
125 2011-11-29T16:08:38 <Donald95> so .. should I make the background transparent? Or light gray like that one
126 2011-11-29T16:08:59 <Donald95> and I don't know if I could find the exact same font :/
127 2011-11-29T16:12:09 <ThomasWaldmann> i can't help you much with design, I am bad at that. i can just tell if it looks good for me or not. ;)
128 2011-11-29T16:12:44 <ThomasWaldmann> transparent background might be an issue if the background is light or dark, right?
129 2011-11-29T16:12:55 <Donald95> yes
130 2011-11-29T16:13:12 <Donald95> big issue
131 2011-11-29T16:15:32 <Donald95> if you use the same icon in site with dark background I guess the text will be almost invisible cuz this icon is transparent bg
132 2011-11-29T16:18:56 <Wim> ThomasWaldmann: with 1.9.2
133 2011-11-29T16:19:00 <ThomasWaldmann> yes, so it sounds like transparent is out of question then
134 2011-11-29T16:19:37 <ThomasWaldmann> Wim: which werkzeug version did you use? did you copy it into moin or use some dist package on sys.path?
135 2011-11-29T16:20:12 <Wim> ThomasWaldmann: i renamed the one with moinmoin to old and just extracted the new one (tarball from github)
136 2011-11-29T16:20:14 * ThomasWaldmann was already thinking whether we should upgrade the builtin werkzeug
137 2011-11-29T16:21:13 <Wim> now I can use it on my ipv6 only server :)
138 2011-11-29T16:22:53 <Wim> so thanks for moinmoin, i'm off again :-)
139 2011-11-29T16:27:14 <ThomasWaldmann> Wim: thanks for testing
140 2011-11-29T16:30:54 *** Wim
141 2011-11-29T17:10:14 *** brunomartin
142 2011-11-29T17:29:00 *** raignarok
143 2011-11-29T17:40:02 <dreimark> ThomasWaldmann: commented on http://www.google-melange.com/gci/task/view/google/gci2011/7116303
144 2011-11-29T17:40:51 <dreimark> it is easily to miss it if it has not a different status
145 2011-11-29T17:52:31 <ThomasWaldmann> dreimark: maybe you should point out that we do not only want svg, but also some ready-to-use pngs
146 2011-11-29T18:17:20 *** dave_largo
147 2011-11-29T18:22:15 *** dave_largo
148 2011-11-29T18:41:37 *** greg_f
149 2011-11-29T19:38:25 *** raignarok
150 2011-11-29T20:01:16 *** brunomartin
151 2011-11-29T20:10:26 *** sungji
152 2011-11-29T20:10:48 *** jek
153 2011-11-29T20:11:35 *** sungji
154 2011-11-29T20:13:13 *** sungji
155 2011-11-29T20:16:27 *** sungji
156 2011-11-29T20:19:36 *** jek
157 2011-11-29T20:20:57 <sungji> what's the project status of moin2? alpha? beta?
158 2011-11-29T20:21:02 <sungji> pre-alpha?
159 2011-11-29T21:13:44 *** pkumar
160 2011-11-29T21:30:24 *** raignarok
161 2011-11-29T21:39:31 <ThomasWaldmann> sungji: alpha or so
162 2011-11-29T21:39:49 <ThomasWaldmann> nice to hack, but don't use it for production
163 2011-11-29T21:40:58 *** Donald95
164 2011-11-29T21:41:09 *** Donald95
165 2011-11-29T21:44:31 *** raignarok
166 2011-11-29T22:28:23 *** Donald95
167 2011-11-29T22:28:50 *** Donald95
168 2011-11-29T22:31:19 <Donald95> Here is my last update http://imageshack.us/f/6/google2copy.jpg/
169 2011-11-29T22:31:29 <Donald95> what should I fix more?
170 2011-11-29T22:33:20 *** dave_largo
171 2011-11-29T22:33:43 *** mpathy
172 2011-11-29T22:33:43 <ThomasWaldmann> hi Donald95
173 2011-11-29T22:36:43 <Donald95> Hey :)
174 2011-11-29T22:44:56 <ThomasWaldmann> mpathy: wanted to tell about your icons, but he is busy with other stuff right now
175 2011-11-29T22:45:50 <mpathy> the background is too distracting
176 2011-11-29T22:48:43 <Donald95> in all of the buttons?
177 2011-11-29T22:54:26 <mpathy> this background is in all of the buttons I have seen
178 2011-11-29T22:56:35 *** mpathy
179 2011-11-29T22:57:27 <sungji> ThomasWaldmann, oh I see... "nice to hack" hm
180 2011-11-29T23:09:57 <dreimark> gn
181 2011-11-29T23:24:52 <sungji> dreimark: good night!
