1 2011-12-03T00:02:35 *** jek
2 2011-12-03T00:08:14 *** jek
3 2011-12-03T00:20:57 *** brunomartin
4 2011-12-03T01:11:37 *** raignarok
5 2011-12-03T01:47:53 <ThomasWaldmann> - Removed support for Python 2.4 (from werkzeug 0.8). oops. now I have to think about using 0.8.x in moin 1.9.4.
6 2011-12-03T01:48:44 <ThomasWaldmann> so, do we better stay with werkzeug < 0.8 or do we raise python requirement to 2.5 for moin 1.9.4?
7 2011-12-03T02:06:43 *** sungji
8 2011-12-03T02:13:53 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5807:8b5c873582ff 1.9/docs/CHANGES: documented Python 2.5 requirement, depending on werkzeug version
9 2011-12-03T02:29:38 *** qxcv
10 2011-12-03T03:20:22 <ThomasWaldmann> http://moinmo.in/28c3 if we want a table in the hack center, there maybe should be more than 1 person on that list ;)
11 2011-12-03T03:53:57 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5808:6e0a686893c3 1.9/docs/REQUIREMENTS: raise werkzeug minimum requirement because of bugs in < 0.7
12 2011-12-03T04:28:05 <ThomasWaldmann> qxcv: review done
13 2011-12-03T04:35:10 <ThomasWaldmann> eSyr: http://www.google-melange.com/gci/task/view/google/gci2011/7125295 difficulty was "unknown" (invalid), i set it to medium now, please verify.
14 2011-12-03T04:48:24 <qxcv> ThomasWaldmann: do you want me to remove all of the "sorting by whether or not the items have children, then by name" and trailing slashes for items that *do* have children?
15 2011-12-03T04:55:24 <ThomasWaldmann> iirc i was rather asking for why it is there
16 2011-12-03T05:10:03 *** jek
17 2011-12-03T05:11:43 *** jek
18 2011-12-03T05:14:05 <qxcv> ah ok
19 2011-12-03T07:59:30 *** qxcv
20 2011-12-03T08:21:14 *** pkumar
21 2011-12-03T09:13:53 *** qxcv
22 2011-12-03T09:18:02 <dreimark> moin
23 2011-12-03T09:58:48 <eSyr> ThomasWaldmann: yes, looks fair.
24 2011-12-03T10:00:57 <dreimark> qxcv: please look if your sub item widget scales with 100 subitems
25 2011-12-03T10:01:04 <dreimark> bbl
26 2011-12-03T10:02:57 *** Gnarlodious
27 2011-12-03T10:12:30 *** Gnarlodious
28 2011-12-03T10:44:18 <qxcv> dreimark: https://imgur.com/66y01
29 2011-12-03T11:06:54 *** raignarok
30 2011-12-03T13:22:52 *** joancreus
31 2011-12-03T13:22:57 <joancreus> TheSheep are you here?
32 2011-12-03T13:59:26 *** Donald95
33 2011-12-03T14:00:06 *** Donald95
34 2011-12-03T14:19:22 *** qxcv
35 2011-12-03T14:38:34 *** Robin08
36 2011-12-03T14:40:21 *** Robin08
37 2011-12-03T14:44:24 *** RogerHaase
38 2011-12-03T14:58:34 <ThomasWaldmann> moin
39 2011-12-03T14:58:54 *** Robin08
40 2011-12-03T14:59:45 <ThomasWaldmann> joancreus: as the sheep seems to be unavailable currently, i suggest you think about some questions you just can ask anybody here.
41 2011-12-03T15:00:00 <joancreus> ok
42 2011-12-03T15:00:07 <joancreus> ThomasWaldmann: what i do not know is which task to claim
43 2011-12-03T15:00:11 <joancreus> usability ones are open
44 2011-12-03T15:00:15 <joancreus> and w/ different levels
45 2011-12-03T15:00:30 <joancreus> so i do not know whether to get a hard easy or medium one
46 2011-12-03T15:00:32 <joancreus> ThomasWaldmann:
47 2011-12-03T15:00:58 <ThomasWaldmann> you first have to decide about what you want to do, then someone can advise you about difficulty
48 2011-12-03T15:02:32 <ThomasWaldmann> (and if you don't know what to do and you can't find out, i suggest you take some more specific task)
49 2011-12-03T15:05:07 <Robin08> ThomasWaldmann: What do I need to know for the accessory task?
50 2011-12-03T15:06:06 <ThomasWaldmann> well, it helps if you know some company that does such stuff and how to deal with them. or at least if you are rather sure that you can find one.
51 2011-12-03T15:06:24 <ThomasWaldmann> there is a research component in that task :)
52 2011-12-03T15:06:51 <Robin08> but i guess the designing part has to be done by me..
53 2011-12-03T15:07:13 <ThomasWaldmann> well, using our logo and some common sense might do that
54 2011-12-03T15:08:25 <Robin08> so if i find a suitable service, what should I do next?
55 2011-12-03T15:08:47 <ThomasWaldmann> check if they meet the requirements
56 2011-12-03T15:09:11 <ThomasWaldmann> then see what they can do, choose some interesting things, discuss it here
57 2011-12-03T15:09:33 <ThomasWaldmann> see what input they need, work on that
58 2011-12-03T15:09:54 <ThomasWaldmann> something that is simple to handle would be great.
59 2011-12-03T15:10:24 <ThomasWaldmann> you have to consider that moin is a rather small bunch of people and there is no formal organisation or company.
60 2011-12-03T15:11:22 <ThomasWaldmann> so if somebody wants a moin t-shirt or something, it would be great if he could just order it somewhere and get it shipped to whereever he lives by the company that sells it.
61 2011-12-03T15:12:58 <Robin08> That would be great. So you mean that the design/accessory will be available somewhere online and fans will just have to place an order. Right?
62 2011-12-03T15:14:21 <ThomasWaldmann> yes. having a simple solution for some nice stuff would be great.
63 2011-12-03T15:15:04 <ThomasWaldmann> of course we know that there are companies printing your design on some tshirt and shipping it to germany.
64 2011-12-03T15:15:41 <ThomasWaldmann> but the point is that not everybody has to do that design and the shipping might also be required to brazil (for example).
65 2011-12-03T15:17:21 <Robin08> I know about some wesites that can internationally ship the accessory.
66 2011-12-03T15:17:28 <Robin08> like cafepress
67 2011-12-03T15:20:16 <ThomasWaldmann> sounds like a good start
68 2011-12-03T15:20:58 <Robin08> Okay. I should claim this task then. Please accept it.
69 2011-12-03T15:21:55 <Robin08> there are two tasks of the same topic
70 2011-12-03T15:22:11 <RogerHaase> Seems like international shipping costs could exceed the price of a t-shirt; is an alternative to design the accessory in a standard format (is there a standard format) and have the accessory made locally?
71 2011-12-03T15:23:15 <ThomasWaldmann> RogerHaase: we can have both maybe
72 2011-12-03T15:24:06 <ThomasWaldmann> for some people, running around (even when virtually done) and searching for some local supplier might be more "expensive" than the shipping
73 2011-12-03T15:26:28 <ThomasWaldmann> Robin08: you have it
74 2011-12-03T15:26:56 <Robin08> Thank you, ThomasWaldmann. :)
75 2011-12-03T15:29:11 <Robin08> If we go for local suppliers, then we will have to contact numerous such people.
76 2011-12-03T15:30:16 <ThomasWaldmann> Robin08: using some open format is required anyway, so the design should be usable at many suppliers
77 2011-12-03T15:30:35 <ThomasWaldmann> finding lots of local ones is not part of your task
78 2011-12-03T15:32:44 <Robin08> Then I will just have to make a design in an open format? How will I know which supplier accepts which format? Maybe svg will not be accepted by some particular suppliers.
79 2011-12-03T15:35:10 <RogerHaase> Robin08: you have to contact several suppliers for your accessory and determine which format they accept. Hopefully there will be a common format for your accessory.
80 2011-12-03T15:36:01 <RogerHaase> Like for printed books in small volume, almost any (US) printer will accept a pdf format.
81 2011-12-03T15:38:17 <Robin08> I found this website: http://www.printfection.com/
82 2011-12-03T15:46:40 <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7116303 can someone review this
83 2011-12-03T15:47:06 <ThomasWaldmann> i can't help, but i only find 1 half acceptable icon there
84 2011-12-03T15:47:45 <ThomasWaldmann> Robin08: also have a quick look at prices. looks like at printperfection a T costs 30usd + 10usd shipping.
85 2011-12-03T15:48:04 *** Robin08
86 2011-12-03T15:53:40 <ThomasWaldmann> RogerHaase: seen my query?
87 2011-12-03T15:58:02 <RogerHaase> ThomasWaldmann: not sure what you are asking: I am looking at Donald's ImageShack buttons
88 2011-12-03T16:00:55 <ThomasWaldmann> RogerHaase: i opened a private query to you
89 2011-12-03T16:34:22 *** joancreus
90 2011-12-03T16:48:03 <izibi> are there any other tables than the ones mentioned in https://bitbucket.org/thomaswaldmann/moin-2.0/issue/13/look-of-tables ?
91 2011-12-03T16:48:28 <izibi> in other words: can i break something else?
92 2011-12-03T16:52:23 <Donald95> Hey
93 2011-12-03T16:52:31 <ThomasWaldmann> grep for <table ?
94 2011-12-03T16:52:37 <Donald95> can someone tell me what's up with my task http://www.google-melange.com/gci/task/view/google/gci2011/7116303
95 2011-12-03T16:53:27 <Donald95> cuz my deadline has extended but I don't know what I'm supposed to redo
96 2011-12-03T16:53:41 <ThomasWaldmann> Donald95: i am not good at design, but i only find one of your images usable.
97 2011-12-03T16:54:04 <dreimark> moin
98 2011-12-03T16:54:32 <Donald95> ThomasWaldman:why are you telling me this now ......
99 2011-12-03T16:54:42 <izibi> oh and of course: what about tables in wiki pages?
100 2011-12-03T16:54:51 <dreimark> https://imgur.com/66y01 that is almost ugly as quicklinks in 1.9
101 2011-12-03T16:55:31 <ThomasWaldmann> Donald95: i try to leave the design feedback to people who are better with design than me, because they can tell you more specifically what to do
102 2011-12-03T16:56:24 <Donald95> ThomasWaldmann: well I talked with TheSheep and I remaked the buttons like 4-5 times with all the changes you and him suggested
103 2011-12-03T16:56:53 <ThomasWaldmann> but i can tell you what i found problematic still (similar stuff than already noted previously, though):
104 2011-12-03T16:56:59 <ThomasWaldmann> hard to read
105 2011-12-03T16:57:35 <Donald95> ThomasWaldmann: aah... ok
106 2011-12-03T16:57:45 <ThomasWaldmann> symetry issues (like one border looking less than another)
107 2011-12-03T16:58:40 <Donald95> ok ok ..
108 2011-12-03T16:58:43 <ThomasWaldmann> e.g. if you look at all.jpg
109 2011-12-03T16:59:32 <ThomasWaldmann> for many buttons, the lower border looks less than the upper
110 2011-12-03T17:00:43 <ThomasWaldmann> and all are somehow hard to read except the one in middle row. 3rd from left.
111 2011-12-03T17:01:38 <Donald95> just tell me if I need to unclaim
112 2011-12-03T17:01:47 <ThomasWaldmann> but even for that one, the individual chars, esp. left and right from the "i" almost merge
113 2011-12-03T17:02:20 <Donald95> anyway
114 2011-12-03T17:02:35 <Donald95> again .. you could of told me that before like 2-3 days
115 2011-12-03T17:02:46 <dreimark> ThomasWaldmann: see query
116 2011-12-03T17:03:15 <Donald95> thanks anyway for your time
117 2011-12-03T17:03:23 <ThomasWaldmann> i guess you got a lot of feedback from people who are much more professional with that than me. including the bad kerning hint.
118 2011-12-03T17:03:25 <Donald95> good luck with the next one :)
119 2011-12-03T17:03:32 <dreimark> he wait
120 2011-12-03T17:05:29 *** Donald95
121 2011-12-03T17:08:36 <izibi> asking again: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/13/look-of-tables does this also include tables in wiki pages? or should the be left relatively unstyled?
122 2011-12-03T17:10:30 <ThomasWaldmann> izibi: if they can be made pretty also i guess it would be nice to have
123 2011-12-03T17:11:19 <ThomasWaldmann> in the end, the main criteria is how it looks like and whether it is somehow consistent, pretty and usable
124 2011-12-03T17:11:50 <eSyr> "make install, not war"
125 2011-12-03T17:12:14 <ThomasWaldmann> so the question to ask is maybe "is there any reason why on-page tables should look different"
126 2011-12-03T17:14:12 <izibi> well i dont't know, maybe there are some users who expect a table to just be a plain table without any additional styling
127 2011-12-03T17:17:53 <izibi> who did the "make rev ids look nice" tasks? <tt> is obsolote
128 2011-12-03T17:25:01 <izibi> chrome, would you please not use every single byte of RAM?
129 2011-12-03T17:28:16 <ThomasWaldmann> izibi: ah, good hint
130 2011-12-03T17:33:16 <izibi> i think the best way would be first to clean up the html and properly use <thead> for example and then style the stuff inside this and only apply a minimum amount of styling to the rest of the table
131 2011-12-03T17:33:23 <ThomasWaldmann> izibi: see commit comment about "who did it"
132 2011-12-03T17:34:43 <ThomasWaldmann> izibi: i am not sure whether that is doable. the markup would have to support thead (tfoot?), the converter also
133 2011-12-03T17:35:59 <ThomasWaldmann> markup(s) even
134 2011-12-03T17:36:02 <dreimark> izibi: if you work on the table task, plase look also on jquery sorters
135 2011-12-03T17:36:21 <dreimark> or other jquery table scripts
136 2011-12-03T17:36:37 <ThomasWaldmann> how is that related to look of tables?
137 2011-12-03T17:36:49 <dreimark> it needs may be th
138 2011-12-03T17:36:57 <dreimark> and not only td
139 2011-12-03T17:37:07 <izibi> ThomasWaldmann: how is the support at the moment? is there at least a way to differentiate between <td> and <th>?
140 2011-12-03T17:37:48 <ThomasWaldmann> not sure, maybe not
141 2011-12-03T17:38:08 <izibi> dreimark: where would you want to use this for exmaple?
142 2011-12-03T17:38:23 <izibi> dreimark: anywhere in the tables generated by moin? or tables in the wiki content?
143 2011-12-03T17:39:14 <dreimark> if we again have an admin tools for listing users
144 2011-12-03T17:39:28 <dreimark> there for example you want to filter and to sort
145 2011-12-03T17:39:41 <dreimark> also on tables created by users
146 2011-12-03T17:39:50 <dreimark> in the past we did that by the data browser widget
147 2011-12-03T17:40:10 <ThomasWaldmann> dreimark: please read the task
148 2011-12-03T17:40:31 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/13/look-of-tables
149 2011-12-03T17:40:39 <izibi> i guess it might be a litte bit difficult to intergrate something in a place that does not yet exist :D
150 2011-12-03T17:41:09 <dreimark> ThomasWaldmann: ok, that is a different question
151 2011-12-03T17:41:12 <dreimark> izibi: ignore me
152 2011-12-03T17:42:39 <dreimark> http://test.moinmo.in/+admin/itemsize gives a 500er
153 2011-12-03T17:42:53 <ThomasWaldmann> it looks like rst_in and docbook has support for thead/tfoot
154 2011-12-03T17:42:54 <izibi> http://test.moinmo.in/moin this doesn't look like there's support for <th>
155 2011-12-03T17:43:51 <ThomasWaldmann> also, html_in/out has support for it
156 2011-12-03T17:44:04 <ThomasWaldmann> so maybe you just need to test with rst or docbook
157 2011-12-03T17:45:30 <izibi> i guess i'll first update the html to be semantically correct, then style it and then i'll see how to apply this to tables in the content
158 2011-12-03T17:48:59 <ThomasWaldmann> sounds like a plan :)
159 2011-12-03T18:05:55 <izibi> http://dl.dropbox.com/u/92247/2011-12-03-180157_370x53_scrot.png i guess this underline shouldn't be there
160 2011-12-03T18:06:41 <izibi> wasn't there a task on styling the headlines? ;)
161 2011-12-03T18:09:01 <izibi> btw <h2> is not allowed within <span> :P
162 2011-12-03T18:09:53 <ThomasWaldmann> izibi: yes, headline (ab)use needs more work
163 2011-12-03T18:11:27 <izibi> btw why isn't the global history just one big table?
164 2011-12-03T18:13:04 <izibi> there's nothing wrong with how it is at the moment, just asking ;)
165 2011-12-03T18:15:52 <izibi> where there changes to /+history recently?
166 2011-12-03T18:16:24 <ThomasWaldmann> well, maybe we want a box / some space around one day, that would be harder to achieve with one big table
167 2011-12-03T18:16:30 <izibi> the column with the [<number>] links is missing here, instead there's one in front that says "HIST"
168 2011-12-03T18:17:33 <ThomasWaldmann> some time ago, I simplified it a lot
169 2011-12-03T18:18:41 <izibi> i just was wondering why it looks different on test.moinmo.in
170 2011-12-03T18:19:23 <dreimark> beause older version
171 2011-12-03T18:19:34 <dreimark> may be we should show tip id on bottom
172 2011-12-03T18:19:52 <ThomasWaldmann> ehrm, that reminds me ... - i need to switch test wiki to more recent code :)
173 2011-12-03T18:22:06 <ThomasWaldmann> izibi: please use your local wiki to do tests
174 2011-12-03T18:26:36 *** greg_f
175 2011-12-03T18:27:04 <izibi> ThomasWaldmann: just wanted to see how the table looks with more data in it
176 2011-12-03T18:44:35 <ThomasWaldmann> http://test.moinmo.in/ now running current code
177 2011-12-03T18:45:52 *** RogerHaase
178 2011-12-03T18:48:06 *** RogerHaase
179 2011-12-03T18:53:24 <izibi> can someone tell me what i don't like there? http://dl.dropbox.com/u/92247/2011-12-03-184814_801x346_scrot.png
180 2011-12-03T18:58:34 <ThomasWaldmann> not me :)
181 2011-12-03T19:09:47 <dreimark> izibi: may be left one should be clickable. sometimes onewants to use it to navigate directly to a wiki in his farm
182 2011-12-03T19:10:04 <dreimark> http://moinmo.in/ParserMarket/interwiki?action=AttachFile&do=view&target=interwiki.py
183 2011-12-03T19:10:16 <dreimark> thats how I currently use it in 1.x
184 2011-12-03T19:13:46 <izibi> http://dl.dropbox.com/u/92247/2011-12-03-191007_804x315_scrot.png what about this?
185 2011-12-03T19:16:28 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1114:91f6360bba7a 2.0/MoinMoin/converter/archive_in.py: archive converter: we get a revision object, use rev.data for the file
186 2011-12-03T19:17:12 <ThomasWaldmann> ok, that fixed the zip and tar crash
187 2011-12-03T19:17:17 <izibi> wohoo! merging! :D
188 2011-12-03T19:19:54 <ThomasWaldmann> or rebase :)
189 2011-12-03T19:21:42 <ThomasWaldmann> RogerHaase: that loops forever issue with index-rebuild, is that with an empty wiki?
190 2011-12-03T19:22:39 <ThomasWaldmann> and what is the difference then to "(A fresh installation on Ubuntu was successful.)" - the other was non-fresh?
191 2011-12-03T19:25:01 <izibi> http://dl.dropbox.com/u/92247/2011-12-03-192111_1274x187_scrot.png that's how a table with thead and tfoot would look like
192 2011-12-03T19:28:17 <ThomasWaldmann> looks like an improvement
193 2011-12-03T19:28:24 <dreimark> the diff button, must that a button?
194 2011-12-03T19:28:36 <dreimark> looks nice
195 2011-12-03T19:29:03 <dreimark> htg bbl
196 2011-12-03T19:29:39 <izibi> dreimark: it's used to submit a form
197 2011-12-03T19:29:46 <izibi> but it could be replaced in javascript
198 2011-12-03T19:30:36 <izibi> but it still has to look different than the rest of the <th>s in order to make clear that it's clickable
199 2011-12-03T19:31:18 <izibi> let's add some css style to the button and see how it looks
200 2011-12-03T19:34:58 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1115:cb2c9d6c69c8 2.0/MoinMoin/items/_tests/test_Item.py: fix diffraw test
201 2011-12-03T19:35:55 <izibi> dreimark: http://dl.dropbox.com/u/92247/2011-12-03-193158_223x77_scrot.png is this better?
202 2011-12-03T19:36:50 <ThomasWaldmann> keep it as it was
203 2011-12-03T19:37:13 <ThomasWaldmann> it is ok if it stands out a bit, so users see that there is a button
204 2011-12-03T19:37:39 <ThomasWaldmann> if we want to change button style, that needs to be done globally and in a consistent way, not just there
205 2011-12-03T19:41:45 <izibi> so now what to do with the global history?
206 2011-12-03T19:42:34 <izibi> i'd just make it one big table argumenting that it's basically one timeline with date markers each day at midnight ;)
207 2011-12-03T19:43:46 <RogerHaase> ThomasWaldmann: regarding the index-build loop, both the windows and ubuntu were fresh clones. I tried ubuntu after failing several times on windows.
208 2011-12-03T19:44:34 <ThomasWaldmann> ok, so storage was empty and it didn't terminate. strange.
209 2011-12-03T19:45:03 <ThomasWaldmann> RogerHaase: can you tell the whoosh version?
210 2011-12-03T19:46:22 <RogerHaase> 2.3.1
211 2011-12-03T19:48:35 <ThomasWaldmann> those python processes you see being created, can you tell what they do exactly?
212 2011-12-03T19:49:54 <ThomasWaldmann> and can you also try index-create instead of index-build?
213 2011-12-03T19:50:36 <ThomasWaldmann> (that's bit redundant, because -i does that, but that way we can see if it only happens for build, which is not really needed for an empty storage)
214 2011-12-03T19:50:59 <RogerHaase> will do, give me a couple of minutes...
215 2011-12-03T19:51:10 <izibi> ThomasWaldmann: what's your opinion on a big table? try it or no? :P
216 2011-12-03T19:52:38 <ThomasWaldmann> izibi: for global history? no.
217 2011-12-03T19:53:00 <izibi> :( then i need another idea :D
218 2011-12-03T19:54:32 <ThomasWaldmann> how did you want to solve the days styling issue with just one table?
219 2011-12-03T19:55:29 <izibi> which days styling issue?
220 2011-12-03T19:56:00 <ThomasWaldmann> RogerHaase: also please try index-build -p1 whether it makes a difference to not giving -p (number of processes)
221 2011-12-03T19:56:23 <ThomasWaldmann> izibi: gh is broken into days
222 2011-12-03T19:56:40 <ThomasWaldmann> (unlike local history)
223 2011-12-03T19:57:30 <izibi> where's the problem? :P
224 2011-12-03T19:57:48 <izibi> i'd just add one row styled like a heading for every day
225 2011-12-03T19:58:12 <ThomasWaldmann> RogerHaase: and also with -p2 (just have seen that procs=1 seems to be default)
226 2011-12-03T19:59:25 <ThomasWaldmann> izibi: and how do you create separation between days, so not all looks like one big table?
227 2011-12-03T20:01:12 <izibi> i'd remove these as there are no fundamental differences between today and tomorrow ;)
228 2011-12-03T20:01:44 <izibi> why should changes made at 23:59 be separeted from those made a minute later?
229 2011-12-03T20:03:29 <izibi> somehow like in irssi. you get a small notice between the messages saying "Day changed to blah", but there is no extra spacing
230 2011-12-03T20:06:35 <RogerHaase> ThomasWaldmann: moin index-build -i and moin index-build -i -p2 act the same as moin index-build -s -i: steady increase in memory, lots of processes started. moin index-build -i -p1 runs and ends quickly as if it worked, but when I try starting the server and access a page I get 404 Not Found instead of the expected missing page, create...
231 2011-12-03T20:12:30 <ThomasWaldmann> RogerHaase: http://paste.ubuntu.com/758494/ can you try with that?
232 2011-12-03T20:15:24 <ThomasWaldmann> izibi: i agree with that, but normal people don't think like that :)
233 2011-12-03T20:18:46 <izibi> i guess they're not normal then :D
234 2011-12-03T20:19:42 <izibi> nothing changes if you remove the <span> (in which a <h2> is placed). why is there at all? :D
235 2011-12-03T20:22:43 <ThomasWaldmann> maybe the h2 shouldn't be there
236 2011-12-03T20:26:05 <izibi> http://dl.dropbox.com/u/92247/2011-12-03-202216_977x241_scrot.png
237 2011-12-03T20:26:12 <RogerHaase> ThomasWaldmann: I tried; the messages comming out on the command prompt window are the same as those in the file attached to the bug report. Is there another place to look?
238 2011-12-03T20:26:29 <izibi> is this ok?
239 2011-12-03T20:30:07 <RogerHaase> ThomasWaldmann: except, the traceback shows line 435 instead of line 432 within indexing.py.
240 2011-12-03T20:30:14 <ThomasWaldmann> RogerHaase: i suspected warnings coming out. can you change to error?
241 2011-12-03T20:31:21 <ThomasWaldmann> izibi: looks good. except the american date/time style :)
242 2011-12-03T20:34:22 <izibi> would this style be appropriate for tables within wiki pages?
243 2011-12-03T20:38:29 <izibi> btw what about browser compatibility? i'm using :nth-child
244 2011-12-03T20:38:46 <RogerHaase> ThomasWaldmann: changed to error, but no additional messages
245 2011-12-03T20:42:17 <RogerHaase> ThomasWaldmann: I put an "assert 1==0" at line 421, same result. So the traceback means..?
246 2011-12-03T20:53:25 <ThomasWaldmann> hm, looks like we have a logging problem. use print?
247 2011-12-03T20:53:39 <RogerHaase> ThomasWaldmann: the failing line seems to be in the rebuild procedure ~line 467: self._modify_index(index, self.schemas[ALL_REVS], self.wikiname, all_revids, 'add', procs, limitmb)
248 2011-12-03T20:54:12 <RogerHaase> Logging is OK, I am getting logging messages out of rebuild procedure
249 2011-12-03T20:59:02 <ThomasWaldmann> didn't you tell you see nothing new?
250 2011-12-03T20:59:18 <ThomasWaldmann> it should tell add/update/delete revid itemname
251 2011-12-03T21:02:08 <RogerHaase> ThomasWaldmann: in file attached to bug report there is a line "File "c:\bitbucket\moin-2.0\MoinMoin\storage\middleware\indexing.py", line 467" ...
252 2011-12-03T21:02:38 <RogerHaase> So I put in logging statements before every line in the try clause there.
253 2011-12-03T21:03:13 <RogerHaase> there being the rebuild procedure
254 2011-12-03T21:05:33 <RogerHaase> the logging message after the self._modify_index... line does not appear
255 2011-12-03T21:09:12 * ThomasWaldmann looks
256 2011-12-03T21:10:48 <ThomasWaldmann> RogerHaase: yes, that is why i put the logging into _modify_index
257 2011-12-03T21:12:30 *** NikitaUtiu
258 2011-12-03T21:12:49 <RogerHaase> ahh, I am catcing up and putting in more logging statements...
259 2011-12-03T21:14:11 <ThomasWaldmann> for mountpoint, revid in revids:
260 2011-12-03T21:14:29 <ThomasWaldmann> can you output mountpoint and revid below that line?
261 2011-12-03T21:18:12 <NikitaUtiu> moin, ThomasWaldmann, I know I didn't finish the task successfully, I've been very busy with school, but I pushed the commit nonetheless to my repo at https://bitbucket.org/NikitaUtiu/moin-2.0
262 2011-12-03T21:27:47 <RogerHaase> ThomasWaldmann: revids must be empty as the lines after "for mountpoint, revid..." do not get executed
263 2011-12-03T21:28:19 <RogerHaase> you probably already know: revids=<MoinMoin.storage.middleware.routing.Backend object at 0x037F3090>
264 2011-12-03T21:28:47 <RogerHaase> ...and that does not have a length.
265 2011-12-03T21:34:03 <ThomasWaldmann> NikitaUtiu: if noone else has taken it, claim it
266 2011-12-03T21:34:13 <NikitaUtiu> ok
267 2011-12-03T21:35:00 <NikitaUtiu> well i claimed it
268 2011-12-03T21:38:04 <izibi> NikitaUtiu: what's wrong with "session_id"? i think that's a common name and changing this might just confuse people
269 2011-12-03T21:38:41 <ThomasWaldmann> izibi: it is wrong if it is not a session id :)
270 2011-12-03T21:38:55 <NikitaUtiu> I'm guessing "secret" is more appropriate for it's role
271 2011-12-03T21:40:25 <ThomasWaldmann> NikitaUtiu: ok, i think we stopped at s/user_secret/user.secret/
272 2011-12-03T21:40:42 <NikitaUtiu> yes
273 2011-12-03T21:41:13 <ThomasWaldmann> RogerHaase: a backend is a iterator
274 2011-12-03T21:41:45 <ThomasWaldmann> and if it is empty, it shouldn't take time
275 2011-12-03T21:50:04 <RogerHaase> ThomasWaldmann: So the first try in "rebuild" fails as expected (because there is nothing to index), the finally clause is executed, and the second try also fails. The problem is somewhere else?
276 2011-12-03T21:50:15 <izibi> ThomasWaldmann: what do you think about alternating background colors in tables in wiki pages? would that be ok or would it be better to just have a simple table with borders there?
277 2011-12-03T21:51:59 <RogerHaase> ThomasWaldmann: is this a clue: ImportError: No module named multiprocessing.forking
278 2011-12-03T21:56:04 <ThomasWaldmann> izibi: i guess if it is not too intense, it might be welcome in general
279 2011-12-03T21:57:01 <ThomasWaldmann> RogerHaase: why does it "fail"?
280 2011-12-03T21:57:33 <ThomasWaldmann> doing nothing (because there isn't anything to do) and failure is something different
281 2011-12-03T21:58:18 <ThomasWaldmann> ah, no forking. full traceback -> issue tracker
282 2011-12-03T22:00:00 <NikitaUtiu> ThomasWaldmann, I submitted a new url for the task
283 2011-12-03T22:00:50 <ThomasWaldmann> RogerHaase: "forking" can't be found. not in moin2, not in whoosh.
284 2011-12-03T22:03:50 *** NikitaUtiu
285 2011-12-03T22:04:42 <ThomasWaldmann> hmm, away he was
286 2011-12-03T22:05:38 <ThomasWaldmann> and no work submitted
287 2011-12-03T22:05:55 <izibi> ThomasWaldmann: http://dl.dropbox.com/u/92247/2011-12-03-220152_245x91_scrot.png
288 2011-12-03T22:06:02 <izibi> just the same colors as in the other tables
289 2011-12-03T22:09:37 <ThomasWaldmann> hmm, great for data tables. but if someone abuses them for layout, he'll be unhappy.
290 2011-12-03T22:09:49 <ThomasWaldmann> can we easily switch it on/off somehow?
291 2011-12-03T22:10:49 <izibi> ThomasWaldmann: is there a way to add a class to the table from the wiki markup?
292 2011-12-03T22:12:39 <ThomasWaldmann> <tableclass="..."> will put that class into table (table) html
293 2011-12-03T22:12:46 <ThomasWaldmann> for 1.9 that worked
294 2011-12-03T22:13:09 <ThomasWaldmann> http://moinmo.in/HelpOnTables
295 2011-12-03T22:13:40 <izibi> yes, that works
296 2011-12-03T22:13:52 <izibi> what should be the default? alternating colors or border?
297 2011-12-03T22:13:58 <RogerHaase> ThomasWaldmann: I am still working on "failing". The line after 467 "self._modify_index(index,..." in rebuild does not get executed per my logging statements. So line 420 "for mountpoint, revid in revids:" must be throwing an exception.
298 2011-12-03T22:14:44 <izibi> but that would be a theme-specific class. is this what you want? :-\
299 2011-12-03T22:14:47 <ThomasWaldmann> izibi: maybe keep default as is, for compat.
300 2011-12-03T22:15:07 <ThomasWaldmann> alternating as option
301 2011-12-03T22:16:18 <izibi> name for the class? "alternating"?
302 2011-12-03T22:17:05 <ThomasWaldmann> RogerHaase: how is that striped lineprinter paper called?
303 2011-12-03T22:21:31 <RogerHaase> greenbar?
304 2011-12-03T22:23:04 <izibi> css definitely misses the ability to nest elements...
305 2011-12-03T22:23:56 <RogerHaase> http://en.wikipedia.org/wiki/Continuous_stationery says green bar or music paper. I never heard the term music paper before.
306 2011-12-03T22:24:44 <ThomasWaldmann> izibi: use "greenbar"?
307 2011-12-03T22:25:02 <ThomasWaldmann> "striped" might be an option also
308 2011-12-03T22:25:20 <ThomasWaldmann> greenbar maybe limits to green bars :)
309 2011-12-03T22:25:44 * izibi throws in another suggestion: zebra
310 2011-12-03T22:25:46 <izibi> http://en.wikipedia.org/wiki/Zebra_striping
311 2011-12-03T22:27:36 <ThomasWaldmann> yeah, why not :)
312 2011-12-03T22:28:19 <izibi> then what about the rest of the tables? just add this class to them or add every single one of them to the css?
313 2011-12-03T22:30:35 <ThomasWaldmann> is this zebra a css feature or does one have to apply a different class for every 2nd row?
314 2011-12-03T22:31:33 <izibi> ThomasWaldmann: i use :nth-child for the striping
315 2011-12-03T22:31:51 <ThomasWaldmann> ah
316 2011-12-03T22:33:07 <izibi> the question is if it's better to do <table id="other-table" class="zebra"> in the html or table.zebra, #other-table in the css
317 2011-12-03T22:33:51 <ThomasWaldmann> maybe the css is easier to modify
318 2011-12-03T22:34:14 <ThomasWaldmann> so maybe a separate zebra class, to mix in?
319 2011-12-03T22:34:16 <izibi> but this has to be done for every other table and in multiple rules
320 2011-12-03T22:35:21 <izibi> ThomasWaldmann: what do you mean by "mix in"?
321 2011-12-03T22:35:31 <ThomasWaldmann> class="foo zebra"
322 2011-12-03T22:40:51 <izibi> is there any secific order of the attributes in the css?
323 2011-12-03T22:41:37 <izibi> td p { margin: 0; padding: 0; } btw what's this rule for?
324 2011-12-03T22:42:12 <ThomasWaldmann> no idea
325 2011-12-03T22:42:28 <ThomasWaldmann> looks like avoiding margings and padding :)
326 2011-12-03T22:43:44 <izibi> o rly? :D
327 2011-12-03T22:45:10 <ThomasWaldmann> you asked :)
328 2011-12-03T22:48:04 <ThomasWaldmann> RogerHaase: maybe primarily try with -p1 (or default, not > 1)
329 2011-12-03T22:48:21 <ThomasWaldmann> that multiwriter stuff had issues in the past and maybe still has
330 2011-12-03T22:51:47 <ThomasWaldmann> RogerHaase: btw, if there really was an exception, we should see it
331 2011-12-03T22:52:19 <ThomasWaldmann> try/finally only makes sure that close() gets executed, it does not catch/suppress exceptions
332 2011-12-03T22:52:58 <ThomasWaldmann> and if you saw that forking importerror after hitting ctrl-c, it maybe is not reliable
333 2011-12-03T22:53:35 <izibi> https://bitbucket.org/thomaswaldmann/moin-2.0/src/cb2c9d6c69c8/MoinMoin/themes/modernized/static/css/common.css#cl-195
334 2011-12-03T22:53:49 <izibi> is it intended that the comment is not ended in this line?
335 2011-12-03T22:55:47 <ThomasWaldmann> not sure what "placeholder" shall tell us
336 2011-12-03T22:56:02 <ThomasWaldmann> it looks like commented out. maybe because it is not used currently?
337 2011-12-03T22:56:44 <izibi> i don't know. that's why i'm asking ;)
338 2011-12-03T22:58:48 <izibi> ThomasWaldmann: http://codereview.appspot.com/5437127
339 2011-12-03T23:07:13 * ThomasWaldmann looks
340 2011-12-03T23:12:28 <izibi> http://dl.dropbox.com/u/92247/2011-12-03-230816_284x203_scrot.png so this are the two possible styles (and zebra with head/footer and normal table with <th>)
341 2011-12-03T23:12:55 <ThomasWaldmann> review done
342 2011-12-03T23:13:27 <ThomasWaldmann> (the css changes should be reviewed by someone else, though). TheSheep, can you help? ^^
343 2011-12-03T23:18:31 <izibi> ThomasWaldmann: replied to the comments
344 2011-12-03T23:20:48 <ThomasWaldmann> right, side-by-side is rather intelligent diff
345 2011-12-03T23:21:34 <ThomasWaldmann> so you have everything mentioned in the task? grepped for <table?
346 2011-12-03T23:24:57 <izibi> ThomasWaldmann: there are many matches in _tests directories. but they seem to only test the output of the converters
347 2011-12-03T23:25:29 <izibi> there are some more tables i could add the zebra look (wikiconfig[help] for example)
348 2011-12-03T23:25:53 <izibi> userbrowser throws an exception so i can't test this
349 2011-12-03T23:26:07 <ThomasWaldmann> btw, at the end, please run all tests
350 2011-12-03T23:27:21 <izibi> and then there's the search result page
351 2011-12-03T23:27:38 <izibi> at the moment it adds an border there
352 2011-12-03T23:28:20 <izibi> i think it would be better to remove the table there at all
353 2011-12-03T23:29:51 <izibi> but fixed that for now
354 2011-12-03T23:30:45 <ThomasWaldmann> what would you suggest for there?
355 2011-12-03T23:31:39 <izibi> i'd just use an ordered list
356 2011-12-03T23:32:39 <ThomasWaldmann> ok
357 2011-12-03T23:32:44 <izibi> RogerHaase: would you also change table.zebra to just .zebra?
358 2011-12-03T23:33:06 <izibi> it's not quite the same but wouldn't really make a difference
359 2011-12-03T23:33:07 <RogerHaase> izibi: yes
360 2011-12-03T23:34:45 <RogerHaase> the way I understand http://code.google.com/speed/page-speed/docs/rendering.html, the fewer selectors the better. Plus it makes simple rules.
361 2011-12-03T23:36:42 <RogerHaase> gtg
362 2011-12-03T23:36:48 *** RogerHaase
363 2011-12-03T23:39:38 *** pkumar
364 2011-12-03T23:40:26 <izibi> ThomasWaldmann: updated the issue, simplified css and added zebra class to wikiconfig[help] tables
365 2011-12-03T23:40:42 <izibi> only table left is userbrowser, but i can't test that one
366 2011-12-03T23:40:48 <izibi> let's run the tests
367 2011-12-03T23:42:43 <izibi> http://paste.pocoo.org/show/516343/
368 2011-12-03T23:43:11 <izibi> some are failing but i guess they are the same that already failed earlier and are not related to my changes
369 2011-12-03T23:44:00 <ThomasWaldmann> yup
370 2011-12-03T23:46:06 <izibi> so what about the userbrowser?
371 2011-12-03T23:54:19 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1116:d56ce46d3e16 2.0/MoinMoin/apps/admin/views.py: fix userbrowser
372 2011-12-03T23:54:21 <ThomasWaldmann> izibi: ^^
373 2011-12-03T23:55:34 <izibi> congratulations, you successfully forced me to rebase
374 2011-12-03T23:56:04 <ThomasWaldmann> ;) don't do that after pushing btw.
375 2011-12-03T23:56:57 <izibi> i haven't commited anything yet
376 2011-12-03T23:58:09 <izibi> is there an easy way to rebase the working directory?
377 2011-12-03T23:59:51 <izibi> hg update :D
