1 2012-05-20T00:35:15 *** jaiditya
2 2012-05-20T00:38:34 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 82:2dc110ff7b19 EmeraldTree/emeraldtree/tree.py:
3 2012-05-20T00:38:34 <CIA-146> HTML/XMLWriter: reduce code duplication, refactor code, bugfix
4 2012-05-20T00:38:34 <CIA-146> move common code to new base class
5 2012-05-20T00:38:34 <CIA-146> call write() less often
6 2012-05-20T00:38:34 <CIA-146> use string formatting rather than +
7 2012-05-20T00:38:34 <CIA-146> bugfix for self.serialize(write, e, qnames) call (removed wrong "encoding" arg)
8 2012-05-20T01:01:39 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 83:a70598fc5ca6 EmeraldTree/emeraldtree/tree.py: XML/HTMLWriter: more deduplication, code moved to base class
9 2012-05-20T01:18:00 *** MattMaker
10 2012-05-20T01:42:57 * ThomasWaldmann tries polyglot writer...
11 2012-05-20T01:56:11 *** MattMaker
12 2012-05-20T02:17:06 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 84:223789ea05b2 EmeraldTree/emeraldtree/ (tests/test_html.py tree.py):
13 2012-05-20T02:17:06 <CIA-146> add polyglot writer (for xmlish html5), add/fix tests
14 2012-05-20T02:17:06 <CIA-146> tests:
15 2012-05-20T02:17:06 <CIA-146> add some toplevel element that is not tested (avoids namespace issues that shall
16 2012-05-20T02:17:06 <CIA-146> not get tested there)
17 2012-05-20T02:17:06 <CIA-146> add tests for xml and polyglot writing, checking whether void and empty elements
18 2012-05-20T02:17:07 <CIA-146> get written correctly
19 2012-05-20T02:17:10 <ThomasWaldmann> waldi: please review ^^
20 2012-05-20T02:34:46 <eSyr-ng> ThomasWaldmann: what do you think about pushing http://moinmo.in/FeatureRequests/FullSearchResultsWithoutHighlight into upstream?
21 2012-05-20T02:35:21 <eSyr-ng> (friend of mine poked me that it still not in moin)
22 2012-05-20T02:40:52 <eSyr-ng> *it is
23 2012-05-20T02:41:21 <ThomasWaldmann> eSyr-ng: you mean that patch shown on that page?
24 2012-05-20T02:45:17 <eSyr-ng> ThomasWaldmann: not exactly, the listed diff looks like workaround for category search, not for the original problem.
25 2012-05-20T02:45:34 <eSyr-ng> i've written small patch for the original FR, currently playing with it.
26 2012-05-20T02:48:56 <ThomasWaldmann> yeah, that's likely better, the patch there doesn't look acceptable
27 2012-05-20T03:04:53 *** Trip_
28 2012-05-20T03:08:33 *** MattMaker
29 2012-05-20T03:43:55 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 85:ef22f92aa803 EmeraldTree/setup.py: bump version number to 0.9.1
30 2012-05-20T03:58:29 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1356:25a7e9e2b9b7 2.0/ (MoinMoin/items/__init__.py setup.py):
31 2012-05-20T03:58:29 <CIA-146> use polyglot writer, require emeraldtree >= 0.9.1
32 2012-05-20T03:58:29 <CIA-146> removed workaround made for the xmlwriter we used previously,
33 2012-05-20T03:59:08 <ThomasWaldmann> ^^ requires upgrade to emeraldtree >= 0.9.1. pip uninstall emeraldtree ; pip install -e .
34 2012-05-20T04:17:16 <xiaq> ThomasWaldmann: moin
35 2012-05-20T04:25:32 <xiaq> ThomasWaldmann: plz see EP comments http://etherpad.osuosl.org/moin-render-method
36 2012-05-20T04:26:30 * xiaq thinks we'd better reach a resolution on render_method stuff since the coding phase is very near
37 2012-05-20T04:58:12 * xiaq is stuck with Hg...
38 2012-05-20T05:01:50 * xiaq thinks we'd better use shiftwidth=2 in jinja templates...
39 2012-05-20T05:04:38 <xiaq> ThomasWaldmann: worked out hg stuff, pull request sent
40 2012-05-20T06:23:18 *** dwcramer
41 2012-05-20T06:53:53 *** xiaq
42 2012-05-20T06:56:09 *** xiaq
43 2012-05-20T06:56:50 *** xiaq
44 2012-05-20T12:13:32 *** jaiditya
45 2012-05-20T13:16:21 <ThomasWaldmann> xiaq: not much news there, but I made an obvious comment on 90
46 2012-05-20T13:47:41 <xiaq> ThomasWaldmann: saw it
47 2012-05-20T13:47:59 <xiaq> ThomasWaldmann: again... do we kill meta_render_method, and perhaps meta_schema?
48 2012-05-20T13:48:31 <xiaq> render_method (control overall rendering) and content_render_method together looks pretty sufficient to me
49 2012-05-20T13:48:36 * xiaq gtg, bbl
50 2012-05-20T14:08:35 *** Trip_
51 2012-05-20T14:13:37 *** MattMaker
52 2012-05-20T14:21:56 <dreimark> xiaq: please give again the url
53 2012-05-20T14:26:23 <dreimark> readed backlog, thomas has looked at it
54 2012-05-20T14:45:25 <CIA-146> Cheer Xiao <xiaqqaix@gmail.com> default * 1357:5b88a6ae67a5 2.0/MoinMoin/ (5 files in 4 dirs):
55 2012-05-20T14:45:25 <CIA-146> Add summary meta key to items. Summary is shown on +show and +search, but not
56 2012-05-20T14:45:25 <CIA-146> +index yet.
57 2012-05-20T14:45:26 <CIA-146> Cheer Xiao <xiaqqaix@gmail.com> default * 1358:895bc6e84918 2.0/ (12 files in 7 dirs): merge
58 2012-05-20T14:45:26 <CIA-146> Cheer Xiao <xiaqqaix@gmail.com> default * 1359:f01c5c8d7464 2.0/MoinMoin/templates/search.html: on +search, only show summary if existing
59 2012-05-20T14:45:27 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1360:a954861f4d2b 2.0/MoinMoin/apps/frontend/views.py: add SUMMARY to the fields that are searched by default when the field is not specified
60 2012-05-20T15:13:44 <xiaq> dreimark: uh, http://etherpad.osuosl.org/moin-render-method
61 2012-05-20T15:15:06 <xiaq> ThomasWaldmann: ping
62 2012-05-20T15:21:38 *** kanha_
63 2012-05-20T15:22:18 *** kanha
64 2012-05-20T15:37:44 *** dwcramer
65 2012-05-20T16:45:45 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1361:359d51f0fa90 2.0/MoinMoin/items/__init__.py: items: remove some unneeded code
66 2012-05-20T16:47:38 <ThomasWaldmann> waldi: http://etherpad.osuosl.org/moin-render-method 46+
67 2012-05-20T16:48:55 * eSyr-ng added fourth extension-related line to .hgrc
68 2012-05-20T16:56:06 <ronny> sup
69 2012-05-20T16:56:26 <ronny> do we have a new paper on plugins by chance?
70 2012-05-20T16:57:52 <ThomasWaldmann> well, see the EP for current state
71 2012-05-20T16:59:05 <ronny> which one again?
72 2012-05-20T17:02:57 <ThomasWaldmann> http://moinmo.in/GoogleSoc2012 see the linked wiki pages there
73 2012-05-20T17:41:31 *** DasIch_
74 2012-05-20T17:43:47 *** DasIch
75 2012-05-20T17:43:47 *** DasIch_
76 2012-05-20T17:55:46 <eSyr-ng> ThomasWaldmann: dreimark: http://codereview.appspot.com/6209085/ http://codereview.appspot.com/6219052/ http://codereview.appspot.com/6218057/ http://codereview.appspot.com/6206092/
77 2012-05-20T17:56:03 <eSyr-ng> ThomasWaldmann: well, issue is revealed to be not so trivial :|
78 2012-05-20T17:57:00 <eSyr-ng> ThomasWaldmann: looks like first diff most related, but others are also related to features mentioned in FR.
79 2012-05-20T17:57:25 <eSyr-ng> (on the other hand, parts of solution are quite independed)
80 2012-05-20T18:05:19 <MaikuMori> moin
81 2012-05-20T18:22:22 *** sudo_dirk
82 2012-05-20T18:51:04 <xiaq> moin
83 2012-05-20T18:51:44 * xiaq reading contenttype_output proposed by ThomasWaldmann
84 2012-05-20T19:11:13 <dreimark> ep is unstable for me
85 2012-05-20T19:21:56 <ThomasWaldmann> eSyr-ng: review done
86 2012-05-20T19:22:01 <ThomasWaldmann> dreimark: works for me
87 2012-05-20T19:29:26 <xiaq> coding phase is coming...
88 2012-05-20T19:30:21 <eSyr-ng> "winter is coming"
89 2012-05-20T19:30:47 <xiaq> but neither http://etherpad.osuosl.org/moin-render-method nor http://etherpad.osuosl.org/moin-flatland-metadata-editor has come to a resolution :(
90 2012-05-20T19:31:05 <xiaq> the ticket system, pastebin and blog projects all depend on that
91 2012-05-20T19:31:51 <xiaq> i suppose we should reach at least some partial resolution...
92 2012-05-20T19:32:09 <ThomasWaldmann> well, there could be a bit more activity, people-wise...
93 2012-05-20T19:34:22 <xiaq> ThomasWaldmann: yeah
94 2012-05-20T19:36:05 <xiaq> i suggest we (people related to the two aforementioned sub-projects) agree on _several_ time points to discuss together - not as compulsive as the weekly meeting, and there should be several of them
95 2012-05-20T19:36:51 <xiaq> if we cannot resolve the two sub-projects first in a clean manner
96 2012-05-20T19:37:14 <xiaq> it will be difficult to merge the 3 related projects' code into a single codebase...
97 2012-05-20T19:40:12 * xiaq calls for more frequent and efficient collaboration
98 2012-05-20T19:41:50 <ThomasWaldmann> xiaq: good idea. make a doodle and TELL people the chosen date when the date choice is done. (that didn't quite work for the last doodle)
99 2012-05-20T19:46:13 <xiaq> ThomasWaldmann: perhaps we can just reuse the existing doodle and pick several time points (we can somehow cover everyone's "yes" instead of "(yes)" points when we have several points to choose)
100 2012-05-20T19:47:23 <xiaq> with one compulsive time point, we often end up with "YyyyYy" ("y" for "(yes)")
101 2012-05-20T19:47:55 <xiaq> but with _several_ non-compulsive time points, we can mange one "YYNYYN", and one "NYYNNY"
102 2012-05-20T19:48:15 <xiaq> and thus everyone has at least one "Y" time covered
103 2012-05-20T19:49:31 * xiaq battery running dry. needs to Zzz too. hope i explained my idea clearly (:
104 2012-05-20T19:49:47 <xiaq> good night and gute nacht everyone :)
105 2012-05-20T19:50:28 <ThomasWaldmann> gn xiaq
106 2012-05-20T20:14:30 <ronny> ThomasWaldmann: where is that polygot patch?
107 2012-05-20T20:15:05 <ThomasWaldmann> http://hg.moinmo.in/EmeraldTree/rev/223789ea05b2
108 2012-05-20T20:16:40 <ronny> ThomasWaldmann: looks good at first glance
109 2012-05-20T20:19:38 <ThomasWaldmann> was just wondering whether that's all
110 2012-05-20T20:28:52 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 86:a3095fd90fa5 EmeraldTree/ (README setup.py): updated README / setup.py
111 2012-05-20T20:30:11 <ronny> ThomasWaldmann: looks small to me
112 2012-05-20T20:34:11 <ThomasWaldmann> well, i first moved common code to base class, see changesets before that
113 2012-05-20T20:35:38 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 87:a0622a5b4877 EmeraldTree/.hgignore: updated .hgignore
114 2012-05-20T20:43:11 <CIA-146> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 88:2d7b39aaa590 EmeraldTree/ (README setup.py): setup.py: add keywords, README: add ET repo url
115 2012-05-20T20:49:37 <jaiditya> ThomasWaldmann: http://etherpad.osuosl.org/moin2-ImproveThemes
116 2012-05-20T21:04:35 <dreimark> eSyr-ng: I review currently
117 2012-05-20T21:05:09 <eSyr-ng> dreimark: good, just uploaded updated version :)
118 2012-05-20T21:05:14 <eSyr-ng> ThomasWaldmann: ^^^
119 2012-05-20T21:08:00 <dreimark> eSyr-ng: http://codereview.appspot.com/6209085/patch/7001/8002 update of this=
120 2012-05-20T21:09:12 <eSyr-ng> dreimark: no, this is the last version currently.
121 2012-05-20T21:09:56 <eSyr-ng> (my statement mostly referred to other patchsets)
122 2012-05-20T21:10:26 <eSyr-ng> (and this i've updated first so you're reviewing latest version at the time)
123 2012-05-20T21:15:44 <dreimark> but there is not all in
124 2012-05-20T21:15:50 <dreimark> e.g. fullsearch is missing
125 2012-05-20T21:16:13 <eSyr-ng> dreimark: how is better handle situation regarding page/macro name codepage? Force it to unicode like .decode("utf-8")?
126 2012-05-20T21:16:57 <eSyr-ng> 6206092 highlight suppression in fullsearch action (needs additions in UI) me 11 minutes
127 2012-05-20T21:21:09 <dreimark> usually the name is utf-8 already, otherwise we have a bug in encoding
128 2012-05-20T21:21:23 <dreimark> but the rest of the string should also be unicode
129 2012-05-20T21:21:54 <dreimark> or we run in codec problems
130 2012-05-20T21:22:53 <eSyr-ng> hmm, in this case i think forcing everything to unicode is fine.
131 2012-05-20T21:28:23 <ThomasWaldmann> xiaq: "Issue management systems that allow creating tickets anonymously are the worst. You never know if the ticket author follows up." Jannis Leidel via Twitter.
132 2012-05-20T21:38:14 *** jaiditya|2
133 2012-05-20T21:39:15 <ThomasWaldmann> dreimark: why are we talking about "utf-8"? (and not about unicode python type)?
134 2012-05-20T21:40:17 <ThomasWaldmann> eSyr-ng: was that ALL duplicated?
135 2012-05-20T21:40:58 <dreimark> ThomasWaldmann: sorry, my mistake
136 2012-05-20T21:41:13 *** jaiditya
137 2012-05-20T21:41:30 <dreimark> eSyr-ng: ^^
138 2012-05-20T21:41:58 <dreimark> unicode "type"
139 2012-05-20T21:43:11 <eSyr-ng> ThomasWaldmann: mostrly. The only exception is titlesearch.
140 2012-05-20T21:43:24 <eSyr-ng> (and default needle)
141 2012-05-20T21:43:49 <ThomasWaldmann> just make sure all code you kill is really duplicated :) if so, I am happy with the removal.
142 2012-05-20T21:43:51 <eSyr-ng> *mostly
143 2012-05-20T21:45:23 <eSyr-ng> ThomasWaldmann: well, i moved all uncommon behaviour (namedly, ValueError handling) to FullSearch. Remaining part is the same.
144 2012-05-20T21:50:02 <dreimark> ThomasWaldmann: http://moinmo.in/TitleIndex
145 2012-05-20T21:50:05 <dreimark> crashes
146 2012-05-20T21:50:28 <dreimark> now it works
147 2012-05-20T21:51:31 <eSyr-ng> dreimark: timeout
148 2012-05-20T22:00:06 <eSyr-ng> ThomasWaldmann: http://codereview.appspot.com/6209085/diff/7001/MoinMoin/macro/FullSearch.py#newcode110 mmm, arg[1].lower()
149 2012-05-20T22:01:52 <ThomasWaldmann> ah! -.-
150 2012-05-20T22:02:18 <MaikuMori> I'm doing some changes on EP
151 2012-05-20T22:04:22 <eSyr-ng> dreimark: by utf8 you meant utf8 bytestrings or unicode strings?
152 2012-05-20T22:05:15 <dreimark> the type should be set not '...' but u'...'
153 2012-05-20T22:05:28 <eSyr-ng> understood.
154 2012-05-20T22:05:49 <dreimark> if we could have something like that http://dezignus.com/free-creative-font/
155 2012-05-20T22:06:26 <dreimark> with a foss license it can have colorful emoticons in a font too
156 2012-05-20T22:06:31 <dreimark> jaiditya|2: ^
157 2012-05-20T22:06:32 <ThomasWaldmann> nice header there
158 2012-05-20T22:08:15 <ThomasWaldmann> dreimark: how is that related to what we need?
159 2012-05-20T22:09:04 <eSyr-ng> rendering font is svg, ok
160 2012-05-20T22:09:11 <eSyr-ng> innovational!
161 2012-05-20T22:09:40 <ThomasWaldmann> svg font support isn't that widespread, see the ticket for font icons we have
162 2012-05-20T22:09:41 <eSyr-ng> i think it would be unique feature for many years which no one will repeat.
163 2012-05-20T22:10:16 <MaikuMori> Any ideas/comments on distribution? Python package vs simple directory?
164 2012-05-20T22:10:25 <eSyr-ng> ThomasWaldmann: not support of fonts in svg but rendering of glyphs into svg curves.
165 2012-05-20T22:11:10 <eSyr-ng> MaikuMori: hm, python package can have some additional initialisation code, maybe this may be useful.
166 2012-05-20T22:11:46 <MaikuMori> Each has pros and cons. Packages are harder to automatically find.
167 2012-05-20T22:11:58 <eSyr-ng> mmmm, why?
168 2012-05-20T22:12:10 <eSyr-ng> moin1.x rather successfully does the job.
169 2012-05-20T22:12:24 <MaikuMori> using imports or?
170 2012-05-20T22:12:38 <eSyr-ng> yes.
171 2012-05-20T22:13:10 <MaikuMori> That's not very automatic. With directories you can just drop it on "plugins" folder and have it discovered.
172 2012-05-20T22:13:45 <ThomasWaldmann> MaikuMori: i think it should be pypi packages, that solves distribution, installation, dependencies,...
173 2012-05-20T22:14:00 <MaikuMori> Can be done with packages as well provided there is no issue with the namespeces. Since you need common point from where to start the search.
174 2012-05-20T22:14:19 <MaikuMori> ThomasWaldmann: yeah those are the good things
175 2012-05-20T22:14:25 <eSyr-ng> MaikuMori: path is the part of configuration.
176 2012-05-20T22:14:27 <ThomasWaldmann> and we'ld just use import packagename then, that also works from a directory that is in sys.path, even if you did not install the file from a package
177 2012-05-20T22:15:59 <MaikuMori> I guess that can be a good start, I'd rather have a list of installed plugins provided to the user automatically.
178 2012-05-20T22:16:06 <MaikuMori> But it all can be added later.
179 2012-05-20T22:16:09 <ThomasWaldmann> MaikuMori: search is maybe not even required
180 2012-05-20T22:16:52 <eSyr-ng> MaikuMori: well, at least trac do this somehow.
181 2012-05-20T22:17:36 <MaikuMori> Trac uses entrypoints
182 2012-05-20T22:18:34 <MaikuMori> And we came to concusion that entrypoints are a bit unstable at the moment since they're still not implemented in "packaging" aka distribute2
183 2012-05-20T22:19:02 <eSyr-ng> hmmm.
184 2012-05-20T22:21:31 <MaikuMori> Also regarding coding, do we each create a new branch?
185 2012-05-20T22:22:38 *** jaiditya|2
186 2012-05-20T22:25:35 <ThomasWaldmann> -> EP
187 2012-05-20T22:25:42 <ThomasWaldmann> http://etherpad.osuosl.org/moin2-PluginSystem
188 2012-05-20T22:26:52 <MaikuMori> Also metadata is an interesting question
189 2012-05-20T22:27:18 <MaikuMori> You're using .py fiile in XStatic right?
190 2012-05-20T22:38:16 <ThomasWaldmann> setup.py as usual in pypi
191 2012-05-20T22:38:50 <ThomasWaldmann> plus some metadata a duplicated into a python file so they are easier accessible from python
192 2012-05-20T22:38:54 <ThomasWaldmann> -a
193 2012-05-20T22:39:30 <ThomasWaldmann> MaikuMori: are you still on EP?
194 2012-05-20T22:40:52 <MaikuMori> yes
195 2012-05-20T22:52:04 <dreimark> gn
196 2012-05-20T22:58:17 *** MattMaker
197 2012-05-20T23:07:16 *** sudo_dirk
198 2012-05-20T23:08:35 *** MattMaker
199 2012-05-20T23:09:31 <eSyr-ng> ThomasWaldmann: http://codereview.appspot.com/6209085/ http://codereview.appspot.com/6218057/
200 2012-05-20T23:10:31 *** Trip_
201 2012-05-20T23:10:42 *** MattMaker
202 2012-05-20T23:16:46 *** Trip_
203 2012-05-20T23:38:09 <eSyr-ng> ThomasWaldmann: http://rn0.ru/show/6On6bsj1IEuD6mQudtx8/
