MoinMoin: MoinMoinChat/Logs/moin-dev/2012-05-21

   1 2012-05-21T00:16:59  <ThomasWaldmann> eSyr-ng: http://rn0.ru/show/6On6bsj1IEuD6mQudtx8/ 36 search QUERY option
   2 2012-05-21T00:17:15  <ThomasWaldmann> (give an example)
   3 2012-05-21T00:18:26  <ThomasWaldmann> 40 addition -> adding?
   4 2012-05-21T00:19:12  <ThomasWaldmann> and maybe it is simple to describe both options separately and giving the full config attr name
   5 2012-05-21T00:19:32  <ThomasWaldmann> simpler*
   6 2012-05-21T00:19:52  *** jaiditya has quit IRC
   7 2012-05-21T00:23:32  <ThomasWaldmann> http://codereview.appspot.com/6209085/ looks ok. ran tests / done manual testing?
   8 2012-05-21T00:25:54  <ThomasWaldmann> http://codereview.appspot.com/6218057 looks ok also. -""-
   9 2012-05-21T00:27:38  <eSyr-ng> ThomasWaldmann: currently doing some tests comparing old/new behaviour, looks like no impact on default config
  10 2012-05-21T00:56:28  <eSyr-ng> ThomasWaldmann: http://rn0.ru/show/Jo5ElJCnoWTZL9aLvjHi/
  11 2012-05-21T01:06:02  <ThomasWaldmann> 36 ... suppressing highlighting search results?
  12 2012-05-21T01:08:02  <eSyr-ng> fixed.
  13 2012-05-21T01:24:45  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5855:3315eb3e4012 1.9/MoinMoin/search/results.py: search/results.py: provide ability to suppress highlighting in page list and link URL parameters.
  14 2012-05-21T01:24:46  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5856:8e5559a0a08b 1.9/MoinMoin/ (config/multiconfig.py macro/FullSearch.py macro/PageList.py):
  15 2012-05-21T01:24:46  <CIA-146> PageList, FullSearch macros: ability to suppress highlighting in result list and
  16 2012-05-21T01:24:48  <CIA-146> item links added alongside with appropriate configuration options. PageList
  17 2012-05-21T01:24:48  <CIA-146> macros is now implemented via FullSearch macros for code deduplication.
  18 2012-05-21T01:24:48  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5857:a89531afebe8 1.9/MoinMoin/search/queryparser/ (__init__.py expressions.py): search/queryparser: no_highlight: search operator added to provide ability to suppress highlighting for (part of) search query.
  19 2012-05-21T01:24:48  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5858:be11f1e64e73 1.9/MoinMoin/ (Page.py config/multiconfig.py): Page.py: added message with information about highlight regexp and link to non-highlighted version (disabled by default in config).
  20 2012-05-21T01:24:48  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5859:570e430cd08c 1.9/MoinMoin/action/fullsearch.py: action/fullsearch.py: ability to suppress highlighting in fullsearch action added.
  21 2012-05-21T01:24:49  <CIA-146> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5860:9acfab97e561 1.9/docs/CHANGES: CHANGES updated regarding highlight control options.
  22 2012-05-21T02:09:25  <eSyr-ng> ThomasWaldmann: can you restart instance which serves moinmo.in? Looks like updated version of FullSearch macro is loaded along with old version of core :\
  23 2012-05-21T04:51:51  *** dwcramer has quit IRC
  24 2012-05-21T08:09:13  <dreimark> MaikuMori: http://www.doodle.com/cvfkrvm4zsygkc6m already updated?
  25 2012-05-21T08:11:14  <dreimark> DasIch: ^
  26 2012-05-21T08:26:46  *** jaiditya has joined #moin-dev
  27 2012-05-21T08:47:23  <eSyr-ng> dreimark: btw, since next week i can be at Wednesday evening if it helps.
  28 2012-05-21T09:36:12  <xiaq> dreimark: my time won't change much, this semester ends at ~Jun. 15
  29 2012-05-21T09:36:51  <xiaq> dreimark: i will have more free time after that, so if we decide to change the meeting time then it will be good for me
  30 2012-05-21T09:49:31  <dreimark> ok, we can decide mid jun again
  31 2012-05-21T11:29:11  *** greg_f has joined #moin-dev
  32 2012-05-21T11:55:03  *** eSyr has quit IRC
  33 2012-05-21T12:04:31  *** eSyr has joined #moin-dev
  34 2012-05-21T13:33:59  *** dwcramer has joined #moin-dev
  35 2012-05-21T14:33:55  *** dwcramer has quit IRC
  36 2012-05-21T14:42:08  *** dave_largo has joined #moin-dev
  37 2012-05-21T15:22:10  *** spy has joined #moin-dev
  38 2012-05-21T15:23:00  *** kanha has joined #moin-dev
  39 2012-05-21T15:23:19  *** kanha_ has quit IRC
  40 2012-05-21T15:36:36  *** greg_f has quit IRC
  41 2012-05-21T15:38:36  *** greg_f has joined #moin-dev
  42 2012-05-21T15:48:18  *** dwcramer has joined #moin-dev
  43 2012-05-21T17:00:46  *** greg_f has quit IRC
  44 2012-05-21T17:16:03  *** greg_f has joined #moin-dev
  45 2012-05-21T17:41:40  *** DasIch_ has joined #moin-dev
  46 2012-05-21T17:43:43  *** DasIch has quit IRC
  47 2012-05-21T17:43:43  *** DasIch_ is now known as DasIch
  48 2012-05-21T17:50:32  *** MattMaker has joined #moin-dev
  49 2012-05-21T17:59:00  *** dwcramer has quit IRC
  50 2012-05-21T18:02:04  *** dwcramer has joined #moin-dev
  51 2012-05-21T18:24:58  *** dwcramer has quit IRC
  52 2012-05-21T18:29:43  *** dwcramer has joined #moin-dev
  53 2012-05-21T19:11:36  *** yufra has quit IRC
  54 2012-05-21T19:22:41  *** yufra has joined #moin-dev
  55 2012-05-21T19:39:17  *** greg_f has quit IRC
  56 2012-05-21T19:40:52  <ThomasWaldmann> as there are questions on how/when to submit code:
  57 2012-05-21T19:41:19  <ThomasWaldmann> you should use codereview to publish your hg workdir contents and ask your mentor for review
  58 2012-05-21T19:42:00  <jaiditya> ok
  59 2012-05-21T19:42:08  <ThomasWaldmann> then iterate until you have reached a good state, then commit, then push to your public bitbucket repo
  60 2012-05-21T19:42:21  <ThomasWaldmann> (which starts as a clone of the moin/2.0 repo)
  61 2012-05-21T19:43:14  <ThomasWaldmann> ah, and before you ask for mentor review, you please do an own review to kill the trivial issues you'll find yourself when just reading your changes slowly
  62 2012-05-21T19:43:30  <ThomasWaldmann> you can use hg diff | less   and hg st  for that
  63 2012-05-21T19:53:31  <eSyr-ng> ThomasWaldmann: one note: better commit before review, then, when doing changes upon review, make small commits which easily can be merged during histedit.
  64 2012-05-21T19:54:32  <eSyr-ng> it gives ability to review multiple patchsets simultaneously (well, until you're not storing each patchset in separate branch) and gives ability to make cleaner and smaller and more atomic commits.
  65 2012-05-21T19:54:46  * ThomasWaldmann updated the GoogleSoc2012 wiki page
  66 2012-05-21T19:55:17  <eSyr-ng> (so, basicly, hg histedit, hg rebase, hg record)
  67 2012-05-21T19:55:22  <eSyr-ng> (or git-hg, hehe)
  68 2012-05-21T19:55:30  <ThomasWaldmann> eSyr-ng: i don't think codereview upload.py works when you try it after commit
  69 2012-05-21T19:55:49  <eSyr-ng> ThomasWaldmann: well, i did it every time already :)
  70 2012-05-21T19:56:22  <eSyr-ng> upload.py  --rev 5856:5857
  71 2012-05-21T19:56:27  <eSyr-ng> upload.py  --rev 5857:5859
  72 2012-05-21T19:56:30  <eSyr-ng> and so on.
  73 2012-05-21T19:56:54  <ThomasWaldmann> do you want to document that procedure on the wiki, maybe a CodeReview page?
  74 2012-05-21T19:56:58  <eSyr-ng> well, this is my workflow, of course it may be not suitable for everyone.
  75 2012-05-21T19:57:02  <eSyr-ng> ok.
  76 2012-05-21T19:57:05  * ThomasWaldmann used that stuff in a lot simpler way :)
  77 2012-05-21T19:57:43  <ThomasWaldmann> keep in mind that some students are new to hg :)
  78 2012-05-21T19:58:13  <eSyr-ng> ThomasWaldmann: me too :)
  79 2012-05-21T20:29:33  *** spy_ has joined #moin-dev
  80 2012-05-21T20:30:26  *** jaiditya has quit IRC
  81 2012-05-21T20:30:47  *** jaiditya|2 has joined #moin-dev
  82 2012-05-21T20:35:01  <breton> ThomasWaldmann: we should decide something on heads now, http://etherpad.osuosl.org/moin2-bms 82-86
  83 2012-05-21T20:45:26  <ronny> ThomasWaldmann: i adde a note to the bms thing
  84 2012-05-21T21:22:24  <ThomasWaldmann> ronny: give line numbers
  85 2012-05-21T21:22:34  <ronny> 14
  86 2012-05-21T21:32:13  <jaiditya|2> foobar theme colour palette http://codereview.appspot.com/6223057/
  87 2012-05-21T21:32:32  *** jaiditya|2 is now known as jaiditya
  88 2012-05-21T22:17:24  <breton> ThomasWaldmann: 18
  89 2012-05-21T23:15:49  *** dave_largo has quit IRC
  90 2012-05-21T23:46:16  *** spy_ has quit IRC
  91