1 2012-05-24T00:02:55 *** dwcramer
2 2012-05-24T01:20:04 <spy> http://codereview.appspot.com/6238045
3 2012-05-24T01:25:44 *** spy_
4 2012-05-24T01:26:07 *** spy
5 2012-05-24T01:38:36 *** spy
6 2012-05-24T01:38:48 *** spy_
7 2012-05-24T01:58:46 *** spy
8 2012-05-24T01:59:34 *** spy
9 2012-05-24T01:59:54 *** spy
10 2012-05-24T02:20:19 *** dwcramer
11 2012-05-24T03:03:49 *** moinBot`
12 2012-05-24T03:03:49 *** moinBot
13 2012-05-24T03:39:27 *** sudo_dirk1
14 2012-05-24T03:41:20 *** sudo_dirk
15 2012-05-24T04:24:43 *** dwcramer
16 2012-05-24T04:44:10 *** dwcramer
17 2012-05-24T05:03:30 *** dwcramer
18 2012-05-24T06:27:03 *** xjjk
19 2012-05-24T09:21:47 *** DasIch_
20 2012-05-24T09:38:27 *** jaiditya
21 2012-05-24T10:13:39 *** eSyr
22 2012-05-24T10:13:44 *** eSyr
23 2012-05-24T11:31:36 *** greg_f
24 2012-05-24T12:29:11 <xiaq> hi all
25 2012-05-24T12:30:22 <xiaq> i just read announcement that my university is going to have a scheduled electricity cutoff on 5-25 0:00-1:00 (which is 5-24 16:00-17:00)
26 2012-05-24T12:30:40 <xiaq> so i won't be able to attend part of the weekly meeting :(
27 2012-05-24T12:30:47 <eSyr-ng> xiaq: 16/17 UTC?
28 2012-05-24T12:30:55 <xiaq> eSyr-ng: yes
29 2012-05-24T12:31:07 <eSyr-ng> huh, such a coincidence.
30 2012-05-24T12:32:01 <xiaq> eSyr-ng: yeah, actually it is citi-wise electricity grid examination
31 2012-05-24T12:32:58 <eSyr-ng> well, i think, this is not big issie, we can talk earlier or later this day if everyone related is free.
32 2012-05-24T12:35:31 <xiaq> eSyr-ng: i think i can just be the last one to talk
33 2012-05-24T12:36:02 <eSyr-ng> xiaq: if wee not be too quick and electricity will not be dealyed :)
34 2012-05-24T12:36:08 <eSyr-ng> *we will
35 2012-05-24T12:36:17 <eSyr-ng> *delayed
36 2012-05-24T12:37:16 <xiaq> eSyr-ng: well, according to past experience the power supply actually resumes before 1:00 (UTC+8), around 0:40 i think
37 2012-05-24T12:39:12 <ThomasWaldmann> xiaq: if they finish on time, just join the still ongoing meeting
38 2012-05-24T12:39:22 <xiaq> eSyr-ng: oth, it's also possible that the power cutoff will damage the dormitory routers - it has happened several times, which luckily didn't affect my dorm
39 2012-05-24T12:39:32 <xiaq> s/oth/otoh/
40 2012-05-24T12:40:02 <xiaq> ThomasWaldmann: okay, i'll be getting online asap
41 2012-05-24T13:12:23 *** jaiditya
42 2012-05-24T13:40:51 *** jaiditya
43 2012-05-24T13:41:00 *** jaiditya
44 2012-05-24T14:02:28 *** dwcramer
45 2012-05-24T14:08:16 <jaiditya> http://codereview.appspot.com/6255043/
46 2012-05-24T14:12:49 *** dwcramer
47 2012-05-24T14:36:00 *** dwcramer
48 2012-05-24T14:40:05 *** dave_largo
49 2012-05-24T14:48:57 *** dwcramer
50 2012-05-24T15:26:59 *** kanha_
51 2012-05-24T15:27:36 *** kanha
52 2012-05-24T15:29:28 <dreimark> waldi: http://codereview.appspot.com/6255043/
53 2012-05-24T16:28:50 *** dwcramer
54 2012-05-24T17:42:30 *** DasIch
55 2012-05-24T17:46:30 *** spy
56 2012-05-24T17:55:59 <dreimark> re
57 2012-05-24T17:57:29 <DasIch> hi
58 2012-05-24T17:57:40 <ThomasWaldmann> dreimark: can you manage the meeting, i am still busy a bit otherwise
59 2012-05-24T17:57:54 <dreimark> ok
60 2012-05-24T17:58:04 <dreimark> everyone here?
61 2012-05-24T17:58:48 <DasIch> I'm here :)
62 2012-05-24T17:58:55 <breton> +
63 2012-05-24T17:59:08 *** xiaq
64 2012-05-24T18:00:31 <spy> yes, here
65 2012-05-24T18:01:48 * dreimark just a note before we start
66 2012-05-24T18:02:30 <dreimark> the month calendar diary pages are for telling on what you are working or why you can't
67 2012-05-24T18:03:16 <dreimark> please add also entries when you are blocked by other stuff
68 2012-05-24T18:03:24 <dreimark> but keep those blockers low
69 2012-05-24T18:03:37 <ThomasWaldmann> (I think the day pages only shall be to report about work, otherwise you won't see on the calendar view when work was done and when not)
70 2012-05-24T18:05:09 <dreimark> yes, then add it to the homepage
71 2012-05-24T18:06:03 <dreimark> at least there should be a hint for the mentors and it shouldn't look someone has vanished
72 2012-05-24T18:06:17 <dreimark> any more commens to that point?
73 2012-05-24T18:07:05 <dreimark> anyone in a hurry, otherwise I take the same order, than last week
74 2012-05-24T18:07:56 <dreimark> breton: your stage
75 2012-05-24T18:08:10 <breton> LAST: not much - etherpad mostly and started working on editing a specific revision as suggested by Thomas
76 2012-05-24T18:08:13 <breton> BLOCKERS: lack of plan on branches. Though I still can do N-people editing and merging without it.
77 2012-05-24T18:08:16 <breton> NEXT: finish coding editing of a specific revision, code N-people editing (http://etherpad.osuosl.org/moin2-bms, 40)
78 2012-05-24T18:08:44 <breton> (NEXT is not fully complete, I hope I will be able to start doing some branching stuff)
79 2012-05-24T18:09:18 <dreimark> can you rephrase Though I still can do N-... edits
80 2012-05-24T18:09:26 <dreimark> what part of is blocking
81 2012-05-24T18:09:51 <breton> the blocking part is lack of plan on branches.
82 2012-05-24T18:10:31 <breton> N-people edits... er... it was just a thought, never mind. Don't read that part.
83 2012-05-24T18:11:14 <DasIch> isn't it possible to use bookmarks or something as feature branches locally?
84 2012-05-24T18:11:17 <dreimark> the Branches section from EP 13
85 2012-05-24T18:11:53 <ThomasWaldmann> breton: aside from coding, you should also have own ideas on how heads/branches etc. are used, there wasn't much progress recently
86 2012-05-24T18:12:00 <DasIch> oops, ignore that part
87 2012-05-24T18:12:14 <ThomasWaldmann> I'll also think about it, but don't just wait for me, do own work.
88 2012-05-24T18:12:56 <breton> ok.
89 2012-05-24T18:13:32 <breton> though I don't see much application for heads and branches, except versioning <_<
90 2012-05-24T18:13:51 <eSyr-ng> breton: drafts
91 2012-05-24T18:13:54 <dreimark> breton: I look later for some stuff
92 2012-05-24T18:14:00 <eSyr-ng> breton: local editing
93 2012-05-24T18:14:22 <eSyr-ng> breton: wiki sync
94 2012-05-24T18:14:59 <dreimark> we also have ther serializer
95 2012-05-24T18:15:08 <ThomasWaldmann> breton: you will heave multiple heads, it is unavoidable (even if you avoid it locally, they'll grow remotely)
96 2012-05-24T18:15:19 <eSyr-ng> breton: advanced access right control (can't edit, but can fork)
97 2012-05-24T18:15:33 <breton> eSyr-ng: already enumerated on the pad.
98 2012-05-24T18:15:55 <breton> except advanced access control, hm
99 2012-05-24T18:16:01 <eSyr-ng> breton: isn't it enough then?
100 2012-05-24T18:16:41 <dreimark> do you need more inout, define blocking part more precisly
101 2012-05-24T18:18:45 <breton> well, now we cannot decide how to store branches
102 2012-05-24T18:18:56 <breton> (as far as I understand)
103 2012-05-24T18:20:31 <ThomasWaldmann> (I guess I already advised 2 times to get clear about use cases and how to precicely USE stuff, and then think about storage and indexing)
104 2012-05-24T18:20:51 *** dwcramer
105 2012-05-24T18:23:47 <dreimark> breton: please prepare sections in the ep for that
106 2012-05-24T18:24:08 <breton> wok.
107 2012-05-24T18:24:10 <breton> *ok.
108 2012-05-24T18:24:16 <dreimark> you need also those for doing tests and disussion is much easier
109 2012-05-24T18:24:54 <dreimark> more questions to breton ?
110 2012-05-24T18:25:07 * ThomasWaldmann not
111 2012-05-24T18:25:57 <dreimark> breton: thanks
112 2012-05-24T18:26:01 <dreimark> DasIch: you are next
113 2012-05-24T18:26:11 <DasIch> LAST"
114 2012-05-24T18:26:53 <DasIch> LAST: worked on the etherpad, setup a local dev environment, read moin code
115 2012-05-24T18:27:11 <DasIch> BLOCKING: none
116 2012-05-24T18:27:49 <ThomasWaldmann> the last 2 items could have been done a long time ago...
117 2012-05-24T18:28:31 <DasIch> NEXT: There needs to be some cooperation regarding the API, so that it is consistent
118 2012-05-24T18:28:43 <dreimark> at least the second last, the last can be done always
119 2012-05-24T18:28:54 <DasIch> I think this deserves a separate etherpad
120 2012-05-24T18:29:29 <DasIch> apart from that I'm going to start coding next
121 2012-05-24T18:29:30 <ThomasWaldmann> which api precisely do you mean and cooperation with who?
122 2012-05-24T18:30:52 <DasIch> ThomasWaldmann: with whoever is working on an API unless nobody else is doing that
123 2012-05-24T18:31:30 <ThomasWaldmann> which api precisely do you mean?
124 2012-05-24T18:31:34 <dreimark> http://etherpad.osuosl.org/moin2-PasteBin 65
125 2012-05-24T18:31:49 <dreimark> you mean everything there related to someone else?
126 2012-05-24T18:31:52 *** brunomartin
127 2012-05-24T18:32:02 <DasIch> ThomasWaldmann: the HTTP api
128 2012-05-24T18:33:01 <DasIch> ThomasWaldmann: versioning, authentication that kind of stuff should be consistent
129 2012-05-24T18:33:10 <ThomasWaldmann> well, you obviously added some stuff to the etherpad without telling
130 2012-05-24T18:33:43 <ThomasWaldmann> so I think you can't expect sensible comments on it right now, before i had time for reading and thinking about it
131 2012-05-24T18:35:57 <dreimark> ThomasWaldmann: DasIch you can discuss this later in the next hours - days
132 2012-05-24T18:36:37 <dreimark> DasIch: with which part do you start coding?
133 2012-05-24T18:36:55 <dreimark> is that independent from the result of that discussion?
134 2012-05-24T18:37:28 <DasIch> dreimark: storing stuff in the database
135 2012-05-24T18:39:36 *** moinBot
136 2012-05-24T18:39:49 <dreimark> thanks DasIch
137 2012-05-24T18:39:56 * ThomasWaldmann wants better and more frequent communication, but no questions right now
138 2012-05-24T18:40:02 <DasIch> ok
139 2012-05-24T18:41:02 <dreimark> MaikuMori: you are next (because xiaq is sifted to the end)
140 2012-05-24T18:41:28 <dreimark> eSyr-ng: ^
141 2012-05-24T18:41:40 <MaikuMori> just got back
142 2012-05-24T18:41:53 <dreimark> your stage
143 2012-05-24T18:42:28 <MaikuMori> LAST: Sorted out some of EP, set some goals
144 2012-05-24T18:43:07 <MaikuMori> BLOCKERS: Still got university 1 week which is eating up my time as it's the last week
145 2012-05-24T18:43:23 <MaikuMori> NEXT: Make a example plugin
146 2012-05-24T18:43:26 <MaikuMori> an*
147 2012-05-24T18:44:35 <dreimark> the todo 10 are they still relevant?
148 2012-05-24T18:45:14 <dreimark> http://etherpad.osuosl.org/moin2-PluginSystem
149 2012-05-24T18:45:45 <MaikuMori> Some are
150 2012-05-24T18:45:57 <dreimark> clean up there
151 2012-05-24T18:46:35 <dreimark> which part of 32 does the example plugin cover?
152 2012-05-24T18:47:03 <MaikuMori> Just going to be the structure at the start
153 2012-05-24T18:47:10 <ThomasWaldmann> DasIch: adding some stuff to your etherpad (api section)
154 2012-05-24T18:47:52 <ThomasWaldmann> MaikuMori: you mean an example plugin PACKAGE?
155 2012-05-24T18:47:56 <MaikuMori> yeah
156 2012-05-24T18:48:13 <dreimark> ah, so you agreed to use pypi?
157 2012-05-24T18:48:27 <MaikuMori> Yep
158 2012-05-24T18:48:52 <MaikuMori> as per 133
159 2012-05-24T18:49:33 <dreimark> also if you work on ep, add it to the diary. and prepare there a section for the univerity blockers or other days
160 2012-05-24T18:49:53 <MaikuMori> Can do
161 2012-05-24T18:51:39 <dreimark> eSyr-ng: or others further questions to MaikuMori ?
162 2012-05-24T18:51:53 <waldi> nope
163 2012-05-24T18:52:38 <dreimark> thanks MaikuMori
164 2012-05-24T18:52:48 <dreimark> next is spy
165 2012-05-24T18:53:04 <spy> LAST: Created own bitbucket repo that is a fork of the main moin/2.0 repo. Played with upload.py for codereview. Added 'ptime' meta key to blog post items, 'logo' and 'supertags' meta keys to blog home items. Studied testing and codereview processes.
166 2012-05-24T18:53:05 <spy> BLOCKERS: none
167 2012-05-24T18:53:07 <spy> NEXT: Investigate the internal mimetype-based transformation of data mechanism. We have to finally understand what view method we will use for the bloghome and blogposts representation, discuss this. Implement simple views which will be deal with posts adding, publishing and blog clearing.
168 2012-05-24T18:54:03 <ThomasWaldmann> (about creating a repo etc... - same comment as above, could've been done much earlier)
169 2012-05-24T18:54:27 <dreimark> please link repo from project page (all others please do too)
170 2012-05-24T18:55:00 <spy> ok, of course
171 2012-05-24T18:55:56 <spy> done
172 2012-05-24T18:55:57 <ThomasWaldmann> as you just added ptime, maybe using that would also be a good step (for blog post list sorting)
173 2012-05-24T18:56:48 <ThomasWaldmann> btw, did you fix the small issues found in review?
174 2012-05-24T18:57:35 <spy> that would be good, but we still don't have any views for listing
175 2012-05-24T18:58:23 <spy> ThomasWaldmann: fixed, will push soon
176 2012-05-24T18:59:22 <dreimark> please care on comments on reviews
177 2012-05-24T18:59:48 <ThomasWaldmann> spy: use same id on codereview
178 2012-05-24T19:00:11 <dreimark> that makes a diff diff merge
179 2012-05-24T19:00:24 <spy> ThomasWaldmann: same id for what?
180 2012-05-24T19:00:31 <dreimark> for upload.py
181 2012-05-24T19:00:51 *** xiaq
182 2012-05-24T19:02:18 <dreimark> spy: everything in NEXT is until our next meeting?
183 2012-05-24T19:02:39 * xiaq is back, hope i haven't missed too much :(
184 2012-05-24T19:02:55 <dreimark> wb xiaq
185 2012-05-24T19:03:03 <spy> I hope that happen
186 2012-05-24T19:03:09 <dreimark> :)
187 2012-05-24T19:03:39 <dreimark> xiaq: http://moinmo.in/MoinMoinChat/Logs/moin-dev/2012-05-24
188 2012-05-24T19:03:49 * xiaq looks
189 2012-05-24T19:04:21 <ThomasWaldmann> well, read that later, please :)
190 2012-05-24T19:04:27 <xiaq> alright
191 2012-05-24T19:04:36 <dreimark> spy: i am not sure but there can be an issue in the convertor between different content types
192 2012-05-24T19:04:49 <dreimark> or ThomasWaldmann do you know, is that still there?
193 2012-05-24T19:05:36 <spy> this is for better understanding renver methods described by Thomas and xiaq
194 2012-05-24T19:05:39 * ThomasWaldmann has no idea what issue you mean
195 2012-05-24T19:05:43 <spy> *render
196 2012-05-24T19:06:15 <dreimark> ok, look at that later
197 2012-05-24T19:06:55 <dreimark> further questions to spy ?
198 2012-05-24T19:08:01 <ThomasWaldmann> not right now
199 2012-05-24T19:08:16 <dreimark> thanks spy
200 2012-05-24T19:08:37 <dreimark> jaiditya: your stage
201 2012-05-24T19:08:39 <dreimark> waldi: ^
202 2012-05-24T19:08:48 <jaiditya> LAST: Started coding with CSS(precisely color palette) of foobar theme
203 2012-05-24T19:08:48 <jaiditya> BLOCKERS: Late reviews
204 2012-05-24T19:08:49 <jaiditya> NEXT: Continue styling of foobar theme and work on ep
205 2012-05-24T19:10:39 <waldi> right now i'm not sure if you don't want to understand what i'm telling you
206 2012-05-24T19:10:56 <waldi> i asked you several times to seperate restructuring from real changes
207 2012-05-24T19:12:06 <jaiditya> no, sorry. But I did that and at first I misunderstood it.
208 2012-05-24T19:12:11 <ThomasWaldmann> (that might make reviews much easier also)
209 2012-05-24T19:12:54 <dreimark> also if stylus could output linefeeds
210 2012-05-24T19:13:05 <waldi> jaiditya: sorry, no, you didn't. restructuring something should do no change in the output if possible
211 2012-05-24T19:14:16 <dreimark> we talk about http://codereview.appspot.com/6255043/
212 2012-05-24T19:14:50 <jaiditya> yeah. I tried not to change the output
213 2012-05-24T19:15:13 <waldi> this changeset already include three distinct changes
214 2012-05-24T19:16:12 <waldi> 1. move of the color definition. 2. renaming the definitions. 3. chaning colors
215 2012-05-24T19:17:00 <dreimark> 08:31 <dreimark> in total it can be three atomics, color replaced, color adjusted, other changes
216 2012-05-24T19:17:10 <waldi> exactly
217 2012-05-24T19:17:37 <jaiditya> My bad. I totally misundersood it.
218 2012-05-24T19:18:07 *** sudo_dirk1
219 2012-05-24T19:18:26 <waldi> okay
220 2012-05-24T19:21:09 <dreimark> it makes reviewing much easier and faster
221 2012-05-24T19:21:25 <dreimark> also it avoids some discussion
222 2012-05-24T19:21:54 <dreimark> can you later please look on stylus
223 2012-05-24T19:22:08 <dreimark> if it can ommit this one line output
224 2012-05-24T19:22:33 <jaiditya> yeah.
225 2012-05-24T19:22:35 <dreimark> if so that would be nice if it can be done initially with one commit
226 2012-05-24T19:22:56 <dreimark> (without an other change)
227 2012-05-24T19:23:54 <dreimark> further questions to jaiditya ?
228 2012-05-24T19:24:07 <ThomasWaldmann> not from me and now
229 2012-05-24T19:24:44 <dreimark> thanks jaiditya
230 2012-05-24T19:24:52 <dreimark> next is xiaq
231 2012-05-24T19:24:58 <xiaq> LAST: worked on meta_schema and/or render_method etherpad
232 2012-05-24T19:25:02 <xiaq> BLOCKER: none, or LAST could be considered as a blocker
233 2012-05-24T19:25:08 <xiaq> NEXT: since official code phase has already begun, i'd better do some coding :) i'll work on the metadata editor first, the rough thought is implementing it has a Jinja macro, taking some schema - perhaps Flatland form - as the argument
234 2012-05-24T19:25:14 <xiaq> As for the meta_schema/render_method stuff, resolution is not yet reached. Perhaps it is a good thing, as it may be easier easier to make observations and plans while working on the code. Still, we need to settle some discussion times for involved people (students and mentors of blog, ticket system and pastebin projects), to ensure consistenty and faciliate future code merging.
235 2012-05-24T19:26:52 <dreimark> xiaq: schedule a doodle time finder for that meeting
236 2012-05-24T19:27:17 <xiaq> dreimark: uh, time finder? should i script one? :)
237 2012-05-24T19:27:24 <dreimark> haha
238 2012-05-24T19:27:41 <xiaq> dreimark: i looked at the doodle
239 2012-05-24T19:28:03 <xiaq> and put off finding the time when i decided it would take quite some time
240 2012-05-24T19:28:20 <xiaq> (yeah, was busy with assignments, but should be better from this weekend on)
241 2012-05-24T19:28:56 <dreimark> ok
242 2012-05-24T19:29:44 <dreimark> which types do you plan for the meta data editorß
243 2012-05-24T19:29:46 <dreimark> ?
244 2012-05-24T19:30:06 <xiaq> free-form text, enumeration, number
245 2012-05-24T19:30:29 <xiaq> the border of free-form text and enumeration is blurry, should we adopt ThomasWaldmann's dynamic value proposal
246 2012-05-24T19:30:34 <ThomasWaldmann> apropos time finding and doodle: http://www.doodle.com/cvfkrvm4zsygkc6m everybody update his availability there and put (upd.) after his name when having done so
247 2012-05-24T19:30:42 <dreimark> is there some boolean required too?
248 2012-05-24T19:31:00 <xiaq> dreimark: yeah - and references
249 2012-05-24T19:31:07 <xiaq> (ref to user items, etc.)
250 2012-05-24T19:31:42 <ThomasWaldmann> spy will need date :)
251 2012-05-24T19:32:12 <ThomasWaldmann> ... metadata editing
252 2012-05-24T19:32:19 <dreimark> ThomasWaldmann: do you plan to merge that asap it is implemented?
253 2012-05-24T19:32:25 <xiaq> aha, it shouldn't be hard to add data types later
254 2012-05-24T19:33:20 <dreimark> true
255 2012-05-24T19:33:26 <xiaq> dreimark: about the doodle, seriously - seems i do have to find the time manually. the "calendar view" provides some suggestions, but that's not enough
256 2012-05-24T19:33:43 <dreimark> yeah, i made the other one
257 2012-05-24T19:34:04 <xiaq> dreimark: the other one??
258 2012-05-24T19:34:09 *** greg_f
259 2012-05-24T19:34:11 <xiaq> dreimark: the other what?
260 2012-05-24T19:34:13 <dreimark> http://www.doodle.com/cvfkrvm4zsygkc6m
261 2012-05-24T19:34:48 *** sudo_dirk
262 2012-05-24T19:35:04 <dreimark> (i meant i had that fun of all those times already)
263 2012-05-24T19:35:30 <dreimark> but may be we can use that too, if there is a match between 3 student and two mentors
264 2012-05-24T19:35:58 <dreimark> any other questions to xiaq ?
265 2012-05-24T19:36:14 <xiaq> dreimark: uh, another doodle for the meta_schema/render_view related things? the url you gave is just the one for the weekly meeting...
266 2012-05-24T19:36:34 <xiaq> (we can talk a bit later, after the meeting)
267 2012-05-24T19:37:45 <dreimark> at http://etherpad.osuosl.org/moin-issue-tracker
268 2012-05-24T19:37:48 <dreimark> 171
269 2012-05-24T19:38:10 <dreimark> is that solved ?
270 2012-05-24T19:38:23 <dreimark> or can it be ignored for now
271 2012-05-24T19:38:52 <dreimark> xiaq: ^
272 2012-05-24T19:39:16 <xiaq> dreimark: i suggest it be moved to the render_method ep, along with thomas's dynamic value set proposal
273 2012-05-24T19:39:38 <xiaq> dreimark: yeah, ignore but not exactly.
274 2012-05-24T19:39:52 <xiaq> dreimark: i hope it be resolved along with the render_method stuff.
275 2012-05-24T19:40:11 <dreimark> ok, the only problem i have with dynamic sets is that you have later old stuff not having all keys
276 2012-05-24T19:40:52 * xiaq needs to exchange battery
277 2012-05-24T19:41:05 <dreimark> ok, we are also at the end
278 2012-05-24T19:41:10 <xiaq> bbl
279 2012-05-24T19:41:11 <dreimark> thanks xiaq
280 2012-05-24T19:41:37 <dreimark> thanks all students and mentors for attending out first meeting in the coding phase ;)
281 2012-05-24T19:42:38 * ThomasWaldmann bbl
282 2012-05-24T19:43:58 <spy> dreimark: what are the right steps to make changes to my local commits and then review them again?
283 2012-05-24T19:44:36 <xiaq> The other battery is already dry too :(
284 2012-05-24T19:44:43 * xiaq on cellphone
285 2012-05-24T19:45:19 <xiaq> oh... irssi in Android terminal looks all corrupted
286 2012-05-24T19:46:12 <xiaq> i suppose i should go zzz for now and discuss later :)
287 2012-05-24T19:46:46 <xiaq> gn :)
288 2012-05-24T19:52:21 <dreimark> gn
289 2012-05-24T19:59:26 *** DasIch
290 2012-05-24T20:05:06 *** DasIch
291 2012-05-24T20:24:45 <spy> Suppose I've commited two revision to my local repo, then upload them to codereview. After review I should edit many thing in both revision. So, what is a best practice to edit my local commits? Unfortunately I can do only one rollback, what is about the second commit? (backout/strip/something else?)
292 2012-05-24T20:25:39 *** MaikuMori
293 2012-05-24T20:25:51 *** MaikuMori
294 2012-05-24T20:26:12 *** dwcramer
295 2012-05-24T20:28:00 *** brunomartin
296 2012-05-24T20:42:41 <DasIch> spy: changing commits is a really bad practice
297 2012-05-24T20:42:58 <DasIch> spy: just fix whatever needs fixing and create a new commit
298 2012-05-24T20:46:20 <spy> DasIch: so, is it better not to commit before review?
299 2012-05-24T20:47:02 <spy> DasIch: and how to continue working on code in such a case?
300 2012-05-24T20:49:19 <DasIch> spy: if you know the review will take a while but you want/have to continue working I'd just commit
301 2012-05-24T20:56:39 *** brunomartin
302 2012-05-24T21:02:47 <spy> ThomasWaldmann: http://codereview.appspot.com/6238045
303 2012-05-24T21:04:21 *** dwcramer
304 2012-05-24T21:05:06 *** dwcramer
305 2012-05-24T21:27:29 *** dave_largo
306 2012-05-24T21:36:02 *** dwcramer
307 2012-05-24T21:37:27 *** dave_largo
308 2012-05-24T21:59:55 <dreimark> spy: done
309 2012-05-24T22:44:14 *** dwcramer
310 2012-05-24T23:02:20 <ThomasWaldmann> re
311 2012-05-24T23:04:16 *** brunomartin
312 2012-05-24T23:18:19 *** dave_largo
313 2012-05-24T23:22:04 *** dwcramer
314
