1 2012-06-15T00:08:04 *** RogerHaase
2 2012-06-15T00:25:42 <spy> ThomasWaldmann: It looks like this: http://punk.psviderski.name/moin/moin-blog.png You noticed that there is a jinja2 solution to show the beginning of a longer text. There is the truncate() function, but the problem is that in template we have already rendered html. Thus we have to cut the beginning of the post data earlier, render it and then give it to the template.
3 2012-06-15T00:40:46 *** MattMaker
4 2012-06-15T00:53:33 <ThomasWaldmann> spy: line spacing looks a bit too small
5 2012-06-15T00:54:18 <ThomasWaldmann> spy: is this the main page (blog item)?
6 2012-06-15T00:54:43 <ThomasWaldmann> just wondering because the "title" is same as the 2nd heading
7 2012-06-15T00:56:04 <ThomasWaldmann> hmm, right, you can't use truncate then
8 2012-06-15T00:57:08 <ThomasWaldmann> i think you should solve that on dom level, then it is independant of the markup being used to write blog posts
9 2012-06-15T00:57:55 <ThomasWaldmann> or just use summary metadata?
10 2012-06-15T01:03:05 <spy> ThomasWaldmann: fixed http://punk.psviderski.name/moin/moin-blog.png
11 2012-06-15T01:04:06 <spy> ThomasWaldmann: no, summary is too poor solution for that
12 2012-06-15T01:06:08 <spy> dreimark on etherpad said that he has already written a macro that shows n chars of a paragraph in moin 1.9
13 2012-06-15T01:09:19 <ThomasWaldmann> unless otherwise proven, consider everything from moin 1.9 a bad hack
14 2012-06-15T01:10:32 <ThomasWaldmann> what you could do is a dom-to-dom converter that just grabs the first section from a document
15 2012-06-15T01:11:04 <ThomasWaldmann> if you put that into the usualy converter chain, you'ld get the first section no matter what the original markup was
16 2012-06-15T01:12:25 <ThomasWaldmann> http://test.moinmo.in/+dom/creole
17 2012-06-15T01:13:01 <ThomasWaldmann> with section i mean the stuff between headings.
18 2012-06-15T01:17:35 <spy> ThomasWaldmann: but not always we have headings. Maybe think deeper and provide more flexible mechanism to specify an arbitrary value for that. For example introduce some markup syntax like '--more--'. All blog engines that I know have this functionality.
19 2012-06-15T01:18:38 <ThomasWaldmann> well, markups are different
20 2012-06-15T01:18:56 <ThomasWaldmann> dom-tree is same thing
21 2012-06-15T01:19:57 <spy> macro?
22 2012-06-15T01:20:13 <ThomasWaldmann> (you could also grab the first paragraph, but i think heading is more flexible)
23 2012-06-15T01:20:24 <ThomasWaldmann> not all markups have macros
24 2012-06-15T01:21:21 <ThomasWaldmann> and i really think you shouldn't do own parsing of a markup you do not know (and as you can't predict what we will have in future...)
25 2012-06-15T01:24:25 <spy> okay
26 2012-06-15T01:25:31 <ThomasWaldmann> that "Here come the Ultrabooks" is what exactly in the blog post? summary? heading?
27 2012-06-15T01:25:37 <ThomasWaldmann> item name?
28 2012-06-15T01:27:05 <spy> "Here come the Ultrabooks" is part of item name without "myblog/"
29 2012-06-15T01:27:32 <spy> and then rendered data
30 2012-06-15T01:27:54 <ThomasWaldmann> i was just thinking how we could use summary :)
31 2012-06-15T01:28:03 <spy> hah :)
32 2012-06-15T01:28:43 <ThomasWaldmann> i think for bugs/issues we wanted to have shorter urls somehow but list the summary in the bugs list
33 2012-06-15T01:28:57 *** dwcramer
34 2012-06-15T01:29:35 <ThomasWaldmann> maybe you could do it the same way and decouple the headings from the item name that way
35 2012-06-15T01:29:50 <ThomasWaldmann> as soon as you want to have a "/" in there, it'll pay out
36 2012-06-15T01:30:50 <spy> mm, sounds interesting
37 2012-06-15T01:31:59 <ThomasWaldmann> also, url could be something like blog/ultrabooks and heading could be "Here come the ultrabooks"
38 2012-06-15T01:33:01 <ThomasWaldmann> and for the permalink, you'ld use the itemid, of course :)
39 2012-06-15T01:33:29 <spy> so do you suggest to use 'summary' for the title of the post?
40 2012-06-15T01:33:33 <ThomasWaldmann> but a minor change just for a different wording in the heading would just change the summary, not the item name
41 2012-06-15T01:34:57 <ThomasWaldmann> either summary or you just take it from the dom
42 2012-06-15T01:35:46 <ThomasWaldmann> i mean if it is just heading + some text, you could just take the heading + some text from the blogpost page
43 2012-06-15T01:37:01 <spy> on my screen the post "Here come the Ultrabooks" doesn't contain any headings. <h1>Here come the Ultrabooks</h1> generated in the blog template
44 2012-06-15T01:40:54 <ThomasWaldmann> well, think about how a long blog post would be structured
45 2012-06-15T01:46:56 <spy> ThomasWaldmann: let's continue tomorrow, gn
46 2012-06-15T01:47:04 <ThomasWaldmann> gn
47 2012-06-15T01:47:16 *** spy
48 2012-06-15T02:14:34 <bretonium> ThomasWaldmann: http://etherpad.osuosl.org/moin2-bms 155 please, coding that part now.
49 2012-06-15T02:27:00 *** dwcramer
50 2012-06-15T02:37:54 <bretonium> ThomasWaldmann: nah, never mind.
51 2012-06-15T03:09:23 *** Trip__
52 2012-06-15T03:11:02 *** MattMaker
53 2012-06-15T03:37:52 *** sudo_dirk1
54 2012-06-15T03:38:31 *** sudo_dirk
55 2012-06-15T03:53:06 *** xiaq-m
56 2012-06-15T03:54:47 *** dwcramer
57 2012-06-15T04:10:48 *** dwcramer
58 2012-06-15T04:35:28 *** dwcramer
59 2012-06-15T04:49:06 *** dwcramer
60 2012-06-15T05:00:15 *** xjjk
61 2012-06-15T05:02:11 <bretonium> Could someone please explain the XXX on MoinMoin/storage/backends/stores.py:200? My parser fails while trying to read it :(
62 2012-06-15T06:24:58 *** xjjk
63 2012-06-15T08:19:37 *** dwcramer
64 2012-06-15T08:31:42 <dreimark> bretonium: http://hg.moinmo.in/moin/2.0/file/3989635de0fb/MoinMoin/storage/backends/stores.py
65 2012-06-15T08:31:57 <dreimark> ther are only 172 lines in that file
66 2012-06-15T08:46:54 <bretonium> hmm, my bad. Edited it and forgot about it. 153.
67 2012-06-15T09:11:45 <dreimark> waldi: ThomasWaldmann ^
68 2012-06-15T09:12:03 <dreimark> http://hg.moinmo.in/moin/2.0/file/3989635de0fb/MoinMoin/storage/backends/stores.py#l153
69 2012-06-15T09:12:11 <dreimark> waldi: ThomasWaldmann ^
70 2012-06-15T09:12:36 <dreimark> bretonium: each number can be used to link to the line number
71 2012-06-15T09:12:53 * dreimark can't help on that part
72 2012-06-15T09:43:06 *** esyr
73 2012-06-15T09:43:18 *** esyr
74 2012-06-15T09:45:33 <bretonium> well, I parsed if (finally), but still don't quite get what's the issue. Anyway, it doesn't block me.
75 2012-06-15T10:11:00 *** Trip__
76 2012-06-15T10:35:33 <bretonium> http://codereview.appspot.com/6308075 - that old "edit a specific revid"
77 2012-06-15T10:36:09 <bretonium> http://codereview.appspot.com/6303079 - here I'll post code for storing and indexing branches and userheads
78 2012-06-15T10:54:37 <xiaq> ThomasWaldmann: hm, did you review my refactor-only patchset?
79 2012-06-15T10:54:47 <xiaq> dreimark: ^^
80 2012-06-15T10:59:58 <xiaq> one thing i noticed is that items/__init__.py and apps/frontend/views.py have circular dependencies - items/__init__.py needs CommentForm from apps/frontend/views.py
81 2012-06-15T11:00:33 <xiaq> this was worked around by deferring the import till the call to do_modify, which built ModifyForm on the fly
82 2012-06-15T11:01:18 <xiaq> but i took the approach of making ModifyForm defined directly in the class - that should have broken, but weirdly it didn't...
83 2012-06-15T11:02:17 <ThomasWaldmann> bretonium: http://hg.moinmo.in/moin/2.0/file/3989635de0fb/MoinMoin/storage/middleware/serialization.py#l69 the comment you found corresponds to that
84 2012-06-15T11:02:17 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 604:cee4ce4ee07b extensions/data/plugin/parser/bbb_create.py: bbb: show actions frame only if there are valid actions for the parser
85 2012-06-15T11:02:18 <CIA-54> Reimar Bauer <rb.proj AT googlemail DOT com> default * 605:c378af5f401b extensions/data/plugin/parser/bbb_create.py: bbb: parser shows GUEST_URL if defined in bbb_settings for a started meeting. This can be used to invite guests.
86 2012-06-15T11:03:33 <ThomasWaldmann> so the problem is fixed. the comment should stay there, but should be changed to non-XXX, just a Note: would be more appropriate as the problem is solved at another place. maybe it should be solved there, I'll have to see.
87 2012-06-15T11:06:33 <xiaq> ThomasWaldmann: moin, did you review my refactor-only patchset? http://codereview.appspot.com/6296074/ sorry to post this several times but i didn't get a clear reply from you and dreimark :(
88 2012-06-15T11:06:37 <xiaq> dreimark: ^
89 2012-06-15T11:07:21 <ThomasWaldmann> well, I said if it is still the same stuff, just arranged differently, it doesn't need review again
90 2012-06-15T11:08:17 <xiaq> ThomasWaldmann: hm, so i wonder it can possibly be merged? :)
91 2012-06-15T11:15:22 <xiaq> ThomasWaldmann: hm? if it can be merged i'll be basing the metadata editor work upon my refactored code
92 2012-06-15T11:17:12 <ThomasWaldmann> did you manually and automatically test it meanwhile?
93 2012-06-15T11:18:08 <xiaq> ThomasWaldmann: yes, no failing tests on py.test, also did manual tests
94 2012-06-15T11:18:50 <ThomasWaldmann> saved some TWiki/AnyWikiDraw also?
95 2012-06-15T11:19:19 <xiaq> ThomasWaldmann: uh, not yet - i need to get java applet working...
96 2012-06-15T11:19:46 <xiaq> ThomasWaldmann: i'll test that some moments later
97 2012-06-15T11:24:37 <dreimark> xiaq: I assumed it is the same I had already reviewed. Or is something changed?
98 2012-06-15T11:24:59 <dreimark> so after you verified saving of awd you can push it
99 2012-06-15T11:25:35 <xiaq> dreimark: there are some minor changes, mostly format and comments - i fixed a few pep8 errors
100 2012-06-15T11:26:11 <xiaq> dreimark: that said it can be merged if it works? :)
101 2012-06-15T11:26:44 <dreimark> you mean merge in to the default moin2 ?
102 2012-06-15T11:27:02 <xiaq> dreimark: yeah
103 2012-06-15T11:27:13 <dreimark> I will do a practical test too after it is in your repo
104 2012-06-15T11:27:31 <dreimark> then I guess yes, ThomasWaldmann ?
105 2012-06-15T11:28:35 * xiaq just got java applet working, haha
106 2012-06-15T11:36:58 <ThomasWaldmann> yes :)
107 2012-06-15T11:44:50 <bretonium> err, do mountpoints work now? How can I practically test them? I see that there is a UserProfile mountpoint now
108 2012-06-15T11:47:35 <bretonium> when I try to get "/UserProfile/breton", the name in storage/middleware/routing.py is simply "breton".
109 2012-06-15T11:48:11 <xiaq> aha, both anywikidraw and twikidraw work now
110 2012-06-15T11:48:21 <xiaq> did spot a bug by testing anywikidraw manually
111 2012-06-15T11:49:18 *** greg_f
112 2012-06-15T11:52:51 <ThomasWaldmann> bretonium: ignore the current way of storing userprofiles
113 2012-06-15T11:53:10 * xiaq sent pull request
114 2012-06-15T12:04:33 *** xiaq-m
115 2012-06-15T12:16:39 *** spy
116 2012-06-15T12:51:38 *** spy
117 2012-06-15T14:14:45 *** dwcramer
118 2012-06-15T14:41:56 *** dave_largo
119 2012-06-15T14:48:30 *** spy
120 2012-06-15T15:34:30 *** spy
121 2012-06-15T15:41:15 <MaikuMori> moin
122 2012-06-15T15:46:02 *** spy
123 2012-06-15T15:47:32 *** dwcramer
124 2012-06-15T15:50:39 *** spy
125 2012-06-15T15:51:27 <dreimark> hi MaikuMori
126 2012-06-15T15:53:52 *** kanha
127 2012-06-15T15:54:01 <bretonium> fellas, have you read the announcement from freenode about maintenance at 2 pm? that's right dirung our meeting
128 2012-06-15T15:54:32 *** kanha__
129 2012-06-15T15:54:48 <dreimark> 14:54 -mrmist(~mrmist@freenode/staff/pdpc.active.mrmist)- [Global Notice] - Our services upgrade is scheduled for 2PM UTC on Saturday. We expect services to be unavailable for up to an hour, so please plan your channel management accordingly. Thanks for flying freenode!
130 2012-06-15T15:57:04 <dreimark> waldi: see http://moinmo.in/GoogleSoc2012/ImproveThemes/2012-06-14 and http://moinmo.in/GoogleSoc2012/ImproveThemes/2012-06-13
131 2012-06-15T16:06:31 <xiaq> http://hg.moinmo.in/moin/2.0/file/3989635de0fb/MoinMoin/templates/forms.html#l23
132 2012-06-15T16:06:40 <xiaq> {# Use of auto_value=false below prevents flatland from appending _1
133 2012-06-15T16:06:41 <xiaq> to the input id attribute ensuring it will match the for attribute
134 2012-06-15T16:06:41 <xiaq> in the matching label above.
135 2012-06-15T16:06:41 <xiaq> #}
136 2012-06-15T16:07:07 <xiaq> input id attribute is controlled by auto_domid, not auto_value...
137 2012-06-15T16:12:34 <xiaq> seems the comment refers to an older version of Flatland?
138 2012-06-15T16:13:39 <dreimark> http://hg.moinmo.in/moin/2.0/diff/3054bf16971b/MoinMoin/templates/forms.html
139 2012-06-15T16:14:02 <dreimark> yes, can be
140 2012-06-15T16:14:14 <dreimark> roger has added that piece
141 2012-06-15T16:15:06 <jek> the comment is accurate
142 2012-06-15T16:15:49 <dreimark> xiaq: ^
143 2012-06-15T16:16:03 <jek> it may be more to the point to say that auto_value=false prevents the value from being suffixed to the generated id
144 2012-06-15T16:16:12 <jek> value happening to be '1' in this case
145 2012-06-15T16:18:44 <xiaq> oh but the issue only applies to radio box, where there are multiple tags generated for a single Flatland element
146 2012-06-15T16:20:57 <xiaq> and setting auto_value doesn't seem the correct thing to do...
147 2012-06-15T16:24:10 * dreimark creating an anywikidraw object takes ages
148 2012-06-15T16:25:07 <xiaq> dreimark: ah it actually hanged on my linux box, i tested in a windows VM...
149 2012-06-15T16:25:26 <dreimark> it worked on linux before too
150 2012-06-15T16:25:51 *** dwcramer
151 2012-06-15T16:25:59 <xiaq> dreimark: you are testing my patch?
152 2012-06-15T16:26:23 <dreimark> yes, clone of your repo - now going to look on main+
153 2012-06-15T16:28:15 <xiaq> dreimark: what is main+?
154 2012-06-15T16:28:28 <dreimark> main repo the + was a typo
155 2012-06-15T16:28:56 <xiaq> ok
156 2012-06-15T16:40:46 <dreimark> xiaq: what do you download if you have an svgdraw image?
157 2012-06-15T16:41:01 <dreimark> main does the tar ball
158 2012-06-15T16:42:09 <dreimark> ok, works, ignore
159 2012-06-15T16:49:12 <dreimark> xiaq: http://dpaste.com/760005/
160 2012-06-15T16:49:18 <dreimark> chromium browser
161 2012-06-15T16:49:30 <dreimark> and linux
162 2012-06-15T16:49:33 <xiaq> dreimark: uh oh
163 2012-06-15T16:50:52 <xiaq> dreimark: java crashes when i test twd on chromium, archlinux :)
164 2012-06-15T16:50:57 <dreimark> but I have that also in main
165 2012-06-15T16:51:43 <xiaq> dreimark: yeah, the stack trace points to none of the codes i touched in my patch
166 2012-06-15T16:53:10 <dreimark> yeah
167 2012-06-15T16:54:20 <dreimark> it may be also a problem in chrome
168 2012-06-15T16:54:34 <dreimark> I don't get currently ff with java working
169 2012-06-15T16:56:33 *** spy
170 2012-06-15T16:57:14 <xiaq> dreimark: ah, did you get a crash when showing the item or doing modify?
171 2012-06-15T16:57:28 <dreimark> xiaq: can you verify the moinmo.in WikiSandbox with linux too
172 2012-06-15T16:57:38 <dreimark> there is a twdraw and anywikidraw page
173 2012-06-15T16:57:46 <dreimark> s/page/item
174 2012-06-15T16:58:10 <dreimark> both work for me
175 2012-06-15T16:59:01 <dreimark> the first one is twd the second awd
176 2012-06-15T16:59:18 <dreimark> we do something very wrong currently if it works there
177 2012-06-15T17:00:34 <xiaq> http://test.moinmo.in/twd doesn't exist
178 2012-06-15T17:01:37 <xiaq> just created it :)
179 2012-06-15T17:02:07 *** dwcramer
180 2012-06-15T17:03:52 *** dwcramer
181 2012-06-15T17:04:30 <xiaq> they all (either of twdraw and anywikidraw, either of test.moinmo.in and my local site) work on my machine with Firefox + icedtea-web-java7 on Archlinux
182 2012-06-15T17:06:21 <xiaq> seems they used to hang, but all work well ATM...
183 2012-06-15T17:32:43 <dreimark> xiaq: it works on 1.9
184 2012-06-15T17:33:03 <xiaq> dreimark: is the java applets of the same version?
185 2012-06-15T17:33:09 <xiaq> also, regarding http://hg.moinmo.in/moin/2.0/diff/3054bf16971b/MoinMoin/templates/forms.html
186 2012-06-15T17:33:11 <dreimark> yes
187 2012-06-15T17:33:18 <xiaq> what's wrong with the original implementation?
188 2012-06-15T17:33:38 <xiaq> putting auto_value=False to get id's right is not worthwhile imo
189 2012-06-15T17:34:03 <dreimark> file a new issue for the id thing
190 2012-06-15T17:35:28 <xiaq> dreimark: uh, i wonder what's the rationale for that changeset? the old way (handle checkboxes specially) looks perfect to me
191 2012-06-15T17:36:33 <xiaq> RogerHaase is not here...
192 2012-06-15T17:36:48 <dreimark> he is in the US TZ
193 2012-06-15T17:41:31 <xiaq> issue created https://bitbucket.org/thomaswaldmann/moin-2.0/issue/199
194 2012-06-15T19:22:55 *** dwcramer
195 2012-06-15T19:23:32 *** greg_f
196 2012-06-15T19:40:27 *** MattMaker
197 2012-06-15T20:09:32 *** dwcramer
198 2012-06-15T21:07:47 *** MattMaker
199 2012-06-15T21:19:46 *** RogerHaase
200 2012-06-15T21:29:46 <spy> ThomasWaldmann: http://etherpad.osuosl.org/moin-blog 81, 114 please
201 2012-06-15T21:44:44 *** brunomartin
202 2012-06-15T21:46:02 *** MattMaker
203 2012-06-15T21:48:13 *** MattMaker
204 2012-06-15T22:18:07 *** MattMaker
205 2012-06-15T22:21:20 *** MattMaker
206 2012-06-15T22:28:40 *** Trip__
207 2012-06-15T22:29:24 *** MattMaker
208 2012-06-15T22:35:43 *** dwcramer
209 2012-06-15T22:40:46 *** Trip__
210 2012-06-15T22:40:53 *** MattMaker
211 2012-06-15T22:50:02 *** dwcramer
212 2012-06-15T23:02:59 *** MattMaker
213 2012-06-15T23:07:10 *** MattMaker
214 2012-06-15T23:12:48 *** dwcramer
215 2012-06-15T23:20:03 *** dave_largo
216 2012-06-15T23:28:15 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5865:dc3c0b894178 1.9/MoinMoin/action/SpellCheck.py: fix dictionary file reading crash under windows
217 2012-06-15T23:45:29 <RogerHaase> xiaq: jek: dreimark: ThomasWaldmann: should we revert to Julian Brost's way of fixing the checkbox ID problem: http://codereview.appspot.com/6305099/
