1 2012-08-05T00:16:03 <RogerHaase> ThomasWaldmann: works OK.
2 2012-08-05T00:17:48 <RogerHaase> I will add it to tomorrows CR. Still working on global review of that moin_page.body... stuff
3 2012-08-05T00:17:50 <RogerHaase> gtg
4 2012-08-05T00:18:04 *** RogerHaase
5 2012-08-05T01:57:01 *** MattMaker
6 2012-08-05T02:42:35 *** dcramer__
7 2012-08-05T02:57:54 *** dcramer__
8 2012-08-05T03:05:10 *** MattMaker
9 2012-08-05T03:09:32 *** MattMaker
10 2012-08-05T03:12:47 *** MattMaker
11 2012-08-05T03:24:02 *** MattMaker
12 2012-08-05T03:24:21 *** MattMaker
13 2012-08-05T04:44:23 * xiaq merged, no conflict
14 2012-08-05T04:57:12 <xiaq> so can i carry out the template rename (http://codereview.appspot.com/6450075/) now?
15 2012-08-05T04:57:35 <xiaq> or wait until jaiditya has done other things
16 2012-08-05T06:52:19 *** eSyr-ng
17 2012-08-05T06:52:37 *** eSyr-ng
18 2012-08-05T08:48:31 <xiaq> jaiditya: the themes looks so good!!!
19 2012-08-05T08:49:02 <dreimark> xiaq: if it fits to merged main
20 2012-08-05T08:49:52 <xiaq> dreimark: hm? i've already merged on my local repo
21 2012-08-05T08:50:01 <dreimark> i meant the cr
22 2012-08-05T08:50:40 <xiaq> dreimark: ah, what has been merged already looks great :)
23 2012-08-05T08:50:52 <dreimark> ok
24 2012-08-05T08:51:31 <dreimark> xiaq: spy_ when is your meeting ?
25 2012-08-05T08:51:47 <xiaq> dreimark: in 10min i suppose
26 2012-08-05T09:03:33 <spy_> moin
27 2012-08-05T09:03:40 <xiaq> spy_: moin
28 2012-08-05T09:05:25 * spy_ looks at xiaq's last metaeditor patchsets
29 2012-08-05T09:05:43 <xiaq> spy_: which is http://codereview.appspot.com/6448075/ (just to be sure)
30 2012-08-05T09:06:00 <spy_> yes
31 2012-08-05T09:06:07 <xiaq> spy_: and the comments i left on your cr http://codereview.appspot.com/6447057/
32 2012-08-05T09:15:36 <spy_> xiaq: okay, I like your idea to keep MetaForm (or even MetaSchema) as simple as possible. But on the other hand I have introduced two special forms for Blog and BlogEntry http://codereview.appspot.com/6356070/diff/42002/MoinMoin/forms.py
33 2012-08-05T09:15:58 <spy_> they have different _load and _dump behaviour
34 2012-08-05T09:16:02 * xiaq looks
35 2012-08-05T09:16:08 <spy_> not different rather extended
36 2012-08-05T09:17:25 <spy_> blog entry could be MoinWiki or Creole or even Binary image
37 2012-08-05T09:17:29 <xiaq> ah, ptime
38 2012-08-05T09:17:45 <xiaq> different storage and html representations. am i right?
39 2012-08-05T09:20:01 <xiaq> Tags already has this problem. see http://codereview.appspot.com/6448075/diff/10001/MoinMoin/items/__init__.py right hand side line 320
40 2012-08-05T09:20:13 <spy_> not sure. They just add some keys to the BaseMeta and declare methods how to update those keys
41 2012-08-05T09:20:49 <spy_> xiaq: exactly, just looked at that too :)
42 2012-08-05T09:23:31 <spy_> that is why I moved that functionality to the MetaForms, But now we have itemtype classes where I suppose we have to define appropriate MetaForms. Could we solve it this way?
43 2012-08-05T09:26:00 <xiaq> spy_: hm my idea is that ModifyForm and MetaForm are coupled anyway (you change them when defining an itemtype), so it doesn't matter if you put some metadata patching code in the ModifyForm._dump and ._load...
44 2012-08-05T09:26:26 <xiaq> spy_: i think the problem is better solved in the widget,
45 2012-08-05T09:26:50 <xiaq> ie. subclassing DateTime and add the behavior to it instead in the metadata form
46 2012-08-05T09:27:53 <xiaq> i haven't found a Flatland mechanism for that, but if it doesn't we can somehow hack it
47 2012-08-05T09:28:34 <xiaq> eg. for loading and dumping of metadata form, check if the widget class has _load and _dump methods before falling back to `set` method for loading and `value` property for dumping
48 2012-08-05T09:29:24 <dreimark> jek: ^^
49 2012-08-05T09:30:23 <xiaq> dreimark: ah, thanks for reminding me.
50 2012-08-05T09:30:45 <xiaq> jek: the problem is that we want different "internal" and "html" representations for an element
51 2012-08-05T09:30:54 <xiaq> take JoinedString for example.
52 2012-08-05T09:32:57 <xiaq> >>> from flatland import *
53 2012-08-05T09:33:04 <xiaq> >>> import re
54 2012-08-05T09:33:04 <xiaq> >>> Tags = JoinedString.of(String).using(separator=', ', separator_regex=re.compile(r'\s*,\s*'))
55 2012-08-05T09:33:07 <xiaq> >>> t = Tags(['lorem', 'ipsum'])
56 2012-08-05T09:33:09 <xiaq> >>> t.value
57 2012-08-05T09:33:12 <xiaq> u'lorem, ipsum'
58 2012-08-05T09:33:27 <xiaq> what if i wish t.value is ['lorem', 'ipsum'] ?
59 2012-08-05T09:37:49 <xiaq> spy_: how do you like the idea of putting non-trivial load/dump codes to the widget instead?
60 2012-08-05T09:45:34 <dreimark> in your example you have the list on t -> t[0].value, t[1].value
61 2012-08-05T09:46:30 <xiaq> dreimark: of course it is possible, but
62 2012-08-05T09:46:49 <xiaq> form.value is assembled from .value properties of its children
63 2012-08-05T09:47:37 <xiaq> hm, seems subclassing JoinedString and overridding .value getter is not a bad choice
64 2012-08-05T09:48:34 <xiaq> (at the same time care should be taken to preserve the behavior of .u getter since elem.u is used to generate html)
65 2012-08-05T09:57:50 <dreimark> spy_: still with us?
66 2012-08-05T10:03:19 <spy_> xiaq: good idea, how it could be applied in ModifyForm? Iterate through all attrs(widgets) of MetaForm and call there _load/_dump?
67 2012-08-05T10:05:34 <spy_> ah, okay, we there is 09:46 < xiaq> form.value is assembled from .value properties of its children
68 2012-08-05T10:05:45 <spy_> oh, sorry :)
69 2012-08-05T10:06:23 <xiaq> spy_: subclassing flatland element and overriding set() method & value property seems the way to go
70 2012-08-05T10:07:11 <spy_> there is field_schema_mapping.keys() method to get all elements of form, right?
71 2012-08-05T10:08:17 <xiaq> spy_: yes, but instead of _dump and _load i think overriding set() and value property is better
72 2012-08-05T10:08:54 *** grzywacz
73 2012-08-05T10:10:42 <spy_> xiaq: yeah, this way it seems we don't even have to explicitly call set() on each element. Just set on form
74 2012-08-05T10:12:38 * xiaq working on a better Tags implementation
75 2012-08-05T10:14:23 <spy_> xiaq: there are also different meta_template constants for MetaForms
76 2012-08-05T10:15:10 <xiaq> spy_: i put it in ModifyForm :)
77 2012-08-05T10:15:38 <spy_> I see
78 2012-08-05T10:16:55 <spy_> but blog entry has its own meta_template and it is not associated with the ModifyForm
79 2012-08-05T10:17:18 <xiaq> spy_: override ModifyForm class then?
80 2012-08-05T10:21:27 * spy_ looks
81 2012-08-05T10:22:39 * xiaq never remembers the argument order of super()...
82 2012-08-05T10:32:17 <spy_> xiaq: like this? class Blog(Contentful): class _ModifyForm(Contentful._ModifyForm): meta_form = "..."
83 2012-08-05T10:33:35 <xiaq> spy_: yes :)
84 2012-08-05T10:33:53 <spy_> hm, okay :)
85 2012-08-05T10:39:02 <spy_> xiaq: I want to have the same do_modify method as the Default(Contentful) has except itemtype=u'blog', but there is hardcoded itemtype=u'default'.
86 2012-08-05T10:39:13 <spy_> how did you plan to do so
87 2012-08-05T10:39:15 <spy_> ?
88 2012-08-05T10:39:41 <xiaq> spy_: make itemtype a class property
89 2012-08-05T10:40:52 <xiaq> spy_: i already have that in my local repo, will publish the change soon
90 2012-08-05T10:45:12 <xiaq> overriding value property works for Tags, will send to cr soon
91 2012-08-05T10:45:23 <xiaq> spy_: the same can be done for ptime i suppose
92 2012-08-05T10:47:40 <spy_> xiaq: now you don't have an explicit set() call for tags, right?
93 2012-08-05T10:48:34 <xiaq> spy_: yes it's not needed since JoinedString accepts list as well as string
94 2012-08-05T10:52:49 *** jaiditya
95 2012-08-05T10:59:16 <spy_> xiaq: looking forward for you cr, then I will try to implement ptime the same way
96 2012-08-05T11:02:39 <spy_> xiaq: could we merge some work on itemtypes to work on it together? Or is it almost ready?
97 2012-08-05T11:03:27 <xiaq> spy_: mine is ready to be merged if you don't mind rebasing your work on my version :)
98 2012-08-05T11:08:55 <dreimark> xiaq: may be show the url again ^
99 2012-08-05T11:09:28 <xiaq> dreimark: ah, i just updated it. http://codereview.appspot.com/6448075/
100 2012-08-05T11:09:30 <xiaq> spy_: ^
101 2012-08-05T11:11:58 <xiaq> ThomasWaldmann: ^
102 2012-08-05T11:15:39 * xiaq is going out, be back in ~1.5h
103 2012-08-05T11:44:33 <dreimark> spy_: everything there you need?
104 2012-08-05T12:17:45 <spy_> xiaq: looks nice. Feel free to merge your changes as soon as possible. I don't have too much to rebase, rather I wait for your permanent changes finished to implement my itemtype classes.
105 2012-08-05T12:19:16 <spy_> dreimark: suppose yes
106 2012-08-05T12:23:14 <dreimark> spy_: btw i have added a fr for search to https://bitbucket.org/thomaswaldmann/moin-2.0/issue/236/search-bar-with-more-selections
107 2012-08-05T12:23:28 <dreimark> i like the codrops solution
108 2012-08-05T12:23:50 <dreimark> and awaits jaiditya joining
109 2012-08-05T12:27:00 <dreimark> bbl
110 2012-08-05T12:47:06 *** dcramer__
111 2012-08-05T12:55:38 <ThomasWaldmann> moin
112 2012-08-05T12:55:45 * ThomasWaldmann looks at http://codereview.appspot.com/6448075/
113 2012-08-05T13:08:40 <ThomasWaldmann> done
114 2012-08-05T13:09:15 <ThomasWaldmann> xiaq: btw, i am seeing some exceptions after merge
115 2012-08-05T13:09:47 <ThomasWaldmann> not sure when they crept in
116 2012-08-05T13:10:06 <ThomasWaldmann> Traceback (most recent call last):
117 2012-08-05T13:10:06 <ThomasWaldmann> File "/home/tw/w/moin-2.0/MoinMoin/apps/feed/views.py", line 78, in atom
118 2012-08-05T13:10:06 <ThomasWaldmann> content = hl_item._render_data_diff_atom(previous_rev, this_rev)
119 2012-08-05T13:10:06 <ThomasWaldmann> AttributeError: 'Default' object has no attribute '_render_data_diff_atom'
120 2012-08-05T13:10:10 <ThomasWaldmann> and
121 2012-08-05T13:10:21 <ThomasWaldmann> Traceback (most recent call last):
122 2012-08-05T13:10:21 <ThomasWaldmann> File "/home/tw/w/moin-2.0/MoinMoin/apps/feed/views.py", line 81, in atom
123 2012-08-05T13:10:21 <ThomasWaldmann> content = render_template('atom.html', get='first_revision', rev=this_rev, content=Markup(hl_item._render_data()), revision=this_revid)
124 2012-08-05T13:10:24 <ThomasWaldmann> AttributeError: 'Default' object has no attribute '_render_data'
125 2012-08-05T13:10:53 *** dcramer__
126 2012-08-05T13:14:39 <ThomasWaldmann> (both seems to be a firefox life bookmark, so it grabs that automatically now and then)
127 2012-08-05T13:28:16 *** dcramer__
128 2012-08-05T14:10:55 <xiaq> ThomasWaldmann: oh, my bad. i didn't check feed views when restructing Item. going to fix that.
129 2012-08-05T14:11:18 <xiaq> ThomasWaldmann: btw, cr replied
130 2012-08-05T14:21:27 <ThomasWaldmann> xiaq: so it makes sure at another place that wikiname metadata key is set to the correct value?
131 2012-08-05T14:23:16 <xiaq> ThomasWaldmann: no, why is that needed?
132 2012-08-05T14:46:31 <ThomasWaldmann> well, if you run multiple wikis, each one has a unique name. and of course you need to know to which one some item belongs
133 2012-08-05T14:46:58 <ThomasWaldmann> but i suspect it uses app.cfg.wikiname somewhere to make that sure.
134 2012-08-05T14:47:54 <xiaq> ThomasWaldmann: yeah. i wonder how is it filled when there is no metadata editor?
135 2012-08-05T14:50:33 <xiaq> md editor shouldn't have altered that
136 2012-08-05T14:57:43 <xiaq> ThomasWaldmann: oh, my bad... wikiname has the same problem with acl. it should be filled with app.cfg.interwikiname when creating a new item...
137 2012-08-05T14:58:51 <xiaq> hm, where is the default acl defined?
138 2012-08-05T15:00:38 <xiaq> seems the "default acl" is just "no acl", which has different semantics with "emtpy acl". am i right?
139 2012-08-05T15:02:52 <xiaq> if so then there is a problem here...
140 2012-08-05T15:04:22 <ThomasWaldmann> yes, no acl means default acl being used
141 2012-08-05T15:04:36 <ThomasWaldmann> empty acl means to override default acl with nothing
142 2012-08-05T15:05:04 <xiaq> ThomasWaldmann: i can fix wikiname, but acl would require some thinking...
143 2012-08-05T15:05:55 <ThomasWaldmann> xiaq: do you require 233 to be fixed for issue tracker?
144 2012-08-05T15:07:08 <xiaq> ThomasWaldmann: just reporting the problem. i'm doing some changes on index code which will fix that
145 2012-08-05T15:11:08 <xiaq> ThomasWaldmann: wikiname fixed. http://codereview.appspot.com/6448075/
146 2012-08-05T15:11:54 <xiaq> ThomasWaldmann: ps. itemtype should be fixed too but is not yet. it requires a change in DummyRev signature and i do that in another changeset
147 2012-08-05T15:15:32 <ThomasWaldmann> (if not required, i wanted to suggest you don't fix it, if you didn't do it already, but rather concentrate on your project)
148 2012-08-05T15:18:54 <xiaq> ThomasWaldmann: ok, but i mean it will be fixed as i implement rich index as some of the code will be rewritten
149 2012-08-05T15:23:58 <ThomasWaldmann> ok
150 2012-08-05T15:24:49 <xiaq> ThomasWaldmann: do you think the md editor patch set is ready to be merged?
151 2012-08-05T15:24:58 <xiaq> ThomasWaldmann: spy_ is waiting for that too :)
152 2012-08-05T15:27:53 <ThomasWaldmann> xiaq: i didn't try it, but assume you practically did test it.
153 2012-08-05T15:28:11 <ThomasWaldmann> so, if there are no obvious bugs or regressions, yes.
154 2012-08-05T15:28:51 <ThomasWaldmann> do we have widget bases editor AND json field now at the same time?
155 2012-08-05T15:28:56 <ThomasWaldmann> based*
156 2012-08-05T15:30:14 <xiaq> ThomasWaldmann: json field is used for extra unknown keys
157 2012-08-05T15:43:23 * xiaq is fixing a failing test due to DummyRev containing default wikiname
158 2012-08-05T15:47:20 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6448075/ test case fixed.
159 2012-08-05T15:55:30 <ThomasWaldmann> xiaq: was it behaving differently for nonexisting rev than existing (like first not having wikiname, but second having?)?
160 2012-08-05T15:58:32 <ThomasWaldmann> xiaq: hmm, don't we overwrite wikiname on POST anyway with whatever we KNOW is the correct wikiname?
161 2012-08-05T15:58:41 <ThomasWaldmann> brb
162 2012-08-05T16:05:26 <xiaq> ThomasWaldmann: i did a test and seems it doesn't...
163 2012-08-05T16:10:26 <xiaq> ah yes it does, but only when wikiname is not defined...
164 2012-08-05T16:19:44 <ThomasWaldmann> that override needs to stay in place (same as for ip addr, user id, ... where we know better than the user)
165 2012-08-05T16:21:07 *** grzywacz
166 2012-08-05T16:21:55 <xiaq> ThomasWaldmann: remove wikiname from md editor then?
167 2012-08-05T16:23:12 <ThomasWaldmann> hmm, yes, maybe better
168 2012-08-05T16:23:33 <ThomasWaldmann> same as old ip addr from previous rev
169 2012-08-05T16:31:57 * xiaq on phone, be back later...
170 2012-08-05T17:10:37 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1618:57b4e55756e1 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme bottom border to moin-flash
171 2012-08-05T17:10:40 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1619:368827dd1a4c 2.0/MoinMoin/themes/modernized/static/css/ (common.css stylus/main.styl): Modernized theme interwiki color changed
172 2012-08-05T17:10:41 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1620:3df48de47789 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme history table width correction
173 2012-08-05T17:10:43 <CIA-54> Jaiditya Mathur <jaiditya.mathur@gmail.com> default * 1621:c56dafa3849b 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl): Foobar theme sep alighment corrected in header
174 2012-08-05T17:10:44 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1622:b1c825b2267a 2.0/MoinMoin/themes/ (4 files in 4 dirs): merged
175 2012-08-05T17:23:25 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1623:1e67974bee6e 2.0/MoinMoin/ (4 files in 4 dirs): remove simplejson fallback, json is included since python 2.6 (which we require)
176 2012-08-05T17:24:42 <ThomasWaldmann> xiaq: spy_: ^ please merge and in case you have additional such imports, treat them in the same way
177 2012-08-05T17:34:15 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6448075/ wikiname disabled...
178 2012-08-05T17:48:50 * ThomasWaldmann looks
179 2012-08-05T17:50:43 <xiaq> ThomasWaldmann: i wonder when and how can a user create an item with wikiname different from app.cfg.interwikiname?
180 2012-08-05T17:56:33 <ThomasWaldmann> there should be no way
181 2012-08-05T17:56:53 <xiaq> ThomasWaldmann: ah ok :)
182 2012-08-05T17:59:41 <xiaq> ThomasWaldmann: wikiname removed: http://codereview.appspot.com/6448075/
183 2012-08-05T18:01:23 <ThomasWaldmann> xiaq: do you think there is anything older than 1. august that still needs review/comments from me?
184 2012-08-05T18:01:40 * ThomasWaldmann is currently cleaning up email inbox
185 2012-08-05T18:02:00 <xiaq> nope
186 2012-08-05T18:14:50 <xiaq> ThomasWaldmann: pull request sent
187 2012-08-05T18:24:23 <ThomasWaldmann> xiaq: make test was without issues?
188 2012-08-05T18:26:57 <ThomasWaldmann> 'duck'?
189 2012-08-05T18:27:10 <xiaq> ThomasWaldmann: yup, without issue
190 2012-08-05T18:27:48 <xiaq> ThomasWaldmann: there can be more meta keys in meta than in the form
191 2012-08-05T18:28:29 <ThomasWaldmann> so why do we have a duck there? :)
192 2012-08-05T18:29:13 <xiaq> ThomasWaldmann: ask jek :) he called the option 'duck'. otherwise exception is thrown when a key not present in meta_form is encountered
193 2012-08-05T18:29:18 * xiaq added a comment to that
194 2012-08-05T18:29:36 <ThomasWaldmann> ah, THAT duck :D
195 2012-08-05T18:29:48 * ThomasWaldmann remembers using that
196 2012-08-05T18:29:58 <xiaq> ThomasWaldmann: hm is a comment necessary?
197 2012-08-05T18:30:40 <ThomasWaldmann> yes
198 2012-08-05T18:37:17 * xiaq is experimenting with the wording of the comment...
199 2012-08-05T18:39:57 <xiaq> # Default value of `policy` argument of Flatland.Dict.set's is
200 2012-08-05T18:39:57 <xiaq> # 'strict', which causes KeyError to be thrown when meta contains
201 2012-08-05T18:39:57 <xiaq> # meta keys that are not present in self['meta_form']. Setting
202 2012-08-05T18:39:57 <xiaq> # policy to 'duck' suppresses this behavior.
203 2012-08-05T18:39:57 <xiaq> self['meta_form'].set(meta, policy='duck')
204 2012-08-05T18:40:12 <xiaq> (i also changed the call to use kwarg)
205 2012-08-05T18:40:46 <xiaq> ThomasWaldmann: ^
206 2012-08-05T18:43:17 <ThomasWaldmann> ok
207 2012-08-05T18:48:21 <ThomasWaldmann> MaikuMori: about theme plugins, please see there: https://bitbucket.org/leafstorm/flask-themes/pull-request/1/potential-fix-for-issues-with-flask-08
208 2012-08-05T18:48:58 <xiaq> ThomasWaldmann: pull request updated
209 2012-08-05T18:49:12 <ThomasWaldmann> (the comment from matthew might be useful as you based your code on the stuff he rejected)
210 2012-08-05T18:52:47 <ThomasWaldmann> xiaq: playing with that code... :)
211 2012-08-05T18:54:34 <ThomasWaldmann> hmm, i can't create an item, UI loop
212 2012-08-05T18:54:47 <dreimark> re
213 2012-08-05T18:54:55 <ThomasWaldmann> (as reimar reported recently, but i could not reproduce back then)
214 2012-08-05T18:54:56 <dreimark> ThomasWaldmann: i guess that is what i also had
215 2012-08-05T18:55:02 <ThomasWaldmann> yeah
216 2012-08-05T18:55:25 <dreimark> i have not found how i should make a testcase for it
217 2012-08-05T18:55:53 <ThomasWaldmann> after "create from scratch", i do not get editor, but it asks for Default/Ticket again
218 2012-08-05T18:56:20 <dreimark> was the same here yesterday
219 2012-08-05T18:56:54 <ThomasWaldmann> it is likely because the create from scratch link is missing the itemtype url arg
220 2012-08-05T18:56:58 <ThomasWaldmann> xiaq: ^
221 2012-08-05T18:57:40 <xiaq> ThomasWaldmann: it's ok here...
222 2012-08-05T18:57:57 <dreimark> xiaq: it takes some item creation
223 2012-08-05T18:58:30 <xiaq> ah i got this too :)
224 2012-08-05T18:58:32 <ThomasWaldmann> oh, and if i add itemtype=default, it blows up with a traceback
225 2012-08-05T18:59:34 <xiaq> ThomasWaldmann: oh are you using foobar?
226 2012-08-05T19:00:26 <ThomasWaldmann> yes
227 2012-08-05T19:01:07 <xiaq> ThomasWaldmann: modernized works. seems foobar wasn't completely fixed...
228 2012-08-05T19:01:17 <ThomasWaldmann> exactly.
229 2012-08-05T19:01:21 <dreimark> yes
230 2012-08-05T19:01:42 <dreimark> but why is that different in both themes?
231 2012-08-05T19:02:03 <ThomasWaldmann> likely because the from scratch link is generated in the template
232 2012-08-05T19:02:25 <xiaq> ThomasWaldmann: yes
233 2012-08-05T19:02:32 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1624:c6974ba2e2b2 2.0/MoinMoin/ (3 files in 2 dirs): Widget-based metadata editor.
234 2012-08-05T19:02:33 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1625:6748d609a242 2.0/MoinMoin/ (forms.py items/__init__.py): forms.py: Create JSON widget
235 2012-08-05T19:02:34 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1626:346c52c9c1e5 2.0/MoinMoin/ (forms.py items/__init__.py):
236 2012-08-05T19:02:34 <CIA-54> Fixes to forms.py and items/__init__.py
237 2012-08-05T19:02:34 <CIA-54> forms.py: Add a missing `import json`; add spy's comment on the `except:` in ValidJSON.validate;
238 2012-08-05T19:02:34 <CIA-54> items/__init__.py: Add a missing empty line.
239 2012-08-05T19:02:35 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1627:b0b73fe90f3d 2.0/MoinMoin/ (items/__init__.py templates/modify_meta.html): Remove wikiname, disable ACL in metadata editor
240 2012-08-05T19:02:35 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1628:95161306ec62 2.0/MoinMoin/ (forms.py items/__init__.py):
241 2012-08-05T19:02:36 <CIA-54> Improve Tags implementation, eliminating tags property fiddling in
242 2012-08-05T19:02:36 <CIA-54> _ModifyForm._dump
243 2012-08-05T19:02:37 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1629:8b7a85055643 2.0/ (114 files in 17 dirs): merged
244 2012-08-05T19:02:37 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1630:24c1a4b29c86 2.0/MoinMoin/items/__init__.py: items/__init__.py: comment policy='duck' argument passed to Flatland.Dict.set
245 2012-08-05T19:02:38 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1631:c1eb8d519084 2.0/MoinMoin/ (4 files in 3 dirs): merged
246 2012-08-05T19:03:19 <xiaq> dreimark: because there are modify_select_template.html in both templates/ and themes/foobar/templates, and they become inconsistent. i have talked about the issue with jaidatya
247 2012-08-05T19:04:01 <xiaq> hopefully we'll see that resolved soon - jaidatya has already removed some duplication
248 2012-08-05T19:04:41 * xiaq goes to bed, gn :)
249 2012-08-05T19:05:51 <dreimark> g
250 2012-08-05T19:05:55 <dreimark> gn
251 2012-08-05T19:06:51 <ThomasWaldmann> gn xiaq
252 2012-08-05T21:01:45 *** grzywacz
253 2012-08-05T21:01:45 *** grzywacz
254 2012-08-05T21:15:05 *** grzywacz
255 2012-08-05T23:11:37 <dreimark> re
256 2012-08-05T23:59:29 <dreimark> gn
