MoinMoin: MoinMoinChat/Logs/moin-dev/2012-08-16

   1 2012-08-16T00:02:12  *** dwcramer has quit IRC
   2 2012-08-16T01:19:31  *** dwcramer has joined #moin-dev
   3 2012-08-16T01:24:53  *** RogerHaase has left #moin-dev
   4 2012-08-16T02:44:59  *** jaiditya has quit IRC
   5 2012-08-16T03:03:34  *** dwcramer has quit IRC
   6 2012-08-16T03:28:16  *** dwcramer has joined #moin-dev
   7 2012-08-16T03:40:08  <xiaq> hm, perhaps it's time to review my index cleanup code: http://codereview.appspot.com/6457091/
   8 2012-08-16T03:40:32  <xiaq> dreimark: ^
   9 2012-08-16T03:40:33  <xiaq> ThomasWaldmann: ^
  10 2012-08-16T03:40:35  <xiaq> spy: ^
  11 2012-08-16T04:37:55  *** MattMaker has quit IRC
  12 2012-08-16T07:26:48  *** MattMaker has joined #moin-dev
  13 2012-08-16T07:29:46  *** yufra has joined #moin-dev
  14 2012-08-16T07:30:56  *** yufra_ has quit IRC
  15 2012-08-16T07:32:05  *** Trip_ has joined #moin-dev
  16 2012-08-16T07:32:06  *** MattMaker has quit IRC
  17 2012-08-16T07:46:08  *** dwcramer has quit IRC
  18 2012-08-16T08:08:57  *** Trip_ has quit IRC
  19 2012-08-16T08:12:17  *** MattMaker has joined #moin-dev
  20 2012-08-16T10:29:00  <ThomasWaldmann> moin
  21 2012-08-16T10:29:04  <ThomasWaldmann> xiaq: review done
  22 2012-08-16T10:31:19  <spy> ThomasWaldmann: sent new updated request
  23 2012-08-16T10:31:48  <spy> ThomasWaldmann: you can't reject #75 too, right?
  24 2012-08-16T10:35:15  <ThomasWaldmann> bitbucket seems a bit broken recently...
  25 2012-08-16T10:37:06  <ThomasWaldmann> no, rejecting 75 just gives a neverending dialogue box...
  26 2012-08-16T10:38:19  <spy> :(
  27 2012-08-16T10:42:00  * ThomasWaldmann pulled
  28 2012-08-16T10:43:29  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1688:f676a325b974 2.0/MoinMoin/templates/blog_layout.html: Add the itemviews panel for blog and blog entry items.
  29 2012-08-16T10:43:30  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1689:f77870dd132f 2.0/MoinMoin/ (forms.py items/__init__.py): Preload PTIME widget with the current datetime.
  30 2012-08-16T10:43:31  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1690:2601f623bdeb 2.0/MoinMoin/items/__init__.py: Fix wrong indentation.
  31 2012-08-16T10:43:31  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1691:28cb88fcc4dd 2.0/MoinMoin/items/ (__init__.py blog.py): Move Blog item implementation to a separate blog.py module.
  32 2012-08-16T10:43:32  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1692:83a10b0c5067 2.0/MoinMoin/items/blog.py: Fix missed includes.
  33 2012-08-16T10:43:33  <CIA-65> Pavel Sviderski <pavel@psviderski.name> default * 1693:0d37d08e56de 2.0/MoinMoin/ (4 files in 3 dirs): merged
  34 2012-08-16T10:44:47  <spy> ThomasWaldmann: in #220 PTIME vs ACL rights issue you wrote that AccessDenied exception could be the filter criterion. There are user.may.read/write methods to check permissions. Are there any other methods to work with acl internally?
  35 2012-08-16T10:50:24  <ThomasWaldmann> these are the most used functions
  36 2012-08-16T10:52:28  <ThomasWaldmann> and regarding ptime, you just need u.may.read or u.may.weakread (depends on how the weak read right will be defined then)
  37 2012-08-16T10:53:43  <spy> yeah, that's right. I just think about the current blog listing filtering.
  38 2012-08-16T10:53:56  <spy> some posts may have unaccessable right
  39 2012-08-16T10:55:14  <spy> unfortunately whoosh doesn't provide the possibility to feed non-whoosh function to filter documents.
  40 2012-08-16T10:55:51  <spy> so it leads to manually do filter after whoosh query
  41 2012-08-16T10:59:20  <spy> the following arising problem is pagination. We can't use whoosh pagination because number of displayed documents depends on ACL.
  42 2012-08-16T11:01:48  <ThomasWaldmann> just forget pagination
  43 2012-08-16T11:02:21  <ThomasWaldmann> we (in general, not in your case) had that problem multiple times yet without a good solution
  44 2012-08-16T11:02:56  <ThomasWaldmann> so for now i think we just don't do it
  45 2012-08-16T11:05:09  <ThomasWaldmann> btw, i posted the pull request issues to #bitbucket, but no reply yet
  46 2012-08-16T11:05:48  <ThomasWaldmann> brb
  47 2012-08-16T11:08:26  <spy> ThomasWaldmann: okay
  48 2012-08-16T11:09:02  <dreimark> spy: jaiditya works on a vertical slider implementation
  49 2012-08-16T11:14:24  <spy> dreimark: what is it?
  50 2012-08-16T11:15:07  <dreimark> similiar to gmail
  51 2012-08-16T11:15:21  <dreimark> where you can scroll the innercontent
  52 2012-08-16T11:16:18  <spy> i see, but there is a pagination there
  53 2012-08-16T11:17:59  <spy> of course it is not reasonable to send all documents to user and show only desired ones
  54 2012-08-16T11:18:43  <spy> there should be possibility to request e.g. 51-100
  55 2012-08-16T11:20:43  <spy> i mean the server side should provide such a functionality
  56 2012-08-16T11:22:44  <dreimark> spy: yes - you have to make a kind of history search for that because there can be new entries while you paginate
  57 2012-08-16T11:23:03  <dreimark> also there could be changes so you have less documents
  58 2012-08-16T11:25:54  <spy> yeah, okay, Thomas said for now we just don't do it :)
  59 2012-08-16T11:30:56  *** greg_f has joined #moin-dev
  60 2012-08-16T13:52:43  *** MattMaker has quit IRC
  61 2012-08-16T14:22:13  *** MattMaker has joined #moin-dev
  62 2012-08-16T14:35:44  *** dwcramer has joined #moin-dev
  63 2012-08-16T14:45:14  *** dave_largo has joined #moin-dev
  64 2012-08-16T14:50:54  *** dwcramer has quit IRC
  65 2012-08-16T15:14:19  <dreimark> xiaq: there is one other from your country on #moin needing help with appshot, if you have time feel free
  66 2012-08-16T15:14:57  <dreimark> nick: liyan
  67 2012-08-16T15:22:13  *** liyan has joined #moin-dev
  68 2012-08-16T15:22:13  *** hughperkins__ has joined #moin-dev
  69 2012-08-16T15:24:46  <liyan> Here is a selenium script to test account creation, login, and logout  http://rn0.ru/show/DHIChjj15lcokSmdz6u6/
  70 2012-08-16T15:25:27  <dreimark> liyan: is that from tip ?
  71 2012-08-16T15:26:00  <dreimark> 0d37d08e56de
  72 2012-08-16T15:26:51  <liyan> and here is the instructions  http://rn0.ru/show/VO0rhaaYPpDm3yMiaYX0/
  73 2012-08-16T15:26:57  <dreimark> we ussually have py.test
  74 2012-08-16T15:27:41  <dreimark> do you think it can be included in that framework too
  75 2012-08-16T15:28:07  <liyan> dreimark, what do you mean by 'tip'?
  76 2012-08-16T15:28:14  <dreimark> hg tip
  77 2012-08-16T15:28:42  <dreimark> currently because of end phase of summer of code we have lots of merges
  78 2012-08-16T15:28:47  <dreimark> and also two themes now
  79 2012-08-16T15:29:56  <liyan> I just did an 'hg clone' a few days ago.
  80 2012-08-16T15:30:21  <dreimark> ok, just hg pull -u and your clone is uptodate
  81 2012-08-16T15:31:06  <dreimark> it should also work in a env, so just pip install selenium
  82 2012-08-16T15:32:14  <dreimark> so it could become extras_require entry in setup.py
  83 2012-08-16T15:33:00  <dreimark> but the main difference is that you have based it on unittest, doing it with pytest would integrate into our other tests directly
  84 2012-08-16T15:33:33  <dreimark> liyan: after the pull you should run moin index-build -s -i
  85 2012-08-16T15:34:10  <dreimark> there are usually new meta keys added
  86 2012-08-16T15:37:43  <dreimark> liyan: look with pylint on your example, some imports are not used
  87 2012-08-16T15:38:20  <dreimark> check also pep8
  88 2012-08-16T15:38:49  <liyan> Ok. I will do an 'hg pull -u' to get the latest changes; and I will look at migrating my code to use pytest.
  89 2012-08-16T15:39:41  <dreimark> you likly need to "pip install markdown" depends when you did the initial clone
  90 2012-08-16T15:41:55  <dreimark> we have to look later if the moin server command is already in such a way implemented that one could easily create a testwiki and destroy it after the selenium tests run
  91 2012-08-16T15:58:03  <dreimark> liyan: http://hg.moinmo.in/moin/2.0/file/0d37d08e56de/MoinMoin/_tests/_test_template.py
  92 2012-08-16T15:58:32  <dreimark> our current tests are having that template pattern
  93 2012-08-16T16:04:43  <liyan> Ok, sounds good. I will look into running pylint, migrating to pytest, doing the hg pull, and looking at the test template.
  94 2012-08-16T16:05:05  <dreimark> :)
  95 2012-08-16T16:05:32  <dreimark> bbl
  96 2012-08-16T16:05:59  *** liyan has quit IRC
  97 2012-08-16T16:07:16  *** dwcramer has joined #moin-dev
  98 2012-08-16T16:11:03  *** hughperkins__ has quit IRC
  99 2012-08-16T16:32:16  *** MattMaker has quit IRC
 100 2012-08-16T16:35:29  *** MattMaker has joined #moin-dev
 101 2012-08-16T17:34:29  *** dwcramer has quit IRC
 102 2012-08-16T17:47:42  *** dwcramer has joined #moin-dev
 103 2012-08-16T17:54:18  *** dwcramer has quit IRC
 104 2012-08-16T17:57:55  *** dwcramer has joined #moin-dev
 105 2012-08-16T18:10:09  *** dwcramer has quit IRC
 106 2012-08-16T18:23:10  *** dwcramer has joined #moin-dev
 107 2012-08-16T18:34:37  *** dwcramer has quit IRC
 108 2012-08-16T18:41:27  *** dwcramer has joined #moin-dev
 109 2012-08-16T18:53:57  *** dcramer_ has joined #moin-dev
 110 2012-08-16T18:57:28  *** dwcramer has quit IRC
 111 2012-08-16T18:59:39  *** dcramer_ has quit IRC
 112 2012-08-16T19:14:27  *** dcramer_ has joined #moin-dev
 113 2012-08-16T19:20:47  *** greg_f has quit IRC
 114 2012-08-16T20:00:36  *** jaiditya has joined #moin-dev
 115 2012-08-16T20:02:19  <jaiditya> xiaq: No heading in foobar theme search page .
 116 2012-08-16T20:06:23  *** dave_largo has quit IRC
 117 2012-08-16T21:06:59  <spy> dreimark: http://codereview.appspot.com/6441151
 118 2012-08-16T21:07:00  <spy> ThomasWaldmann: ^
 119 2012-08-16T21:12:27  <spy> added some unittests, but have a problem with acl
 120 2012-08-16T21:13:58  <spy> jaiditya: what should I do next when I've added some changes to the stylus file?
 121 2012-08-16T21:20:01  <spy> jaiditya: do I have to install node.js?
 122 2012-08-16T21:47:13  <jaiditya> spy: sorry was afk
 123 2012-08-16T21:47:41  <jaiditya> spy: yes, first node.js then stylus
 124 2012-08-16T21:48:44  <jaiditya> and then u'll have to execute "stylus --include-css --compress < main.styl > ../common.css"
 125 2012-08-16T21:48:58  <jaiditya> in theme's stylus folder
 126 2012-08-16T21:51:51  <spy> are there any prebuild node.js for linux?
 127 2012-08-16T22:06:37  *** dave_largo has joined #moin-dev
 128 2012-08-16T22:12:07  <spy> jaiditya: http://pastebin.com/HLmHNcbg
 129 2012-08-16T22:13:52  *** dcramer_ has quit IRC
 130 2012-08-16T22:18:38  <jaiditya> spy: indentation matters, it means nesting
 131 2012-08-16T22:28:24  *** diofeher has joined #moin-dev
 132 2012-08-16T22:30:31  *** RogerHaase has joined #moin-dev
 133 2012-08-16T22:37:05  *** diofeher has quit IRC
 134 2012-08-16T23:21:34  *** dave_largo has quit IRC
 135 2012-08-16T23:23:18  <spy> jaiditya: this is unmodified file from the main repo
 136 2012-08-16T23:36:38  <dreimark> re
 137 2012-08-16T23:39:33  <dreimark> spy: looking
 138 2012-08-16T23:41:47  <jaiditya> spy: I don't get any error here
 139 2012-08-16T23:43:41  <jaiditya> RogerHaase: Do you get any error while generating css from current stylus file of modernized theme ?
 140 2012-08-16T23:50:26  <RogerHaase> no errors,  the 4 lines of copyright now have 4 leading blanks, was 2
 141 2012-08-16T23:51:57  <RogerHaase> .. and the video font-size line around line 30 has 2 more leading blanks (common.css)
 142 2012-08-16T23:56:47  <dreimark> spy: nodejs in ubuntu
 143 2012-08-16T23:57:47  <RogerHaase> jaiditya: but line 1580 in main.styl does look like it needs 4 leading spaces