1 2012-08-21T00:06:33 *** ronny
2 2012-08-21T00:19:14 *** RogerHaase
3 2012-08-21T00:50:12 *** dwcramer
4 2012-08-21T01:19:02 *** MattMaker
5 2012-08-21T02:40:01 *** dwcramer
6 2012-08-21T03:10:17 *** MattMaker
7 2012-08-21T03:15:14 *** MattMaker
8 2012-08-21T03:28:40 *** MattMaker
9 2012-08-21T03:46:02 *** MattMaker
10 2012-08-21T05:01:45 *** jaiditya
11 2012-08-21T05:03:50 *** dwcramer
12 2012-08-21T05:17:20 *** dwcramer
13 2012-08-21T06:10:09 *** jaiditya
14 2012-08-21T07:26:19 *** ronny
15 2012-08-21T07:26:19 *** ronny
16 2012-08-21T07:28:24 *** jaiditya
17 2012-08-21T08:47:02 <dreimark> moin
18 2012-08-21T09:05:45 <ThomasWaldmann> moin
19 2012-08-21T09:43:04 *** MattMaker
20 2012-08-21T10:55:59 <MaikuMori> moin
21 2012-08-21T11:03:07 *** greg_f
22 2012-08-21T11:16:05 <gwork> moin
23 2012-08-21T11:17:16 <spy> dreimark: moin, are blog tests still broken for you?
24 2012-08-21T11:19:32 *** gwork
25 2012-08-21T11:30:30 <dreimark> spy: yes
26 2012-08-21T11:30:33 <dreimark> make clean
27 2012-08-21T11:30:35 <dreimark> make test
28 2012-08-21T11:30:52 <dreimark> shows the two tests broken
29 2012-08-21T11:33:05 *** gwork
30 2012-08-21T11:56:53 <spy> dreimark: could you please add 'print rv.data' below 27 line in MoinMoin/items/_tests/test_Blog.py, then run py.test -s MoinMoin/items/_tests/test_Blog.py > blog.log and send this output to me.
31 2012-08-21T12:01:01 <ThomasWaldmann> are we talking about failing tests in main repo or in spy's repo?
32 2012-08-21T12:03:44 <spy> ThomasWaldmann: main
33 2012-08-21T12:09:25 <ThomasWaldmann> 620 passed, 360 skipped in 117.60 seconds
34 2012-08-21T12:13:56 <spy> I don't have any breakage, but dreimark has. Want to understand why.
35 2012-08-21T12:18:40 <dreimark> ThomasWaldmann: main repo
36 2012-08-21T12:22:35 <dreimark> spy: it fails not if it is called alone
37 2012-08-21T12:25:00 <spy> hmm
38 2012-08-21T12:26:29 <ThomasWaldmann> can we just have the log output?
39 2012-08-21T12:27:55 <dreimark> sure, it try a fresh clone meanwhile
40 2012-08-21T12:29:57 <spy> still I want to look at rv.data output to find out something
41 2012-08-21T12:31:45 <dreimark> http://rn0.ru/show/SdTsVWnc3gVvG6lDyFPE/
42 2012-08-21T12:37:49 <dreimark> spy: ThomasWaldmann on a fresh clone i have 0 errors
43 2012-08-21T12:39:24 <spy> dreimark: run moin index-update
44 2012-08-21T12:39:56 *** hughperkins
45 2012-08-21T12:39:56 *** liyan
46 2012-08-21T12:40:06 <spy> those fails are due to broken PTIME-sorting
47 2012-08-21T12:40:24 *** liyan
48 2012-08-21T12:40:35 <spy> likely it is whoosh bug
49 2012-08-21T12:40:48 <spy> that is already fixed :)
50 2012-08-21T12:41:18 <dreimark> spy: so i have to check if i have a differnt woosh version?
51 2012-08-21T12:41:22 *** hughperkins_
52 2012-08-21T12:42:01 *** liyan_
53 2012-08-21T12:42:20 <spy> dreimark: just try to run index-update
54 2012-08-21T12:42:22 *** liyan_
55 2012-08-21T12:44:10 *** hughperkins_
56 2012-08-21T12:45:36 <dreimark> did not work
57 2012-08-21T12:45:41 <ThomasWaldmann> Whoosh==2.4.1 < from "pip freeze" in my env
58 2012-08-21T12:46:17 <dreimark> mine 2.4.0
59 2012-08-21T12:46:30 <dreimark> whoosh.__version__
60 2012-08-21T12:47:43 <dreimark> the fresh clone has also 2.4.1
61 2012-08-21T12:47:58 <dreimark> spy: i suggest you raise the version to that in setup.py
62 2012-08-21T12:48:51 <spy> mine Whoosh==2.4.1
63 2012-08-21T12:49:46 <liyan> Hi dreimark, here is a new draft of a selenium login test script http://rn0.ru/show/vqfzBszYLKXB3wYH6MBc/
64 2012-08-21T12:51:04 <spy> ThomasWaldmann: hm, the sorting bug was fixed later than 2.4.1 was released
65 2012-08-21T12:53:58 <spy> but what I see on a log output is that items are sorted in the order in which they were created (not relative to their PTIMEs)
66 2012-08-21T12:59:03 *** liyan
67 2012-08-21T13:03:32 *** hughperkins
68 2012-08-21T13:23:01 <ThomasWaldmann> well, as i said: it works for me
69 2012-08-21T13:24:08 <ThomasWaldmann> btw, whoosh is installed from my bitbucket repo and i think it'll take the latest from there
70 2012-08-21T13:24:28 <ThomasWaldmann> so not really 2.4.1 release, but something later that still says it is 2.4.1 :|
71 2012-08-21T13:25:00 <ThomasWaldmann> (and i think i already suggested to matt to increase the version number directly after releasing, so one sees it is not just 2.4.1 any more)
72 2012-08-21T13:32:55 <spy> it works for me too
73 2012-08-21T13:35:56 <dreimark> spy: if it works or not depends currently on luck
74 2012-08-21T13:36:27 <dreimark> only increasing the version number by matt will solve it permanently
75 2012-08-21T13:37:04 <dreimark> version handling should always have strict rules
76 2012-08-21T13:39:56 <breton> well, in fact, installation via quickiinstall from the main repo doesn't work for me. http://rn0.ru/show/7VqjSobaZiL8hKVhpGcu/
77 2012-08-21T13:40:33 <breton> wanted to run tests what is discussed above.
78 2012-08-21T13:40:50 *** dwcramer
79 2012-08-21T13:43:12 <breton> *for what
80 2012-08-21T13:48:41 <breton> also, "620 passed, 58 skipped".
81 2012-08-21T14:14:49 <spy> I assume that a blog entry item is always a subitem of a blog item. If you want to show a blog entry item and its parent is not a blog item you will get AccessDenied. Is there a reason to have a blog entry item outside of a blog?
82 2012-08-21T14:14:53 <spy> dreimark: ^
83 2012-08-21T14:14:56 <spy> ThomasWaldmann: ^
84 2012-08-21T14:16:48 <spy> someone might rename an entry 'myblog/foo' to 'foo' and he will get AccessDenied
85 2012-08-21T14:19:30 <spy> worse he can do it by accident
86 2012-08-21T14:40:16 *** dave_largo
87 2012-08-21T14:52:27 *** MattMaker
88 2012-08-21T14:52:43 *** MattMaker
89 2012-08-21T14:57:35 <spy> xiaq: You introduce a separate css for tickets MoinMoin/static/css/ticket.css. Why doesn't it depend on a selected theme? What will you do when there will be specific to the theme styles?
90 2012-08-21T14:59:07 <spy> I consider to separate blog styles, but to have them separately for each theme
91 2012-08-21T15:17:24 *** ronny
92 2012-08-21T15:41:42 <xiaq> spy: i just did it the easy way. :)
93 2012-08-21T15:42:57 <xiaq> also, probably we can come up with a way to reuse some css across themes without making things too fragmented...
94 2012-08-21T15:56:29 *** dave_largo
95 2012-08-21T16:13:40 <spy> xiaq: okay
96 2012-08-21T16:21:31 *** ronny
97 2012-08-21T16:56:13 *** dwcramer
98 2012-08-21T17:13:17 *** jaiditya
99 2012-08-21T17:36:47 *** RogerHaase
100 2012-08-21T17:44:43 <spy> jaiditya: need help with foobar styling for Blog
101 2012-08-21T17:46:45 <spy> currently there are two side panels on the foobar theme and the blog layout provide another one. oh, too many
102 2012-08-21T17:48:19 <spy> jaiditya: what do you think if we move blog's widgets (currently Categories listing) to the right local panel?
103 2012-08-21T17:49:10 *** dcramer_
104 2012-08-21T17:51:58 *** dwcramer
105 2012-08-21T18:45:46 *** dave_largo
106 2012-08-21T19:00:40 <jaiditya> spy: hi
107 2012-08-21T19:00:49 <jaiditya> sorry was afk
108 2012-08-21T19:02:39 <jaiditya> spy: I was also thinking the same...the blog widget would suit more in right panel
109 2012-08-21T19:05:00 <jaiditya> there is a {% block local %} look at local.html...so you'll have to overwrite itemviews in block by blog widgets..
110 2012-08-21T19:05:37 <jaiditya> so u'll have to extend your template from show.html
111 2012-08-21T19:05:49 <jaiditya> then
112 2012-08-21T19:06:08 <jaiditya> {% block local %}
113 2012-08-21T19:06:17 <jaiditya> widget content
114 2012-08-21T19:06:29 <jaiditya> {% endblock %}
115 2012-08-21T19:07:29 <jaiditya> this will overwrite the itemviews by widget in the local (right) panel
116 2012-08-21T19:40:34 *** greg_f
117 2012-08-21T19:48:27 *** xorAxAx
118 2012-08-21T19:48:41 <spy> jaiditya: i will create blog_layout template for foobar theme where will override the local block
119 2012-08-21T19:50:50 *** xorAxAx
120 2012-08-21T20:01:16 <xiaq> ThomasWaldmann: updated http://codereview.appspot.com/6457091/
121 2012-08-21T20:01:17 <xiaq> dreimark: ^^
122 2012-08-21T20:01:26 * xiaq goes to bed, gn
123 2012-08-21T20:05:36 <dreimark> gn xiaq
124 2012-08-21T20:52:49 *** dave_largo
125 2012-08-21T20:58:20 *** dave_largo
126 2012-08-21T21:04:40 <jaiditya> spy: which file is the parent of blog_layout ?
127 2012-08-21T21:21:57 <spy> local.html
128 2012-08-21T21:23:39 <spy> jaiditya: ^
129 2012-08-21T21:24:08 <jaiditya> then just override block local in blog_layout
130 2012-08-21T21:24:55 <jaiditya> and extend it from show.html
131 2012-08-21T21:25:28 <jaiditya> its better that way
132 2012-08-21T21:26:15 <jaiditya> I mean extend blog_layout from show.html instead of local.html
133 2012-08-21T21:27:21 -jaiditya- AVATAR
134 2012-08-21T21:37:56 <spy> jaiditya: no, this would be wrong, because show.html works with the selected ONE item, but blog_layout shows many items simultenously on the one page. Soon I will show you what I did
135 2012-08-21T21:39:13 <jaiditya> spy: ok, you know that better, will be waiting for it
136 2012-08-21T22:05:11 <spy> jaiditya: will that "Views" block on the local panel be as it is now or do you consider to create a drop-down menu or something else for it?
137 2012-08-21T22:06:56 <jaiditya> for now no drop-down list
138 2012-08-21T22:46:04 <spy> jaiditya: please register, login and change Theme to FooBar: http://vps.psviderski.name:8080/myblog
139 2012-08-21T22:46:33 <jaiditya> just a min
140 2012-08-21T22:46:34 <spy> jaiditya: I've added css for blog a bit
141 2012-08-21T22:48:10 <jaiditya> spy: using stylus ?
142 2012-08-21T22:48:41 *** dcramer_
143 2012-08-21T22:49:46 <jaiditya> spy: views panel is intentional ?
144 2012-08-21T22:52:09 <jaiditya> spy: looks good
145 2012-08-21T22:55:45 <spy> jaiditya: for now I've add it to be able to modify the header item
146 2012-08-21T22:56:52 <jaiditya> minor detailing bugs but I'll take care of css stuff once it gets merged
147 2012-08-21T22:57:33 <spy> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/77/move-blog-templates-styles-to-a-separate
148 2012-08-21T22:57:37 <spy> ThomasWaldmann: ^
149 2012-08-21T22:57:39 <spy> dreimark: ^
150 2012-08-21T22:57:41 <spy> jaiditya: ^
151 2012-08-21T22:58:33 <jaiditya> yeah, bitbucket bug
152 2012-08-21T22:59:13 <jaiditya> spy: you have pushed all your stuff ?
153 2012-08-21T22:59:15 <spy> jaiditya: also for foobar theme I have to add a lot of "margin 1em 0" to expand vertical space between blocks.
154 2012-08-21T23:01:39 <spy> blog styles for modernized and foobar themes become more distinct, is is ok?
155 2012-08-21T23:03:32 <spy> I feel the perfect way is to use the same stylus file for both themes, am I wrong?
156 2012-08-21T23:03:35 <spy> jaiditya: ^
157 2012-08-21T23:03:40 <jaiditya> no, instead of adding same "margin 1em 0" again and again you should have added that to entire block globally
158 2012-08-21T23:04:24 <jaiditya> spy: why we have different stylus file for blog ?
159 2012-08-21T23:09:57 <spy> jaiditya: in modernized theme we have many useful inherited margins for div elements, but foobar don't has them, so the blog looks like a mess.
160 2012-08-21T23:11:11 <spy> maybe create one blog.styl and optimize it to be compatible for both themes?
161 2012-08-21T23:11:14 <jaiditya> spy: ok, will look at complete blog css for both modernized and foobar
162 2012-08-21T23:11:26 <jaiditya> yeah, I intend the
163 2012-08-21T23:11:29 <jaiditya> same
164 2012-08-21T23:13:34 <spy> jaiditya: btw, you can pull from my repo until the pull request isn't pushed.
165 2012-08-21T23:16:43 *** dave_largo
166 2012-08-21T23:16:53 <jaiditya> ok, btw when are you planning to push your stuff
167 2012-08-21T23:17:15 <spy> also I consider to use left-side panel that is currently used for subitems navigation for blog's widgets (I mean modernized theme)
168 2012-08-21T23:17:47 <spy> I've already pushed
169 2012-08-21T23:17:51 <spy> no?
170 2012-08-21T23:18:02 <spy> https://bitbucket.org/psviderski/moin-2.0/
171 2012-08-21T23:18:21 <jaiditya> I'll pull from your repo
172 2012-08-21T23:19:28 <jaiditya> spy: and to use subitem navigation panel for blog widget u'll again just have to override the subitem block
173 2012-08-21T23:20:25 <jaiditya> spy: {% block subitem_navigation %}{% endblock %}
174 2012-08-21T23:20:45 <spy> it is better to wrap it into a new div block like "sidebar/panel"
175 2012-08-21T23:21:02 <jaiditya> {% block subitem_navigation %}
176 2012-08-21T23:21:03 <jaiditya> widget content
177 2012-08-21T23:21:03 <jaiditya> {% endblock %}
178 2012-08-21T23:21:03 <spy> and use it for all such stuff
179 2012-08-21T23:22:51 <dreimark> spy: i look tom.
180 2012-08-21T23:22:54 <dreimark> gn
181 2012-08-21T23:23:50 <jaiditya> spy: won't make much difference
182 2012-08-21T23:24:25 <jaiditya> you can do it either way
183 2012-08-21T23:37:45 * ThomasWaldmann rejected all those outdated pull requests
184 2012-08-21T23:37:58 <ronny> yo
185 2012-08-21T23:39:20 <spy> ThomasWaldmann: do I have to sent it again?
186 2012-08-21T23:46:49 <ThomasWaldmann> spy: do you have outgoing stuff?
187 2012-08-21T23:48:51 <spy> ThomasWaldmann: yeah, you've rejected it now :)
188 2012-08-21T23:50:04 <ThomasWaldmann> ok, then please redo the pull request
189 2012-08-21T23:50:19 <ThomasWaldmann> we can use it for testing that other bitbucket bug :)
190 2012-08-21T23:52:14 <spy> ThomasWaldmann: done
191 2012-08-21T23:53:01 <CIA-79> Pavel Sviderski <pavel@psviderski.name> default * 1721:1df0320ae4c4 2.0/MoinMoin/ (5 files in 3 dirs): Move blog styles to separate css/styl files (modernized theme).
192 2012-08-21T23:53:02 <CIA-79> Pavel Sviderski <pavel@psviderski.name> default * 1722:02c0e90cbb0b 2.0/MoinMoin/themes/foobar/static/css/ (common.css stylus/main.styl blog.css stylus/blog.styl): Move blog styles to separate css/styl files (foobar theme).
193 2012-08-21T23:53:02 <CIA-79> Pavel Sviderski <pavel@psviderski.name> default * 1723:805f03d03259 2.0/MoinMoin/ (12 files in 3 dirs): Move blog templates to a separate 'blog' directory. Split 'blog_layout' into two parts, 'layout' and 'utils'.
194 2012-08-21T23:53:03 <CIA-79> Pavel Sviderski <pavel@psviderski.name> default * 1724:5068b69bfb0c 2.0/MoinMoin/themes/foobar/templates/blog/layout.html: Add blog/layout.html template for foobar theme.
195 2012-08-21T23:53:19 <spy> jaiditya: ^
196 2012-08-21T23:53:28 <ThomasWaldmann> yup, it is fixed :)
197 2012-08-21T23:53:58 <spy> nice! :)
198 2012-08-21T23:55:17 <jaiditya> ok will have a look tmrw, its too late here, gn
199 2012-08-21T23:55:54 <spy> jaiditya: gn
200 2012-08-21T23:57:25 <ThomasWaldmann> gn jaiditya
