1 2012-09-28T00:22:45 *** RogerHaase
2 2012-09-28T01:09:58 *** dwcramer
3 2012-09-28T05:10:27 *** dwcramer
4 2012-09-28T09:03:03 *** MattMaker
5 2012-09-28T09:04:05 *** MattMaker
6 2012-09-28T11:22:48 *** greg_f
7 2012-09-28T11:29:23 <dreimark> moin
8 2012-09-28T11:33:11 <ThomasWaldmann> moin
9 2012-09-28T15:15:23 <ThomasWaldmann> hmm, CIA has left us alone
10 2012-09-28T16:07:45 *** dave_largo
11 2012-09-28T16:12:36 <waldi> yep. it is gone forever
12 2012-09-28T16:23:54 *** dwcramer
13 2012-09-28T16:33:44 *** sunu
14 2012-09-28T16:38:14 <ThomasWaldmann> http://cia.vc/ oops
15 2012-09-28T16:40:11 <dreimark> .oO
16 2012-09-28T16:59:11 <sunu> hello ThomasWaldmann :)
17 2012-09-28T16:59:27 <sunu> see if I'm on the right track today
18 2012-09-28T16:59:29 <sunu> http://codereview.appspot.com/6571070
19 2012-09-28T16:59:33 <sunu> :D
20 2012-09-28T17:11:15 <dreimark> where there tabs used before ?
21 2012-09-28T17:11:38 <dreimark> it looks at least that there more lines changed than needed
22 2012-09-28T17:12:09 <dreimark> if style becomes changed then please afterwards or before / just not together
23 2012-09-28T17:12:54 *** RogerHaase
24 2012-09-28T17:12:57 <ThomasWaldmann> sunu: did you run that makefile target?
25 2012-09-28T17:13:30 <sunu> oh I forgot to convert indentation to tabs. :(
26 2012-09-28T17:16:19 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560065 now ?
27 2012-09-28T17:16:53 <sunu> I just want to know if I'm getting the idea or I'm still on the wrong track
28 2012-09-28T17:17:32 <dreimark> better readable, on future upload's please use same id
29 2012-09-28T17:18:24 <dreimark> sunu: hmm, foes this work with the standalone server
30 2012-09-28T17:18:29 <dreimark> s/foes/does/
31 2012-09-28T17:19:06 <dreimark> ah ok, you renmed only gae support
32 2012-09-28T17:19:29 <ThomasWaldmann> sunu: review done
33 2012-09-28T17:23:43 <sunu> ThomasWaldmann: the support folder is not path yet so the moin command won't be detected. So should I use bash script to add support to path ?
34 2012-09-28T17:26:18 <ThomasWaldmann> try to create a simple solution requiring least amount of additional files. doesn't sound like an additional bash script.
35 2012-09-28T17:26:57 * ThomasWaldmann brb
36 2012-09-28T17:27:51 *** sunu
37 2012-09-28T17:27:54 *** sunu_
38 2012-09-28T17:27:54 *** sunu_
39 2012-09-28T17:28:34 <sunu> ThomasWaldmann: I just lost my connection. sorry :(
40 2012-09-28T17:29:00 <sunu> I was askin that the support folder is not path yet so the moin command won't be detected. So should I use bash script to add support to path ?
41 2012-09-28T17:32:22 <dreimark> 15:26 < ThomasWaldmann> try to create a simple solution requiring least amount of additional files. doesn't sound like an additional bash script.
42 2012-09-28T17:32:25 <dreimark> 15:26 * ThomasWaldmann brb
43 2012-09-28T17:35:02 <sunu> dreimark: btw how do I upload again to that same id ?
44 2012-09-28T17:36:10 <RogerHaase> python upload.py -i 6560065
45 2012-09-28T17:36:44 <sunu> RogerHaase: Thanks :)
46 2012-09-28T17:37:10 <dreimark> btw. that is a python script and it has a help page too
47 2012-09-28T17:42:39 <dreimark> bbl
48 2012-09-28T17:49:15 *** spy
49 2012-09-28T18:02:42 *** dave_largo
50 2012-09-28T18:13:16 <ThomasWaldmann> sunu: you really need a better inet connection. what is that what you currently use?
51 2012-09-28T18:14:35 <sunu> It's 2Mbps broadband connection from BSNL which is the largest internet provider here in India and it's a govt. company too. :(
52 2012-09-28T18:14:57 <sunu> and it's kinda the best available here.
53 2012-09-28T18:15:24 <sunu> There maintenance just sucks.
54 2012-09-28T18:15:52 <sunu> Btw all stuff government sucks here in India.
55 2012-09-28T18:15:57 <ThomasWaldmann> so is that dsl or cable?
56 2012-09-28T18:16:18 <ThomasWaldmann> just wondering why it disconnects so often
57 2012-09-28T18:16:50 <sunu> dsl..
58 2012-09-28T18:17:12 <ThomasWaldmann> you need the pirate party in the government, then at least the internet would work, haha
59 2012-09-28T18:18:06 <sunu> its the telephone wire mainly .. the wiring in here is done in the open .. not underground like in US or europe
60 2012-09-28T18:18:38 <ThomasWaldmann> so is your dsl modem resyncing when it throws you out?
61 2012-09-28T18:20:20 <sunu> not sure what you mean ..but it's like I lose connection for 2-3 seconds and then it's back up.. but that's enough to disconnect me from the channel
62 2012-09-28T18:22:22 <ThomasWaldmann> usually dsl modems have some "sync" led. if it is continously on (often green), you have sync. if it is blinking, it lost sync and is resyncing.
63 2012-09-28T18:23:37 <sunu> yeah mine blicks red when the sync is lost ..and then it resyncs
64 2012-09-28T18:23:48 <sunu> and the green light comes on
65 2012-09-28T18:24:46 <ThomasWaldmann> if that happens often, either the line is bad, the modem is bad, or it is configured for too high speed (more than the line can do)
66 2012-09-28T18:26:21 <ThomasWaldmann> (there are rather new modems with "RAM" (rate adaptive mode), that try to get most out of the line, but are able to adapt)
67 2012-09-28T18:27:00 <sunu> yeah it's mainly the line... I have already tested the modem and all . The people from BSNL also admit it's the line .. but they just won't repair it :/
68 2012-09-28T18:27:49 <ThomasWaldmann> any other choice, some other company that does better?
69 2012-09-28T18:28:46 <ThomasWaldmann> btw, have a look into that "moin" file you copy into support/ - you'll see it is rather special and maybe won't work like you expect
70 2012-09-28T18:29:24 <sunu> I live in a pretty small town here. So choices are limited. There are 2 companies introducing 3G here next month. Will try to switch to 3G I guess
71 2012-09-28T18:30:08 <sunu> yeah, I was just looking into the moin file. it also needs pkg_resources . so should I have the .egg file in support folder too ?
72 2012-09-28T18:30:34 <sunu> or I should not copy it atall and do it some other way ?
73 2012-09-28T18:30:34 <ThomasWaldmann> no, rather do it differently
74 2012-09-28T18:31:03 <sunu> ok, some hint ? :D
75 2012-09-28T18:31:11 *** spy
76 2012-09-28T18:31:56 <ThomasWaldmann> maybe we could have a single python file in toplevel dir (moin.py ?)
77 2012-09-28T18:32:14 <ThomasWaldmann> which does the sys.path manipulation
78 2012-09-28T18:32:42 <ThomasWaldmann> then checks for gae and does what's special for gae
79 2012-09-28T18:33:30 <ThomasWaldmann> and which has some toplevel code (with the usual check for '__main__') that runs the simple server
80 2012-09-28T18:34:13 <ThomasWaldmann> but maybe you want to first finish the Makefile / app.yaml stuff and commit
81 2012-09-28T18:34:27 <ThomasWaldmann> see my last comments on codereview
82 2012-09-28T18:34:44 <sunu> ok.
83 2012-09-28T18:35:33 <sunu> so we will have the main.py in the toplevel directory by default?
84 2012-09-28T18:35:49 <sunu> the user don't have to download it, right ?
85 2012-09-28T18:35:49 <ThomasWaldmann> moin :)
86 2012-09-28T18:36:01 <ThomasWaldmann> but do that after committing the finished stuff
87 2012-09-28T18:36:01 <sunu> oh sorry ..moin.py
88 2012-09-28T18:36:08 <sunu> yeah.
89 2012-09-28T18:36:30 <ThomasWaldmann> and just as a hint: avoid renaming files and changing them within same changeset / review
90 2012-09-28T18:36:47 <ThomasWaldmann> it's hard to review in such cases what you really changed
91 2012-09-28T18:40:00 <sunu> didn't get that. example ?
92 2012-09-28T18:43:44 <ThomasWaldmann> if you "hg mv oldname newname", a diff will show all lines from oldname removed and all lines from newname added
93 2012-09-28T18:44:02 <ThomasWaldmann> so one can not easily see if other changes were done
94 2012-09-28T18:44:42 <sunu> so I should use hg move while renaming files.
95 2012-09-28T18:46:38 <sunu> ThomasWaldmann: uploaded. http://codereview.appspot.com/6560065/
96 2012-09-28T18:48:12 <ThomasWaldmann> sure, never to mv, always hg mv if you rename a file or directory under version control
97 2012-09-28T18:48:17 <ThomasWaldmann> do*
98 2012-09-28T18:51:10 <sunu> ThomasWaldmann: is it ok to commit now ?
99 2012-09-28T18:52:16 <ThomasWaldmann> see review
100 2012-09-28T18:52:30 <ThomasWaldmann> did you configure hg to use your correct username / email?
101 2012-09-28T18:55:11 <sunu> yeah the username and password of bitbucket
102 2012-09-28T18:58:39 <ThomasWaldmann> i rather mean that when you commit, that hg uses the correct name and email for the repo history (hg log)
103 2012-09-28T19:03:31 <sunu> it uses user:sunu <sunu0000@gmail.com> now
104 2012-09-28T19:04:37 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560065. Now I can work on the moin.py ?
105 2012-09-28T19:05:11 <ThomasWaldmann> you don't want your real name there?
106 2012-09-28T19:06:03 <sunu> sunu is my real nick name actually . Should I have my full name there ?
107 2012-09-28T19:06:28 <ThomasWaldmann> Well, that's the usual thing. Except if you have strong reasons against. :)
108 2012-09-28T19:06:56 <ThomasWaldmann> another review done :)
109 2012-09-28T19:07:21 <ThomasWaldmann> do you have any non-ascii chars in your name?
110 2012-09-28T19:08:24 <ThomasWaldmann> (if so, better use some ascii transcription that is acceptable for you)
111 2012-09-28T19:08:40 <sunu> nah it's Tarashish Mishra. It's all english :)
112 2012-09-28T19:08:48 <sunu> so ascii
113 2012-09-28T19:08:54 <ThomasWaldmann> ok
114 2012-09-28T19:11:10 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560065. Done
115 2012-09-28T19:17:17 <sunu> ThomasWaldmann: changed username to full name :)
116 2012-09-28T19:35:40 *** sunu
117 2012-09-28T19:35:43 *** sunu_
118 2012-09-28T19:35:43 *** sunu_
119 2012-09-28T19:36:01 *** greg_f
120 2012-09-28T19:51:11 *** dave_largo
121 2012-09-28T19:56:06 *** sunu_
122 2012-09-28T19:57:01 *** sunu
123 2012-09-28T19:57:01 *** sunu_
124 2012-09-28T19:59:47 *** sunu
125 2012-09-28T20:00:01 *** sunu
126 2012-09-28T20:03:14 <sunu> ThomasWaldmann: created the moin.py file. take a look please. http://codereview.appspot.com/6568068
127 2012-09-28T20:04:23 <ThomasWaldmann> see codereview.
128 2012-09-28T20:04:38 <ThomasWaldmann> http://codereview.appspot.com/6560065
129 2012-09-28T20:07:39 <sunu> ThomasWaldmann: insert a blank means insert a space ?
130 2012-09-28T20:12:32 <ThomasWaldmann> yes
131 2012-09-28T20:12:55 <ThomasWaldmann> other review done also.
132 2012-09-28T20:19:39 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560065 . Done :)
133 2012-09-28T20:21:20 <ThomasWaldmann> ok
134 2012-09-28T20:21:38 <ThomasWaldmann> now write a good and useful commit comment and commit :)
135 2012-09-28T20:22:02 <ThomasWaldmann> and always have a look at hg diff and hg status before committing
136 2012-09-28T20:26:58 <sunu> "Edited Makefile and app.yaml to generate a single support directory for both gae and simple server" : this is good enough ?
137 2012-09-28T20:28:44 <ThomasWaldmann> almost :)
138 2012-09-28T20:30:15 <ThomasWaldmann> generate a support directory to be used by GAE and standalone, don't use jinja2 from GAE env
139 2012-09-28T20:31:32 <sunu> commit done :)
140 2012-09-28T20:31:59 <ThomasWaldmann> ok, push it to BB and send me a pull request :)
141 2012-09-28T20:32:58 * ThomasWaldmann brb
142 2012-09-28T20:39:50 <sunu> pull request sent :)
143 2012-09-28T21:01:52 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560068
144 2012-09-28T21:01:55 *** dwcramer
145 2012-09-28T21:02:06 <sunu> and http://codereview.appspot.com/6568068
146 2012-09-28T21:04:28 <ThomasWaldmann> ehrm
147 2012-09-28T21:04:55 <ThomasWaldmann> did you answer my question why you don't remove egg and pth stuff any more?
148 2012-09-28T21:07:50 <ThomasWaldmann> (i didn't see Makefile in the last review btw)
149 2012-09-28T21:08:17 <sunu> sorry didn't get you. Thought we removed then in Makefile >
150 2012-09-28T21:10:08 <ThomasWaldmann> see your changeset
151 2012-09-28T21:11:33 <sunu> oh noes :(
152 2012-09-28T21:11:46 <ThomasWaldmann> btw, did you test that stuff on GAE?
153 2012-09-28T21:11:52 <sunu> i removed that 2 lines by mistake
154 2012-09-28T21:12:58 <ThomasWaldmann> ok, you can strip the changeset from BB
155 2012-09-28T21:13:14 <ThomasWaldmann> in your local repo, you can do a rollback
156 2012-09-28T21:13:41 <ThomasWaldmann> (the latter only work for 1 last changeset, so you're lucky)
157 2012-09-28T21:15:56 <sunu> I just ran gae now.
158 2012-09-28T21:16:33 <sunu> As soon I hit the home page I get a 500 saying ImportError: No module named mmap
159 2012-09-28T21:16:56 <sunu> that supposed to be in support folder ?
160 2012-09-28T21:18:33 <ThomasWaldmann> ehrm, wait
161 2012-09-28T21:19:24 <ThomasWaldmann> check the whoosh version you have, you need 2.5.x from default branch
162 2012-09-28T21:20:00 *** dave_largo
163 2012-09-28T21:20:04 <ThomasWaldmann> (if you installed the env from moin's default branch, you have 2.4.1)
164 2012-09-28T21:20:26 <sunu> yeah
165 2012-09-28T21:20:31 <sunu> 2.4.1 it is
166 2012-09-28T21:21:31 <ThomasWaldmann> bleeding edge :)
167 2012-09-28T21:22:22 <sunu> so how can I have 2.5.x in support ?
168 2012-09-28T21:23:38 <ThomasWaldmann> pip uninstall whoosh
169 2012-09-28T21:23:45 <ThomasWaldmann> pip install -e .
170 2012-09-28T21:23:59 <ThomasWaldmann> (if you are on gae branch, that shall fetch 2.5.x)
171 2012-09-28T21:43:27 <sunu> ThomasWaldmann: http://codereview.appspot.com/6560065
172 2012-09-28T21:43:36 <sunu> alright ?
173 2012-09-28T21:48:35 <ThomasWaldmann> yeah
174 2012-09-28T21:49:09 <ThomasWaldmann> is GAE happy with us providing jinja2 although it is also available there?
175 2012-09-28T21:57:06 <sunu> well I still have 2.4.1 even after doing pip install
176 2012-09-28T21:57:21 <sunu> let me see what I did wrong.
177 2012-09-28T21:57:41 <ThomasWaldmann> 19:23 ThomasWaldmann$ pip install -e .
178 2012-09-28T21:57:45 <ThomasWaldmann> you did that?
179 2012-09-28T21:59:13 <sunu> yeah ... but I have my environment pointed to another directory :p
180 2012-09-28T21:59:39 <sunu> let me do it right this time
181 2012-09-28T22:00:22 *** dwcramer
182 2012-09-28T22:19:08 <sunu> ThomasWaldmann: GAE seems pretty happy :)
183 2012-09-28T22:19:16 <sunu> running perfect :D
184 2012-09-28T22:19:54 <sunu> ThomasWaldmann: http://codereview.appspot.com/6568068 This one needs a review
185 2012-09-28T22:20:15 <sunu> (btw I sent a fresh pull request)
186 2012-09-28T22:31:06 * ThomasWaldmann looks
187 2012-09-28T22:33:05 * ThomasWaldmann accepted pull request
188 2012-09-28T22:33:46 *** dwcramer
189 2012-09-28T22:36:25 *** sunu
190 2012-09-28T22:36:41 *** sunu
191 2012-09-28T22:57:57 <ThomasWaldmann> sunu: review done
192 2012-09-28T23:05:04 <sunu> ThomasWaldmann: It's 2:30 here. Time for bed. Will get back tomorrow :)
193 2012-09-28T23:05:56 <sunu> Btw from when to when do you remain online ?
194 2012-09-28T23:06:17 <ThomasWaldmann> depends. often utc afternoon to night
195 2012-09-28T23:08:54 <sunu> ok. Good night :)
196 2012-09-28T23:09:03 *** sunu
197 2012-09-28T23:18:55 *** jaiditya
198 2012-09-28T23:19:08 <jaiditya> moin
199 2012-09-28T23:19:18 <jaiditya> sorry
200 2012-09-28T23:19:29 <jaiditya> was nt available
201 2012-09-28T23:20:03 <ThomasWaldmann> no problem, just join if you have time :)
202 2012-09-28T23:20:34 <jaiditya> I have to finish what I started.
203 2012-09-28T23:20:39 <jaiditya> first
204 2012-09-28T23:21:10 <jaiditya> I pulled changes from the repo
205 2012-09-28T23:21:22 <jaiditya> there is a new branch added
206 2012-09-28T23:22:29 <ThomasWaldmann> yeah, some gae work
207 2012-09-28T23:23:04 <ThomasWaldmann> (you should work on default branch, of course, except if you work on gae)
208 2012-09-28T23:25:10 <jaiditya> I'll first finish what's remaining
209 2012-09-28T23:25:27 <ThomasWaldmann> ok, thanks :)
210 2012-09-28T23:25:45 <jaiditya> BTW I'd like to know about the gae work
211 2012-09-28T23:25:45 * ThomasWaldmann currently does some server work
212 2012-09-28T23:26:27 <ThomasWaldmann> https://moin2-test.appspot.com/Home < see there, it "basically works"
213 2012-09-28T23:27:04 <ThomasWaldmann> btw, you just missed a new contributor from india
214 2012-09-28T23:32:06 <jaiditya> tarashish mishra ?
215 2012-09-28T23:34:36 <ThomasWaldmann> yes
216 2012-09-28T23:40:01 <RogerHaase> wb jaiditya :)
217 2012-09-28T23:55:38 <RogerHaase> ThomasWaldmann: maybe we should remove svgweb? http://codereview.appspot.com/6576066/
