MoinMoin: MoinMoinChat/Logs/moin-dev/2012-10-07

   1 2012-10-07T00:00:48  *** grzywacz has quit IRC
   2 2012-10-07T00:18:17  *** dwcramer has quit IRC
   3 2012-10-07T00:50:00  *** dwcramer has joined #moin-dev
   4 2012-10-07T00:58:48  *** MattMaker has quit IRC
   5 2012-10-07T00:59:18  *** MattMaker has joined #moin-dev
   6 2012-10-07T04:19:00  <sunu> dreimark: ThomasWaldmann: replied and updated http://codereview.appspot.com/6619053/
   7 2012-10-07T04:54:48  <ThomasWaldmann> moin sunu :)
   8 2012-10-07T05:47:40  *** dwcramer has quit IRC
   9 2012-10-07T06:05:23  *** dwcramer has joined #moin-dev
  10 2012-10-07T08:58:49  *** Trip_ has joined #moin-dev
  11 2012-10-07T09:00:12  *** MattMaker has quit IRC
  12 2012-10-07T09:20:30  *** grzywacz has joined #moin-dev
  13 2012-10-07T09:20:31  *** grzywacz has joined #moin-dev
  14 2012-10-07T11:10:15  *** Trip_ has quit IRC
  15 2012-10-07T11:10:53  *** MattMaker has joined #moin-dev
  16 2012-10-07T13:22:27  <sunu> hi ThomasWaldmann  :)
  17 2012-10-07T13:23:29  * sunu just had a 9 hours long powercut for maintenace.
  18 2012-10-07T13:35:33  *** ChanServ has quit IRC
  19 2012-10-07T13:36:14  <xiaq> moin
  20 2012-10-07T13:36:36  <xiaq> i was getting down to some work when i caught a cold... and now busy with assignments.
  21 2012-10-07T13:37:03  <xiaq> a bit sorry, hopefully can code a bit later. :)
  22 2012-10-07T13:40:25  <ThomasWaldmann> xiaq: no problem, get well soon!
  23 2012-10-07T13:42:50  <sunu> ThomasWaldmann: http://codereview.appspot.com/6619053 updated
  24 2012-10-07T13:44:05  <sunu> ThomasWaldmann: btw I couldn't find mail_from defined anywhere ? So I had to add it to wikiconfig_gae.py manually.
  25 2012-10-07T13:44:49  <ThomasWaldmann> sunu: btw, you can use different comments/subjects for the patch sets, like what you really changed
  26 2012-10-07T13:45:00  *** ChanServ has joined #moin-dev
  27 2012-10-07T13:45:00  *** morgan.freenode.net sets mode: +o ChanServ
  28 2012-10-07T13:47:31  <sunu> ThomasWaldmann: Roger that :D
  29 2012-10-07T13:49:29  <ThomasWaldmann> sunu: btw, what moin function did you use to test email sending on gae?
  30 2012-10-07T13:50:44  <sunu> password recovery
  31 2012-10-07T13:50:48  <sunu> ThomasWaldmann:
  32 2012-10-07T13:55:33  <ThomasWaldmann> sunu: review done
  33 2012-10-07T13:56:58  <sunu> ThomasWaldmann: be back in a hour or so.. have to give a friend some help with his studies :)
  34 2012-10-07T15:23:41  <sunu> ThomasWaldmann: http://codereview.appspot.com/6619053 updated
  35 2012-10-07T15:26:13  <sunu> ThomasWaldmann: before commiting what about wikiconfig_gae.py ?
  36 2012-10-07T15:26:41  <sunu> should I leave the hardcoded mail_from there or remove it ?
  37 2012-10-07T15:27:13  <sunu> If I remove it mail_from is None on gae.
  38 2012-10-07T15:33:26  <ThomasWaldmann> sunu: you can't know the correct mail_from
  39 2012-10-07T15:33:55  <sunu> ThomasWaldmann: so what to do ?
  40 2012-10-07T15:34:12  <sunu> just commit the sendmail ?
  41 2012-10-07T15:38:50  <sunu> ThomasWaldmann: oh didn't see your comment on wikiconfig
  42 2012-10-07T15:39:02  <sunu> :D
  43 2012-10-07T15:43:59  <sunu> ThomasWaldmann: pull request sent.
  44 2012-10-07T15:44:06  <sunu> Next is what ?
  45 2012-10-07T15:52:42  <ThomasWaldmann> sunu: a bit more difficult would be the GAE user auth stuff
  46 2012-10-07T15:53:02  <ThomasWaldmann> it would need you getting familiar with how auth code works in moinmoin
  47 2012-10-07T15:58:19  <sunu> ThomasWaldmann: some pointers to read up ? I am not familiar with auth in general , but i want to do it :)
  48 2012-10-07T16:00:44  <ThomasWaldmann> MoinMoin.auth :)
  49 2012-10-07T16:01:34  <ThomasWaldmann> it's modular, so you could write a gae module for auth. some hints about how to do it are on the issue tracker issue for this
  50 2012-10-07T16:01:37  <ThomasWaldmann> sunu: ^
  51 2012-10-07T16:02:32  * sunu is reading up the code
  52 2012-10-07T16:09:29  *** breton_ is now known as breton
  53 2012-10-07T16:27:38  *** dwcramer has quit IRC
  54 2012-10-07T17:13:22  *** RogerHaase has joined #moin-dev
  55 2012-10-07T17:34:48  *** dwcramer has joined #moin-dev
  56 2012-10-07T18:13:59  <sunu> ThomasWaldmann: Not sure if I am going in the right path. Please have a look http://codereview.appspot.com/6628043
  57 2012-10-07T18:24:12  <RogerHaase> ThomasWaldmann:  try 2 to eliminate double wrapping of transcluded svg objects:  http://codereview.appspot.com/6613063/
  58 2012-10-07T18:31:24  <RogerHaase> dreimark: the server-side transclusion marking (aka wrapping) only adds a class and a data-href attribute to an element.  The dom manipulation to add overlay links is done by js.  So I don't think docbook_out and rst_out apply.
  59 2012-10-07T18:46:17  <ThomasWaldmann> sunu: review done
  60 2012-10-07T18:46:22  <ThomasWaldmann> hi RogerHaase
  61 2012-10-07T18:53:39  <ThomasWaldmann> RogerHaase: review done, need more info :)
  62 2012-10-07T18:56:21  <sunu> ThomasWaldmann: search_users returns a list of User objects ?
  63 2012-10-07T19:01:40  <ThomasWaldmann> sunu: list of user item revisions (IIRC)
  64 2012-10-07T19:07:39  <ThomasWaldmann> sunu: you maybe can take SOME (not all) ideas from ldap_login auth
  65 2012-10-07T19:07:56  <RogerHaase> ThomasWaldmann:  I will change the comment to say "other objects" rather than "svg objects" -- currently only external pages and svg images generate an object tag:  http://www.digitalrockart.org/moin2/TestAllTranscludableItems
  66 2012-10-07T19:10:31  <ThomasWaldmann> sunu: or GivenAuth
  67 2012-10-07T19:10:53  <sunu> ThomasWaldmann: ok :)
  68 2012-10-07T19:11:37  <ThomasWaldmann> RogerHaase: ah
  69 2012-10-07T19:12:53  <dreimark> RogerHaase: I wondered because of the mix in include.
  70 2012-10-07T19:13:12  <ThomasWaldmann> nice test page
  71 2012-10-07T19:13:20  <dreimark> but ok you are right that won't apply to others than html_out
  72 2012-10-07T19:14:14  * dreimark has on the testpage "External Page" with scrollbars
  73 2012-10-07T19:16:00  <dreimark> hmm instead of downloads we should have the html5 player in place for multimedia stuff compatible to an html5 player object
  74 2012-10-07T19:16:10  * dreimark files an issue
  75 2012-10-07T19:17:30  <dreimark> hmm, may be it is already done https://bitbucket.org/thomaswaldmann/moin-2.0/issue/190/wav-items-do-not-show-html5-audio-player
  76 2012-10-07T19:27:10  <RogerHaase> dreimark: a way to specify height and width on external pages and svg images is still missing.  If you view the test page with safari, it displays the svg image with scrollbars.
  77 2012-10-07T19:30:12  <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/273/translude-has-to-show-something
  78 2012-10-07T19:30:41  <dreimark> this is related also to the render method selection for transclusion issue
  79 2012-10-07T19:32:22  <ThomasWaldmann> issue 273 lacks details
  80 2012-10-07T19:35:25  <ThomasWaldmann> and it is mixing up suggestion(s) with bug(s)
  81 2012-10-07T19:37:19  <dreimark> ok, i split it
  82 2012-10-07T19:40:38  <sunu> ThomasWaldmann: http://codereview.appspot.com/6628043/ have a look :)
  83 2012-10-07T19:50:54  <ThomasWaldmann> sunu: done
  84 2012-10-07T20:10:47  <sunu> ThomasWaldmann: http://codereview.appspot.com/6628043 updated.
  85 2012-10-07T20:14:02  * sunu watched The WestIndies win the t20 cricket worldcup :)
  86 2012-10-07T20:22:46  <ThomasWaldmann> sunu: done. maybe try the code you made.
  87 2012-10-07T20:23:07  *** grzywacz has quit IRC
  88 2012-10-07T20:25:54  <sunu> ThomasWaldmann: How to enable the gae_auth module ?
  89 2012-10-07T20:27:38  <ThomasWaldmann> in wiki config, auth = [GaeAuth(), ]
  90 2012-10-07T20:35:17  <sunu> ThomasWaldmann: ok , going to bed now. Will try again tomorrow. gn.
  91 2012-10-07T20:41:12  <ThomasWaldmann> gn sunu
  92 2012-10-07T23:10:01  *** MattMaker has quit IRC
  93 2012-10-07T23:10:47  *** MattMaker has joined #moin-dev
  94 2012-10-07T23:15:47  *** MattMaker has quit IRC
  95 2012-10-07T23:26:11  *** MattMaker has joined #moin-dev
  96