1 2013-03-19T00:11:44 <ThomasWaldmann> put the test log output into a pastebin
2 2013-03-19T00:13:00 <ThomasWaldmann> sharky93: ^
3 2013-03-19T00:15:12 <sharky93> ThomasWaldmann, http://rn0.ru/show/Txje127hwzMbWQ0iqyoJ/
4 2013-03-19T00:18:22 <ThomasWaldmann> how did you run the tests?
5 2013-03-19T00:18:42 <ThomasWaldmann> can you paste the full test log?
6 2013-03-19T00:18:55 <sharky93> i used the pep8 package for python -> https://pypi.python.org/pypi/pep8
7 2013-03-19T00:19:46 <ThomasWaldmann> you just need to enter:
8 2013-03-19T00:19:49 <ThomasWaldmann> make test
9 2013-03-19T00:20:06 <ThomasWaldmann> in the toplevel dir of the moin2 repo workdir
10 2013-03-19T00:21:33 <sharky93> When i tried that, i get this error -> http://rn0.ru/show/gTUt4LcgZ1K99vbCRl3A/ . I tried it in the toplevel dir.
11 2013-03-19T00:23:55 <ThomasWaldmann> did you install moin using quickinstall? (see docs)?
12 2013-03-19T00:25:48 <sharky93> yeah, i used quickinstall
13 2013-03-19T00:26:58 <ThomasWaldmann> ok, did you enter the virtual env before running make test?
14 2013-03-19T00:29:27 <sharky93> ah!, i thought i'm in a virtual env. but had switched to a new tab then.
15 2013-03-19T00:31:42 <sharky93> ThomasWaldmann, even on doing 'make test' now, i get this error -> http://rn0.ru/show/mDAShMjsNYFrglRwhkmj/
16 2013-03-19T00:31:59 <sharky93> the complete log can be found at -> http://rn0.ru/show/dWQXdXr8op35b905UtG6/
17 2013-03-19T00:33:05 <sharky93> ThomasWaldmann, btw, after fixing the tabs, i uploaded the bug fix using the same codereview id -> @ https://codereview.appspot.com/7897043
18 2013-03-19T00:33:26 <ThomasWaldmann> why does it refer to build/lib/...?
19 2013-03-19T00:35:07 <sharky93> no idea, did not change anything there.
20 2013-03-19T00:35:38 <sharky93> should i try a reinstall ?
21 2013-03-19T00:35:49 <ThomasWaldmann> yeah, just follow the docs
22 2013-03-19T00:36:03 <ThomasWaldmann> never seen that issue before
23 2013-03-19T00:37:25 <sharky93> i'll try the 'make test' once after a fresh install.
24 2013-03-19T00:39:35 <ThomasWaldmann> you can keep the dlc
25 2013-03-19T00:39:49 <ThomasWaldmann> so you don't to download all again
26 2013-03-19T00:39:57 <ThomasWaldmann> +need
27 2013-03-19T00:43:12 <sharky93> oh, i already had downloaded by the time i saw the message. Ran 'make test', the final result -> http://rn0.ru/show/oWhDucJwxwUbzJPEbTMJ/ .. on a fresh install
28 2013-03-19T00:43:51 <ThomasWaldmann> ok, now look at the failures
29 2013-03-19T00:46:04 <sharky93> the failure -> http://rn0.ru/show/KQTWoHIk5jGbZLD2t2Oy/ . can i do anything about it ? since it is a completely fresh install, ideally there should be 0 failures ?
30 2013-03-19T00:48:19 <ThomasWaldmann> interesting. i thought i had all of these fixed.
31 2013-03-19T00:48:47 <ThomasWaldmann> but that's not your fault, does the tested source have your changes?
32 2013-03-19T00:57:03 <sharky93> yeah, i tested and uploaded @ https://codereview.appspot.com/7897043
33 2013-03-19T01:02:59 <ThomasWaldmann> review done
34 2013-03-19T01:03:52 <ThomasWaldmann> have a look at the view method for the root url to see what it does
35 2013-03-19T02:35:00 <sharky93> ThomasWaldmann, ah, okay, i'll look it up, can this bug be assigned to me ?
36 2013-03-19T05:28:23 *** vaishaks
37 2013-03-19T05:31:37 *** sharky93
38 2013-03-19T06:36:46 *** vaishaks
39 2013-03-19T06:41:36 *** spy
40 2013-03-19T06:41:45 *** ashutosh1461
41 2013-03-19T06:42:01 *** spy
42 2013-03-19T06:45:51 *** ashutosh1461
43 2013-03-19T06:48:33 *** sharky93
44 2013-03-19T06:58:49 *** sharky93
45 2013-03-19T07:09:58 *** ronny_
46 2013-03-19T07:23:28 *** ashutosh1461
47 2013-03-19T07:26:28 <ashutosh1461> what is the RegistryItem class for ? https://bitbucket.org/thomaswaldmann/moin-2.0/src/4307c3e76076b9d8accc8ed13b5ac884a8f471a0/MoinMoin/items/__init__.py?at=default#cl-65
48 2013-03-19T07:27:59 *** Guest23551
49 2013-03-19T08:30:36 *** Pods
50 2013-03-19T08:51:25 <Pods> Have been checking on the DOM converters problem, the implementation of creation of unicode URIs for wiki links. This should also provide access to the query parameters seems intuitive with python's urllib.
51 2013-03-19T08:51:59 <Pods> I am not sure if Support for per-instance converters refer to the same as the concept used for WPF
52 2013-03-19T08:52:10 <Pods> ThomasWaldmann ^
53 2013-03-19T08:56:45 *** greg_f
54 2013-03-19T09:06:15 <Pods> Assuming these converters refer to the input to DOM converters and then DOM to output converters
55 2013-03-19T09:06:44 <Pods> for each instance of the entities (URLs? ) we are converting.
56 2013-03-19T09:08:38 *** greg_f
57 2013-03-19T09:10:42 *** greg_f
58 2013-03-19T09:16:38 <dreimark> waldi: ^
59 2013-03-19T09:24:13 <dreimark> hmm, currently thinking about if we want an "external link item"
60 2013-03-19T09:24:37 <Pods> dreimark : if you could guide me , can we start taking up projects already??
61 2013-03-19T09:24:40 <dreimark> which is used to describe and define the links
62 2013-03-19T09:25:19 <Pods> could you point me to the source repo for it??
63 2013-03-19T09:25:20 <dreimark> Pods: for dom convertor better ask ThomasWaldmann or waldi
64 2013-03-19T09:25:38 <Pods> right :)
65 2013-03-19T09:26:09 <dreimark> https://bitbucket.org/thomaswaldmann/emeraldtree
66 2013-03-19T09:27:37 <dreimark> Pods: emeraldtree is internally used to build the DOM XML Tree
67 2013-03-19T09:27:49 <Pods> okay.
68 2013-03-19T09:28:08 <Pods> Also, who should i preferably approach for the network API project
69 2013-03-19T09:28:08 <Pods> ??
70 2013-03-19T09:32:46 <dreimark> have you reproduced the issue your mentioned?
71 2013-03-19T09:33:41 <dreimark> identify where it gets the data
72 2013-03-19T09:34:14 <dreimark> Pods: are you working on a bug ?
73 2013-03-19T09:34:30 <dreimark> can you give me the Id?
74 2013-03-19T09:34:34 <waldi> Pods: url parameters are an opaque string from the URI/IRI spec. you can only parse then on a higher layer
75 2013-03-19T09:36:53 <Pods> I am basically brainstorming implementation ideas for the project ideas invloving "Validation of Wiki Contents" ; "Improve DOM converters" and "Remote editor wrapper" as of now
76 2013-03-19T09:37:21 <Pods> And also trying to se if the indicated TODO sections in the source codes i am browsing interest me, hence the queries.
77 2013-03-19T09:37:47 <Pods> Any suggestion as to which bug I could look at from the perspective of taking up any one of these projects in gsoc
78 2013-03-19T09:38:51 <Pods> ^waldi , dreimark
79 2013-03-19T09:40:55 *** sharky93
80 2013-03-19T09:48:19 <ashutosh1461> Hey dreimark , i have solved bug#346 can you check it out ? https://codereview.appspot.com/7856046/
81 2013-03-19T10:02:01 *** vaishaks
82 2013-03-19T10:11:36 <dreimark> ashutosh1461: done
83 2013-03-19T10:13:25 *** vaishaks
84 2013-03-19T10:14:24 <Pods> dreimark: have been browsing through the emraldtree repo, not clear as to where can i trace the bugs for the same and also regarding the build instructions. Any link for the same??
85 2013-03-19T10:18:19 *** vpv_
86 2013-03-19T10:20:16 *** vpv
87 2013-03-19T10:20:16 *** Pods
88 2013-03-19T10:20:18 <sharky93> ThomasWaldmann, with reference to -> https://codereview.appspot.com/7897043/ , i do not understand your comment -> "the wiki is not required to run at the root url ("/").".. is this not what is meant by -> http://goo.gl/h0bkh
89 2013-03-19T10:20:19 *** Pods
90 2013-03-19T10:20:20 *** vpv_
91 2013-03-19T10:20:20 *** vpv_
92 2013-03-19T10:21:12 <ThomasWaldmann> sharky93: that's the view method for the root url. it is not required to mount the wsgi app to servername/ though, it could be also mounted at servername/wiki/ for example and that method still would get called.
93 2013-03-19T10:30:21 *** Pods_
94 2013-03-19T10:31:00 *** sharky93
95 2013-03-19T10:31:16 *** ashutosh1461
96 2013-03-19T10:31:19 *** Pods
97 2013-03-19T10:31:35 *** Pods_
98 2013-03-19T10:41:18 *** Pods
99 2013-03-19T10:43:07 *** sharky93
100 2013-03-19T10:43:47 *** ashutosh1461
101 2013-03-19T10:47:22 <ashutosh1461> dreimark, what do you mean by your comment https://codereview.appspot.com/7856046/diff/1/MoinMoin/items/__init__.py#oldcode369 ?
102 2013-03-19T10:57:34 *** trinity_28
103 2013-03-19T11:11:29 *** haseeb
104 2013-03-19T11:19:24 *** trinity_28
105 2013-03-19T11:21:54 *** trinity_28
106 2013-03-19T11:22:37 <sunu> ThomasWaldmann: Please review https://codereview.appspot.com/7512044
107 2013-03-19T11:38:38 <ThomasWaldmann> sunu: done
108 2013-03-19T11:45:21 <sharky93> ThomasWaldmann, how do i modify where to mount the wsgi application ? just to test.
109 2013-03-19T11:45:45 <dreimark> ashutosh1461: if you run make test. you see tests running, there is a test_rename
110 2013-03-19T11:45:51 <sharky93> ThomasWaldmann, suppose you mount it at 'servername/wiki/' , the same method for root will still get called and meanwhile the value for "url" would also be '/' and since everything is relative to the new mount point, it should not matter.
111 2013-03-19T11:46:09 <dreimark> ashutosh1461: add a test which fails now then try with your code
112 2013-03-19T11:46:52 <dreimark> sharky93: you do this on the wsgi deployment level
113 2013-03-19T11:48:19 <dreimark> sharky93: http://flask.pocoo.org/docs/deploying/mod_wsgi/#configuring-apache
114 2013-03-19T11:48:42 <dreimark> WSGIScriptAlias / can be also WSGIScriptAlias /SomeThingElse/
115 2013-03-19T11:51:42 <ThomasWaldmann> sharky93: you maybe can not simply test that with the standalone server, but the scenario is not unusual when deploying on a real webserver like apache
116 2013-03-19T11:52:38 <ThomasWaldmann> and of course the url is not "/", but "/wiki/" in that case
117 2013-03-19T11:54:08 <sharky93> ThomasWaldmann, then maybe we can use a global variable for the mount point ? how else can we refer that
118 2013-03-19T11:57:16 <sharky93> ThomasWaldmann, in that case, why should this work ? -> http://goo.gl/h0bkh .. flask would call that handler only when the URL is routed as "/" ?
119 2013-03-19T11:57:46 <ThomasWaldmann> no, flask works as it should
120 2013-03-19T11:58:18 <ThomasWaldmann> (all routes are relative to where the wsgi app and the blueprint are mounted)
121 2013-03-19T11:59:19 <ThomasWaldmann> but maybe you notice meanwhile that checking the URL is a bad idea
122 2013-03-19T12:09:34 <sharky93> ThomasWaldmann, yeah, but the other links will work on the same principle -> https://bitbucket.org/thomaswaldmann/moin-2.0/src/4307c3e76076/MoinMoin/themes/__init__.py?at=default#cl-204
123 2013-03-19T12:10:51 <sharky93> ThomasWaldmann, is storing the mount point a bad idea ? since that way we could use URL's which should not go wrong. Since any URL will be of the form -> "mountpoint/relativeforflask"
124 2013-03-19T12:28:45 *** ronny_
125 2013-03-19T12:32:13 <ThomasWaldmann> don't check the url
126 2013-03-19T12:34:45 *** dave_largo
127 2013-03-19T12:39:35 <ThomasWaldmann> or rather: don't check the url that way
128 2013-03-19T12:40:25 <sharky93> ThomasWaldmann, what could be another way ?
129 2013-03-19T12:45:52 *** ronny_
130 2013-03-19T12:47:28 <ThomasWaldmann> sharky93: look at how urls are usually generated by moin
131 2013-03-19T12:48:22 * ThomasWaldmann bbl
132 2013-03-19T12:59:52 <sunu> ThomasWaldmann: https://codereview.appspot.com/7512044 updated.
133 2013-03-19T13:14:48 <Pods> dreimark : In regard to the discussions we had in the morning about the project regarding Network APIs and Remote editor wrapper, are there any significant bugs you would encourange the gsoc applicants to tackle
134 2013-03-19T13:15:01 <Pods> Since the pausity of time would not allow random code tweaks
135 2013-03-19T13:23:19 <dreimark> Pods: for remote editor you can look at editmoin. something similiar may be not only limited to text items is interesting
136 2013-03-19T13:23:55 <Pods> okay :) thanks
137 2013-03-19T13:24:36 <dreimark> editmoin works with moin-1.x
138 2013-03-19T13:24:53 <dreimark> some other progrms have python APIs e.g. inkscape
139 2013-03-19T13:25:07 <dreimark> so it may be used to edit svg etc. items
140 2013-03-19T13:26:02 <sharky93> ThomasWaldmann, I added a print statement after this line -> http://goo.gl/yD6KW , the extra output i got is this -> http://rn0.ru/show/zej2qVAPvSqtYfmofwkw/ , note the url's in the tuple, for any link are relative to the mountpoint. "/". Now this line -> http://goo.gl/ZJDYH generates a hyperlink with URL as "http://localhost:8080/Home" . So isn't the mountpoint being taken care of already by flask ?
141 2013-03-19T13:26:05 <dreimark> without networking API but local you can look on how the serialisation works
142 2013-03-19T13:26:42 <Pods> any links to any issues i might want to look into ?? the source i mean wherein i could start contribution??
143 2013-03-19T13:26:55 *** sharky93
144 2013-03-19T13:27:13 <dreimark> and https://bitbucket.org/thomaswaldmann/moin-2.0/src/4307c3e76076b9d8accc8ed13b5ac884a8f471a0/MoinMoin/script/maint/modify_item.py?at=default
145 2013-03-19T13:27:52 <Pods> great bbl after checking this out :)
146 2013-03-19T13:27:56 <Pods> thanks for your help
147 2013-03-19T13:28:21 <dreimark> as it is a missing API i am not sure if we have issues for it but will examine this
148 2013-03-19T13:29:28 <dreimark> an external editor must be able to send META and DATA
149 2013-03-19T13:29:44 <dreimark> or keep some META
150 2013-03-19T13:29:50 <Pods> right now , it seems to facilitate both right??
151 2013-03-19T13:30:02 <dreimark> Pods: yes, locally
152 2013-03-19T13:30:34 <Pods> you mean across (say) peers it wont do that??
153 2013-03-19T13:30:45 <dreimark> this is only usefull if you are on the server (this way)
154 2013-03-19T13:31:13 <dreimark> a remote editor likly will be on a different platform
155 2013-03-19T13:31:49 <dreimark> http://labix.org/editmoin
156 2013-03-19T13:32:18 <Pods> okay i get it now
157 2013-03-19T13:32:35 <dreimark> for example this can be used with vim
158 2013-03-19T13:33:13 <Pods> yes, do we need to extend its support for usage
159 2013-03-19T13:33:23 <Pods> looks like the latest moin doesnt work over http
160 2013-03-19T13:34:50 <dreimark> rephrase last sentence
161 2013-03-19T13:35:15 <dreimark> or do you mean https://moinmo.in ?
162 2013-03-19T13:35:49 <Pods> If i am directly running the command (say) "editmoin http://moinmoin.wikiwikiweb.de/TestPage"
163 2013-03-19T13:35:59 <dreimark> Pods: this is outdated
164 2013-03-19T13:36:32 <dreimark> moinmoin.wikiwikiweb.de is very old and not the location of moinmo.in
165 2013-03-19T13:36:52 <Pods> looks like we have something to tweak in the documentation too then :)
166 2013-03-19T13:36:55 <dreimark> it was in old day before we had the .in domain used
167 2013-03-19T13:37:05 <dreimark> Pods: which documentation?
168 2013-03-19T13:37:11 <Pods> http://labix.org/editmoin this page illustrates the usahe from this command
169 2013-03-19T13:37:35 <Pods> and hence there is a bug also reported saying "error: body information not found" in the bug tracker issue of this page
170 2013-03-19T13:37:38 <dreimark> editmoin is third party
171 2013-03-19T13:37:41 <Pods> *usage
172 2013-03-19T13:38:15 <Pods> I see
173 2013-03-19T13:38:55 <dreimark> editmoin http://moinmo.in/WikiSandBox
174 2013-03-19T13:39:08 <dreimark> after pip install editmoin into a virtualenv
175 2013-03-19T13:40:33 <Pods> okay yes, this seems to work ok
176 2013-03-19T13:42:40 <Pods> Have to go now , when could i catch up nect ?? In a couple of hours maybe ??
177 2013-03-19T13:42:43 <Pods> *next
178 2013-03-19T13:46:31 *** sharky93
179 2013-03-19T13:49:17 *** RogerHaase
180 2013-03-19T13:58:23 *** sharky93
181 2013-03-19T13:58:57 *** sharky93
182 2013-03-19T14:17:43 <dreimark> Pods: should work out, but I also have today a pycon de meeting
183 2013-03-19T14:41:49 *** haseeb
184 2013-03-19T15:21:41 *** dave_largo
185 2013-03-19T15:25:32 *** ronny_
186 2013-03-19T15:27:59 *** dave_largo
187 2013-03-19T15:42:55 *** ronny
188 2013-03-19T15:42:56 *** ronny
189 2013-03-19T15:44:22 <sunu> ThomasWaldmann: https://codereview.appspot.com/7512044 updated.
190 2013-03-19T16:25:04 <ashutosh1461> dreimark, i am facing a import mismatch error on running the test command, https://bitbucket.org/ashu1461/code/src/837bccc1a94ad8e660fa1ceca6de844a91b01d36/error.png
191 2013-03-19T16:25:24 *** Pods_
192 2013-03-19T16:25:29 *** Pods
193 2013-03-19T16:25:43 <Pods_> dreimark : ping
194 2013-03-19T16:25:51 *** Pods_
195 2013-03-19T16:25:56 *** POds
196 2013-03-19T16:40:37 *** bruno_
197 2013-03-19T16:42:30 *** sunu
198 2013-03-19T16:42:30 *** waldi
199 2013-03-19T16:42:36 *** sunu
200 2013-03-19T16:48:12 <dreimark> ashutosh1461: check that you are in your env, and also use a text paster if possible
201 2013-03-19T16:48:22 *** bruno_
202 2013-03-19T16:48:29 <dreimark> Pods: i have to travel now, was in a meeting until now
203 2013-03-19T16:48:39 *** waldi
204 2013-03-19T16:48:39 *** waldi
205 2013-03-19T16:48:45 <dreimark> bbl
206 2013-03-19T16:48:56 <Pods> sure can catch up when you are back
207 2013-03-19T16:51:46 *** haseeb
208 2013-03-19T16:51:46 *** haseeb
209 2013-03-19T16:55:29 *** Pods
210 2013-03-19T17:10:45 *** sonakshi
211 2013-03-19T17:10:51 *** vaishaks
212 2013-03-19T17:29:46 *** haseeb
213 2013-03-19T17:31:20 <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/7856046/#ps8001 , Also as dreimark pointed out the authentication problem, We already check whether the user has permissions or not before calling the item.rename function.
214 2013-03-19T17:48:46 *** rihnapstor
215 2013-03-19T17:49:54 *** greg_f
216 2013-03-19T17:51:00 *** rihnapstor
217 2013-03-19T17:51:00 *** rihnapstor
218 2013-03-19T17:54:56 * dreimark greets from cologne
219 2013-03-19T17:56:06 <ThomasWaldmann> dreimark: greetings to the other pythonistas!
220 2013-03-19T18:02:06 * dreimark done - greetings back
221 2013-03-19T18:05:44 *** haseeb
222 2013-03-19T18:11:12 <sunu> ThomasWaldmann: https://codereview.appspot.com/7512044 ok to commit now ?
223 2013-03-19T18:12:43 <ThomasWaldmann> did you run make test?
224 2013-03-19T18:13:57 <ThomasWaldmann> btw, did you test your code locally / interactively also (not on gae / not on the gae sdk server), just using whoosh with local file index?
225 2013-03-19T18:14:37 <ashutosh1461> :q
226 2013-03-19T18:15:00 * ThomasWaldmann thinks we should merge your branch soon, but I am hesitating due to the "unstable" whoosh version
227 2013-03-19T18:16:01 <sunu> My env is broken. I should get a fresh env perhaps.
228 2013-03-19T18:16:43 <sunu> ThomasWaldmann: gae and default are still using different versions of whoosh?
229 2013-03-19T18:17:36 <ThomasWaldmann> i think so. see setup.py
230 2013-03-19T18:21:20 <rihnapstor> moin all :)
231 2013-03-19T18:22:53 <sunu> whoosh>=2.5.0 for gae and whoosh>=2.4.0 for default. So why not whoosh>=2.5.0 for both branches ?
232 2013-03-19T18:23:01 <sunu> ThomasWaldmann: ^^
233 2013-03-19T18:23:20 <ThomasWaldmann> i delayed it because whoosh 2.5 is not released at all
234 2013-03-19T18:23:30 <ThomasWaldmann> for 2.4, there is at least an old release
235 2013-03-19T18:24:33 <ThomasWaldmann> hopefully matt is improving on release managment. it should get maintenance releases more often and also real releases.
236 2013-03-19T18:25:20 <ThomasWaldmann> (and the maintenance releases should be strictly bug fixes, nothing else)
237 2013-03-19T18:25:37 <sunu> So after 2.5 is released we can merge ?
238 2013-03-19T18:26:04 <ThomasWaldmann> well, we can merge any time we think we can deal with it.
239 2013-03-19T18:26:46 <ThomasWaldmann> maybe I'll do some whoosh 2.5 testing today evening. fed up with waiting somehow. :D
240 2013-03-19T18:27:21 <sunu> great :D
241 2013-03-19T18:27:26 <ThomasWaldmann> also, i accidentally committed stuff to gae branch that was intended for default branch, so merging would solve that, too.
242 2013-03-19T18:28:23 <sunu> I'm currently getting 3 failures.
243 2013-03-19T18:28:45 <sunu> 3 failed, 610 passed, 353 skipped in 45.41 seconds
244 2013-03-19T18:31:26 <sunu> 2 in convertors, 1 in blog. So should I commit the support stuff now or is there anything else to improve ?
245 2013-03-19T18:31:33 <sunu> ThomasWaldmann: ^
246 2013-03-19T18:32:16 <ThomasWaldmann> 1 in blog is expected, same in default branch
247 2013-03-19T18:32:34 <ThomasWaldmann> 2 in converters: maybe old stuff, I suppose you didn't touch them
248 2013-03-19T18:32:42 <ThomasWaldmann> commit it for now
249 2013-03-19T18:32:55 * ThomasWaldmann brb
250 2013-03-19T18:32:56 <sunu> Ok.
251 2013-03-19T18:33:34 *** Pods
252 2013-03-19T18:34:33 *** ronny
253 2013-03-19T18:36:53 *** rihnapstor
254 2013-03-19T18:37:59 *** Pods
255 2013-03-19T18:41:50 *** rihnapstor
256 2013-03-19T18:41:59 <ashutosh1461> dreimark, still getting a mismatch error, and i updated the code, https://codereview.appspot.com/7856046/#ps8001
257 2013-03-19T18:42:08 *** sonakshi
258 2013-03-19T18:45:54 *** rihnapstor
259 2013-03-19T18:45:54 *** rihnapstor
260 2013-03-19T18:47:32 *** ronny
261 2013-03-19T18:50:19 <sunu> ThomasWaldmann: PR sent. Btw I have updated my proposal page a bit. Have a look if you would. http://moinmo.in/TarashishMishra/GSOC-2013
262 2013-03-19T18:50:27 <sunu> dreimark: ^^
263 2013-03-19T18:56:11 *** Pods
264 2013-03-19T19:11:25 <sunu> ThomasWaldmann: Didn't see your last comment on code review. I have to undo the last commit now I guess :D
265 2013-03-19T19:16:50 *** Pods
266 2013-03-19T19:19:58 <RogerHaase> ashutosh1461: added a comment to 7856046
267 2013-03-19T19:20:12 *** Pods_
268 2013-03-19T19:21:56 *** Pods_
269 2013-03-19T19:31:06 <rihnapstor> its like pick the issues from moin bitbucket repo. and once solved ,or done some changes ,using the upload.py submit a patch to codereview tool.this is how it works ?
270 2013-03-19T19:33:02 <ThomasWaldmann> sunu: merged!
271 2013-03-19T19:33:17 <sunu> rihnapstor: yup
272 2013-03-19T19:33:30 <sunu> ThomasWaldmann: Thanks :)
273 2013-03-19T19:33:31 <ThomasWaldmann> rihnapstor: and tell on the issue tracker that you work on it
274 2013-03-19T19:34:10 <ThomasWaldmann> and, do the first review yourself. hg diff, slowly ready it, look for suspicious stuff, run make test, ...
275 2013-03-19T19:34:39 <sharky93> ThomasWaldmann, Issue updated. URL: http://codereview.appspot.com/7897043
276 2013-03-19T19:38:03 <rihnapstor> yse ThomasWaldmann ,i saw sunu pull request just couple of minutes back :)
277 2013-03-19T19:41:48 * ThomasWaldmann runs test in default branch with whoosh 2.5
278 2013-03-19T19:52:26 * sunu goes to bed. Good night all
279 2013-03-19T19:56:46 <ThomasWaldmann> gn sunu
280 2013-03-19T19:56:52 <ThomasWaldmann> sharky93: review done
281 2013-03-19T20:02:09 <ThomasWaldmann> ok, tests work on whoosh 2.5 after a small import fix
282 2013-03-19T20:08:39 <sharky93> ThomasWaldmann, updated Reply -> https://codereview.appspot.com/7897043/diff/16001/MoinMoin/themes/__init__.py#newcode214
283 2013-03-19T20:12:39 <ThomasWaldmann> done
284 2013-03-19T20:16:15 <ashutosh1461> RogerHaase, updated the error message, whats next ?
285 2013-03-19T20:17:04 * ThomasWaldmann switched the default branch to whoosh 2.5. requires pip install -e . on an existing environment (and maybe index rebuild).
286 2013-03-19T20:18:42 <RogerHaase> ashutosh1461: upload.py?
287 2013-03-19T20:21:39 <ashutosh1461> RogerHaase, https://codereview.appspot.com/7856046/#ps11001
288 2013-03-19T20:28:31 <RogerHaase> ashutosh1461: can you run tests yet? I think you have a pep8 error ...),"err... needs space character after ,
289 2013-03-19T20:33:48 <ashutosh1461> RogerHaase, aah yes, silly mistakes. fixed it. yes,i tried to run the test but it gave me a import mismatch error https://bitbucket.org/ashu1461/code/src/837bccc1a94ad8e660fa1ceca6de844a91b01d36/error.png
290 2013-03-19T20:37:04 *** spy_
291 2013-03-19T20:43:38 <RogerHaase> ashutosh1461: how do you run that? did you do a "pip install pytest" to your env?
292 2013-03-19T20:48:03 <ashutosh1461> RogerHaase, i ran make test after activating the virtual env, yes pytest is already installed.
293 2013-03-19T20:53:25 <rihnapstor> RogerHaase: my local moin setup restrict admin acces how can i solve issue #347 ?
294 2013-03-19T20:56:47 <RogerHaase> rihnapstor: read wikiconfig.py and make yourself a superuser by adding " acl_functions = u'+MyName:superuser'" to wikiconfig_editme.py
295 2013-03-19T20:57:43 <rihnapstor> ok thanks i will just do that.
296 2013-03-19T20:59:40 <sharky93> ThomasWaldmann, i've now been able to reduce the code duplication. In reference to -> https://codereview.appspot.com/7897043, should i add one more patch now
297 2013-03-19T21:01:05 <RogerHaase> ashtosh1461: I just rebuilt my env at tip, cannot reproduce the problem on Linux Mint, python 2.7.3. Try deleting your env and doing another ./quickinstall
298 2013-03-19T21:06:48 <RogerHaase> ashutosh1461: ^^
299 2013-03-19T21:08:19 <ashutosh1461> RogerHaase, yes i am doing that.
300 2013-03-19T21:10:55 *** haseeb
301 2013-03-19T21:11:34 *** dave_largo
302 2013-03-19T21:13:24 *** Pods
303 2013-03-19T21:13:27 *** vpv_
304 2013-03-19T21:13:28 * ThomasWaldmann merges gae into default
305 2013-03-19T21:13:43 <RogerHaase> ashutosh1461: do you have a build dir? https://bitbucket.org/thomaswaldmann/moin-2.0/issue/116/pytest-script-raises-importmismatcherror
306 2013-03-19T21:17:48 <ashutosh1461> RogerHaase, reinstalling did not work and build directory is there.
307 2013-03-19T21:18:26 <RogerHaase> rihnapstor: the item_root = "FrontPage" also gets added to wikiconfig_editme.py. You need to be superuser to see admin functions.
308 2013-03-19T21:18:54 <RogerHaase> ashutosh1461: try deleting it
309 2013-03-19T21:20:25 <ashutosh1461> yes, it worked :D , what was the problem ?
310 2013-03-19T21:25:13 <RogerHaase> ashutosh1461: per issue 116, did you do something odd with make? build should not be there. Anyway run tests, also pep8 tests, ask tw for review
311 2013-03-19T21:27:10 <rihnapstor> RogerHaase: should i unicode the temroot value like itemroot = u'FrontPage' ?
312 2013-03-19T21:27:41 <RogerHaase> probably, my error
313 2013-03-19T21:29:50 <sharky93> ThomasWaldmann, Issue updated. URL: http://codereview.appspot.com/7897043.
314 2013-03-19T21:30:39 <ashutosh1461> RogerHaase, No, I just followed the normal installation instructions and Thanks :D !
315 2013-03-19T21:33:57 <rihnapstor> RogerHaase: thanks ,edited ,ca use just verify my edits here http://postimage.org/image/4e3755vzh/.
316 2013-03-19T21:35:46 <RogerHaase> askutosh1461: if quickinstall leaves a build dir, then maybe you found a new bug. Is there something unusual about your system?
317 2013-03-19T21:37:22 <RogerHaase> rihnapstor: looks OK, try it
318 2013-03-19T21:37:55 <rihnapstor> yeah
319 2013-03-19T21:39:50 <rihnapstor> worked :D thanks RogerHaase :)
320 2013-03-19T21:44:17 <ashutosh1461> RogerHaase, i use ubuntu 12.04 and everything else is working fine.
321 2013-03-19T21:45:56 <rihnapstor> linux mint 14 cinnamon here :)
322 2013-03-19T21:46:00 <ThomasWaldmann> sunu: does make test work for you?
323 2013-03-19T21:46:07 <ThomasWaldmann> (on gae branch)
324 2013-03-19T21:51:07 <RogerHaase> ashutosh1461: try ./quickinstall > quickinstall.txt ; see if the build directory returns, post quickinstall.txt if it does
325 2013-03-19T21:56:24 *** AndChat|119664
326 2013-03-19T21:58:20 <ashutosh1461> RogerHaase, no build directory this time ?
327 2013-03-19T22:01:18 *** sharky93
328 2013-03-19T22:12:05 <RogerHaase> ashutosh1461: Try making another clone to see if you can recreate the problem. If you cannot recreate the problem, leave a comment on #116 stating you had the problem, but cannot reproduce.
329 2013-03-19T22:14:07 <RogerHaase> ashutosh1461: use ./quickinstall > quickinstall.txt for new clone
330 2013-03-19T22:14:13 <RogerHaase> gtg
331 2013-03-19T22:14:18 *** RogerHaase
332 2013-03-19T22:20:32 <ashutosh1461> bye, gn everyone :) !
333 2013-03-19T22:20:34 *** ashutosh1461
334 2013-03-19T22:22:42 *** rihnapstor
335 2013-03-19T23:06:28 *** ronny
336
