1 2013-03-24T00:06:27 *** eSyr
2 2013-03-24T00:14:24 *** haseeb_
3 2013-03-24T00:31:02 *** eSyr
4 2013-03-24T01:03:51 *** eSyr
5 2013-03-24T01:13:12 *** eSyr
6 2013-03-24T01:38:52 *** eSyr
7 2013-03-24T01:40:31 *** eSyr
8 2013-03-24T02:25:04 *** eSyr
9 2013-03-24T03:00:45 *** eSyr
10 2013-03-24T03:20:31 *** eSyr
11 2013-03-24T03:39:33 *** eSyr
12 2013-03-24T05:13:01 *** eSyr
13 2013-03-24T05:21:22 *** eSyr
14 2013-03-24T05:52:42 *** rihnapstor
15 2013-03-24T06:19:10 *** rihnapstor
16 2013-03-24T06:23:28 *** rihnapstor
17 2013-03-24T06:36:51 <sunu> ThomasWaldmann: I did look at the failures especially those converter ones. If I go step by step with pdb everything goes fine and the tests pass, but without pdb it fails. I can't really figure out what is going wrong.
18 2013-03-24T06:38:49 <sunu> The rendered_data is exactly what it should be while i check with pdb, but while running the test without pdb the <img> tag goes missing.
19 2013-03-24T06:39:58 <sunu> RogerHaase: can you take a look at it ^^
20 2013-03-24T06:45:37 *** rihnapstor
21 2013-03-24T08:10:46 *** ashutosh1461
22 2013-03-24T08:14:12 *** haseeb_
23 2013-03-24T09:05:47 *** haseeb_
24 2013-03-24T09:42:49 *** ashutosh1461
25 2013-03-24T11:57:13 *** ashutosh1461
26 2013-03-24T12:38:39 <ThomasWaldmann> moin
27 2013-03-24T12:39:00 <ThomasWaldmann> was there a codereview for "inducer"'s pull request?
28 2013-03-24T12:39:50 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/143/adapt-import19-for-namespaces/diff
29 2013-03-24T12:40:30 <ThomasWaldmann> sunu: hmm, that sounds strange
30 2013-03-24T13:16:01 * ThomasWaldmann did a test run with py 2.7.4rc1 and gae branch, that converter test fail also happens there (and also all the other test fails)
31 2013-03-24T13:23:05 <sunu> moin ThomasWaldmann
32 2013-03-24T13:24:30 <sunu> I commented out all the other tests in test_include.py except the 2 failing tests, ran the tests. The first one passed.
33 2013-03-24T13:36:51 <ThomasWaldmann> you can also selectively runs tests by using py.test -k somekeyword testfile.py
34 2013-03-24T13:41:17 * ThomasWaldmann merges default -> gae again
35 2013-03-24T13:46:49 *** sonakshi
36 2013-03-24T13:47:29 <sunu> =================== 7 tests deselected by '-ktest_InlineIncludeImage' ====================
37 2013-03-24T13:47:32 <sunu> ========================= 1 passed, 7 deselected in 0.44 seconds =========================
38 2013-03-24T13:50:41 <ThomasWaldmann> interesting. but the other one still fails when run isolatedly
39 2013-03-24T13:51:23 <sunu> ThomasWaldmann: yes
40 2013-03-24T13:56:38 <sunu> the otherone fails inside pdb too.
41 2013-03-24T14:01:43 <sunu> More interestingly py.test -k test_IncludeAsLinkAlternate MoinMoin/converter/_tests/test_include.py fails in default branch too.
42 2013-03-24T14:07:20 <ThomasWaldmann> sunu: merge done, 1 fail less (the pep8 one)
43 2013-03-24T14:07:54 <ThomasWaldmann> sunu: shall we split debugging the include stuff, which one do you want?
44 2013-03-24T14:16:11 *** sonakshi
45 2013-03-24T14:18:51 <sunu> ThomasWaldmann: the first one
46 2013-03-24T14:19:03 * sunu brb
47 2013-03-24T14:27:14 <ashutosh1461> ThomasWaldmann, please review the final patch i guess, https://codereview.appspot.com/7862046 :)
48 2013-03-24T14:32:05 <ThomasWaldmann> ashutosh1461: why is that a new review id?
49 2013-03-24T14:36:27 <ThomasWaldmann> and btw, you never need to mention "final" beforehands
50 2013-03-24T14:49:07 *** dwcramer
51 2013-03-24T14:52:11 <ashutosh1461> ThomasWaldmann, by mistake yesterday i created a new id, here is the link to the previous one, https://codereview.appspot.com/7856046/ :)
52 2013-03-24T15:03:56 <ThomasWaldmann> please update the previous review with the current code
53 2013-03-24T15:04:57 <ashutosh1461> updated :) #patch13
54 2013-03-24T15:06:43 *** greg_f
55 2013-03-24T15:10:46 <ThomasWaldmann> ashutosh1461: done
56 2013-03-24T15:13:45 *** Mango_Man
57 2013-03-24T15:17:51 <ThomasWaldmann> sunu: test_IncludeAsLinkAlternate one of the issues with that test is that it is not independant of the other tests as it doesn't create the items it is referring to
58 2013-03-24T15:27:13 *** Mango_Man
59 2013-03-24T15:31:00 * ThomasWaldmann fixed that and pushed
60 2013-03-24T15:34:30 <ThomasWaldmann> hah, saving an empty item does not work as expected there...
61 2013-03-24T16:04:50 <ThomasWaldmann> sunu: btw, i recommended argparse module and forgot it is new in py2.7
62 2013-03-24T16:05:49 <ThomasWaldmann> (but considering that even debian might have 2.7 soon, I am considering raising the minimum requirement)
63 2013-03-24T16:49:13 *** rihnapstor
64 2013-03-24T16:51:50 *** sonakshi
65 2013-03-24T16:53:03 *** sonakshi
66 2013-03-24T16:58:19 <ThomasWaldmann> sunu: i found a solution
67 2013-03-24T16:58:53 <ThomasWaldmann> just don't know yet WHY it works :D
68 2013-03-24T17:02:43 *** ashutosh1461
69 2013-03-24T17:02:58 <sunu> ThomasWaldmann: pulled in the changes, solves for default. but fails in gae branch
70 2013-03-24T17:07:00 <ThomasWaldmann> it all works if no empty content is used for items (e.g. the png, not '' but 'x' will work)
71 2013-03-24T17:07:25 <ThomasWaldmann> but i don't know yet why that isn't an issue in main branch and why it is required in gae branch
72 2013-03-24T17:09:31 <ThomasWaldmann> it's CACHE_TYPE="simple"
73 2013-03-24T17:10:36 *** greg_f
74 2013-03-24T17:18:42 <ThomasWaldmann> ok, found it, likely
75 2013-03-24T17:19:00 *** ashutosh1461
76 2013-03-24T17:19:20 <ThomasWaldmann> the internal_representation uses caching and only the hash value of the contents is used as key
77 2013-03-24T17:20:40 <ThomasWaldmann> so if we have same data (like '') but different metadata (like content-type) that influences the representation, it will give wrong results
78 2013-03-24T17:28:25 <sunu> ThomasWaldmann: Nice :). That indeed is the problem.
79 2013-03-24T17:28:32 <sunu> == 1 failed, 632 passed, 331 skipped in 51.16 seconds === now :D
80 2013-03-24T17:29:07 <ThomasWaldmann> i am currently fixing the cache key problem, it's at different places...
81 2013-03-24T17:29:36 <ThomasWaldmann> sunu: did you recently give the gae branch code a try on appspot?
82 2013-03-24T17:30:07 <rihnapstor> ThomasWaldmann: sunu: which testing method is followed for moin ? where can i study that ?
83 2013-03-24T17:30:46 <ThomasWaldmann> py.test
84 2013-03-24T17:31:13 <ThomasWaldmann> (one usually just enters "make test" - it runs py.test then with right options)
85 2013-03-24T17:31:41 <sunu> ThomasWaldmann: no. I'll try now.
86 2013-03-24T17:32:27 <ThomasWaldmann> rihnapstor: btw, the development workflow is documented, did you read the docs?
87 2013-03-24T17:34:04 <rihnapstor> ok nice :)Yes i am reading the docs ,but haven't yet finished reading fully.
88 2013-03-24T17:38:11 <sunu> ImportError: No module named flask.ext.theme on local appengine server
89 2013-03-24T17:40:05 <ThomasWaldmann> sunu: hmm, is that this import bug? didn't we solve that already somehow?
90 2013-03-24T17:41:39 <sunu> hmm that was for flask cache iirc
91 2013-03-24T17:42:28 <sunu> flask has some kind of hook to handle these ext imports, don't know why it's going wrong
92 2013-03-24T17:42:59 <sunu> let me build a new env first.
93 2013-03-24T17:45:45 *** dwcramer
94 2013-03-24T17:51:29 * ThomasWaldmann can't even start the standalone server on gae branch...
95 2013-03-24T17:51:34 <ThomasWaldmann> fixing...
96 2013-03-24T17:52:20 <rihnapstor> ThomasWaldmann: can you please review my first patch for issue #347 here https://codereview.appspot.com/7719054.
97 2013-03-24T17:54:49 <ThomasWaldmann> rihnapstor: put spaces before and after urls
98 2013-03-24T17:55:43 <ThomasWaldmann> and if you put a link to the issue into the description of the codereview, that would be great also
99 2013-03-24T17:56:38 <ThomasWaldmann> and please first look yourself at the codereview url, the stuff there doesn't look right
100 2013-03-24T18:00:18 <ThomasWaldmann> sunu: i pushed the fixes
101 2013-03-24T18:01:37 *** dwcramer
102 2013-03-24T18:02:44 *** rihnapstor
103 2013-03-24T18:07:46 *** rihnapstor
104 2013-03-24T18:11:37 <rihnapstor> ThomasWaldmann: i am sorry , i will avoid this mistakes happening in the future.
105 2013-03-24T18:15:11 <ThomasWaldmann> no problem, how did you get that? :)
106 2013-03-24T18:16:21 *** rihnapstor
107 2013-03-24T18:18:18 *** rihnapstor
108 2013-03-24T18:18:52 *** rihnapstor
109 2013-03-24T18:20:24 *** rihnapstor
110 2013-03-24T18:21:21 *** rihnapstor
111 2013-03-24T18:22:18 *** haseeb_
112 2013-03-24T18:22:34 <rihnapstor> ThomasWaldmann: whats wrong with my codereview url ?
113 2013-03-24T18:25:23 <ThomasWaldmann> it shows a lot of changes in the diff
114 2013-03-24T18:29:06 <sunu> ThomasWaldmann: does the flask.ext import work for you ?
115 2013-03-24T18:29:47 <dreimark> rihnapstor: it looks like you reformatted lots of code
116 2013-03-24T18:29:51 <dreimark> please don't
117 2013-03-24T18:30:08 <sunu> As a temporary solution we can move the stuff in flaskext into flask.ext while creating support directory
118 2013-03-24T18:30:57 <ThomasWaldmann> sunu: it works for the standalone server, do you mean the gae dev server?
119 2013-03-24T18:31:17 <sunu> yup
120 2013-03-24T18:31:25 <dreimark> rihnapstor: have you some flag which reformats it to < 80 chars per line or so
121 2013-03-24T18:31:29 <rihnapstor> dreimark: ThomasWaldmann: i am sorry for the mistakes.btw before starting with bug fixed i played with moin source code ,did some changes here and there.
122 2013-03-24T18:31:41 <sunu> I just marked there is no __init__.py in flaskext server
123 2013-03-24T18:31:53 <sunu> flaskext folder*
124 2013-03-24T18:33:01 <dreimark> rihnapstor: please redo them and of course apply your changes then again
125 2013-03-24T18:34:30 <dreimark> whenever a wording or reformatting change is done then one without anything else
126 2013-03-24T18:34:41 <sunu> hmm no need for __init__.py i guess. we are not importing anything directly from flaskext.
127 2013-03-24T18:34:49 <ThomasWaldmann> sunu: ImportError: No module named whoosh.filedb.gae
128 2013-03-24T18:35:17 <sunu> no I don't get that
129 2013-03-24T18:36:39 <sunu> Whoosh == 2.5.0 btw
130 2013-03-24T18:36:44 <sunu> ThomasWaldmann:
131 2013-03-24T18:38:30 <rihnapstor> i edited the " frontend/views.py" and "templates/common.js" files for restricting the search button from sending request incase of empty search text. the code worked but since it was not a bug in issue tracker i made my mind to erase that code from those files but didn't commit changes to my local repository so while running "upload.py" those untracked files got uploaded too.
132 2013-03-24T18:40:21 <ThomasWaldmann> sunu: i use the repo code / setup.py "as is"
133 2013-03-24T18:41:15 <rihnapstor> ThomasWaldmann: dreimark i will make a new patch entirely . but before that i should delete those" common.js " and "frontend/views.py" files and then make a pull request.
134 2013-03-24T18:41:33 <dreimark> no pull request before review please
135 2013-03-24T18:41:46 <dreimark> and those amount of changes won't get in
136 2013-03-24T18:42:59 * ThomasWaldmann killed dlc/ and env/ and runs quickinstall to make sure
137 2013-03-24T18:43:17 <ashutosh1461> ThomasWaldmann, issue updated, https://codereview.appspot.com/7856046/#ps19004
138 2013-03-24T18:43:34 <sunu> ThomasWaldmann: btw did you do make support
139 2013-03-24T18:43:40 <sunu> :P
140 2013-03-24T18:44:19 <ThomasWaldmann> ehrm, no :)
141 2013-03-24T18:44:23 <dreimark> rihnapstor: have a look at the crecord extension
142 2013-03-24T18:44:32 <dreimark> of hg
143 2013-03-24T18:44:36 <sunu> haha :D
144 2013-03-24T18:45:00 <ThomasWaldmann> maybe there should be a check for that, giving a good error msg :)
145 2013-03-24T18:46:57 <sunu> hmm. this happens a lot of time and creates unnecessary confusion.
146 2013-03-24T18:48:13 <ThomasWaldmann> add_support_to_path maybe add some "exists" check there?
147 2013-03-24T18:49:53 <sunu> hmm.
148 2013-03-24T18:51:45 <sunu> Shouldn't add_support_to_path() be inside the if gae: block?
149 2013-03-24T18:56:16 <ThomasWaldmann> no
150 2013-03-24T18:56:34 <ThomasWaldmann> support dir is for standalone support, not only for gae
151 2013-03-24T18:57:26 <sunu> yes. right.
152 2013-03-24T18:59:37 <dreimark> sunu: ThomasWaldmann is that a similar issue as #293
153 2013-03-24T18:59:45 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/293/gae-flask-import-magic-incompatibility
154 2013-03-24T19:00:25 <ThomasWaldmann> that's what i meant above
155 2013-03-24T19:02:58 <sunu> dreimark: seems to be the same issue.
156 2013-03-24T19:08:03 <sunu> ThomasWaldmann: https://codereview.appspot.com/7988046
157 2013-03-24T19:11:18 *** dwcramer
158 2013-03-24T19:13:49 <rihnapstor> dreimark: record extension enabled for hg.
159 2013-03-24T19:14:43 <ThomasWaldmann> sunu: ImportError: No module named flask.ext.themes
160 2013-03-24T19:14:49 <ThomasWaldmann> after make support
161 2013-03-24T19:15:00 <sunu> yup that's the one i get
162 2013-03-24T19:16:27 <ThomasWaldmann> and yes, it is the gae import issue as it works with "python moin.py"
163 2013-03-24T19:17:22 *** haseeb_
164 2013-03-24T19:19:20 <sunu> yes.
165 2013-03-24T19:19:58 *** ronny
166 2013-03-24T19:19:58 *** ronny
167 2013-03-24T19:20:18 * sunu has college tomorrow morning. Need some sleep. gn all :)
168 2013-03-24T19:21:03 <ThomasWaldmann> gn sunu
169 2013-03-24T19:21:43 <dreimark> rihnapstor: don't commit by cdrecord use it for charry picking
170 2013-03-24T19:23:04 *** dwcramer
171 2013-03-24T19:24:22 <rihnapstor> dreimark: still not used that extension.
172 2013-03-24T19:27:26 <rihnapstor> dreimark: when editing an issue using codereview tool what should i enter into "CC" ,"Reviewers" fields ? shoud i leave them blank ?
173 2013-03-24T19:28:00 <dreimark> rihnapstor: cherry pick the good ones
174 2013-03-24T19:28:06 <dreimark> hg revert --all
175 2013-03-24T19:28:25 <dreimark> and patch -p0 < the good ones
176 2013-03-24T19:28:38 <dreimark> then upload again
177 2013-03-24T19:30:24 <rihnapstor> dreimark: i want to know what should be entered in "CC" "Reviewers " field in UI provided by codereview tool when editing an issue using UI ?
178 2013-03-24T19:33:39 <ThomasWaldmann> just use upload.py and publish the url here
179 2013-03-24T19:34:23 <rihnapstor> ThomasWaldmann: dreimark please review https://codereview.appspot.com/7570051/
180 2013-03-24T19:38:24 <dreimark> rihnapstor: added a comment
181 2013-03-24T19:38:28 <dreimark> brb
182 2013-03-24T19:43:28 <ashutosh1461> ThomasWaldmann, please review issue https://codereview.appspot.com/7610050/#ps12001 #320 and #335 <related to subitems> , it solves also the nested sub-items bug.
183 2013-03-24T19:44:42 <ashutosh1461> and the previous rename one too , https://codereview.appspot.com/7856046/#ps19004 :)
184 2013-03-24T19:51:16 * ThomasWaldmann looks
185 2013-03-24T19:53:04 <ThomasWaldmann> ashutosh1461: rename change -> you ran "make test", did practical tests?
186 2013-03-24T19:56:45 <ashutosh1461> ThomasWaldmann, yes did testing in rename change
187 2013-03-24T19:57:12 * rihnapstor reworking on issue #347
188 2013-03-24T19:57:15 *** haseeb
189 2013-03-24T19:57:15 *** haseeb
190 2013-03-24T19:59:15 <ashutosh1461> ThomasWaldmann, I dont remember the exact stats, but 1 test failed in the rename change and 3 in sub-items one
191 2013-03-24T20:01:37 <ThomasWaldmann> ashutosh1461: ok, commit and pull request for the rename change
192 2013-03-24T20:02:21 <ThomasWaldmann> in default repo, there should be currently 1 failing test (blog stuff), not more
193 2013-03-24T20:03:36 <ashutosh1461> hmm . :)
194 2013-03-24T20:05:20 <dreimark> https://codereview.appspot.com/7856046/diff2/47001:19004/MoinMoin/items/__init__.py?context=10&column_width=80
195 2013-03-24T20:05:32 <dreimark> is there _ removed ?
196 2013-03-24T20:06:33 <ashutosh1461> yes
197 2013-03-24T20:06:36 <dreimark> ok, conmpared with repo
198 2013-03-24T20:09:11 <dreimark> the only question I have is about the name of "NameNotUniqueError"
199 2013-03-24T20:09:25 <dreimark> does it need the postfix Error?
200 2013-03-24T20:09:51 <dreimark> NonExistent could also have it, but hasn't
201 2013-03-24T20:10:26 *** haseeb
202 2013-03-24T20:13:17 <ashutosh1461> dreimark, as you wish but i guess NameNotUniqueError would be fine. raise <someError> sounds good.
203 2013-03-24T20:17:32 <dreimark> i guess we raise always on Error ;) but also a lot of others have the postfix, so it is ok
204 2013-03-24T20:17:50 <dreimark> just searched the py repo
205 2013-03-24T20:19:50 <dreimark> ClientLoginError, HTTPError, NotImplementedError, ImportError ...
206 2013-03-24T20:25:14 <ashutosh1461> :) ThomasWaldmann check out the comment, https://codereview.appspot.com/7610050/
207 2013-03-24T20:37:42 *** haseeb
208 2013-03-24T20:44:19 <rihnapstor> dreimark: ThomasWaldmann can you please review my revised patch here https://codereview.appspot.com/7570051
209 2013-03-24T20:58:47 <dreimark> rihnapstor: how does this help, if I set the root in my config to FISH ?
210 2013-03-24T21:01:49 <dreimark> see also the discussion on the tracker
211 2013-03-24T21:28:32 <dreimark> gn
212 2013-03-24T21:28:32 <rihnapstor> so dreimark the "FrontPage" prefixed with "/" should be eliminated ?
213 2013-03-24T21:28:32 *** ronny
214 2013-03-24T21:30:39 <ashutosh1461> ThomasWaldmann, dreimark, please review https://codereview.appspot.com/7610050/
215 2013-03-24T21:38:53 * rihnapstor has college tommorow,bed time
216 2013-03-24T21:38:58 <rihnapstor> gn everyone
217 2013-03-24T21:39:04 *** rihnapstor
218 2013-03-24T21:44:51 *** ronny
219 2013-03-24T22:42:03 * ashutosh1461 bed time, gn everyone :)
220 2013-03-24T22:42:09 *** ashutosh1461
221 2013-03-24T22:43:53 *** ronny
222 2013-03-24T23:15:27 *** xorAxAx
223 2013-03-24T23:16:13 *** xorAxAx
224 2013-03-24T23:23:38 *** xiaq_
225 2013-03-24T23:23:39 *** dcramer_
226 2013-03-24T23:23:52 *** dwcramer
227 2013-03-24T23:23:53 *** xiaq
228 2013-03-24T23:27:22 *** eSyr
229 2013-03-24T23:30:33 *** eSyr
230 2013-03-24T23:38:24 *** haseeb
231 2013-03-24T23:52:26 *** breton_
232 2013-03-24T23:52:27 *** breton
233 2013-03-24T23:58:58 *** SteveMcIntyre
234
