1 2013-03-26T03:17:58 *** sharky93
2 2013-03-26T03:22:44 *** sharky93
3 2013-03-26T03:35:00 *** spinningarrow
4 2013-03-26T04:33:24 *** spinningarrow
5 2013-03-26T06:12:19 *** ronny_
6 2013-03-26T06:31:43 *** errtr
7 2013-03-26T06:31:53 <errtr> hi ThomasWaldmann
8 2013-03-26T06:46:16 *** errtr
9 2013-03-26T07:19:34 <dreimark> moin
10 2013-03-26T08:42:42 *** haseeb
11 2013-03-26T08:46:35 *** greg_f
12 2013-03-26T09:33:10 *** ashutosh1461
13 2013-03-26T09:54:37 *** ashutosh1461
14 2013-03-26T10:12:02 *** ashutosh1461
15 2013-03-26T10:17:28 <ThomasWaldmann> moin
16 2013-03-26T10:19:13 <ashutosh1461> hello ThomasWaldmann :)
17 2013-03-26T10:21:16 *** haseeb
18 2013-03-26T10:24:34 <ashutosh1461> ThomasWaldmann, the function guessContentType here, http://goo.gl/vdCHm is not getting used anywhere now. should we remove it ? i think it would be more easy to get Contenttype from the individual function params, rather than calling guessContentType everywhere.
19 2013-03-26T10:35:30 *** ashutosh1461
20 2013-03-26T12:01:32 <sunu> moin
21 2013-03-26T12:04:47 *** ronny_
22 2013-03-26T12:06:01 *** ronny_
23 2013-03-26T12:49:49 *** dave_largo
24 2013-03-26T12:53:41 *** spinningarrow
25 2013-03-26T13:32:22 *** bruno_
26 2013-03-26T13:38:21 <ThomasWaldmann> bruno_: btw, did I already tell? the namespaces branch was merged into main branch. bugs being fixed...
27 2013-03-26T13:48:35 *** ronny_2
28 2013-03-26T13:50:57 *** spinningarrow
29 2013-03-26T13:52:09 *** ronny_
30 2013-03-26T14:08:40 *** spinningarrow
31 2013-03-26T14:14:00 <bruno_> ThomasWaldmann, hi! Yes, that's great! I have been watching the moin2 repo....
32 2013-03-26T14:18:11 <bruno_> ThomasWaldmann, I will review this patch https://codereview.appspot.com/5376052/ with the head changeset, but seems that part of this work was already done...
33 2013-03-26T14:23:46 *** spinningarrow
34 2013-03-26T14:36:00 *** spinningarrow
35 2013-03-26T14:36:05 *** RogerHaase
36 2013-03-26T15:12:50 *** haseeb
37 2013-03-26T15:12:50 *** haseeb
38 2013-03-26T15:27:53 *** ashutosh1461
39 2013-03-26T15:31:09 <ashutosh1461> RogerHaase, testing part done https://codereview.appspot.com/7610050/#ps56001 and the the function guessContentType here, http://goo.gl/vdCHm is not getting used anywhere now. should we remove it ? i think it would be more easy to get Contenttype from the individual function params, rather than calling guessContentType everywhere.
40 2013-03-26T15:33:18 <ThomasWaldmann> bruno_: oh, that's a quite old cr :D
41 2013-03-26T15:41:29 *** dwcramer
42 2013-03-26T15:49:38 <RogerHaase> ashutosh1461: I am thinking 7610050 fixes 335, 320, and 351. Is that your understanding too?
43 2013-03-26T15:52:29 *** ronny_2
44 2013-03-26T15:56:32 <sunu> ThomasWaldmann: Could you have a look at my gsoc proposal page? http://moinmo.in/TarashishMishra/GSOC-2013
45 2013-03-26T16:09:29 *** spinningarrow
46 2013-03-26T16:22:19 <RogerHaase> ashutosh1461: done
47 2013-03-26T16:30:07 *** haseeb
48 2013-03-26T16:34:00 <ThomasWaldmann> sunu: later, at work currently
49 2013-03-26T16:36:11 <sunu> ThomasWaldmann: sure :)
50 2013-03-26T16:43:49 <bruno_> ThomasWaldmann, yeah, I know... sorry for that... :-S
51 2013-03-26T17:33:12 *** spinningarrow
52 2013-03-26T17:35:27 *** axitkhurana
53 2013-03-26T17:41:14 *** greg_f
54 2013-03-26T18:30:01 *** ronny
55 2013-03-26T18:30:02 *** ronny
56 2013-03-26T18:35:48 *** ashutosh1461
57 2013-03-26T18:36:57 *** ronny
58 2013-03-26T18:37:18 *** ronny
59 2013-03-26T18:37:18 *** ronny
60 2013-03-26T18:42:08 *** ronny_
61 2013-03-26T18:42:08 *** ronny_
62 2013-03-26T18:44:40 *** ronny
63 2013-03-26T19:15:00 <dreimark> sunu: https://github.com/ahupp/python-magic
64 2013-03-26T19:15:46 <dreimark> if that works on other platforms too it could be used to get the correct mimetype
65 2013-03-26T19:16:05 <RogerHaase> ThomasWaldmann: I like the mozilla personna login concepts. OK to add an enhancement issue in case someone is interested in adding it to moin2?
66 2013-03-26T19:17:45 <RogerHaase> is everyone getting these 4 pep8 errors at current moin2 tip? http://rn0.ru/show/iCqprOYEZfI6Kcmm5pvT/
67 2013-03-26T19:20:22 <dreimark> sunu: that should also work for files stored in BLOBs
68 2013-03-26T19:23:37 *** axitkhurana
69 2013-03-26T19:28:39 <sunu> dreimark: we can use that for deciding the contenttype of jfu uploads then ?
70 2013-03-26T19:29:11 <dreimark> RogerHaase: MoinMoin/items/_tests/test_Blog.py s..F....
71 2013-03-26T19:29:11 <dreimark> MoinMoin/items/_tests/test_Content.py s............
72 2013-03-26T19:29:12 <dreimark> MoinMoin/items/_tests/test_Item.py s.F......FF...
73 2013-03-26T19:29:29 <dreimark> sunu: yes and also for the cli uploader
74 2013-03-26T19:30:12 <dreimark> sunu: have you thought on a lifetime for the pastesß
75 2013-03-26T19:30:20 <dreimark> ?
76 2013-03-26T19:30:58 <dreimark> the blog feature has introduced a time for publishing
77 2013-03-26T19:31:14 <sunu> yes the ptime stuff
78 2013-03-26T19:31:27 <dreimark> some pastes also have a private and public feature
79 2013-03-26T19:33:09 <sunu> about lifetime, should it be some fixed number of days or should it be based on activity ?
80 2013-03-26T19:33:47 <dreimark> both is interesting, at least the latter makes a cleanup at some time
81 2013-03-26T19:35:03 <dreimark> have you looked on the logeit uploader ?
82 2013-03-26T19:35:41 <sunu> No. I will take a look now that you have mentioned it :D
83 2013-03-26T19:37:53 <dreimark> since the shutdown of paste.pocoo.org, we have external_links in meta http://hg.moinmo.in/moin/2.0/log?rev=external
84 2013-03-26T19:38:59 <dreimark> think also on some anti-spam tools (for the future)
85 2013-03-26T19:41:07 <dreimark> bbl
86 2013-03-26T19:41:12 <sunu> we could use those external_links for spam control. May be allow only trusted links. Need to do some reading on it and see how anti-spam stuff is implemented :)
87 2013-03-26T19:42:10 <ThomasWaldmann> RogerHaase: about persona/browserid: google for it, it's not all positive (of course the mozilla people's talks are)
88 2013-03-26T19:42:27 <dreimark> shutting down a service just because of spam is ...
89 2013-03-26T19:42:45 * dreimark have to look at some M$ problems bbl
90 2013-03-26T19:43:58 *** banas
91 2013-03-26T19:45:43 <banas> dreimark: I've joined here. So based on my background, what are some projects you would suggest? I'd love them to be the kind that wouldn't take a lot of time getting started with, and are at the same time challenging :)
92 2013-03-26T19:46:41 *** spinningarrow
93 2013-03-26T19:48:15 *** axitkhurana
94 2013-03-26T19:48:35 *** spinningarrow
95 2013-03-26T19:51:08 <ThomasWaldmann> banas: can you have a look at the issue tracker? maybe you like something and you can better tell what's interesting for you.
96 2013-03-26T19:52:26 <ThomasWaldmann> RogerHaase: current moin2 tip is gae branch, so you have the pep8 fails in gae branch?
97 2013-03-26T19:54:03 <banas> ThomasWaldmann: Sure. I hope by issue tracker, you;re referring to the Ideas page? I did find the UI improvements idea interesting. Thing is, I am currently travelling and my internet isn't very stable. If I could talk to you tomorrow, what's an ideal time? :)
98 2013-03-26T19:57:01 <ThomasWaldmann> dreimark: that python-magic is quite lowlevel stuff, depending on specific binaries/libraries
99 2013-03-26T19:57:46 <ThomasWaldmann> banas: the issue tracker is linked from the MoinMoin2.0 page which is linked from the ideas page
100 2013-03-26T19:58:07 <RogerHaase> ThomasWaldmann: hmm, no I seem to be on default but see 3 recent gae commits. Will try tests at gae tip...
101 2013-03-26T19:58:34 <ThomasWaldmann> banas: about time: just try. usually the utc afternoons/evenings/nights might work
102 2013-03-26T19:59:22 * ThomasWaldmann runs make test on default branch
103 2013-03-26T20:03:00 <RogerHaase> I have same number of failures at gae tip: http://rn0.ru/show/dR0PD26yWT0fYowXEqvU/
104 2013-03-26T20:11:01 <ThomasWaldmann> hmm, didn't i exclude that old stuff?
105 2013-03-26T20:14:03 <RogerHaase> ThomasWaldmann: I was comparing pep8 test results with ashutosh1461 earlier -- he had 0 failures
106 2013-03-26T20:16:07 <ThomasWaldmann> 1 failed, 613 passed, 350 skipped in 94.10 seconds (default branch)
107 2013-03-26T20:16:18 <ThomasWaldmann> the failure is the blog stuff
108 2013-03-26T20:17:31 <RogerHaase> ThomasWaldmann: the postings I showed were from pep8 py.test.exe --pep8 -k pep8 > pytestpep8.txt
109 2013-03-26T20:17:32 <ThomasWaldmann> $ py.test --pep8 -k pep8 --clearcache # --> no fails
110 2013-03-26T20:18:46 <ThomasWaldmann> RogerHaase: look into setup.cfg - there are some excludes
111 2013-03-26T20:23:06 <ThomasWaldmann> RogerHaase: http://www.opine.me/mozilla-persona-browserid-is-a-step-in-the-wrong-direction/
112 2013-03-26T20:28:32 *** axitkhurana
113 2013-03-26T20:28:34 <RogerHaase> ThomasWaldmann: looks like windows ignores the excludes, or at least some of them. Will a delete few exclusions to see if there is a difference....
114 2013-03-26T20:37:31 <xorAxAx> ThomasWaldmann: i get invalid token error on moinmo.in with the link provided in the mail
115 2013-03-26T20:37:52 <xorAxAx> ah, expired
116 2013-03-26T20:52:46 <RogerHaase> ThomasWaldmann: 286 passed, 11 skipped, 662 deselected, got there by changing / to \ :-D
117 2013-03-26T21:24:48 <RogerHaase> https://bitbucket.org/hpk42/pytest-pep8/issue/3/pep8ignore-is-ignored-by-windows-wants-not
118 2013-03-26T21:24:58 *** dave_largo
119 2013-03-26T21:35:14 *** spinningarrow
120 2013-03-26T21:35:33 *** spinningarrow
121 2013-03-26T21:41:01 *** ashutosh1461
122 2013-03-26T21:44:40 *** dwcramer
123 2013-03-26T21:47:21 <dreimark> RogerHaase: ThomasWaldmann http://rn0.ru/show/9aQUpW3ZTV8s5CZSuxFw/
124 2013-03-26T21:47:39 <dreimark> ============== 4 failed, 610 passed, 345 skipped in 36.44 seconds ==============
125 2013-03-26T21:48:23 <dreimark> hg tip 2051:da0add742730
126 2013-03-26T21:58:42 <RogerHaase> dreimark: hmm, I only get 1 error on blog at gae tip. Earlier I was asking about pytest-pep8 -- found a bug where windows wants \ in filenames within pep8ignore ^^^
127 2013-03-26T21:59:43 <RogerHaase> http://rn0.ru/show/vfJDDFfl6IL93Fd6QDMZ/
128 2013-03-26T22:06:04 <dreimark> hmm, rm -r wiki and recreating the index doesn't help
129 2013-03-26T22:08:42 *** RogerHaase
130 2013-03-26T22:08:54 * dreimark hadn't a clean repo
131 2013-03-26T22:08:54 *** ashutosh1461
132 2013-03-26T22:09:10 <dreimark> now also 1 failed, 614 passed, 344 skipped in 34.63 seconds
133 2013-03-26T22:11:25 <dreimark> gn
134 2013-03-26T22:18:46 *** ashutosh1461
135 2013-03-26T22:24:31 <ashutosh1461> ThomasWaldmann, please check https://codereview.appspot.com/7610050/ (in relation with #335 , #320 and #351)
136 2013-03-26T22:34:13 <ThomasWaldmann> hi ashutosh1461
137 2013-03-26T22:34:20 * ThomasWaldmann looking
138 2013-03-26T22:35:51 <ashutosh1461> ThomasWaldmann, Holi wishes from India :D
139 2013-03-26T22:36:10 <ashutosh1461> Happy Holi to all :)
140 2013-03-26T22:36:30 <ThomasWaldmann> no holidays still, but thanks :P
141 2013-03-26T22:38:24 <ThomasWaldmann> how's that "contenttype" part of the change related?
142 2013-03-26T22:40:39 <ashutosh1461> that is used in the linking and transcluding part
143 2013-03-26T22:41:58 <ThomasWaldmann> you got rid of that guessType stuff
144 2013-03-26T22:42:02 <ashutosh1461> There was a problem in transcluding the sub-item, check out Roger's comment https://bitbucket.org/thomaswaldmann/moin-2.0/issue/335
145 2013-03-26T22:43:02 <ashutosh1461> hmm, the function was not giving proper results and is also a bit complex.
146 2013-03-26T22:45:30 <ThomasWaldmann> found one little issue, see review
147 2013-03-26T22:47:16 <ThomasWaldmann> i don't see how 335 is related to guessType
148 2013-03-26T22:49:55 <ashutosh1461> ThomasWaldmann, instead of creating a new issue (about the transcluding and linking part of sub-items not working properly), RogerHasse added a comment to the #335 page about the issue.
149 2013-03-26T22:52:35 <ThomasWaldmann> i am still not seeing anything that specificially says what was wrong
150 2013-03-26T22:53:24 <ThomasWaldmann> (related to guessType/contenttype)
151 2013-03-26T22:56:29 <ashutosh1461> ThomasWaldmann, the guessContentType function always returned the content to be "text/plain", which lead to incorrect transcluding of the sub-items, so we needed the correct contenttype for the functions (linkSubitem line 290 and TranscludeSubitem line 251) to work properly.
152 2013-03-26T23:03:31 <ThomasWaldmann> ok, is anything still using guessType?
153 2013-03-26T23:03:50 <ThomasWaldmann> guessContentType i mea
154 2013-03-26T23:03:54 <ThomasWaldmann> n
155 2013-03-26T23:05:36 <ThomasWaldmann> ehrm. guessContentType is guessing the type of the currently edited text based on the #f_meta_text form field.
156 2013-03-26T23:06:19 <ashutosh1461> ThomasWaldmann, check out the comment, https://codereview.appspot.com/7610050/diff/69001/MoinMoin/templates/modify.html and the guessContenttype function is useless for now.
157 2013-03-26T23:07:32 <ThomasWaldmann> well, there is a slight difference between before/after you change semantics
158 2013-03-26T23:08:02 <ThomasWaldmann> after your change, it uses the contenttype as it was when rendering the form
159 2013-03-26T23:08:23 <ThomasWaldmann> before, it used the contenttype as currently present in the form field
160 2013-03-26T23:08:52 <ThomasWaldmann> i suggest you split your changeset into 2 parts:
161 2013-03-26T23:09:03 <ThomasWaldmann> a) fixing the name related issues
162 2013-03-26T23:09:15 <ThomasWaldmann> b) working on that contenttype related stuff
163 2013-03-26T23:10:23 <ThomasWaldmann> a) looks good (just from looking at the code, i didn't run it myself, but I am assuming you did and checked it works ok)
164 2013-03-26T23:10:29 <ThomasWaldmann> btw, how about tests?
165 2013-03-26T23:10:36 <ashutosh1461> but ThomasWaldmann before my change the contenttype variable passed as params into the caller function was not getting used anywhere ?
166 2013-03-26T23:10:41 <ashutosh1461> so where is the confusion ?
167 2013-03-26T23:11:01 <ashutosh1461> yes it works fine, Roger checked it.
168 2013-03-26T23:11:31 <ThomasWaldmann> i didn't understand your question, you need to be more precise
169 2013-03-26T23:12:04 <ashutosh1461> tests, i made a few changes in the test files, now they work fine.
170 2013-03-26T23:12:41 *** bruno_
171 2013-03-26T23:12:56 <ThomasWaldmann> ah, right, seeing now that one of the changes was in a test.
172 2013-03-26T23:13:06 <ThomasWaldmann> 00:10 ashutosh1461$ but ThomasWaldmann before my change the contenttype variable passed as params into the caller function was not getting used anywhere ?
173 2013-03-26T23:13:10 <ThomasWaldmann> but i meant that
174 2013-03-26T23:13:23 <ashutosh1461> https://bitbucket.org/thomaswaldmann/moin-2.0/src/1faff598bbae2d41c7bcf9a5c4d06fb97800debb/MoinMoin/templates/modify.html?at=default#cl-23
175 2013-03-26T23:15:00 <ashutosh1461> look here, the contenttype getting used here doesn't come into use anywhere, also it gives contenttype of the sub-item which is of no use here in the function i guess.
176 2013-03-26T23:15:52 <ashutosh1461> we mainly need the contenttype of the item we are modifying not the contenttype of the "subitem" we are transcluding which the before contenttype var was giving.
177 2013-03-26T23:21:46 <ThomasWaldmann> https://codereview.appspot.com/7610050/diff/69001/MoinMoin/templates/modify.html line 26,27,29 on the right - where does contenttype come from?
178 2013-03-26T23:22:42 <ashutosh1461> https://codereview.appspot.com/7610050/diff/69001/MoinMoin/items/__init__.py line 736
179 2013-03-26T23:24:36 <ThomasWaldmann> ok. but it's still not assured that this is STILL the correct contenttype, the editor could have changed it.
180 2013-03-26T23:25:10 <ThomasWaldmann> ok, as I already said: split it into 2 changesets, one just about names and one about cleaning up that contenttype stuff
181 2013-03-26T23:25:52 <ThomasWaldmann> i always felt a BIT bad about that insert link/transclusion code, but now it's getting worse.
182 2013-03-26T23:26:22 <ThomasWaldmann> maybe we should just get rid of that and just insert names and leave the markup stuff to the user
183 2013-03-26T23:27:32 <ThomasWaldmann> (that's way more simple and always works(tm))
184 2013-03-26T23:30:12 <ThomasWaldmann> (also ashutosh1461 ^
185 2013-03-26T23:30:20 <ThomasWaldmann> -also
186 2013-03-26T23:30:30 <ashutosh1461> ok fine, i will make two changesets , maybe there is not much difference in clicking the transclusion link and writing some {{pagename}}, so the button doesn't come out to be much handy.
187 2013-03-26T23:33:57 <ThomasWaldmann> well, for long names it might be still interesting
188 2013-03-26T23:34:23 <ThomasWaldmann> we can discuss that change tomorrow with roger and/or dreimark
189 2013-03-26T23:35:19 <ThomasWaldmann> i am saying it's bad because it has to somehow duplicate/reverse ALL python markup parsing code in JS
190 2013-03-26T23:35:51 <ThomasWaldmann> currently, there is support for a few markups, but you'ld have to extend that for any additional markup moin supports
191 2013-03-26T23:37:19 <ThomasWaldmann> e.g. a markdown parser was added a while ago, but it is missing there
192 2013-03-26T23:38:59 <ThomasWaldmann> and your change (giving the contenttype into the rendering environment instead of parsing it from form field) is causing a regression for the case when the form field was edited to a different contenttype
193 2013-03-26T23:40:22 <ashutosh1461> oh.. i see . and one more bug i pointed out suppose we change a meta[name] filed in the json data suppose we change "Home" to "Home","club" then it doesn't check whether a previously existing item "club" exists or not.
194 2013-03-26T23:40:36 <ashutosh1461> field*
195 2013-03-26T23:40:48 <ThomasWaldmann> btw, the bug in guessContentType is likely caused by it looking at the #f_meta_text field (which was correct back then but later got a separate field for some keys, like contenttype and itemtype)
196 2013-03-26T23:41:50 <ThomasWaldmann> ashutosh1461: yeah, that's an UX issue, too. the validator might catch it after submission, though.
197 2013-03-26T23:42:49 <ThomasWaldmann> but one after the other...
198 2013-03-26T23:52:58 <ashutosh1461> ThomasWaldmann, here is the patch for the issues related for names, https://codereview.appspot.com/7610050/#ps74001
199 2013-03-26T23:54:39 <ThomasWaldmann> ok, that looks clean.
200 2013-03-26T23:55:03 <ThomasWaldmann> test it, run the unit tests, commit, pull request :)
201 2013-03-26T23:58:47 <ashutosh1461> ThomasWaldmann, for the next few days i have a couple of assignment deadlines (college stuff), so I wont be here much, but i want some stuff to do if i get some spare time. What kind of bugs should i look for now?
