MoinMoin: MoinMoinChat/Logs/moin-dev/2013-09-03

   1 2013-09-03T00:12:16  <ashutosh1461> GN
   2 2013-09-03T00:12:17  *** ashutosh1461 has quit IRC
   3 2013-09-03T07:32:04  *** xiaq has quit IRC
   4 2013-09-03T07:32:13  *** xiaq has joined #moin-dev
   5 2013-09-03T07:32:37  *** xiaq is now known as Guest67730
   6 2013-09-03T09:07:40  *** Guest67730 is now known as xiaq
   7 2013-09-03T10:06:17  <ThomasWaldmann> moin
   8 2013-09-03T10:20:16  <ananasova> moin
   9 2013-09-03T10:53:17  <ananasova> ThomasWaldmann: i'd like to discuss the determing of subscribers for sending mail notifications and the order of execution
  10 2013-09-03T10:54:34  <ananasova> atm the signal for item destruction is emited before the item is destroyed, because otherwise we can't get subscribers, since there is no item
  11 2013-09-03T10:55:42  <ananasova> but this might be a bad thing. what if the destruction didn't happend and it threw an exception, but the notification about it was sent
  12 2013-09-03T10:56:26  <ananasova> this is what i am talking about - https://bitbucket.org/ana-balica/moin-2.0/commits/aa5ac2aa7a2461566aab1862755ba98d6b9459fd
  13 2013-09-03T12:17:47  <ThomasWaldmann> well, one maybe could check acls, but i guess there is no easy way to care for unexpected exceptions
  14 2013-09-03T12:36:26  <ananasova> http://etherpad.osuosl.org/moin-mail lines 8:9
  15 2013-09-03T13:01:43  *** diofeher has joined #moin-dev
  16 2013-09-03T13:01:51  <diofeher> j/ #django
  17 2013-09-03T13:01:56  <diofeher> ops sorry :)
  18 2013-09-03T13:02:11  *** diofeher has left #moin-dev
  19 2013-09-03T13:02:43  *** dave_largo has joined #moin-dev
  20 2013-09-03T13:46:28  <ananasova> ThomasWaldmann: changes made to the definitions of funcs from MoinMoin/util/subscriptions.py https://codereview.appspot.com/13234048/
  21 2013-09-03T14:05:40  <ThomasWaldmann> ananasova: done
  22 2013-09-03T14:14:12  <ananasova> will be back after some time, when back will fix
  23 2013-09-03T19:07:22  <ananasova> and i'm back with this update - https://codereview.appspot.com/13234048/
  24 2013-09-03T19:07:41  <ananasova> ThomasWaldmann: ^ can you please take a look when free?
  25 2013-09-03T19:19:27  <ThomasWaldmann> ananasova: done
  26 2013-09-03T19:20:00  <ThomasWaldmann> this is a good change, much more flexible and even easier now
  27 2013-09-03T19:22:22  <ananasova> true true
  28 2013-09-03T19:23:23  <ThomasWaldmann> we could now have tag patterns :D
  29 2013-09-03T19:26:54  <ananasova> :D just curious if anybody would really come with such a feature-request
  30 2013-09-03T19:31:09  <ananasova> ThomasWaldmann: https://codereview.appspot.com/13234048/diff2/5001:10001/MoinMoin/util/subscriptions.py
  31 2013-09-03T19:49:34  <ThomasWaldmann> ananasova: looks ok, please run tests and practically try it
  32 2013-09-03T19:53:51  <ananasova> did that already :)
  33 2013-09-03T20:02:10  <ananasova> ThomasWaldmann: how about flask-babel ctxmanager? https://codereview.appspot.com/13444043/
  34 2013-09-03T20:12:24  <ThomasWaldmann> there is still a "why?" from me
  35 2013-09-03T20:12:39  <ThomasWaldmann> https://codereview.appspot.com/13444043/diff2/1:5001/MoinMoin/i18n/_tests/test_i18n.py?column_width=80
  36 2013-09-03T20:14:21  <ananasova> did you see the answer? or the explanation is not good enough?
  37 2013-09-03T20:15:47  <ThomasWaldmann> hmm, somehow the answer was not a inline-reply, reading it now
  38 2013-09-03T20:16:43  <ThomasWaldmann> ah, ok. looks fine. any feedback from mitsuhiko / issue tracker / pull request?
  39 2013-09-03T20:19:31  <ananasova> no news. since the original code is from user lalinsky, maybe ask him to pr. it seems strange that he didn't do a pr, because the change is on a separate branch
  40 2013-09-03T20:20:46  <ananasova> normally with git you create a new branch per feature, especially for pull requests
  41 2013-09-03T20:26:08  <ThomasWaldmann> https://github.com/lalinsky/nosexunit lol
  42 2013-09-03T20:44:41  <ananasova> :D good he didn't CamelCased it
  43 2013-09-03T21:09:29  <ananasova> btw ThomasWaldmann do you have my repo pulled?
  44 2013-09-03T21:10:15  *** ashutosh1461 has joined #moin-dev
  45 2013-09-03T21:12:28  <ashutosh1461> ThomasWaldmann, added some points regarding history view http://etherpad.osuosl.org/moin-itemid 19-31
  46 2013-09-03T21:14:15  <ashutosh1461> also, jek has not replied yet. What to do ?
  47 2013-09-03T21:15:38  *** dave_largo has quit IRC
  48 2013-09-03T21:16:43  <ananasova> anyway if you do and you have some extra time, could you please test admin emails? simply set in the config your mail, set True email_tracebacks and generate an exception
  49 2013-09-03T21:17:04  * ananasova says good night :)
  50 2013-09-03T22:46:13  *** ashutosh1461 has quit IRC
  51 2013-09-03T23:17:32  <jek> i never seem to catch ashutosh1461