1 2013-09-22T00:14:11 <ashutosh1461> ThomasWaldmann, resolved all issues except a minor one https://bitbucket.org/ashu1461/moin-2.0/issue/26/
2 2013-09-22T00:14:53 * ashutosh1461 updates the docs for admins.
3 2013-09-22T00:59:15 <ashutosh1461> gn
4 2013-09-22T00:59:17 *** ashutosh1461
5 2013-09-22T07:32:55 <ananasova> moin
6 2013-09-22T07:44:31 *** MaikuMori
7 2013-09-22T07:44:47 *** MaikuMori
8 2013-09-22T08:02:30 *** sharky993
9 2013-09-22T08:02:39 <sharky993> moin
10 2013-09-22T09:15:46 <ananasova> i have an issue with configuration of multiple loggers with different handlers, i think i am missing smth important
11 2013-09-22T09:15:54 <ananasova> here is the conf file - http://rn0.ru/show/3429/
12 2013-09-22T09:18:05 <ananasova> the expected behaviour is to receive emails with tracebacks sent by the EmailHandler
13 2013-09-22T09:44:37 <ThomasWaldmann> ananasova: qualname is for enabling the logger only in some specific module/package
14 2013-09-22T09:45:42 <ThomasWaldmann> e.g. qualname=MoinMoin.auth will only enable in that package
15 2013-09-22T09:50:48 <ananasova> it says i need to specify qualname... so for every module in moin
16 2013-09-22T09:51:31 <ananasova> `qualname=` apparently works
17 2013-09-22T09:53:07 * sharky993 confirms moin2 is now Valid HTML5.
18 2013-09-22T09:53:30 * sharky993 confirms for atleast the basic theme.
19 2013-09-22T09:54:05 <ananasova> aha, it works with multiple loggers, but still there's recursion when sendmail raises exceptions
20 2013-09-22T09:55:34 <ananasova> so propagate=0 doesn't solve the problem... shall we then keep the globals?
21 2013-09-22T09:58:27 *** ashutosh1461
22 2013-09-22T10:00:07 <ThomasWaldmann> ok, who's here?
23 2013-09-22T10:00:14 <ashutosh1461> here
24 2013-09-22T10:00:22 <ananasova> here
25 2013-09-22T10:01:10 <ThomasWaldmann> any mentors? TheSheep? waldi?
26 2013-09-22T10:01:14 <sharky993> here
27 2013-09-22T10:01:58 <ThomasWaldmann> hmm, iirc waldi is maybe busy otherwise today.
28 2013-09-22T10:02:53 <ThomasWaldmann> some general comments first: tomorrow sept. 23, 1900 UTC is pencils down.
29 2013-09-22T10:03:22 <ThomasWaldmann> that means that everything done afterwards won't be considered for gsoc
30 2013-09-22T10:03:56 <ThomasWaldmann> and that your stuff should be in the best possible state then.
31 2013-09-22T10:04:27 <ThomasWaldmann> stuff = puplic repo wit code and docs, issue tracker, etherpad, calendar
32 2013-09-22T10:04:59 <waldi> i'm here
33 2013-09-22T10:06:03 <ThomasWaldmann> it does not mean that you must stop working on moin code or stop contributing. we would be very happy if you would continue to contribute after gsoc ended.
34 2013-09-22T10:06:44 <ThomasWaldmann> we want to use all your code and people will use it in production at some time.
35 2013-09-22T10:07:30 <ThomasWaldmann> ok, so ananasova and waldi, please begin.
36 2013-09-22T10:07:46 <ananasova> ok
37 2013-09-22T10:08:00 <ananasova> DONE:
38 2013-09-22T10:08:00 <ananasova> * Documentation for admin emails (https://codereview.appspot.com/13457059/) and user subscriptions (https://codereview.appspot.com/13334053/)
39 2013-09-22T10:08:03 <ananasova> * Fixing issue #5 log-to-mail crash (in progress)
40 2013-09-22T10:08:05 <ananasova> * Clean EP, moved the tasks to bb issue tracker
41 2013-09-22T10:08:08 <ananasova> * Small fix with unicode literals for email subject
42 2013-09-22T10:08:11 <ananasova> TODO:
43 2013-09-22T10:08:23 <ananasova> * commit what is left (docs, fixes)
44 2013-09-22T10:10:43 <ThomasWaldmann> ananasova: did you practically try all the stuff you worked on? ran all unit tests?
45 2013-09-22T10:10:50 <ananasova> yes
46 2013-09-22T10:11:09 * ThomasWaldmann submitted a draft comment to one of the CRs that i forgot
47 2013-09-22T10:11:39 * ananasova saw it, will add a comment in the docs about the config file
48 2013-09-22T10:12:36 <ThomasWaldmann> (will look at the other one after meeting)
49 2013-09-22T10:12:54 <ananasova> practically tried the code with 2 subscribers with different locale, making changes as a logged in user and as an anonymous user
50 2013-09-22T10:13:15 <waldi> okay
51 2013-09-22T10:13:17 <ananasova> with different types of subscriptions
52 2013-09-22T10:15:48 <ThomasWaldmann> ah, another comment for all students: please check with hg status that ALL code that should be committed to the repo really IS committed and not just on your disk.
53 2013-09-22T10:16:22 <ThomasWaldmann> ok, anything else for/from ananasova?
54 2013-09-22T10:16:27 <waldi> no
55 2013-09-22T10:17:33 <ThomasWaldmann> btw, also for all students: if there is some obvious todo left and you ran out of time for it, put it into issue tracker, so it won't be forgotten
56 2013-09-22T10:18:29 <ThomasWaldmann> ok, thanks ananasova / waldi. next is ashutosh1461 please.
57 2013-09-22T10:18:41 <ThomasWaldmann> TheSheep: are you with us?
58 2013-09-22T10:19:38 <ashutosh1461> ok
59 2013-09-22T10:19:47 <ashutosh1461> Done this week:-
60 2013-09-22T10:19:48 <ashutosh1461> Testing
61 2013-09-22T10:19:48 <ashutosh1461> Worked on documentation
62 2013-09-22T10:19:48 <ashutosh1461> Fixed remaining bugs, and bugs added yesterday.
63 2013-09-22T10:19:48 <ashutosh1461> ToDo:-
64 2013-09-22T10:19:48 <ashutosh1461> More testing
65 2013-09-22T10:19:50 <ashutosh1461> Complete documentation for admin.
66 2013-09-22T10:21:57 <ThomasWaldmann> ashutosh1461: I'll do some more testing today, glad that you could fix a lot already.
67 2013-09-22T10:22:55 <ThomasWaldmann> btw, the search might need some thinking/fixing considering namespaces.
68 2013-09-22T10:24:07 <ThomasWaldmann> like if one is in namespace "foo", maybe expectance is that search operates on ns "foo" only
69 2013-09-22T10:24:51 <ashutosh1461> hmm .. i will do that.
70 2013-09-22T10:25:43 <ashutosh1461> also to namespace of the item with the result in global search.
71 2013-09-22T10:25:51 <ashutosh1461> to display *
72 2013-09-22T10:28:12 <ThomasWaldmann> ok.
73 2013-09-22T10:28:21 <ThomasWaldmann> any questions for ashutosh1461 ?
74 2013-09-22T10:29:11 <ThomasWaldmann> ashutosh1461: btw, you can use that config from the pastebin i gave yesterday for examples/ and reference it from admin docs.
75 2013-09-22T10:29:31 <ThomasWaldmann> just read it, there is one line in it that should get removed
76 2013-09-22T10:30:17 <ashutosh1461> ok fine.
77 2013-09-22T10:31:11 <ThomasWaldmann> i also noticed that backends is currently a dict with None values, maybe we should change that to a list later.
78 2013-09-22T10:31:59 <ThomasWaldmann> ok, thanks ashutosh1461. next is sharky993 and TheSheep (if here).
79 2013-09-22T10:32:38 <sharky993> ok
80 2013-09-22T10:32:58 <sharky993> DONE
81 2013-09-22T10:33:02 <sharky993> Fixed the exception being raised on accessing global index, so no more test failures
82 2013-09-22T10:33:07 <sharky993> Fixed one test, further pep8 fixes
83 2013-09-22T10:33:12 <sharky993> Added Basic ACL UI with POC for validating the string
84 2013-09-22T10:33:17 <sharky993> Fixed HTML5 validation errors in the markup
85 2013-09-22T10:33:21 <sharky993> Fixed the rendering of the flash message, so does not cover the whole screen
86 2013-09-22T10:33:28 <sharky993> TODO
87 2013-09-22T10:33:32 <sharky993> Add docs for compiling the theme so that any future work is easy
88 2013-09-22T10:33:36 <sharky993> Etherpad cleanup
89 2013-09-22T10:33:47 <sharky993> EOF
90 2013-09-22T10:38:10 <ThomasWaldmann> btw, if you can reference to (e.g.) bootstrap docs, you should do so, not try to duplicate them.
91 2013-09-22T10:38:58 <sharky993> ah, will keep that in mind
92 2013-09-22T10:39:36 <ThomasWaldmann> lots of open issues still
93 2013-09-22T10:41:04 <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/37/pygments-css-missing e.g. that one seems easy to fix
94 2013-09-22T10:42:04 <sharky993> hmm, have not had a detailed look at that, but i think we've closed all major ones
95 2013-09-22T10:43:59 <ThomasWaldmann> maybe go through them and check if some stuff is open that should be closed
96 2013-09-22T10:45:14 <sharky993> sure
97 2013-09-22T10:47:31 <ThomasWaldmann> hmm, index still looks TODO
98 2013-09-22T10:48:37 <ThomasWaldmann> and global history looks very different compared to local history
99 2013-09-22T10:49:46 <sharky993> ThomasWaldmann, yeah, but its supposed to be that way, no?
100 2013-09-22T10:50:22 <sharky993> surely they dont follow the same layout
101 2013-09-22T10:51:49 <ThomasWaldmann> it's not totally the same and shouldn't be
102 2013-09-22T10:52:04 <ThomasWaldmann> but it looks ugly and is different for stuff that could be the same
103 2013-09-22T10:52:29 <ThomasWaldmann> btw, i just tried to modify Home item, adding tags to it
104 2013-09-22T10:53:08 <ThomasWaldmann> tried to save it and now it tells me "The ACL string is invalid" (no dot at the end, btw.) although i did not change ACL at all.
105 2013-09-22T10:53:59 <ThomasWaldmann> on "Edit ACL" it shows None in the input field (I didn't put that there).
106 2013-09-22T10:54:07 <sharky993> yeah, i made that commit to specifically show the POC for ACL editing
107 2013-09-22T10:54:57 <ThomasWaldmann> btw, for item modify, we have a comment input field (1 line)
108 2013-09-22T10:55:03 <sharky993> "None" in Edit ACL is used to specifically mention that the ACL string does not exist, since flatland does not distinguish between empty and non-existent values.
109 2013-09-22T10:55:13 <ThomasWaldmann> for rename/delete/destroy, it seems we have a comment textarea.
110 2013-09-22T10:55:41 <ThomasWaldmann> yeah, but it does not let me save.
111 2013-09-22T10:56:19 <ThomasWaldmann> can you file issues for that ^^ please?
112 2013-09-22T10:56:20 <sharky993> just a minute.
113 2013-09-22T10:56:44 <ThomasWaldmann> TheSheep: last chance within official meeting ;)
114 2013-09-22T10:57:17 <sharky993> ThomasWaldmann, try pulling now, you should be able to save now :)
115 2013-09-22T10:59:11 <ThomasWaldmann> yeah, works now
116 2013-09-22T10:59:29 <ThomasWaldmann> still that None is a bit strange
117 2013-09-22T10:59:47 <sharky993> i think it will not be once there are docs describing that :) ?
118 2013-09-22T10:59:50 <ThomasWaldmann> users might think that None has some special meaning within acl strings.
119 2013-09-22T11:00:59 <sharky993> we could call that by a different name, which is more obvious, like "NoACLStringExistsCurrently"
120 2013-09-22T11:01:02 <ThomasWaldmann> ok, any other questions for sharky993 ?
121 2013-09-22T11:01:16 <ThomasWaldmann> not that much better
122 2013-09-22T11:01:31 <sharky993> an open-end i guess :)
123 2013-09-22T11:01:37 <ThomasWaldmann> if there is no acl, it shouldn't have any content
124 2013-09-22T11:01:51 <sharky993> i had initially planned on using "None" and "Empty"
125 2013-09-22T11:01:58 <ThomasWaldmann> or maybe tell there is no acl and let you add one
126 2013-09-22T11:02:49 <sharky993> hmm, maybe discuss again with TheSheep
127 2013-09-22T11:03:06 <ThomasWaldmann> maybe have an issue about this.
128 2013-09-22T11:03:13 <ThomasWaldmann> on the tracker
129 2013-09-22T11:03:24 <sharky993> a comment under Complex ACL UI should work, no?
130 2013-09-22T11:03:41 <ThomasWaldmann> no, that's fundamental
131 2013-09-22T11:03:59 <sharky993> right so simple ACL UI.
132 2013-09-22T11:04:18 <ThomasWaldmann> ok, looks like we are through for today. sharky993 please grab TheSheep later.
133 2013-09-22T11:04:44 <ThomasWaldmann> so to everybody who made it here, thanks for attending.
134 2013-09-22T11:04:53 <ThomasWaldmann> use your remaining gsoc time wisely. :)
135 2013-09-22T11:08:03 <ashutosh1461> ThomasWaldmann, https://bitbucket.org/ashu1461/moin-2.0/issue/26/ugly-40-in-links . This is a problem in flask, right ?
136 2013-09-22T11:11:39 <ThomasWaldmann> flask or werkzeug and our choice of @
137 2013-09-22T11:13:02 <ashutosh1461> so what can we do ? apart from changing the '@' ?
138 2013-09-22T11:15:12 <ThomasWaldmann> we can investigate whether it should be urlquoted
139 2013-09-22T11:15:24 <ThomasWaldmann> same thing as for + btw
140 2013-09-22T11:16:01 <ThomasWaldmann> it's not high prio, there are maybe more important things to work on now
141 2013-09-22T11:16:36 <ashutosh1461> hmm, correct, i just wanted to confirm.
142 2013-09-22T11:17:02 * ashutosh1461 does some testing.
143 2013-09-22T11:18:00 <ananasova> ThomasWaldmann: updated the documentation crs, https://codereview.appspot.com/13334053/ and https://codereview.appspot.com/13457059/
144 2013-09-22T11:18:30 *** ashutosh1461
145 2013-09-22T11:20:42 * sharky993 bbl
146 2013-09-22T11:20:49 *** sharky993
147 2013-09-22T11:20:59 * TheSheep reads the backlog
148 2013-09-22T12:10:59 *** ashutosh1461
149 2013-09-22T12:13:07 *** eSyr
150 2013-09-22T12:24:47 *** greg_f
151 2013-09-22T13:40:04 *** ashutosh1461
152 2013-09-22T13:54:30 *** ashutosh1461
153 2013-09-22T15:26:11 *** sunu
154 2013-09-22T15:27:39 *** sunuununununu
155 2013-09-22T15:46:17 *** sunu
156 2013-09-22T15:50:54 *** sunu
157 2013-09-22T16:16:12 *** RogerHaase
158 2013-09-22T16:26:27 *** sharky993
159 2013-09-22T16:26:35 <sharky993> re
160 2013-09-22T17:42:00 *** greg_f
161 2013-09-22T19:04:18 *** sharky993
162 2013-09-22T19:52:24 <dreimark> moin
163 2013-09-22T19:55:47 <dreimark> sorry for haveing so less time at the moment.
164 2013-09-22T19:56:45 <ashutosh1461> moin
165 2013-09-22T20:23:40 <ananasova> ThomasWaldmann: updated docs - https://codereview.appspot.com/13334053/ and https://codereview.appspot.com/13457059/
166 2013-09-22T20:24:54 <ananasova> dreimark: ^ if you have some time, you can check the docs if those are clear enough :)
167 2013-09-22T20:25:22 <ThomasWaldmann> re
168 2013-09-22T20:38:17 <ananasova> ThomasWaldmann: waldi: left a comment here - https://bitbucket.org/ana-balica/moin-2.0/issue/10/relative-sizes-for-mail-notification
169 2013-09-22T21:17:45 <ananasova> also left a comment here https://codereview.appspot.com/13274046/
170 2013-09-22T21:26:13 *** RogerHaase
171 2013-09-22T21:36:55 *** ashutosh1461
172 2013-09-22T22:42:31 <ThomasWaldmann> TheSheep: can you comment on ananasova's issue?
