1 2013-11-28T00:00:33 *** woleium
2 2013-11-28T02:09:39 *** sudo_dirk_
3 2013-11-28T02:10:35 *** sudo_dirk
4 2013-11-28T09:32:03 *** greg_f
5 2013-11-28T09:37:03 *** greg__
6 2013-11-28T09:39:54 *** greg_f
7 2013-11-28T09:58:45 <sharky93> moin
8 2013-11-28T09:59:25 * sharky93 fixed a blocker with merging the boostrap changes.
9 2013-11-28T09:59:56 <sharky93> one remains. #75.
10 2013-11-28T10:00:11 * sharky93 not sure how to proceed with that. @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/75/bootstrap-less-source-without-license
11 2013-11-28T10:05:36 <ThomasWaldmann> well, add a license?
12 2013-11-28T10:05:54 <ThomasWaldmann> but also think about how these files shall be maintained.
13 2013-11-28T10:06:25 <ThomasWaldmann> e.g. bootstrap creates a new release now and then, how shall these copies get updated?
14 2013-11-28T10:06:52 <ThomasWaldmann> it seems that there is not just that license issue, but a maintenance issue
15 2013-11-28T10:06:58 <ThomasWaldmann> sharky93: ^
16 2013-11-28T10:13:02 <ThomasWaldmann> hmm, looks like TheSheep is away.
17 2013-11-28T10:16:48 <sharky93> ThomasWaldmann: keeping the maintenance in mind, our addition to that set of less files is only "basic.less", everything else can be directly updated as an when bootstrap updates
18 2013-11-28T10:17:27 <sharky93> the only issue would be if they change the names of classes, which i think they don't unless its a big bump, say from v3 to 4 :)
19 2013-11-28T10:18:12 <ThomasWaldmann> is that documented/assured somewhere?
20 2013-11-28T10:18:47 * sharky93 is not sure, but i remember having a discussion with thesheep about it
21 2013-11-28T10:19:14 <ThomasWaldmann> and if that is the case, wouldn't it be easier if someone just copies(?) the bs files into that directory ad-hoc if he needs to compile the css with new mods?
22 2013-11-28T10:19:41 <sharky93> yes, but isn't that added work for the developer?
23 2013-11-28T10:19:55 <ThomasWaldmann> currently we still have a slight license problem btw as it is still apache lic
24 2013-11-28T10:20:23 <ThomasWaldmann> sharky93: not much if it is clear what needs to be done.
25 2013-11-28T10:20:41 <sharky93> hmm
26 2013-11-28T10:20:47 <ThomasWaldmann> it is much more work finding out what to do or how to maintain that stuff or what version we have copied or ...
27 2013-11-28T10:20:59 <ThomasWaldmann> or what was modified and what not
28 2013-11-28T10:21:16 <ThomasWaldmann> so i suggest you find out what bs version you used
29 2013-11-28T10:21:31 <ThomasWaldmann> then do a diff between the stuff in the repo and the original
30 2013-11-28T10:21:53 <ThomasWaldmann> check if basic.less is really the only mod
31 2013-11-28T10:22:10 <ThomasWaldmann> if so, remove everything else, document how to compile a new css
32 2013-11-28T10:22:32 <ThomasWaldmann> that solve both the license and the maintenance issue
33 2013-11-28T10:23:18 <ThomasWaldmann> AND you need to put a license into your own file
34 2013-11-28T10:23:35 <sharky93> ThomasWaldmann: isn't using the compiled css a license issue?
35 2013-11-28T10:26:02 <ThomasWaldmann> apache thinks it is not. and soon it won't be for sure.
36 2013-11-28T10:26:21 <ThomasWaldmann> but not having all these copies in our repo would be a big plus.
37 2013-11-28T10:26:48 <ThomasWaldmann> i am not sure about the best license for your own file.
38 2013-11-28T10:27:03 <ThomasWaldmann> maybe triple-license it under gpl v2+, apache v2 and MIT :D
39 2013-11-28T10:27:58 <ThomasWaldmann> waldi: ? ^
40 2013-11-28T10:28:41 <ThomasWaldmann> (we can remove apache lic v2 as soon as bootstrap has finally made it to MIT)
41 2013-11-28T10:29:18 * ThomasWaldmann brb
42 2013-11-28T10:34:31 * sharky93 likes WTFPL :D
43 2013-11-28T11:23:36 <sharky93> ThomasWaldmann: i checked with the bs version i used, its 3.0.0, current release is 3.0.2, there is a difference of 867 commits between them :D .. um, so should I just add to the docs about the version with which basic.less will work and then remove the copies of less files from our repo?
44 2013-11-28T11:25:59 <ThomasWaldmann> sharky93: you add the version info to basic.less, in a comment near the top, below the license/copyright
45 2013-11-28T11:26:15 <ThomasWaldmann> and you first do the diff between what's in the repo and 3.0.0
46 2013-11-28T11:27:12 <ThomasWaldmann> also, add a pointer in basic.less to the docs you wrote about how to deal with css/less/bootstrap.
47 2013-11-28T11:27:35 <ThomasWaldmann> in the docs, add info about the needed copying (if there is no better way than copying)
48 2013-11-28T11:59:42 <sharky93> ThomasWaldmann: i checked, it matches with 3.0.0 RC1 .. does that work?
49 2013-11-28T12:32:48 *** greg_f
50 2013-11-28T12:34:39 *** greg__
51 2013-11-28T12:40:45 *** greg_f
52 2013-11-28T12:41:58 *** greg_f
53 2013-11-28T13:09:28 <ThomasWaldmann> sharky93: if it exactly matches with rc1 but not with 3.0 release, then document it like that for now
54 2013-11-28T13:17:52 *** RogerHaase
55 2013-11-28T13:20:50 *** greg_f
56 2013-11-28T13:37:37 <sharky93> ThomasWaldmann: sadly, it doesn't match 100%, what do you suggest? should i try making it compliant with 3.0.0 RC1 ?
57 2013-11-28T14:07:09 *** greg_f
58 2013-11-28T15:32:54 <ThomasWaldmann> sharky93: doesn't it match because you modified it?
59 2013-11-28T16:14:13 *** brunomartin
60 2013-11-28T16:39:14 <sharky93> ThomasWaldmann: no, we used a wip version, hence the issue now, it doesnt match 100% with rc1 nor with rc2 :( .. though closer to rc1.
61 2013-11-28T16:42:47 <ThomasWaldmann> if it's not about changes DONE BY YOU, I guess it doesn't matter
62 2013-11-28T16:43:03 <ThomasWaldmann> maybe some fixes by bootstrap devs
63 2013-11-28T16:43:19 <ThomasWaldmann> so just document it works with 3.0 rc1
64 2013-11-28T16:43:25 <ThomasWaldmann> sharky93: ^^
65 2013-11-28T16:44:11 <ThomasWaldmann> and after that cleanup commit, I suggest upgrading to and testing with a more recent release of bootstrap
66 2013-11-28T16:52:54 <sharky93> ThomasWaldmann: in the changelogs, i see some class renames :/ , maybe we should try to make it work with rc1, then document and get rid of the native less files.
67 2013-11-28T17:41:13 *** greg_f
68 2013-11-28T18:11:32 <ThomasWaldmann> sharky93: that's what I said
69 2013-11-28T18:12:26 * ThomasWaldmann bbl
70 2013-11-28T20:58:31 *** brunomartin
71 2013-11-28T21:50:13 <sharky93> ThomasWaldmann: The WIP version of bootstrap which we had in the repo date 5th August. RC1 is 27th July, RC2 is 14th Aug.
72 2013-11-28T21:50:37 <sharky93> in any case, the changes had to break some part of the code so. i think going to RC2 is better.
73 2013-11-28T21:50:40 * sharky93 working on it.
74 2013-11-28T21:55:03 <sharky93> infact, breaks many things :/
75 2013-11-28T23:07:20 *** RogerHaase
76
