1 2014-05-21T00:27:11  *** derdon has quit IRC
   2 2014-05-21T00:28:34  *** sl33k_ has quit IRC
   3 2014-05-21T01:21:30  *** magu_cic_ has joined #moin-dev
   4 2014-05-21T01:24:01  *** magu_cic has quit IRC
   5 2014-05-21T05:53:02  *** magu_cic has joined #moin-dev
   6 2014-05-21T05:56:02  *** magu_cic_ has quit IRC
   7 2014-05-21T08:43:57  *** randomax has joined #moin-dev
   8 2014-05-21T09:00:05  *** greg_f has joined #moin-dev
   9 2014-05-21T09:13:47  *** sl33k_ has joined #moin-dev
  10 2014-05-21T09:20:28  *** sl33k_ has quit IRC
  11 2014-05-21T09:20:51  *** sl33k_ has joined #moin-dev
  12 2014-05-21T09:25:26  *** randomax has quit IRC
  13 2014-05-21T11:08:44  <sl33k_> I want to take up writing automated tests on frontend.diff and frontend.diffraw (if they are not already taken up).
  14 2014-05-21T11:12:44  <sl33k_> from Tests topic at http://moinmo.in/EasyToDo.
  15 2014-05-21T11:35:48  *** randomax has joined #moin-dev
  16 2014-05-21T12:01:25  *** randomax_ has joined #moin-dev
  17 2014-05-21T12:03:21  *** randomax has quit IRC
  18 2014-05-21T12:44:14  *** dave_largo has joined #moin-dev
  19 2014-05-21T12:47:02  *** randomax_ has quit IRC
  20 2014-05-21T12:47:22  *** randomax has joined #moin-dev
  21 2014-05-21T13:31:09  <ThomasWaldmann> sl33k_: always have a space before / after urls you post
  22 2014-05-21T13:31:36  <ThomasWaldmann> so one can select the url by clicking on it and it is really the url you meant
  23 2014-05-21T13:33:01  *** randomax has quit IRC
  24 2014-05-21T13:33:18  *** randomax has joined #moin-dev
  25 2014-05-21T13:33:34  <sl33k_> my bad :)
  26 2014-05-21T13:33:42  <ThomasWaldmann> sl33k_: ok, you'll need to see on what level that can be tested. if you want to really test the behaviour when using that on the web ui, you'll likely need selenium or so
  27 2014-05-21T13:35:09  *** RogerHaase has joined #moin-dev
  28 2014-05-21T14:32:29  *** randomax has quit IRC
  29 2014-05-21T14:45:47  *** skathpalia has joined #moin-dev
  30 2014-05-21T14:46:57  <dimazest> skathpalia: have a look to my PR comments https://codereview.appspot.com/100720043/
  31 2014-05-21T14:47:17  <dimazest> they might be a bit silly though
  32 2014-05-21T14:56:28  <skathpalia> dimazest, I have added comments in the cr
  33 2014-05-21T14:58:13  <dimazest> i see, changing the code would also be a good idea :)
  34 2014-05-21T15:00:23  <skathpalia> Yeah making new changes
  35 2014-05-21T15:01:47  <skathpalia> dimazest, updated the cr
  36 2014-05-21T15:18:07  <skathpalia> dimazest, I have pushed the new code to the cr
  37 2014-05-21T15:19:30  <dimazest> btw, it should be possible to send revisions, then the comments are not lost
  38 2014-05-21T15:22:38  <skathpalia> send revisions?
  39 2014-05-21T15:23:15  <dimazest> https://codereview.appspot.com/80700049/
  40 2014-05-21T15:23:22  <dimazest> here are several revisions of a patch
  41 2014-05-21T15:24:26  <skathpalia> Yeah I updated that cr only i.e. made a new revision https://codereview.appspot.com/100720043/
  42 2014-05-21T15:27:36  *** RogerHaase has quit IRC
  43 2014-05-21T15:32:15  <skathpalia> dimazest, I have given explanation of the change in my cr
  44 2014-05-21T15:35:38  <dimazest> ThomasWaldmann or somebody else, could you have a look to https://codereview.appspot.com/100720043/
  45 2014-05-21T15:40:50  <ThomasWaldmann> dimazest: just did that
  46 2014-05-21T15:41:53  <ThomasWaldmann> skathpalia: see that CR and think about my questions
  47 2014-05-21T15:55:45  <skathpalia> dimazest, ThomasWaldmann added some comments in the cr
  48 2014-05-21T15:57:01  <ThomasWaldmann> skathpalia: (a,b) is a tuple
  49 2014-05-21T15:57:08  <ThomasWaldmann> (a) is not
  50 2014-05-21T15:57:33  <ThomasWaldmann> that's because comma is the tuple operator, not the parentheses
  51 2014-05-21T15:58:01  <skathpalia> Oh sorry I should have carefully  done that
  52 2014-05-21T15:58:06  <ThomasWaldmann> so, if you want a 1-tuple, you need (a, )
  53 2014-05-21T15:58:56  <skathpalia> Yeah I think I should do this way only (a, )
  54 2014-05-21T15:59:17  <skathpalia> or just a
  55 2014-05-21T15:59:24  <skathpalia> what do you suggest?
  56 2014-05-21T16:00:01  <ThomasWaldmann> well, there are multiple things to think about here
  57 2014-05-21T16:01:16  <ThomasWaldmann> giving a 2-tuple with string values in one case and just a string in another case is bad and confusing and might lead to strange errors
  58 2014-05-21T16:02:09  <ThomasWaldmann> also, the question is whether giving a 1-tuple in one case and a 2-tuple in another case is helpful if the template has to check for that and then invent the 2nd part magically - you could just give it from the code
  59 2014-05-21T16:03:00  <ThomasWaldmann> so, in the end, if you need 2 things, I'ld say always give a 2-tuple
  60 2014-05-21T16:03:08  <ThomasWaldmann> (things = value and label)
  61 2014-05-21T16:03:24  <skathpalia> yeah so I will send 2 tuple
  62 2014-05-21T16:03:30  <skathpalia> updating the cr
  63 2014-05-21T16:04:02  <ThomasWaldmann> btw, we don't give anything for quickest CR updates. I rather prefer not having too many CRs in too short time.
  64 2014-05-21T16:04:38  <ThomasWaldmann> so take your time to think about whether what you do makes sense and is the best way to solve the problem
  65 2014-05-21T16:05:22  <ThomasWaldmann> (that even applies to before uploading first CR - do the first review yourself before asking mentors)
  66 2014-05-21T16:05:39  <skathpalia> Ok will give some more time to my cr from now onwards
  67 2014-05-21T16:08:40  <ThomasWaldmann> btw, did you see what I meant with "strange errors" when looking at the template code?
  68 2014-05-21T16:09:27  <skathpalia> No I didn't get that part
  69 2014-05-21T16:09:37  <skathpalia> can you please explain it ?
  70 2014-05-21T16:10:01  <ThomasWaldmann> you check for length == 2 meaning the tuple length
  71 2014-05-21T16:10:30  <ThomasWaldmann> but if you don't create a tuple, but just have a string, that will check for strings with length == 2
  72 2014-05-21T16:10:59  <ThomasWaldmann> also, if it's just a simple "else", length 3 would get same treatment as 1
  73 2014-05-21T16:11:02  <skathpalia> Oh yeah I forgot about that
  74 2014-05-21T16:11:20  <skathpalia> Yeah will correct that in next cr
  75 2014-05-21T16:11:38  <skathpalia> Now I will some more time on my next cr
  76 2014-05-21T16:11:54  <skathpalia> Thanks for pointing these out :)
  77 2014-05-21T16:32:09  <skathpalia> dimazest, Actually that try except statement that was there in my cr is required
  78 2014-05-21T16:32:30  <skathpalia> because all the select boxes are made there only
  79 2014-05-21T16:32:48  <skathpalia> and one of the select box is "Assigned to"
  80 2014-05-21T16:33:13  <skathpalia> which is for user which has name which needs to be displayed in the select list
  81 2014-05-21T16:47:26  <ThomasWaldmann> btw, "except:" is usually an antipattern
  82 2014-05-21T16:47:49  <ThomasWaldmann> maybe look at "python antipattern" internet search results
  83 2014-05-21T16:50:18  <skathpalia> Ok will search for that
  84 2014-05-21T17:21:27  *** RogerHaase has joined #moin-dev
  85 2014-05-21T17:23:31  *** derdon has joined #moin-dev
  86 2014-05-21T17:25:13  *** greg_f has quit IRC
  87 2014-05-21T17:40:18  *** skathpalia has quit IRC
  88 2014-05-21T18:25:33  *** RogerHaase has quit IRC
  89 2014-05-21T20:40:03  *** RogerHaase has joined #moin-dev
  90 2014-05-21T20:46:31  *** dave_largo has quit IRC
  91 2014-05-21T21:58:05  *** RogerHaase has left #moin-dev
  92 2014-05-21T22:46:14  *** sl33k__ has joined #moin-dev
  93 2014-05-21T22:49:33  *** sl33k_ has quit IRC
  94

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-05-21 (last edited 2014-05-21 00:30:02 by IrcLogImporter)