1 2014-05-24T03:49:29 *** sl33k_
2 2014-05-24T06:09:01 *** sl33k_
3 2014-05-24T06:30:51 *** skathpalia
4 2014-05-24T06:31:15 <skathpalia> ThomasWaldmann, code review needed https://codereview.appspot.com/100720043/
5 2014-05-24T06:31:25 <skathpalia> I got it reviewed by dimazest
6 2014-05-24T06:31:41 <skathpalia> Please have a look at it then I will commit it
7 2014-05-24T06:40:58 <skathpalia> ananasova, in MoinMoin/util/notifications.py there is Notification class defined which is having a field item_name which can be None also so I think a solution can be to have fqname field instead of item_name
8 2014-05-24T06:42:23 <skathpalia> What do you say about this solution
9 2014-05-24T06:42:24 <skathpalia> ?
10 2014-05-24T06:43:27 <skathpalia> Then the subscribers will be notified of ITEMID incase there is no name
11 2014-05-24T07:37:50 <ananasova> moin
12 2014-05-24T07:38:02 <ananasova> skathpalia: you mean like that? https://codereview.appspot.com/65070043/
13 2014-05-24T07:39:02 *** sl33k_
14 2014-05-24T08:25:54 <skathpalia> but ananasova here you haven't changed the item_name field in Notification class
15 2014-05-24T08:35:40 <ananasova> wait, let me check
16 2014-05-24T08:36:26 <ananasova> ah, this is patch on subscription API
17 2014-05-24T08:37:56 <ananasova> what is the use case having an item_name = None when creating a Notification obj?
18 2014-05-24T08:38:12 <ananasova> i am a little behind with all the latest updates
19 2014-05-24T08:39:27 <skathpalia> According to the project done by ashutosh last year an item can be such that it has no name
20 2014-05-24T08:40:14 <skathpalia> But notification part is dependent on item_name so it crashes when item has no name
21 2014-05-24T08:40:55 <skathpalia> thats why I gave the idea if having fqname instead of item_name
22 2014-05-24T08:42:20 <ananasova> hm.. ok, and this item is available to the users? can one receive a notification about an item change that has no name?
23 2014-05-24T08:43:24 <skathpalia> According to the current code user can't receive notification regarding such object
24 2014-05-24T08:43:42 <skathpalia> Yeah this item is accessible by itemid
25 2014-05-24T08:44:26 <ananasova> ok
26 2014-05-24T08:45:16 <ananasova> so you need the change asap?
27 2014-05-24T08:46:31 <skathpalia> Actually I wanted to get some guidance for changing the current code as you have worked on this project
28 2014-05-24T08:47:10 <ananasova> sure, ask :)
29 2014-05-24T08:48:05 <ananasova> notification class builds and formats the contents of a mail notification
30 2014-05-24T08:48:40 <ananasova> we have templates written in jinja2 that are rendered with all the relevant information
31 2014-05-24T08:49:01 <skathpalia> according to me changing the item_name to fqname in Notification class would work
32 2014-05-24T08:49:08 <skathpalia> what do you suggest?
33 2014-05-24T08:49:22 <skathpalia> I mean your views on this change
34 2014-05-24T08:51:36 <ananasova> if you can't build an item from fqname how are you going to create a diff?
35 2014-05-24T08:53:20 <ananasova> or is it possible to retrieve an item via fqname in this case always?
36 2014-05-24T08:53:42 <skathpalia> Yeah we can always retieve an item by fqname
37 2014-05-24T08:53:57 <skathpalia> whether an item has name or not
38 2014-05-24T08:54:01 *** randomax
39 2014-05-24T08:55:03 <ananasova> in this case, the change is possible. you just need to be careful with notification main sentences that uses the name of the item
40 2014-05-24T08:56:03 <ananasova> i.e. it must be substituted by something else that will be relevant and clear for users
41 2014-05-24T08:57:07 <ananasova> and it also implies some changes to the notification templates
42 2014-05-24T08:57:12 <skathpalia> Yeah I have tried changing the item_name to fqname at many places here in notification but 3-4 tests are failing after my change
43 2014-05-24T08:57:24 <ananasova> yeah, they should
44 2014-05-24T08:57:59 <ananasova> you need to make more changes here
45 2014-05-24T09:00:25 <skathpalia> Also ananasova How can I set a mail server to check the mail from moin?
46 2014-05-24T09:05:07 <ananasova> http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=mail#mail-configuration
47 2014-05-24T09:21:10 <skathpalia> ananasova, do we need to change here the username password etc?
48 2014-05-24T09:23:22 <skathpalia> and also which port is used for sending mail?
49 2014-05-24T09:26:34 <skathpalia> I mean the default port that moin uses for sending mail ?
50 2014-05-24T09:31:38 <skathpalia> ananasova, ^^
51 2014-05-24T09:37:30 <ananasova> if you want to use SMTP, then yes - you need to change username/password
52 2014-05-24T09:38:28 <ananasova> the port depends on the smtp server
53 2014-05-24T09:38:49 <ananasova> it's not moin dependent
54 2014-05-24T09:39:12 <skathpalia> like I am using smtp.gmail.com as smtp server
55 2014-05-24T09:39:30 <skathpalia> which runs on port 465
56 2014-05-24T09:39:40 <skathpalia> then how can I specify the port?
57 2014-05-24T09:40:11 <ananasova> smtp.server.org:port
58 2014-05-24T09:40:32 <skathpalia> Ok thanks :)
59 2014-05-24T09:40:51 <ananasova> :)
60 2014-05-24T09:47:40 <skathpalia> ananasova, I did the changes but still I didn't receive any mail on modification of the subscribed item
61 2014-05-24T09:48:13 <skathpalia> Is there something else also that needs to be changed for receiving mail?
62 2014-05-24T09:50:55 <ananasova> did you register? is your account verified?
63 2014-05-24T09:51:29 <skathpalia> I registered but account is not verified
64 2014-05-24T09:52:14 <skathpalia> You mean I have to register as new user and then I will receive a verification mail and then only I will be able to receive notifications?
65 2014-05-24T09:52:19 <skathpalia> right?
66 2014-05-24T09:53:34 <ananasova> well, verified means that it is verified by admins
67 2014-05-24T09:53:55 <ananasova> for now you can change the meta from the wiki storage
68 2014-05-24T09:54:26 <ananasova> or
69 2014-05-24T09:54:32 <ananasova> http://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=mail#user-e-mail-address-verification
70 2014-05-24T09:54:38 <ananasova> set it to false
71 2014-05-24T09:56:31 <skathpalia> ananasova, If I set it to false then my account will be considered verified ?
72 2014-05-24T09:56:50 <skathpalia> I mean if I create a new account and this flag is false
73 2014-05-24T09:56:55 <ananasova> yes
74 2014-05-24T09:57:01 <ananasova> i think there was a fix for that
75 2014-05-24T09:58:10 <skathpalia> But in mine it is already false
76 2014-05-24T09:58:23 <ananasova> ok
77 2014-05-24T09:58:33 <ananasova> then check what your profile meta has
78 2014-05-24T10:00:14 <skathpalia> What do I need to check in profile meta?
79 2014-05-24T10:00:46 <ananasova> search for verified key
80 2014-05-24T10:00:51 <ananasova> True/False
81 2014-05-24T10:02:16 <skathpalia> you mean EMAIL_UNVALIDATED Key?
82 2014-05-24T10:03:36 <ananasova> something like that.
83 2014-05-24T10:03:55 <ananasova> it's pretty intuitive, i don't remember exactly the name of ti
84 2014-05-24T10:03:57 <ananasova> it*
85 2014-05-24T10:04:39 <skathpalia> Ok I am setting this key to False
86 2014-05-24T10:08:36 <skathpalia> ananasova, Still no mail is received
87 2014-05-24T10:09:08 <skathpalia> Also I found out that https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/util/notifications.py?at=default#cl-214 here this set has no element
88 2014-05-24T10:09:32 <skathpalia> even though a user is subscribed to that item which is modified
89 2014-05-24T10:10:52 <ananasova> check the logs, read some documentation. it's hard to debug something i don't see and i can't try
90 2014-05-24T10:11:22 <ananasova> i am glad to help you and by no means i am being rude to you, but some of the answers can be found in the documentation. try to search there first :)
91 2014-05-24T10:15:26 <skathpalia> sorry for that
92 2014-05-24T10:17:02 <skathpalia> Actually I searched the documentation but I couldn't understand some parts
93 2014-05-24T10:24:55 <ananasova> ok
94 2014-05-24T10:26:37 <skathpalia> ananasova, Can you please pull the new code from the repo and try mail configuration?
95 2014-05-24T10:27:21 <ananasova> in 5 minutes :)
96 2014-05-24T10:27:29 <skathpalia> Thanks :)
97 2014-05-24T10:39:19 <ananasova> wow, bitbucket interface changed
98 2014-05-24T10:40:13 <skathpalia> yeah it changed few days back only :)
99 2014-05-24T10:58:26 <ananasova> there is a bug
100 2014-05-24T10:59:32 *** randomax
101 2014-05-24T10:59:47 <ananasova> or maybe i need to update venv and index
102 2014-05-24T11:00:53 <ananasova> the bug is exactly where you pointed out
103 2014-05-24T11:02:39 <skathpalia> in notifications.py ?
104 2014-05-24T11:03:01 <skathpalia> in subscribers_locale part?
105 2014-05-24T11:03:14 <ananasova> oh, i see where the problem is
106 2014-05-24T11:03:24 <ananasova> just few more minutes
107 2014-05-24T11:15:52 <ananasova> :D
108 2014-05-24T11:16:00 <ananasova> this is hilarious
109 2014-05-24T11:16:43 <ananasova> i forgot we implemented the following: user that makes the change to an item is not getting a mail notification, since he already knows about his change
110 2014-05-24T11:17:03 <skathpalia> Oh
111 2014-05-24T11:17:21 <ananasova> so you need 2 users to check the functionality
112 2014-05-24T11:17:47 <skathpalia> Ok checking with that
113 2014-05-24T11:17:51 <ananasova> ok, just tested it. it works
114 2014-05-24T11:23:08 <skathpalia> ananasova, did you use smtp server for testing it ?
115 2014-05-24T11:28:02 <ananasova> yup
116 2014-05-24T11:28:41 <ananasova> btw there is a maybe "bug".. not sure about that
117 2014-05-24T11:29:47 <ananasova> but when creating a new user, the email is set to unvalidated in any case
118 2014-05-24T11:29:56 <ananasova> maybe there is some specific workflow here
119 2014-05-24T11:30:21 <ananasova> don't forget to change "email_unvalidated" key to "email"
120 2014-05-24T11:30:46 <ananasova> bbl
121 2014-05-24T11:42:17 *** randomax
122 2014-05-24T11:44:13 *** skathpalia
123 2014-05-24T11:45:52 *** skathpalia
124 2014-05-24T12:09:44 *** sl33k_
125 2014-05-24T12:38:59 *** randomax
126 2014-05-24T12:46:19 *** skathpalia
127 2014-05-24T12:52:39 <ThomasWaldmann> moin
128 2014-05-24T12:59:04 *** skathpalia
129 2014-05-24T13:20:20 <ThomasWaldmann> dimazest: dreimark: waldi: meeting at 16:00 UTC
130 2014-05-24T13:20:35 <dimazest> ok
131 2014-05-24T13:20:43 <ThomasWaldmann> let's see if the mentors/students set a reminder ;)
132 2014-05-24T13:20:45 <dimazest> is it via irc, or something else?
133 2014-05-24T13:20:50 <ThomasWaldmann> here
134 2014-05-24T13:21:21 <ananasova> yey first moin meeting this gsoc \o/
135 2014-05-24T13:25:16 * ThomasWaldmann is currently still in another meeting. if students join here, please point them to https://moinmo.in/GoogleSoc2014 for preparations
136 2014-05-24T13:28:42 *** skathpalia
137 2014-05-24T13:29:24 <skathpalia> ThomasWaldmann, review needed for ticket update https://codereview.appspot.com/100720043/
138 2014-05-24T13:57:04 <ananasova> skathpalia: i will take a look later :)
139 2014-05-24T13:58:12 <skathpalia> np
140 2014-05-24T14:00:52 <ThomasWaldmann> skathpalia: see cr
141 2014-05-24T14:04:10 <skathpalia> ThomasWaldmann, when the item has no name then we will be referring to the index meta[NAME][0] which is not there
142 2014-05-24T14:04:18 <skathpalia> so indexerror would occur
143 2014-05-24T14:05:48 <skathpalia> So I just fill u'' instead of name if such a situation occurs
144 2014-05-24T14:06:41 <skathpalia> ThomasWaldmann, Can you explain me the flaw you are pointing in this cr?
145 2014-05-24T14:07:36 <ThomasWaldmann> skathpalia: you deal with multiple revs
146 2014-05-24T14:08:38 <skathpalia> yeah this is for multiple items
147 2014-05-24T14:09:12 <skathpalia> i am taking name if all the items have name
148 2014-05-24T14:09:20 <skathpalia> otherwise I take ITEMID
149 2014-05-24T14:10:41 <skathpalia> I am still not able to get your point
150 2014-05-24T14:13:52 *** magu_cic_
151 2014-05-24T14:14:26 <skathpalia> ThomasWaldmann, ^^
152 2014-05-24T14:19:22 *** magu_cic
153 2014-05-24T14:22:33 *** randomax
154 2014-05-24T14:24:29 *** greg_f
155 2014-05-24T14:25:30 *** RogerHaase
156 2014-05-24T14:26:16 <ThomasWaldmann> skathpalia: one rev causes an IndexError, then you "fix" that by treating all revs the no-name way
157 2014-05-24T14:28:04 <randomax> RogerHaase, code review needed https://codereview.appspot.com/91680043/
158 2014-05-24T14:28:32 <skathpalia> Yeah ThomasWaldmann dimazest also pointed the same
159 2014-05-24T14:28:41 <randomax> RogerHaase, fixed the quicklinks exceeding the box and also their tooltip
160 2014-05-24T14:29:49 <skathpalia> but is some items have name and some so not then the list should contain either ITEMIDs or names
161 2014-05-24T14:30:21 <skathpalia> suppose if some have name and some have itemid then if I consider the name for those named items
162 2014-05-24T14:31:00 <skathpalia> Then select list would have some options having ITEMID while some will have name
163 2014-05-24T14:31:58 <skathpalia> It would be difficult for user to identify which one is name and which one is ITEMID especially when item name has length 32
164 2014-05-24T14:32:34 <skathpalia> for removing this ambiguity only I took either all names or all itemids
165 2014-05-24T14:34:33 * ThomasWaldmann brb
166 2014-05-24T14:40:25 <RogerHaase> randomax: done
167 2014-05-24T14:42:28 <randomax> RogerHaase, the title being used there is wrong as it refers to the page title... so if i open a page titled "MyMoinmoin", all the quicklink tooltips show "MyMoinmoin"
168 2014-05-24T14:44:10 <randomax> And i guess 15 is the optimum size for each theme.. 25 characters gets a bit too long i guess.. but i can try sending in values separately for basic theme if you say so..
169 2014-05-24T14:44:33 *** greg_f
170 2014-05-24T14:47:50 <RogerHaase> randomax: for a page with a long name, the tool tip is truncated to 24 characters, should the tool tipe be the whole name?
171 2014-05-24T14:49:33 <RogerHaase> 24/25
172 2014-05-24T14:50:18 <RogerHaase> randomax: modernized is sthll showing 25 for me, is modernized code passing in a length?
173 2014-05-24T14:52:03 <RogerHaase> foobar also 25
174 2014-05-24T14:55:52 <RogerHaase> randomax: if you committed the previous patch, it would be helpful if you pushed to public repo
175 2014-05-24T14:56:35 *** mansi
176 2014-05-24T14:58:19 <RogerHaase> randomax: I see the "MyMoinmoin" mouseover bug also exists in modernized and foobar - fix modernized, ignore foobar
177 2014-05-24T14:59:12 <randomax> RogerHaase, yes i'll push.. and yeah i noticed that mordernized and foobar do not get affected and am looking into it.. regarding the tooltip i've seen both kinds of tooltips -long and shortened.. i'll try with a full length one and come up with the answer
178 2014-05-24T15:00:07 <randomax> yeah sorry.. i saw that just now.. brb..
179 2014-05-24T15:07:30 <ThomasWaldmann> skathpalia: maybe make a list of usecases when this code is used. i guess we need to know that before deciding what's best.
180 2014-05-24T15:20:05 <ThomasWaldmann> skathpalia: could be that we want to TELL the code what to use, not just react to an IndexError
181 2014-05-24T15:26:38 *** derdon
182 2014-05-24T15:27:11 <randomax> RogerHaase, the main problem here is the distributed code.. the thing that you had pointed out earlier.. it gets quite confusing as to what code is where.. i'll work on that..
183 2014-05-24T15:29:20 <RogerHaase> randomax: ok, I think I prefer leaving the default name length at 25 and passing in a shorter length. 25 has been default length for long time, even in moin 1.x
184 2014-05-24T15:29:54 <skathpalia> ThomasWaldmann, for tickets the same code is used to generate select list for superseded by, depends on (in these itemids should be displayed as it is for tickets ) and assigned to (here name should be used as it is for the names of the user)
185 2014-05-24T15:31:16 <RogerHaase> randomax: you also need to work on updating EP plan
186 2014-05-24T15:31:36 <randomax> for the next week ?
187 2014-05-24T15:32:30 <skathpalia> I will make soon make a full list of the usecases specifying where else the code is used
188 2014-05-24T15:32:39 <RogerHaase> at least, even longer would be better
189 2014-05-24T15:34:25 <randomax> ok.. i'll do that too :)
190 2014-05-24T15:38:12 *** derdon
191 2014-05-24T15:39:40 * ThomasWaldmann cloned both student repos, both noticed there is no gsoc code in them yet
192 2014-05-24T15:39:42 *** derdon
193 2014-05-24T15:41:16 <RogerHaase> ThomasWaldmann: enhance media support, add mp4 video, mp3 audio, fix wav audio https://codereview.appspot.com/100760044/
194 2014-05-24T15:48:05 <ThomasWaldmann> RogerHaase: done
195 2014-05-24T15:50:14 *** derdon
196 2014-05-24T15:52:07 *** derdon
197 2014-05-24T15:58:14 *** randomax
198 2014-05-24T16:00:02 <ThomasWaldmann> RogerHaase: tried installing stuff from scratch according to the docs, worked (python quickinstall, m sample, m run)
199 2014-05-24T16:01:09 <ThomasWaldmann> ok, 16:00 utc, welcome to the weekly gsoc meeting
200 2014-05-24T16:01:27 <waldi> moin
201 2014-05-24T16:01:40 <ThomasWaldmann> skathpalia: are you ready for updating us?
202 2014-05-24T16:01:47 <skathpalia> yeah
203 2014-05-24T16:02:11 <dimazest> hello
204 2014-05-24T16:02:24 <ThomasWaldmann> ok, skathpalia, your stage :)
205 2014-05-24T16:02:30 <skathpalia> This week I tried to make ticket update work properly
206 2014-05-24T16:02:40 <ThomasWaldmann> can someone ping randomax, he should be with us
207 2014-05-24T16:03:38 <skathpalia> as per this cr https://codereview.appspot.com/100720043/ ticket update is working but notification module is not working properly
208 2014-05-24T16:03:49 <skathpalia> But still ticket is updated properly
209 2014-05-24T16:04:18 <skathpalia> My next week task would be to remove this error in notification module
210 2014-05-24T16:04:45 <dimazest> and make the code pretty and tidy :)
211 2014-05-24T16:04:45 <skathpalia> I have started my work on this and also made a small cr https://codereview.appspot.com/93570043
212 2014-05-24T16:04:56 <skathpalia> sure dimazest
213 2014-05-24T16:05:43 <skathpalia> Actually the notification module is dependent on item_name which is not there in case of tickets so it crashes on tickets
214 2014-05-24T16:06:42 <skathpalia> not only on tickets it crashes on all those items which have no name so main task for the next week is to use fqname instead of item_name in this notification module
215 2014-05-24T16:07:48 <ThomasWaldmann> skathpalia: your progress last week, how much was it blocked by you waiting for CR feedback?
216 2014-05-24T16:08:17 *** randomax
217 2014-05-24T16:08:35 <skathpalia> Yeah somewhat
218 2014-05-24T16:08:48 <skathpalia> dimazest, ThomasWaldmann I have also added some information at the end of my EP( http://etherpad.osuosl.org/moin-ticket-blog ) regarding the tentative schedule upto week 4
219 2014-05-24T16:09:19 <ThomasWaldmann> skathpalia: you know what an operating system does while waiting for I/O?
220 2014-05-24T16:10:16 <skathpalia> do some other processing work which is not dependent on that I/O
221 2014-05-24T16:10:41 <dimazest> i think it makes sense to clean up the EP, so a complete stranger could understand what's the progress
222 2014-05-24T16:11:22 <skathpalia> Yeah thats my mistake would clean it by tonight
223 2014-05-24T16:11:54 <ThomasWaldmann> skathpalia: exactly. think about how you can do same. might speedup your progress a lot.
224 2014-05-24T16:12:18 <skathpalia> Yeah in the mean time i saw how we can run query for extracting tickets and also worked on some notification work also
225 2014-05-24T16:12:43 <ThomasWaldmann> etherpad should be "documentation mode" stuff, no chat style
226 2014-05-24T16:12:49 <skathpalia> Yeah will try to work with more speed
227 2014-05-24T16:14:21 <skathpalia> ThomasWaldmann, I will clean it by tonight
228 2014-05-24T16:14:34 <dimazest> are you familiar with tests?
229 2014-05-24T16:14:43 <skathpalia> Not much
230 2014-05-24T16:15:05 <skathpalia> I just saw one or two test of moin
231 2014-05-24T16:15:11 <skathpalia> unit tests ^
232 2014-05-24T16:15:12 <dimazest> ideally, why you change code (this is your next task) test coverage helps a lot
233 2014-05-24T16:15:51 <dimazest> because it protects from mistakes and can point to code that you didn't even think needs changing
234 2014-05-24T16:16:25 <ThomasWaldmann> skathpalia: do you run the tests after making changes?
235 2014-05-24T16:16:28 <dimazest> you should at least run the tests and see that there are no new failing tests
236 2014-05-24T16:16:39 <skathpalia> Yeah for the next task its necessary as there is a faling test for that
237 2014-05-24T16:17:17 <skathpalia> Yeah usually I run the tests after change
238 2014-05-24T16:17:22 <ThomasWaldmann> ok
239 2014-05-24T16:17:33 <skathpalia> I did it every time I worked on notifications part
240 2014-05-24T16:17:57 <ThomasWaldmann> skathpalia: i just ran the pre-gsoc code and created a new ticket
241 2014-05-24T16:18:32 <ThomasWaldmann> these dropdown menues show item names of tickets right now and you are changing this to be itemids
242 2014-05-24T16:18:47 <skathpalia> Yeah
243 2014-05-24T16:19:39 <ThomasWaldmann> but, when it is an itemid, the dropdown to add references will lose meaningful content, so there should be some useful text in there also
244 2014-05-24T16:19:57 <ThomasWaldmann> also, itemid should be shortened, likely
245 2014-05-24T16:21:06 <skathpalia> Ok may be we can simply show some initials and some ending part of ITEMID
246 2014-05-24T16:22:06 <ThomasWaldmann> skathpalia: no, likely a prefix makes sense as (in the end) you can use that prefix in the url also
247 2014-05-24T16:22:34 <skathpalia> Yeah this is one is better
248 2014-05-24T16:22:40 <ThomasWaldmann> think git and hg offering usage of shortened cs ids as long as they are unique
249 2014-05-24T16:22:59 <dimazest> yeap
250 2014-05-24T16:23:47 <skathpalia> Ok will try to look for some algorithm to do that
251 2014-05-24T16:24:46 <ThomasWaldmann> iirc we already have a jinja2 filter for that
252 2014-05-24T16:25:24 <ThomasWaldmann> look at the +history view, it only shows a short revid
253 2014-05-24T16:25:44 <skathpalia> Yeah I noticed there
254 2014-05-24T16:25:50 <skathpalia> Ok will look into that
255 2014-05-24T16:26:39 <ThomasWaldmann> if while being blocked on something you have some time for other improvements: you have noticed the ticket UI sucks.
256 2014-05-24T16:27:07 <ThomasWaldmann> so if you are in that code / template anyway, improve whatever you find
257 2014-05-24T16:27:29 <skathpalia> Yeah will try to define some css for tickets
258 2014-05-24T16:28:01 <ThomasWaldmann> you didn't announce anything special blocking you, so there is nothing?
259 2014-05-24T16:28:19 <skathpalia> No nothing :)
260 2014-05-24T16:28:42 <skathpalia> Nothing is blocking me
261 2014-05-24T16:28:51 <ThomasWaldmann> ok, 2 minutes left (30mins per student), any other questions?
262 2014-05-24T16:29:32 <RogerHaase> it would be helpful if both students could close finished code reviews
263 2014-05-24T16:29:33 <ThomasWaldmann> (for / by skathpalia)
264 2014-05-24T16:29:45 <ThomasWaldmann> ah, yes!
265 2014-05-24T16:29:59 * ThomasWaldmann has a pile of unclosed ones also X)
266 2014-05-24T16:30:18 <skathpalia> i don't have any question :)
267 2014-05-24T16:30:36 <dimazest> good then!
268 2014-05-24T16:31:09 <ThomasWaldmann> ok, thanks to skathpalia and dimazest. randomax, you're ready?
269 2014-05-24T16:31:12 <randomax> yes
270 2014-05-24T16:31:17 <ThomasWaldmann> ok, your stage
271 2014-05-24T16:32:00 <randomax> my plan for the week was to improve quicklinks
272 2014-05-24T16:32:11 <randomax> they were exceeding the divs
273 2014-05-24T16:32:11 <ThomasWaldmann> (btw, the content you prepare for the weekly meeting you can also reuse for your blog post)
274 2014-05-24T16:32:34 <ThomasWaldmann> randomax: basic theme?
275 2014-05-24T16:32:39 <randomax> yes
276 2014-05-24T16:33:06 <randomax> the problem turned out to be in the call to the shorten_item_name function itself
277 2014-05-24T16:33:24 <randomax> by default it is supposed to shorten item names to 25 characters or lesser
278 2014-05-24T16:33:44 <randomax> so the 25 characters were exceeding the divs
279 2014-05-24T16:34:01 <ThomasWaldmann> oh :)
280 2014-05-24T16:34:03 <randomax> so solution is to pass a value to the function
281 2014-05-24T16:34:27 <randomax> so i found for the divs in the basic theme
282 2014-05-24T16:34:35 <randomax> the ideal size would be 15 characters
283 2014-05-24T16:35:02 <randomax> also the tooltips of the quicklinks were showing the title of the page
284 2014-05-24T16:35:15 *** magu_cic
285 2014-05-24T16:35:19 <randomax> instead of item related to the quicklink itself
286 2014-05-24T16:35:31 <ThomasWaldmann> maybe it makes sense to fix this in ALL themes and always give a specific value?
287 2014-05-24T16:35:48 <randomax> that too was resolved as the code earlier was using "title"
288 2014-05-24T16:36:02 <randomax> which referred to the page title..
289 2014-05-24T16:36:31 <ThomasWaldmann> randomax: that's not the title of the page for me, but "MyMoinMoin", which is likely the interwikiname
290 2014-05-24T16:37:48 <RogerHaase> right, it was wikiname, but still the wrong thing to use there
291 2014-05-24T16:38:11 <randomax> ok.. i saw "My Moinmoin" in the title of the page too and also the name of the variable was "title"
292 2014-05-24T16:38:17 <randomax> so i got confused
293 2014-05-24T16:38:24 <randomax> my bad..
294 2014-05-24T16:38:40 <ThomasWaldmann> RogerHaase: ofc it is not interesting if it is the "local" wiki, but it might be interesting if the quicklink points to another wiki
295 2014-05-24T16:39:33 <ThomasWaldmann> randomax: so you change(d) it to show what?
296 2014-05-24T16:39:57 <RogerHaase> you can make a quicklink point to another wiki?
297 2014-05-24T16:40:37 <randomax> i currently have changed it to show a 25 character link text.. but I was trying to make show the full length link
298 2014-05-24T16:40:59 <ThomasWaldmann> RogerHaase: iirc, quicklinks are shared in the userprofile and stored as interwiki links like MoinMoin:FrontPage
299 2014-05-24T16:41:55 <randomax> it might make it easier for the user to recognize a link that way
300 2014-05-24T16:42:13 <ThomasWaldmann> as we shorten, showing the full pagename is the right thing i guess. if the page is in another wiki wikiname:pagename maybe?
301 2014-05-24T16:43:09 <randomax> okk.. i'll try to implement that..
302 2014-05-24T16:43:52 <randomax> then the next task was to shorten the sidebar as it was getting too big
303 2014-05-24T16:44:01 <RogerHaase> I am still confused as to how you get a link to another wiki, There is an alternative to clicking the Add Link for the page you are viewing?
304 2014-05-24T16:44:08 *** sl33k_
305 2014-05-24T16:44:51 <ThomasWaldmann> RogerHaase: you could share the profile storage between multiple wikis
306 2014-05-24T16:45:16 <ThomasWaldmann> also, we have namespaces now
307 2014-05-24T16:46:09 <RogerHaase> OK, so to test that we have to setup a wiki farm?
308 2014-05-24T16:46:12 <randomax> ok.. does the quicklink currently store which wiki it belongs to ?
309 2014-05-24T16:47:23 <ThomasWaldmann> randomax: i think so, one could just look into the fs file
310 2014-05-24T16:48:33 <ThomasWaldmann> "quicklinks": ["MyMoinMoin/Home
311 2014-05-24T16:49:00 <ThomasWaldmann> (not just "Home")
312 2014-05-24T16:50:01 <randomax> ok.. i'll try and implement it in "wikiname : pagename" format
313 2014-05-24T16:50:06 <ThomasWaldmann> so, displaying MyMoinMoin wasn't that bad. better would have been MyMoinMoin/Home i guess, esp. since for longer names the rightmost part might be not fully recognizable.
314 2014-05-24T16:50:33 <ThomasWaldmann> randomax: maybe just use what you get as quicklink
315 2014-05-24T16:51:01 *** sl33k_
316 2014-05-24T16:51:21 <randomax> yes currently the variable gives a 25 character version..
317 2014-05-24T16:51:49 <ThomasWaldmann> RogerHaase: yes, maybe also namespace would work (but I first have to get into the current state of namespaces myself)
318 2014-05-24T16:51:54 <randomax> apart from the "title" which gives me the "MyMoinmoin"
319 2014-05-24T16:53:21 <RogerHaase> So, we are saying tooltip should give Title/FullItemName?
320 2014-05-24T16:53:26 <ThomasWaldmann> btw, such mouseovers, maybe we could find a rather generic solution
321 2014-05-24T16:54:15 <ThomasWaldmann> often we show (shortened) references to other items. that might be a (shortened) name or (shortened) itemid and in general the mouseover should be helpful to recognize what we are linking to
322 2014-05-24T16:55:08 <ThomasWaldmann> for a named item, the full wikiname/namespace/itemname is helpful, for a nameless item, i guess we need to either show full itemid or grab description text or so
323 2014-05-24T16:55:57 <ThomasWaldmann> skathpalia can use such code, too ^^
324 2014-05-24T16:56:15 <randomax> is it possible to create nameless items ?
325 2014-05-24T16:56:22 <skathpalia> Yeah
326 2014-05-24T16:56:27 <ThomasWaldmann> yes tickets and soon blog items
327 2014-05-24T16:56:39 <ThomasWaldmann> maybe also threaded discussion at some time
328 2014-05-24T16:56:39 <skathpalia> Also other items can be nameless
329 2014-05-24T16:56:49 <RogerHaase> If we have a nameless ticket item in quicklinks, what is content of quicklink?
330 2014-05-24T16:57:50 <ThomasWaldmann> shortened itemid maybe (namespace could be tickets then)
331 2014-05-24T16:58:47 <ThomasWaldmann> and the bubble could maybe show short description
332 2014-05-24T16:59:30 <ThomasWaldmann> (we should avoid that you have to click the link to get an idea about what it is)
333 2014-05-24T17:00:02 <randomax> ok
334 2014-05-24T17:00:25 <ThomasWaldmann> hmm, issue with that: will have to fetch that stuff from index
335 2014-05-24T17:01:05 <RogerHaase> well, as blog view does not have an Add Link, maybe that is a skathpalia issue
336 2014-05-24T17:01:38 <ThomasWaldmann> randomax: something completely different:
337 2014-05-24T17:03:05 <ThomasWaldmann> "user settings" sub menu bar repeats "settings" quite frequently. in german, "settings" is "einstellungen" which makes these words rather long and the menubar wraps to next line.
338 2014-05-24T17:04:04 <randomax> ok.. i dont think "settings" should be used again and again
339 2014-05-24T17:04:10 <ThomasWaldmann> easy fix: remove "settings" word from sub menu
340 2014-05-24T17:04:38 <randomax> yeah..
341 2014-05-24T17:05:11 <randomax> also this week i had to fix issue #73 in sharky's repo
342 2014-05-24T17:05:22 <randomax> the sidebar was getting too large
343 2014-05-24T17:05:59 <ThomasWaldmann> randomax: can you give some full links to issues, codereview, etc. you worked on this week?
344 2014-05-24T17:06:00 <randomax> so firstly i reduced the padding of the cells like "Home","History" and all other cells in the sidebar
345 2014-05-24T17:06:13 <randomax> from 10px to 5px
346 2014-05-24T17:06:43 <randomax> yeah 1 sec
347 2014-05-24T17:06:59 <randomax> https://codereview.appspot.com/96520046/ for issue #73
348 2014-05-24T17:07:18 <randomax> https://codereview.appspot.com/91680043/ for tooltips and quicklinks
349 2014-05-24T17:08:15 <ThomasWaldmann> ok, will have a look
350 2014-05-24T17:10:40 <ThomasWaldmann> ok, any other questions?
351 2014-05-24T17:11:29 <randomax> nope :)
352 2014-05-24T17:11:37 <RogerHaase> did we get to blocked, next week?
353 2014-05-24T17:12:03 <ThomasWaldmann> RogerHaase: to SEE the result of such changes, what's the best way? apply diff from CR, have screenshots from randomax?
354 2014-05-24T17:12:27 <RogerHaase> I much prefer applying diff
355 2014-05-24T17:12:32 <randomax> i have put up both code reviews and screenshots
356 2014-05-24T17:13:27 <ThomasWaldmann> maybe we could have some "links of the day" sections in etherpad? easier to find than in irc log
357 2014-05-24T17:13:58 <randomax> RogerHaase, i didn't get you - "did we get to blocked, next week?"
358 2014-05-24T17:14:12 <randomax> ThomasWaldmann, yes i'll put up the links over there
359 2014-05-24T17:14:21 <RogerHaase> right
360 2014-05-24T17:14:55 * ThomasWaldmann needs a break for hackerspace dinner, bbl :)
361 2014-05-24T17:15:27 <RogerHaase> OK, then since time is up, the meeting is over?
362 2014-05-24T17:17:36 <RogerHaase> skathpalia: you have a typo in your blog entry about pycharm, path of the script should be <venv>/bin/moin not <venv>/bin/python
363 2014-05-24T17:18:24 <skathpalia> Ok will change that
364 2014-05-24T17:19:37 <skathpalia> RogerHaase, corrected that
365 2014-05-24T17:23:35 <RogerHaase> thanks
366 2014-05-24T17:56:57 *** sl33k_
367 2014-05-24T18:02:20 *** sl33k_
368 2014-05-24T18:04:35 *** skathpalia
369 2014-05-24T18:07:41 * ThomasWaldmann is back
370 2014-05-24T18:16:25 *** randomax
371 2014-05-24T18:16:27 *** sl33k_
372 2014-05-24T18:19:14 *** sl33k_
373 2014-05-24T18:27:38 *** greg_f
374 2014-05-24T18:29:56 *** sl33k_
375 2014-05-24T18:41:50 *** sl33k_
376 2014-05-24T18:53:51 *** mansi
377 2014-05-24T18:58:15 *** greg_f
378 2014-05-24T20:37:10 *** magu_cic
379 2014-05-24T20:44:52 *** magu_cic
380 2014-05-24T21:17:33 *** magu_cic
381 2014-05-24T21:54:14 *** RogerHaase
382 2014-05-24T22:25:21 *** magu_cic
383 2014-05-24T23:24:02 *** derdon
384
