1 2014-06-14T04:42:33 *** sl33k_
2 2014-06-14T06:14:53 *** sl33k_
3 2014-06-14T06:19:37 *** sl33k_
4 2014-06-14T06:23:33 *** skathpalia
5 2014-06-14T06:25:49 <skathpalia> ThomasWaldmann, dimazest I have added filter option and also by default it shows only open tickets and all tickets can be viewed by clicking on "All" button in +tickets view
6 2014-06-14T06:25:59 <skathpalia> Here is the cr https://codereview.appspot.com/102140045
7 2014-06-14T06:27:33 *** sl33k_
8 2014-06-14T06:46:43 *** sl33k_
9 2014-06-14T06:46:48 *** sl33k_
10 2014-06-14T07:11:04 *** skathpalia
11 2014-06-14T07:15:39 *** penguinRaider
12 2014-06-14T08:32:33 *** sl33k_
13 2014-06-14T09:39:46 <dimazest> hello, i had a look to the changes, see my comments
14 2014-06-14T11:03:31 *** skathpalia
15 2014-06-14T11:03:42 <skathpalia> dimazest, I have updated the cr
16 2014-06-14T11:25:52 *** skathpalia
17 2014-06-14T11:26:06 <dimazest> let me check it
18 2014-06-14T11:29:30 *** sl33k_
19 2014-06-14T11:33:22 <dimazest> we are meeting in 4 and a half hours, right
20 2014-06-14T11:33:24 <dimazest> ?
21 2014-06-14T11:33:35 <dimazest> with all the traveling i got lost
22 2014-06-14T11:49:41 <ThomasWaldmann> moin
23 2014-06-14T11:51:26 <ThomasWaldmann> dimazest: https://moinmo.in/GoogleSoc2014 there is the date
24 2014-06-14T11:51:42 <ThomasWaldmann> and "yes"
25 2014-06-14T11:53:01 <dimazest> cool, so i did the elementary math correctly, i usually suck in it :)
26 2014-06-14T11:59:31 <ThomasWaldmann> many linuxes have a world clock (e.g. ubuntu), you just need to add some cities ;)
27 2014-06-14T12:00:14 * ThomasWaldmann has berlin, UTC, LA, New Delhi currently :D
28 2014-06-14T13:07:15 *** randomax
29 2014-06-14T13:39:05 *** penguinRaider
30 2014-06-14T13:52:50 *** penguinRaider
31 2014-06-14T13:59:10 *** RogerHaase
32 2014-06-14T14:20:45 <RogerHaase> ThomasWaldmann: fix invalid moin-transclusion hover color, make pycharm happy https://codereview.appspot.com/102140048/
33 2014-06-14T14:43:52 <ThomasWaldmann> RogerHaase: done
34 2014-06-14T15:11:59 *** penguinRaider
35 2014-06-14T15:15:37 *** sl33k_
36 2014-06-14T15:17:46 *** skathpalia
37 2014-06-14T15:18:19 *** sl33k_
38 2014-06-14T15:22:14 *** skathpalia
39 2014-06-14T15:26:27 *** sl33k_
40 2014-06-14T15:29:34 *** skathpalia
41 2014-06-14T16:00:09 <dimazest> hello
42 2014-06-14T16:00:17 <skathpalia> moin
43 2014-06-14T16:00:21 <RogerHaase> moin
44 2014-06-14T16:01:19 <randomax> moin
45 2014-06-14T16:02:14 <RogerHaase> ThomasWaldmann: ^^
46 2014-06-14T16:02:17 <dimazest> ThomasWaldmann: are you here?
47 2014-06-14T16:02:43 * ThomasWaldmann here now
48 2014-06-14T16:02:59 <ThomasWaldmann> ok, welcome to our weekly meeting
49 2014-06-14T16:03:09 <ThomasWaldmann> skathpalia: your stage
50 2014-06-14T16:03:13 <skathpalia> Done:
51 2014-06-14T16:03:18 <skathpalia> Added +tickets view to display all tickets
52 2014-06-14T16:03:22 <skathpalia> Also defined css for the table
53 2014-06-14T16:03:30 <skathpalia> Added filter and search option also in this view
54 2014-06-14T16:03:36 <skathpalia> Here is the cr https://codereview.appspot.com/102140045
55 2014-06-14T16:03:43 <skathpalia> Here is the screenshot of +tickets view http://picpaste.com/pics/Screenshot_from_2014-06-14_16_37_37-NSjpCy4C.1402744114.png
56 2014-06-14T16:03:56 <skathpalia> Blocked:
57 2014-06-14T16:04:02 <skathpalia> Not able to find out hwow can we create tickets without giving any initial name or fqname.
58 2014-06-14T16:04:11 <skathpalia> TODO:
59 2014-06-14T16:04:20 <skathpalia> Add create button to +tickets view for creating tickets.
60 2014-06-14T16:04:25 <skathpalia> Also improve the UI of tickets.
61 2014-06-14T16:04:38 <skathpalia> Also add subscribe option to tickets
62 2014-06-14T16:04:41 <ThomasWaldmann> hmm, still no unified representation (code) for tickets
63 2014-06-14T16:05:14 <ThomasWaldmann> but maybe it is better here, in case someone wants to sort by ID or Summary
64 2014-06-14T16:06:06 <ThomasWaldmann> the E/D/S/P colums are rather wide while the summary col is rather narrow, can you improve that?
65 2014-06-14T16:06:27 <skathpalia> Yeah will increase the width of summary column
66 2014-06-14T16:06:45 <skathpalia> and decrease width of E/D/S/P
67 2014-06-14T16:06:51 <ThomasWaldmann> also ID must be monospace, it looks ugly when proportional
68 2014-06-14T16:07:49 *** sl33k_
69 2014-06-14T16:08:20 <ThomasWaldmann> that filter "All", can one click that to get sth else?
70 2014-06-14T16:08:20 <skathpalia> Ok will do that also
71 2014-06-14T16:08:40 * ThomasWaldmann just looks at screenshot right now
72 2014-06-14T16:09:56 <skathpalia> All means that on clicking it one can view both open and closed tickets
73 2014-06-14T16:10:36 <dimazest> should we add "Open", "Closed" right next to "All"
74 2014-06-14T16:10:52 <ThomasWaldmann> ok, so as you see, i was a bit confused whether it is a state ("as shown currently") or an action ("click here to see all")
75 2014-06-14T16:11:36 <skathpalia> Thats why I have added the title
76 2014-06-14T16:11:59 <ThomasWaldmann> yeah
77 2014-06-14T16:12:45 <ThomasWaldmann> but dimazest's idea is maybe better, just show the options and make clear what is currently shown
78 2014-06-14T16:13:29 <skathpalia> Ok I will add "closed" and "open" button also to make it more clear
79 2014-06-14T16:14:07 <ThomasWaldmann> btw, these 2 search fields are now a bit confusing also
80 2014-06-14T16:14:33 <ThomasWaldmann> didn't we get rid of the upper one already?
81 2014-06-14T16:14:40 <ThomasWaldmann> (for that view)
82 2014-06-14T16:15:14 <skathpalia> No
83 2014-06-14T16:15:41 <skathpalia> I have imported layout.html which is having upper search bar
84 2014-06-14T16:16:25 <skathpalia> May be it us not confusing as it is written that the lower searchbox is meant for tickets only
85 2014-06-14T16:17:29 * ThomasWaldmann often types in the wrong search box in thunderbird, so better assume that shit happens if you display 2 search boxes near each other)
86 2014-06-14T16:18:20 <ThomasWaldmann> the space between tickets "headline" at the "My MoinMoin" bar is also a bit much?
87 2014-06-14T16:18:25 <dimazest> what if one search box is kept
88 2014-06-14T16:18:39 <skathpalia> Ok then we have to define a different layout.html for tickets
89 2014-06-14T16:18:52 <dimazest> but there is auto comletion functionality, the way github does it http://cl.ly/image/1V3q3x033S1z/Screen%20Shot%202014-06-14%20at%2019.17.14.png
90 2014-06-14T16:19:18 <dimazest> just the block that is responsible for the search box
91 2014-06-14T16:20:39 <ThomasWaldmann> maybe put search box simplification on the todo and first just do the simple changes (spacing)
92 2014-06-14T16:21:18 <skathpalia> I think that space is coming because of trail that needs to be shown
93 2014-06-14T16:21:30 <ThomasWaldmann> and remove ubuntu-one from your starter :D
94 2014-06-14T16:21:47 <skathpalia> :D
95 2014-06-14T16:22:17 <ThomasWaldmann> well, we decided that we don't have trail on that view, right?
96 2014-06-14T16:22:32 <ThomasWaldmann> so the space should be freed
97 2014-06-14T16:23:11 <skathpalia> Ok will define another layout.html for tickets in which I will remove trail and search box
98 2014-06-14T16:24:12 <ThomasWaldmann> https://codereview.appspot.com/102140045/ that should get finished, it is getting too many patches...
99 2014-06-14T16:25:03 <skathpalia> Its almost done
100 2014-06-14T16:25:05 <ThomasWaldmann> so first finish what you already touched, then make a new one for next changes
101 2014-06-14T16:25:08 <RogerHaase> no need for another layout.html see randomax's search.html {% set search_form = None %} {# layout will not show search form in header #}
102 2014-06-14T16:25:14 <skathpalia> Just some minor changes left
103 2014-06-14T16:25:41 <ThomasWaldmann> RogerHaase: ah, maybe i confused it with his changed :)
104 2014-06-14T16:25:47 <ThomasWaldmann> changes*
105 2014-06-14T16:26:10 <skathpalia> Yeah will do that Thanks RogerHaase
106 2014-06-14T16:27:26 <ThomasWaldmann> that table sorter stuff is not done yet?
107 2014-06-14T16:27:39 <skathpalia> Yeah its not done
108 2014-06-14T16:27:55 <ThomasWaldmann> yesterday at the python workshop, some guys used "datatables" js plugin
109 2014-06-14T16:28:07 <skathpalia> You told that you would ask someone regarding that in last meeting
110 2014-06-14T16:28:10 <ThomasWaldmann> so mottie or datatables seem to be somehow popular
111 2014-06-14T16:28:39 <skathpalia> Ok will try to use one of them
112 2014-06-14T16:28:57 <ThomasWaldmann> radomir (aka TheSheep aka desiphu [or so]) made the xstatic package for mottie
113 2014-06-14T16:29:33 <ThomasWaldmann> the guys yday talked about pagin functionality of datatables, that sounded interesting
114 2014-06-14T16:29:49 <ThomasWaldmann> check if mottie does that, too
115 2014-06-14T16:30:26 <skathpalia> I will try to do that
116 2014-06-14T16:30:51 <ThomasWaldmann> about create-item-with-no-name blocker: didn't get to looking at it yet, but guess i could this weekend
117 2014-06-14T16:31:34 <ThomasWaldmann> ah, another one: make the ID clickable also, same target as summary text
118 2014-06-14T16:31:50 <skathpalia> Ok
119 2014-06-14T16:32:28 <ThomasWaldmann> any ideas how to make the columns less wide without having it too tight?
120 2014-06-14T16:33:03 <skathpalia> I was thinking of defining width of each column
121 2014-06-14T16:34:03 <ThomasWaldmann> i think there should be a little [and always same] space between columns
122 2014-06-14T16:34:54 <ThomasWaldmann> but, maybe the width taken by the th should be reduced?
123 2014-06-14T16:35:15 <skathpalia> Yeah that would work I suppose
124 2014-06-14T16:35:18 <ThomasWaldmann> so, E D S P with titles?
125 2014-06-14T16:35:19 <skathpalia> I will try that
126 2014-06-14T16:35:35 <RogerHaase> 1-digit numbers would look better centered
127 2014-06-14T16:35:52 <dimazest> i was thinking about one letter abbreviations as well
128 2014-06-14T16:36:06 <ThomasWaldmann> well, if we use 1-letter th, solves that, too :D
129 2014-06-14T16:36:11 <skathpalia> Yeah may be that would be Ok
130 2014-06-14T16:36:34 <skathpalia> We can always define a title that would represent the full form of abbreviation
131 2014-06-14T16:37:08 <ThomasWaldmann> of course, translation is a problem for E D S P
132 2014-06-14T16:37:23 <RogerHaase> if you add table sorter you will need a clickable heading for sorting
133 2014-06-14T16:38:03 <ThomasWaldmann> is only the text clickable or the whole space taken by the column header?
134 2014-06-14T16:38:10 <skathpalia> We can have whole th clickable
135 2014-06-14T16:38:23 <ThomasWaldmann> if that works, YES :=
136 2014-06-14T16:38:26 <ThomasWaldmann> :)
137 2014-06-14T16:38:37 <ThomasWaldmann> for all columns
138 2014-06-14T16:39:39 <ThomasWaldmann> ok, guess that was it from me. anything else for skathpalia ?
139 2014-06-14T16:39:47 <skathpalia> Nope
140 2014-06-14T16:40:04 <RogerHaase> please close #424 and the CR
141 2014-06-14T16:40:21 <dimazest> that's it
142 2014-06-14T16:40:26 <skathpalia> Ok will do that
143 2014-06-14T16:40:42 <ThomasWaldmann> ok, thanks. randomax: your stage ;)
144 2014-06-14T16:40:52 <randomax> done
145 2014-06-14T16:40:58 <randomax> added advanced search
146 2014-06-14T16:41:04 <randomax> https://codereview.appspot.com/109730047/
147 2014-06-14T16:41:14 <randomax> http://picpaste.com/pics/basicsearch-7PpJZAfZ.1402762214.png
148 2014-06-14T16:41:18 <randomax> http://picpaste.com/pics/foobarsearch-dsWKJh8O.1402762234.png
149 2014-06-14T16:41:23 <randomax> http://picpaste.com/pics/modernsearch-oFBggLo1.1402762259.png
150 2014-06-14T16:41:33 <randomax> improved the index section GUI
151 2014-06-14T16:41:46 <randomax> and added smiley support
152 2014-06-14T16:41:51 <randomax> in basic theme
153 2014-06-14T16:41:54 <randomax> https://codereview.appspot.com/108020043
154 2014-06-14T16:42:02 <randomax> http://picpaste.com/pics/index-closed-TzoqLZvD.1402761240.png
155 2014-06-14T16:42:08 <randomax> http://picpaste.com/pics/index-open-C1rKqrpx.1402761258.png
156 2014-06-14T16:42:53 <randomax> also added the css classes for the highlighting items in the "Show Items" tab
157 2014-06-14T16:43:03 <ThomasWaldmann> http://picpaste.com/pics/basicsearch-7PpJZAfZ.1402764096.png "Revisions" (...) is both italic and underlined
158 2014-06-14T16:43:25 <ThomasWaldmann> maybe remove italic?
159 2014-06-14T16:43:40 <randomax> Ok.. will do that :)
160 2014-06-14T16:43:58 <ThomasWaldmann> also, there is some duplication in wording
161 2014-06-14T16:44:02 <randomax> cr for pygments css classes - https://codereview.appspot.com/102430045
162 2014-06-14T16:44:31 <ThomasWaldmann> e.g. "Revisions" headline and below "Latest Revisions" and "All Revisions" (and similar in other columns)
163 2014-06-14T16:44:45 <randomax> Ohh.. ok
164 2014-06-14T16:44:49 <randomax> i'll remove that
165 2014-06-14T16:45:01 <ThomasWaldmann> so if headline is Revisions, options could be just "Latest" and "All"
166 2014-06-14T16:45:12 <randomax> yeah
167 2014-06-14T16:45:47 <ThomasWaldmann> i don't understand what Modified Time options do
168 2014-06-14T16:46:21 <ThomasWaldmann> (also remove all "Items" words from the "Item Types")
169 2014-06-14T16:46:49 <randomax> You can see search results by either newer items first or older items first
170 2014-06-14T16:46:56 <randomax> or by the default config
171 2014-06-14T16:47:19 <ThomasWaldmann> who knows what the default is?
172 2014-06-14T16:48:38 <randomax> the default just gives the output as it is searched.. as in whatever the whoosh query result is without applying any filter
173 2014-06-14T16:49:11 <ThomasWaldmann> "Sorting", "None", "Newer first", "Older first" maybe?
174 2014-06-14T16:49:41 <RogerHaase> I am thinking the time would be more useful if there were input boxes for start and end dates -- like 2014-01-01 to 2014-03-01
175 2014-06-14T16:49:58 <randomax> Ok.. i'll change the terms there.. along with removing the repetitions
176 2014-06-14T16:50:30 <ThomasWaldmann> RogerHaase: i guess such complex queries could be done in the input box (if one knows whoosh's query syntax good enough)
177 2014-06-14T16:51:11 *** skathpalia
178 2014-06-14T16:51:21 <RogerHaase> if it possible there that would be fine (assuming it is somewhere documented)
179 2014-06-14T16:51:41 <randomax> ok.. i'll try to implement that
180 2014-06-14T16:51:46 <ThomasWaldmann> hmm, was skathpalia in a hurry? would be good if students stay until we are all finished.
181 2014-06-14T16:52:43 <ThomasWaldmann> what i noticed right now: skathpalia's tickets view has no trail and a heading "Tickets" in the content area. your search view has no heading, but a trail.
182 2014-06-14T16:54:17 <randomax> is a heading required in search ?
183 2014-06-14T16:54:26 <ThomasWaldmann> hmm, also kill the "Advanced " from "Advanced Search Options"
184 2014-06-14T16:54:47 <randomax> ok
185 2014-06-14T16:54:55 <ThomasWaldmann> randomax: we should be consistent between views
186 2014-06-14T16:54:56 <randomax> also i had one more doubt
187 2014-06-14T16:55:31 <randomax> it wasnt fixed in the last meeting whether we should use the rights section in the search or remove it ?
188 2014-06-14T16:56:32 <ThomasWaldmann> dimazest: RogerHaase: opinions about position of "Input suggestions"? I think it should be below text input field, not below "Search Options"
189 2014-06-14T16:57:11 <RogerHaase> are you looking at basic theme - it shows wiki name at top, current page in trail and maybe highlighted at left
190 2014-06-14T16:57:43 * ThomasWaldmann still looks there: http://picpaste.com/pics/basicsearch-7PpJZAfZ.1402764096.png
191 2014-06-14T16:58:21 <randomax> i thought search options are more related to the search so i kept them there
192 2014-06-14T16:58:37 <randomax> also again google uses that method :)
193 2014-06-14T16:58:38 <dimazest> i would move all three suggestions closer to the text input
194 2014-06-14T16:58:59 <ThomasWaldmann> ^ as user shall type in these, right?
195 2014-06-14T16:59:19 <dimazest> maybe they also should be links to the corresponding searches
196 2014-06-14T16:59:46 <ThomasWaldmann> hmm, hard to do if you usually want some combination
197 2014-06-14T16:59:48 <RogerHaase> agree, would move under input box
198 2014-06-14T17:00:28 <ThomasWaldmann> ok, so it moves under input box please
199 2014-06-14T17:00:32 <randomax> ok.. i'll move the suggestions above
200 2014-06-14T17:01:00 <RogerHaase> but, suggest postponing implementing any clickable suggestions for moin 2.2+
201 2014-06-14T17:01:40 <ThomasWaldmann> about the "rights" (permissions). i personally don't think they are useful on the search results view as we only show search results the user is allowed to see (right?).
202 2014-06-14T17:02:34 <ThomasWaldmann> but they have a slightly negative effect there as they flood the user with a lot of information he maybe didn't want to know at all
203 2014-06-14T17:03:09 <randomax> ok.. i'll remove that..
204 2014-06-14T17:03:10 <ThomasWaldmann> that said, I think such a display would be more useful on the item's "show" view.
205 2014-06-14T17:03:40 <ThomasWaldmann> if we do not already have it indirectly by greying out stuff the user is not allowed to do.
206 2014-06-14T17:04:02 <ThomasWaldmann> RogerHaase: dimazest: your opinion?
207 2014-06-14T17:04:22 <randomax> ok.. seems good to implement it in the show view
208 2014-06-14T17:05:05 <ThomasWaldmann> ah, i see there is a more pretty content-type now, nice
209 2014-06-14T17:05:16 <RogerHaase> I thought last thing said was remove it last week
210 2014-06-14T17:06:41 <dimazest> i wouldn't show a page if the user has no access, otherwise by a series of queries (and patience) one can get the content of the whole page
211 2014-06-14T17:07:10 <ThomasWaldmann> dimazest: i am sure we never show CONTENT of such an item
212 2014-06-14T17:07:38 <dimazest> ahh, i see
213 2014-06-14T17:07:45 <ThomasWaldmann> but you can't keep names completely secret. not sure how search handles them right now.
214 2014-06-14T17:08:13 <dimazest> i guess names are fine being public
215 2014-06-14T17:08:18 <ThomasWaldmann> randomax: http://picpaste.com/pics/modernsearch-oFBggLo1.1402765580.png there seems to be more vspace between the search options
216 2014-06-14T17:08:29 <ThomasWaldmann> (than in the other themes)
217 2014-06-14T17:09:17 <ThomasWaldmann> also, left alignment of input field, options table, search results seems inconsistent
218 2014-06-14T17:10:23 <ThomasWaldmann> (please check for other themes yourself)
219 2014-06-14T17:10:34 <randomax> ok will do that
220 2014-06-14T17:12:55 <ThomasWaldmann> http://picpaste.com/pics/index-open-C1rKqrpx.1402765928.png that "filter by content type" is now used on the index and also on the search view.
221 2014-06-14T17:13:10 <ThomasWaldmann> but it looks like 2 different implementations, right?
222 2014-06-14T17:13:52 <randomax> yeah.. but that is search
223 2014-06-14T17:14:03 <ThomasWaldmann> could we maybe use same widget at all places where we need it?
224 2014-06-14T17:14:20 <randomax> it cant show any items by with any name
225 2014-06-14T17:14:44 <ThomasWaldmann> hm?
226 2014-06-14T17:14:46 <randomax> *items with any name
227 2014-06-14T17:14:59 <randomax> as in you have to put in a search query in the search section
228 2014-06-14T17:15:20 <randomax> name of the item or content or something else
229 2014-06-14T17:15:44 <randomax> in index section it just shows all items
230 2014-06-14T17:15:59 <randomax> of that type regardless of anything
231 2014-06-14T17:17:04 <ThomasWaldmann> ok, if you can't completely reuse it, can you make it at least visually more similar?
232 2014-06-14T17:17:45 <randomax> ok.. will try to do that
233 2014-06-14T17:19:16 <ThomasWaldmann> ok, that's it from me currently. any other questions/suggestions?
234 2014-06-14T17:19:39 <randomax> no :)
235 2014-06-14T17:20:02 <RogerHaase> we have been trying to discuss adding more css to static/css to avoid triplicating css for each theme
236 2014-06-14T17:20:54 <RogerHaase> ...and coding pure css rather than stylus or lessc, then compiling
237 2014-06-14T17:21:20 <ThomasWaldmann> fine with me (as long as it works)
238 2014-06-14T17:21:34 <ThomasWaldmann> can we avoid colouring problems?
239 2014-06-14T17:21:55 <randomax> as in ?
240 2014-06-14T17:22:01 <ThomasWaldmann> like defining colours there globally that mismatch the themes?
241 2014-06-14T17:22:21 <randomax> yeah each theme has some of its own css
242 2014-06-14T17:22:37 <randomax> the common part is what i define in the common css file
243 2014-06-14T17:22:38 <RogerHaase> we can define a default and if theme wants different, it can override
244 2014-06-14T17:23:51 <ThomasWaldmann> stylus or less might be required as soon as we need to compute stuff or have variables
245 2014-06-14T17:24:04 <ThomasWaldmann> but we can just try....
246 2014-06-14T17:24:45 <RogerHaase> related, should static dir be moved under theme dir so it is a closer cousin?
247 2014-06-14T17:26:34 <ThomasWaldmann> well, if you have the stuff there that is NOT per-theme, i would keep it out of theme dir
248 2014-06-14T17:28:39 <RogerHaase> in 1.9 under htdocs we have common and applets
249 2014-06-14T17:29:16 <ThomasWaldmann> yeah, htdocs, but not themes
250 2014-06-14T17:30:43 <RogerHaase> OK, leave directory structure as is; proceed with changesets in progress as they are now, and add common css to static/css in a future changeset
251 2014-06-14T17:31:12 <randomax> ok
252 2014-06-14T17:31:22 *** skathpalia
253 2014-06-14T17:31:55 <ThomasWaldmann> skathpalia: welcome back (I already wondered you left so quickly before meeting end)
254 2014-06-14T17:32:13 <ThomasWaldmann> ok, anything else for randomax ?
255 2014-06-14T17:32:15 <skathpalia> sorry
256 2014-06-14T17:32:27 <RogerHaase> skathpalia: ^^ check log re ticket.css
257 2014-06-14T17:33:10 * ThomasWaldmann opened some browser tabs with misc. code reviews
258 2014-06-14T17:33:33 <randomax> :)
259 2014-06-14T17:36:30 <skathpalia> ThomasWaldmann, Can I commit my change regarding the download of nameless items?
260 2014-06-14T17:36:44 <ThomasWaldmann> ok, looks like we are through for today with the meeting
261 2014-06-14T17:36:49 <ThomasWaldmann> thanks everybody
262 2014-06-14T17:36:57 <ThomasWaldmann> skathpalia: url?
263 2014-06-14T17:37:18 <skathpalia> https://codereview.appspot.com/102210043/
264 2014-06-14T17:40:46 <ThomasWaldmann> ok, see there
265 2014-06-14T17:45:17 <skathpalia> ThomasWaldmann, for getting rid of trouble in windows we can have itemid as name of file if there is no name of item
266 2014-06-14T17:53:17 *** randomax
267 2014-06-14T18:01:31 <ThomasWaldmann> skathpalia: yes, for example
268 2014-06-14T18:01:52 <ThomasWaldmann> you could use the content-type to add a reasonable extension
269 2014-06-14T18:01:55 <skathpalia> Ok I will add a filename method for that :)
270 2014-06-14T18:03:03 <skathpalia> May be we can have itemid-<ITEMID_OF_ITEM>
271 2014-06-14T18:04:38 <skathpalia> Yeah we can add content-type also
272 2014-06-14T18:06:54 <ThomasWaldmann> i mean .txt (or .rst .moin ...)
273 2014-06-14T18:07:54 <skathpalia> Ok I will try to do that :)
274 2014-06-14T18:11:37 *** skathpalia
275 2014-06-14T18:12:55 <ThomasWaldmann> dimazest: RogerHaase: i often see hardcoded colours in new css
276 2014-06-14T18:13:38 <ThomasWaldmann> e.g. in basic.less. how is that compatible with bootstrap themes?
277 2014-06-14T18:14:02 <ThomasWaldmann> shouldn't colours be taken from some theme palette (or at least based on them)?
278 2014-06-14T18:20:31 <RogerHaase> ThomasWaldmann: agree, there are a few pre-randomax and he added a few more to basic theme and modernized and foobar. those should go in palette
279 2014-06-14T18:24:28 <ThomasWaldmann> see there: https://codereview.appspot.com/108020043/
280 2014-06-14T19:24:49 <ThomasWaldmann> hmm, codereviews are getting too big somehow
281 2014-06-14T19:25:11 <ThomasWaldmann> somehow more focus would help, imho
282 2014-06-14T19:29:42 <RogerHaase> yes, we need to slow scope creep and have more small commits
283 2014-06-14T19:31:11 <RogerHaase> also forgot to nag randomax that his blog needs updating
284 2014-06-14T19:45:23 <ThomasWaldmann> hehe, scope creep. yeah, that' what I meant. :D
285 2014-06-14T19:45:42 * ThomasWaldmann done with CRs
286 2014-06-14T19:45:57 <ThomasWaldmann> lots of python todo also
287 2014-06-14T19:47:03 * ThomasWaldmann has the slight feeling there is too little use of bootstrap
288 2014-06-14T19:47:21 <ThomasWaldmann> and too much homegrown css
289 2014-06-14T19:48:29 *** sl33k_
290 2014-06-14T21:09:01 <RogerHaase> ThomasWaldmann: I contradicted you on randomax's https://codereview.appspot.com/102430045/
291 2014-06-14T21:10:30 * ThomasWaldmann looks
292 2014-06-14T21:12:12 <ThomasWaldmann> RogerHaase: thought that's already done like that somewhere else.
293 2014-06-14T21:12:59 <ThomasWaldmann> so I agree ;)
294 2014-06-14T21:16:10 <RogerHaase> ThomasWaldmann: no, was not done, modernized and foobar have pygment_default.css duplicated in their respective css/stylus directories
295 2014-06-14T21:51:05 *** RogerHaase
296
