1 2014-06-25T01:37:37 *** derdon
2 2014-06-25T01:44:49 *** magu_cic_
3 2014-06-25T04:40:02 *** RogerHaase
4 2014-06-25T05:11:56 *** RogerHaase
5 2014-06-25T05:36:10 *** penguinRaider
6 2014-06-25T06:09:51 *** sl33k_
7 2014-06-25T06:24:02 *** magu_cic
8 2014-06-25T06:24:14 *** penguinRaider
9 2014-06-25T06:25:36 *** penguinRaider
10 2014-06-25T06:39:40 *** sl33k_
11 2014-06-25T07:20:44 *** sl33k_
12 2014-06-25T08:42:02 *** greg_f
13 2014-06-25T10:27:08 *** penguinRaider
14 2014-06-25T13:08:57 *** sl33k_
15 2014-06-25T13:12:01 *** sl33k_
16 2014-06-25T13:12:04 *** sl33k_
17 2014-06-25T13:47:58 *** skathpalia
18 2014-06-25T13:49:25 <skathpalia> dimazest, I tried removing the mutable list that I used in this cr https://codereview.appspot.com/101460044/ buy I am not able to get a method by which I can send the tags which user has selected
19 2014-06-25T13:49:39 <skathpalia> Can you please see to it?
20 2014-06-25T14:01:55 <skathpalia> I mean sending the selected tags from html to python function
21 2014-06-25T14:25:15 *** RogerHaase
22 2014-06-25T14:38:55 *** sl33k_
23 2014-06-25T15:22:18 *** dave_largo
24 2014-06-25T15:33:19 *** magu_cic_
25 2014-06-25T15:36:27 *** magu_cic
26 2014-06-25T15:38:05 *** magu_cic
27 2014-06-25T15:38:33 *** skathpalia
28 2014-06-25T15:39:14 *** magu_cic_
29 2014-06-25T15:39:58 *** magu_cic
30 2014-06-25T15:40:33 *** magu_cic
31 2014-06-25T16:04:55 *** skathpalia
32 2014-06-25T16:07:30 <ThomasWaldmann> skathpalia: did you see my feedback on that cr? i don't see much changes yet
33 2014-06-25T16:08:12 <skathpalia> Yeah I have made all other changes except removal of that list
34 2014-06-25T16:08:22 <skathpalia> *mutable list
35 2014-06-25T16:09:01 <skathpalia> I am not able to find a method by which I can send selected tags from html to python function
36 2014-06-25T16:09:05 <ThomasWaldmann> you still have that try/except instead of get
37 2014-06-25T16:09:36 <skathpalia> Oh sorry I didn't update the cr
38 2014-06-25T16:09:46 <ThomasWaldmann> (well, yes, maybe find the first highlevel way before we care for details)
39 2014-06-25T16:10:23 <skathpalia> I tried the way that you suggested yesterday (usinf getlist) but this way I get the names of all tags not the selected ones
40 2014-06-25T16:10:24 <ThomasWaldmann> btw, where's randomax?
41 2014-06-25T16:14:58 <skathpalia> I think he is not here because of power failure at college
42 2014-06-25T16:14:59 *** skathpalia
43 2014-06-25T16:21:50 *** skathpalia
44 2014-06-25T16:22:04 <skathpalia> ThomasWaldmann, sorry my internet just got disconnected
45 2014-06-25T16:23:22 <skathpalia> I talked with randomax and he said he would be back as soon as power comes :)
46 2014-06-25T16:26:13 <ThomasWaldmann> maybe he could just move to a place with power and internet?
47 2014-06-25T16:26:15 *** sl33k_
48 2014-06-25T16:28:02 <skathpalia> Ok I will tell him :)
49 2014-06-25T16:36:41 *** randomax
50 2014-06-25T16:38:42 <skathpalia> ThomasWaldmann, I have updated the cr
51 2014-06-25T16:39:05 <skathpalia> Removed and try-except statement and also removed hardcoded colors and also used set instead of list for tags
52 2014-06-25T16:40:47 <skathpalia> Also added hint for sorting by multiple columns
53 2014-06-25T16:41:27 <skathpalia> and now full summary is being shown
54 2014-06-25T16:41:50 <ThomasWaldmann> http://www.w3.org/TR/html5/forms.html#constructing-the-form-data-set interesting, i didn't knew that x/y stuff for images
55 2014-06-25T16:53:19 <ThomasWaldmann> skathpalia: did you understand how MultiDicts work?
56 2014-06-25T16:53:42 <skathpalia> Yeah I tried using getlist
57 2014-06-25T16:54:16 <skathpalia> and I got the values of tags but I got all the tags but we need only those which are selected by user
58 2014-06-25T16:54:51 <ThomasWaldmann> so you did form.getlist("tags") or so?
59 2014-06-25T16:55:05 <skathpalia> Yeah I did that
60 2014-06-25T16:55:33 <ThomasWaldmann> only the selected ones should be in there. maybe it depends on the form tag?
61 2014-06-25T16:55:34 <skathpalia> I did form.getlist('selected_tag') but this way I get all the tags
62 2014-06-25T16:57:08 <skathpalia> I am not able to find a way by which we can distinguish between selected and not-selected input fields
63 2014-06-25T17:00:31 <ThomasWaldmann> a select tag should work the way we want - semantically. i have no idea about styling that nicely, so it looks like we want.
64 2014-06-25T17:03:16 <ThomasWaldmann> maybe ask RogerHaase or deshipu (on #moin) about the styling stuff for tags
65 2014-06-25T17:04:04 <skathpalia> Ok
66 2014-06-25T17:04:40 <skathpalia> RogerHaase, I am having one problem in adding option of filter by tags in +tickets view
67 2014-06-25T17:04:47 <skathpalia> https://codereview.appspot.com/101460044/
68 2014-06-25T17:05:14 <skathpalia> In thin I have mutable list in views.py and we need to get rid of this
69 2014-06-25T17:06:03 *** sl33k_
70 2014-06-25T17:06:39 <skathpalia> For that we need to send the tags which are selected by user from html to python function
71 2014-06-25T17:06:54 <skathpalia> Do you have any idea how this can be done?
72 2014-06-25T17:24:40 *** sl33k_
73 2014-06-25T17:33:18 <RogerHaase> skathpalia: was away, I have your patch applied now, what do I do to see the problem?
74 2014-06-25T17:34:51 <skathpalia> the current is working but here I have used mutable list in views.py which should not be there
75 2014-06-25T17:41:18 <RogerHaase> skathpalia: I don't understand, the discussion seems to be about passing selected values from a form to the host
76 2014-06-25T17:41:30 <skathpalia> Yeah
77 2014-06-25T17:42:11 <skathpalia> Suppose the user selects tag1
78 2014-06-25T17:42:27 <skathpalia> then he sees only those tickets which have tag1
79 2014-06-25T17:42:51 <skathpalia> and then if he selects tag2 then he should see tickets with tag1 and tag2
80 2014-06-25T17:45:58 <RogerHaase> I am on tags view and I see a list of my tags, if I click on 1 I see the tickets with those tags -- where are you able to select both tag1 and tag2?
81 2014-06-25T17:47:17 <skathpalia> For this we need a ticket with both these tags
82 2014-06-25T17:47:55 <skathpalia> have 3 tickets one with tag1, other with tag2 and last one with both tag1 and tag2
83 2014-06-25T17:47:57 <randomax> RogerHaase, updated the cr https://codereview.appspot.com/106140043/
84 2014-06-25T17:48:12 <skathpalia> and then you can easily see that
85 2014-06-25T17:55:00 <RogerHaase> skathpalia: If I select a tag that has 3 hits, then I see a list of links to each tag, there is no place to select another tag
86 2014-06-25T17:57:09 <skathpalia> Are you having just one tag for all those 3 hits?
87 2014-06-25T17:57:26 <skathpalia> I mean those 3 tickets are having only that tag?
88 2014-06-25T17:58:47 <RogerHaase> All have selected tag, 2 have other tags as well
89 2014-06-25T17:59:47 <skathpalia> In mine its showing other tags also
90 2014-06-25T18:01:30 <RogerHaase> skathpalia: starting over, I click Tags under site navigation, and see a list of tags that are links. I click a like and see items with that tag.
91 2014-06-25T18:01:40 <RogerHaase> like/link
92 2014-06-25T18:04:36 <skathpalia> yeah
93 2014-06-25T18:05:27 <RogerHaase> there is no place to select a second tag
94 2014-06-25T18:09:37 <skathpalia> I am again checking it
95 2014-06-25T18:10:20 <RogerHaase> randomax: I am confused by your cr. When I do a diff patchset 1 x patchset 2, I see the same changes as base x patchset 1?
96 2014-06-25T18:11:06 <randomax> yeah i used a new repo for this patchset..
97 2014-06-25T18:11:19 <skathpalia> RogerHaase, I applied my patch to a new repo clone and it is working there
98 2014-06-25T18:11:22 <randomax> i have committed my code for the pygments classes
99 2014-06-25T18:11:47 <skathpalia> I made 3 tickets
100 2014-06-25T18:11:58 <skathpalia> 1st ticket: tag1, tag2
101 2014-06-25T18:12:04 <skathpalia> 2nd ticket: tag1
102 2014-06-25T18:12:09 <skathpalia> 3rd ticket: tag2
103 2014-06-25T18:12:36 <skathpalia> and then in +tickets view I clicked on tag1 button
104 2014-06-25T18:13:21 <skathpalia> and then I see blue tag1 button and 2 tickets being shown and then I select tag2 button below it and then it shows 2 ticket
105 2014-06-25T18:13:31 <skathpalia> and then both buttons get blue
106 2014-06-25T18:14:12 *** greg_f
107 2014-06-25T18:15:40 <RogerHaase> skathpalia: OK, I was on +tags, now I am on +tickets...
108 2014-06-25T18:16:27 <RogerHaase> I have 2 blue buttons, now what is the issue?
109 2014-06-25T18:17:28 <dimazest> hi, sorry i was away from the laptop today
110 2014-06-25T18:17:35 <skathpalia> The issue is that we are using mutable list in views.py which should be replaced
111 2014-06-25T18:18:28 <skathpalia> RogerHaase, how can we use python set in jinja2 template?
112 2014-06-25T18:18:47 <skathpalia> Actually I need to take difference of two lists in jinja2
113 2014-06-25T18:20:52 <skathpalia> Actually I got an idea to remove mutable list thats why I need to perform difference of two lists in jinja2
114 2014-06-25T18:21:29 <dimazest> i see
115 2014-06-25T18:21:48 <dimazest> can you keep the selected_tags either in the url or post them
116 2014-06-25T18:21:57 <dimazest> or store it in a cookie
117 2014-06-25T18:22:10 <dimazest> (that's just a speculation)
118 2014-06-25T18:22:31 <skathpalia> Yeah I am trying to keep selected_tags in url
119 2014-06-25T18:23:32 <skathpalia> Now user can select tags but for deselecting I need to perform difference between 2 lists
120 2014-06-25T18:23:57 <RogerHaase> still not understanding, selecting/deselecting seems to work - list of tickets expands/contracts
121 2014-06-25T18:24:32 <dimazest> that's because there is a global list that stores the tags
122 2014-06-25T18:24:50 <dimazest> btw, this should not work for two users or two opened tabs
123 2014-06-25T18:25:20 <RogerHaase> must break for 30 minutes
124 2014-06-25T18:36:30 *** sunu
125 2014-06-25T18:49:22 <RogerHaase> randomax: looks OK, commit
126 2014-06-25T18:51:36 <RogerHaase> randomax: but as you can see if you do ps1 x ps2 on that code review, CR gets really confusing if you update your repo in the middle of a cr process
127 2014-06-25T18:53:06 <skathpalia> RogerHaase, I am having one problem with lists in jinja2
128 2014-06-25T18:53:41 <skathpalia> I want to get a list from another list with one specific element removed
129 2014-06-25T18:54:04 <skathpalia> without changing the original list
130 2014-06-25T18:54:46 <skathpalia> But when I assign list2=list1 and then do some changes in list2 then list1 is also getting changed
131 2014-06-25T18:55:14 <skathpalia> Can you give any idea how can I do the desired operation?
132 2014-06-25T18:55:49 <RogerHaase> https://docs.python.org/2/library/copy.html
133 2014-06-25T18:56:55 <dimazest> list2=list(list1)
134 2014-06-25T18:58:22 <randomax> RogerHaase, yeah.. i shifted to another pc so had to make a new repo..
135 2014-06-25T18:58:29 <randomax> RogerHaase, also updated the cr https://codereview.appspot.com/109730047/
136 2014-06-25T19:20:33 <skathpalia> dimazest, updated the cr https://codereview.appspot.com/101460044
137 2014-06-25T19:20:45 <skathpalia> Removed global list selected_tags
138 2014-06-25T19:20:58 <RogerHaase> randomax: I get traceback when I try the search patch http://rn0.me/show/DryHIAAFtraXwcuhwPxX/ -- but still looking as hg import had fuzzy fit and a reject on css
139 2014-06-25T19:26:00 <randomax> RogerHaase, i think the patch didnt import properly.. coz i dont get an error
140 2014-06-25T19:28:25 *** skathpalia
141 2014-06-25T20:16:48 *** sl33k_
142 2014-06-25T20:19:23 <RogerHaase> randomax: I think I got it; for some reason the hg import was failing silently after applying patches to the first 3 files and then ignoring all others. Rebuilt your repo and reapplied, still have import errors, but no tracebacks
143 2014-06-25T20:20:18 *** sl33k_
144 2014-06-25T20:25:18 <randomax> oh.. ok
145 2014-06-25T20:28:34 <RogerHaase> randomax: there are still some minor problems, but as this is better than what we have and your patch is already too big, commit and work on the small issues later...
146 2014-06-25T20:30:55 <RogerHaase> issues, it is not obvious to click on search options bar to expand/contract (used to ba a down arrow thingy); when I click Markup Text checkbox the All checkbox does not get unchecked.
147 2014-06-25T20:35:23 <randomax> RogerHaase, yeah there is a down arrow there.. just that the glyphicons are not working currently..
148 2014-06-25T20:35:39 <randomax> regarding the checkbox i'll make changes in another changeset
149 2014-06-25T20:35:40 <RogerHaase> OK
150 2014-06-25T20:58:52 <randomax> RogerHaase, for the search ui should i update the same pr which i have for footer and pygments classes fix or should i wait for them to be merged ?
151 2014-06-25T21:02:03 <RogerHaase> update the pr so all get pulled
152 2014-06-25T21:02:30 <randomax> ok
153 2014-06-25T21:15:38 <RogerHaase> randomax: I wonder if glyphicon problem goes back to bootstrap 3.1.1.2 upgrade - in search.html line ~19 <span class="icon-chevron-down"> should be <span class="glyphicon-chevron-down"> to match CSS coming from bootstrap; But then in Firefox I see box with E114 rather than the glyph
154 2014-06-25T21:16:40 *** dave_largo
155 2014-06-25T22:09:46 *** RogerHaase
156 2014-06-25T22:44:11 *** sl33k_
157
