1 2014-06-30T00:00:32 *** sl33k_
2 2014-06-30T00:33:27 *** magu_cic_
3 2014-06-30T03:19:15 *** penguinRaider
4 2014-06-30T05:55:41 *** magu_cic
5 2014-06-30T06:05:36 *** magu_cic
6 2014-06-30T07:15:50 *** sl33k_
7 2014-06-30T07:27:25 *** skathpalia
8 2014-06-30T07:27:56 <skathpalia> dimazest, Added suggestions for tags in ticket modify and submit template and also shown all tags in tickets view
9 2014-06-30T07:28:00 <skathpalia> cr https://codereview.appspot.com/104420043/
10 2014-06-30T07:34:54 <dimazest> skathpalia: see my comments
11 2014-06-30T07:42:50 <skathpalia> dimazest, updated the cr
12 2014-06-30T07:43:40 <dimazest> skathpalia: was that code broken?
13 2014-06-30T07:43:48 <skathpalia> No
14 2014-06-30T07:43:58 <skathpalia> That was working
15 2014-06-30T07:44:02 <dimazest> hmm
16 2014-06-30T07:45:48 <dimazest> have you got the form if selected_tags is a list?
17 2014-06-30T07:45:55 <dimazest> that should have been broken
18 2014-06-30T07:46:35 <skathpalia> No we always convert selected_tags into set before passing it to tickets.html
19 2014-06-30T07:47:04 <skathpalia> You can see it here https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/214/added-filter-by-tags-option-and-option-of/diff#LMoinMoin/apps/frontend/views.pyT2226
20 2014-06-30T07:48:41 <dimazest> right
21 2014-06-30T07:50:27 <dimazest> then tags can be a list
22 2014-06-30T07:51:31 <dimazest> and the changes look fine
23 2014-06-30T07:51:55 <skathpalia> Can I commit it?
24 2014-06-30T07:53:04 <skathpalia> dimazest, ^^
25 2014-06-30T07:53:20 <dimazest> make tags a list
26 2014-06-30T07:54:04 <skathpalia> dimazest, updated the cr
27 2014-06-30T07:54:47 <dimazest> you can commit!
28 2014-06-30T07:55:22 <skathpalia> dimazest, Also one more cr regarding UI of tickets https://codereview.appspot.com/107060043/
29 2014-06-30T07:56:43 <skathpalia> The source was Ok according to ThomasWaldmann
30 2014-06-30T07:58:16 <skathpalia> dimazest, Can I commit this also?
31 2014-06-30T07:58:26 <dimazest> let me check it first
32 2014-06-30T08:01:56 *** greg_f
33 2014-06-30T08:04:32 <dimazest> this also is fine
34 2014-06-30T08:04:58 <skathpalia> Ok committing that also :)
35 2014-06-30T08:11:46 *** skathpalia
36 2014-06-30T08:41:38 *** sl33k_
37 2014-06-30T08:49:32 *** randomax
38 2014-06-30T09:05:17 *** Bernard1
39 2014-06-30T09:34:12 <randomax> ThomasWaldmann, cr needed - https://codereview.appspot.com/104410045
40 2014-06-30T09:34:29 <randomax> cleaned up some validation errors
41 2014-06-30T10:24:03 *** Bernard1
42 2014-06-30T11:00:23 *** randomax
43 2014-06-30T11:06:00 *** randomax
44 2014-06-30T11:26:26 *** magu_cic
45 2014-06-30T11:31:36 *** magu_cic
46 2014-06-30T13:14:15 *** randomax
47 2014-06-30T13:17:42 *** dave_largo
48 2014-06-30T13:30:01 *** randomax
49 2014-06-30T14:18:20 *** RogerHaase
50 2014-06-30T14:51:40 <randomax> RogerHaase, cr needed - https://codereview.appspot.com/104410045
51 2014-06-30T14:51:49 <randomax> validation errors
52 2014-06-30T14:52:01 <randomax> will brb.. going for dinner..
53 2014-06-30T15:34:14 <RogerHaase> randomax: commented on cr
54 2014-06-30T15:57:39 <randomax> RogerHaase, i mistakenly wrote home instead of index
55 2014-06-30T15:57:57 <randomax> but the css validation was giving errors in the changed lines
56 2014-06-30T15:58:14 <randomax> for example valign property is not a css attribute
57 2014-06-30T15:58:40 <randomax> also "content"
58 2014-06-30T15:58:53 <randomax> has no value of type "moin-folder-close"
59 2014-06-30T15:59:43 <randomax> the html validation tool just started working for me.. earlier since yesterday night it was giving me an "excess traffic pattern blocked error" so i was not being able to validate html
60 2014-06-30T15:59:52 <randomax> i'll put a cr for that in a few minutes
61 2014-06-30T16:01:11 <randomax> i also wanted to ask regarding the metadata ui
62 2014-06-30T16:01:48 <randomax> that in case the particular item in the itemlinks section does not belong to the current wiki
63 2014-06-30T16:02:06 <randomax> should i show a broken link or a valid link
64 2014-06-30T16:02:07 <randomax> ?
65 2014-06-30T16:11:55 <RogerHaase> randomax: on index page, these are errors I see: http://rn0.me/show/jowWWOE1r2sLAPaKXipo/
66 2014-06-30T16:14:42 <randomax> yeah.. same here
67 2014-06-30T16:14:50 <RogerHaase> randomax: I would put a valid link if the link is not the current wiki
68 2014-06-30T16:15:54 <randomax> ok..
69 2014-06-30T16:18:39 <RogerHaase> randomax: valign and icon-folder-close does not appear in the list of validation errors
70 2014-06-30T16:20:56 <randomax> yes.. they appear in the css validation tool
71 2014-06-30T16:22:07 <randomax> http://picpaste.com/pics/cssval-Q1Lp0lpR.1404145316.png
72 2014-06-30T16:22:24 <RogerHaase> randomax: you have different validation errors? can you show?
73 2014-06-30T16:25:58 <randomax> No.. there are two types of validation - HTML and CSS
74 2014-06-30T16:26:10 <randomax> I checked the HTML validation
75 2014-06-30T16:26:18 <randomax> it matches with what you provided
76 2014-06-30T16:26:24 <randomax> i also did the CSS validation
77 2014-06-30T16:26:46 <randomax> the CSS validation errors are the ones I fixed in the cr
78 2014-06-30T16:26:53 <randomax> http://picpaste.com/pics/cssval-Q1Lp0lpR.1404145316.png
79 2014-06-30T16:28:38 <RogerHaase> randomax: my fault, I read css validation, but was thinking html validation...
80 2014-06-30T16:50:32 <randomax> RogerHaase, removed html validation errors in index page http://codereview.appspot.com/103680044
81 2014-06-30T16:56:55 <RogerHaase> randomax: I remember looking at basic CSS validation a while back and thinking it was a mess, still is. Seems low payback, do not bother with it for now
82 2014-06-30T16:57:55 <randomax> yeah.. i worked on the html validation errors in the above cr
83 2014-06-30T17:16:14 *** skathpalia
84 2014-06-30T17:27:45 <RogerHaase> randomax: done with cr, suggest also fixing the warning messages
85 2014-06-30T17:30:25 <randomax> ok.. i'll do that in another patch
86 2014-06-30T17:33:35 <RogerHaase> randomax: actually, I did one more test, if you delete the name attribute rather than changing it to an ID, the duplicate ID error is eliminated and everything seems OK. Can you see any adverse changes?
87 2014-06-30T17:34:55 <RogerHaase> do in same patch, you have less than 10 characters changed.... still small
88 2014-06-30T17:36:08 <randomax> will try that.. ok i will do that in the same patch
89 2014-06-30T17:49:48 *** skathpalia
90 2014-06-30T17:59:22 <RogerHaase> randomax: that leaves the empty <h1></h1> problem. I would deal with that in a separate changeset. The global index page seems non-standard with respect to showing the title in an h1 tag
91 2014-06-30T17:59:41 <RogerHaase> must break for ~30 min
92 2014-06-30T17:59:57 <randomax> ok
93 2014-06-30T18:18:07 <randomax> RogerHaase, updated the cr https://codereview.appspot.com/103680044/
94 2014-06-30T18:24:25 *** sl33k_
95 2014-06-30T18:34:33 *** greg_f
96 2014-06-30T18:39:57 *** xjjk
97 2014-06-30T18:40:31 *** xjjk
98 2014-06-30T18:42:16 <RogerHaase> randomax: cr looks OK to me, ask tw
99 2014-06-30T18:42:50 <randomax> ThomasWaldmann, code review needed https://codereview.appspot.com/103680044/
100 2014-06-30T19:02:17 <ThomasWaldmann> randomax: why did you remove name= and for what was it used precisely?
101 2014-06-30T19:03:32 <RogerHaase> ThomasWaldmann: http://rn0.me/show/jowWWOE1r2sLAPaKXipo/ name was not used
102 2014-06-30T19:04:27 <ThomasWaldmann> really? strange that we had it then. :D
103 2014-06-30T19:04:30 <RogerHaase> that section was coded as if inside a form, but it is not
104 2014-06-30T19:05:19 <ThomasWaldmann> ok, looks fine then
105 2014-06-30T19:06:47 <randomax> i'll commit it then..
106 2014-06-30T19:54:31 *** sl33k_
107 2014-06-30T21:02:34 *** dave_largo
108 2014-06-30T21:07:45 <RogerHaase> ThomasWaldmann: #443 workaround, xstatic font-awesome 4.1.0.1 upgrade breaks icons, revert to 3.2.1.1 https://codereview.appspot.com/110300043/
109 2014-06-30T21:30:31 *** not-xjjk
110 2014-06-30T21:35:59 *** xjjk
111 2014-06-30T22:00:00 <ThomasWaldmann> RogerHaase: done
112 2014-06-30T22:16:07 *** RogerHaase
113 2014-06-30T22:36:58 *** sl33k_
114
