1 2014-07-16T02:00:44  *** penguinRaider has joined #moin-dev
   2 2014-07-16T06:10:03  *** penguinRaider has quit IRC
   3 2014-07-16T06:35:02  *** penguinRaider has joined #moin-dev
   4 2014-07-16T07:08:37  *** Bernard has joined #moin-dev
   5 2014-07-16T07:20:29  *** sl33k_ has joined #moin-dev
   6 2014-07-16T08:09:11  *** sl33k_ has quit IRC
   7 2014-07-16T08:17:22  *** sl33k_ has joined #moin-dev
   8 2014-07-16T08:45:34  *** greg_f has joined #moin-dev
   9 2014-07-16T09:01:47  *** sl33k_ has quit IRC
  10 2014-07-16T09:05:32  *** penguinRaider has quit IRC
  11 2014-07-16T09:12:02  *** Bernard has quit IRC
  12 2014-07-16T09:21:31  *** penguinRaider has joined #moin-dev
  13 2014-07-16T09:39:05  *** sl33k_ has joined #moin-dev
  14 2014-07-16T10:59:37  *** skathpalia has joined #moin-dev
  15 2014-07-16T11:07:59  *** rciorba has joined #moin-dev
  16 2014-07-16T11:08:08  *** rciorba has left #moin-dev
  17 2014-07-16T11:32:33  *** randomax has joined #moin-dev
  18 2014-07-16T11:49:13  <skathpalia> dimazest,  Added some more meta data information(specific to blog items such as ptime, supertags etc) to be displayed in basic theme and also removed the hardcoding of modify_meta template done in basic theme and moved commment in modify_meta_entry.html as it was causing syntax error there
  19 2014-07-16T11:49:24  <skathpalia> https://codereview.appspot.com/114850044/
  20 2014-07-16T12:49:21  <dimazest> skathpalia: could you please send a screenshot
  21 2014-07-16T12:53:20  <dimazest> skathpalia: looks good, but i'm not sure whether duplicated code is necessary
  22 2014-07-16T12:59:21  <skathpalia> dimazest, Actually macros have different names for modernized and basic theme
  23 2014-07-16T12:59:59  *** sl33k_ has quit IRC
  24 2014-07-16T13:00:20  <skathpalia> For example meta_editor() macro is defined only for modernized and foobar theme and basic_meta_editoris defined only for basic theme
  25 2014-07-16T13:00:52  <skathpalia> so adding meta_editor macro in basic theme in any template won't affect it and vice-versa
  26 2014-07-16T13:04:00  <skathpalia> screenshot for basic theme http://picpaste.com/meta_editor_basic-EE9FW71E.png
  27 2014-07-16T13:04:11  <skathpalia> for modernized theme http://picpaste.com/meta_editor_modernized-qUnwvPZf.png
  28 2014-07-16T13:06:08  *** sl33k_ has joined #moin-dev
  29 2014-07-16T13:07:03  <dimazest> ahh i see
  30 2014-07-16T13:07:54  <dimazest> looks a bit hackish, i mean json is shown and other cool things
  31 2014-07-16T13:07:56  <dimazest> i like it
  32 2014-07-16T13:13:50  <skathpalia> dimazest, due to this macros names differences only it the ptime, supertags etc were not shown
  33 2014-07-16T13:33:14  <skathpalia> dimazest, what did you mean by hackish ?
  34 2014-07-16T13:33:31  <skathpalia> i didnt get you, Can you please explain?
  35 2014-07-16T13:40:02  *** RogerHaase has joined #moin-dev
  36 2014-07-16T13:40:33  <dimazest> it's totally fine
  37 2014-07-16T13:40:52  <dimazest> just my grandmother would not understand what it is about
  38 2014-07-16T13:41:11  <dimazest> :)
  39 2014-07-16T13:41:38  <skathpalia> :D
  40 2014-07-16T13:41:55  <skathpalia> then, Can I commit it?
  41 2014-07-16T13:43:41  <skathpalia> dimazest, ^^
  42 2014-07-16T13:44:02  <dimazest> yes
  43 2014-07-16T13:44:17  <skathpalia> Ok
  44 2014-07-16T13:45:09  <skathpalia> Now I will work on my pending crs of #433 and UI of blog items :)
  45 2014-07-16T14:40:35  *** sl33k_ has quit IRC
  46 2014-07-16T15:07:22  *** RogerHaase has left #moin-dev
  47 2014-07-16T15:34:30  *** skathpalia has quit IRC
  48 2014-07-16T15:59:07  *** randomax has quit IRC
  49 2014-07-16T16:40:45  <ThomasWaldmann> moin
  50 2014-07-16T16:46:09  *** RogerHaase has joined #moin-dev
  51 2014-07-16T16:46:34  *** skathpalia has joined #moin-dev
  52 2014-07-16T16:48:05  <skathpalia> ThomasWaldmann, updated cr https://codereview.appspot.com/112780043/
  53 2014-07-16T17:18:52  *** randomax has joined #moin-dev
  54 2014-07-16T17:22:21  <ThomasWaldmann> skathpalia: see there
  55 2014-07-16T17:29:32  <randomax> moin
  56 2014-07-16T17:29:38  <randomax> ThomasWaldmann, review needed
  57 2014-07-16T17:29:43  <randomax> https://codereview.appspot.com/110210043/
  58 2014-07-16T17:29:48  <randomax> https://codereview.appspot.com/109410043/
  59 2014-07-16T17:29:54  <randomax> https://codereview.appspot.com/101630045/
  60 2014-07-16T17:30:00  <randomax> https://codereview.appspot.com/109440043/
  61 2014-07-16T17:30:04  <randomax> https://codereview.appspot.com/104590043/
  62 2014-07-16T17:30:15  <skathpalia> ThomasWaldmann, added comment in the code and updated the cr https://codereview.appspot.com/112780043/
  63 2014-07-16T17:30:16  <randomax> https://codereview.appspot.com/112830043/
  64 2014-07-16T17:38:31  <RogerHaase> ThomasWaldmann: template indentation coding standards  https://codereview.appspot.com/117810048/
  65 2014-07-16T17:47:34  *** sl33k_ has joined #moin-dev
  66 2014-07-16T17:59:31  *** greg_f has quit IRC
  67 2014-07-16T18:14:28  *** skathpalia has quit IRC
  68 2014-07-16T20:23:59  *** sl33k_ has quit IRC
  69 2014-07-16T20:28:32  *** sl33k_ has joined #moin-dev
  70 2014-07-16T22:00:17  *** RogerHaase has quit IRC
  71 2014-07-16T22:01:01  *** RogerHaase has joined #moin-dev
  72 2014-07-16T22:14:32  *** RogerHaase has left #moin-dev
  73 2014-07-16T22:36:38  *** sl33k_ has quit IRC
  74

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-07-16 (last edited 2014-07-16 02:15:02 by IrcLogImporter)