1 2014-08-02T09:30:21 *** greg_f
2 2014-08-02T11:27:27 *** greg_f
3 2014-08-02T15:01:17 *** randomax
4 2014-08-02T15:11:21 *** yogesh
5 2014-08-02T15:35:37 *** randomax
6 2014-08-02T15:35:52 *** yogesh
7 2014-08-02T15:36:27 *** saurabh
8 2014-08-02T15:36:35 *** saurabh
9 2014-08-02T15:40:15 *** randomax
10 2014-08-02T16:00:41 <ThomasWaldmann> dimazest: dreimark: randomax: skathpalia: waldi: meeting time :)
11 2014-08-02T16:01:01 <skathpalia> moin
12 2014-08-02T16:01:03 <ThomasWaldmann> (iirc, roger is still away)
13 2014-08-02T16:01:37 <skathpalia> dimazest is also offline till 10th August
14 2014-08-02T16:02:00 <randomax> moin
15 2014-08-02T16:02:25 <ThomasWaldmann> ok, guess we are as complete as it gets then.
16 2014-08-02T16:02:31 <ThomasWaldmann> skathpalia: please begin
17 2014-08-02T16:02:33 <skathpalia> Ok
18 2014-08-02T16:02:43 <skathpalia> Done:
19 2014-08-02T16:02:48 <skathpalia> Improved UI of Blog items in all the themes
20 2014-08-02T16:02:53 <skathpalia> Basic: https://codereview.appspot.com/113830043/
21 2014-08-02T16:02:58 <skathpalia> Modernized: https://codereview.appspot.com/121930043/
22 2014-08-02T16:03:03 <skathpalia> Foobar: https://codereview.appspot.com/118490044/
23 2014-08-02T16:03:10 <skathpalia> Also in foobar theme shown itemview such as modify, add link etc in blog view
24 2014-08-02T16:03:16 <skathpalia> Fixed traceback which comes on accessing +admin/itemsize due to presence of ticket items
25 2014-08-02T16:03:21 <skathpalia> https://codereview.appspot.com/120230043/
26 2014-08-02T16:03:27 <skathpalia> Also updated the cr https://codereview.appspot.com/114210043/
27 2014-08-02T16:03:33 <skathpalia> So now both the issues that were reported by Roger in my previous repo
28 2014-08-02T16:03:47 <skathpalia> have been solved :)
29 2014-08-02T16:03:54 <skathpalia> Blocked: None
30 2014-08-02T16:03:59 <skathpalia> TODO:
31 2014-08-02T16:04:05 <skathpalia> Work on some more UI improvements of blogs in basic theme.
32 2014-08-02T16:04:14 <skathpalia> Also need to finalize whether we should remove ticket.styl or not because of stylus issues
33 2014-08-02T16:04:14 <skathpalia> Get the pending crs finalized
34 2014-08-02T16:04:31 <skathpalia> Also get some pending crs finalized
35 2014-08-02T16:04:44 <skathpalia> Also try to write some tests for tickets
36 2014-08-02T16:04:57 <ThomasWaldmann> for blog main items, there is still no "create blog entry"?
37 2014-08-02T16:05:28 <skathpalia> I have added a button of blog-create-entry in blog view with a TODO
38 2014-08-02T16:05:44 <skathpalia> TODO of creating the items without any initial fqname
39 2014-08-02T16:06:01 <skathpalia> cr https://codereview.appspot.com/116940044/
40 2014-08-02T16:06:14 <waldi> moin
41 2014-08-02T16:07:13 <ThomasWaldmann> i don't see a button
42 2014-08-02T16:07:24 * ThomasWaldmann runs the current main repo code
43 2014-08-02T16:07:53 <skathpalia> Its not comitted, I have added button in this cr https://codereview.appspot.com/116940044/
44 2014-08-02T16:07:56 <skathpalia> ThomasWaldmann, ^^
45 2014-08-02T16:08:00 <ThomasWaldmann> ah, ok
46 2014-08-02T16:08:30 <skathpalia> I got it reviewed by Roger, its Ok according to him
47 2014-08-02T16:08:51 <skathpalia> Can I commit it after updating it as per the current repo?
48 2014-08-02T16:09:30 <ThomasWaldmann> i have to look at the still todo codereviews, a list would be fine
49 2014-08-02T16:10:20 <ThomasWaldmann> but the priority task for next week is to get pending stuff finished and committed
50 2014-08-02T16:10:47 <skathpalia> Yeah will try to get the pending crs committed :)
51 2014-08-02T16:12:11 <ThomasWaldmann> also, to practically work with the new functionality, to identify places with lacking UI/UX or where it blows up
52 2014-08-02T16:13:41 <skathpalia> yeah sure ... will try to do some more improvements to the above :)
53 2014-08-02T16:13:43 <ThomasWaldmann> is the above list of crs complete (i mean the stuff that still needs review rather than the already committed stuff)?
54 2014-08-02T16:14:12 <skathpalia> No there are some more pending crs
55 2014-08-02T16:14:24 <skathpalia> https://codereview.appspot.com/111410043/
56 2014-08-02T16:15:05 <ThomasWaldmann> maybe you can go through all your CRs and close the ones that are committed
57 2014-08-02T16:15:08 <skathpalia> Also need to confirm if we can delete ticket.styl and just have ticket.css due to stylus issues
58 2014-08-02T16:15:28 <ThomasWaldmann> then the still todo stuff is easier to discover :)
59 2014-08-02T16:15:32 <skathpalia> Ok will close committed ones :)
60 2014-08-02T16:16:30 <skathpalia> ThomasWaldmann, what do you say on deleting ticket.styl?
61 2014-08-02T16:17:11 <ThomasWaldmann> i don't like how ticket.css looks like currently
62 2014-08-02T16:17:21 <ThomasWaldmann> .styl looks better
63 2014-08-02T16:17:46 <skathpalia> Roger tried this cr https://codereview.appspot.com/115260043/
64 2014-08-02T16:18:00 <skathpalia> In this ticket.css also looks better
65 2014-08-02T16:19:34 <ThomasWaldmann> that's better, but still looks ugly
66 2014-08-02T16:20:05 <skathpalia> I think after proper indentation it will look much better
67 2014-08-02T16:20:38 <ThomasWaldmann> guess we can decide when roger is back, deleting a file and reformatting another one isn't that much
68 2014-08-02T16:20:59 <skathpalia> Ok we will discuss it then :)
69 2014-08-02T16:22:46 <ThomasWaldmann> did summary get renamed to title on the UI?
70 2014-08-02T16:23:37 <skathpalia> Yeah It shows Title (required) on the UI of blog-entries
71 2014-08-02T16:24:09 <ThomasWaldmann> why?
72 2014-08-02T16:25:22 <skathpalia> Actually it was already Title I just added (required) with it
73 2014-08-02T16:25:45 <ThomasWaldmann> the main question is why it is not consistent:
74 2014-08-02T16:25:53 <ThomasWaldmann> it is called summary in metadata
75 2014-08-02T16:26:00 <ThomasWaldmann> it is called title for blog
76 2014-08-02T16:26:07 <ThomasWaldmann> it is called summary for issue
77 2014-08-02T16:26:42 <ThomasWaldmann> also, for issues, it still shows the item name as "title", not the summary
78 2014-08-02T16:26:53 <skathpalia> Oh yeah will change it to summary (required)
79 2014-08-02T16:27:49 <skathpalia> I have removed showing item_name in https://codereview.appspot.com/114210043/ will show summary now :)
80 2014-08-02T16:27:55 <skathpalia> will update this cr
81 2014-08-02T16:27:57 <ThomasWaldmann> ok
82 2014-08-02T16:29:24 <ThomasWaldmann> ok, nothing else for now from me. waldi, dreimark: anything from you?
83 2014-08-02T16:29:36 <waldi> no
84 2014-08-02T16:30:13 <ThomasWaldmann> next week is the last real work week, you should be finished with your main things be the end of it.
85 2014-08-02T16:30:19 <ThomasWaldmann> by*
86 2014-08-02T16:30:33 <skathpalia> Ok :)
87 2014-08-02T16:30:51 <ThomasWaldmann> the week after that is mainly for fixing/polishing whatever we find
88 2014-08-02T16:31:25 <ThomasWaldmann> ok, thanks skathpalia. randomax: your stage!
89 2014-08-02T16:31:32 <randomax> Done-
90 2014-08-02T16:31:37 <randomax> Added raw view and hence users can use custom css with item names such as "item.css" - https://codereview.appspot.com/116550043/
91 2014-08-02T16:31:52 <randomax> Removed subitems sidebar in modernized theme - https://codereview.appspot.com/114700043/
92 2014-08-02T16:32:02 <randomax> Refreshed page after theme change as per sharky93 issue 66 https://codereview.appspot.com/121720043/
93 2014-08-02T16:32:10 <randomax> Added bootstrap tables to Item Size view and Interwiki Names view and also made item sizes human readable - https://codereview.appspot.com/119150043/
94 2014-08-02T16:32:16 <randomax> made modify edit textarea expand/contract to fit window size like modernized and foobar - https://codereview.appspot.com/113570043/
95 2014-08-02T16:32:20 <ThomasWaldmann> can you point me where using items as css was discussed/planned?
96 2014-08-02T16:32:57 <randomax> http://etherpad.osuosl.org/moin-improve-gui - line 293
97 2014-08-02T16:33:20 <randomax> Added background color to sidebar so that it looks separate from the content - https://codereview.appspot.com/118330043/ - http://picpaste.com/pics/newbasic-RQz0yyJz.1406995574.png
98 2014-08-02T16:33:26 <randomax> Added css classes for making multicolumn lists - https://codereview.appspot.com/121730043/
99 2014-08-02T16:33:32 <randomax> Added capability to edit acl in item acl report view itself - https://codereview.appspot.com/119880046/
100 2014-08-02T16:33:36 <randomax> Removed auto-computed values from metadata-edit view, added usergroup section - https://codereview.appspot.com/113780043/
101 2014-08-02T16:33:47 <randomax> Blocked-
102 2014-08-02T16:33:49 <randomax> None
103 2014-08-02T16:33:54 <randomax> NEXT-
104 2014-08-02T16:34:00 <randomax> Make some sample custom css items and close small open issues in own repo to finish up main part of project
105 2014-08-02T16:35:35 <ThomasWaldmann> don't waste too much time on custom css, I'ld rather have the default css in a state that not everybody feels the urge to customize it.
106 2014-08-02T16:36:45 <randomax> it was not so much of work actually
107 2014-08-02T16:36:58 <randomax> one small cr to allow raw view
108 2014-08-02T16:37:24 <ThomasWaldmann> also, why did that need a new +raw view? iirc we already have a view that gives the item content "as is"?
109 2014-08-02T16:38:15 <ThomasWaldmann> (see the url it uses to transclude images, for example)
110 2014-08-02T16:38:34 <ThomasWaldmann> {{foo.png}}
111 2014-08-02T16:39:18 <randomax> i didnt get which view you are talking about ?
112 2014-08-02T16:39:42 <ThomasWaldmann> just see what it uses as src= there
113 2014-08-02T16:40:20 <ThomasWaldmann> global history still looks rather crappy, btw
114 2014-08-02T16:40:33 <ThomasWaldmann> such stuff is way more important than adding user-definable css
115 2014-08-02T16:40:57 <ThomasWaldmann> (== which not many users will be able to use anyway)
116 2014-08-02T16:41:52 <randomax> yeah i wanted to ask whether i can use the images used in the other themes for that.. the icons i mean
117 2014-08-02T16:41:58 *** saurabh
118 2014-08-02T16:42:17 <ThomasWaldmann> the view is +get
119 2014-08-02T16:42:20 *** skathpalia
120 2014-08-02T16:42:22 *** saurabh
121 2014-08-02T16:42:28 *** Guest95977
122 2014-08-02T16:42:55 <ThomasWaldmann> so check whether you can use +get and kill +raw again
123 2014-08-02T16:44:03 <ThomasWaldmann> first get a clean layout. and i think a theme shall rather not use icons from another theme, but have its own.
124 2014-08-02T16:45:06 <randomax> ok i'll use new icons
125 2014-08-02T16:47:32 <ThomasWaldmann> ok, same priorities for you: get pending stuff reviewed/committed, concentrate on important main goals next week.
126 2014-08-02T16:47:58 <ThomasWaldmann> close CRs that were already committed
127 2014-08-02T16:48:46 <randomax> yeah i already closed the ones that are committed
128 2014-08-02T16:49:05 <ThomasWaldmann> practically use the wiki to identify bad UI/UX and places where it blows up
129 2014-08-02T16:50:19 <ThomasWaldmann> (because that's what your mentors will do after the pencils down, so you can avoid them finding a lot of issues by finding them on your own first, while you still have time to fix)
130 2014-08-02T16:50:44 <randomax> ok i'll do that.. the problem with +get view is that i need add the a ".css" itemtype
131 2014-08-02T16:51:32 <ThomasWaldmann> itemtype or contenttype?
132 2014-08-02T16:51:47 <randomax> sorry contenttype
133 2014-08-02T16:52:18 <ThomasWaldmann> yeah, it needs to be text/css, but it should be that anyway
134 2014-08-02T16:52:45 <randomax> ok i'll add the option for that in the create new item section
135 2014-08-02T16:53:30 <ThomasWaldmann> what i feel a bit uncomfortable about is that css styles can contain js (iirc, at least style="..." html attr can contain js)
136 2014-08-02T16:53:59 <ThomasWaldmann> waldi: is it the same for plain css content?
137 2014-08-02T16:54:27 <waldi> no
138 2014-08-02T16:55:09 <ThomasWaldmann> ok, so it is just style=... but not css rules?
139 2014-08-02T16:57:31 <ThomasWaldmann> http://stackoverflow.com/questions/3607894/cross-site-scripting-in-css-stylesheets
140 2014-08-02T16:59:40 <ThomasWaldmann> so, if that really is an issue (and it seems like on first sight), you're maybe working on a bug, not a feature
141 2014-08-02T17:00:50 <randomax> the reason i was working on that was that the wiki already has an option for user css url
142 2014-08-02T17:01:31 <randomax> and me and roger decided that we need an easier way to for users to give css styles as every user might not have access to a server to host their css
143 2014-08-02T17:01:47 <randomax> so we thought maybe we can create wiki items regarding the same
144 2014-08-02T17:02:08 <ThomasWaldmann> yeah, old moin had this also, but i bet less than 1% of all users used it
145 2014-08-02T17:02:48 <ThomasWaldmann> and if the only clean way to do such stuff is to introduce an XSS issue, you maybe rather should not do it
146 2014-08-02T17:03:50 <randomax> fine.. i'll leave that..
147 2014-08-02T17:04:45 <ThomasWaldmann> ok. guess noone will miss that if just our default css is nice.
148 2014-08-02T17:05:42 <ThomasWaldmann> ok, any more questions?
149 2014-08-02T17:06:02 <randomax> nope
150 2014-08-02T17:07:04 <ThomasWaldmann> ok, so final spurt next 2 weeks! ;)
151 2014-08-02T17:07:40 <ThomasWaldmann> thanks for attending, official part over now
152 2014-08-02T17:08:02 * ThomasWaldmann does some CR now
153 2014-08-02T17:15:20 <ThomasWaldmann> strange, CR has some issues with drafts by me... (like if I didn't submit them, but I am pretty sure i always do "m")
154 2014-08-02T17:19:42 <ThomasWaldmann> what's also rather bad is that as a reviewer one can not close issues... - so if the submitter of a CR does not close it, as a reviewer you'll have it in your list forever...
155 2014-08-02T17:23:49 *** randomax
156 2014-08-02T17:31:54 <ThomasWaldmann> haha, there is a 5yo issue about this...
157 2014-08-02T18:04:14 <ThomasWaldmann> dimazest: doing some more tests on your pytest work and then merging
158 2014-08-02T19:14:44 <ThomasWaldmann> skathpalia: please pull/merge from main repo
159 2014-08-02T19:14:52 <ThomasWaldmann> randomax: ^^
160 2014-08-02T19:22:03 *** skathpalia
161
