1 2014-10-13T09:13:45 *** greg_f
2 2014-10-13T12:21:27 *** moinBot
3 2014-10-13T12:22:53 *** xorAxAx
4 2014-10-13T12:23:38 *** vpv
5 2014-10-13T12:24:30 *** vpv
6 2014-10-13T12:25:22 *** xorAxAx
7 2014-10-13T12:28:45 *** pjoshi
8 2014-10-13T12:41:28 <pjoshi> ThomasWaldmann: Hello I have sent you the pull request for the issue #455
9 2014-10-13T12:47:55 *** pjoshi
10 2014-10-13T13:18:22 *** pjoshi
11 2014-10-13T13:40:32 *** greg_f
12 2014-10-13T13:45:40 *** pjoshi
13 2014-10-13T13:52:32 *** greg_f
14 2014-10-13T14:14:44 *** RogerHaase
15 2014-10-13T15:27:59 *** dave_largo
16 2014-10-13T15:44:34 <ThomasWaldmann> moin
17 2014-10-13T15:44:53 <RogerHaase> moin :)
18 2014-10-13T15:51:40 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/238/455-global-index-view-has-odd-link-to/diff
19 2014-10-13T15:52:14 <ThomasWaldmann> that does not even look internall consistent (look at where a # [anchor] is used and where not)
20 2014-10-13T15:53:30 <ThomasWaldmann> also, making the link directly from e.relname looks rather questionable (what if the wiki does not run at / url? what if relname is non-ascii?)
21 2014-10-13T15:55:07 <RogerHaase> have not tested the non-root part, will try
22 2014-10-13T15:56:15 <ThomasWaldmann> i didn't look up what relname precisly contains, but from the name I suppose it is a "relative name" (not something that can be directly used in a url)
23 2014-10-13T15:56:43 * ThomasWaldmann declined the PR for now
24 2014-10-13T15:58:44 <ThomasWaldmann> btw, gci and gsoc 2015 was announced recently. if someone thinks we should take part, we should talk about it.
25 2014-10-13T16:11:37 *** pjoshi
26 2014-10-13T16:11:52 <pjoshi> ThomasWaldmann: Hello
27 2014-10-13T16:11:55 <ThomasWaldmann> ananasova: dimazest: eSyr: RogerHaase: sharky93: sunu: waldi: xorAxAx: if you think we should apply for Google Code-In (and later for GSOC2015) and you'ld like to take an active role, please tell so.
28 2014-10-13T16:12:33 <pjoshi> Will you please tell me for the decline of my pull request ?
29 2014-10-13T16:12:41 * ThomasWaldmann won't apply except if there is significant interest of helpers / mentors
30 2014-10-13T16:12:54 <ThomasWaldmann> pjoshi: read the comment given there
31 2014-10-13T16:13:53 <pjoshi> ThomasWaldmann: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/238/455-global-index-view-has-odd-link-to/diff
32 2014-10-13T16:13:58 <pjoshi> No comment here ?
33 2014-10-13T16:14:24 <ThomasWaldmann> well, i gave it when declining, so I'ld expect you got it?
34 2014-10-13T16:15:29 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/238/455-global-index-view-has-odd-link-to/activity see there
35 2014-10-13T16:22:19 <RogerHaase> ThomasWaldmann: I have no interest in participating in gci, would help out in gsoc2015 but not as mentor
36 2014-10-13T16:26:05 <pjoshi> RogerHaase: What does the "anchor" do here in https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/238/455-global-index-view-has-odd-link-to/diff#chg-MoinMoin/templates/index.html
37 2014-10-13T16:26:46 <ThomasWaldmann> RogerHaase: ok, thanks
38 2014-10-13T16:27:31 <ThomasWaldmann> pjoshi: your question is unclear
39 2014-10-13T16:28:36 <pjoshi> ThomasWaldmann: I am not able to detect the functioning of "macro entry_anchor" there ?
40 2014-10-13T16:30:00 <ThomasWaldmann> you removed that macro, so it's not there any more.
41 2014-10-13T16:30:36 <pjoshi> Yeah That's why I didn't care about the entry_anchor thing
42 2014-10-13T16:31:09 <pjoshi> But you mentioned that in your comment about the anchor
43 2014-10-13T16:31:09 <ThomasWaldmann> but compare 102 in first to 116 in second template
44 2014-10-13T16:31:51 <ThomasWaldmann> and i didn't mention entry_anchor macro
45 2014-10-13T16:33:52 <pjoshi> ThomasWaldmann: 102 was the wrong code I commited... I am sorry for that as in the "#" is extra there in the href.
46 2014-10-13T16:34:57 <pjoshi> I commited code and then updated that code again
47 2014-10-13T16:39:37 <ThomasWaldmann> ok, so the # there should not be there?
48 2014-10-13T16:40:22 <pjoshi> ThomasWaldmann: Yup
49 2014-10-13T16:40:31 <pjoshi> # will not be there
50 2014-10-13T16:43:14 <ThomasWaldmann> ok, then just the url building is left
51 2014-10-13T16:43:40 <pjoshi> ThomasWaldmann: I guess in the updated version I ahve cleared that too
52 2014-10-13T16:43:49 <ThomasWaldmann> what precisely is in e.relname. type of object? semantics of object?
53 2014-10-13T16:46:34 <pjoshi> ThomasWaldmann: As we needed the url should contain the name of the object when we click on the ↑ sign so e is in the objects from dirs and relname is the name of that object
54 2014-10-13T16:47:31 <pjoshi> So basically here we are just appending the name of the object only rather than some index which was appended earlier but now changed to the name of that object
55 2014-10-13T16:50:32 <RogerHaase> back; that <a href="{{ e.relname }}" does work when the wiki is not running at server root http://www.digitalrockart.org/moin2/+index/
56 2014-10-13T16:52:02 <ThomasWaldmann> so. e.relname could be u"TestUmlautsÜÖÄ" ?
57 2014-10-13T16:53:32 <ThomasWaldmann> feel free to use any other non-ascii chars or other chars not valid in urls
58 2014-10-13T16:53:46 <ThomasWaldmann> *url pathes, to be more precise
59 2014-10-13T16:53:58 <RogerHaase> yes, try the link after AjudaNaFormataçã
60 2014-10-13T16:54:08 <RogerHaase> link/arrow link
61 2014-10-13T16:54:21 <pjoshi> I guess the url is working for almost all values
62 2014-10-13T16:55:31 <ThomasWaldmann> <a href="/moin2/+index/AjudaNaFormata%C3%A7%C3%A3o"
63 2014-10-13T16:55:39 <ThomasWaldmann> <a href="AjudaNaFormatação"
64 2014-10-13T16:56:03 <ThomasWaldmann> that the 2nd works is sheer luck and not included in the standards
65 2014-10-13T16:56:37 <pjoshi> if AjudaNaFormatação is the name of the directory, then it will gonna work
66 2014-10-13T16:56:42 <ThomasWaldmann> the first one is how it looks in a compliant url
67 2014-10-13T16:58:05 <ThomasWaldmann> so, I guess you really want to use url_for somehow
68 2014-10-13T16:59:08 <pjoshi> url_for ?
69 2014-10-13T16:59:48 <ThomasWaldmann> just grep for it in the code/templates
70 2014-10-13T17:00:10 <ThomasWaldmann> you give it a name (etc.) and it makes a valid url for you
71 2014-10-13T17:01:16 <pjoshi> Oh then I guess we have to use that and give the name e.relname to that, right ?
72 2014-10-13T17:04:33 <pjoshi> RogerHaase: I came to know about that name space problem
73 2014-10-13T17:05:08 <pjoshi> As in the global index view and even in history view we are just getting default values only
74 2014-10-13T17:05:44 <ThomasWaldmann> pjoshi: url_for just knows what you give to it, so it at least needs the full name
75 2014-10-13T17:06:29 <ThomasWaldmann> (aside from the server name and base path of the installation, which is always same for a specific wiki)
76 2014-10-13T17:10:12 <pjoshi> ThomasWaldmann: Okay so in place or e.relname in the url I ahve to use url_for and will give the name of the object in the dirs
77 2014-10-13T17:10:18 <pjoshi> means e.name
78 2014-10-13T17:16:48 <ThomasWaldmann> likely yes
79 2014-10-13T17:17:14 <ThomasWaldmann> (I didn't look up the code yet that feeds the template)
80 2014-10-13T17:17:41 <ThomasWaldmann> but you'll see url_for at a lot of places if you need examples
81 2014-10-13T17:18:36 <pjoshi> Yeah I will go through that now
82 2014-10-13T17:18:47 <pjoshi> And will correct that thing
83 2014-10-13T17:27:29 <ThomasWaldmann> RogerHaase: do you run the latest 1.9 code from the repo?
84 2014-10-13T17:30:23 <RogerHaase> ThomasWaldmann: I updated ~ one month ago when you asked for testers
85 2014-10-13T17:30:50 <ThomasWaldmann> anything unusual?
86 2014-10-13T17:31:02 <ThomasWaldmann> there was a small change some weeks ago btw
87 2014-10-13T17:31:34 * ThomasWaldmann looks at https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/239/several-fixes-to-basic-theme/commits
88 2014-10-13T17:37:35 <ThomasWaldmann> RogerHaase: when using div class=col..., isn't it required to have class=row around it? you removed it and replaced it by class=container.
89 2014-10-13T17:38:40 <RogerHaase> yes, bootlint flagged it, the col is supposed to be under a row
90 2014-10-13T17:42:20 <ThomasWaldmann> https://bitbucket.org/RogerHaase/moin-2.0/commits/5e5b0b454e1dbd976981531697c0fcd2689b6bf0#LMoinMoin/themes/basic/templates/layout.htmlT54 but there it is col without row
91 2014-10-13T17:45:05 <ThomasWaldmann> great, lots of fixes and cleanups in that PR \o/
92 2014-10-13T17:50:52 <ThomasWaldmann> RogerHaase: ^
93 2014-10-13T17:51:13 <ThomasWaldmann> https://bitbucket.org/RogerHaase/moin-2.0/commits/eb4595aea80bdc350b6d116bb592cfb204f82b7b < really duplicate? . vs : ?
94 2014-10-13T17:52:20 <RogerHaase> oops, will put that back
95 2014-10-13T17:53:12 <ThomasWaldmann> not sure if both things are used, just noticed it is not exactly same
96 2014-10-13T17:55:49 <RogerHaase> that container was replaced with row 2 patches later
97 2014-10-13T17:56:06 <ThomasWaldmann> ah, ok
98 2014-10-13T17:56:11 <RogerHaase> must break for 30 minutes
99 2014-10-13T18:04:01 <ThomasWaldmann> https://www.youtube.com/watch?v=d49kmiE_Bp4
100 2014-10-13T18:11:19 *** pjoshi
101 2014-10-13T18:21:47 *** greg_f
102 2014-10-13T20:14:56 <RogerHaase> ThomasWaldmann: I favor removing the few bootstrap classes being used to style things within moin-content and using (sometimes adding) the more traditional moin styling. The first to be changed are the 6 tables under the User and Admin links (My Changes, Users, Groups...)
103 2014-10-13T20:15:43 <RogerHaase> imho, the bootstrap styling is rather ugly. But the bigger issue is to NOT change the parsers to put out things like "<table class="table table-hover tablesorter tablesorter-default zebra moin-sortable"
104 2014-10-13T21:01:56 <RogerHaase> ThomasWaldmann: fyi, I pulled moin 1.9 updates, no issues
105 2014-10-13T21:03:15 *** dave_largo
106 2014-10-13T21:52:06 *** RogerHaase
107
