MoinMoin: MoinMoinChat/Logs/moin-dev/2015-01-27

   1 2015-01-27T02:33:07  *** yogicxl has joined #moin-dev
   2 2015-01-27T06:12:06  *** Kallor has joined #moin-dev
   3 2015-01-27T07:03:51  *** Kallor has quit IRC
   4 2015-01-27T07:53:26  *** Kallor has joined #moin-dev
   5 2015-01-27T08:44:42  *** Kallor has quit IRC
   6 2015-01-27T09:15:17  *** greg_f has joined #moin-dev
   7 2015-01-27T11:12:46  *** Kallor has joined #moin-dev
   8 2015-01-27T11:16:01  *** Kallor has quit IRC
   9 2015-01-27T11:23:27  *** greg_f has quit IRC
  10 2015-01-27T12:19:27  *** greg_f has joined #moin-dev
  11 2015-01-27T13:44:32  <yogicxl> ThomasWaldmann, please review https://codereview.appspot.com/195380043/
  12 2015-01-27T14:20:56  *** pjoshi_ has joined #moin-dev
  13 2015-01-27T15:20:19  <pjoshi_> ThomasWaldmann: Moin
  14 2015-01-27T15:21:28  <pjoshi_> ThomasWaldmann: If we use anchors in the index.html in #455 ,then instead of using the name of the item in the anchor like 'e.fullname' we have to get the url from other way ?
  15 2015-01-27T15:27:29  <ThomasWaldmann> why would you use an anchor? i thought the goal was to use a link?
  16 2015-01-27T15:27:53  <ThomasWaldmann> (to +index/ThatItem)
  17 2015-01-27T15:28:35  <pjoshi_> yeah but I am not able to find 'X' in url_for(',X', e.fullname)
  18 2015-01-27T15:28:52  <pjoshi_> which can append thatitem to /+index
  19 2015-01-27T15:34:16  <ThomasWaldmann> looks at the url routing, the placeholder name is defined there
  20 2015-01-27T15:34:29  <ThomasWaldmann> look*
  21 2015-01-27T15:34:51  <ThomasWaldmann> (and grep for url_for to get examples)
  22 2015-01-27T15:35:10  <pjoshi_> Okay.
  23 2015-01-27T15:57:52  <pjoshi_> ThomasWaldmann: Yeah done X is '.index'
  24 2015-01-27T15:58:58  * ThomasWaldmann bbl
  25 2015-01-27T16:02:00  *** pjoshi_ has quit IRC
  26 2015-01-27T16:02:30  *** RogerHaase has joined #moin-dev
  27 2015-01-27T16:02:38  *** pjoshi_ has joined #moin-dev
  28 2015-01-27T16:05:04  <pjoshi_> ThomasWaldmann: Please review it https://codereview.appspot.com/139660043/patch/200001/210001 ... Hopefully the last time for that issue :P
  29 2015-01-27T16:07:51  *** pjoshi_ has quit IRC
  30 2015-01-27T16:08:25  *** pjoshi_ has joined #moin-dev
  31 2015-01-27T16:15:11  *** xiaq has joined #moin-dev
  32 2015-01-27T16:16:11  *** pjoshi_ has quit IRC
  33 2015-01-27T16:16:46  *** pjoshi_ has joined #moin-dev
  34 2015-01-27T16:17:30  *** greg__ has joined #moin-dev
  35 2015-01-27T16:18:00  *** greg_f has quit IRC
  36 2015-01-27T16:18:00  *** xiaq_ has quit IRC
  37 2015-01-27T16:33:37  *** pjoshi_ has quit IRC
  38 2015-01-27T16:34:09  *** pjoshi_ has joined #moin-dev
  39 2015-01-27T16:43:37  <pjoshi_> RogerHaase: Moin
  40 2015-01-27T16:46:50  <pjoshi_> RogerHaase: Please review it https://codereview.appspot.com/139660043/patch/200001/210001 ... Hopefully the last time for that issue :P
  41 2015-01-27T16:47:26  <yogicxl> RogerHaase, please review please review https://codereview.appspot.com/195380043/
  42 2015-01-27T16:49:53  *** dave_largo has joined #moin-dev
  43 2015-01-27T16:50:44  <RogerHaase> pjoshi_: I looked at that, seems OK. When you pass a CR url, easiest for reviewers is https://codereview.appspot.com/139660043/ as most reviewers will look at messages, then side-by-side diffs
  44 2015-01-27T16:51:17  <pjoshi_> RogerHaase: Okay will take care of that
  45 2015-01-27T16:51:18  <pjoshi_> :)
  46 2015-01-27T16:56:39  *** pjoshi_ has quit IRC
  47 2015-01-27T17:05:20  <RogerHaase> yogicxl: you forgot to run ./m tests before submitting patch for review
  48 2015-01-27T17:06:07  <yogicxl> RogerHaase, i guess so.
  49 2015-01-27T17:06:19  <RogerHaase> ... also always a good idea to run ./m coding-std and ./m css just before uploading a patch for CR
  50 2015-01-27T17:06:52  <yogicxl> RogerHaase, i ll keep that in mind
  51 2015-01-27T17:08:12  <yogicxl> RogerHaase, Could you please suggest me a better way for style="input:readonly", I wish to make the form elements unedittable.
  52 2015-01-27T17:24:43  <yogicxl> RogerHaase, My tests are taking unusually long time to run. Could tell me what could be the problem? In my m-pytest.txt file it is hanging on line 714: "i/lib/python2.7/site-packages/setuptools/tests/test_packageindex.py F......"
  53 2015-01-27T17:31:18  *** dave_largo has quit IRC
  54 2015-01-27T17:31:50  *** yogicxl has quit IRC
  55 2015-01-27T17:32:26  <RogerHaase> yogicxl: running full tests usually take 5+ minutes for me.  if you want to ru an individual test, you can do ./m pytest -k views.py
  56 2015-01-27T17:39:30  *** yogicxl has joined #moin-dev
  57 2015-01-27T17:48:44  <yogicxl> RogerHaase, In my case the ./m test has not completed in my last two tries I made, I gave atleast 13 mins each time but it hangs at line 714.
  58 2015-01-27T17:52:47  <RogerHaase> yogicxl: dk, post entire m-pytest.txt
  59 2015-01-27T17:53:08  <yogicxl> RogerHaase, ok i will.
  60 2015-01-27T17:54:47  <RogerHaase> yogicxl: on your patch, you have style="input:read-only; should be readonly. For some reason it works on basic theme but not on modernized
  61 2015-01-27T17:55:00  <RogerHaase> must break for an hour...
  62 2015-01-27T18:00:53  *** SteveMcIntyre has quit IRC
  63 2015-01-27T18:11:40  <yogicxl> RogerHaase, This is the error log. http://www.fpaste.org/176225/23822331/
  64 2015-01-27T18:13:01  *** yogicxl has quit IRC
  65 2015-01-27T18:26:28  *** greg__ has quit IRC
  66 2015-01-27T18:42:34  *** dave_largo has joined #moin-dev
  67 2015-01-27T19:05:54  *** SteveMcIntyre has joined #moin-dev
  68 2015-01-27T19:24:46  *** jek__ is now known as jek
  69 2015-01-27T20:22:45  *** ananasov1 has joined #moin-dev
  70 2015-01-27T20:32:42  *** ananasova has quit IRC
  71 2015-01-27T21:19:58  *** dave_largo has quit IRC
  72 2015-01-27T21:58:42  *** RogerHaase has left #moin-dev
  73 2015-01-27T22:28:58  * ThomasWaldmann will reboot soon
  74 2015-01-27T22:29:25  *** ThomasWaldmann has quit IRC
  75 2015-01-27T23:18:30  *** moinBot has joined #moin-dev
  76