1 2015-01-31T07:40:39  *** pjoshi_ has joined #moin-dev
   2 2015-01-31T07:41:19  <pjoshi_> Moin
   3 2015-01-31T07:41:36  <pjoshi_> ThomasWaldmann: Should I send a pull request now ?
   4 2015-01-31T08:14:55  *** pjoshi_ has quit IRC
   5 2015-01-31T08:39:50  *** pjoshi_ has joined #moin-dev
   6 2015-01-31T09:09:16  *** pjoshi_ has quit IRC
   7 2015-01-31T09:42:57  *** pjoshi_ has joined #moin-dev
   8 2015-01-31T09:48:35  *** pjoshi_ has joined #moin-dev
   9 2015-01-31T11:38:06  *** pjoshi_ has quit IRC
  10 2015-01-31T11:59:15  *** greg_f has joined #moin-dev
  11 2015-01-31T12:14:48  *** greg_f has quit IRC
  12 2015-01-31T12:24:00  *** greg_f has joined #moin-dev
  13 2015-01-31T12:44:32  *** greg__ has joined #moin-dev
  14 2015-01-31T12:44:52  *** greg_f has quit IRC
  15 2015-01-31T13:58:19  *** pjoshi_ has joined #moin-dev
  16 2015-01-31T14:04:24  *** greg__ has quit IRC
  17 2015-01-31T14:07:31  *** greg_f has joined #moin-dev
  18 2015-01-31T14:41:36  *** pjoshi_ has quit IRC
  19 2015-01-31T14:47:18  *** greg_f has quit IRC
  20 2015-01-31T14:48:01  *** greg_f has joined #moin-dev
  21 2015-01-31T15:01:12  *** RogerHaase has joined #moin-dev
  22 2015-01-31T15:17:13  *** greg_f has quit IRC
  23 2015-01-31T15:30:40  *** pjoshi_ has joined #moin-dev
  24 2015-01-31T15:35:42  <pjoshi_> moin
  25 2015-01-31T15:35:51  <pjoshi_> RogerHaase: hello
  26 2015-01-31T15:36:04  <RogerHaase> pjoshi_: moin
  27 2015-01-31T15:36:32  <pjoshi_> Finally done with the result of the issue #455
  28 2015-01-31T15:36:33  <pjoshi_> :P
  29 2015-01-31T15:39:11  <RogerHaase> yes, I saw, did you update your pull request?
  30 2015-01-31T15:40:15  <pjoshi_> Naa, waiting for tw's confirmation
  31 2015-01-31T15:40:33  <pjoshi_> As all the tests are running perfectly
  32 2015-01-31T15:41:57  <RogerHaase> he said OK if the tests ran.  So update your pull request.  Easiest way is to delete your old public repo and create another
  33 2015-01-31T15:43:00  <pjoshi_> RogerHaase: I updated my repo last time from the main repo of moin
  34 2015-01-31T15:43:35  <pjoshi_> should I now directly push the changes on my repo and then sent a pull request to main repo ?
  35 2015-01-31T15:45:37  <RogerHaase> you agree your current public repo has a bad commit?  https://bitbucket.org/prakhar126/moin-2.0/commits/cdbf074a96c22e6fbb3d465ad3a6f5ee99eb45b8
  36 2015-01-31T15:46:30  <pjoshi_> yeah.. okay let me delete this and fork again from the main repo
  37 2015-01-31T15:54:36  <pjoshi_> RogerHaase: That stylus bug is still there
  38 2015-01-31T15:54:37  <pjoshi_> :/
  39 2015-01-31T15:55:40  <RogerHaase> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/484/lessc-220-omits-comments-from-basic-static
  40 2015-01-31T15:56:45  <pjoshi_> as in an extra file of css is created in the pull request https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/245/global-index-url-correction/diff
  41 2015-01-31T15:59:34  <RogerHaase> why did you add .directory and normalize.css files to your commit?
  42 2015-01-31T16:00:18  <pjoshi_> I just did hg add .
  43 2015-01-31T16:00:45  <pjoshi_> Let me correct it again
  44 2015-01-31T16:00:58  <pjoshi_> (irritating stuff :/ )
  45 2015-01-31T16:02:00  <RogerHaase> learning hg always takes a while, try to follow the docs and complain if they are wrong or misleading
  46 2015-01-31T16:02:52  <pjoshi_> RogerHaase: Okay got it.
  47 2015-01-31T16:06:54  *** greg_f has joined #moin-dev
  48 2015-01-31T16:41:01  *** pjoshi_ has quit IRC
  49 2015-01-31T17:25:34  *** Guest70091 is now known as sunu
  50 2015-01-31T19:21:34  *** greg_f has quit IRC
  51 2015-01-31T20:11:07  <RogerHaase> ThomasWaldmann: fix #449 Traceback after clicking Save button on User Settings Personal Tab  https://codereview.appspot.com/192660043/
  52 2015-01-31T21:44:27  *** RogerHaase has left #moin-dev
  53

MoinMoin: MoinMoinChat/Logs/moin-dev/2015-01-31 (last edited 2015-01-31 07:45:03 by IrcLogImporter)