1 2015-08-18T00:20:27 *** yask
2 2015-08-18T07:17:22 *** vipul20
3 2015-08-18T07:54:20 *** greg_f
4 2015-08-18T11:33:43 *** jhermann
5 2015-08-18T11:55:44 *** yask
6 2015-08-18T11:58:11 *** yask
7 2015-08-18T11:58:30 *** yask
8 2015-08-18T12:33:36 *** dave_largo
9 2015-08-18T12:58:38 *** vipul20
10 2015-08-18T13:03:44 *** vipul20
11 2015-08-18T14:26:51 <ThomasWaldmann> waldi: i am still out-of-city at a customer and might be on the road at meeting time, can you manage the meeting?
12 2015-08-18T14:31:56 <waldi> nope, i'm out also
13 2015-08-18T14:50:25 *** jhermann
14 2015-08-18T14:58:22 *** Cthulhux-
15 2015-08-18T14:59:42 *** Cthulhux`
16 2015-08-18T15:53:39 *** skathpalia
17 2015-08-18T15:54:15 <skathpalia> moin
18 2015-08-18T15:57:38 <vipul20> moin
19 2015-08-18T15:59:16 * ThomasWaldmann just returned
20 2015-08-18T15:59:27 <ThomasWaldmann> so, who's here?
21 2015-08-18T15:59:48 *** skathpalia
22 2015-08-18T15:59:52 <vipul20> moin
23 2015-08-18T16:01:34 <ThomasWaldmann> ok, welcome to our weekly meeting
24 2015-08-18T16:01:40 <ThomasWaldmann> vipul20: please begin
25 2015-08-18T16:01:55 <ThomasWaldmann> (ajitesh, are you with us?)
26 2015-08-18T16:02:26 <ThomasWaldmann> hm, we just lost skathpalia as it sems
27 2015-08-18T16:02:27 <vipul20> #DONE
28 2015-08-18T16:02:27 <vipul20> fixed issue of comment tree: implemented indentend comment/reply threads
29 2015-08-18T16:02:27 <vipul20> CR: https://codereview.appspot.com/256840043
30 2015-08-18T16:02:27 <vipul20> Advanced search CR pending: https://codereview.appspot.com/256230043
31 2015-08-18T16:02:27 <vipul20> #TODO
32 2015-08-18T16:02:28 <vipul20> commit the CRs !
33 2015-08-18T16:02:45 <vipul20> need review for both the CRs
34 2015-08-18T16:03:01 <yask> moin
35 2015-08-18T16:03:10 <ThomasWaldmann> i am looking at the tree building one
36 2015-08-18T16:04:19 <vipul20> I did it like (comment, indent) pair so the indent is actually the padding by which it would be indented
37 2015-08-18T16:05:57 <ThomasWaldmann> do you have a screenshot of the new output?
38 2015-08-18T16:06:24 <vipul20> http://i.imgur.com/0HKK3Sk.png
39 2015-08-18T16:07:24 <ThomasWaldmann> CR updated
40 2015-08-18T16:08:45 <ThomasWaldmann> ok, looks good :)
41 2015-08-18T16:09:26 *** skathpalia
42 2015-08-18T16:09:28 <ThomasWaldmann> what happens if it gets nested rather deeply?
43 2015-08-18T16:10:36 <vipul20> didn't try for more than 10 thread deep
44 2015-08-18T16:10:38 <ThomasWaldmann> and is the amount it is using for indentation somehow different between first/second/third level?
45 2015-08-18T16:11:13 <vipul20> I've kept it same for every level
46 2015-08-18T16:11:34 <ThomasWaldmann> but on your screenshot it looks different
47 2015-08-18T16:12:11 <vipul20> for the first reply its more then its same for every comment
48 2015-08-18T16:12:31 <ThomasWaldmann> I'ld suggest to always use same amount
49 2015-08-18T16:12:41 <ThomasWaldmann> (and the smaller one of both)
50 2015-08-18T16:12:56 <vipul20> ok I'll correct it
51 2015-08-18T16:13:42 <ThomasWaldmann> also, you can make processing simpler by treating the first level of comments as reply_to to ticket text (ticket itemid)
52 2015-08-18T16:13:50 <ThomasWaldmann> then you only have 1 root
53 2015-08-18T16:14:23 <ThomasWaldmann> wb skathpalia
54 2015-08-18T16:14:35 <ThomasWaldmann> skathpalia: vvv
55 2015-08-18T16:14:53 <ThomasWaldmann> 18:02 vipul20$ #DONE
56 2015-08-18T16:14:53 <ThomasWaldmann> 18:02 vipul20$ fixed issue of comment tree: implemented indentend comment/reply threads
57 2015-08-18T16:14:56 <ThomasWaldmann> 18:02 vipul20$ CR: https://codereview.appspot.com/256840043
58 2015-08-18T16:14:58 <ThomasWaldmann> 18:02 vipul20$ Advanced search CR pending: https://codereview.appspot.com/256230043
59 2015-08-18T16:15:01 <ThomasWaldmann> 18:02 vipul20$ #TODO
60 2015-08-18T16:15:05 <ThomasWaldmann> 18:02 vipul20$ commit the CRs !
61 2015-08-18T16:15:07 <ThomasWaldmann> 18:02 vipul20$ need review for both the CRs
62 2015-08-18T16:15:22 <vipul20> skathpalia: also the screenshot http://i.imgur.com/0HKK3Sk.png
63 2015-08-18T16:15:30 <ThomasWaldmann> (but I've also noted that on CR)
64 2015-08-18T16:15:52 <skathpalia> This looks good
65 2015-08-18T16:16:10 <skathpalia> but may be can have one level of reply
66 2015-08-18T16:16:43 <skathpalia> I mean there is a comment and users can add multiple replies to the single comment
67 2015-08-18T16:16:44 <ThomasWaldmann> the hex ids of course could go away as soon as this has stabilized, as it is now also visualized
68 2015-08-18T16:16:55 <skathpalia> similar to what is implemented in facebook
69 2015-08-18T16:17:19 <ThomasWaldmann> skathpalia: explain what it means for non-facebookers
70 2015-08-18T16:18:24 <ThomasWaldmann> vipul20: also, you will not need to "search" this root, as you already have it
71 2015-08-18T16:18:49 <skathpalia> I mean if we implement it the way it is done by vipul20 then the UI becomes a bit tidy
72 2015-08-18T16:19:07 <ThomasWaldmann> the reply link still could get some button-like style
73 2015-08-18T16:19:20 <skathpalia> If there is only one level of comments, it would look good also according to me
74 2015-08-18T16:19:40 <vipul20> but don't we need to get the root comments initially ? which refers to ticket's itemid ?
75 2015-08-18T16:19:48 <ThomasWaldmann> skathpalia: with one level you mean flat vs threaded?
76 2015-08-18T16:20:00 <skathpalia> not flat
77 2015-08-18T16:20:35 <ThomasWaldmann> vipul20: root it the ticket itemid itself then, assuming your 1st level of comments has reply_to=ticket_itemid
78 2015-08-18T16:20:36 <skathpalia> e.g. if I add a comment, then users can reply to that comment only
79 2015-08-18T16:20:48 <skathpalia> They cannnot add reply to the earlier reply
80 2015-08-18T16:21:01 <skathpalia> like this
81 2015-08-18T16:21:04 <skathpalia> comment1
82 2015-08-18T16:21:12 <skathpalia> reply1
83 2015-08-18T16:21:12 <vipul20> http://i.imgur.com/RzO9mpT.png
84 2015-08-18T16:21:19 <vipul20> oh sorry to spoil that
85 2015-08-18T16:21:21 <skathpalia> reply2
86 2015-08-18T16:21:29 <skathpalia> comment1
87 2015-08-18T16:21:35 <skathpalia> reply1
88 2015-08-18T16:21:37 <skathpalia> reply2
89 2015-08-18T16:21:39 <skathpalia> reply3
90 2015-08-18T16:21:44 <skathpalia> like this
91 2015-08-18T16:22:00 <ThomasWaldmann> so i cant reply to reply1?
92 2015-08-18T16:22:05 <skathpalia> yeah
93 2015-08-18T16:22:12 <ThomasWaldmann> not good (imho)
94 2015-08-18T16:23:28 <skathpalia> If you think UI wise then you may find the 1-level reply method better
95 2015-08-18T16:23:35 <ThomasWaldmann> that forces one to create a bad structure if one wants to reply to a reply
96 2015-08-18T16:24:18 <ThomasWaldmann> (and you will have to manually refer to the other post somehow, to make it clear to what you reply)
97 2015-08-18T16:24:52 <ThomasWaldmann> vipul20: you'll add some style to reply link?
98 2015-08-18T16:25:02 <skathpalia> yeah may be
99 2015-08-18T16:25:10 <ThomasWaldmann> so it look like a small button?
100 2015-08-18T16:25:12 <vipul20> like button ?
101 2015-08-18T16:25:14 <vipul20> ok
102 2015-08-18T16:25:50 <ThomasWaldmann> blog update is in the works? last one is 2weeks old
103 2015-08-18T16:26:29 <vipul20> yes I thought this will be the final one so I'll update it when I get finished
104 2015-08-18T16:27:08 <ThomasWaldmann> when would that be?
105 2015-08-18T16:27:54 <vipul20> maybe I should update it today and will update it again later
106 2015-08-18T16:28:01 <vipul20> I'll update it today
107 2015-08-18T16:28:08 <ThomasWaldmann> ok, thanks
108 2015-08-18T16:28:51 <ThomasWaldmann> skathpalia: did you recently try the code from the other CR?
109 2015-08-18T16:29:09 <skathpalia> which cr?
110 2015-08-18T16:29:18 <ThomasWaldmann> https://codereview.appspot.com/256230043
111 2015-08-18T16:30:24 <skathpalia> I think I didn't try the patch 3 of this
112 2015-08-18T16:30:36 <skathpalia> will try it tonight
113 2015-08-18T16:30:55 <ThomasWaldmann> ok, (please update CR with the results then)
114 2015-08-18T16:31:10 <ThomasWaldmann> any questions to / from vipul20 ?
115 2015-08-18T16:31:18 <vipul20> no
116 2015-08-18T16:31:20 <skathpalia> no
117 2015-08-18T16:31:59 <ThomasWaldmann> btw, yesterday was "suggested pencils down" date
118 2015-08-18T16:32:47 <ThomasWaldmann> and 21. august is the final deadline, so all stuff that is finished and working should be committed by then
119 2015-08-18T16:33:39 <ThomasWaldmann> vipul20: yask: make sure you don't miss the deadlines and also not to blow up things in the last minute. :)
120 2015-08-18T16:34:16 <ThomasWaldmann> ok, thanks vipul20, yask your stage now.
121 2015-08-18T16:34:39 <ThomasWaldmann> waldi: ^
122 2015-08-18T16:34:48 <yask> DONE:
123 2015-08-18T16:34:48 <yask> Committed all the changes after CR review
124 2015-08-18T16:34:48 <yask> Separated markitup plugin from the project by creating xstatic-markitup (https://pypi.python.org/pypi/XStatic-MarkitUp)
125 2015-08-18T16:34:48 <yask> Repo:(https://bitbucket.org/yask123/xstatic-markitup)
126 2015-08-18T16:34:48 <yask> NEXT:
127 2015-08-18T16:34:48 <yask> css optimisations
128 2015-08-18T16:36:14 <ThomasWaldmann> vipul20: yask: if it looks like you are running out of time with making the code ready, I could live with a blog update directly after the pencils down deadline.
129 2015-08-18T16:37:03 <yask> okkey!
130 2015-08-18T16:38:31 <ThomasWaldmann> vipul20: yask: also, please make sure to be available on IRC until the review's deadline is over, just in case there are questions.
131 2015-08-18T16:38:45 <yask> sure!
132 2015-08-18T16:38:53 <vipul20> yes sure
133 2015-08-18T16:39:14 <ThomasWaldmann> ah, nice, more xstatic stuff
134 2015-08-18T16:39:40 <ThomasWaldmann> yask: did you try installing moin from scratch with pulling all the dependencies from pypi?
135 2015-08-18T16:39:50 <yask> Yes, I did that!
136 2015-08-18T16:40:16 <ThomasWaldmann> btw, when you release stuff, you can also gpg sign it. that makes sure people can verify it is untampered as you made it.
137 2015-08-18T16:41:10 <yask> Okkey! cool!.
138 2015-08-18T16:41:22 <ThomasWaldmann> XStatic-MarkitUp
139 2015-08-18T16:41:23 <ThomasWaldmann> --------------
140 2015-08-18T16:41:32 <ThomasWaldmann> there are 2 - missing
141 2015-08-18T16:41:44 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-MarkitUp < there
142 2015-08-18T16:42:30 <yask> 2 missing?
143 2015-08-18T16:42:47 <ThomasWaldmann> --
144 2015-08-18T16:42:59 <ThomasWaldmann> so it really underlines
145 2015-08-18T16:43:19 <yask> ah! Okkey! I'll fix it
146 2015-08-18T16:43:50 <ThomasWaldmann> https://codereview.appspot.com/259260043 this is the CR where all the stuff was mixed up, right?
147 2015-08-18T16:44:15 <ThomasWaldmann> so can you make one where it is not mixed up?
148 2015-08-18T16:44:19 <yask> Yes!
149 2015-08-18T16:44:22 <ronny> sup
150 2015-08-18T16:44:38 <ThomasWaldmann> hey ronny ;)
151 2015-08-18T16:44:48 <ronny> hmm, im overworking myself a bit
152 2015-08-18T16:45:05 <ThomasWaldmann> summer of code final meeting before deadline right now :)
153 2015-08-18T16:45:13 <ronny> oh ::)
154 2015-08-18T16:45:25 <ronny> then please continue, see you at the devroom in sankt augustin
155 2015-08-18T16:45:42 <ThomasWaldmann> yeah, I'll be there :)
156 2015-08-18T16:46:26 <ThomasWaldmann> yask: the yes referred to 1st or 2nd question?
157 2015-08-18T16:47:14 <ThomasWaldmann> https://codereview.appspot.com/259250043/ < this one did not get any mentor comment yet?
158 2015-08-18T16:47:37 <yask> yea, I had committed that change, I removed those files in next commit: https://bitbucket.org/yask123/moin-2.0/commits/11494d859dcba8dd3aa778c668dd64c88815e80f
159 2015-08-18T16:48:28 <yask> skathpalia: reviewed it
160 2015-08-18T16:48:29 <ThomasWaldmann> ok
161 2015-08-18T16:49:05 <ThomasWaldmann> (maybe always leave some comment on CR and if only "OK")
162 2015-08-18T16:50:40 <ThomasWaldmann> yask: ok, so all your CRs are committed?
163 2015-08-18T16:51:22 <yask> Yes!
164 2015-08-18T16:51:44 <ThomasWaldmann> good ;)
165 2015-08-18T16:52:20 <ThomasWaldmann> vipul20: as time is running out, I suggest you also commit everything that works before the deadline.
166 2015-08-18T16:53:01 <ThomasWaldmann> as a general comment, your mentors will just pull your code and play with it in the final review process
167 2015-08-18T16:53:04 <vipul20> Ok
168 2015-08-18T16:53:19 <ThomasWaldmann> you can do that on your own too, to avoid having them find all the remaining bugs :D
169 2015-08-18T16:53:59 <ThomasWaldmann> esp. avoid missing files (maybe do a from-scratch install yourself to play with)
170 2015-08-18T16:54:09 <yask> Okkey!
171 2015-08-18T16:54:14 <ThomasWaldmann> or code that tracebacks or just does not work
172 2015-08-18T16:54:27 <ThomasWaldmann> or severe ugliness :)
173 2015-08-18T16:55:21 <ThomasWaldmann> always look at it from the perspective of somebody who would work with the code (as a developer and as a practical user)
174 2015-08-18T16:55:53 <ThomasWaldmann> for your python code, run py.test --pep8
175 2015-08-18T16:56:27 <ThomasWaldmann> you will have to submit a overall diff of all your code to google
176 2015-08-18T16:56:55 <ThomasWaldmann> actually reading that diff yourself might make you find some issues (or some stuff you forgot)
177 2015-08-18T16:57:49 <ThomasWaldmann> https://moinmo.in/GoogleSoc2014 < see the hg commands there and find out the right hash to start with
178 2015-08-18T16:58:06 <ThomasWaldmann> and the first who finds out, please update the 2015 page accordingly
179 2015-08-18T16:58:57 <ThomasWaldmann> ok, anything left to / from yask?
180 2015-08-18T16:59:04 <yask> No
181 2015-08-18T17:00:19 <ThomasWaldmann> as ajitesh and waldi are not here: skathpalia?
182 2015-08-18T17:02:08 <ThomasWaldmann> btw, the mentors please keep in mind to look at the result rather early after the pencils down
183 2015-08-18T17:02:31 <ThomasWaldmann> the PSF deadlines are earlier than the google deadlines for the final review
184 2015-08-18T17:02:59 <ThomasWaldmann> ok, looks like skathpalia has no more questions.
185 2015-08-18T17:03:20 <ThomasWaldmann> thanks for attending the last coding phase meeting
186 2015-08-18T17:03:39 <ThomasWaldmann> use the rest of the time wisely
187 2015-08-18T17:51:54 *** greg_f
188 2015-08-18T18:27:43 *** Cthulhux-
189 2015-08-18T18:27:43 *** Cthulhux-
190 2015-08-18T19:10:28 *** yask
191 2015-08-18T19:13:32 *** skathpalia
192 2015-08-18T21:03:24 *** dave_largo
193
