Description

The OpenID server doesn't seem to be working. I get always a "403 No request" message when I try to log in to any website. Even if I try to explicitly pass a request, it gives me the same error message.

Steps to reproduce

1. Any usage of the openid server should reproduce the bug.

Example

Component selection

• general

Details

Workaround

Discussion

I don't run the openid code on my sites, Rowan, can you help here? -- ThomasWaldmann 2009-12-08 11:10:04

Haven't tried the OP in Moin for a long time now. The error is probably because of the change in Moin 1.9's Request objects. (Made the changes in the RP but not OP). -- RowanKerr 2009-12-15 05:41:00

This appears to fix it for me, but I have no idea whether it is correct:

diff --git a/MoinMoin/action/serveopenid.py b/MoinMoin/action/serveopenid.py
index 59548a6..341c9f8 100644
--- a/MoinMoin/action/serveopenid.py
+++ b/MoinMoin/action/serveopenid.py
@@ -170,7 +170,7 @@ class MoinOpenIDServer:
     def handle(self):
         _ = self._
         request = self.request
-        form = request.form
+        form = request.values
 
         username = request.page.page_name
         if 'openid.user' in request.page.pi:

-- JohannesBerg 2009-12-15 13:14:17

request.form is POSTed form data only, request.args is URL args only, request.values is both mixed.

• Well I think it wants mixed ... whatever request.form used to be before some change changed the variable meaning? (seriously, don't make API changes like that w/o renaming things!) -- JohannesBerg 2009-12-15 16:04:15

There is another request.form in handle_response - do you think we need .values there also?

• Possible, that might even explain ../OpenIDExistingBroken. -- JohannesBerg 2009-12-15 21:46:03

Better to use request.values everywhere as you can't guarantee how the external site will send OpenID parameters to your OP (GET vs POST) -- RowanKerr 2009-12-18 03:02:00

The patch fixes the problem for me. -- TiagoPeixoto 2024-11-21 20:07:06

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.9/rev/581cdc260b90

CategoryMoinMoinBugFixed